| *** mhen_ is now known as mhen | 01:52 | |
| *** ykarel_ is now known as ykarel | 07:40 | |
| jlejeune | hello bauzas, sean-k-mooney[m], gibi and others :) I would like to backport my changes related to these topics: https://review.opendev.org/q/topic:%22bug-2044235%22 and https://review.opendev.org/q/topic:%22bug/2085135%22, what do you think about them ? thanks | 07:52 |
|---|---|---|
| gibi | jlejeune: I did some reviews in both series now, and had couple of +2 but both series has some minor issues in later backports so I left -1es later | 08:17 |
| jlejeune | gibi: checking, thanks | 08:37 |
| opendevreview | Masahito Muroi proposed openstack/nova-specs master: Add spec for virtio-blk multiqueue extra_spec https://review.opendev.org/c/openstack/nova-specs/+/951636 | 08:38 |
| masahito | sean-k-mooney[m]: Uggla: gibi: Thanks for the review in the last development cycle for the multiqueue. I resumed the upstream patch update b/c the Gazpacho development cycle was open :) | 08:42 |
| opendevreview | Merged openstack/nova stable/2025.2: Adds regression test for bug LP#2044235 https://review.opendev.org/c/openstack/nova/+/961948 | 08:58 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Fix fill_metadata usage for the ImagePropertiesWeigher https://review.opendev.org/c/openstack/nova/+/963358 | 09:10 |
| bauzas | gibi: gmaan had a few good comments on https://review.opendev.org/c/openstack/nova/+/963358 I just rebased it | 09:10 |
| opendevreview | Merged openstack/nova stable/2025.2: Update start_service() function in test https://review.opendev.org/c/openstack/nova/+/963842 | 09:16 |
| opendevreview | Merged openstack/nova stable/2025.2: Adds regression test for bug LP#2085135 https://review.opendev.org/c/openstack/nova/+/963843 | 09:16 |
| opendevreview | Masahito Muroi proposed openstack/nova-specs master: Add spec for virtio-blk multiqueue extra_spec https://review.opendev.org/c/openstack/nova-specs/+/951636 | 09:37 |
| opendevreview | Merged openstack/nova stable/2025.2: Reset the mapped field of nodes at service deletion https://review.opendev.org/c/openstack/nova/+/963844 | 11:00 |
| gibi | bauzas: ack I will check it | 12:24 |
| opendevreview | Balazs Gibizer proposed openstack/placement stable/2025.2: Reproduce GET a_c slowness bug/2126751 https://review.opendev.org/c/openstack/placement/+/964219 | 14:19 |
| opendevreview | Balazs Gibizer proposed openstack/placement stable/2025.2: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/964220 | 14:19 |
| opendevreview | Balazs Gibizer proposed openstack/placement stable/2025.1: Reproduce GET a_c slowness bug/2126751 https://review.opendev.org/c/openstack/placement/+/964221 | 14:24 |
| opendevreview | Balazs Gibizer proposed openstack/placement stable/2025.1: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/964222 | 14:24 |
| opendevreview | Balazs Gibizer proposed openstack/placement stable/2024.2: Reproduce GET a_c slowness bug/2126751 https://review.opendev.org/c/openstack/placement/+/964223 | 14:25 |
| opendevreview | Balazs Gibizer proposed openstack/placement stable/2024.2: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/964224 | 14:25 |
| gibi | dansmith: I've pushed the stable backports of the placment fix | 14:26 |
| gibi | when you have time please take look. They are all clean cherry-picks | 14:26 |
| gibi | https://review.opendev.org/q/topic:%22bug/2126438%22 and https://review.opendev.org/q/topic:%22bug/2126751%22+project:openstack/placement | 14:27 |
| dansmith | okay I'm really slammed today and I have a bunch of glance things I just got poked for in the meeting just now | 14:27 |
| gibi | sure, no worries we are not in a rush with these backports | 14:27 |
| dansmith | might be good if some other people could just do the low-impact work of validating the backports | 14:27 |
| gibi | I pinged you as you have the context and Sean is on PTO. But yeah this is easy to review for any cores | 14:28 |
| dansmith | ack | 14:28 |
| jlejeune | gibi:about your remark on my cherry-pick, the change is not the same on other stable branches because you 've introduced that new line in test_service.py in that change https://review.opendev.org/c/openstack/nova/+/947245 and it's not been backported on other stable branches | 14:38 |
| gibi | jlejeune: cool, please note that in the commit message of the patch that first has this difference | 14:40 |
| gibi | this is a common pattern we do to help the reviewers to know that the difference is not a mistake but intentional | 14:41 |
| jlejeune | gibi: ok my bad, doing | 14:42 |
| gibi | no worries. If you never see such backport commit message that needed this then there is no way to know how we handle it | 14:44 |
| jlejeune | do you have an example in mind ? | 14:46 |
| opendevreview | Julien Le Jeune proposed openstack/nova stable/2025.1: Update start_service() function in test https://review.opendev.org/c/openstack/nova/+/963845 | 14:54 |
| opendevreview | Julien Le Jeune proposed openstack/nova stable/2025.1: Adds regression test for bug LP#2085135 https://review.opendev.org/c/openstack/nova/+/963846 | 14:54 |
| opendevreview | Julien Le Jeune proposed openstack/nova stable/2025.1: Reset the mapped field of nodes at service deletion https://review.opendev.org/c/openstack/nova/+/963847 | 14:54 |
| jlejeune | gibi: something like that ? ^ | 14:56 |
| gibi | jlejeune: yepp, look good. thanks | 15:10 |
| gmaan | bauzas: +w now. though i replied for the test comment but that is just comment things actual assert in test is correct so no issue. | 15:27 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [doc]PCI in Placement tuning https://review.opendev.org/c/openstack/nova/+/963281 | 15:41 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func]Test with optimize_for_wide_provider_trees https://review.opendev.org/c/openstack/nova/+/963036 | 17:03 |
| *** bauzas9 is now known as bauzas | 19:35 | |
| opendevreview | Merged openstack/nova master: Fix fill_metadata usage for the ImagePropertiesWeigher https://review.opendev.org/c/openstack/nova/+/963358 | 23:56 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!