| obre | Hi! There is a BP (add-amx-traits) thats been lying around since 2023, which describes a feature I would like to see in nova, and that I guess Im able to implement. The BP is not approved, and posted by someone else. Should I in some way update the BP and assign it to myself, or should I create a new one to get it approved and then Implemented? | 08:02 |
|---|---|---|
| mkuroha | gibi: Please take another look when you have time. I’ve addressed your comments. https://review.opendev.org/c/openstack/nova/+/948304 | 08:17 |
| ykarel | bauzas, auniyal can you check os-vif release patch https://review.opendev.org/c/openstack/releases/+/975181 | 08:41 |
| elodilles | auniyal bauzas Uggla : hi, sorry for pinging, but there are a couple of release patches that would require a release liaison review o:) if you have some spare time, then please take a look: https://review.opendev.org/q/project:openstack/releases+reviewer:self+is:open | 10:03 |
| gibi | gmaan: thanks for the review on the eventlet removal side. I see you went back and forth about waiting for the deadline of the currently waited for task. I think I have a way out of that debate. Currently the libvirt driver will cancel() all the outstanding tasks on the executor then shut it down. So at shutdown the executor can be awaken, check if the current task is cancelled or not then decide | 11:15 |
| gibi | what to do. This way a cancelled task's deadline does not need to be waited for | 11:16 |
| opendevreview | Merged openstack/nova stable/2025.2: Reproduce bug/2130881 https://review.opendev.org/c/openstack/nova/+/975162 | 12:01 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Use an executor to delay STOPPED events https://review.opendev.org/c/openstack/nova/+/974445 | 12:48 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Cleanup libvirt driver at service stop https://review.opendev.org/c/openstack/nova/+/975128 | 12:48 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Fix full executor warning on noname executor https://review.opendev.org/c/openstack/nova/+/975172 | 12:48 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467 | 12:48 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: DNM:Test with oslo.vmware + compute eventlet removal patches https://review.opendev.org/c/openstack/nova/+/973468 | 12:48 |
| gibi | gmaan: ^^ improvement is up. I will still need to do a cleanup round on the patches (e.g. moving prints to log) | 12:49 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Use an executor to delay STOPPED events https://review.opendev.org/c/openstack/nova/+/974445 | 13:58 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Cleanup libvirt driver at service stop https://review.opendev.org/c/openstack/nova/+/975128 | 13:58 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Fix full executor warning on noname executor https://review.opendev.org/c/openstack/nova/+/975172 | 13:58 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467 | 13:58 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: DNM:Test with oslo.vmware + compute eventlet removal patches https://review.opendev.org/c/openstack/nova/+/973468 | 13:58 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Cleanup libvirt driver at service stop https://review.opendev.org/c/openstack/nova/+/975128 | 14:05 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Fix full executor warning on noname executor https://review.opendev.org/c/openstack/nova/+/975172 | 14:05 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467 | 14:05 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: DNM:Test with oslo.vmware + compute eventlet removal patches https://review.opendev.org/c/openstack/nova/+/973468 | 14:05 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Remove spawn_after https://review.opendev.org/c/openstack/nova/+/975396 | 14:05 |
| gibi | gmaan: and now the cleanups are also done | 14:06 |
| gibi | gmaan: hold on I'm seeing issuess | 14:20 |
| dansmith | gibi: did you see my response on the async detach patch and asking you for clarification? | 14:32 |
| gibi | dansmith: not yet, but I will check now... | 14:33 |
| gibi | dansmith: I replied | 14:45 |
| dansmith | ack | 14:46 |
| gibi | you basically answered my question, we have no issue here, I only have a minor request to translate 500 to 503 | 14:48 |
| * dansmith nods | 14:49 | |
| opendevreview | Merged openstack/nova stable/2025.2: Init virt driver before use https://review.opendev.org/c/openstack/nova/+/975163 | 14:50 |
| Uggla | Reminder, nova meeting in ~30mn | 15:26 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Use an executor to delay STOPPED events https://review.opendev.org/c/openstack/nova/+/974445 | 15:51 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Remove spawn_after https://review.opendev.org/c/openstack/nova/+/975396 | 15:51 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Cleanup libvirt driver at service stop https://review.opendev.org/c/openstack/nova/+/975128 | 15:51 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Fix full executor warning on noname executor https://review.opendev.org/c/openstack/nova/+/975172 | 15:51 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467 | 15:51 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: DNM:Test with oslo.vmware + compute eventlet removal patches https://review.opendev.org/c/openstack/nova/+/973468 | 15:51 |
| gibi | gmaan: ^^ this should better now, I promise :) | 15:52 |
| opendevreview | Merged openstack/nova stable/2025.1: Reproduce bug/2130881 https://review.opendev.org/c/openstack/nova/+/975164 | 15:56 |
| Uggla | #startmeeting nova | 16:01 |
| opendevmeet | Meeting started Mon Feb 2 16:01:58 2026 UTC and is due to finish in 60 minutes. The chair is Uggla. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:01 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:01 |
| opendevmeet | The meeting name has been set to 'nova' | 16:01 |
| Uggla | Hello everyone | 16:02 |
| erlon | \o | 16:02 |
| gibi | o/ | 16:02 |
| erlon | hey | 16:02 |
| lajoskatona | o/ | 16:02 |
| bauzas | o/ | 16:02 |
| gmaan | o/ | 16:02 |
| elodilles | o/ | 16:02 |
| fwiesel | \o | 16:03 |
| dansmith | oj | 16:03 |
| Uggla | Let's start | 16:03 |
| Uggla | #topic Bugs (stuck/critical) | 16:03 |
| Uggla | #info No Critical bug | 16:03 |
| tkajinam | o/ | 16:03 |
| Uggla | #topic Gate status | 16:03 |
| Uggla | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:04 |
| Uggla | #link https://etherpad.opendev.org/p/nova-ci-failures-minimal | 16:04 |
| Uggla | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&branch=stable%2F*&branch=master&pipeline=periodic-weekly&skip=0 Nova&Placement periodic jobs status | 16:04 |
| Uggla | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:04 |
| Uggla | #info Please try to provide a meaningful comment when you recheck | 16:04 |
| Uggla | Shame on me, I have not looked at the gate today, anything special with it ? | 16:04 |
| gmaan | nova-alt-configurations is fixed now | 16:05 |
| gmaan | tempest change is merged, so feel free to recheck for this failure | 16:05 |
| gmaan | #link https://review.opendev.org/c/openstack/tempest/+/975356 | 16:05 |
| Uggla | ok gmaan, good to know and thanks | 16:07 |
| Uggla | anything else ? | 16:07 |
| bauzas | - | 16:07 |
| Uggla | ok so moving on | 16:08 |
| Uggla | #link https://releases.openstack.org/gazpacho/schedule.html | 16:08 |
| Uggla | oops | 16:08 |
| Uggla | #topic Release Planning | 16:08 |
| Uggla | #link https://releases.openstack.org/gazpacho/schedule.html | 16:08 |
| Uggla | #info Nova deadlines are set in the above schedule | 16:08 |
| Uggla | #info 4 weeks before feature freeze | 16:09 |
| Uggla | #info PTG etherpad for 2026.1 is available: https://etherpad.opendev.org/p/nova-2026.1-ptg | 16:09 |
| Uggla | #topic Review priorities | 16:09 |
| Uggla | #link https://etherpad.opendev.org/p/nova-2026.1-status | 16:09 |
| Uggla | #info I have updated Launchpad and the above doc. Please ping me if you spot something missing. | 16:09 |
| bauzas | ++ | 16:10 |
| Uggla | TBH, I'm a bit worried by the vTPM series. | 16:10 |
| Uggla | Is there still some things that needs to be clarified discussed ? | 16:11 |
| Uggla | Does an adhoc meeting could help ? | 16:11 |
| bauzas | mel and dan are not here | 16:11 |
| bauzas | afaics | 16:11 |
| bauzas | so let's discuss this when they're back | 16:11 |
| bauzas | oh, sorry, at least mel, dan is here | 16:12 |
| Uggla | bauzas, from your perspective could an adhoc meeting help ? | 16:12 |
| * Uggla maybe worried too much, but would like to avoid same pattern as last cycle. | 16:13 | |
| dansmith | eh? | 16:14 |
| bauzas | yes and no, I reviewed the series, maybe melwitt could change the relationship, but that's not an issue IMHO | 16:14 |
| dansmith | I've been tied up with other stuff for the last week, but I think it's moving forward | 16:14 |
| bauzas | I'm continuing to review the series | 16:14 |
| Uggla | dansmith, bauzas, good if you think it is progressing. | 16:15 |
| Uggla | ok I don't want to bother you more about it, if you think it is ok. | 16:15 |
| Uggla | moving on | 16:15 |
| Uggla | #topic OpenAPI | 16:16 |
| Uggla | #link: https://review.opendev.org/q/topic:%22openapi%22+(project:openstack/nova+OR+project:openstack/placement)+-status:merged+-status:abandoned | 16:16 |
| Uggla | #info still 11 remaining atm. (-3) | 16:16 |
| Uggla | #topic Stable Branches | 16:16 |
| * Uggla giving the mic to elodilles | 16:16 | |
| elodilles | thanks | 16:17 |
| elodilles | first of all, thanks bauzas for your nova release liaison reviews ;) a couple of stable/2024.2 releases merged today (nova, placement, os-vif) | 16:17 |
| elodilles | otherwise, | 16:17 |
| elodilles | #info stable gates seem to be in good state | 16:17 |
| elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | 16:17 |
| elodilles | and that's all from me | 16:17 |
| * elodilles passing back the mic | 16:17 | |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove tpm supoort detection for libvirt < 8.0.0 https://review.opendev.org/c/openstack/nova/+/952308 | 16:18 |
| Uggla | thanks elodilles and thanks bauzas for the reviews. | 16:18 |
| elodilles | ++ | 16:18 |
| Uggla | #topic vmwareapi 3rd-party CI efforts Highlights | 16:19 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Drop redundant chown of tpm data directory https://review.opendev.org/c/openstack/nova/+/962446 | 16:19 |
| Uggla | fwiesel do you have something to share ? | 16:19 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove tpm supoort detection for libvirt < 8.0.0 https://review.opendev.org/c/openstack/nova/+/952308 | 16:20 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Drop redundant chown of tpm data directory https://review.opendev.org/c/openstack/nova/+/962446 | 16:20 |
| fwiesel | No, nothing from my side. Working on getting the cross-project dependencies in | 16:20 |
| Uggla | fwiesel ok thanks | 16:20 |
| Uggla | #topic Gibi's news about eventlet removal | 16:20 |
| * Uggla giving the mic to gibi | 16:21 | |
| gibi | o/ | 16:21 |
| gibi | Last week fwiesel reported issues from the compute eventlet removal series | 16:21 |
| gibi | I'm fixed one problem https://review.opendev.org/c/openstack/nova/+/975172/5?usp=related-change | 16:21 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: AMD SEV: omit iommu='on' for virtio devices https://review.opendev.org/c/openstack/nova/+/909635 | 16:22 |
| gibi | and found a deeper one https://review.opendev.org/c/openstack/nova/+/965467/48#message-62f7ef828c38c33f322f72737b4016ace9b9f242 | 16:22 |
| bauzas | ack, will look at them | 16:22 |
| gibi | The second is not resolved yet but I have plans to fix it | 16:22 |
| gibi | other than that the improvement on the event delaying mechanism is now ready to (re)-review https://review.opendev.org/c/openstack/nova/+/974445/12 | 16:23 |
| bauzas | yup, on my plan | 16:23 |
| gibi | and I think that is it | 16:23 |
| gibi | Uggla: mic is back to you | 16:23 |
| gmaan | nice, I will check it. It was ok both way for me as i commented in that change | 16:24 |
| gmaan | i saw the next change in that series where libvirt driver was canceling all the submitted event during shutdown which is better. | 16:24 |
| Uggla | thanks gibi. | 16:24 |
| gmaan | but I will check the latest change | 16:24 |
| Uggla | #topic Open discussion | 16:24 |
| erlon | hey Uggla | 16:25 |
| erlon | hey today :) | 16:25 |
| * Uggla giving the mic to erlon | 16:25 | |
| erlon | *here | 16:25 |
| erlon | first, sorry about missing the previous meeting. I dropped in the topic but couldn't attend. | 16:25 |
| erlon | I have a customer who wants this bug fixed. After some investigation, I concluded that what is currently affecting them is bug #1741364, which is a different manifestation of a similar problem: the VM devices not being updated if the Ceph monitors change during the virtual machines' lifetime. | 16:26 |
| erlon | #link https://bugs.launchpad.net/nova/+bug/1452641 | 16:26 |
| erlon | Bug #1741364 addresses the ephemeral part of it, while bug #1452641 deals with Cinder volume devices. | 16:27 |
| erlon | #link launchpad.net/bugs/1741364 | 16:27 |
| erlon | With that said, I want to get some feedback regarding a potential fix for the issue: https://review.opendev.org/c/openstack/nova/+/974032 | 16:28 |
| erlon | I believe we don't need anything fancy; we just need to ensure that the ephemeral disk information is also updated whenever we do that for the RBD volumes. I think that change is close to what we need, but I was also considering whether it would be possible to patch nova-manage to allow batch operations, just like we do for volume attachments. | 16:28 |
| erlon | so, I suppose nobody opposes :p | 16:32 |
| gibi | :) | 16:32 |
| Uggla | erlon, I guess everybody needs to load context too. | 16:33 |
| tkajinam | so the point is that you don't want to stop and start the vm and looking for the way to update mon addrs keeping vms running ? | 16:33 |
| bauzas | yeah | 16:33 |
| tkajinam | if you stop and start the vm then I guess xml is regenerated and picks up the new mon addrs (correct me if I'm wrong) | 16:33 |
| erlon | tkajinam: starting and stopping the VMs should be okay, actually I don't think should be possible to update the block device mapping without stopping. | 16:34 |
| tkajinam | ah, ok | 16:35 |
| erlon | tkajinam: so, that behaves like you're saying for the volume attachments. But if the virtual machine has ephemeral devices back it by RBD, those are not refreshed. The ask is to, make them behave like volumes. | 16:35 |
| erlon | so, when you shelve, or migrate, you would get all volume mappings (cinder and ephemeral) updated (today only cinders are) | 16:37 |
| tkajinam | sounds fair | 16:38 |
| Uggla | erlon to my mind that sounds reasonable. I will add this patch to the review list. | 16:38 |
| erlon | right, thanks. I will do a full review on it as well since I believe there's a few bits missing. And I'll propose something for nova-manage | 16:39 |
| Uggla | ok | 16:40 |
| erlon | nova-manage volume_attachment refresh --ephemeral [INSTANCE_UUID] [VOLUME_ID] [CONNECTOR_PATH] | 16:40 |
| erlon | or | 16:40 |
| erlon | nova-manage ephemeral_attachments refresh [INSTANCE_UUID] | 16:40 |
| tkajinam | I'm wondering if a few other operations can resolve it. I feel like only providing live-migration to fix bdm would be incomplete from operator's perspective | 16:40 |
| erlon | The first, would mix concepts (volume vs ephemeral), but in my opinion would make a smoother for the user experience. The second is more consistent, what would require more code and a new command | 16:41 |
| tkajinam | (and we may want a similar functionality in cold migration path for example | 16:41 |
| Uggla | erlon I would rather the second, but that's just a feeling. | 16:43 |
| erlon | tkajinam: right, today, for volume we only have the functionality on migrate, resize and re-attach (shelve), are you thinking on something else? | 16:43 |
| tkajinam | erlon, no the list looks good for start. if we extend it we also have to extend the refresh mechanism for cinder volumes, likely | 16:45 |
| tkajinam | and I personally tend to support the 2nd approach given ephemeral volumes are handled slightly different from cinder volumes and I don't want to confuse users to find out which options can be used for resources | 16:46 |
| tkajinam | for example volume id is not needed for ephemeral volumes | 16:47 |
| Uggla | tkajinam ++ | 16:47 |
| erlon | yeah, I also believe that the current operations should be okay, since it is mostly a point in time operation. As long as the operator have a way to update the VMs they should be fine. | 16:47 |
| Uggla | erlon, something else ? | 16:47 |
| erlon | ok | 16:47 |
| gibi | sounds sane | 16:47 |
| erlon | thats all from me | 16:47 |
| Uggla | thanks erlon | 16:48 |
| Uggla | I guess lajoskatona wanted to share someting ? | 16:48 |
| lajoskatona | Uggla: thanks, I have :-) | 16:48 |
| * Uggla giving the mic to lajoskatona | 16:48 | |
| lajoskatona | o/ | 16:49 |
| lajoskatona | I started to work on the migration away from neutronclient calls to SDK ones, and I have few patches up for review: | 16:49 |
| lajoskatona | https://review.opendev.org/q/topic:%22sdk_for_neutron%22 | 16:49 |
| lajoskatona | The last one for ports is red currently, I have to revisit it when I will have time | 16:49 |
| lajoskatona | I tried to do small patches, each one covers one neutron API element, like networks or subnets | 16:50 |
| lajoskatona | and it would be really helpful if I have feedback if the overall direction is good or any suggestion in review | 16:51 |
| gibi | i will try to start reviewing them | 16:51 |
| Uggla | me too. | 16:52 |
| lajoskatona | thanks. I believe teh logic under remained the same, I just changed from what SDK returns instead of the dicts returned by neutronclient | 16:52 |
| gibi | can we put a recurring topic about this on the agenda? | 16:53 |
| lajoskatona | the other "big" difference are the exceptions as Neutronclient has some real exotic ones, and I tried to cover those with exceptions from SDK | 16:53 |
| gibi | (just to help me remember) | 16:53 |
| Uggla | gibi sure. | 16:54 |
| lajoskatona | that can work, we do the same in Neutron meeting for this topic when I have more for review | 16:54 |
| gibi | Uggla: thanks | 16:54 |
| lajoskatona | thanks for the time | 16:54 |
| Uggla | lajoskatona did you checked what was done for manila regarding sdk ? | 16:54 |
| lajoskatona | yes, I checked in the past but not deeply | 16:55 |
| MaxLamprecht[m] | o/ Uggla I have also one additional topic | 16:55 |
| Uggla | MaxLamprecht[m] do you think you can cover it in 5mn ? | 16:56 |
| lajoskatona | that's it from me for SDK | 16:56 |
| Uggla | thanks lajoskatona | 16:56 |
| MaxLamprecht[m] | sure | 16:56 |
| Uggla | ok MaxLamprecht[m], so please go ahead | 16:56 |
| MaxLamprecht[m] | I am working on resolving some inconsistencies between bdms/cinder-attachments that are happening regulary in our environment. | 16:56 |
| MaxLamprecht[m] | I have these MRs incl. regression tests. Would be great to get review :) https://review.opendev.org/c/openstack/nova/+/972045 https://review.opendev.org/c/openstack/nova/+/974832 https://review.opendev.org/c/openstack/nova/+/934984 | 16:56 |
| Uggla | MaxLamprecht[m], I have put them on the review list. | 16:58 |
| Uggla | it looks like you have reproducer so it is cool | 16:58 |
| MaxLamprecht[m] | I am currently investigating every single cause of these "out of sync" states in our env and try to fix the root causes. Maybe I will come up with more MRs in the next weeks/months. | 16:58 |
| MaxLamprecht[m] | thanks | 16:58 |
| Uggla | MaxLamprecht[m] something else to add ? | 16:59 |
| MaxLamprecht[m] | nop thats everything :) thx | 16:59 |
| Uggla | good thanks. It is time to close because we are at the top of the hour. | 17:00 |
| Uggla | Thanks for joining this meeting. Have a nice day/evening and see you next week. | 17:01 |
| Uggla | #endmeeting | 17:01 |
| opendevmeet | Meeting ended Mon Feb 2 17:01:09 2026 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 17:01 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2026/nova.2026-02-02-16.01.html | 17:01 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2026/nova.2026-02-02-16.01.txt | 17:01 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2026/nova.2026-02-02-16.01.log.html | 17:01 |
| gibi | thanks | 17:01 |
| lajoskatona | Bye, o/ | 17:01 |
| bauzas | thanks | 17:01 |
| * Uggla moving away because my daughter does not feel well. | 17:02 | |
| elodilles | thanks o/ | 17:02 |
| elodilles | Uggla: :S i hope she gets well soon | 17:05 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove tpm support detection for libvirt < 8.0.0 https://review.opendev.org/c/openstack/nova/+/952308 | 17:16 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Drop redundant chown of tpm data directory https://review.opendev.org/c/openstack/nova/+/962446 | 17:17 |
| opendevreview | melanie witt proposed openstack/nova master: DNM test volume snapshot NFS https://review.opendev.org/c/openstack/nova/+/956282 | 17:33 |
| opendevreview | Merged openstack/nova stable/2025.1: Init virt driver before use https://review.opendev.org/c/openstack/nova/+/975165 | 17:36 |
| gmaan | gibi: on graceful shutdown, this is ready . I have abandon the DB, object change for the new topic field https://review.opendev.org/c/openstack/nova/+/975242 | 17:38 |
| gmaan | bauzas: ^^ | 17:38 |
| gibi | gmaan: ack, I will circle back | 17:41 |
| gmaan | thanks | 17:41 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Remove eventlet from CacheConcurrencyTestCase https://review.opendev.org/c/openstack/nova/+/970069 | 18:09 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Remove eventlet from libvirt/test_driver https://review.opendev.org/c/openstack/nova/+/970070 | 18:09 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Remove eventlet from libvirt/volume/test_mount https://review.opendev.org/c/openstack/nova/+/970071 | 18:09 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Speed up RetryDecorator in unit test https://review.opendev.org/c/openstack/nova/+/975443 | 18:09 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Speed up RetryDecorator in unit test https://review.opendev.org/c/openstack/nova/+/975443 | 18:12 |
| gibi | gmaan: the first graceful patch looks good to me I just have a question about RPC minor version / service version https://review.opendev.org/c/openstack/nova/+/975242/4#message-96014581a53a1bfc9a6dbc419832eb7dd61dac46 | 18:19 |
| gmaan | gibi: yes, I am planning to bump that when new RPC server/new topic will be in use in compute service | 18:21 |
| gmaan | because that is the time, we need to handle the old vs new compute via versioning or fallback etc | 18:22 |
| gibi | gmaan: OK make sense | 18:23 |
| gibi | I just wanted to be sure we will do it | 18:24 |
| gibi | my +2 stands :) | 18:24 |
| gmaan | yeah, thanks | 18:24 |
| gmaan | gibi: checked the STOPPED events change, its looks nice now. I left one comment about calculating the remaining_delay while it wait for shutdown condition https://review.opendev.org/c/openstack/nova/+/974445/comment/597be334_afaa6a5f/ | 18:52 |
| gibi | gmaan: thanks you have a good point. I will fix it tomorrow | 19:26 |
| sean-k-mooney | gibi: would you mind adding https://review.opendev.org/c/openstack/nova/+/975171/1 and https://review.opendev.org/c/openstack/nova/+/973149 to your review list for tomorrow | 19:28 |
| gibi | sean-k-mooney: done :) | 19:30 |
| gibi | I mean the first one is done | 19:31 |
| gibi | the second will need my fresh brain tomorrow | 19:31 |
| sean-k-mooney | thanks :) | 19:33 |
| dansmith | gibi: can I have you for a sec? | 19:38 |
| dansmith | fresh brain probably not required | 19:38 |
| gmaan | gibi: ack | 19:51 |
| dansmith | nevermind I think | 19:53 |
| opendevreview | Merged openstack/nova master: Add regression test to repoduce bug 2139351 https://review.opendev.org/c/openstack/nova/+/975171 | 20:07 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!