| *** ykarel__ is now known as ykarel | 04:28 | |
| LarsErikP | sean-k-mooney: oh! Thank you so much for creating the reproducer for the BFV bug! | 07:04 |
|---|---|---|
| obre | Are nova-tests known to be a bit flaky? https://review.opendev.org/c/openstack/nova/+/976390 fails on two tests; and I cannot see that the fails are related to the patch? | 07:06 |
| *** Callum0271 is now known as Callum027 | 07:49 | |
| sean-k-mooney | obre: in gerneal no but there are a number of diffent gate issues at the moment | 10:52 |
| sean-k-mooney | obre: we try to keep the stable but tere are a few things that are sort of out of our contol like kernel panics on volume attach/detach which are qemu bugs that we are stuck with | 10:52 |
| obre | Then I guess its fair to attempt a recheck if I suspect such issues? | 11:27 |
| sean-k-mooney | yes our only real ask is that you look at the failures, try to determin if they look related to the patch and either note what teh failrue was or state that it looks unrelated when you recheck | 11:30 |
| sean-k-mooney | i.e. `recheck un related ssh time out in <[test|job] name> | 11:30 |
| sean-k-mooney | ` | 11:30 |
| sean-k-mooney | we have a script that count bare `recheck` comments we basilly just want to know if folks see the same test fail often because that proably means we need to go fix it | 11:31 |
| obre | Ack. And this is simply done by a "reply" in the review.opendev.org page? | 11:33 |
| sean-k-mooney | ya you just leave a comment via the web you ui so recheck follow by anythin else. recheck needs to be the first word on the first line | 11:34 |
| obre | The recheck for 976390 went fine for the first test that failed (An ssh auth failure in nova-multi-cell), but the second thest that failed with a POST_FAILURE was nova-live-migration-ceph which seems to complain about issues stopping libvirt in the controller is still failing. I cant understand how my change affects that, and Im not sure to where to start trying to debug the | 14:40 |
| obre | fail. I am still suspecting the test to fail because of something else. Do anyone have some hints/pointers of what I should do? | 14:40 |
| sean-k-mooney | that proably not related to your change and weill need to be investaged sepreatly. it would be good to check the build history of the job and see if there are ohter failures currently | 14:41 |
| sean-k-mooney | you can do that in the zuul ui if you click on the failed job there is a build history link | 14:42 |
| obre | There is at least 4 other changes which have failed in the same way the last 2 days. | 14:45 |
| sean-k-mooney | ack then its proably a sideeffect fo the ci breakges we had this week | 14:47 |
| sean-k-mooney | for now if most test are passing you can leave yoru reivew as is until we have tiem to review it next week | 14:48 |
| obre | Test-wise all tests are passing except for nova-live-migration-ceph with a POST_FAILURE and openstack-tox-py313-arm64 with a RETRY_LIMIT; but the last one is also non-voting. Then all leave the review as is; and keep an eye on irc the next week. Thanks a lot for all the responses sean-k-mooney! | 14:50 |
| opendevreview | Lajos Katona proposed openstack/nova master: Fix for bug 2140537 https://review.opendev.org/c/openstack/nova/+/975934 | 14:56 |
| dansmith | bauzas: waiting on one +W from you on the bottom vTPM set to merge three of them | 15:28 |
| dansmith | if there's something else to be addressed that's cool, but just wanted to point it out | 15:28 |
| dansmith | the object is only used by host mode, which is +2+W | 15:28 |
| dansmith | nicolairuckel: please remove all the unrelated damage to existing code in your patch and then I'll be happy to approve | 15:36 |
| dansmith | I made comments to identify them | 15:37 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Fix bound https://review.opendev.org/c/openstack/nova/+/971038 | 16:18 |
| stephenfin | sean-k-mooney: ^ | 16:18 |
| stephenfin | forgot about that | 16:18 |
| sean-k-mooney | oh right that latent bug | 16:22 |
| sean-k-mooney | +1 for now becauyse it looks correct ill loop back on monday | 16:23 |
| sean-k-mooney | once ci has passed | 16:23 |
| * stephenfin +2s as the patch won't merge if CI says no and it's easy to forget about patches otherwise 🤷 | 16:24 | |
| stephenfin | but that's just me | 16:24 |
| opendevreview | Pierre-Samuel Le Stang proposed openstack/nova master: This is a reproducer bug for #2130429 https://review.opendev.org/c/openstack/nova/+/976764 | 16:25 |
| sean-k-mooney | stephenfin: i do that if i have run the tox tests locally or otherwse smoke cheked it but im trying nto to get too side tracked today | 16:26 |
| stephenfin | I'm curious: what do you gain by not +2ing if you've done your review and are satified with it? | 16:28 |
| stephenfin | (I did run this one locally, fwiw, but that's besides the point here) | 16:28 |
| sean-k-mooney | well in this just confiming it passes but not much | 16:29 |
| sean-k-mooney | im mostly just distacted at the moment so not +2ing out of habbit | 16:30 |
| stephenfin | fair fair | 16:30 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove errant field https://review.opendev.org/c/openstack/nova/+/976765 | 16:34 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (5/6) https://review.opendev.org/c/openstack/nova/+/956239 | 16:51 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (6/6) https://review.opendev.org/c/openstack/nova/+/956240 | 16:51 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server shares APIs https://review.opendev.org/c/openstack/nova/+/956266 | 16:51 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Invert validation check https://review.opendev.org/c/openstack/nova/+/956241 | 16:51 |
| stephenfin | sean-k-mooney: another one for next week: I made a tiny change to https://review.opendev.org/c/openstack/nova/+/956239/10..11 based on failing tests from tempest | 16:52 |
| stephenfin | (it aligns us with the show server view, which is what update server uses under the hood) | 16:52 |
| sean-k-mooney | ack | 16:54 |
| sean-k-mooney | ill see if i can do a full pass early next week remind me if i dont | 16:55 |
| opendevreview | Pierre-Samuel Le Stang proposed openstack/nova master: Reset file position on Glance upload retry https://review.opendev.org/c/openstack/nova/+/976766 | 17:04 |
| opendevreview | Lajos Katona proposed openstack/nova master: Fix for bug 2140537 https://review.opendev.org/c/openstack/nova/+/975934 | 17:17 |
| opendevreview | Nicolai Ruckel proposed openstack/nova master: Preserve UEFI NVRAM variable store https://review.opendev.org/c/openstack/nova/+/959682 | 20:17 |
| opendevreview | Nicolai Ruckel proposed openstack/nova master: Preserve UEFI NVRAM variable store https://review.opendev.org/c/openstack/nova/+/959682 | 20:22 |
| nicolairuckel | dansmith: sorry, I missed your ping here. Thanks again! You're 3D printing comment really threw me off a bit and I tried to google that in case I missed something. :D | 22:30 |
| opendevreview | Nicolai Ruckel proposed openstack/nova master: Preserve UEFI NVRAM variable store https://review.opendev.org/c/openstack/nova/+/959682 | 22:55 |
| *** haleyb is now known as haleyb|out | 23:42 | |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!