| opendevreview | Masanori Kuroha proposed openstack/nova master: Copy applied provider config https://review.opendev.org/c/openstack/nova/+/948304 | 01:52 |
|---|---|---|
| opendevreview | Masanori Kuroha proposed openstack/nova master: Copy applied provider config https://review.opendev.org/c/openstack/nova/+/948304 | 01:53 |
| opendevreview | Ashish Gupta proposed openstack/nova master: Run functional test with threading mode https://review.opendev.org/c/openstack/nova/+/979850 | 05:52 |
| opendevreview | Ashish Gupta proposed openstack/nova master: Disable greenlet-based notifier sender check under native threading temporarily https://review.opendev.org/c/openstack/nova/+/985621 | 05:52 |
| stephenfin | gibi: sean-k-mooney: Morning 👋 Before the PTG kicks off, could I get some eyes on https://review.opendev.org/c/openstack/nova/+/985506? It's trivial but needed to unblock an u-c bump for o.vo | 09:03 |
| gibi | stephenfin: done | 09:22 |
| stephenfin | gibi++ ty 🙏 | 09:23 |
| *** sambork_ is now known as sambork | 09:30 | |
| DominikDanelski[m] | I missed signing-up for the virtual PTG for 2026.2. Doest that mean that adding https://review.opendev.org/q/topic:%22bp/numa-topology-with-rps%22 (NUMA Topology with Resource Providers) is dead in the water? Are specs / code changes reviewed, if they haven't been added to the agenda? | 11:15 |
| sean-k-mooney | DominikDanelski[m]: no, the ptg is for gaining concencous not for approving any specific feaute | 11:20 |
| sean-k-mooney | so 1 it cna still happen via the normal spec review process and 2 if there is time it can still be included in the ptg adgenda | 11:20 |
| sean-k-mooney | the main issue i have with the current code is the reqrite of numa_fit_instance_to_host | 11:22 |
| sean-k-mooney | it not clear to me that you fully undersstood what that fucniton was ment to do in the context of numa in placment | 11:23 |
| sean-k-mooney | in the numa filtier its role is to determin if a given allcoation candiate can fullifle the the numa request so we can filter the canidate in the host state object | 11:25 |
| sean-k-mooney | in the compute manger/resocue tracker claim its role i sgieve a singel allcoation candate generate the full instnac enuma toplogy and confirm its still valid | 11:26 |
| sean-k-mooney | that code was intentially written in a functional style so that it was a pure input of the parmater with no sideffect which is why the object oriatneted rewrite makes it harder to revew as it break the mental model we had for that code | 11:27 |
| sean-k-mooney | even if the code is effectivly equvlent https://review.opendev.org/c/openstack/nova/+/971176/9/nova/virt/hardware.py is an invaisve rewrite | 11:27 |
| opendevreview | Anton Iacobaeus proposed openstack/nova-specs master: Intel TDX support in libvirt driver https://review.opendev.org/c/openstack/nova-specs/+/979608 | 11:35 |
| DominikDanelski[m] | sean-k-mooney: Did you see my reply in https://review.opendev.org/c/openstack/nova/+/971176/1/nova/virt/hardware.py#b2509? I think the change to the overall logic is not as significant as it may look from the lines of diff, but I asked about your input there and I'm open to changes if you provide direction for them. | 11:38 |
| sean-k-mooney | i did but again because it fundemtnally change the organstaion of the code i have not had tiem to fully unlopad all my expecations fo how that code shoudl work adn rereview it based on yoru changes | 11:47 |
| sean-k-mooney | as i said that refactoring makes it a lot harder to review your change | 11:47 |
| sean-k-mooney | if you wanted to make that easier to review you would do the refactor in its own patch that does not change any exisitng behivor. although im not entirly conveice that is the correct move. it would make it much clear what is jsut a refactorign vs behvior change | 11:50 |
| opendevreview | Esra Ozkan proposed openstack/nova master: Check volume status before live migration https://review.opendev.org/c/openstack/nova/+/973750 | 12:13 |
| opendevreview | Elod Illes proposed openstack/nova stable/2025.2: fix: device_by_alias should respect config type https://review.opendev.org/c/openstack/nova/+/984920 | 12:22 |
| sean-k-mooney | Uggla: so its a little disapointing that the lack fo openstack client and sdk? supprot for nova share attatchment was not coverd in teh manilla cross project session | 12:24 |
| sean-k-mooney | Uggla: i dont think we shoudl apcpate any new feature there really until that gap is closed | 12:24 |
| sean-k-mooney | i dont object to any of the feature but without afctully coing that gap so you dont have to use curl im not sure we should keep exteneding it | 12:24 |
| sean-k-mooney | oh... | 12:25 |
| sean-k-mooney | sorry i msiste it | 12:25 |
| Uggla | sean-k-mooney, good news the sdk and client were merged, it was the first topic of yesterday meeting. | 12:25 |
| sean-k-mooney | ya i ddint see that initally | 12:25 |
| sean-k-mooney | all good then | 12:25 |
| Uggla | sean-k-mooney, gouthamr take over this and manage to cross the finish line. | 12:26 |
| Uggla | sean-k-mooney no worries. | 12:27 |
| Uggla | sean-k-mooney, also carloss presented good progress on the testing side. | 12:29 |
| sean-k-mooney | shoudl i ask if said testing found bugs or not | 12:30 |
| Uggla | sean-k-mooney, I would say yes at least one I'm aware of it --> 984802: Set instance to ERROR state on start_instance power_on failure | https://review.opendev.org/c/openstack/nova/+/984802 | 12:33 |
| carloss | sean-k-mooney: yep, the change Uggla linked was an issue gouthamr ran into. but so far, in the scenario (end to end) tests I have implemented, no further bugs found | 12:40 |
| carloss | this is a job run using manila's cephfs native: https://zuul.opendev.org/t/openstack/build/f761d9016979435abe69c849a645ebc2 | 12:40 |
| carloss | I'm still figuring out why LVM (with NFS) is failing on CI because it's passing in a local env I have - so I think there's some mismatch in the env I own compared to the CI | 12:41 |
| carloss | the share attachment tests are under the TestShareAttachmentCEPHFS class | 12:41 |
| sean-k-mooney | Uggla: oh the resoume on host boot feature | 12:44 |
| sean-k-mooney | ya im betting we didnt re attach the share or something? | 12:45 |
| sean-k-mooney | that woudl have been easy to miss | 12:45 |
| opendevreview | Merged openstack/nova master: objects: Prepare for oslo.versionedobjects 3.10.0 https://review.opendev.org/c/openstack/nova/+/985506 | 12:48 |
| DominikDanelski[m] | sean-k-mooney: OK, so I propose that we split the change in 2: first the behaviour change without the signature change (extending the function's behaviour at the expense of making it long), then the split which would end in the current state. It would be hard to show the refactor without the reason it's being done (extending behaviour). | 12:54 |
| *** clarkb is now known as Guest7683 | 13:48 | |
| opendevreview | Karol Klimaszewski proposed openstack/nova-specs master: Spec for SPDK-based nova-provisioned storage backend https://review.opendev.org/c/openstack/nova-specs/+/985676 | 13:56 |
| tkajinam | as it's not likely we have time to discuss this... I wonder if that namespace package thing is what we broken when we removed pkg_resources ? | 13:59 |
| tkajinam | I intended to keep that functionality but that was later broken by canonical folks insisting "this doesn't work for us" | 14:00 |
| tkajinam | I might be confused by https://review.opendev.org/c/openstack/nova/+/939827 , though | 14:00 |
| tkajinam | ok it seems nova.scheduler.filters has never been exposed as a namespace package | 14:01 |
| tkajinam | we probably want to use the entrypoints approach instead | 14:01 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: test if CLI testing hitting scatter gather https://review.opendev.org/c/openstack/nova/+/985681 | 14:20 |
| opendevreview | Karol Klimaszewski proposed openstack/nova-specs master: Spec for SPDK-based nova-provisioned storage backend https://review.opendev.org/c/openstack/nova-specs/+/985676 | 14:30 |
| *** Guest7683 is now known as clarkb | 14:57 | |
| cardoe | Thanks all for having the Ironic folks. | 15:04 |
| opendevreview | Goutham Pacha Ravi proposed openstack/nova-specs master: Add spec for virtiofs hot attach and detach https://review.opendev.org/c/openstack/nova-specs/+/983816 | 15:15 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: test if CLI testing hitting scatter gather https://review.opendev.org/c/openstack/nova/+/985681 | 16:43 |
| cardoe | dansmith: I think my comments were misconstrued a little bit and I'd like to clear things up. | 18:07 |
| -opendevstatus- NOTICE: The wiki.openstack.org service will be offline for a few minutes while we perform a database upgrade | 18:07 | |
| cardoe | There's a number of users / operators of the nova-ironic driver that I'm aware of. That driver hasn't been a prime focus of the nova cores team so a lot of times patches kinda stall out a little bit. The testing for that driver in Zuul isn't the best as was highlighted during the call. | 18:09 |
| cardoe | So what I'm doing is trying to get those users / operators to share some changes together that are important to them and trying to figure out the best way for us to voice that "this bug/issues is important to that group" | 18:10 |
| cardoe | The reason for the repo idea is that more than once it's happened that I've spoken to one of them and they've said "oh we've iterated on the patch a little bit and use a new version". So just trying to come up with a way for them to do that more in the open. | 18:11 |
| dansmith | cardoe: sounds pretty much like what you said on the call (although the context around it at the time is the important but). Sounds like a fork to me, which doesn't seem very constructive... | 18:17 |
| dansmith | but, you don't need to convince me, I responded to your comment in the moment in the context of the moment | 18:18 |
| cardoe | Can you give me suggestions how we get fixes that are important to the users of nova-ironic landed? | 18:21 |
| opendevreview | Bryan Fraschetti proposed openstack/nova master: Reject to attach and detach volume while task_state is not None https://review.opendev.org/c/openstack/nova/+/758918 | 18:23 |
| opendevreview | Bryan Fraschetti proposed openstack/nova master: Feat: Add Command for Forceful BDM Deletion https://review.opendev.org/c/openstack/nova/+/985717 | 18:23 |
| opendevreview | Bryan Fraschetti proposed openstack/nova master: add task state for attach volume and detach volume https://review.opendev.org/c/openstack/nova/+/985718 | 18:23 |
| opendevreview | Bryan Fraschetti proposed openstack/nova master: Reject Volume Attachment if task_state not Attaching https://review.opendev.org/c/openstack/nova/+/985719 | 18:23 |
| sean-k-mooney | ok im goign to call it a day. ill be in the watcher session most fo tomorrow but if im meeded for a session ping me and ill try an attend | 18:25 |
| cardoe | https://bugs.launchpad.net/nova/+bug/1884217 https://bugs.launchpad.net/nova/+bug/1732506 (mentioned by johngarbutt during the session) https://bugs.launchpad.net/nova/+bug/2127087 https://bugs.launchpad.net/nova/+bug/2085432 https://bugs.launchpad.net/nova/+bug/2131095 https://bugs.launchpad.net/nova/+bug/2148059 https://bugs.launchpad.net/nova/+bug/2117700 | 18:33 |
| cardoe | That's just the list of bugs that I'm aware of that operators have mentioned | 18:33 |
| cardoe | I don't have a list of gerrit patches handy | 18:35 |
| melwitt | gmaan: dunno if you might be able to shed any light on this, but in CI the nova.tests.functional.test_servers.ServerMovingTestsWithNestedResourceRequests.test_resize_reschedule_uses_host_lists_3_fails test has been flaking out and I can't see why, | 18:44 |
| melwitt | the last messages in the traceback are graceful shutdown stuff and I assume they're not related, but I wondered what you might think. example: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_af0/openstack/af0437afd3354ef990fcb3d6aa47f80a/testr_results.html | 18:44 |
| *** erlon0 is now known as erlon | 19:33 | |
| opendevreview | Goutham Pacha Ravi proposed openstack/nova-specs master: Add spec for virtiofs hot attach and detach https://review.opendev.org/c/openstack/nova-specs/+/983816 | 20:12 |
| gmaan | let me check | 21:52 |
| gmaan | melwitt: it seems all nova services are shutdown in between of tests. | 22:13 |
| gmaan | functional tests override the graceful shutdown to 0 so shutdown will be immediately without waiting for things to finish and that is why server is stuck in that state | 22:14 |
| gmaan | not sure why shutdown happen | 22:14 |
| melwitt | gmaan: thanks for looking. so this is unexpected? that is a good clue for me to continue debugging | 22:15 |
| gmaan | yeah, shutdown itself should not be initiated in between of test | 22:16 |
| opendevreview | Goutham Pacha Ravi proposed openstack/nova-specs master: Add virtiofs live migration spec https://review.opendev.org/c/openstack/nova-specs/+/983801 | 22:57 |
| opendevreview | Goutham Pacha Ravi proposed openstack/nova-specs master: Add spec for virtiofs live migration https://review.opendev.org/c/openstack/nova-specs/+/983801 | 23:01 |
| opendevreview | Goutham Pacha Ravi proposed openstack/nova-specs master: Add virtiofs cold migration spec https://review.opendev.org/c/openstack/nova-specs/+/985738 | 23:01 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!