| opendevreview | Sam Morrison proposed openstack/nova master: Filter out deleted instances when looking for build timouts https://review.opendev.org/c/openstack/nova/+/880125 | 00:09 |
|---|---|---|
| opendevreview | Merged openstack/nova master: Fix port remain while error on update port with multi network https://review.opendev.org/c/openstack/nova/+/983672 | 01:14 |
| opendevreview | Artem Vasilyev proposed openstack/nova master: Fix race between resize and update_available_resource for dedicated CPUs https://review.opendev.org/c/openstack/nova/+/984048 | 07:26 |
| opendevreview | Artem Vasilyev proposed openstack/nova master: Add reproducer for bug #2147776 https://review.opendev.org/c/openstack/nova/+/984007 | 07:26 |
| opendevreview | Joan Gilabert proposed openstack/nova-specs master: Repropose and update cyborg vGPU (mdev) support https://review.opendev.org/c/openstack/nova-specs/+/967515 | 10:41 |
| opendevreview | Maximilian Stinsky proposed openstack/nova master: Remove experimental warning from UnifiedLimitsDriver https://review.opendev.org/c/openstack/nova/+/989102 | 11:39 |
| opendevreview | Stephen Finucane proposed openstack/os-vif master: zuul: Disable cinder jobs https://review.opendev.org/c/openstack/os-vif/+/989113 | 12:07 |
| stephenfin | sean-k-mooney: Is that what you were suggesting? ^ | 12:13 |
| sean-k-mooney | more or less yes | 12:13 |
| sean-k-mooney | i have 3 or 4 other memory optimisation patches in flight to neturon and devstack too | 12:13 |
| sean-k-mooney | to help out but that is a quick and easy win | 12:14 |
| sean-k-mooney | if we disable it in the vars section i dont think we need to replciate that ot subnodes but it will fail if we do and we can add it | 12:15 |
| sean-k-mooney | i think all the os-vif jobs are single node anyway | 12:16 |
| opendevreview | Matt Crees proposed openstack/nova master: Don't drop pci_dev network caps when VF is in use https://review.opendev.org/c/openstack/nova/+/982660 | 12:42 |
| opendevreview | Matt Crees proposed openstack/nova master: Add test_update_devices_preserves_vf_network_caps https://review.opendev.org/c/openstack/nova/+/989121 | 12:42 |
| opendevreview | Matt Crees proposed openstack/nova master: Add test_update_devices_preserves_vf_network_caps https://review.opendev.org/c/openstack/nova/+/989121 | 13:07 |
| opendevreview | Matt Crees proposed openstack/nova master: Don't drop pci_dev network caps when VF is in use https://review.opendev.org/c/openstack/nova/+/982660 | 13:07 |
| *** ykarel_ is now known as ykarel | 13:13 | |
| opendevreview | Merged openstack/os-vif master: zuul: Disable cinder jobs https://review.opendev.org/c/openstack/os-vif/+/989113 | 15:11 |
| opendevreview | sean mooney proposed openstack/nova master: Add regression test for unified limits resource bug https://review.opendev.org/c/openstack/nova/+/975859 | 15:11 |
| opendevreview | sean mooney proposed openstack/nova master: Fix unified limits to include all resource types https://review.opendev.org/c/openstack/nova/+/975872 | 15:11 |
| sean-k-mooney | melwitt: i think i adressed all your comment on https://review.opendev.org/q/topic:%22bug/2140631%22 let me know if i missed anything | 15:35 |
| melwitt | sean-k-mooney: ok nice, I will take a look | 15:36 |
| opendevreview | Matt Crees proposed openstack/nova master: Add test_update_devices_preserves_vf_network_caps https://review.opendev.org/c/openstack/nova/+/989121 | 15:40 |
| opendevreview | Matt Crees proposed openstack/nova master: Don't drop pci_dev network caps when VF is in use https://review.opendev.org/c/openstack/nova/+/982660 | 15:40 |
| Uggla | melwitt, dansmith if you can have a look at 987704: Fix resize to unpermitted flavors | https://review.opendev.org/c/openstack/nova/+/987704, that should not take long | 16:01 |
| dansmith | ? | 16:02 |
| melwitt | Uggla: it looks like that is merged already? | 16:08 |
| Uggla | melwitt, dansmith oops sory wrong CC here: I mean 988501: Do not log metadata proxy shared secret | https://review.opendev.org/c/openstack/nova/+/988501 | 16:09 |
| melwitt | Uggla: ah ok, sure I will look | 16:17 |
| sean-k-mooney | https://bugs.launchpad.net/nova/+bug/2150094 is a secuirty weakness more then a security vulnerablity | 16:24 |
| sean-k-mooney | but we shoudl avoid logging it in general | 16:25 |
| sean-k-mooney | im not sure that rotaion of the metadata_proxy_shared_secret is strictly require but it does not hurt | 16:26 |
| sean-k-mooney | elodilles: mind addign a unit test for the log message just to assert the secret is not in it. https://review.opendev.org/c/openstack/nova/+/988501 | 16:52 |
| melwitt | sean-k-mooney: thought you might find this interesting -- this is a bug that first appeared in downstream CI intermittently where I found the root cause ... but I figured it was probably too rare to prioritize. then it showed up again recently in a customer case so I proposed a fix for it https://review.opendev.org/c/openstack/nova/+/988547 you might be good to comment on it bc you know a lot about NFS | 17:07 |
| sean-k-mooney | less then you might think and more then i ever wanted | 17:07 |
| sean-k-mooney | but sure i can take a look | 17:07 |
| melwitt | heheh | 17:08 |
| sean-k-mooney | that sound liek a nfs lockign issue | 17:08 |
| sean-k-mooney | melwitt: on enit. @mock.patch('os.open', | 17:09 |
| sean-k-mooney | i belive we have mock open helper | 17:09 |
| sean-k-mooney | because mocking builting like open is a littel od | 17:09 |
| sean-k-mooney | it might be better to use that | 17:09 |
| sean-k-mooney | ill read the rest but just somthign i notced initally | 17:10 |
| melwitt | yeah in debugging the CI issue we put debug printing _everywhere_ in it and were able to confirm a false positive of the exists() call -- returned true when it was not there | 17:10 |
| melwitt | oh gotcha | 17:10 |
| melwitt | thanks, that sounds familiar. I'll go look for it | 17:10 |
| sean-k-mooney | we might have got rid of our helper since mock not does if for you | 17:12 |
| sean-k-mooney | we often do @mock.patch('builtins.open', new_callable=mock.mock_open()) | 17:12 |
| sean-k-mooney | but mocing os.open will probaly work | 17:12 |
| sean-k-mooney | melwitt: i just know that used to be a bit flaky in older version fo python so im alwasy a litte carful of it failing in the gate if we dotn do that correctly | 17:13 |
| melwitt | yeah, it's a good point | 17:14 |
| opendevreview | Maximilian Stinsky proposed openstack/nova master: Remove experimental warning from UnifiedLimitsDriver https://review.opendev.org/c/openstack/nova/+/989102 | 17:17 |
| sean-k-mooney | melwitt: so the fix si to add O_CREAT|O_EXCL | 17:17 |
| sean-k-mooney | to bypass the cache | 17:17 |
| melwitt | that is the idea. I'm not aware if there could be any possible pitfall with that or rather if there is some way that it would not work | 17:19 |
| sean-k-mooney | well the constrati woudl be if one of the open modes was not supproted by a given version of nfs or the kernel | 17:22 |
| sean-k-mooney | i dont think you are usign anyting exotic in this patch | 17:22 |
| opendevreview | Merged openstack/nova master: Reproduce bug/2152697 https://review.opendev.org/c/openstack/nova/+/988769 | 17:23 |
| sean-k-mooney | we did have to do soem O_DIRECT check for a time but apprently that was added in kernel 2.4.10 so we may not need that anymore | 17:23 |
| sean-k-mooney | O_EXCL Ensure that this call creates the file: if this flag is | 17:24 |
| sean-k-mooney | specified in conjunction with O_CREAT, and path already | 17:24 |
| sean-k-mooney | exists, then open() fails with the error EEXIST. | 17:24 |
| sean-k-mooney | ok so that is the behvior we want for the probe | 17:24 |
| sean-k-mooney | On NFS, O_EXCL is supported only when using NFSv3 or later | 17:25 |
| sean-k-mooney | on kernel 2.6 or later. | 17:25 |
| sean-k-mooney | ya i think we are good with those min versions in 2026 | 17:25 |
| melwitt | yeah from what I saw O_EXCL not exotic | 17:25 |
| melwitt | I have a couple of vtpm live migration follow up items, one small patch with corrected config help text https://review.opendev.org/c/openstack/nova/+/987312 and one small patch spec amendment to clarify secret access control language https://review.opendev.org/c/openstack/nova-specs/+/987310 for those reading the delivered spec as a reference, if anyone could help review | 17:43 |
| sean-k-mooney | melwitt: by the way there is a somewat related but to that swap/epmereal issues tha twe shoudl evengually fix | 17:53 |
| sean-k-mooney | when we created ephmeral and i belive swap disk with the qcow backend we share a backing file based on the size | 17:54 |
| sean-k-mooney | and at leasat for the ephermal disk we can format the qcow for a given vm | 17:55 |
| sean-k-mooney | but if im not mistaken that can casue filesysetm currption when we cold migrate if we resue a backign file form a diffent host | 17:56 |
| sean-k-mooney | basiclly we shoudl just never use backign files for swap and ephmeral | 17:58 |
| sean-k-mooney | https://blueprints.launchpad.net/nova/+spec/allow-disabling-ephemeral-disk-formatting was sort of related to that | 17:58 |
| sean-k-mooney | but there was bug for the actual issue somewhere | 17:59 |
| sean-k-mooney | melwitt: this https://bugs.launchpad.net/nova/+bug/2095173 | 18:01 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/940900 | 18:02 |
| sean-k-mooney | melwitt: the swap thing just reminede me we hever actly fixed that | 18:03 |
| melwitt | sean-k-mooney: ah yeah, I am aware of that general issue. good to have the links, I had not seen a bug report for it | 18:19 |
| opendevreview | Stephen Finucane proposed openstack/os-vif master: typing: Updates for typed oslo.config https://review.opendev.org/c/openstack/os-vif/+/989206 | 19:19 |
| opendevreview | Stephen Finucane proposed openstack/os-vif master: Remove linux bridge plugin https://review.opendev.org/c/openstack/os-vif/+/941586 | 19:20 |
| opendevreview | Stephen Finucane proposed openstack/os-vif master: typing: Updates for typed oslo.config https://review.opendev.org/c/openstack/os-vif/+/989206 | 19:32 |
| opendevreview | Stephen Finucane proposed openstack/os-vif master: Remove linux bridge plugin https://review.opendev.org/c/openstack/os-vif/+/941586 | 19:32 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Use static pages for eol release release notes https://review.opendev.org/c/openstack/nova/+/989210 | 19:36 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Use static pages for eom release release notes https://review.opendev.org/c/openstack/nova/+/989211 | 19:36 |
| opendevreview | Stephen Finucane proposed openstack/nova master: docs: Speed up release notes builds https://review.opendev.org/c/openstack/nova/+/989212 | 19:36 |
| stephenfin | melwitt: That should significantly speed up release notes builds. I recall you complaining about that a long time ago | 19:38 |
| stephenfin | ☝️ | 19:38 |
| melwitt | stephenfin: IIRC I added parallel build a long time ago for that :) thanks for the heads up, I will look at them | 20:27 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!