| gmaan | stephenfin: melwitt nova change for enforce_scope testing also ready https://review.opendev.org/c/openstack/nova/+/986946 | 01:59 |
|---|---|---|
| opendevreview | Kamil Sambor proposed openstack/nova master: Add concurrency_backend config option for Nova services https://review.opendev.org/c/openstack/nova/+/993760 | 10:44 |
| chandank` | sean-k-mooney: Hello, Are you still reviewing the nvme spec? Reason I am asking because I need to update the cleanup state diagram and few nit pics. Or I will wait for your feedback. | 11:42 |
| chandank` | sorry wrong channel | 11:49 |
| *** chandank` is now known as chandankumar | 11:50 | |
| opendevreview | Udayendu Kar proposed openstack/python-novaclient master: tests: skip osprofiler test when dependency is not installed https://review.opendev.org/c/openstack/python-novaclient/+/995048 | 12:42 |
| opendevreview | mitya-eremeev-2 proposed openstack/nova stable/2025.1: Replace eventlet.event.Event with threading.Event https://review.opendev.org/c/openstack/nova/+/995063 | 13:40 |
| stephenfin | gibi: sean-k-mooney: Could one of you sanity check this for me? https://review.opendev.org/c/openstack/python-openstackclient/+/995003/ | 13:41 |
| stephenfin | I assume it's fine but I've never done anything dual-stack'y like that | 13:41 |
| sean-k-mooney | you can have both if you have subnets for both on the same network | 13:43 |
| sean-k-mooney | but ill take a look now | 13:43 |
| sean-k-mooney | i am not sure if we can spcify both in nova api but if you pass a newuton port or network the the port can be assigne both | 13:44 |
| sean-k-mooney | stephenfin: hum so accordign to the api ref | 13:45 |
| gibi | I will rely on sean-k-mooney's eyes as I also never did dual stack | 13:45 |
| sean-k-mooney | networks.fixed_ip | 13:45 |
| sean-k-mooney | is ipv4 only | 13:45 |
| sean-k-mooney | A fixed IPv4 address for the NIC. Valid with a neutron or nova-networks network. | 13:45 |
| sean-k-mooney | https://docs.openstack.org/api-ref/compute/#id11 | 13:46 |
| sean-k-mooney | i will have to check the code but lookign at the fixed_ip filed there i dont see evnicne we have ever supprot ipv6 in server create | 13:47 |
| sean-k-mooney | i.e where we provide an ipv6 adress to use | 13:47 |
| sean-k-mooney | it will owrk if you pass port or netork that has an ipv6 subnet | 13:47 |
| sean-k-mooney | but we dont currently allow you to specify a subnet to create the prot on or pass an ipv6 ip | 13:48 |
| sean-k-mooney | so either the api ref is wrong (*that is possibel) or ipv6 is not suprpot in genral so the issue is not about dualstack or not at that point | 13:49 |
| sean-k-mooney | stephenfin: ok so looking at the openapi schmea you wote | 13:51 |
| sean-k-mooney | teh api accpate networks.fixed_ip but we allow that to be an ipv4 or v6 adress | 13:52 |
| sean-k-mooney | at least in the schema | 13:52 |
| sean-k-mooney | but we only support one of fixed_ip prot or uuid per network | 13:53 |
| sean-k-mooney | meainign you cant pass both for the same port | 13:53 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L283-L299 | 13:53 |
| stephenfin | I wonder can we test it somehow just to see what happens? | 13:54 |
| stephenfin | I imagine deploying dual-stack devstack is not a trivial matter 😅 | 13:54 |
| sean-k-mooney | i dont think its that terirbel you just need to create a newton networ with both | 13:55 |
| sean-k-mooney | the host does not need it | 13:55 |
| sean-k-mooney | but i can see if i have a devstack i can test it on quickly | 13:55 |
| sean-k-mooney | i think the failure mode is we dont accpet muleipel fixed ip pre netowrk object in our api. we could be i think that is why that is there | 13:59 |
| sean-k-mooney | so it snot someabout v4 or v6 | 13:59 |
| frickler | I tested it locally and indeed the v6 address does not get set | 13:59 |
| sean-k-mooney | its more that we only supprot 1 adress per port that we create | 14:00 |
| frickler | while without a fixed-ip specified, I do get both addr types | 14:00 |
| sean-k-mooney | frickler: ya it woudl change the subnet we attach too | 14:00 |
| sean-k-mooney | i think before we make the client change we woudl need a new api microverion but in the past we said if you neded somethign like ethat you shoudl precreate the neutorn port | 14:01 |
| sean-k-mooney | basiclly because we didnt wnat to keep ading proxy apis for that | 14:01 |
| sean-k-mooney | frickler: i assume you created the vm with curl? | 14:01 |
| sean-k-mooney | or did you just use the propsoed patch? | 14:02 |
| frickler | I did use the patch. against a 2024.1 admittedly | 14:03 |
| frickler | *cloud | 14:03 |
| sean-k-mooney | devstack default to a dual stack deployment https://paste.opendev.org/show/bq6cSQIBviTCgXyGkvA7/ so il test it again on that deployment which si masteris with the patch | 14:04 |
| sean-k-mooney | frickler: so what im seeitn tiwth the patch applied is regardless of the oder only the v4 adress gets applied | 14:20 |
| sean-k-mooney | https://paste.opendev.org/show/bzPsu7xQOJ0oc0fzJzSs/ | 14:20 |
| sean-k-mooney | although the vms get both v4 and v6 adresses the v6 adress is just not the one i specified | 14:21 |
| sean-k-mooney | looking at the reques boday this is what is being sent https://paste.opendev.org/show/baVOCdYizNOYiccHJmWe/ | 14:24 |
| sean-k-mooney | stephenfin: so the patch does not actlly work | 14:24 |
| sean-k-mooney | it remvoes the check but the client is still only seingi the ipv4 adress becuase i think we check the ipv4 first in the code and then dont check the ipv6 adress | 14:25 |
| sean-k-mooney | stephenfin: i marked https://bugs.launchpad.net/python-openstackclient/+bug/2152032 as invlid feel free to change that if you think that is wrong | 14:33 |
| sean-k-mooney | frickler: thanks for checking :) | 14:34 |
| stephenfin | no, that's great. thanks for looking into it :) frickler++ sean-k-mooney++ | 14:37 |
| opendevreview | Sylvain Desgrais proposed openstack/nova master: Allow security group names with leading/trailing spaces https://review.opendev.org/c/openstack/nova/+/995073 | 14:37 |
| frickler | well ... if nova accepts both v4 and v6 in the API, but then ignores one of those, arguably that's a bug that could/should get fixed an not an API change? | 14:37 |
| frickler | using a preconfigured port works, but has more drawbacks, too. like security groups also need to get applied manually to the port and are ignored during the server create call | 14:38 |
| opendevreview | Sylvain Desgrais proposed openstack/nova master: Allow security group names with leading/trailing spaces https://review.opendev.org/c/openstack/nova/+/995073 | 14:39 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Limit the port fields during security_group query https://review.opendev.org/c/openstack/nova/+/994896 | 14:49 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Detect AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/994764 | 14:57 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Support launchSecurity element for SEV-SNP https://review.opendev.org/c/openstack/nova/+/994920 | 14:57 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Omit optional fields for SEV/SEV-ES https://review.opendev.org/c/openstack/nova/+/994921 | 14:57 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Drop sev capability check in launch instance flow https://review.opendev.org/c/openstack/nova/+/994929 | 14:57 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-SNP memory encryption https://review.opendev.org/c/openstack/nova/+/994930 | 14:57 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Drop sev capability check in launch instance flow https://review.opendev.org/c/openstack/nova/+/994929 | 15:21 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: AMD SEV: omit iommu='on' for virtio devices https://review.opendev.org/c/openstack/nova/+/909635 | 15:21 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-SNP memory encryption https://review.opendev.org/c/openstack/nova/+/994930 | 15:21 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Update documentations for AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/995090 | 15:51 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Update documentations for AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/995090 | 16:13 |
| opendevreview | Merged openstack/nova master: Add regression test for bug 2062127 https://review.opendev.org/c/openstack/nova/+/976654 | 17:22 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-SNP memory encryption https://review.opendev.org/c/openstack/nova/+/994930 | 17:44 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Update documentations for AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/995090 | 17:44 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove [libvirt] num_memory_encrypted_guests https://review.opendev.org/c/openstack/nova/+/995120 | 18:02 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove [libvirt] num_memory_encrypted_guests https://review.opendev.org/c/openstack/nova/+/995120 | 18:02 |
| opendevreview | Adam Harwell proposed openstack/placement master: Add ASGI application entry point for Placement API https://review.opendev.org/c/openstack/placement/+/995129 | 19:06 |
| opendevreview | Adam Harwell proposed openstack/placement master: Add ASGI application entry point for Placement API https://review.opendev.org/c/openstack/placement/+/995133 | 19:10 |
| rm_work[m] | erk | 19:11 |
| sean-k-mooney | frickler: osc is not sending both. nova will accpet an ip in v4 or v6 format but it wont accpet multiple of them | 19:54 |
| sean-k-mooney | frickler: i have not tested it with curl but i woudl expect a 400 band request if you tried to repoeate the file of make it a list instaed of a stirng | 19:54 |
| sean-k-mooney | in the json payload | 19:54 |
| melwitt | gmaan: question on https://review.opendev.org/c/openstack/nova/+/986946 let me know if I am wrong :) | 20:02 |
| melwitt | sean-k-mooney: why did you +2 this? :) it's phrased as if it's an addition to someone else's patch but I don't see other related patches? oh, it's that you requested testing in the patch above and added it below https://review.opendev.org/c/openstack/nova/+/994437 | 20:17 |
| gmaan | melwitt: checking, I am not sure why that test does not exist in base test class and only in scope testing | 20:19 |
| melwitt | yeah, it was different than everything else seems like | 20:19 |
| opendevreview | Adam Harwell proposed openstack/placement master: Add ASGI application entry point for Placement API https://review.opendev.org/c/openstack/placement/+/995133 | 20:21 |
| gmaan | melwitt: nice catch, replied the reason. it was added when policy was SYSTEM_READER and we did not move it to base class when removed the system scope from our policy | 20:27 |
| gmaan | I will fix it | 20:27 |
| melwitt | ah gotcha. cool I will look again after you update | 20:27 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Update policy scope enforcement testing https://review.opendev.org/c/openstack/nova/+/986946 | 20:38 |
| opendevreview | Sylvain Desgrais proposed openstack/nova master: Allow security group names with leading/trailing spaces https://review.opendev.org/c/openstack/nova/+/995073 | 20:40 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove [libvirt] num_memory_encrypted_guests https://review.opendev.org/c/openstack/nova/+/995120 | 21:43 |
| opendevreview | Merged openstack/nova master: Add regression tests for interface attach MTU bug https://review.opendev.org/c/openstack/nova/+/994437 | 22:29 |
| opendevreview | Merged openstack/nova master: Fix network mtu metadata disappears after attaching https://review.opendev.org/c/openstack/nova/+/936093 | 22:35 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!