| gibi | tkajinam: I will try to collect as much printouts as possible form my HW today from both SNP enabled and SNP disabled in BIOS mode to see if we can settle the yesterdays debate somehwo | 07:29 |
|---|---|---|
| bauzas | gibi: thanks that will help | 07:30 |
| gibi | then I will have to give the HW back | 07:30 |
| gibi | probably I can ask for it again later if needed | 07:30 |
| bauzas | the issue is with the SNP support detection that said, as tkajinam said, atm we only be able to look at the /proc/cpuinfo file | 07:31 |
| gibi | but I don't want to overstretch the kindness of the kernel folks :) | 07:31 |
| bauzas | heh sure | 07:35 |
| bauzas | gibi: I mean, if you can see how we can detect by libvirt whether we support SNP, it would be nice | 07:36 |
| gibi | I think there is an extra complication about libvirt version which I cannot really test. I will have data from one specific libvirt version 12.5 | 07:36 |
| gibi | I can try to get back to libvirt 11.10 but I cannot go back to 10.5 | 07:39 |
| bauzas | ack thanks | 07:47 |
| opendevreview | Kamil Sambor proposed openstack/nova master: Correct release name in concurrency_backend https://review.opendev.org/c/openstack/nova/+/996219 | 08:00 |
| gibi | tkajinam, sean-k-mooney: here are data collected from my HW with SNP enabled and disabled in BIOS. https://drive.google.com/drive/folders/1U_wK6DRiPxKm98LJx3_BGH3VTEsPtFSU?usp=drive_link | 08:32 |
| sean-k-mooney | i cannot downlowd those files | 08:33 |
| gibi | the most useful thing seems to be /sys/module/kvm_amd/parameters/sev_snp as that switches to N when I disable the feature in BIOS | 08:33 |
| sean-k-mooney | oh i might need to sign in | 08:33 |
| gibi | I can open them in incognito | 08:34 |
| sean-k-mooney | i had to down load the full set | 08:35 |
| sean-k-mooney | but then i coudl open the zip | 08:35 |
| sean-k-mooney | so <launchSecurity supported='yes'> | 08:35 |
| sean-k-mooney | <enum name='sectype'> | 08:35 |
| sean-k-mooney | <value>sev</value> | 08:35 |
| sean-k-mooney | <value>sev-snp</value> | 08:35 |
| sean-k-mooney | </enum> | 08:35 |
| sean-k-mooney | </launchSecurity> | 08:35 |
| sean-k-mooney | is till advertised in the non snp libvirt folder | 08:36 |
| sean-k-mooney | so that with snp disabled in the bios? | 08:36 |
| bauzas | that's the problem tkajinam mentioned yesterday | 08:36 |
| bauzas | libvirt says "sure, do SNP" even if the BIOS option is disabled | 08:37 |
| sean-k-mooney | right but that isnt something nova should be checking | 08:37 |
| bauzas | maybe this is fixed in a later libvirt release tho | 08:37 |
| sean-k-mooney | that shoudl be either a config option or soemthing libvirt tells us | 08:37 |
| bauzas | would you be OK with a nova conf asking the operator to set it once the BIOS option is set ? | 08:38 |
| sean-k-mooney | yes | 08:38 |
| bauzas | and by default, saying no | 08:38 |
| gibi | the non_snp folder is the one where I disable the snp in bios, yes | 08:39 |
| sean-k-mooney | i woudl also be ok with it beign a comma seperate list of sev modes | 08:39 |
| sean-k-mooney | sev_mdoes=sev,sev-snp | 08:39 |
| sean-k-mooney | gibi: is there a reason you downgraded back to 11.10? | 08:39 |
| sean-k-mooney | bauzas: the minimal change i woudl be ok with is not parsing and extracting all the cpu flags and then check if sev-snp is in it and instead jsut check for that one value. i.e. i dont like that we are adding self._cpu_flag and now have a thrid set of cpu flag in the libvirt driver | 08:42 |
| sean-k-mooney | we are already mixing the cpu flags form virsh capablities and domcapablites which are not the saem | 08:42 |
| sean-k-mooney | and parsing and storage all the raw cpu flags woudl add a third set that disagree with the other two | 08:43 |
| sean-k-mooney | gibi are you suggesting we use /sys/module/kvm_amd/parameters/sev Y /sys/module/kvm_amd/parameters/sev_es Y /sys/module/kvm_amd/parameters/sev_snp N | 08:44 |
| sean-k-mooney | instead | 08:44 |
| sean-k-mooney | i slightly prefer that over parsing /proc also | 08:45 |
| sean-k-mooney | so if we use read_sys form the filesytem module to check /sys/module/kvm_amd/parameters/sev_snp and use that to set _support snp | 08:45 |
| sean-k-mooney | and do the same for the other two parmater so we set all 3 booleans the same way that coudl be workable | 08:46 |
| sean-k-mooney | its unfortente that the snp enabeld host has | 08:46 |
| sean-k-mooney | /sys/module/kvm_amd/parameters/sev Y /sys/module/kvm_amd/parameters/sev_es Y /sys/module/kvm_amd/parameters/sev_snp Y | 08:46 |
| sean-k-mooney | becasue it mean nova need to knwo about the new fireware bevhior which it really should not need to knwo about | 08:47 |
| sean-k-mooney | hum | 08:48 |
| sean-k-mooney | [ 17.742507] ccp 0000:23:00.1: SEV firmware updated from 1.55.31 to 1.58.1 | 08:48 |
| sean-k-mooney | so you r firmware is bing updated during boot | 08:48 |
| sean-k-mooney | i wonder if that is also impacting this behvior | 08:49 |
| sean-k-mooney | i was hoping or at least expect /sys/module/kvm_amd/parameters/sev_es N | 08:50 |
| sean-k-mooney | when snp is enabeld in the bios | 08:50 |
| sean-k-mooney | i wonder if that will be fixed ina future kernel update but in any case reading /sys/module/kvm_amd/parameters/sev_snp is less prblematic to me then /proc/cpuinfo | 08:51 |
| sean-k-mooney | tkajinam: ^ | 08:51 |
| gibi | so based on my trial, if SNP is disable in the bios then we can start ES VMs. So if we only rely on /sys/module/kvm_amd/parameters/sev_snp to detect in SNP is enabled in the bios that would be enough to infer if ES can be used or not. | 08:52 |
| sean-k-mooney | looking at the data sev_snp is in /proc/cpuinfo on the host with it disabeld in the bios | 08:53 |
| sean-k-mooney | so looking at that does not help in this case | 08:53 |
| sean-k-mooney | /sys/module/kvm_amd/parameters/sev_snp really does seam to be the only thing that tells us the bios config state | 08:54 |
| bauzas | gibi: two negatives in your last phrase didn't help me, you mean that checking sev_snp in sysfs can be enough for knowing whether the host supports SNP or ES ? | 08:55 |
| sean-k-mooney | bauzas: yes ^ | 08:55 |
| sean-k-mooney | bauzas: if /sys/module/kvm_amd/parameters/sev_snp is Y we know we cant use ES | 08:56 |
| bauzas | confirmed ? | 08:56 |
| gibi | by looking at the /sys/module/kvm_amd/parameters/sev_snp if that is N, and sev_es is Y, then I can boot SEV ES VMs on the machine | 08:56 |
| gibi | if both is yes then on SEV SNP can be booted | 08:56 |
| gibi | *both is Y | 08:56 |
| gibi | *both are Y | 08:57 |
| sean-k-mooney | *then only | 08:57 |
| bauzas | OK, and when SNP BIOS option is disabled, then /sys/module/kvm_amd/parameters/sev_snp is N ? | 08:57 |
| bauzas | (with new firmware of course) | 08:57 |
| gibi | /sys/module/kvm_amd/parameters/sev Y /sys/module/kvm_amd/parameters/sev_es Y /sys/module/kvm_amd/parameters/sev_snp N | 08:57 |
| bauzas | perfect then | 08:57 |
| gibi | all given with the kernel verson I run (6.12) | 08:58 |
| bauzas | tkajinam: looks like we have an alternative | 08:58 |
| bauzas | gibi: yeah, of course | 08:58 |
| gibi | this is the firmware version microcode_ctl-20260210-1.el10.noarch | 08:58 |
| sean-k-mooney | bauzas: well its not jsut an alternitive the curent patch that looks at /proc/cpuinfo is incorrect | 08:59 |
| sean-k-mooney | bauzas: looking at the data that gibi collected sev_snp is alwasy in /proc/cpuinfo regardless fo the bios option | 08:59 |
| sean-k-mooney | so we can check if the host could supprot snp by checking lauchsecuity for <value>sev-snp</value> | 09:00 |
| sean-k-mooney | and we can check if its congiured ot use it | 09:00 |
| sean-k-mooney | by checkign /sys/module/kvm_amd/parameters/sev_snp | 09:00 |
| sean-k-mooney | so we would report snp support if an only if /sys/module/kvm_amd/parameters/sev_snp Y and launchsecuirt <value>sev-snp</value> | 09:01 |
| sean-k-mooney | if /sys/module/kvm_amd/parameters/sev_snp Y we will not report es supprot | 09:01 |
| bauzas | hah | 09:02 |
| bauzas | I was thinking /proc/cpuinfo was correct, but if that's not, then yeah indeed this is even not an alternative | 09:03 |
| sean-k-mooney | i think /proc/cpuinfo is basiclly checkign the cpuid bits and decoding them, indepently of the fireware state | 09:04 |
| sean-k-mooney | so its baiclly sayign "this cpu implents this feature" not that you can use it at least in this kernle version | 09:05 |
| gibi | (to be correct I haev | 09:05 |
| gibi | (to be correct I have amd-ucode-firmware-20260624-24.el10.noarch | 09:05 |
| gibi | that has the firmware | 09:05 |
| gibi | SEV > than 1.37.23 has the fix | 09:05 |
| gibi | and I'm running 1.58.1 based on dmestg | 09:05 |
| gibi | > 10:39 < sean-k-mooney> gibi: is there a reason you downgraded back to 11.10? | I wanted to see if libvirt reporting changed between these versions | 09:06 |
| sean-k-mooney | ack i just didn see a no snp 12.x data | 09:07 |
| sean-k-mooney | i assume it didnt change | 09:07 |
| sean-k-mooney | gibi: are you happy to summerise your finding and this conversation on the review? | 09:07 |
| gibi | yepp I'm adding it | 09:08 |
| bauzas | thanks | 09:10 |
| *** chandank` is now known as chandankumar | 09:15 | |
| gibi | summarized to https://review.opendev.org/c/openstack/nova/+/994343/12#message-58d4e2f443634207d5a35a5cefce1fbd31ede5b8 | 09:28 |
| opendevreview | Joan Gilabert proposed openstack/nova master: Add libvirt driver MDEV ARQ support for Cyborg https://review.opendev.org/c/openstack/nova/+/995840 | 09:54 |
| gibi | I'm returning the HW | 12:20 |
| tkajinam | gibi sean-k-mooney bauzas , sorry I was out during the way and am catching up. I read the test result posted by gibi and I agree cpuinfo does not really working as expected (I picked it up from my old test logs but I might have misread it after a while). | 12:38 |
| tkajinam | I'll update the implementation and also spec to reflect the change soon. | 12:38 |
| sean-k-mooney | ack | 12:39 |
| sean-k-mooney | i think form the data that gibi capatured we have all the info we need to proeprly simulate this in unit/fuctional tests | 12:40 |
| gibi | tkajinam: thanks | 12:45 |
| bauzas | tkajinam: thanks ! | 12:45 |
| tkajinam | sean-k-mooney, yes | 12:52 |
| tkajinam | sean-k-mooney, one question. do you want me to rebase the whole sev series on top of your change to push all startup checks into the libvirt driver ? | 12:53 |
| tkajinam | sean-k-mooney, the question might be equivalent to whether you'll backport your fix to stable branches. | 12:53 |
| tkajinam | the whole sev-snp series, I mean | 12:54 |
| sean-k-mooney | am either that or put your new check in init_host in the driver and i can fix it in mine | 12:55 |
| sean-k-mooney | but im hoping to backport my fixes so both oders wil work | 12:55 |
| sean-k-mooney | tkajinam: so this function call in driver.init_host in the libvirt driver https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L924-L926 | 12:56 |
| sean-k-mooney | is pulling all the instnaces form the db and backfilling the default for the image properties | 12:57 |
| sean-k-mooney | so you could make https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L980-L997 return the list of instances | 12:57 |
| sean-k-mooney | and hten use that ot do your check | 12:57 |
| sean-k-mooney | but it woudl be cleaner ot rebase i think | 12:57 |
| tkajinam | yeah I read your change and I think I now understand how the check should be implemented after that fix. | 12:58 |
| sean-k-mooney | driver.init_host is called before we do the hostname validation and it really shoudl not have been loading the instance form the db like that | 12:58 |
| tkajinam | I agree | 12:59 |
| *** ykarel_ is now known as ykarel | 13:01 | |
| sean-k-mooney | i guess gibi or bauzas may have a prefernce but without https://github.com/openstack/nova/commit/2714c71d05e8501ddb3a8fc0c36f3406ef974072 those checks in the compute manager for self._validate_pinning_configuration(instances) and self._validate_vtpm_configuration(instances) were lazy loading the image propereis and flavor on every instance for every driver | 13:03 |
| sean-k-mooney | so we need to backprot that at a mimim if we were to backport the sev check | 13:04 |
| sean-k-mooney | but i woudl not like to backprot the sev check until we make it driver specirifc hostetly | 13:04 |
| sean-k-mooney | we shoudl not be imposing that pelenty on the ironic driver ectra when it does not apply | 13:04 |
| sean-k-mooney | that the whole premise behind https://review.opendev.org/c/openstack/nova/+/990552 | 13:05 |
| bauzas | I don't honestly have a preference :) | 13:11 |
| opendevreview | Joan Gilabert proposed openstack/nova master: Report OWNER_NOVA trait on resource providers https://review.opendev.org/c/openstack/nova/+/994299 | 14:43 |
| opendevreview | Joan Gilabert proposed openstack/nova master: Add libvirt driver MDEV ARQ support for Cyborg https://review.opendev.org/c/openstack/nova/+/995840 | 14:43 |
| opendevreview | Joan Gilabert proposed openstack/nova master: Rename cyborg-tempest to cyborg-tempest-py3 https://review.opendev.org/c/openstack/nova/+/996297 | 14:47 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Task tracking mechanism for graceful shutdown https://review.opendev.org/c/openstack/nova/+/996299 | 14:55 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore SEV-ES when SEV-SNP is detected https://review.opendev.org/c/openstack/nova/+/994343 | 15:46 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Detect AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/994764 | 16:02 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Support launchSecurity element for SEV-SNP https://review.opendev.org/c/openstack/nova/+/994920 | 16:02 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Omit optional fields for SEV/SEV-ES https://review.opendev.org/c/openstack/nova/+/994921 | 16:03 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Drop sev capability check in launch instance flow https://review.opendev.org/c/openstack/nova/+/994929 | 16:03 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: AMD SEV: omit iommu='on' for virtio devices https://review.opendev.org/c/openstack/nova/+/909635 | 16:03 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-SNP memory encryption https://review.opendev.org/c/openstack/nova/+/994930 | 16:11 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Update documentations for AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/995090 | 16:11 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove [libvirt] num_memory_encrypted_guests https://review.opendev.org/c/openstack/nova/+/995120 | 16:16 |
| melwitt | gmaan: dunno if you have seen this but it seems like unit test test_cold_migration_dest_compute_graceful_shutdown has been failing intermittently https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_dc2/openstack/dc227da7383b4f62ab0731d251d86e2f/testr_results.html | 16:31 |
| melwitt | https://opensearch.logs.openstack.org/_dashboards/app/data-explorer/discover?security_tenant=global#?_a=(discover:(columns:!(build_status,message,build_change,build_name),isDirty:!f,sort:!()),metadata:(indexPattern:'94869730-aea8-11ec-9e6a-83741af3fdcd',view:discover))&_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-30d,to:now))&_q=(filters:!(),query:(language:kuery,query:'message:%22in%20test_cold_migration_dest_compute | 16:32 |
| melwitt | _graceful_shutdown%22')) | 16:32 |
| melwitt | bah, sorry. link looked less long in my text box | 16:32 |
| *** mtreinish_ is now known as mtreinish | 16:36 | |
| *** opendevstatus_ is now known as opendevstatus__ | 16:38 | |
| *** opendevstatus__ is now known as opendevstatus | 16:38 | |
| *** opendevstatus is now known as Guest12850 | 16:38 | |
| opendevreview | Takashi Kajinami proposed openstack/nova master: WIP: Use domain capabilities to detect SEV-SNP support by libvirt/QEMU https://review.opendev.org/c/openstack/nova/+/996316 | 16:43 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore SEV-ES when SEV-SNP is detected https://review.opendev.org/c/openstack/nova/+/994343 | 16:45 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Accept hw_firmware_stateless=True for BIOS firmware type https://review.opendev.org/c/openstack/nova/+/995835 | 16:45 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: compute: Validate SEV/SEV-ES support at start up https://review.opendev.org/c/openstack/nova/+/994342 | 16:45 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore SEV-ES when SEV-SNP is detected https://review.opendev.org/c/openstack/nova/+/994343 | 16:45 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Detect AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/994764 | 16:45 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Support launchSecurity element for SEV-SNP https://review.opendev.org/c/openstack/nova/+/994920 | 16:45 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Omit optional fields for SEV/SEV-ES https://review.opendev.org/c/openstack/nova/+/994921 | 16:45 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Drop sev capability check in launch instance flow https://review.opendev.org/c/openstack/nova/+/994929 | 16:46 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: AMD SEV: omit iommu='on' for virtio devices https://review.opendev.org/c/openstack/nova/+/909635 | 16:46 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-SNP memory encryption https://review.opendev.org/c/openstack/nova/+/994930 | 16:46 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Update documentations for AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/995090 | 16:46 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove [libvirt] num_memory_encrypted_guests https://review.opendev.org/c/openstack/nova/+/995120 | 16:46 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: WIP: Use domain capabilities to detect SEV-SNP support by libvirt/QEMU https://review.opendev.org/c/openstack/nova/+/996316 | 16:47 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove [libvirt] num_memory_encrypted_guests https://review.opendev.org/c/openstack/nova/+/995120 | 17:16 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: ci: Remove GLANCE_STANDALONE https://review.opendev.org/c/openstack/nova/+/996322 | 17:19 |
| gmaan | melwitt: yeah, sean-k-mooney also reported the same yesterday, I will check it today. it seems some timing issue | 17:23 |
| sean-k-mooney | of hte graceful shutdown test? | 17:24 |
| sean-k-mooney | melwitt: i use https://tinyurl.com/ for those urls | 17:25 |
| gmaan | sean-k-mooney: yeah | 17:26 |
| sean-k-mooney | https://tinyurl.com/2ver5rr6 | 17:26 |
| sean-k-mooney | actully not hta tquey is broken | 17:26 |
| gmaan | did not get time yesterday but I am on it | 17:26 |
| melwitt | yeah it got cut off https://tinyurl.com/46cyby7t | 17:27 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Accept hw_firmware_stateless=True for BIOS firmware type https://review.opendev.org/c/openstack/nova/+/995835 | 17:30 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: compute: Validate SEV/SEV-ES support at start up https://review.opendev.org/c/openstack/nova/+/994342 | 17:30 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore SEV-ES when SEV-SNP is detected https://review.opendev.org/c/openstack/nova/+/994343 | 17:31 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Detect AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/994764 | 17:31 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Support launchSecurity element for SEV-SNP https://review.opendev.org/c/openstack/nova/+/994920 | 17:31 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Omit optional fields for SEV/SEV-ES https://review.opendev.org/c/openstack/nova/+/994921 | 17:31 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Drop sev capability check in launch instance flow https://review.opendev.org/c/openstack/nova/+/994929 | 17:31 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: AMD SEV: omit iommu='on' for virtio devices https://review.opendev.org/c/openstack/nova/+/909635 | 17:31 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-SNP memory encryption https://review.opendev.org/c/openstack/nova/+/994930 | 17:32 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Update documentations for AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/995090 | 17:32 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove [libvirt] num_memory_encrypted_guests https://review.opendev.org/c/openstack/nova/+/995120 | 17:32 |
| sean-k-mooney | ok ya so its happenign fairly consitently | 17:34 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Detect AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/994764 | 18:05 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Support launchSecurity element for SEV-SNP https://review.opendev.org/c/openstack/nova/+/994920 | 18:05 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Omit optional fields for SEV/SEV-ES https://review.opendev.org/c/openstack/nova/+/994921 | 18:05 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Drop sev capability check in launch instance flow https://review.opendev.org/c/openstack/nova/+/994929 | 18:05 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: AMD SEV: omit iommu='on' for virtio devices https://review.opendev.org/c/openstack/nova/+/909635 | 18:05 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-SNP memory encryption https://review.opendev.org/c/openstack/nova/+/994930 | 18:05 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Update documentations for AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/995090 | 18:05 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove [libvirt] num_memory_encrypted_guests https://review.opendev.org/c/openstack/nova/+/995120 | 18:05 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Detect AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/994764 | 18:34 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Support launchSecurity element for SEV-SNP https://review.opendev.org/c/openstack/nova/+/994920 | 18:34 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Omit optional fields for SEV/SEV-ES https://review.opendev.org/c/openstack/nova/+/994921 | 18:34 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Drop sev capability check in launch instance flow https://review.opendev.org/c/openstack/nova/+/994929 | 18:34 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: AMD SEV: omit iommu='on' for virtio devices https://review.opendev.org/c/openstack/nova/+/909635 | 18:34 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-SNP memory encryption https://review.opendev.org/c/openstack/nova/+/994930 | 18:34 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Update documentations for AMD SEV-SNP support https://review.opendev.org/c/openstack/nova/+/995090 | 18:34 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove [libvirt] num_memory_encrypted_guests https://review.opendev.org/c/openstack/nova/+/995120 | 18:34 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: WIP: Use domain capabilities to detect SEV-SNP support by libvirt/QEMU https://review.opendev.org/c/openstack/nova/+/996316 | 18:34 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: WIP: Use domain capabilities to detect SEV-SNP support by libvirt/QEMU https://review.opendev.org/c/openstack/nova/+/996316 | 18:48 |
| gmaan | sambork: gibi: after seeing openstack-tox-py313 and openstack-tox-py314 unit test jobs failing one of my test in eventlet mode (which i need to fix to handle both mode), i realized should not be run all our default unit tests jobs openstack-tox-py313, openstack-tox-py314 in threading mode and convert nova-tox-py313-threading->nova-tox-py313-eventlet ? | 18:48 |
| gmaan | mainly openstack-tox-py314 or any new higher python versions testing can be done in threading mode | 18:48 |
| sean-k-mooney | well we will next cycle right | 19:02 |
| sean-k-mooney | the goal is to default to threaded mdoe this cycle | 19:03 |
| sean-k-mooney | but form next cycel we defintly should | 19:03 |
| sean-k-mooney | for this cycle if we now have everything defaulting to threaded | 19:04 |
| sean-k-mooney | we could update the job/tox config i guess | 19:04 |
| sean-k-mooney | gmaan: we are technaly supproting eventlet on 3.14 | 19:05 |
| sean-k-mooney | so the eventlet supprot is more tied to the nova version then the python version | 19:05 |
| gmaan | yeah, i mean we can run 3.14 version on eventlet but rest all jobs running on threading mode | 19:06 |
| sean-k-mooney | although i dont know if 3.15 will ever be suproted by eventlet so that might eb threaded only as a side effect | 19:06 |
| sean-k-mooney | well really your talking about changing this to true https://github.com/openstack/nova/blob/master/tox.ini#L66 | 19:07 |
| gmaan | kind of matching the code default which is threading mode to what we tests in most of the jobs and have a single eventlet job running on latest py version until we need to keep the support | 19:07 |
| sean-k-mooney | ya | 19:07 |
| sean-k-mooney | i think that woudl make sense | 19:07 |
| sean-k-mooney | so remove OS_NOVA_DISABLE_EVENTLET_PATCHING=False form the default tox unit and functional targets | 19:08 |
| gmaan | yeah | 19:08 |
| sean-k-mooney | and rename the -threading evne and update the zuul jobs to match | 19:08 |
| gmaan | functional I am not sure as i think that is not yet ready for threading mode | 19:08 |
| gmaan | current functional threading mode job fail | 19:08 |
| gmaan | but yes at least unit tests are all ready | 19:09 |
| sean-k-mooney | oh ok i did not see an exclude file there | 19:09 |
| sean-k-mooney | but ya i know that was in flight i guess we are not quite there yet | 19:09 |
| sean-k-mooney | anyway i think your proposal makes sense so +1 form me | 19:10 |
| sean-k-mooney | hum https://github.com/openstack/nova/blob/master/tox.ini#L142-L151 does not configure eventlet so i assume it is not disabeled by default | 19:12 |
| sean-k-mooney | so not quite | 19:14 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/monkey_patch.py#L134-L144 | 19:14 |
| sean-k-mooney | we will patch if the env var is not set because the behvior fo the new config option is to return auto | 19:14 |
| sean-k-mooney | which means we take the else brnach | 19:15 |
| sean-k-mooney | so until we change the default here https://github.com/openstack/nova/blob/master/nova/monkey_patch.py#L120 we still have not actully change the default in all code paths | 19:15 |
| sean-k-mooney | so the unit and functional test and any tox env that does not set the evn var is currently using eventlet still | 19:16 |
| gmaan | i think that was left because console proxy in this cycle still in eventlet mode as default | 19:18 |
| sean-k-mooney | if that is the case then the unit test shoudl proably not be updated until next cycle | 19:18 |
| sean-k-mooney | gmaan: we stil have a few test that dont pass in threaded mode as well https://github.com/openstack/nova/blob/master/threading_unit_test_excludes.txt | 19:20 |
| gmaan | or we can do it for all other services | 19:20 |
| gmaan | oh, i thought this list was cleared but yeah then we should wait probably | 19:20 |
| sean-k-mooney | we cant have monkey patched and not in the same tox invocation | 19:20 |
| sean-k-mooney | almost | 19:21 |
| sean-k-mooney | if we get that to 0 it valid to swap the behvior up to RC1 | 19:21 |
| sean-k-mooney | so we are not in a rush | 19:21 |
| gmaan | yeah | 19:22 |
| opendevreview | Merged openstack/nova master: Correct release name in concurrency_backend https://review.opendev.org/c/openstack/nova/+/996219 | 21:14 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Task tracking mechanism for graceful shutdown https://review.opendev.org/c/openstack/nova/+/996299 | 21:50 |
| opendevreview | Brian Haley proposed openstack/nova master: Change neutron API calls to use project_id https://review.opendev.org/c/openstack/nova/+/994321 | 22:27 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!