| opendevreview | Ghanshyam Maan proposed openstack/nova master: Task tracking mechanism for graceful shutdown https://review.opendev.org/c/openstack/nova/+/996299 | 04:01 |
|---|---|---|
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Call manager graceful_shutdown while RPC server waits https://review.opendev.org/c/openstack/nova/+/996583 | 04:03 |
| opendevreview | Fabian Wiesel proposed openstack/nova master: vmware: Read iso file in binary mode during upload https://review.opendev.org/c/openstack/nova/+/996738 | 05:10 |
| *** ykarel_ is now known as ykarel | 06:15 | |
| *** mhen_ is now known as mhen | 06:25 | |
| gibi | gmaan: sean-k-mooney: I responed in the bug about the attachment show API issue | 09:06 |
| gibi | A proper client should handle 404 already while the volume is being attached as nova returns 404 when BDM is nto yet exists. | 09:06 |
| sean-k-mooney | yes it should | 09:07 |
| gibi | so returning 404 while BDM exists but without attachment_id is backward compatible from that client perspectvie | 09:07 |
| sean-k-mooney | i dont think a 200 -> 404 shoudl require a microversion as it should alreay be getting the 404 before while we are attaching and retrying | 09:07 |
| sean-k-mooney | so i agree that is backwards compatiable | 09:08 |
| sean-k-mooney | but also tahat api cant be used to know fi the volume is actully attached today | 09:08 |
| sean-k-mooney | although it will get closer to working for that with your proposed chagne | 09:09 |
| gibi | yeah just because we have attachment_id it does not tell us if the compute finished attaching the volume to the VM | 09:09 |
| gibi | the versioned notification is better in this regard as that is sent from the compute side | 09:10 |
| sean-k-mooney | if i recall the oder correctly , the volume gets attached in cinder, then we udate the bdms and finally attach it to the vm | 09:10 |
| gibi | yepp | 09:10 |
| sean-k-mooney | the last 2 might be reversed | 09:10 |
| sean-k-mooney | so the way to do this reliabley todya is server show and look at the attachments there | 09:10 |
| gibi | the attachment_id is added to the BDM by the conductor before the compute attaches the volume to the instance | 09:10 |
| sean-k-mooney | ack ok then i did remember the order | 09:10 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reproducer for https://bugs.launchpad.net/nova/+bug/2160224 https://review.opendev.org/c/openstack/nova/+/996756 | 09:58 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Do not try to return empty attachment_id from API https://review.opendev.org/c/openstack/nova/+/996757 | 09:58 |
| gibi | sean-k-mooney: gmaan: ^^ this might help dicussing the situation further | 10:02 |
| sean-k-mooney | gibi: woudl you agree that the bug shoudl be set to low an asgined to you give your working on it and respocen schema validation is not only off by defualt but docuemnted as never to be used in production only for testing? | 10:06 |
| gibi | sean-k-mooney: sure | 11:02 |
| gibi | I'm filing a separate bug to switch response schema validation errors to HTTP500 with a clear error message | 11:04 |
| sean-k-mooney | ack just an fyi ill be finishing up in the next 2 hours so i will be unlike to be around when gmaan comes onlien but i sumemrised my toughts in the bug | 11:07 |
| gibi | https://bugs.launchpad.net/nova/+bug/2160303 | 11:07 |
| gibi | sean-k-mooney: no worries | 11:08 |
| gibi | and thanks for the response in the bug | 11:08 |
| sean-k-mooney | in terems of the 404 responce it might evenually make sesen to only return the attahcment if the atttachment is fully compelte form a nova point of view but that out of scope fo the current bugs you filed | 11:09 |
| sean-k-mooney | well or have a better way | 11:10 |
| sean-k-mooney | to knwo if the attach is done | 11:10 |
| gibi | yeah | 11:10 |
| sean-k-mooney | which is actully tracked seperatly | 11:10 |
| sean-k-mooney | https://bugs.launchpad.net/nova/+bug/2058928 and or hte spec rajesh started | 11:11 |
| sean-k-mooney | ultimplate you shoudl be able to pool the intatnce actin event for completion | 11:11 |
| sean-k-mooney | gibi: switching topics for a sec im going to see if i can quickly update the futureist patches to adress your feedback and split the fix and feature | 11:13 |
| sean-k-mooney | gibi: do you want to proceed with the quick workaround in nova in the interim? | 11:13 |
| gibi | sean-k-mooney: we can wait with the hack in nova as that is top of the functional test with threading series anyhow | 11:14 |
| sean-k-mooney | well i was going to suggest rebasign to master | 11:14 |
| sean-k-mooney | if we didnt want to wait to save some ci time | 11:15 |
| sean-k-mooney | but ok ill see if i can get the actual fix tidied up quickly | 11:15 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: HACK:Speed up functional test in threading mode https://review.opendev.org/c/openstack/nova/+/996500 | 13:14 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Check service_ref before destroy https://review.opendev.org/c/openstack/nova/+/996793 | 13:14 |
| opendevreview | Merged openstack/placement master: tests: Support file-backed SQLite URL in placement fixtures https://review.opendev.org/c/openstack/placement/+/993106 | 14:10 |
| sean-k-mooney | gibi: sorry i just didnt get as far with the futurist work as i hoped for today. im going to wrap up shortly but ill take a look at it again on monday | 14:21 |
| gibi | sean-k-mooney: no worries. Have a nice weekend | 14:21 |
| sean-k-mooney | i might push what i have before i leave i need to pack a bag and trun on the ac in my car to cool it down or ill melt when i get into it | 14:23 |
| sean-k-mooney | i plugged it in to charge ealer and the temperture in the car was 35c which is what i get for parking it facing uphil and south on a nice day | 14:24 |
| sean-k-mooney | oh i was under estermating it say its at 44c right now. i am happy it also has a remote ac feature | 14:27 |
| *** mhen_ is now known as mhen | 15:28 | |
| opendevreview | Mike Lowe proposed openstack/nova master: Fix PCI cleanup when a move claim is aborted https://review.opendev.org/c/openstack/nova/+/996822 | 15:32 |
| opendevreview | Merged openstack/nova master: tests: use file-backed Placement SQLite in functional threading https://review.opendev.org/c/openstack/nova/+/992581 | 17:57 |
| gmaan | gibi: sean-k-mooney[m] stuck on other things downstream but I will check and reply on bug/gerrit. most probably today otherwise Monday | 19:47 |
| *** haleyb is now known as haleyb|out | 23:35 | |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!