| *** erlon4 is now known as erlon | 00:30 | |
| opendevreview | Brian Haley proposed openstack/nova master: Change neutron API calls to use project_id https://review.opendev.org/c/openstack/nova/+/994321 | 02:35 |
|---|---|---|
| opendevreview | Goutham Pacha Ravi proposed openstack/nova master: Extract share management from ComputeManager https://review.opendev.org/c/openstack/nova/+/999349 | 05:37 |
| opendevreview | Goutham Pacha Ravi proposed openstack/nova master: Support cold migration with virtiofs shares https://review.opendev.org/c/openstack/nova/+/989633 | 05:37 |
| *** benj_2 is now known as benj_ | 06:12 | |
| antia | gmaan: Thanks for reviewing the TDX series. I replied to some of the comments and will make changes to address the rest. | 07:38 |
| *** chandank` is now known as chandankumar` | 12:08 | |
| sean-k-mooney | antia: are you expecting to push new version of the patches today. i had hoped you would have prepared them on wednesday orginally? | 13:13 |
| antia | sean-k-mooney: yes, just finalizing now | 13:14 |
| sean-k-mooney | ack ill try an loop back to them so before i drop fo rthe weekend | 13:28 |
| opendevreview | Anton Iacobaeus proposed openstack/nova master: libvirt: Add Intel TDX host capability detection https://review.opendev.org/c/openstack/nova/+/994421 | 13:41 |
| opendevreview | Anton Iacobaeus proposed openstack/nova master: libvirt: Generalize memory encryption config https://review.opendev.org/c/openstack/nova/+/998466 | 13:41 |
| opendevreview | Anton Iacobaeus proposed openstack/nova master: libvirt: Add memory encryption config for TDX https://review.opendev.org/c/openstack/nova/+/998608 | 13:41 |
| opendevreview | Anton Iacobaeus proposed openstack/nova master: libvirt: Launch security Intel TDX https://review.opendev.org/c/openstack/nova/+/999249 | 13:41 |
| opendevreview | Anton Iacobaeus proposed openstack/nova master: doc: Add documentation for Intel TDX https://review.opendev.org/c/openstack/nova/+/1000081 | 13:41 |
| opendevreview | Anton Iacobaeus proposed openstack/nova master: libvirt: reject_mem_enc_instances https://review.opendev.org/c/openstack/nova/+/1000082 | 13:41 |
| opendevreview | Anton Iacobaeus proposed openstack/nova master: libvirt: Add os_firmware_secure https://review.opendev.org/c/openstack/nova/+/1000472 | 13:41 |
| opendevreview | Anton Iacobaeus proposed openstack/nova master: libvirt: Check only x86_64 arch for Intel TDX https://review.opendev.org/c/openstack/nova/+/1000805 | 13:41 |
| antia | sean-k-mooney: submitted a new version of the patches now, but this is without moving the os_firmware_secure patch | 13:41 |
| sean-k-mooney | ack | 13:42 |
| sean-k-mooney | that order is ok was well | 13:42 |
| sean-k-mooney | its a littel cleaner the other way but it shoudl be fien as is | 13:42 |
| sean-k-mooney | the how woudl be to merge the full series before FF in anycase | 13:42 |
| sean-k-mooney | ill need to to do one or two things before i have tiem to re reivew but ill try an do a pass over them in an hour or so | 13:44 |
| antia | thanks! | 13:47 |
| opendevreview | Clif Houck proposed openstack/nova master: perf(ironic): eliminate O(N²) ProviderTree deepcopy at startup https://review.opendev.org/c/openstack/nova/+/980676 | 13:51 |
| opendevreview | Clif Houck proposed openstack/nova master: Parallelize per-node resource updates https://review.opendev.org/c/openstack/nova/+/980679 | 13:51 |
| sean-k-mooney | antia: one thing to keep in mind, in openstack we try to ensure that every commit is indepently correct | 14:01 |
| sean-k-mooney | because we want master to be constaly deployable into production | 14:01 |
| sean-k-mooney | so we allow follow up patches but only when they are not requried for correctness | 14:02 |
| antia | that makes sense | 14:02 |
| sean-k-mooney | that why even if its fixed in a later patch if its a correctness issue we as for it to be fixed in teh relevent patch that intoduced the issue just as wider context | 14:02 |
| sean-k-mooney | that partly because we use gerrit but more because we do not belive in squash merging series | 14:03 |
| dansmith | gmaan: looks like we're in good shape on the graceful patches.. I'll try to hit the last one today | 14:16 |
| opendevreview | Anton Iacobaeus proposed openstack/nova master: libvirt: Add Intel TDX host capability detection https://review.opendev.org/c/openstack/nova/+/994421 | 14:56 |
| opendevreview | Anton Iacobaeus proposed openstack/nova master: libvirt: Generalize memory encryption config https://review.opendev.org/c/openstack/nova/+/998466 | 14:56 |
| opendevreview | Anton Iacobaeus proposed openstack/nova master: libvirt: Add memory encryption config for TDX https://review.opendev.org/c/openstack/nova/+/998608 | 14:56 |
| opendevreview | Anton Iacobaeus proposed openstack/nova master: libvirt: Add os_firmware_secure https://review.opendev.org/c/openstack/nova/+/1000472 | 14:56 |
| opendevreview | Anton Iacobaeus proposed openstack/nova master: libvirt: Launch security Intel TDX https://review.opendev.org/c/openstack/nova/+/999249 | 14:56 |
| opendevreview | Anton Iacobaeus proposed openstack/nova master: doc: Add documentation for Intel TDX https://review.opendev.org/c/openstack/nova/+/1000081 | 14:56 |
| opendevreview | Anton Iacobaeus proposed openstack/nova master: libvirt: reject_mem_enc_instances https://review.opendev.org/c/openstack/nova/+/1000082 | 14:56 |
| opendevreview | Anton Iacobaeus proposed openstack/nova master: libvirt: Check only x86_64 arch for Intel TDX https://review.opendev.org/c/openstack/nova/+/1000805 | 14:56 |
| gmaan | antia: thanks, will check today. i finished till doc yesterday but that is most of the key thing and last two were good maybe, | 15:03 |
| gmaan | dansmith: ack, thanks | 15:03 |
| gmaan | dansmith: and this doc/releasenotes one is last https://review.opendev.org/c/openstack/nova/+/997141/10 | 15:03 |
| dansmith | gmaan: yep, I know | 15:09 |
| gmaan | dansmith: k. I will fix this if i re-spin it otherwise sometime later https://review.opendev.org/c/openstack/nova/+/1000211/comment/734dd672_9a340618/ | 15:10 |
| gmaan | or you want to push me a followup in thtis series? | 15:10 |
| dansmith | not critical, see what other people think | 15:12 |
| gmaan | ack | 15:15 |
| dansmith | ugh, I can't put my finger on it right now.. Uggla when is FF? | 15:17 |
| Uggla | Thursday next week | 15:18 |
| gmaan | Aug 28, end of next week | 15:18 |
| dansmith | duh, linked from the top of the H page | 15:18 |
| sean-k-mooney | the non client lib freze shoudl have been yesterday i think as well | 15:18 |
| sean-k-mooney | i was about to check if the os-tirat release we are waitign on happend? | 15:18 |
| dansmith | ack, so I think we have plenty of time for gouthamr to at least try for a follow-up patch for reconciling missed share access rules | 15:18 |
| sean-k-mooney | Uggla: do you know? | 15:18 |
| dansmith | Uggla: I assume you would be up for a FFE if necessary to get that over the line if the rest of it is landed? | 15:19 |
| gmaan | antia: sean-k-mooney on TDX one, before you both goes offline. one thing to discuss. i have to check the updated series but i cannot see VM create is rejected if os_secure_boot=required and TDX requested, https://review.opendev.org/c/openstack/nova/+/999249/5/nova/virt/libvirt/driver.py#7967 | 15:19 |
| Uggla | dansmith yes if we have a chance to do it. | 15:19 |
| gmaan | is update/re-aranging series done or shoud i wait | 15:19 |
| sean-k-mooney | Uggla: looks like the last release was 2 months ago so im going to go request a new release now | 15:20 |
| sean-k-mooney | https://github.com/openstack/releases/blob/master/deliverables/_independent/os-traits.yaml#L115-L118 | 15:20 |
| Uggla | sean-k-mooney, I don't know. But things are probably lagging a bit because Elod is on pto | 15:21 |
| dansmith | Uggla: AFAIK we're now just waiting for you to circle back on the exception handling comment here: https://review.opendev.org/c/openstack/nova/+/999349 | 15:22 |
| sean-k-mooney | well sylvain is the release liason so they would have been teh one to propeose it normally but they are also on pto | 15:22 |
| sean-k-mooney | rather then elod | 15:22 |
| dansmith | otherwise I think I'm +2 on both assuming gouthamr will propose a followup for a periodic resync of the share access rules | 15:22 |
| gmaan | antia: this one https://review.opendev.org/c/openstack/nova/+/999249/3..5/nova/virt/libvirt/driver.py#b7976 | 15:24 |
| gmaan | i was expecting we reject the request when we find os_secure_boot is required and tdx-requested otherwise it still ignore it. no? | 15:25 |
| Uggla | dansmith, thanks I'm gonna answer. Did you test with nfs or cephfs ? | 15:26 |
| dansmith | nfs | 15:26 |
| dansmith | Uggla: I put notes in the comments about the things I tested (although notably left out which driver I was using) | 15:27 |
| antia | gmaan: There is a follow up patch, which I now moved to be in front, which solves the secure boot interaction with TDX | 15:27 |
| Uggla | ok I have just setup a cephfs devstack for testing it. That should not fundamentally change. But it will be another check. | 15:27 |
| dansmith | very good | 15:28 |
| antia | https://review.opendev.org/c/openstack/nova/+/1000472 with this it shouldn't be required to reject on os_secure_boot=required for TDX | 15:28 |
| gmaan | antia: ok, let me go through the whole series again, will do after sometime. btw which TZ you are in? | 15:29 |
| sean-k-mooney | did gibi or you have time to test that secure boot actully worked in that version | 15:29 |
| antia | gmaan: UTC+2, so just about to head off for the weekend :) | 15:30 |
| Uggla | dansmith, I would have progressed more without yesterday escalation. | 15:30 |
| gmaan | i did not have HW access, gibi had. i asked him about it but we will get to know on monday. | 15:30 |
| gmaan | antia: ack | 15:30 |
| gmaan | or antia may have tested? | 15:30 |
| sean-k-mooney | gmaan: sorry that question was to antia | 15:30 |
| antia | both me and gibi tested it | 15:30 |
| gmaan | yeah, i know. just saying | 15:30 |
| sean-k-mooney | ack we can stage thigns ready for gibi to +w on monday if we think its otehrwse ready adn he can do a final test if they have time | 15:31 |
| gmaan | i asked gibi also but can we publish the testing results (if you can upload yours) somewhere, as we will not be testing it in upstream, it will be good ref to know what is tested and working fine | 15:32 |
| sean-k-mooney | im almost done with the cybrog things i need to do today so ill be starting on the tdx review again in a bit | 15:32 |
| antia | logs of my tests (but this is before the most recent changes): https://paste.openstack.org/show/bdbleKLLworBpma70kXB/ | 15:32 |
| gmaan | not sure where we can share as permanent doc | 15:32 |
| sean-k-mooney | antia: but that does not actully should you checkign theat secure boot was enabled in the guest os image | 15:33 |
| sean-k-mooney | and tha tit booted with that | 15:33 |
| gmaan | i was thinking to have some doc existing in Nova repo with all testing you did. not detail maybe | 15:33 |
| sean-k-mooney | we proably shoud nto merge that | 15:33 |
| antia | sean-k-mooney: Ah that is true! I can do some more testing after the weekend | 15:33 |
| sean-k-mooney | unless it written as a guide to testing | 15:34 |
| sean-k-mooney | gmaan: we have similar guide for some numa stuff | 15:34 |
| sean-k-mooney | gmaan: so somethign like https://github.com/openstack/nova/tree/master/doc/source/contributor/testing | 15:34 |
| gmaan | sean-k-mooney: ++ yeah. i did not check numa one but yes guide to test/results | 15:35 |
| sean-k-mooney | well i dont thinik we should comemit one off results | 15:35 |
| gmaan | yup, kind of this | 15:35 |
| sean-k-mooney | but we can commit docs of how to test it manually properly | 15:35 |
| gmaan | at least, which one worked or not | 15:35 |
| sean-k-mooney | so of this is going to end up automated later in whitebox/tempest too | 15:36 |
| sean-k-mooney | the system gibi borrowed may eventully end up geting used to test this perodicily downstream | 15:37 |
| gmaan | ++ for tempest/whitebox testing but if we have some 3rd party CI to run them somewhere | 15:37 |
| sean-k-mooney | we kind of do. righ tnow we are not allwoe do report reuslt publicly because of infra info discustore risks | 15:37 |
| sean-k-mooney | gmaan: we have internal nightly master job for cybrog | 15:38 |
| gmaan | anyways, let's start with similar doc first, antia are you ok to push something next week. I am saying that is blocker for series to merge but good to have when we are merging it | 15:38 |
| sean-k-mooney | we shoudl be able to do the saem for TDX in the coming weeks | 15:38 |
| sean-k-mooney | not a blocker for the feature | 15:38 |
| gmaan | yeah | 15:38 |
| sean-k-mooney | jsut fyi that we hope to have that in place proably before the year is up | 15:39 |
| sean-k-mooney | we are still exploring options for public third party ci bu thats complicated | 15:39 |
| antia | would it be a document about TDX testing in https://github.com/openstack/nova/tree/master/doc/source/contributor/testing? | 15:39 |
| sean-k-mooney | yes so like https://github.com/openstack/nova/blob/master/doc/source/contributor/testing/serial-console.rst | 15:41 |
| sean-k-mooney | or the numa one | 15:41 |
| antia | something like that I can fix | 15:41 |
| sean-k-mooney | basiclly it woudl explain how to verify the feature is workign corectly | 15:41 |
| sean-k-mooney | antia: i would keep that as a follwup patch provided that works for gmaan | 15:42 |
| gmaan | yeah, works for me at the end of series. do not change existing series | 15:42 |
| antia | sounds good | 15:42 |
| gmaan | thanks | 15:42 |
| antia | have a nice weekend all, and thanks for reviewing! | 15:43 |
| gmaan | have a nice weekend antia | 15:43 |
| gmaan | sean-k-mooney: I am not sure you are planning to go through series today but I will be able to do during end of my day. I will leave the merge things until gibi or you recheck. we still have 1 week before FF | 15:43 |
| sean-k-mooney | im going to be aound for another hour or two | 15:44 |
| sean-k-mooney | im trying to complete the cybrog nvme serise first | 15:44 |
| sean-k-mooney | then loop back to this after | 15:44 |
| gmaan | ack | 15:44 |
| sean-k-mooney | the os-triats question above was we have a depency on the new os-trait release in that | 15:45 |
| gmaan | we released that right? i thought changes was done in advanbce and released | 15:45 |
| sean-k-mooney | they were don but not released | 15:45 |
| sean-k-mooney | https://review.opendev.org/c/openstack/releases/+/1001835/1/deliverables/_independent/os-traits.yaml | 15:45 |
| sean-k-mooney | i just created that | 15:45 |
| sean-k-mooney | im going to raise it in the release channel shortly | 15:46 |
| gmaan | sean-k-mooney: humm, tdx series added 3.8.0 in requirement.txt | 15:46 |
| sean-k-mooney | yep that was done 2 months ago | 15:46 |
| sean-k-mooney | the cyborg traits for nvme secure erase modes | 15:46 |
| sean-k-mooney | merge last week | 15:46 |
| gmaan | sean-k-mooney: its there https://github.com/openstack/os-traits/blob/3.8.0/os_traits/hw/cpu/x86/intel.py#L28 | 15:46 |
| gmaan | yeah, os-traits updates was done long back | 15:47 |
| sean-k-mooney | gmaan: right but we need a new release for a differnt feature | 15:47 |
| sean-k-mooney | this isnt needed in nova but is needed in placment and cybrog | 15:47 |
| gmaan | ohk, i thought you are saying TDX part is not released yet | 15:48 |
| sean-k-mooney | no that is there | 15:48 |
| gmaan | yeah | 15:48 |
| sean-k-mooney | but i need to complete the nvme feature review before going back to the tdx series | 15:48 |
| gmaan | got it | 15:49 |
| sean-k-mooney | im trying to see if i can get os-traits 3.9.0 released so we can fully supprot requeting nvme devices based on tehre secure erase capabliteis | 15:49 |
| gmaan | maybe we need more people here https://github.com/openstack/governance/blob/master/reference/projects.yaml#L1039 | 15:49 |
| sean-k-mooney | Uggla if you can appove https://review.opendev.org/c/openstack/releases/+/1001835 that woudl help | 15:50 |
| gmaan | Uggla: ^^ idea to add a few more as release will stuck if you and bauzas both are on PTO | 15:50 |
| sean-k-mooney | having more then one is nice for pto coverage but the ptl can alwasy approve as well | 15:50 |
| gmaan | yeah, just thinking to have 1 or 2 more along with PTL | 15:51 |
| sean-k-mooney | for cybrog and watcher we have 2 release liasons seperate form teh ptl with 3 possbel aprpovers we are genneraly pretty PTO resitent | 15:51 |
| Uggla | sean-k-mooney, done. Tbh I was here this week but forget about it. | 15:54 |
| sean-k-mooney | no worries am we shoudl check os-vif and os-resouce classees for pendign release as well | 15:54 |
| sean-k-mooney | but im not aware of any critial patches in those | 15:55 |
| sean-k-mooney | os vif was milestone 2 | 15:56 |
| sean-k-mooney | we actuul;y do have a few fixes we shoudl include in 2026.2 | 15:56 |
| sean-k-mooney | ill also prospoe that now | 15:56 |
| sean-k-mooney | we specificly want https://github.com/openstack/os-vif/commit/8f2d2cc92d6f79c85e03e52d61b0f71d08a0cca2 | 15:57 |
| sean-k-mooney | Uggla: https://review.opendev.org/c/openstack/releases/+/1001844 | 15:58 |
| Uggla | sean-k-mooney i approved | 16:05 |
| opendevreview | Clif Houck proposed openstack/nova master: Parallelize per-node resource updates https://review.opendev.org/c/openstack/nova/+/980679 | 16:19 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Add doc and release notes for the graceful shutdown task tracking https://review.opendev.org/c/openstack/nova/+/997141 | 17:26 |
| * gouthamr reads scrollback.. | 17:54 | |
| gouthamr | ack on the periodic cleanup on the virtiofs/cold migration patch dansmith.. | 17:55 |
| gouthamr | i'm working on it | 17:55 |
| dansmith | gouthamr: cool | 18:02 |
| gmaan | dansmith: updated the doc change | 18:20 |
| dansmith | gmaan: got it | 18:33 |
| * dansmith dusts hands | 18:33 | |
| gmaan | dansmith: thanks for reviews on the whole series. | 18:34 |
| * dansmith nods | 18:43 | |
| *** nicolairuckel_ is now known as nicolairuckel | 20:07 | |
| opendevreview | Merged openstack/nova master: Report OWNER_NOVA trait on resource providers https://review.opendev.org/c/openstack/nova/+/994299 | 21:01 |
| opendevreview | Goutham Pacha Ravi proposed openstack/nova master: Use a per-instance cephx identity for CephFS shares https://review.opendev.org/c/openstack/nova/+/1001900 | 21:17 |
| opendevreview | Goutham Pacha Ravi proposed openstack/nova master: Use a per-instance cephx identity for CephFS shares https://review.opendev.org/c/openstack/nova/+/1001900 | 21:46 |
| opendevreview | Goutham Pacha Ravi proposed openstack/nova master: Extract share management from ComputeManager https://review.opendev.org/c/openstack/nova/+/999349 | 21:46 |
| opendevreview | Goutham Pacha Ravi proposed openstack/nova master: Support cold migration with virtiofs shares https://review.opendev.org/c/openstack/nova/+/989633 | 21:46 |
| opendevreview | Goutham Pacha Ravi proposed openstack/nova master: Use a per-instance cephx identity for CephFS shares https://review.opendev.org/c/openstack/nova/+/1001900 | 22:28 |
| opendevreview | Goutham Pacha Ravi proposed openstack/nova master: Extract share management from ComputeManager https://review.opendev.org/c/openstack/nova/+/999349 | 22:28 |
| opendevreview | Goutham Pacha Ravi proposed openstack/nova master: Support cold migration with virtiofs shares https://review.opendev.org/c/openstack/nova/+/989633 | 22:28 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!