| simondodsley | gibi: Is there any chance that this patch (https://review.opendev.org/c/openstack/nova/+/973750) be relooked at again. It's a really simple fix for a big issue. Already have one +2 | 06:33 |
|---|---|---|
| gibi | simondodsley: I've approved it. I hope I did not risk RC1 with it. But I'm in a good mood so I taking my chances here. Btw next time feel free to ping me eariler if I reviewed someting before and never showed up re-reviewing the patch | 07:32 |
| bauzas | gibi: would you agree with gmaan's comment on https://review.opendev.org/c/openstack/nova/+/1003386 that we go for a known bug reno instead of fixing it ? | 09:15 |
| bauzas | I'm cool with that and if you look at the irc logs we discussed a nice alternative | 09:15 |
| gibi | let me check | 09:53 |
| gibi | I'v read the review comments. I'm OK to keep as a known bug for now. I agree that it is not fatal thing to have this task leaked as it only slows down the shutdown, does not prevent it | 09:59 |
| * Uggla has written about the nova-reviewers group situation --> https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/VDH5NVO6S4XDZDYEK32GZPT2444U2OJD/ | 09:59 | |
| gibi | Uggla: thanks I will jump there | 10:01 |
| gibi | but I also need to read the tc channel logs to get the full context | 10:02 |
| bauzas | given the lack of consensus yet, I'd propose to defer the application of nova-reviewers until a consequent discussion can happen (before PTG or in it) for at least being all of up agreeing for find some policy how to use this new group | 10:42 |
| sean-k-mooney | ls | 12:23 |
| sean-k-mooney | :) | 12:23 |
| sean-k-mooney | gibi: gmaan: https://review.opendev.org/c/openstack/nova/+/1004687/1 and https://review.opendev.org/c/openstack/nova/+/966479/5 update nova next to ubuntu 26.04 and nova-alt-config to to debian 13, the latter was ment ot be done in 2026.1 so it woudl be nice if we can proceed with both this cycle, can ye take a look when ye have time | 12:25 |
| *** erlon6 is now known as erlon | 12:43 | |
| gibi | Uggla: thanks for the email, I responded there and commented on the https://review.opendev.org/c/openstack/nova/+/986141 as well | 12:51 |
| gibi | we need to start figure out a the way forward | 12:52 |
| *** chandank` is now known as chandankumar` | 13:02 | |
| opendevreview | Kamil Sambor proposed openstack/nova master: Fix pickling error that forces oslo.service to fall back to fork https://review.opendev.org/c/openstack/nova/+/1000956 | 13:04 |
| gablan | hi gibi! I'm backporting the graceful shutdown work from master to stable/2026.1 downstream, and I hit the TODO you left in Host.cleanup() in `nova/virt/libvirt/host.py` about `stopping _event_handler` and `the _conn_event_thread` loop. do you have anything planned for it, or can I propose a patch for it? | 13:06 |
| gibi | gablan: check master I think gmaan recent changes there are addressing it | 13:17 |
| gibi | sean-k-mooney: are you sure this is save to do on the day of RC1? If yes then we can land it but I need you to react and revert if something breaks on the gate after landing | 13:19 |
| gibi | /save/safe/ | 13:19 |
| gibi | cc gmaan, Uggla | 13:19 |
| sean-k-mooney | so i think so but im ok to wait until after rc1 is cut and backport if reqruied. | 13:20 |
| sean-k-mooney | i coudl also flip the order | 13:20 |
| sean-k-mooney | the debian 12->13 change for alt config | 13:20 |
| sean-k-mooney | shoudl be safe because our ceph jobs have been on debina 13 all cycle | 13:20 |
| sean-k-mooney | we just didnt get aroudn to movaing nova-alt-conig last cycel or eailar becasue i forgot the patch was still open/in merge conflict | 13:21 |
| gibi | when gmaan is up we can make the call I think | 13:21 |
| gibi | I will be around for longer today to accomodate that (and due to other unrelated reasons) | 13:22 |
| sean-k-mooney | unless we have a strong reason not to i woudl perfer to have some py3.14 testign on stable 2026.2 but im ok if perpoel prefer not too | 13:22 |
| sean-k-mooney | ack works for me | 13:22 |
| dansmith | my reasoning would be that we didn't go all of the cycle with that testing on, so flipping it right now seems much riskier than necessary | 13:39 |
| bauzas | is it me or the level of changes we plan to deliver so close to RC1 is high today ? | 14:02 |
| bauzas | as a reminder, we can make RC2 if there are some regressions that need to be fixed asap | 14:03 |
| bauzas | but on the graceful shutdown case, I think we agreed yesterday to just amend the existing relnotes with a known bug file so people would know about the existing and decide whether to opt-in or not | 14:04 |
| opendevreview | ribaudr proposed openstack/nova master: Add Hibiscus prelude section https://review.opendev.org/c/openstack/nova/+/1004927 | 14:05 |
| Uggla | bauzas, gibi just to let you know I have updated the highlight with latest input from gmann/bauzas https://review.opendev.org/c/openstack/releases/+/1004465 also reflect that change to the prelude patch https://review.opendev.org/c/openstack/nova/+/1004927 | 14:08 |
| bauzas | ack | 14:09 |
| Uggla | and sorry it comes later than I what I expected. | 14:09 |
| dansmith | bauzas: what else is proposed? we agreed to punt on the graceful shutdown one for sure | 14:10 |
| bauzas | dansmith: I maybe misunderstood the above discussion, I thought two different things were discussed, the one about graceful shutdown leaking threads and the other one being a nova-next change | 14:12 |
| dansmith | bauzas: oh yeah, the shutdown one is punted, and I agree, the nova-next change should wait.. I thought you meant something else | 14:13 |
| *** erlon3 is now known as erlon | 14:14 | |
| gibi | Uggla: ack | 14:17 |
| gibi | bauzas: this needs second code (max microversion) https://review.opendev.org/c/openstack/nova/+/1004872 | 14:37 |
| gibi | s/code/core/ | 14:37 |
| bauzas | oh I forgot that one | 14:37 |
| gibi | Uggla: bauzas: what should we do with translation? https://review.opendev.org/c/openstack/nova/+/980544 | 14:39 |
| bauzas | we ship them by a single approver | 14:39 |
| gibi | OK then I approve it | 14:40 |
| bauzas | I did it | 14:40 |
| gibi | ohh you did it good | 14:40 |
| gibi | thanks | 14:40 |
| bauzas | nw | 14:40 |
| bauzas | and fwiw the i18n team works on a change from zanata | 14:40 |
| bauzas | I dunno where they are | 14:40 |
| * gibi looks around definitely not here :) | 14:41 | |
| opendevreview | Gabin Lanore proposed openstack/nova master: libvirt: stop the event dispatch loops on cleanup https://review.opendev.org/c/openstack/nova/+/1005022 | 14:48 |
| gablan | gibi: thanks! Checked both of gmaan's patches 1003386 is the task-registry leak, 1001572 is the executor ownership refactor. Neither seems to touch Host.cleanup(), so I pushed a patch for it :D | 14:50 |
| gibi | gablan: thanks cc gmaan ^^ | 14:51 |
| opendevreview | Clif Houck proposed openstack/nova stable/2025.1: perf(ironic): eliminate O(N²) ProviderTree deepcopy at startup https://review.opendev.org/c/openstack/nova/+/1005073 | 15:27 |
| opendevreview | Grzegorz Grasza proposed openstack/nova master: Mask password-like content in exception notifications https://review.opendev.org/c/openstack/nova/+/1005074 | 15:48 |
| opendevreview | Merged openstack/nova master: Mark 2.104 as maximum API version for 2026.2 Hibiscus https://review.opendev.org/c/openstack/nova/+/1004872 | 16:09 |
| opendevreview | Merged openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/980544 | 16:09 |
| gibi | Uggla: I've approved the prelude as the highlights laned. Are we done? :) | 16:14 |
| gibi | s/laned/landed/ | 16:14 |
| gibi | ahh we are not doen | 16:15 |
| gibi | done | 16:15 |
| gibi | https://review.opendev.org/c/openstack/nova/+/1004430 and https://review.opendev.org/c/openstack/nova/+/1004424 are still need to land to have RC1 | 16:15 |
| gibi | but then every patch from the tracking etherpad are approved now | 16:16 |
| gibi | so we only need to wait for the gate | 16:16 |
| gibi | sean-k-mooney: I guess the discussion about about the job changes went into the direction that we should not risk it now | 16:16 |
| sean-k-mooney | did i miss that | 16:17 |
| sean-k-mooney | were there comemtns on the patches | 16:17 |
| sean-k-mooney | because i tought we were landing the other way | 16:17 |
| sean-k-mooney | that htis was low risk | 16:17 |
| gibi | I think bauzas and dansmith discussed above | 16:18 |
| sean-k-mooney | ah ok i was in a watcher irc meetign when we were chatting about it so i had swapped back to that | 16:18 |
| sean-k-mooney | the debian change i feel really shoudl be done this cycel becase it was propsed 10 months ago and was defered lat cycel for similar reasons | 16:19 |
| sean-k-mooney | the ubuntu 24.04->26.04 change for nova next is more a nice ot have | 16:19 |
| sean-k-mooney | anyway i guess we can do them right after we cut rc1 | 16:20 |
| zigo | Hi team ! | 16:20 |
| zigo | I get it for the 2 nova patches above that needs to land, but anything preventing placement to be released ? | 16:20 |
| sean-k-mooney | im not directly aware of anything pending on that side beyond perhaps a release not prelude | 16:21 |
| sean-k-mooney | but im not sure that is strictly requried | 16:21 |
| Uggla | gibi, thanks I think we are done. We just need to wait the latest SHA to put it into the RC1 release | 16:21 |
| sean-k-mooney | we didnt really have any placmeent feature so the normal release notes i sproably enough | 16:21 |
| sean-k-mooney | gibi: anyway so looking at the service version patchs they are now approved so i think thats all good | 16:22 |
| sean-k-mooney | bauzas: for context on the ubuntu change i proght it up at FF and i was asked to wait to RC1 which is why i put it up yesterday | 16:25 |
| sean-k-mooney | we can wait again but i woudl like to get that testign in place early in 2027.1 | 16:26 |
| sean-k-mooney | the base testing of nova on 26.04 has been runing in devstack for several months now which is why i was not expecting this to be contoversial | 16:27 |
| sean-k-mooney | https://meetings.opendev.org/meetings/nova/2026/nova.2026-08-24-16.00.log.html#l-217 | 16:29 |
| gmaan | sean-k-mooney: gibi: same here, i would not prefer to touch the testing bit at this stage, let's have master rc-1 cut and then we can do those for 2027.1 | 16:30 |
| gmaan | gibi: gablan thanks, will check | 16:30 |
| gmaan | sean-k-mooney: for py3.14 testing on 2026.2 you mean unit/functional test or tempest job? | 16:30 |
| sean-k-mooney | i ment moving nova-next to ubuntu 26.04 to test with 3.14 in tempest | 16:31 |
| sean-k-mooney | that what i propsed a few weeks ago in the irc meeting | 16:31 |
| sean-k-mooney | specifcly for advance testing in 2026.2 | 16:31 |
| sean-k-mooney | gibi asked i do it after FFs and i asked to do it before RC1 | 16:32 |
| sean-k-mooney | so i proposed the patches this week to do that | 16:32 |
| gmaan | yeah i know we discussed it on IRC to do it after FF but seeing gate unstability over last month, i agree to do it after rc-1. | 16:33 |
| sean-k-mooney | ok anyway here is the devstack patch to make it voting there https://review.opendev.org/c/openstack/devstack/+/1004684?tab=change-view-tab-header-zuul-results-summary | 16:33 |
| gmaan | I am not against of adding it on 2020.2 but let's do it once stable/2026.2 exist so that it would not block current master dev/release | 16:33 |
| sean-k-mooney | if you have not seen that as well | 16:33 |
| sean-k-mooney | well once we cut RC1 master will be 2027.1 and it shoudl be voting there anyway in the next week or 2 as our default shoudl be chaning | 16:34 |
| sean-k-mooney | but ya lets focus on getting RC1 out for nova and placement and come back to this next week | 16:35 |
| gmaan | yeah, we can backport that based on hoiw it run on stable/2026.2 | 16:36 |
| sean-k-mooney | ack | 16:36 |
| gmaan | sean-k-mooney: but from testing runtime, i think we will keep 24.04 and 26.04 noth voting on 2027.1 | 16:36 |
| sean-k-mooney | no | 16:36 |
| gmaan | https://governance.openstack.org/tc/reference/runtimes/2027.1.html#additional-testing-for-a-smooth-upgrade | 16:37 |
| gmaan | yes | 16:37 |
| sean-k-mooney | we will keep 24.04 for upgrades | 16:37 |
| sean-k-mooney | but 26.04 shoudl be voting and our new default | 16:37 |
| gmaan | because its 2027.1 where we are bumping the distro testing | 16:37 |
| gmaan | yes and at least one job for 24.04 | 16:37 |
| gmaan | and voting | 16:37 |
| sean-k-mooney | ya so proably the skiplevel greande job | 16:38 |
| sean-k-mooney | with the normal greade job using 26.04 | 16:38 |
| sean-k-mooney | but we can select one fo the others | 16:38 |
| gmaan | yeah, that only. so upgrade path from 2026.2 (on ubuntu 24.04) -> 2027.1 (ubuntu 26.04 ) is covered | 16:38 |
| gmaan | ski level job is always there for SLURP and NON-SLURP by default unless project opt-out on non-SLURP release | 16:38 |
| sean-k-mooney | yep i think the skip level job is often the best for that smoth upgrade path | 16:39 |
| gmaan | yeah | 16:39 |
| sean-k-mooney | ok i need to check that all the rc/stable branches for the cybrog and watcher repos that should exsit have been created so ping if anything comes up else ill be doing that for the next while | 16:40 |
| sean-k-mooney | gmaan: actully for the tempest plugins those will happen as a group correct? | 16:42 |
| sean-k-mooney | i guess they are not typiclly branched | 16:43 |
| sean-k-mooney | so that probaly fine but they will be tagged | 16:43 |
| gmaan | sean-k-mooney: yeah, there will be only final release for tempest plugin and no stable branch | 16:43 |
| sean-k-mooney | ack perfect | 16:43 |
| gmaan | and jobs/ new master twick will happen usually at same time | 16:44 |
| gibi | Uggla: sean-k-mooney: zigo: the placement RC1 release patch is not up to date with the tip of master | 16:44 |
| gmaan | for devstack/greande branches, yes it wait for all projects stable exist and when i get release go ahead | 16:44 |
| gmaan | *release team go ahead | 16:44 |
| sean-k-mooney | gibi: ah is it missing the packagign fix form earlier in the week | 16:45 |
| gmaan | s/i/QA PTL, hoping it will not be me all the time :) | 16:45 |
| gibi | the placement unreleased release notes looks OK to me I don't think we need a prelude there as it is sort | 16:45 |
| gibi | Uggla: are you still around or should I go ahead and update the placement release patch? | 16:46 |
| sean-k-mooney | oh that is there it just missing the tox changes | 16:47 |
| sean-k-mooney | those are nice ot hvae if can bump them quickly | 16:47 |
| gibi | I can | 16:47 |
| gibi | so I start doing it | 16:48 |
| sean-k-mooney | i think its low risk and we might as well inculde them | 16:48 |
| gibi | https://review.opendev.org/c/openstack/releases/+/1004525/1..2 | 16:52 |
| gibi | updated | 16:52 |
| gibi | but we need Uggla's or bauzas' approval a release liasons | 16:52 |
| sean-k-mooney | well the current version is not approved | 16:53 |
| sean-k-mooney | adn the release team only merge them tomorow if late | 16:54 |
| sean-k-mooney | so updatign now wont really impact there appoval | 16:54 |
| sean-k-mooney | i commented on the patch that the current sha is ok since the tox chagne are nice to have | 16:54 |
| sean-k-mooney | we can alwasy backport them if needed | 16:54 |
| gibi | I pushed the change :) | 16:55 |
| sean-k-mooney | i guess the irc bot is not flexibel enough to tell use when nova related release patches are pushed | 16:56 |
| gibi | yeah that would be too much :) | 16:56 |
| sean-k-mooney | that looks good to me | 16:58 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Update release notes with known bug of live migration task leak https://review.opendev.org/c/openstack/nova/+/1005093 | 17:09 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Update release notes with known bug of live migration task leak https://review.opendev.org/c/openstack/nova/+/1003386 | 17:10 |
| *** mhen_ is now known as mhen | 17:11 | |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Update release notes with known bug of live migration task leak https://review.opendev.org/c/openstack/nova/+/1003386 | 17:11 |
| gmaan | dansmith: gibi bauzas updated release notes to list that task tracking bug as known bug https://review.opendev.org/c/openstack/nova/+/1003386 | 17:12 |
| gmaan | gablan: ^^ as you are backporting the graceful shutdown in downstream, this is known bug. | 17:13 |
| gmaan | gablan: btw, good to see interest in graceful shutdown feature, let us know how it works and especially any feedback on default value of graceful shutdown timeout configuration https://docs.openstack.org/nova/latest/admin/graceful-shutdown.html#configuration | 17:15 |
| opendevreview | Merged openstack/nova master: Add Hibiscus prelude section https://review.opendev.org/c/openstack/nova/+/1004927 | 17:28 |
| dansmith | gmaan: see my comment on the reno | 17:33 |
| dansmith | if you agree I can ninja the updated version, and if not, I'll +W | 17:33 |
| gmaan | dansmith: checked, yes that is correct. let me update it | 17:35 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Update release notes with known bug of live migration task leak https://review.opendev.org/c/openstack/nova/+/1003386 | 17:37 |
| gmaan | dansmith: ^^ done | 17:38 |
| dansmith | got it | 17:38 |
| opendevreview | Merged openstack/nova master: Update release notes with known bug of live migration task leak https://review.opendev.org/c/openstack/nova/+/1003386 | 18:54 |
| opendevreview | Clif Houck proposed openstack/nova stable/2026.1: Parallelize per-node resource updates https://review.opendev.org/c/openstack/nova/+/1005115 | 19:45 |
| clif | man I'm going to have to rework that backport patch again for 2025.2 since it seems like at that point in time futurist.GreenThreadPoolExecutor was used instead of nova.utils.create_executor | 19:49 |
| JayF | No guardrail on the eventlet migration cliff :( don't fall (I know this is maybe unbelivable but pun not intended) | 19:53 |
| clif | I guess it wasn't as bad as I expected | 20:11 |
| opendevreview | Clif Houck proposed openstack/nova stable/2025.2: Parallelize per-node resource updates https://review.opendev.org/c/openstack/nova/+/1005118 | 20:21 |
| opendevreview | Clif Houck proposed openstack/nova stable/2025.1: Parallelize per-node resource updates https://review.opendev.org/c/openstack/nova/+/1005119 | 20:23 |
| sean-k-mooney | clif: we have been slowly cenrtalisaing all the executor stuff release to release and putting it in a corner | 20:29 |
| sean-k-mooney | so ya i woudl expect some rework to be needed there | 20:29 |
| clif | yeah I understand, the main hurdle was initially adapting to the change that happened recently with thread_pool_executor | 20:30 |
| clif | going backward has been relatively easy | 20:30 |
| clif | and the initial adaptation wasn't that bad in hindsight either, just unexpected | 20:31 |
| sean-k-mooney | at least your doing it the "right way" release by release, its much much harder to skip im my expirnce | 20:35 |
| sean-k-mooney | anyway im calling it a day o/ | 20:36 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!