| gibi_ | ashigupt: I will try to get to it but at the moment it is somewhere in the middle of my todo lit | 07:03 |
|---|---|---|
| gibi_ | lis | 07:03 |
| gibi_ | list | 07:03 |
| *** bauzas7 is now known as bauzas | 07:54 | |
| bauzas | hey folks, back | 08:09 |
| bauzas | gibi_: I mentioned https://review.opendev.org/c/openstack/nova/+/1005727 but this requires a bit of cleanup on my side per the last comments, fwiw | 08:16 |
| gibi_ | ack | 08:25 |
| gibi_ | I push what I have and then start looking at yours | 08:26 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Fix PCI allocation leak on failed cold migration https://review.opendev.org/c/openstack/nova/+/1006003 | 09:00 |
| gibi_ | bauzas: that is mine ^^ it reuses an existing RPC call originally used for live migration during cold migration to clean up the leaked MoveClaim | 09:01 |
| bauzas | ack | 09:01 |
| gibi_ | bauzas: left questions in the fix | 09:13 |
| bauzas | ty, still trying to untangle all the potential issues | 09:13 |
| gibi_ | ack | 09:14 |
| *** gibi_ is now known as gibi | 09:14 | |
| bauzas | as a reminder, the best solution is something persisted | 09:14 |
| bauzas | but still trying to find a short-term fix for being backportable shortly | 09:14 |
| gibi | ahh and I realized that I asked the same question as Dan | 09:15 |
| gibi | about how the two parallel request can overlap | 09:15 |
| bauzas | np | 09:15 |
| gibi | OK moved my comment to the proper place | 09:26 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce bug 2166786 https://review.opendev.org/c/openstack/nova/+/1004658 | 09:27 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Fix PCI allocation leak on failed cold migration https://review.opendev.org/c/openstack/nova/+/1006003 | 09:27 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Guard against deleting a concurrent request's BDM on timeout https://review.opendev.org/c/openstack/nova/+/1005727 | 10:38 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Reject stale reserve_block_device_name RPC on compute https://review.opendev.org/c/openstack/nova/+/1006011 | 10:38 |
| opendevreview | Merged openstack/placement master: pre-commit: Add codespell https://review.opendev.org/c/openstack/placement/+/931806 | 11:36 |
| gibi | gmaan: does this clear_events_for_instance needs to run for failed resizes as well https://github.com/openstack/nova/blob/94de0576ca02e0668233bedfbe7e18b87316c708/nova/compute/manager.py#L6418 ? E.g. if driver.migrate_disk_and_power_off raises do we leak a pending resize task? | 13:11 |
| bauzas | gibi: gmaan: I barely paid attention to the gate issues with threading, but I just saw that one https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_c5e/openstack/c5e5e75ba3ba4ea1bbc056c4f9299476/testr_results.html | 13:52 |
| bauzas | context : https://review.opendev.org/c/openstack/nova/+/1005727 | 13:53 |
| gibi | https://bugs.launchpad.net/nova/+bug/2165149 | 13:55 |
| gibi | https://review.opendev.org/c/openstack/nova/+/1003586 | 13:56 |
| opendevreview | ribaudr proposed openstack/nova master: Fix swap disk creation skipped on NFS during cold migration https://review.opendev.org/c/openstack/nova/+/1006036 | 13:56 |
| gibi | bauzas: that is also one of the todos I have | 13:56 |
| bauzas | ack ok | 13:56 |
| bauzas | I didn't wanted to blindly recheck | 13:56 |
| gibi | we have open bug and a local fix that does not work on the gate :) | 13:56 |
| bauzas | gibi: great questions by the way on my second patch for preveting BDM creation after RPC timeout | 14:00 |
| bauzas | I wasn't having that level of expertise, you're pushing me into looking at all the oslo.service details :) | 14:00 |
| gibi | yeah my feeling is that we are getting deeper and deeper into a rabbithole | 14:00 |
| gibi | but I haven't had the brain power to offer a real backportable alternative | 14:01 |
| bauzas | fwiw, I care about the first patch in the series, I just offered help for the other patch | 14:02 |
| bauzas | if we don't find a short-term solution for the BDMs being created without calling Cinder, I'm all good | 14:03 |
| bauzas | I just want nova to not delete the wrong BDM (the other case) :-) | 14:03 |
| gibi | OK. we can refocus on the first | 14:03 |
| gibi | I understand your priorities ;) | 14:03 |
| gibi | btw mine is also more complicated than what I pushed. we might want to fixes on that prevent the problem to reapper(that I pushed) and a fix in the periodic to clear the old leaks | 14:04 |
| gibi | *two fixes one that | 14:04 |
| gibi | so I'm poking at the periodic | 14:05 |
| gibi | while fighiting a race condition in the original reproduce as we revert stuff in an untestable order | 14:05 |
| gibi | aaand I will drop for a wile in 25mins so running out of time too | 14:06 |
| bauzas | yeah I need some brain cycles now to look at your patch | 14:06 |
| gibi | if you look just focus on the RPC implications, the rest might change | 14:09 |
| bauzas | I need to load a bit of context, that's it | 14:09 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!