| opendevreview | Merged openstack/nova master: Add regression test for bug 2162835 https://review.opendev.org/c/openstack/nova/+/999977 | 02:59 |
|---|---|---|
| OriginCode | Hi, I'm trying to learn to contribute to Nova, and I could not open https://wiki.openstack.org/wiki/Blueprints | 03:26 |
| amartyasinha | OriginCode: wiki.openstack.org is down, see this for more details: https://lists.opendev.org/archives/list/service-announce@lists.opendev.org/thread/COVTID5W6P4EMXSXGMVFZKV7N53HFO64/?sort=date | 08:11 |
| amartyasinha | You can go through https://docs.openstack.org/nova/latest/contributor/index.html to learn to contribute to Nova. | 08:11 |
| OriginCode | amartyasinha: Thanks for the information | 08:31 |
| opendevreview | Thomas Goirand proposed openstack/nova master: Clear the guestfs forceTCG flag in the libvirt fixture https://review.opendev.org/c/openstack/nova/+/1012663 | 08:31 |
| gibi | zigo: I noticed that you are not updating the reviews I'm commented on but you are opening new reviews with the updated commit. I suggest that when you update a review keep the change id in the commit message intact so that gerrit can recognize that the new commit is a new patchset for an existing review | 08:57 |
| opendevreview | Lucas HENRY proposed openstack/placement master: Declare the unsuffixed request group in mappings https://review.opendev.org/c/openstack/placement/+/1012669 | 09:04 |
| zigo | gibi: If I did that, then that's a mistake, sorry. | 09:10 |
| zigo | Let me fix. | 09:10 |
| zigo | ETOOMANYPATCHES | 09:11 |
| gibi | I see two manager.LOG reviews and two tcg reviews at least | 09:12 |
| zigo | Thanks for letting me know. | 09:12 |
| opendevreview | Thomas Goirand proposed openstack/nova master: Clear the guestfs forceTCG flag in the libvirt fixture https://review.opendev.org/c/openstack/nova/+/1012543 | 09:15 |
| zigo | This one fixed, the duplicate is abandonned. | 09:15 |
| opendevreview | Thomas Goirand proposed openstack/nova master: Mock manager.LOG in the reverts_task_state test https://review.opendev.org/c/openstack/nova/+/1012436 | 09:17 |
| zigo | gibi: I closed that one where you already gave me a +2, so maybe you can add the +2 on this one? ^ | 09:18 |
| gibi | sure :) | 09:21 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test]Catch hanging task at graceful shutdown https://review.opendev.org/c/openstack/nova/+/1003266 | 09:32 |
| gibi | gmaan: ^^ this still shows some leaked tasks during testcase clenaup top of recent master | 09:33 |
| *** elodille1 is now known as elodilles | 12:06 | |
| LarsErikP | just me nagging about this again https://bugs.launchpad.net/nova/+bug/2062127 any hope of actually getting a fix? =) sean-k-mooney[m] ? | 12:26 |
| sean-k-mooney | LarsErikP: honestly i completely forgot about this so i dont know the current state of the patch | 12:38 |
| sean-k-mooney | i think where i left that mroe or less was i added the repoducer dan asked for and rebased the patch for rajat, then Nope noted a bug which i think i fix and then i more or less left it there after dan pointed out a potical logic bug in the patch that i didnt have time to work on fixing | 12:41 |
| sean-k-mooney | i was hopign rajat or someone else would have time to pick that back up | 12:42 |
| LarsErikP | I'm crossing my fingers :P | 12:42 |
| cdent | stephenfin: Only because you might be awake, but anyone else feel free to chime in: I've just released a new version of Paste which does two important things: | 13:25 |
| cdent | fixes a major security issue in paste.session (not relevant for nova as far as I can tell) | 13:26 |
| cdent | deprecates the entire package | 13:26 |
| cdent | Based on a quick review just now, while nova continues to rely on paste.deploy (separately maintained), the only way it really cares about paste itself is in nova/api/openstack/urlmap.py for something that could much more easily be done via stdlib's urllib.parse | 13:27 |
| cdent | I'm in my idle retirement, so providing a patch myself (at least one that is tested) is a bit more than my current access to resources would allow, but line 154 changing to an incatation using urllib.parse.urlsplit ought to do the trick | 13:33 |
| * cdent gazes in some surprise at all the nicks he still recognizes | 13:34 | |
| gibi | cdent: o/ long time no see. How are you these days? | 13:39 |
| gibi | yes we are aware of the urlmap change needed to get rid of the dependency | 13:39 |
| gibi | I'm not sure who subscribed to fix it | 13:39 |
| cdent | hi gibi! I'm good thanks. Like I said, I'm retired and spend most of my time doing ceramics and climbing but every now again someone submits something to paste that raises me from my slumber. | 13:40 |
| gibi | ceramics and climbig sound pretty good | 13:40 |
| cdent | Ah, glad to hear it. The reason I cam to say something about it is that 3.11.0 will raise a DeprecationWarning now | 13:40 |
| gibi | good. that will help us keep remembering to remove it | 13:40 |
| cdent | What about you? You well? | 13:41 |
| gibi | I'm good too thanks. I'm not lucky enough to retire but would be nice to do it. :) Fortunately I still like being around in OpenStack / Nova. Sometimes I even enjoy optimizing placement allocation_candidates generation algo :) | 13:42 |
| cdent | I looked at the placement code a while ago (can't remember why) and thought "gosh, some of this is considerably more complicated than it used to be". I hope it is continues to do a reasonable job. I don't miss work, but I do sometimes miss opensource community stuff. | 13:44 |
| cdent | I'm going to go home and start cooking some stew for dinner. Let me know if there are issues with the new paste. Nice to chat. o/ | 13:47 |
| gibi | placement itself is good. I think nova started using placement in somewhat suboptimal way and figured it out too late | 13:47 |
| gibi | cdent: it was nice indeed | 13:47 |
| gibi | o/ | 13:47 |
| cdent | I'll have to come back sometime and ask you about that suboptimal, sounds interesting. | 13:48 |
| gibi | https://review.opendev.org/c/openstack/nova-specs/+/938070 this summs it up | 13:50 |
| sean-k-mooney | cdent is gone but if you read the scopeback w ehave a patch form stephenfin to remove paste form nova | 13:58 |
| gibi | https://review.opendev.org/c/openstack/nova/+/1005563 | 13:58 |
| gibi | this one | 13:59 |
| gibi | I guess | 13:59 |
| sean-k-mooney | yes... but there was also one i recall reviewing that i and taksi had looked at | 13:59 |
| sean-k-mooney | maybe we jsut dicssed it on irc | 14:00 |
| sean-k-mooney | but it refence form the ptg etherpad | 14:00 |
| sean-k-mooney | ok ya its the same one https://review.opendev.org/c/openstack/nova/+/1005563 | 14:00 |
| sean-k-mooney | so i guess we just chatted about it outsdie fo gerrit | 14:00 |
| sean-k-mooney | stephenfin: can you rebase that when you have time | 14:01 |
| sean-k-mooney | cdent https://etherpad.opendev.org/p/nova-2027.1-ptg#L854 was the ptg topic but ya its as you said we have a very minimal dep and we are just goign to vendor the tiny bit we need and drop it | 14:01 |
| opendevreview | Dan Smith proposed openstack/nova master: Add consumer_type for migration placeholder allocations https://review.opendev.org/c/openstack/nova/+/1012083 | 15:33 |
| opendevreview | Guillaume Boutry proposed openstack/nova master: Skip empty consumers before reshaping allocations https://review.opendev.org/c/openstack/nova/+/1012727 | 15:45 |
| opendevreview | Stephen Finucane proposed openstack/nova master: docs: Cover behavioral changes in microversion guidance https://review.opendev.org/c/openstack/nova/+/1012733 | 16:18 |
| gmaan | gibi: yes, it will show as we have not fixed the migration task leak yet. i am going to implement the fix as part of this cycle graceful shutdown work | 17:32 |
| gmaan | Uggla: can you review this and accordingly i can merge it given gibi +1 there https://review.opendev.org/c/openstack/nova/+/1007750 | 17:38 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tox: Drop py310 targets https://review.opendev.org/c/openstack/nova/+/1012752 | 18:11 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Assert live migration precheck in test_bug_2044235 https://review.opendev.org/c/openstack/nova/+/1012753 | 18:11 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Temporarily cap API version used for live migration tests https://review.opendev.org/c/openstack/nova/+/1012754 | 18:11 |
| opendevreview | Stephen Finucane proposed openstack/nova master: DNM: api: Disable live migration of v2.105 https://review.opendev.org/c/openstack/nova/+/1012755 | 18:11 |
| stephenfin | gmaan: just a reminder about https://review.opendev.org/c/openstack/nova/+/1012429 | 18:35 |
| stephenfin | (it's one of the blockers for us fixing pagination in gophercloud, hence the ask :)) | 18:35 |
| gmaan | stephenfin: i opened it but got distracted, will check this afternoon | 18:36 |
| stephenfin | ty 🙏 | 18:36 |
| stephenfin | sean-k-mooney: won't get to that today, but I'll try to do so tomorrow | 18:36 |
| stephenfin | my approach was a dumb vendoring of what paste.deploy did. I'll see if I can simplify in a follow-up pre cdent's suggestion | 18:37 |
| sean-k-mooney | stephenfin: no worries | 18:43 |
| sean-k-mooney | stephenfin: whas there a second version somewhere? | 18:43 |
| sean-k-mooney | that the only one i found but i tought i was reviweign a diffent version of that elsehwere but it may be been a diffent change entirly | 18:44 |
| stephenfin | I don't think so. I think you're thinking about a different patch, but I don't recall what patch that is either 😅 | 18:44 |
| sean-k-mooney | it was proably one of the oslo ones | 18:44 |
| opendevreview | sean mooney proposed openstack/nova-specs master: Specify atomic PCI passthrough groups for Nova https://review.opendev.org/c/openstack/nova-specs/+/975635 | 19:32 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!