| *** harlowja has quit IRC | 00:00 | |
| *** tsekiyama has quit IRC | 00:09 | |
| *** bknudson has joined #openstack-oslo | 00:17 | |
| *** bknudson has left #openstack-oslo | 00:25 | |
| *** praneshp has quit IRC | 00:25 | |
| *** lbragstad has quit IRC | 00:31 | |
| *** bknudson has joined #openstack-oslo | 00:34 | |
| openstackgerrit | Arnaud Legendre proposed a change to openstack/oslo.vmware: Deprecate RetryDecorator for the retrying package https://review.openstack.org/102379 | 00:46 |
|---|---|---|
| *** dstanek is now known as dstanek_zzz | 00:48 | |
| *** morganfainberg is now known as morganfainberg_Z | 00:57 | |
| *** dstanek_zzz is now known as dstanek | 01:04 | |
| *** praneshp has joined #openstack-oslo | 01:18 | |
| *** lbragstad has joined #openstack-oslo | 01:25 | |
| *** harlowja_ has quit IRC | 01:28 | |
| *** oomichi has quit IRC | 01:29 | |
| *** praneshp_ has joined #openstack-oslo | 01:32 | |
| *** harlowja has joined #openstack-oslo | 01:32 | |
| *** oomichi has joined #openstack-oslo | 01:33 | |
| *** dstanek is now known as dstanek_zzz | 01:34 | |
| *** praneshp has quit IRC | 01:35 | |
| *** praneshp_ is now known as praneshp | 01:35 | |
| *** lbragstad has left #openstack-oslo | 01:37 | |
| *** praneshp has quit IRC | 01:43 | |
| *** lbragstad has joined #openstack-oslo | 01:46 | |
| openstackgerrit | YAMAMOTO Takashi proposed a change to openstack/oslo.messaging: Use assertEqual instead of assertIs for strings https://review.openstack.org/102084 | 01:50 |
| *** morganfainberg_Z is now known as morganfainberg | 02:06 | |
| openstackgerrit | Arnaud Legendre proposed a change to openstack/oslo.vmware: Store PBM wsdl in the oslo.vmware git repository https://review.openstack.org/102409 | 02:17 |
| *** arnaud__ has quit IRC | 02:23 | |
| *** dstanek_zzz is now known as dstanek | 02:26 | |
| *** dims__ has quit IRC | 02:28 | |
| *** openstackgerrit has quit IRC | 02:31 | |
| *** dims__ has joined #openstack-oslo | 02:54 | |
| *** dims__ has quit IRC | 02:58 | |
| *** praneshp has joined #openstack-oslo | 03:04 | |
| *** harlowja is now known as harlowja_away | 03:04 | |
| *** zzzeek has joined #openstack-oslo | 03:24 | |
| *** arnaud__ has joined #openstack-oslo | 03:31 | |
| *** dstanek is now known as dstanek_zzz | 03:32 | |
| *** zhiyan_ is now known as zhiyan | 03:49 | |
| *** dims__ has joined #openstack-oslo | 03:55 | |
| *** dims__ has quit IRC | 03:59 | |
| *** dstanek_zzz is now known as dstanek | 04:25 | |
| *** dstanek is now known as dstanek_zzz | 04:35 | |
| *** lbragstad has quit IRC | 04:45 | |
| *** SridharG has joined #openstack-oslo | 04:52 | |
| *** dims__ has joined #openstack-oslo | 04:56 | |
| *** dstanek_zzz is now known as dstanek | 04:56 | |
| *** ajc_ has joined #openstack-oslo | 04:59 | |
| *** dims__ has quit IRC | 05:00 | |
| *** dstanek is now known as dstanek_zzz | 05:06 | |
| *** zzzeek has quit IRC | 05:14 | |
| *** morganfainberg is now known as morganfainberg_Z | 05:14 | |
| *** markmcclain has joined #openstack-oslo | 05:17 | |
| *** markmcclain1 has joined #openstack-oslo | 05:18 | |
| *** max_lobur has joined #openstack-oslo | 05:20 | |
| *** markmcclain has quit IRC | 05:22 | |
| *** ildikov has quit IRC | 05:27 | |
| *** markmc has joined #openstack-oslo | 05:34 | |
| *** markmcclain1 has quit IRC | 05:39 | |
| *** ihrachyshka has joined #openstack-oslo | 05:46 | |
| *** ihrachyshka has quit IRC | 05:46 | |
| *** praneshp_ has joined #openstack-oslo | 05:47 | |
| *** praneshp has quit IRC | 05:49 | |
| *** praneshp_ is now known as praneshp | 05:49 | |
| *** zzzeek has joined #openstack-oslo | 05:54 | |
| *** ildikov has joined #openstack-oslo | 05:54 | |
| *** dims__ has joined #openstack-oslo | 05:56 | |
| *** dstanek_zzz is now known as dstanek | 05:57 | |
| *** dims__ has quit IRC | 06:01 | |
| *** max_lobur has quit IRC | 06:06 | |
| *** dstanek is now known as dstanek_zzz | 06:07 | |
| *** jaosorior has joined #openstack-oslo | 06:33 | |
| *** arnaud__ has quit IRC | 06:46 | |
| *** SridharG has quit IRC | 06:46 | |
| *** arnaud__ has joined #openstack-oslo | 06:48 | |
| *** max_lobur has joined #openstack-oslo | 06:54 | |
| *** dims__ has joined #openstack-oslo | 06:57 | |
| *** dstanek_zzz is now known as dstanek | 06:57 | |
| *** praneshp has quit IRC | 07:01 | |
| *** dims__ has quit IRC | 07:04 | |
| *** dstanek is now known as dstanek_zzz | 07:07 | |
| *** tkelsey has joined #openstack-oslo | 07:18 | |
| *** zzzeek has quit IRC | 07:19 | |
| *** zzzeek has joined #openstack-oslo | 07:19 | |
| *** zzzeek has quit IRC | 07:27 | |
| *** i159 has joined #openstack-oslo | 07:29 | |
| *** SridharG has joined #openstack-oslo | 07:34 | |
| *** ajo|mac has joined #openstack-oslo | 07:39 | |
| *** arnaud__ has quit IRC | 07:51 | |
| *** ajo|mac has quit IRC | 07:56 | |
| *** ajo|mac has joined #openstack-oslo | 07:57 | |
| *** ajo|mac has quit IRC | 07:58 | |
| *** dstanek_zzz is now known as dstanek | 07:58 | |
| *** mrda is now known as mrda-away | 08:02 | |
| *** ihrachyshka has joined #openstack-oslo | 08:03 | |
| *** dstanek is now known as dstanek_zzz | 08:08 | |
| *** pblaho has joined #openstack-oslo | 08:15 | |
| boris-42 | markmc hi | 08:43 |
| markmc | boris-42, hey | 08:44 |
| boris-42 | markmc I have some small question | 08:44 |
| boris-42 | markmc I just saw some issue in oslo.messaging related to unit tests structure | 08:44 |
| boris-42 | markmc I wanna fix it | 08:45 |
| boris-42 | markmc and do something like this https://review.openstack.org/#/c/102460/ | 08:45 |
| boris-42 | markmc ^ are you interested in such changes? | 08:45 |
| *** eezhova has quit IRC | 08:46 | |
| markmc | boris-42, I'll reply in the review rather than duplicating here | 08:46 |
| boris-42 | markmc so are you ok or not?) I would like just to do the same for rest | 08:47 |
| boris-42 | markmc and one more small question about this file https://github.com/openstack/oslo.messaging/blob/master/oslo/messaging/__init__.py#L16-L23 | 08:48 |
| boris-42 | markmc why do we need to import everything in such manner? | 08:48 |
| boris-42 | markmc it produce actually mess in main module.. | 08:48 |
| ihrachyshka | boris-42: https://github.com/openstack/oslo.messaging/commit/03aafcb49c2c0dded12786c0885945aa821d5b2f | 08:49 |
| boris-42 | ihrachyshka not sure what is the goal of such importnats? | 08:50 |
| boris-42 | why we are creating mess in top module? | 08:50 |
| ihrachyshka | boris-42: there was an API for the library that exposed those symbols. we probably don't want to change that | 08:50 |
| ihrachyshka | it would break lots of existing code | 08:51 |
| markmc | boris-42, 'mess' is subjective, you're welcome to your opinion ... | 08:52 |
| boris-42 | markmc ok probably it's just another style | 08:52 |
| boris-42 | markmc to make a libs | 08:52 |
| markmc | but I'd much rather oslo.messaging.get_transport() rather than oslo.messaging.transport.get_transport() | 08:52 |
| boris-42 | markmc so about moving tests | 08:52 |
| markmc | it was carefully done this way to get a nice public API | 08:52 |
| boris-42 | markmc I don't move test directory | 08:52 |
| boris-42 | markmc I move some test modules deeper in test directory | 08:53 |
| *** openstackgerrit has joined #openstack-oslo | 08:53 | |
| markmc | boris-42, please reply in the review | 08:53 |
| boris-42 | markmc replied =) | 08:53 |
| markmc | boris-42, I misunderstood | 08:53 |
| boris-42 | markmc yep just organizing structure inside of tests/ directory | 08:53 |
| boris-42 | markmc then we have some kind of name spaces, and we are able to use template, test_<name_of_testing_module>.py | 08:54 |
| *** eezhova has joined #openstack-oslo | 08:57 | |
| *** dstanek_zzz is now known as dstanek | 08:59 | |
| openstackgerrit | Boris Pavlovic proposed a change to openstack/oslo.messaging: Fix structure of unit tests in oslo.messaging (part 2) https://review.openstack.org/102470 | 09:02 |
| *** dims has joined #openstack-oslo | 09:02 | |
| *** dims has quit IRC | 09:08 | |
| *** pblaho is now known as pblaho|afk | 09:09 | |
| *** dstanek is now known as dstanek_zzz | 09:09 | |
| openstackgerrit | Boris Pavlovic proposed a change to openstack/oslo.messaging: Fix structure of unit tests in oslo.messaging (part 2) https://review.openstack.org/102470 | 09:11 |
| openstackgerrit | Boris Pavlovic proposed a change to openstack/oslo.messaging: Fix structure of unit tests in oslo.messaging (part 3 last) https://review.openstack.org/102471 | 09:11 |
| openstackgerrit | Max Lobur proposed a change to openstack/oslo.db: Add __contains__ to ModelBase to fully behave like a dict https://review.openstack.org/102008 | 09:15 |
| boris-42 | markmc I think i will improve a bit test coverage | 09:17 |
| boris-42 | markmc after we merge refactoring of structure seems like some modules are not tested.. | 09:18 |
| markmc | boris-42, like? | 09:18 |
| *** amotoki has quit IRC | 09:24 | |
| boris-42 | markmc https://github.com/openstack/oslo.messaging/blob/master/oslo/messaging/_drivers/impl_zmq.py or I missed tests for it | 09:26 |
| *** gcb_ has joined #openstack-oslo | 09:27 | |
| markmc | boris-42, yes https://bugs.launchpad.net/oslo.messaging/+bug/1302941 | 09:27 |
| markmc | mike wilson has some patches proposed | 09:27 |
| boris-42 | markmc does tox -e cover works for you? | 09:27 |
| markmc | haven't tried lately | 09:27 |
| markmc | it did at one point | 09:27 |
| boris-42 | markmc Coverage.py warning: No data was collected. | 09:27 |
| boris-42 | markmc I will try to fix it | 09:28 |
| *** ihrachyshka has quit IRC | 09:44 | |
| *** pblaho|afk is now known as pblaho | 09:56 | |
| openstackgerrit | Radoslav Gerganov proposed a change to openstack/oslo.vmware: Refactor the PBM support https://review.openstack.org/102480 | 09:56 |
| *** dstanek_zzz is now known as dstanek | 10:00 | |
| *** yamahata has quit IRC | 10:08 | |
| *** dstanek is now known as dstanek_zzz | 10:10 | |
| *** gcb_ has quit IRC | 10:11 | |
| *** ihrachyshka has joined #openstack-oslo | 10:17 | |
| *** ihrachyshka has quit IRC | 10:21 | |
| *** ihrachyshka has joined #openstack-oslo | 10:22 | |
| *** gcb_ has joined #openstack-oslo | 10:28 | |
| *** ihrachyshka has quit IRC | 10:47 | |
| *** ihrachyshka has joined #openstack-oslo | 10:47 | |
| *** dstanek_zzz is now known as dstanek | 11:00 | |
| *** dims has joined #openstack-oslo | 11:03 | |
| *** dims has quit IRC | 11:08 | |
| *** yamahata has joined #openstack-oslo | 11:15 | |
| *** gcb_ has quit IRC | 11:16 | |
| *** dims_ has joined #openstack-oslo | 11:19 | |
| *** dims__ has joined #openstack-oslo | 11:22 | |
| *** dims_ has quit IRC | 11:25 | |
| *** tkelsey has quit IRC | 11:33 | |
| *** SridharG has quit IRC | 11:36 | |
| *** erecio has joined #openstack-oslo | 11:44 | |
| *** pblaho is now known as pblaho|afk | 11:48 | |
| *** pblaho|afk is now known as pblaho | 11:51 | |
| *** flaper87|afk is now known as flaper87 | 11:59 | |
| *** jaosorior has quit IRC | 12:02 | |
| *** erecio has quit IRC | 12:11 | |
| *** erecio has joined #openstack-oslo | 12:12 | |
| *** erecio has quit IRC | 12:13 | |
| *** erecio has joined #openstack-oslo | 12:14 | |
| *** jaosorior has joined #openstack-oslo | 12:19 | |
| *** erecio has quit IRC | 12:20 | |
| *** erecio has joined #openstack-oslo | 12:21 | |
| *** ajc_ has quit IRC | 12:23 | |
| *** dims__ has quit IRC | 12:31 | |
| *** dims__ has joined #openstack-oslo | 12:31 | |
| *** lbragstad has joined #openstack-oslo | 12:50 | |
| *** SridharG has joined #openstack-oslo | 12:50 | |
| *** dstanek is now known as dstanek_zzz | 12:53 | |
| *** jecarey has joined #openstack-oslo | 12:54 | |
| *** pblaho is now known as pblaho|afk | 12:55 | |
| *** flaper87 is now known as flaper87|afk | 12:55 | |
| *** tkelsey has joined #openstack-oslo | 12:59 | |
| *** dstanek_zzz is now known as dstanek | 13:00 | |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo.config: Add CLI option support to config fixture https://review.openstack.org/102515 | 13:01 |
| *** pblaho|afk is now known as pblaho | 13:02 | |
| *** mriedem has joined #openstack-oslo | 13:15 | |
| *** pblaho has quit IRC | 13:17 | |
| *** dstanek is now known as dstanek_zzz | 13:20 | |
| *** zzzeek has joined #openstack-oslo | 13:21 | |
| *** dstanek_zzz is now known as dstanek | 13:23 | |
| *** jecarey has quit IRC | 13:25 | |
| *** jecarey has joined #openstack-oslo | 13:25 | |
| openstackgerrit | Radoslav Gerganov proposed a change to openstack/oslo.vmware: Do not log the full session ID https://review.openstack.org/102200 | 13:29 |
| *** markmcclain has joined #openstack-oslo | 13:36 | |
| *** markmcclain1 has joined #openstack-oslo | 13:37 | |
| *** markmcclain1 has quit IRC | 13:38 | |
| openstackgerrit | Radoslav Gerganov proposed a change to openstack/oslo.vmware: Do not log the full session ID https://review.openstack.org/102200 | 13:39 |
| *** markmcclain has quit IRC | 13:40 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-specs: Fix graduate-serialization file name https://review.openstack.org/102530 | 13:44 |
| *** zzzeek has quit IRC | 13:47 | |
| *** ildikov has quit IRC | 14:06 | |
| *** sileht has quit IRC | 14:20 | |
| boris-42 | dhellmann seems like oslo global requirements are broken | 14:21 |
| boris-42 | dhellmann actually this job check-requirements-integration-dsvm fails 100% | 14:22 |
| dhellmann | boris-42: link? | 14:22 |
| boris-42 | dhellmann https://review.openstack.org/#/c/102362/ | 14:22 |
| boris-42 | dhellmann I made a lot of rechecks | 14:22 |
| dhellmann | boris-42: you should talk to the folks in #openstack-infra | 14:23 |
| openstackgerrit | Matt Riedemann proposed a change to openstack/oslo-incubator: Remove unnecessary setUp function https://review.openstack.org/101990 | 14:23 |
| openstackgerrit | Matt Riedemann proposed a change to openstack/oslo-incubator: Move nova.utils.cpu_count() to service.py module https://review.openstack.org/101978 | 14:23 |
| *** sileht has joined #openstack-oslo | 14:23 | |
| mriedem | markmc: this needs a +W again, was just a rebase https://review.openstack.org/#/c/101990/ | 14:24 |
| markmc | mriedem, done | 14:25 |
| mriedem | thanks | 14:25 |
| bnemec | mriedem: Your commit message is wrong. :-P | 14:27 |
| bnemec | s/service.py/processutils.py/ | 14:27 |
| mriedem | bnemec: gdi, i looked at the body but not the title | 14:27 |
| mriedem | go go gerrit commit message edit button | 14:27 |
| openstackgerrit | Matt Riedemann proposed a change to openstack/oslo-incubator: Move nova.utils.cpu_count() to processutils module https://review.openstack.org/101978 | 14:28 |
| mriedem | bnemec: and in using that i outdated your patch :( | 14:28 |
| mriedem | i'll fix and rebase locally | 14:29 |
| bnemec | mriedem: We should probably just rebase that out of the series. It's not dependent anymore. | 14:29 |
| mriedem | you want to do that? | 14:29 |
| *** ildikov has joined #openstack-oslo | 14:30 | |
| *** james_li has joined #openstack-oslo | 14:30 | |
| *** jaosorior has quit IRC | 14:32 | |
| bnemec | mriedem: I'm in a meeting right now, but I could when I get done | 14:32 |
| *** dstanek is now known as dstanek_zzz | 14:34 | |
| openstackgerrit | Ben Nemec proposed a change to openstack/oslo-incubator: Remove unnecessary setUp function https://review.openstack.org/101990 | 14:36 |
| bnemec | mriedem: ^ | 14:37 |
| mriedem | beautiful | 14:38 |
| *** tsekiyama has joined #openstack-oslo | 14:41 | |
| *** morganfainberg_Z is now known as morganfainberg | 14:42 | |
| *** zhiyan is now known as zhiyan_ | 14:43 | |
| *** dstanek_zzz is now known as dstanek | 14:45 | |
| *** markmcclain has joined #openstack-oslo | 14:48 | |
| *** oomichi has quit IRC | 14:52 | |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo-specs: Add oslo-config-generator https://review.openstack.org/102548 | 14:54 |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo.config: Add oslo-config-generator https://review.openstack.org/100946 | 14:55 |
| openstackgerrit | mouad benchchaoui proposed a change to openstack/oslo-incubator: Fix reconnect race condition with RabbitMQ cluster https://review.openstack.org/102555 | 15:18 |
| *** ihrachyshka has quit IRC | 15:23 | |
| *** ajo|mac has joined #openstack-oslo | 15:39 | |
| openstackgerrit | Radoslav Gerganov proposed a change to openstack/oslo.vmware: Refactor the PBM support https://review.openstack.org/102480 | 15:45 |
| *** ajo|mac has quit IRC | 15:46 | |
| *** james_li has quit IRC | 15:47 | |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Implementation Alembic as migration engine https://review.openstack.org/99965 | 15:52 |
| *** i159 has quit IRC | 15:54 | |
| openstackgerrit | Aaron Rosen proposed a change to openstack/oslo.messaging: Replace usage of str() with six.text_type https://review.openstack.org/97362 | 15:57 |
| viktors|afk | bnemec: around? | 15:57 |
| *** viktors|afk is now known as viktors | 15:58 | |
| *** yamahata has quit IRC | 15:58 | |
| bnemec | viktors: Yes | 16:02 |
| viktors | bnemec: Hi! Can I ask you to review a few patches in oslo.db? ) | 16:03 |
| bnemec | viktors: If they're as large as the ones Ilya linked me yesterday then I make no promises. :-) | 16:04 |
| viktors | bnemec: let me ping Ilya, - I'm afraid that it can be the same patches :) | 16:05 |
| bnemec | viktors: https://review.openstack.org/#/c/93398 and https://review.openstack.org/#/c/93424 ? | 16:06 |
| bnemec | They're both open in my browser, but they're both multiple hundreds of lines so they take a while. | 16:07 |
| viktors | bnemec: yes, that’s exactly these patches ) | 16:08 |
| bnemec | viktors: Yeah, they're on my list | 16:09 |
| viktors | bnemec: I just remember, that you had some notes about patch ``Add a base test case for DB schema comparison`` in oslo-incubator before graduation, so you can take look at this patch in oslo.db | 16:10 |
| bknudson | does anyone have tips on how to debug oslo.db with devstack? | 16:10 |
| bknudson | for example with keystone and python-keystoneclient I can just set breakpoints in /opt/stack/keystone/ | 16:10 |
| bknudson | but that doesn't seem to work with oslo.db | 16:10 |
| bnemec | viktors: Oh right, those came from incubator. I'll try to refresh my memory on what I said before. | 16:11 |
| viktors | bknudson: I don't have such experience yet ) | 16:12 |
| viktors | bnemec: ok, thank you | 16:13 |
| bknudson | I'll try just creating a symlink... it says <module 'oslo.db.sqlalchemy.session' from '/usr/local/lib/python2.7/dist-packages/oslo/db/sqlalchemy/session.pyc'> | 16:13 |
| *** praneshp has joined #openstack-oslo | 16:14 | |
| bknudson | symlink works. seems like it should be easier | 16:18 |
| *** amotoki has joined #openstack-oslo | 16:26 | |
| *** jecarey has quit IRC | 16:28 | |
| bnemec | dhellmann: I forget, are we not pip install -e'ing anymore in devstack? Related to bknudson's question about oslo.db above. | 16:38 |
| bnemec | That might explain why setting breakpoints in /opt/stack isn't working. | 16:38 |
| dhellmann | bnemec, bknudson: yes, we had to turn that off to fix the namespace package issue | 16:38 |
| dhellmann | so you should set the breakpoint on the installed copy of the code in /usr/local/... | 16:39 |
| bknudson | dhellmann: ok. I make /usr/local/ ... session.py a symlink into /opt/stack/oslo.db/.../session.py | 16:39 |
| *** arnaud has joined #openstack-oslo | 16:40 | |
| dhellmann | bknudson: if you install *all* of the oslo libs with "pip install -e" then you can just edit them in /opt/stack, but if you only have some of them installed that way imports break. | 16:42 |
| *** pblaho has joined #openstack-oslo | 16:42 | |
| bknudson | dhellmann: does devstack install the oslo libs? | 16:43 |
| dhellmann | bknudson: it installs them, but does not use the -e flag | 16:43 |
| bknudson | dhellmann: or is this something I'd have to do myself? | 16:43 |
| bknudson | was just looking at how it installs keystoneclient -- http://git.openstack.org/cgit/openstack-dev/devstack/tree/lib/keystone#n435 | 16:44 |
| bknudson | and now keystonemiddleware | 16:44 |
| dhellmann | bknudson: right, the oslo libs are different because of the namespace package | 16:45 |
| bknudson | it does setup_install instead of setup_develop | 16:45 |
| bknudson | hehe "TODO(sdague): remove this once we get to Icehouse" | 16:45 |
| openstackgerrit | Doug Hellmann proposed a change to openstack-dev/pbr: Update integration script for Apache 2.4 https://review.openstack.org/102584 | 16:54 |
| *** max_lobur has left #openstack-oslo | 16:55 | |
| dhellmann | boris-42: https://bugs.launchpad.net/pbr/+bug/1334326 | 16:55 |
| *** viktors is now known as viktors|afk | 16:58 | |
| *** harlowja_away is now known as harlowja | 17:13 | |
| *** arnaud__ has joined #openstack-oslo | 17:25 | |
| *** james_li has joined #openstack-oslo | 17:40 | |
| *** flaper87|afk is now known as flaper87 | 17:43 | |
| *** jecarey has joined #openstack-oslo | 17:56 | |
| openstackgerrit | Brant Knudson proposed a change to openstack/oslo.db: Add connection trace for DB2 https://review.openstack.org/92182 | 17:56 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add WBE protocol message version properties https://review.openstack.org/101778 | 17:57 |
| *** arnaud__ has quit IRC | 18:06 | |
| *** arnaud has quit IRC | 18:06 | |
| *** arnaud has joined #openstack-oslo | 18:06 | |
| *** arnaud__ has joined #openstack-oslo | 18:07 | |
| *** zzzeek has joined #openstack-oslo | 18:08 | |
| *** arnaud has quit IRC | 18:10 | |
| *** arnaud__ has quit IRC | 18:10 | |
| *** tkelsey has quit IRC | 18:12 | |
| *** markmc has quit IRC | 18:12 | |
| *** jecarey has quit IRC | 18:23 | |
| *** morganfainberg_L has quit IRC | 18:31 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack-dev/pbr: Update integration script for Apache 2.4 https://review.openstack.org/102584 | 18:38 |
| *** tmcpeak has joined #openstack-oslo | 18:41 | |
| tmcpeak | hey all, I have a few questions about hacking - is this the place to ask? | 18:42 |
| dhellmann | tmcpeak: here or openstack-dev; jogo is the lead on that project | 18:43 |
| tmcpeak | dhellmann: awesome, thank you | 18:43 |
| tmcpeak | jogo: you around? | 18:44 |
| tmcpeak | dhellmann: nice name btw | 18:44 |
| dhellmann | tmcpeak: :-) | 18:47 |
| jogo | tmcpeak: I am about to go AFK for a but | 18:50 |
| jogo | but if hopefully I can point you in the right direction | 18:50 |
| jogo | tmcpeak: I am a little amazed there were no other python packages with that name | 18:51 |
| jogo | tmcpeak: lunch time, but I am happy to answer your questions after | 18:52 |
| *** harlowja has quit IRC | 18:52 | |
| tmcpeak | jogo: cool, I'll catch you after lunch. Thank you. | 18:53 |
| *** openstackgerrit has quit IRC | 19:04 | |
| *** openstackgerrit has joined #openstack-oslo | 19:05 | |
| *** jecarey has joined #openstack-oslo | 19:24 | |
| boris-42 | dhellmann thanks | 19:27 |
| *** eezhova has quit IRC | 19:34 | |
| *** dstanek is now known as dstanek_zzz | 19:34 | |
| *** ihrachyshka has joined #openstack-oslo | 19:41 | |
| *** ajo|mac has joined #openstack-oslo | 19:44 | |
| *** ajo|mac has quit IRC | 19:44 | |
| *** dstanek_zzz is now known as dstanek | 19:45 | |
| *** ajo|mac has joined #openstack-oslo | 19:47 | |
| zzzeek | heya dhellmann , sorry youre the only one here to ask… looking at https://github.com/openstack/oslo.db/commit/f3ece0bb#diff-d5686294b02d35658b4c6125f0981ba2R97 | 19:47 |
| zzzeek | this test IMHO presents a real major issue - it will guaranteed fail if run in any environment that happens to have eventlet installed | 19:47 |
| zzzeek | if oslo.db ever has eventlet as a dependency or if the tests ever need to be run in a more integrated environment, this test cant pass | 19:48 |
| zzzeek | as is the case for me right now, trying to get a test-oslo/nova against SQLAlchemy CI going on my jenkins server | 19:48 |
| *** pblaho has quit IRC | 19:48 | |
| * bnemec hates that threadpool stuff | 19:49 | |
| zzzeek | bnemec: since you’re here, whats the usual way to jump on these things, comment on the review or cerate a new bug ? | 19:49 |
| bnemec | zzzeek: I would create a new bug. The review is already closed so it's possible followup comments will get lost. | 19:50 |
| bnemec | zzzeek: Is it the popping of eventlet from sys.modules that breaks things? | 19:50 |
| zzzeek | no. its the fact that if eventlet is installed, the import will succeed | 19:50 |
| zzzeek | its a poorly written test | 19:51 |
| zzzeek | im not sure what it wants to test | 19:51 |
| *** ihrachyshka has quit IRC | 19:51 | |
| *** ihrachyshka has joined #openstack-oslo | 19:51 | |
| zzzeek | if it wants to test that “import eventlet” fails when eventlet isnt installed, uh, not sure what the point of that is | 19:51 |
| zzzeek | if it wants to test that concurrency.py _api() is called, OK then test that that’s called | 19:52 |
| *** erecio has quit IRC | 19:52 | |
| bnemec | Hmm, I thought the point of the test was to mock out eventlet completely. | 19:52 |
| zzzeek | if you remove it from sys.modules and then say “import eventlet”, it will load, if its installed | 19:54 |
| bnemec | That shouldn't happen until after the test is over though, right? We stick the fake eventlet module in sys.modules and then addCleanup to remove it after the test runs. | 19:56 |
| bnemec | Any imports during the test should be getting the mock version. | 19:56 |
| *** erecio has joined #openstack-oslo | 19:57 | |
| zzzeek | bnemec: the test in question: https://github.com/openstack/oslo.db/commit/f3ece0bb#diff-d5686294b02d35658b4c6125f0981ba2R98 - line 98 | 19:57 |
| zzzeek | note line 106 | 19:57 |
| zzzeek | im working up a patch that uses mock more appropriately there | 19:58 |
| bnemec | zzzeek: Ohhh, yeah that's bad. | 19:58 |
| therve | zzzeek, It won't load after the del? | 19:59 |
| zzzeek | it loads just fine if eventlet is installed in the python environment | 19:59 |
| therve | zzzeek, http://paste.openstack.org/show/84921/ | 20:00 |
| zzzeek | teh top of the module makes claims “we dont have eventlet installed in test-requirements”, this is IMHO far too brittle of an assumption | 20:00 |
| bnemec | Yeah, referencing self.db_api is going to trigger an import. | 20:00 |
| therve | Maybe it's not exactly what's happening, but deleting from sys.modules has some effect | 20:00 |
| zzzeek | bc you dont have greenthread installed | 20:00 |
| bnemec | Actually, the del before that is unnecessary here. | 20:00 |
| zzzeek | therve: im actually getting this test failing | 20:00 |
| therve | I have greenthread installed | 20:01 |
| zzzeek | therve: not sure whats happening on yours | 20:01 |
| therve | Well it's just some import side effect | 20:01 |
| therve | Not saying the test is correct, it also shouldn't do global changes | 20:02 |
| zzzeek | therve: go toa brand new python prompt in that same environment and say “import greenthread” | 20:02 |
| zzzeek | oh from eventlet | 20:03 |
| zzzeek | therve: here’s what that test does wrong: http://paste.openstack.org/show/84924/ | 20:05 |
| zzzeek | it expects ImportError | 20:05 |
| *** openstackgerrit has quit IRC | 20:05 | |
| therve | Ah, right | 20:06 |
| *** openstackgerrit has joined #openstack-oslo | 20:06 | |
| therve | sys.modules['eventlet'] = None perharps? | 20:06 |
| zzzeek | therve: I’m working up putting an alternate Mock in there that wil behave like an ImportError | 20:06 |
| zzzeek | therve: just trying to figure out the logistics of that | 20:06 |
| tmcpeak | jogo: you back? | 20:07 |
| openstackgerrit | Aaron Rosen proposed a change to openstack/oslo.messaging: Replace usage of str() with six.text_type https://review.openstack.org/97362 | 20:08 |
| therve | zzzeek, Just putting None in sys.modules seems to do the trick | 20:14 |
| zzzeek | therve: OK | 20:14 |
| zzzeek | therve: would this form be accepted: http://paste.openstack.org/show/84926/ or does it have to just be ‘sys.modules[‘eventlet’] = None’ | 20:20 |
| therve | zzzeek, Considering the cleanup done it setUp, I'm not sure you have to be so careful | 20:20 |
| therve | Also I'm not a oslo.db developer :) | 20:20 |
| zzzeek | therve: yeah it doesnt. just looks like intent is clearer…. | 20:21 |
| jogo | tmcpeak: back | 20:26 |
| tmcpeak | jogo: cool | 20:27 |
| tmcpeak | jogo: so what I'm trying to do is create some new tests with hacking for basic security stuff | 20:27 |
| tmcpeak | jogo: hacking seems like it would be a nice fit | 20:27 |
| tmcpeak | jogo: what I'm wondering is what is the proper way to go about it. I know I can define local checks | 20:28 |
| tmcpeak | jogo: and a factory and all that good stuff | 20:28 |
| tmcpeak | jogo: what kind of notifications would they throw? the doc said that hacking should only be used to check for things that have already been approved | 20:28 |
| jogo | so what is the example rule you are trying to do? | 20:29 |
| tmcpeak | an example would be looking for Shell=True in os calls | 20:29 |
| jogo | my advice would be start as a local check and once that is working and gains traction we can bring it to hacking as a whole | 20:29 |
| tmcpeak | jogo: ok cool, that sounds good | 20:30 |
| jogo | after the idea gets lazy consensus on the ML (no objections) | 20:30 |
| tmcpeak | jogo: so since it will at first be a local check, what kind of error can it throw? anything I want? it wouldn't have one of those codes | 20:30 |
| jogo | anything yup | 20:30 |
| jogo | projects have there own codes for errors | 20:30 |
| jogo | nova is N | 20:30 |
| jogo | tempest is 'T' etc | 20:30 |
| tmcpeak | jogo: oh ok, perfect | 20:30 |
| tmcpeak | jogo: I'm working on a very basic check for PoC, can I run it by you when I'm a little further along? | 20:31 |
| jogo | tmcpeak: I was just about to say I would be happy to look at it | 20:31 |
| jogo | so yup | 20:31 |
| tmcpeak | jogo: awesome! thank you so much for the help. I think hacking is perfect for this use case | 20:31 |
| jogo | glad to help | 20:32 |
| dhellmann | zzzeek: sorry, stepped out for a bit, but it sounds like you've found a way forward? | 20:34 |
| zzzeek | yeah | 20:34 |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Fix test to not assume eventlet isn't present https://review.openstack.org/102635 | 20:35 |
| dhellmann | zzzeek: what does your environment look like that has eventlet installed? | 20:36 |
| zzzeek | dhellmann: I am creating a special environemnt to run on my jenkins servers that has all the “heavyweight” libs installed systemwide | 20:37 |
| zzzeek | im using a custom tox file | 20:37 |
| bnemec | This will probably also come up in cross testing. | 20:37 |
| bnemec | The other projects are going to pull eventlet into the venv. | 20:37 |
| zzzeek | b.c. this runs on amazon ec2 and building out numpy on an ec2.small is severe | 20:37 |
| dhellmann | bnemec: with cross-testing we would run the tests for the *other* projects with oslo.db installed, so that shouldn't matter | 20:38 |
| dhellmann | zzzeek: the change is fine, I'm just trying to understand how you found the issue | 20:39 |
| bnemec | dhellmann: You would think by now I'd have a handle on how the cross-testing will work, but apparently not. :-) | 20:40 |
| zzzeek | dhellmann: i ran the tests in a venv that has eventlet installed, using the sqla_py27 env you see at the bottom of http://paste.openstack.org/show/84927/ | 20:40 |
| dhellmann | bnemec: keep your brain unbroken | 20:40 |
| bnemec | I would imagine this could be a problem on a devstack system too. Wouldn't that install eventlet system-wide? | 20:40 |
| dhellmann | yes, devstack would do that, but we don't run the unit tests for the lib that way | 20:41 |
| bnemec | Or does oslo.db us no-site-packages (or whatever it's called) | 20:41 |
| dhellmann | yeah, it should have the system site packages blocked | 20:41 |
| zzzeek | this is true, the regular tox for oslo.db prevents this. unless oslo.db ever had a need to actually test against eventlet directly | 20:44 |
| openstackgerrit | Doug Hellmann proposed a change to openstack-dev/pbr: Update integration script for Apache 2.4 https://review.openstack.org/102584 | 20:44 |
| dhellmann | zzzeek: that class will be exercised in integration tests with apps that set up eventlet, but we're not doing it in the unit tests | 20:45 |
| zzzeek | dhellmann: im not sure there’s any real disagreement here :) | 20:46 |
| zzzeek | dhellmann: its just unnecessary to weld the test to that assumption in this case and imho not a great practice overall to assume things are *not* installed, and other weird assumptions about the outside world | 20:47 |
| *** flaper87 is now known as flaper87|afk | 20:47 | |
| *** tmcpeak has left #openstack-oslo | 20:48 | |
| bnemec | Huh. This actually doesn't happen when I run oslo.db tests on a system with eventlet installed. The systemwide eventlet isn't showing up in the venv. | 20:49 |
| dhellmann | zzzeek: yeah, like I said, the change is fine. I asked viktors|afk and roman to add a test like that to verify the class, and we didn't want to require eventlet since we weren't going to actually do anything with the pool | 20:50 |
| dhellmann | bnemec: it won't, zzzeek has a *different* venv with both libs installed | 20:50 |
| bnemec | dhellmann: Yeah, for some reason I just thought the system packages would be visible inside the venv too. Obviously not though. | 20:52 |
| dhellmann | bnemec: there's a flag to control that, and we have it set to make them not visible because otherwise we have trouble with the namespace package | 20:53 |
| *** ajo|mac has quit IRC | 20:53 | |
| *** ajo|mac has joined #openstack-oslo | 20:54 | |
| dhellmann | jogo: https://review.openstack.org/#/c/96961/ has landed, are we ready to merge https://review.openstack.org/#/c/97344/ now? | 20:55 |
| *** erecio has quit IRC | 20:56 | |
| jogo | dhellmann: yup just +Wed | 21:02 |
| *** ajo|mac has quit IRC | 21:02 | |
| jogo | http://docs.openstack.org/developer/oslo.i18n/guidelines.html is way nicer then the wiki | 21:02 |
| dhellmann | jogo: yeah, more formatting options and a review process | 21:03 |
| dhellmann | jogo: thanks! | 21:03 |
| *** SridharG has quit IRC | 21:22 | |
| *** HenryG has quit IRC | 21:23 | |
| *** SridharG has joined #openstack-oslo | 21:24 | |
| *** harlowja has joined #openstack-oslo | 21:28 | |
| *** ihrachyshka has quit IRC | 21:35 | |
| *** SridharG has quit IRC | 21:37 | |
| *** mrda-away is now known as mrda | 21:37 | |
| *** SridharG has joined #openstack-oslo | 21:38 | |
| *** SridharG has quit IRC | 21:39 | |
| *** ajo|mac has joined #openstack-oslo | 21:59 | |
| *** dims__ has quit IRC | 22:01 | |
| *** lbragstad has quit IRC | 22:02 | |
| *** markmcclain has quit IRC | 22:08 | |
| *** james_li has quit IRC | 22:08 | |
| *** dims__ has joined #openstack-oslo | 22:25 | |
| *** openstackgerrit has quit IRC | 22:35 | |
| *** openstackgerrit has joined #openstack-oslo | 22:36 | |
| *** markmcclain has joined #openstack-oslo | 22:45 | |
| *** markmcclain has quit IRC | 22:49 | |
| *** jecarey has quit IRC | 22:53 | |
| *** mriedem has quit IRC | 22:54 | |
| *** zzzeek has quit IRC | 22:59 | |
| *** markmcclain has joined #openstack-oslo | 23:01 | |
| *** oomichi has joined #openstack-oslo | 23:30 | |
| *** ajo|mac has quit IRC | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!