*** mestery has quit IRC | 00:04 | |
*** tsekiyama has quit IRC | 00:06 | |
*** sileht has quit IRC | 00:06 | |
*** yamahata has joined #openstack-oslo | 00:14 | |
*** dstanek is now known as dstanek_zzz | 00:24 | |
*** dstanek_zzz is now known as dstanek | 00:45 | |
*** dstanek is now known as dstanek_zzz | 00:55 | |
*** markmcclain has quit IRC | 01:03 | |
*** lbragstad has joined #openstack-oslo | 01:11 | |
*** markmcclain has joined #openstack-oslo | 01:26 | |
*** markmcclain has quit IRC | 01:28 | |
*** dstanek_zzz is now known as dstanek | 01:46 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Move failure to its own type specific module https://review.openstack.org/102091 | 01:51 |
---|---|---|
*** mestery has joined #openstack-oslo | 02:30 | |
*** jecarey has joined #openstack-oslo | 02:30 | |
*** HenryG has joined #openstack-oslo | 02:36 | |
*** praneshp has quit IRC | 02:37 | |
*** yamahata has quit IRC | 02:52 | |
*** yamahata has joined #openstack-oslo | 02:53 | |
*** jecarey has quit IRC | 02:55 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Move failure to its own type specific module https://review.openstack.org/102091 | 02:57 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Hoist the notifier to its own module https://review.openstack.org/102372 | 02:58 |
*** praneshp has joined #openstack-oslo | 03:17 | |
*** lbragstad has quit IRC | 03:38 | |
*** zhiyan_ is now known as zhiyan | 03:55 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Move failure to its own type specific module https://review.openstack.org/102091 | 04:02 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Hoist the notifier to its own module https://review.openstack.org/102372 | 04:03 |
*** dstanek is now known as dstanek_zzz | 04:07 | |
*** praneshp has quit IRC | 04:11 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Move failure to its own type specific module https://review.openstack.org/102091 | 04:12 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Hoist the notifier to its own module https://review.openstack.org/102372 | 04:13 |
openstackgerrit | garyk proposed a change to openstack/oslo.vmware: Add exception NoRootDiskDefined https://review.openstack.org/102714 | 04:24 |
*** praneshp has joined #openstack-oslo | 04:32 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use a common message dispatcher https://review.openstack.org/101094 | 04:44 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Move failure to its own type specific module https://review.openstack.org/102091 | 04:47 |
*** praneshp_ has joined #openstack-oslo | 04:47 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Hoist the notifier to its own module https://review.openstack.org/102372 | 04:48 |
*** praneshp has quit IRC | 04:50 | |
*** praneshp_ is now known as praneshp | 04:50 | |
*** dstanek_zzz is now known as dstanek | 04:58 | |
*** ajc_ has joined #openstack-oslo | 04:59 | |
*** SridharG has joined #openstack-oslo | 05:00 | |
*** dims__ has quit IRC | 05:40 | |
*** harlowja is now known as harlowja_away | 05:49 | |
openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo.messaging: Add 'docs' tox environment https://review.openstack.org/102728 | 05:52 |
openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo.messaging: Add missing docs for list_opts() https://review.openstack.org/102729 | 05:53 |
openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo.messaging: Remove duplicate docs for MessageHandlingServer https://review.openstack.org/102731 | 05:53 |
openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo.messaging: Fix formatting of TransportURL.parse() docs https://review.openstack.org/102732 | 05:53 |
*** zhiyan is now known as zhiyan_ | 06:13 | |
*** zhiyan_ is now known as zhiyan | 06:14 | |
*** dstanek is now known as dstanek_zzz | 06:18 | |
*** ildikov has quit IRC | 06:31 | |
openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo.config: Add oslo-config-generator https://review.openstack.org/100946 | 06:34 |
*** dims__ has joined #openstack-oslo | 06:36 | |
*** dims__ has quit IRC | 06:41 | |
*** jaosorior has joined #openstack-oslo | 06:42 | |
*** sileht has joined #openstack-oslo | 06:44 | |
*** pblaho has joined #openstack-oslo | 07:06 | |
*** openstackgerrit has quit IRC | 07:07 | |
*** ildikov has joined #openstack-oslo | 07:16 | |
*** mrda is now known as manslaughter | 07:20 | |
*** manslaughter is now known as mrda | 07:22 | |
*** tkelsey has joined #openstack-oslo | 07:22 | |
*** oomichi has quit IRC | 07:23 | |
*** i159 has joined #openstack-oslo | 07:28 | |
*** dims__ has joined #openstack-oslo | 07:30 | |
*** dims__ has quit IRC | 07:35 | |
*** praneshp has quit IRC | 07:38 | |
*** ihrachyshka has joined #openstack-oslo | 07:55 | |
*** nacim has joined #openstack-oslo | 08:05 | |
*** mrda is now known as mrda-away | 08:08 | |
*** prashanthr_ has joined #openstack-oslo | 08:15 | |
prashanthr_ | hi I would like to add a redis backend to oslo cache. | 08:16 |
prashanthr_ | is there any existing blueprint / is a new one to be created ? | 08:16 |
*** viktors|afk is now known as viktors | 08:25 | |
*** dims__ has joined #openstack-oslo | 08:31 | |
*** dims__ has quit IRC | 08:36 | |
ihrachyshka | prashanthr_: have you googled for it? I think there's one | 08:41 |
prashanthr_ | ihrachyska: https://blueprints.launchpad.net/oslo/+spec/cache-redis-backend . Is this the one ? | 08:42 |
ihrachyshka | prashanthr_: obviously, yes | 08:42 |
prashanthr_ | but this one looks quite old. | 08:43 |
prashanthr_ | hmm in 2013. | 08:43 |
ihrachyshka | prashanthr_: just ping the author on update | 08:44 |
prashanthr_ | ihrachyska: Okay sure. | 08:44 |
prashanthr_ | thanks | 08:44 |
prashanthr_ | :) | 08:44 |
*** pblaho is now known as pblaho|afk | 09:22 | |
*** pblaho|afk is now known as pblaho | 09:27 | |
*** GheRivero has quit IRC | 09:31 | |
*** dims__ has joined #openstack-oslo | 09:32 | |
*** GheRivero has joined #openstack-oslo | 09:33 | |
*** dims__ has quit IRC | 09:37 | |
*** markmc has joined #openstack-oslo | 09:41 | |
*** ajo|mac has joined #openstack-oslo | 09:51 | |
*** prashanthr_ has quit IRC | 09:57 | |
*** pblaho is now known as pblaho|afk | 10:20 | |
*** eezhova has joined #openstack-oslo | 10:27 | |
*** dims__ has joined #openstack-oslo | 10:40 | |
*** eezhova has quit IRC | 10:57 | |
markmc | boris-42, please stop with the 'recheck no bug' | 10:58 |
boris-42 | markmc ok) | 10:58 |
markmc | boris-42, we need to understand failures, file bugs, file e-r queries, etc. | 10:58 |
boris-42 | markmc there is bug for fake? | 10:58 |
markmc | boris-42, e.g. http://logs.openstack.org/82/102782/1/check/check-oslotest-dsvm-oslo.messaging/7958c0e/console.html | 10:58 |
boris-42 | markmc yep I am trying to fix it now | 10:58 |
boris-42 | markmc actually | 10:58 |
boris-42 | markmc so I should make a bug? | 10:59 |
boris-42 | markmc and then recheck bug? | 10:59 |
markmc | boris-42, yes, check whether there's a bug, file one if not, use that in recheck | 10:59 |
boris-42 | markmc could you config it https://bugs.launchpad.net/oslo.messaging/+bug/1334607 ? | 11:01 |
boris-42 | markmc and add priority? | 11:01 |
markmc | boris-42, wow, you used 'recheck no bug' 12 times in oslo.messaging in the last 24 hours! | 11:02 |
boris-42 | markmc yep | 11:02 |
boris-42 | markmc and most of them were related to this bug | 11:02 |
markmc | boris-42, once or twice would be ok, maybe - but that many times is totally abusing our CI system | 11:02 |
boris-42 | markmc okay I am going to fix this bug | 11:02 |
boris-42 | markmc I think I know where is issue | 11:02 |
boris-42 | markmc sorry for rechecks=) | 11:02 |
markmc | boris-42, ok, thanks | 11:02 |
boris-42 | markmc so one question | 11:03 |
boris-42 | markmc I will push script (and probably we will need to recheck multiply times, to ensure that everything works) | 11:04 |
boris-42 | markmc /script/patch** | 11:04 |
*** ildikov_ has joined #openstack-oslo | 11:04 | |
boris-42 | markmc so do recheck bug #xxx | 11:04 |
boris-42 | ? | 11:04 |
*** ildikov has quit IRC | 11:04 | |
markmc | boris-42, recheck no bug would be fine for that | 11:05 |
*** ajo|mac has quit IRC | 11:06 | |
*** ajo|mac has joined #openstack-oslo | 11:07 | |
*** ajo|mac has quit IRC | 11:13 | |
*** ajo|mac has joined #openstack-oslo | 11:14 | |
*** ajo|mac has quit IRC | 11:19 | |
*** flaper87|afk is now known as flaper87 | 11:19 | |
*** ajo|mac has joined #openstack-oslo | 11:20 | |
*** yamahata has quit IRC | 11:21 | |
boris-42 | markmc https://review.openstack.org/#/c/102800/1 if this will work we have crap with stevedore | 11:23 |
boris-42 | markmc In Rally we have much better approach for plugins (so we can reuse the same approach in oslo.messaging) it works perfect and doesn't require any configuration | 11:23 |
markmc | boris-42, "stevedore is crap, Rally has something much better" isn't how I like to start a technical discussion | 11:24 |
boris-42 | markmc =) | 11:25 |
boris-42 | markmc holywars stile=) | 11:25 |
boris-42 | markmc but let's just see will it work | 11:25 |
boris-42 | markmc if it works we will need to fix stevedore or use another (probably better) approach | 11:26 |
*** ajo|mac has quit IRC | 11:26 | |
*** ajo|mac has joined #openstack-oslo | 11:27 | |
*** pblaho|afk is now known as pblaho | 11:32 | |
*** ajo|mac has quit IRC | 11:33 | |
*** ajo|mac has joined #openstack-oslo | 11:34 | |
*** pblaho is now known as pblaho|afk | 11:42 | |
*** pblaho|afk is now known as pblaho | 11:46 | |
*** lbragstad has joined #openstack-oslo | 11:52 | |
*** lbragstad has quit IRC | 11:56 | |
*** erecio has joined #openstack-oslo | 12:13 | |
ihrachyshka | markmc: around? I have a question regarding log translation | 12:22 |
markmc | ihrachyshka, sure | 12:22 |
ihrachyshka | markmc: there was additional_locale proposed as a new config option, but was rejected | 12:23 |
ihrachyshka | markmc: meaning, no way to translate logs? | 12:23 |
markmc | ihrachyshka, got a link? | 12:23 |
ihrachyshka | markmc: there are some references to 'sample config file to be provided' in launchpad and irc logs though | 12:23 |
ihrachyshka | but I miss context on what it is | 12:23 |
ihrachyshka | markmc: https://review.openstack.org/#/c/62508/ | 12:23 |
ihrachyshka | part of https://blueprints.launchpad.net/oslo/+spec/i18n-messages | 12:23 |
ihrachyshka | sorry, the reference is in gerrit, not LP | 12:24 |
markmc | ok | 12:27 |
markmc | you can have the logs be translated just by running the service in a different locale | 12:27 |
*** openstackgerrit has joined #openstack-oslo | 12:27 | |
markmc | if you want to log in *multiple* languages at once, you need to do that via logging.conf | 12:27 |
markmc | ihrachyshka, does that make sense? | 12:28 |
ihrachyshka | markmc: what is that logging.conf? | 12:28 |
markmc | ihrachyshka, standard python logging configuration file | 12:29 |
ihrachyshka | aha. where is it located? how can I configure it? | 12:29 |
markmc | ihrachyshka, see log-config-append config option in openstack.common.log | 12:29 |
markmc | nova has etc/nova/logging_sample.conf | 12:30 |
markmc | # The name of a logging configuration file. This file is appended to | 12:31 |
markmc | # any existing logging configuration files. For details about logging | 12:31 |
markmc | # configuration files, see the Python logging module documentation. | 12:31 |
markmc | # (string value) | 12:31 |
markmc | # Deprecated group/name - [DEFAULT]/log_config | 12:31 |
markmc | #log_config_append = <None> | 12:31 |
ihrachyshka | markmc: I see. is there any config example to get multiple languages logged? | 12:36 |
markmc | ihrachyshka, no, but I suspect dhellmann could get you pointed in the right direction quickly | 12:36 |
ihrachyshka | ok, thanks | 12:36 |
markmc | ihrachyshka, if you do figure it out, be sure to submit a sample for oslo.i18n docs | 12:36 |
ihrachyshka | :) | 12:37 |
*** ildikov_ has quit IRC | 12:39 | |
*** dstanek_zzz is now known as dstanek | 12:39 | |
openstackgerrit | Sean Dague proposed a change to openstack-dev/pbr: Update integration script for Apache 2.4 https://review.openstack.org/102584 | 12:44 |
dhellmann | ihrachyshka: you need to set up a TranslationHandler. There's an example at the bottom of http://docs.openstack.org/developer/oslo.i18n/api.html#module-oslo.i18n.log | 12:51 |
*** ildikov has joined #openstack-oslo | 12:52 | |
*** zzzeek has joined #openstack-oslo | 12:56 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.i18n: Remove mention of Message objects from public docs https://review.openstack.org/102819 | 12:57 |
*** ajc_ has quit IRC | 13:00 | |
*** lbragstad has joined #openstack-oslo | 13:02 | |
*** dstanek is now known as dstanek_zzz | 13:02 | |
*** dstanek_zzz is now known as dstanek | 13:04 | |
*** mriedem has joined #openstack-oslo | 13:08 | |
ihrachyshka | dhellmann: I've tried to set that as follows: http://paste.fedoraproject.org/113441/40378809/ | 13:08 |
ihrachyshka | messages are still not translated | 13:08 |
*** flaper87 is now known as flaper87|afk | 13:10 | |
ihrachyshka | locale is there in 'locale -a' list | 13:10 |
ihrachyshka | hm, it's actually devstack installation. shouldn't we have .po files compiled into .mo somewhere? I can't find them | 13:11 |
markmc | hehe | 13:12 |
*** pblaho is now known as pblaho|afk | 13:12 | |
markmc | ihrachyshka, sorry, I'm really LOLing here | 13:12 |
* markmc starts to cry now | 13:12 | |
markmc | yes, we do all this work for translating stuff and never actually install those translations in a way they can be used | 13:12 |
* ihrachyshka is confused | 13:12 | |
ihrachyshka | ah, got it :) | 13:13 |
ihrachyshka | no one cares about use cases. let's do some engineering! | 13:13 |
markmc | https://etherpad.openstack.org/p/havana-oslo-i18n-strategy | 13:13 |
markmc | as long as we give the translators tonnes of work to do, everyone's happy | 13:13 |
*** dstanek is now known as dstanek_zzz | 13:14 | |
ihrachyshka | yeah, I guess localizers also find lots of fun from the process | 13:14 |
*** zzzeek has quit IRC | 13:14 | |
markmc | Making sure translations get compiled and installed correctly | 13:14 |
markmc | devstack needs to run setup.py compile_catalog | 13:14 |
ihrachyshka | ok, I see the very last line | 13:14 |
dhellmann | ihrachyshka, markmc : if one of you will open a bug about that against devstack, I can see if daisy can find someone from the translation team to make a patch | 13:15 |
dhellmann | they're going to need to do that to add the testing required to make translations mandatory anyway | 13:15 |
markmc | yeah | 13:16 |
dhellmann | I think part of the problem in the past has been most devs don't care about translations, and most translators aren't devs, so they each focus on their own half of the work and don't talk much | 13:16 |
ihrachyshka | markmc: where does compile_catalog target come from? | 13:16 |
markmc | ihrachyshka, babel installs setuptools commands AFAIR | 13:16 |
markmc | babel installs setup.py commands: | 13:16 |
markmc | extract_messages - pull strings marked with _() into e.g. nova.pot | 13:16 |
markmc | compile_catalog - compile .po files into .mo files | 13:16 |
markmc | update_catalog - copy strings from .pot into .po | 13:16 |
markmc | (that's from the etherpad too) | 13:16 |
ihrachyshka | ah, ok, thanks | 13:17 |
markmc | dhellmann, https://bugs.launchpad.net/nova/+bug/995287 | 13:17 |
dhellmann | markmc: thanks | 13:17 |
ihrachyshka | not that I'm too interested in the topic, but our QA asked me for directions on how to verify that it works since Icehouse. and now I dig it. :) | 13:17 |
markmc | dhellmann, that's why I added those LOCALEDIR env variables AFAIR | 13:18 |
dhellmann | ah, I wondered what all that was for | 13:18 |
markmc | hehe | 13:19 |
markmc | it's all summarized in that bug | 13:19 |
* markmc couldn't be bothered re-reading it all | 13:19 | |
openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo.config: Add oslo-config-generator https://review.openstack.org/100946 | 13:20 |
*** ildikov has quit IRC | 13:22 | |
dhellmann | markmc: I'm sending that to daisy to look at. She has said she'll find someone in IBM to do the work and she'll manage it. | 13:22 |
*** pblaho|afk is now known as pblaho | 13:22 | |
markmc | great | 13:22 |
markmc | it was pretty much just daisy and I at that havana summit session AFAIR | 13:23 |
dhellmann | yeah, we had a few more people interested in icehouse, but it's a small group | 13:23 |
dhellmann | they did a lot of work on the lazy translation stuff last cycle, but haven't been very engaged this cycle | 13:23 |
markmc | no shortage of people interested in submitting patches to change the translation markers for log messages though :) | 13:24 |
markmc | I sometimes wonder has anyone ever ran any openstack service with translations enabled | 13:25 |
ihrachyshka | dhellmann: this will cover devstack. how about distributions? does it mean all packagers should make sure setup.py compile_catalog is called? 'cause I don't see neither .mo files nor this target called in redhat packaging :) | 13:25 |
markmc | ihrachyshka, yes | 13:25 |
markmc | ihrachyshka, and possibly you need to set the LOCALEDIR env variables in e.g. systemd targets | 13:25 |
ihrachyshka | markmc: good to know we have such a 'minor' bug in packaging :P | 13:25 |
* markmc passes the tissues | 13:26 | |
dhellmann | ihrachyshka: yes, the distros are responsible for that | 13:26 |
markmc | (for crying) | 13:26 |
ihrachyshka | markmc: what are LOCALEDIR for? wouldn't gettext be able to find catalog in default path? | 13:26 |
markmc | ihrachyshka, I don't remember, maybe they're just needed for devstack | 13:27 |
markmc | ihrachyshka, but yes, you're probably right - packages would install the catalogs in the default path | 13:27 |
ihrachyshka | dhellmann: so, devstack will be handled by daisy, right? no need for bug? | 13:30 |
markmc | ihrachyshka, https://bugs.launchpad.net/devstack/+bug/995287 | 13:32 |
ihrachyshka | ah, ok, that's already there | 13:33 |
dhellmann | ihrachyshka: if you want to make a patch, I'm sure she'd be happy for you to do that :-) | 13:33 |
ihrachyshka | dhellmann: ok, putting it in todo list somewhere after 'high priority stuff' | 13:34 |
*** dstanek_zzz is now known as dstanek | 13:34 | |
dhellmann | ihrachyshka: if you don't get to it, she's likely to find someone, so no worries | 13:35 |
ihrachyshka | roger | 13:35 |
ihrachyshka | ok, at least now I can tell our QA that "no, you can't check translated logs, because we don't even ship translations" lol | 13:36 |
markmc | heh, job done | 13:36 |
openstackgerrit | Chuck Short proposed a change to openstack-dev/pbr: Add Python 3.4 checking https://review.openstack.org/102828 | 13:44 |
openstackgerrit | Chuck Short proposed a change to openstack-dev/hacking: Add Python 3.4 checking https://review.openstack.org/102829 | 13:47 |
*** jecarey has joined #openstack-oslo | 13:54 | |
openstackgerrit | Radoslav Gerganov proposed a change to openstack/oslo.vmware: Add 'NoRootDiskDefined' exception https://review.openstack.org/102833 | 13:58 |
*** markmcclain has joined #openstack-oslo | 14:02 | |
*** nacim has quit IRC | 14:04 | |
*** ajo|mac has quit IRC | 14:07 | |
*** ajo|mac has joined #openstack-oslo | 14:09 | |
*** markmc has quit IRC | 14:11 | |
*** ildikov has joined #openstack-oslo | 14:18 | |
*** bknudson has quit IRC | 14:27 | |
boris-42 | markmc seems like that dirty hack works | 14:38 |
*** ajo|mac has quit IRC | 14:40 | |
dhellmann | boris-42: why isn't the fake driver loading normally? | 14:43 |
boris-42 | dhellmann I don't know I am going to deep dive in configuration of stevedore | 14:44 |
boris-42 | dhellmann but if we force import in test module | 14:44 |
boris-42 | dhellmann it works without issues | 14:44 |
boris-42 | dhellmann I can recheck 4th time | 14:44 |
dhellmann | boris-42: this feels like a test execution order issue | 14:45 |
boris-42 | dhellmann yep | 14:46 |
boris-42 | dhellmann if this module is not imported in some other test | 14:46 |
boris-42 | some other test module* | 14:46 |
boris-42 | this fails | 14:46 |
dhellmann | so which test is triggering the fake driver to be loaded as a side-effect? | 14:46 |
boris-42 | dhellmann I don't know yet =) | 14:46 |
boris-42 | dhellmann as I say need to deep dive into this =) | 14:46 |
dhellmann | ok | 14:47 |
boris-42 | dhellmann newbie in oslo.messaging=) | 14:47 |
boris-42 | I am newbie* | 14:47 |
* dhellmann nods | 14:47 | |
boris-42 | dhellmann btw https://review.openstack.org/#/c/102470/ and https://review.openstack.org/#/c/102471/ quite simple and ready to merge with +2 =) | 14:47 |
dhellmann | boris-42: is the change you're having trouble with in the same series as those? | 14:48 |
boris-42 | dhellmann nope it's just restruct of unit test | 14:49 |
boris-42 | dhellmann to understand what modules are not tested | 14:49 |
boris-42 | dhellmann and what are tested | 14:49 |
*** ajo|mac has joined #openstack-oslo | 14:49 | |
dhellmann | ok, I wondered if that restructuring caused something to happen in a different order | 14:49 |
boris-42 | dhellmann I don't think so=) | 14:49 |
boris-42 | dhellmann I just would like to help oslo.messaging with unit testing | 14:49 |
boris-42 | dhellmann and code cleanup / improvement | 14:50 |
*** pblaho is now known as pblaho|afk | 14:50 | |
*** nacim has joined #openstack-oslo | 14:50 | |
*** pblaho|afk is now known as pblaho | 14:51 | |
dhellmann | boris-42: ok, I'm working on that requirements issue still today, so it may be a while before I get to review anything | 14:52 |
boris-42 | dhellmann no worries, I am not blocked with it | 14:52 |
boris-42 | dhellmann cause I have to merge patch in ceilometer =) | 14:52 |
boris-42 | dhellmann and it doesn't depend on osprofiler | 14:52 |
boris-42 | dhellmann (btw thanks for fixing it) | 14:52 |
*** dstanek is now known as dstanek_zzz | 14:55 | |
*** tongli has joined #openstack-oslo | 14:56 | |
*** tsekiyama has joined #openstack-oslo | 14:57 | |
*** hyakuhei__ is now known as hyakuhei_ | 15:11 | |
*** james_li has joined #openstack-oslo | 15:12 | |
*** erecio has quit IRC | 15:14 | |
*** zzzeek has joined #openstack-oslo | 15:17 | |
*** ajo|mac has quit IRC | 15:21 | |
*** dims__ has quit IRC | 15:21 | |
*** dims__ has joined #openstack-oslo | 15:22 | |
*** ajo|mac has joined #openstack-oslo | 15:22 | |
openstackgerrit | Thomas Herve proposed a change to openstack/oslo.messaging: Fix info method of ListenerSetupMixin https://review.openstack.org/102860 | 15:23 |
*** ajo|mac has quit IRC | 15:28 | |
*** dstanek_zzz is now known as dstanek | 15:28 | |
*** ajo|mac has joined #openstack-oslo | 15:29 | |
*** nacim has quit IRC | 15:30 | |
*** ajo|mac has quit IRC | 15:35 | |
*** ajo|mac has joined #openstack-oslo | 15:36 | |
openstackgerrit | Sean Dague proposed a change to openstack-dev/pbr: Update integration script for Apache 2.4 https://review.openstack.org/102584 | 15:37 |
*** markmcclain has quit IRC | 15:38 | |
zzzeek | hey bnemec : what exactly is the “negative test” you’re referring to on https://review.openstack.org/#/c/93398/? trying to parse that | 15:38 |
bnemec | zzzeek: I'm looking for something where the model doesn't match the migration. | 15:39 |
bnemec | Basically a case where the test would fail. | 15:39 |
bnemec | It's nice that the test passes, but for all I know there's a logic error somewhere that means we aren't actually checking anything. :-) | 15:40 |
bnemec | (probably not, but I've seen it happen before) | 15:40 |
zzzeek | oh i see | 15:40 |
*** ajo|mac has quit IRC | 15:41 | |
*** erecio has joined #openstack-oslo | 15:42 | |
zzzeek | there’s kind of a crapload of classes here? i thought I made complicaed hierarchies…. | 15:43 |
*** nacim has joined #openstack-oslo | 15:43 | |
*** dstanek is now known as dstanek_zzz | 15:52 | |
*** jaosorior has quit IRC | 16:02 | |
*** dshulyak has quit IRC | 16:04 | |
*** bknudson has joined #openstack-oslo | 16:05 | |
*** ajo|mac has joined #openstack-oslo | 16:06 | |
*** ajo|mac has quit IRC | 16:11 | |
openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Implementation Alembic as migration engine https://review.openstack.org/99965 | 16:17 |
*** erecio has quit IRC | 16:20 | |
*** i159 has quit IRC | 16:21 | |
*** pblaho is now known as pblaho|afk | 16:25 | |
*** erecio has joined #openstack-oslo | 16:27 | |
*** pblaho|afk is now known as pblaho | 16:29 | |
*** zhiyan is now known as zhiyan_ | 16:32 | |
*** nacim has quit IRC | 16:34 | |
*** viktors is now known as viktors|afk | 16:34 | |
*** jaosorior has joined #openstack-oslo | 16:48 | |
*** dstanek_zzz is now known as dstanek | 16:57 | |
*** pblaho has quit IRC | 17:00 | |
zzzeek | is ilya here? | 17:01 |
* zzzeek sees no nickname that looks like “ilya pekelny” … | 17:02 | |
*** hyakuhei_ is now known as hyakuhei | 17:02 | |
*** hyakuhei has quit IRC | 17:02 | |
*** hyakuhei has joined #openstack-oslo | 17:02 | |
*** praneshp has joined #openstack-oslo | 17:04 | |
*** harlowja_away is now known as harlowja | 17:10 | |
*** james_li has quit IRC | 17:14 | |
bnemec | zzzeek: I think he's i159, but it looks like he left a bit ago. | 17:14 |
zzzeek | ok | 17:15 |
*** ildikov has quit IRC | 17:16 | |
*** markmcclain has joined #openstack-oslo | 17:16 | |
*** markmcclain1 has joined #openstack-oslo | 17:18 | |
*** markmcclain has quit IRC | 17:20 | |
*** dstanek is now known as dstanek_zzz | 17:25 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Clarify locked decorator is for instance methods https://review.openstack.org/98691 | 17:25 |
*** ihrachyshka has quit IRC | 17:25 | |
*** markmcclain1 has quit IRC | 17:57 | |
*** james_li has joined #openstack-oslo | 17:58 | |
*** ildikov has joined #openstack-oslo | 18:03 | |
mriedem | jecarey: got an i18n bug in glance | 18:12 |
mriedem | https://bugs.launchpad.net/glance/+bug/1334774 | 18:12 |
mriedem | unicode error slipped in | 18:12 |
mriedem | doing this on an exception: msg = "Forbidden upload attempt: %s" % e | 18:13 |
mriedem | i believe that is supposed to be: msg = "Forbidden upload attempt: %s" % str(e) | 18:13 |
mriedem | now right? | 18:13 |
jecarey | No ... shouldn't put a str() on it ... should work without the str on it ... format should do the right thing. | 18:14 |
*** dstanek_zzz is now known as dstanek | 18:14 | |
jecarey | self.assertIn('Attempted: 2, Maximum: 1', str(exc)) | 18:15 |
jecarey | should be using six.text_type() | 18:15 |
dhellmann | mriedem, jecarey : add the text_type around the string and leave the exception object unwrapped | 18:18 |
dhellmann | better yet, just prefix the string with u as a unicode literal | 18:18 |
*** jokke_ has joined #openstack-oslo | 18:19 | |
mriedem | that's in the test case assertion, but i'm also seeing it when logged | 18:19 |
mriedem | http://logs.openstack.org/63/102863/1/check/gate-glance-python27/6ad16a3/console.html#_2014-06-26_15_57_12_261 | 18:19 |
*** openstackgerrit has quit IRC | 18:20 | |
mriedem | so there is a problem in test_quota.py when it's doing the assertEquals, and a problem in upload_data_to_store when it's looking a str concatenated with an exception | 18:21 |
mriedem | *logging | 18:21 |
*** tkelsey has quit IRC | 18:25 | |
jecarey | It is trying to format unicode into non-unicode: msg = "Forbidden upload attempt: %s" % e | 18:26 |
mriedem | so this is ok right? msg = _("Image storage media is full: %s") % e | 18:26 |
mriedem | but this is not? msg = "Forbidden upload attempt: %s" % e | 18:26 |
jecarey | Yes ... but they just removed the _() because it is a message for a debug log. | 18:27 |
mriedem | right | 18:27 |
mriedem | so the string for the debug log message needs to be unicode? | 18:27 |
mriedem | msg = u"Forbidden upload attempt: %s" % e ? | 18:27 |
jecarey | yes. dhellmann that seems like a general direction when removing the _() for debug messages that have messages (exceptions) as replacement parms. | 18:29 |
mriedem | eww, we're probably pretty exposed across all the projects then | 18:30 |
mriedem | since people are removing _() for debug level messages more now in juno | 18:30 |
*** ajo|mac has joined #openstack-oslo | 18:31 | |
dhellmann | yes, they jumped the gun on that a bit, we haven't had time to provide good instructions for how to make those changes | 18:32 |
mriedem | ok, thanks for clarifying - i'll get this glance fix up for review and add jecarey to it | 18:33 |
dhellmann | I was planning to do that as part of releasing oslo.i18n, which has been delayed because of some other issues that have distracted me at work | 18:33 |
mriedem | to make sure i'm following correctly | 18:33 |
dhellmann | cool | 18:33 |
mriedem | damn day jobs :) | 18:33 |
dhellmann | seriously :-) | 18:33 |
jecarey | I know its been discussed before, but this seems like having _LD() which returns unicode (and doesnt' translate) would make things easier. | 18:33 |
mriedem | jokke_: i'll add you to the glance change when i get it up also | 18:33 |
*** erecio has quit IRC | 18:34 | |
jokke_ | yup, we have at least tons of those in glance | 18:34 |
jokke_ | would something like six.text_type() be more appropriate? I think there was some compability issues with u"", no? | 18:36 |
*** praneshp_ has joined #openstack-oslo | 18:37 | |
*** praneshp has quit IRC | 18:39 | |
*** praneshp_ is now known as praneshp | 18:39 | |
*** openstackgerrit has joined #openstack-oslo | 18:39 | |
*** tkelsey has joined #openstack-oslo | 18:42 | |
*** openstackstatus has joined #openstack-oslo | 18:42 | |
*** ChanServ sets mode: +v openstackstatus | 18:42 | |
dhellmann | jokke_: python 3.2 doesn't support u, but we don't support 3.2 so it shouldn't matter | 18:44 |
mriedem | u"" doesn't work in py3? | 18:44 |
dhellmann | it works in 3.3 and 3.4 | 18:44 |
mriedem | ok | 18:44 |
jokke_ | dhellmann: ah ok, thanks for that | 18:45 |
jokke_ | good to know | 18:45 |
openstackgerrit | Paul Michali proposed a change to openstack/oslo.messaging: Oslo: encoding error in file https://review.openstack.org/102909 | 18:45 |
*** james_li has quit IRC | 18:46 | |
*** tsekiyama has quit IRC | 18:46 | |
*** ekarlso has quit IRC | 18:46 | |
*** viktors|afk has quit IRC | 18:46 | |
*** praneshp has quit IRC | 18:46 | |
*** ildikov has quit IRC | 18:46 | |
*** bknudson has quit IRC | 18:46 | |
*** zzzeek has quit IRC | 18:46 | |
*** jecarey has quit IRC | 18:46 | |
*** mriedem has quit IRC | 18:46 | |
*** SlickNik has quit IRC | 18:46 | |
*** zhiyan_ has quit IRC | 18:46 | |
*** jd__ has quit IRC | 18:46 | |
*** openstackgerrit has quit IRC | 18:46 | |
*** mrda-away has quit IRC | 18:46 | |
*** wendar has quit IRC | 18:46 | |
*** mgagne has quit IRC | 18:46 | |
*** russellb has quit IRC | 18:46 | |
*** ttx has quit IRC | 18:46 | |
*** hartsocks has quit IRC | 18:46 | |
jokke_ | jecarey: I'd like that _LD( as if some point we can start translating debug messages as well, it would simplify the change | 18:46 |
*** openstackgerrit has joined #openstack-oslo | 18:46 | |
*** praneshp has joined #openstack-oslo | 18:46 | |
*** ildikov has joined #openstack-oslo | 18:46 | |
*** james_li has joined #openstack-oslo | 18:46 | |
*** bknudson has joined #openstack-oslo | 18:46 | |
*** zzzeek has joined #openstack-oslo | 18:46 | |
*** tsekiyama has joined #openstack-oslo | 18:46 | |
*** jecarey has joined #openstack-oslo | 18:46 | |
*** mriedem has joined #openstack-oslo | 18:46 | |
*** SlickNik has joined #openstack-oslo | 18:46 | |
*** zhiyan_ has joined #openstack-oslo | 18:46 | |
*** mrda-away has joined #openstack-oslo | 18:46 | |
*** russellb has joined #openstack-oslo | 18:46 | |
*** ekarlso has joined #openstack-oslo | 18:46 | |
*** viktors|afk has joined #openstack-oslo | 18:46 | |
*** wendar has joined #openstack-oslo | 18:46 | |
*** mgagne has joined #openstack-oslo | 18:46 | |
*** jd__ has joined #openstack-oslo | 18:46 | |
*** hartsocks has joined #openstack-oslo | 18:46 | |
*** ttx has joined #openstack-oslo | 18:46 | |
*** markmcclain has joined #openstack-oslo | 18:46 | |
jokke_ | jecarey: I'd like that _LD( as if some point we can start translating debug messages as well, it would simplify the change (resent, due to split) | 18:47 |
*** flaper87|afk has quit IRC | 18:48 | |
*** creiht has quit IRC | 18:48 | |
*** mtreinish has quit IRC | 18:48 | |
*** creiht has joined #openstack-oslo | 18:48 | |
*** flaper87|afk has joined #openstack-oslo | 18:48 | |
*** flaper87|afk is now known as flaper87 | 18:48 | |
*** flaper87 has quit IRC | 18:49 | |
*** flaper87 has joined #openstack-oslo | 18:49 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.messaging: encoding error in file https://review.openstack.org/102909 | 18:49 |
bnemec | dhellmann: Should https://review.openstack.org/#/c/102909 have a Related-Bug too? | 18:50 |
dhellmann | oh, yeah, probably, he mentions the bug but not using the "right" syntax | 18:50 |
bnemec | Also, holy random problem batman! | 18:50 |
*** mtreinish has joined #openstack-oslo | 18:50 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.messaging: encoding error in file https://review.openstack.org/102909 | 18:51 |
*** openstackgerrit has quit IRC | 18:51 | |
dhellmann | yeah, really | 18:51 |
*** openstackgerrit has joined #openstack-oslo | 18:52 | |
dhellmann | bnemec: I blame sileht's french keyboard ;-) | 18:52 |
bnemec | lol | 18:52 |
openstackgerrit | Ben Nemec proposed a change to openstack/oslo.messaging: encoding error in file https://review.openstack.org/102909 | 18:53 |
bnemec | Would anyone else like a crack at that commit message? :-) | 18:56 |
*** james_li has quit IRC | 18:56 | |
*** tsekiyama has quit IRC | 18:56 | |
*** ekarlso has quit IRC | 18:56 | |
*** viktors|afk has quit IRC | 18:56 | |
mriedem | fix problem | 18:58 |
mriedem | "fix problem" | 18:58 |
dhellmann | bnemec: heh | 19:00 |
*** erecio has joined #openstack-oslo | 19:08 | |
openstackgerrit | pritesh proposed a change to openstack-dev/hacking: Add hacking check for vim configuration in source files https://review.openstack.org/101969 | 19:14 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.i18n: Add links to policy discussions https://review.openstack.org/102028 | 19:17 |
*** james_li has joined #openstack-oslo | 19:19 | |
*** tsekiyama has joined #openstack-oslo | 19:19 | |
*** ekarlso has joined #openstack-oslo | 19:19 | |
*** viktors|afk has joined #openstack-oslo | 19:19 | |
*** ajo|mac has quit IRC | 19:23 | |
*** harlowja is now known as harlowja_away | 19:24 | |
*** erecio has quit IRC | 19:42 | |
*** tkelsey has quit IRC | 19:44 | |
*** james_li has quit IRC | 19:48 | |
*** ajo|mac has joined #openstack-oslo | 19:59 | |
openstackgerrit | Ken Giusti proposed a change to openstack/oslo.messaging: An initial implementation of a 1.0 based messaging driver https://review.openstack.org/75815 | 20:00 |
*** lbragstad has left #openstack-oslo | 20:00 | |
*** jecarey has quit IRC | 20:02 | |
*** erecio has joined #openstack-oslo | 20:03 | |
*** arnaud has joined #openstack-oslo | 20:04 | |
*** harlowja_away is now known as harlowja | 20:23 | |
*** stannie has joined #openstack-oslo | 20:26 | |
*** stannie has left #openstack-oslo | 20:26 | |
*** erecio has quit IRC | 20:30 | |
*** ajo|mac_ has joined #openstack-oslo | 20:46 | |
*** dstanek is now known as dstanek_zzz | 20:47 | |
*** ajo|mac has quit IRC | 20:47 | |
*** james_li has joined #openstack-oslo | 20:49 | |
*** dims_ has joined #openstack-oslo | 20:49 | |
*** jaosorior has quit IRC | 20:52 | |
*** dims__ has quit IRC | 20:52 | |
*** tongli has quit IRC | 20:54 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use a common message dispatcher https://review.openstack.org/101094 | 20:58 |
morganfainberg | dhellmann, ping, re: oslo.db and the sanity check code | 21:01 |
morganfainberg | dhellmann, looks like in a case where a migration ends up being wrong (i.e. not InnoDB/utf8 in mysql), you might get wedged. | 21:02 |
morganfainberg | dhellmann, we might want to provide (if we don't) a subclass of Table() that forces innodb/utf8 for the sanity check reasons. | 21:02 |
*** jecarey has joined #openstack-oslo | 21:07 | |
*** dstanek_zzz is now known as dstanek | 21:09 | |
*** dstanek is now known as dstanek_zzz | 21:19 | |
*** ajo|mac_ has quit IRC | 21:32 | |
*** markmcclain has quit IRC | 21:35 | |
*** ajo|mac has joined #openstack-oslo | 21:37 | |
*** mrda-away is now known as mrda | 21:39 | |
*** ajo|mac has quit IRC | 21:45 | |
*** ajo|mac has joined #openstack-oslo | 21:49 | |
*** pcm_ has joined #openstack-oslo | 21:53 | |
*** mriedem has left #openstack-oslo | 21:54 | |
*** mriedem has quit IRC | 21:54 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Increase the logging of the WBE response/send activities https://review.openstack.org/102959 | 22:21 |
*** oomichi has joined #openstack-oslo | 22:24 | |
*** toabctl has quit IRC | 22:28 | |
*** toabctl has joined #openstack-oslo | 22:31 | |
*** james_li has quit IRC | 22:33 | |
*** dstanek_zzz is now known as dstanek | 22:40 | |
*** markmcclain has joined #openstack-oslo | 22:52 | |
*** markmcclain1 has joined #openstack-oslo | 22:53 | |
*** markmcclain has quit IRC | 22:56 | |
*** dims_ has quit IRC | 23:01 | |
*** bknudson has quit IRC | 23:02 | |
*** SridharG has quit IRC | 23:17 | |
openstackgerrit | Pranesh Pandurangan proposed a change to openstack/taskflow: Allow handlers to provide validation callables https://review.openstack.org/101679 | 23:20 |
*** dims_ has joined #openstack-oslo | 23:26 | |
*** ajo|mac has quit IRC | 23:31 | |
*** ajo|mac has joined #openstack-oslo | 23:33 | |
*** mriedem has joined #openstack-oslo | 23:37 | |
*** ajo|mac has quit IRC | 23:38 | |
*** ajo|mac has joined #openstack-oslo | 23:40 | |
*** ajo|mac has quit IRC | 23:40 | |
*** yamahata has joined #openstack-oslo | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!