*** vishy has quit IRC | 00:02 | |
*** vishy has joined #openstack-oslo | 00:05 | |
*** praneshp_ has joined #openstack-oslo | 00:07 | |
*** flaper87 is now known as flaper87|afk | 00:08 | |
*** rpodolyaka1 has joined #openstack-oslo | 00:10 | |
*** therve has joined #openstack-oslo | 00:11 | |
*** ekarlso- has joined #openstack-oslo | 00:11 | |
*** dmitryme has quit IRC | 00:12 | |
*** rpodolyaka has quit IRC | 00:12 | |
*** ekarlso has quit IRC | 00:12 | |
*** therve` has quit IRC | 00:12 | |
*** dhellmann_ has quit IRC | 00:12 | |
*** noelbk has quit IRC | 00:12 | |
*** praneshp has quit IRC | 00:12 | |
*** bogdando has quit IRC | 00:12 | |
*** bogdando has joined #openstack-oslo | 00:12 | |
*** praneshp_ is now known as praneshp | 00:12 | |
*** noelbk has joined #openstack-oslo | 00:12 | |
*** dhellmann has joined #openstack-oslo | 00:12 | |
*** dmitryme has joined #openstack-oslo | 00:13 | |
*** dims has joined #openstack-oslo | 00:21 | |
*** dims_ has joined #openstack-oslo | 00:24 | |
*** dims has quit IRC | 00:27 | |
*** mtanino has quit IRC | 00:30 | |
*** yamahata has joined #openstack-oslo | 00:33 | |
*** yamahata has quit IRC | 00:39 | |
*** yamahata has joined #openstack-oslo | 00:39 | |
*** bogdando has quit IRC | 00:52 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.concurrency: Add code/api documentation https://review.openstack.org/118933 | 00:59 |
---|---|---|
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Mark 'task_notifier' as renamed to 'atom_notifier' https://review.openstack.org/103286 | 01:02 |
*** bogdando has joined #openstack-oslo | 01:04 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a futures type that can contain our future functionality https://review.openstack.org/116489 | 01:10 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslosphinx: Add initial cut for documentation https://review.openstack.org/118756 | 01:10 |
*** mriedem has joined #openstack-oslo | 01:12 | |
openstackgerrit | Huai Jiang proposed a change to openstack/oslo.db: Use single quotes for db schema sanity check https://review.openstack.org/118935 | 01:17 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Bring in a newer optional eventlet https://review.openstack.org/118937 | 01:18 |
*** liusheng has joined #openstack-oslo | 01:21 | |
*** bnemec has quit IRC | 01:32 | |
*** bnemec has joined #openstack-oslo | 01:32 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Reduce unused tox environments https://review.openstack.org/118941 | 01:39 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.concurrency: Add code/api documentation https://review.openstack.org/118933 | 01:41 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: Add docs target and generate api docs https://review.openstack.org/118905 | 01:41 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.rootwrap: Initial cut of documentation for oslo.rootwrap https://review.openstack.org/118752 | 01:41 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Reduce unused tox environments https://review.openstack.org/118941 | 01:46 |
*** HenryG has quit IRC | 01:51 | |
*** mriedem has left #openstack-oslo | 02:05 | |
*** takedakn has quit IRC | 02:07 | |
*** HenryG has joined #openstack-oslo | 02:40 | |
*** amrith is now known as _amrith_ | 02:41 | |
*** praneshp has quit IRC | 02:50 | |
*** tongli has quit IRC | 03:05 | |
*** stevemar has joined #openstack-oslo | 03:27 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Use fixtures from oslo.i18n and oslo.cfg https://review.openstack.org/118952 | 03:41 |
*** takedakn has joined #openstack-oslo | 03:42 | |
*** takedakn has quit IRC | 03:47 | |
*** takedakn has joined #openstack-oslo | 04:00 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Remove duplicate test and cleanup unnecessary files https://review.openstack.org/118959 | 04:20 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Add API documentation to docs build https://review.openstack.org/118960 | 04:20 |
*** dims_ has quit IRC | 04:21 | |
*** dims has joined #openstack-oslo | 04:21 | |
openstackgerrit | Jamie Lennox proposed a change to openstack-dev/cookiecutter: Use oslotest rather than copying helpers https://review.openstack.org/118961 | 04:23 |
*** dims has quit IRC | 04:26 | |
*** morganfainberg_Z is now known as morganfainberg | 04:29 | |
openstackgerrit | Jamie Lennox proposed a change to openstack-dev/cookiecutter: Automatically initialize git when finished. https://review.openstack.org/118967 | 04:57 |
openstackgerrit | Jamie Lennox proposed a change to openstack-dev/cookiecutter: Automatically initialize git when finished. https://review.openstack.org/118967 | 04:59 |
openstackgerrit | Aaron Rosen proposed a change to openstack-dev/cookiecutter: Add additional gitignores .swo/.swn https://review.openstack.org/118923 | 05:27 |
openstackgerrit | Aaron Rosen proposed a change to openstack-dev/cookiecutter: Add additional gitignores .sw? https://review.openstack.org/118923 | 05:37 |
*** harlowja_at_home has joined #openstack-oslo | 05:43 | |
*** harlowja is now known as harlowja_away | 05:50 | |
*** AAzza_afk has joined #openstack-oslo | 05:56 | |
*** AAzza_afk is now known as AAzza | 05:56 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.i18n: Imported Translations from Transifex https://review.openstack.org/116553 | 06:06 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.db: Imported Translations from Transifex https://review.openstack.org/118539 | 06:06 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.log: Imported Translations from Transifex https://review.openstack.org/118979 | 06:08 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.concurrency: Imported Translations from Transifex https://review.openstack.org/118545 | 06:11 |
*** flaper87|afk is now known as flaper87 | 06:12 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.messaging: Imported Translations from Transifex https://review.openstack.org/118547 | 06:12 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.utils: Imported Translations from Transifex https://review.openstack.org/118549 | 06:13 |
*** harlowja_at_home has quit IRC | 06:23 | |
*** akamyshnikova has quit IRC | 06:24 | |
*** amotoki has joined #openstack-oslo | 06:25 | |
*** takedakn has quit IRC | 06:27 | |
*** zzzeek has quit IRC | 06:31 | |
*** stevemar has quit IRC | 06:31 | |
*** jaosorior has joined #openstack-oslo | 06:35 | |
*** takedakn has joined #openstack-oslo | 06:39 | |
*** sunrenjie6 has joined #openstack-oslo | 07:01 | |
*** AAzza is now known as AAzza_afk | 07:03 | |
*** lbragstad has quit IRC | 07:03 | |
*** wendar has quit IRC | 07:04 | |
*** wendar_ has joined #openstack-oslo | 07:04 | |
*** lbragstad has joined #openstack-oslo | 07:05 | |
*** sunrenjie6 has quit IRC | 07:05 | |
*** sunrenjie6 has joined #openstack-oslo | 07:07 | |
*** sunrenjie6 has quit IRC | 07:11 | |
*** takedakn has quit IRC | 07:14 | |
*** sunrenjie6 has joined #openstack-oslo | 07:14 | |
*** sunrenjie6 has quit IRC | 07:19 | |
*** jeckersb_gone has quit IRC | 07:29 | |
*** ildikov has joined #openstack-oslo | 07:31 | |
*** sunrenjie6 has joined #openstack-oslo | 07:32 | |
*** sunrenjie6 has quit IRC | 07:36 | |
*** ihrachyshka has joined #openstack-oslo | 07:38 | |
*** ihrachyshka has quit IRC | 07:42 | |
*** pblaho has joined #openstack-oslo | 08:06 | |
*** dtantsur|afk is now known as dtantsur | 08:19 | |
*** takedakn has joined #openstack-oslo | 08:29 | |
*** pblaho is now known as pblaho|afk | 08:32 | |
*** pblaho|afk is now known as pblaho | 08:35 | |
*** takedakn has quit IRC | 08:51 | |
*** sridhar has joined #openstack-oslo | 09:17 | |
*** dtantsur is now known as dtantsur|brb | 09:48 | |
*** yamahata has quit IRC | 10:16 | |
*** pblaho is now known as pblaho|afk | 10:22 | |
*** k4n0_ has quit IRC | 10:33 | |
*** k4n0 has joined #openstack-oslo | 10:35 | |
*** _amrith_ is now known as amrith | 10:39 | |
*** dims has joined #openstack-oslo | 11:04 | |
*** dtantsur|brb is now known as dtantsur | 11:14 | |
*** dims has quit IRC | 11:19 | |
*** dims has joined #openstack-oslo | 11:19 | |
*** pblaho|afk is now known as pblaho | 11:20 | |
*** dims_ has joined #openstack-oslo | 11:21 | |
*** dims has quit IRC | 11:24 | |
*** dims_ has quit IRC | 11:26 | |
*** dims has joined #openstack-oslo | 11:27 | |
*** dims_ has joined #openstack-oslo | 11:30 | |
*** pcm_ has joined #openstack-oslo | 11:30 | |
*** dims has quit IRC | 11:31 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: Add a memory based shared cache https://review.openstack.org/116297 | 11:35 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo-incubator: fix small typo https://review.openstack.org/118437 | 11:38 |
*** i159 has joined #openstack-oslo | 11:38 | |
*** dims_ has quit IRC | 11:42 | |
*** dims has joined #openstack-oslo | 11:43 | |
*** dims_ has joined #openstack-oslo | 11:45 | |
*** dims has quit IRC | 11:47 | |
*** AAzzal has joined #openstack-oslo | 11:49 | |
*** AAzzal is now known as AAzza | 11:49 | |
*** mrda1 has joined #openstack-oslo | 11:50 | |
*** YorikSar_ has joined #openstack-oslo | 11:50 | |
*** jroll|dupe has joined #openstack-oslo | 11:50 | |
*** hartbot has joined #openstack-oslo | 11:50 | |
*** AAzza_afk has quit IRC | 11:50 | |
*** YorikSar has quit IRC | 11:50 | |
*** jroll has quit IRC | 11:50 | |
*** mrda has quit IRC | 11:51 | |
*** dtantsur has quit IRC | 11:51 | |
*** hartsocks has quit IRC | 11:51 | |
*** dtantsur has joined #openstack-oslo | 11:51 | |
*** dtantsur has quit IRC | 11:51 | |
*** dtantsur has joined #openstack-oslo | 11:51 | |
*** jroll|dupe is now known as jroll | 11:51 | |
*** i159 has quit IRC | 11:52 | |
*** YorikSar_ is now known as YorikSar | 11:54 | |
*** tongli has joined #openstack-oslo | 11:55 | |
*** dims_ has quit IRC | 12:05 | |
*** dims has joined #openstack-oslo | 12:06 | |
openstackgerrit | Dmitry Tantsur proposed a change to openstack/oslo-incubator: Add field_labels parameter to cliutils.print_list https://review.openstack.org/113978 | 12:07 |
*** gordc has joined #openstack-oslo | 12:10 | |
*** flaper87 is now known as echo | 12:11 | |
*** echo is now known as flaper87 | 12:11 | |
*** jeckersb_gone has joined #openstack-oslo | 12:35 | |
*** amrith is now known as _amrith_ | 12:35 | |
*** jeckersb_gone is now known as jeckersb | 12:36 | |
*** kgiusti has joined #openstack-oslo | 12:38 | |
*** flaper87 is now known as flaper87|afk | 12:40 | |
*** flaper87|afk is now known as flaper87 | 12:42 | |
*** pblaho has quit IRC | 12:55 | |
*** yamahata has joined #openstack-oslo | 12:58 | |
*** pblaho has joined #openstack-oslo | 12:59 | |
*** enykeev has quit IRC | 13:09 | |
*** zzzeek has joined #openstack-oslo | 13:09 | |
*** zzzeek has quit IRC | 13:09 | |
*** k4n0 has quit IRC | 13:12 | |
*** mriedem has joined #openstack-oslo | 13:18 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.concurrency: Add code/api documentation https://review.openstack.org/118933 | 13:20 |
*** tkelsey has joined #openstack-oslo | 13:25 | |
*** i159 has joined #openstack-oslo | 13:33 | |
*** bknudson has joined #openstack-oslo | 13:35 | |
*** rpodolyaka1 is now known as rpodolyaka_pto | 13:42 | |
YorikSar | dhellmann: ping | 13:45 |
*** alexpilotti has joined #openstack-oslo | 13:48 | |
openstackgerrit | Oleksii Chuprykov proposed a change to openstack/oslo.db: Add description for test_models_sync function https://review.openstack.org/116004 | 13:49 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: Add docs target and generate api docs https://review.openstack.org/118905 | 13:53 |
*** dtantsur is now known as dtantsur|brb | 14:00 | |
openstackgerrit | A change was merged to openstack/oslo.db: ModelsMigrationsSync:Override compare_server_default https://review.openstack.org/115203 | 14:00 |
*** yamahata has quit IRC | 14:02 | |
*** yamahata has joined #openstack-oslo | 14:02 | |
*** _amrith_ is now known as amrith | 14:02 | |
*** mtanino has joined #openstack-oslo | 14:07 | |
*** markmcclain has joined #openstack-oslo | 14:10 | |
*** jeckersb` has joined #openstack-oslo | 14:13 | |
*** yamahata has quit IRC | 14:17 | |
*** pblaho has quit IRC | 14:17 | |
*** jeckersb has quit IRC | 14:17 | |
*** AAzza has quit IRC | 14:17 | |
*** ekarlso- has quit IRC | 14:17 | |
*** harlowja_away has quit IRC | 14:17 | |
openstackgerrit | Matt Riedemann proposed a change to openstack/oslo-incubator: Check for namedtuple_as_object support before using it https://review.openstack.org/119073 | 14:18 |
*** yamahata has joined #openstack-oslo | 14:20 | |
dhellmann | YorikSar: pong | 14:21 |
dhellmann | dims: you're a patch generating machine this week :-) | 14:21 |
YorikSar | dhellmann: Ah, I've just thought if we could change wording in the requriements.txt comment you're adding. | 14:21 |
YorikSar | dhellmann: But since it's the same across all projects, I think we can leave it as is. | 14:22 |
dims | dhellmann: lol :) | 14:22 |
*** jecarey has joined #openstack-oslo | 14:22 | |
dhellmann | YorikSar: yeah, I realized last night that we should have the requirements update sync ensure that header is present, so maybe we can tweak the wording that way | 14:22 |
dims | YorikSar: agree. same thing with fungi's 3.4 patch | 14:23 |
*** ekarlso- has joined #openstack-oslo | 14:23 | |
YorikSar | dims: I'm not sure if my suggestion about py34 will work, actually. Just shared a thought. | 14:23 |
dims | YorikSar: ack. | 14:24 |
*** zz_jgrimm is now known as jgrimm | 14:25 | |
*** ajo is now known as ajo|call | 14:28 | |
openstackgerrit | Oleksii Chuprykov proposed a change to openstack/oslo.db: Renaming in WalkVersionsMixin https://review.openstack.org/119078 | 14:31 |
dhellmann | bnemec, dims : before I approve https://review.openstack.org/#/c/118551/3 and cut a new release of oslotest so we can make oslo.serialization work on py33, do we have any idea if there are users of oslotest that expect to get mox installed as a side-effect? Maybe jd__ was right to -1 that patch to remove the test dependency from oslo.serialization | 14:32 |
*** 17SAA4MFR has joined #openstack-oslo | 14:33 | |
*** pblaho has joined #openstack-oslo | 14:33 | |
*** AAzza has joined #openstack-oslo | 14:33 | |
*** 17SAA4BEV has joined #openstack-oslo | 14:33 | |
*** 17SAA4BEV has quit IRC | 14:33 | |
*** 17SAA4MFR has quit IRC | 14:33 | |
*** pblaho has quit IRC | 14:33 | |
*** AAzza has quit IRC | 14:33 | |
*** jaypipes has joined #openstack-oslo | 14:34 | |
*** stevemar has joined #openstack-oslo | 14:35 | |
dhellmann | YorikSar: that's your patch I'm asking about ^^ | 14:35 |
dims | dhellmann: worst case scenario, they would have to add mox explicitly? | 14:36 |
dhellmann | dims: yeah | 14:36 |
dims | dhellmann: thats perfectly ok if it comes to that | 14:37 |
dims | dhellmann: +1 from me | 14:37 |
dhellmann | dims: yeah, but it's also reason to wait until next week, so I'll set an alarm to remind me to do it monday morning | 14:37 |
dhellmann | I'll also email the -dev list, I guess, to give everyone a heads up | 14:37 |
dims | dhellmann: sounds good | 14:38 |
bnemec | dhellmann: At a glance it looks like everyone is already pulling in mox explicitly, so I think we're probably okay. | 14:45 |
bnemec | It is kind of nasty though since we've been telling people not to do that. | 14:45 |
dhellmann | bnemec: I sent a warning email with some details to the -dev list just a second ago, and I'll wait until after the FF patch storm dies down | 14:45 |
bnemec | dhellmann: Sounds good. | 14:46 |
*** sridhar has quit IRC | 14:47 | |
*** ildikov has quit IRC | 14:51 | |
*** hartbot is now known as hartsocks | 14:52 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslotest: Add fixture for mock.patch.multiple https://review.openstack.org/119085 | 15:05 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.serialization: Remove mock test dependency https://review.openstack.org/117237 | 15:09 |
*** jeckersb` is now known as jeckersb_gone | 15:09 | |
*** jeckersb_gone is now known as jeckersb | 15:10 | |
*** amotoki has quit IRC | 15:14 | |
* dhellmann can't wait to remove the flakey rpc tests from the incubator | 15:20 | |
*** amrith is now known as _amrith_ | 15:21 | |
*** zzzeek has joined #openstack-oslo | 15:22 | |
dhellmann | dims, bnemec, YorikSar : I think I linked to https://etherpad.openstack.org/p/juno-oslo-feature-freeze yesterday. if you have anything you think we ought to add to that list please do | 15:23 |
YorikSar | dhellmann: About oslotest: I can run a global grep to see if we have any project that imports mox directly. | 15:31 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Add API documentation to docs build https://review.openstack.org/118960 | 15:31 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Remove duplicate test and cleanup unnecessary files https://review.openstack.org/118959 | 15:31 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Use fixtures from oslo.i18n and oslo.cfg https://review.openstack.org/118952 | 15:31 |
YorikSar | dhellmann: I even have a script that iterates over all projects and clones all repos somewhere... | 15:31 |
YorikSar | dhellmann: As for oslo.concurrency, I'm finally finished with chasing weird (non-HA) behavior in Keystone/dogpile.cache/python-memcached for our Icehouse release and now I'll be able to put more effort to fixing oslo.concurrency (more CRs are going to appear). | 15:34 |
YorikSar | btw, should we stop approving things in not-yet-used libs? It adds up to gate madness... | 15:37 |
dhellmann | YorikSar: yes, we shouldn't be approving anything that isn't related to a blueprinted feature we slated for juno | 15:41 |
*** takedakn has joined #openstack-oslo | 15:41 | |
dhellmann | rpodolyaka_pto, viktors: if you have oslo.db changes we need to land to complete blueprints for juno, please add them to http://etherpad.openstack.org/p/juno-oslo-feature-freeze | 15:42 |
YorikSar | dhellmann: I just saw https://review.openstack.org/118545 | 15:42 |
dhellmann | YorikSar: translations count, because of the string freeze | 15:42 |
YorikSar | dhellmann: Ah... Ok. | 15:42 |
dhellmann | YorikSar: although I suppose those could wait for next week, too | 15:43 |
zzzeek | so dhellmann , yesterday I learned that rackspace in fact has already produced a fork of Nova that uses all raw DBAPI access straight to MySQLdb, and that’s what they use in production | 15:48 |
dhellmann | which connector do they use? | 15:48 |
zzzeek | MySQLdb | 15:49 |
zzzeek | though all the MySQL DBAPIs are very similar, it woudlnt be hard for them to use alternate ones. except they’d lose a lot of their perceived “performance” | 15:49 |
YorikSar | zzzeek: So that's what nova.db.api abstraction is for. | 15:49 |
dhellmann | have they proposed merging that upstream? do the nova devs want it? | 15:49 |
zzzeek | dhellmann: I think the status now is that they want to move off of it, but I’m not sure everyone agrees | 15:50 |
dhellmann | by "they" you mean rackspace? | 15:50 |
zzzeek | yes | 15:50 |
dhellmann | it might be worth talking to michael and some of the other nova cores about making db performance a priority for kilo, esp. if you can offer to work with them directly and contribute patches | 15:50 |
zzzeek | I’m troubled lately that a lot of these decisions are made with isolated profiling that doesnt actually show a wholeistic result | 15:51 |
zzzeek | dhellmann: I have a whole bag of new performance things in the queue. however, none of them are ever going to be as fast in a straight out “drag race” against MySQLdb written in pure C | 15:51 |
*** dtantsur|brb is now known as dtantsur | 15:51 | |
dhellmann | runtime performance isn't the only thing we want to optimize for | 15:52 |
zzzeek | dhellmann: i can get things like inserting 100K rows, runs in like .2 sec for MySQLdb, will run in like .4 for Core. now how often do we need to bulk insert 100K rows in the blink of an eye? probably never ? | 15:52 |
zzzeek | dhellmann: yes. this is whats bugging me. people are making huge changes based only on that one thing | 15:52 |
dhellmann | I don't know what use case that matches | 15:52 |
zzzeek | dhellmann: yup | 15:52 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.utils: Auto generate the API documentation https://review.openstack.org/119097 | 15:53 |
dhellmann | right, so that's why I'm suggesting talking to some of the cores about getting involved in a more rational approach | 15:53 |
*** markmcclain has quit IRC | 15:53 | |
*** i159 has quit IRC | 15:53 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.middleware: Auto generate the API documentation https://review.openstack.org/119098 | 15:57 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.messaging: Auto generate the API documentation https://review.openstack.org/119099 | 16:02 |
*** yamahata has quit IRC | 16:06 | |
*** tkelsey has quit IRC | 16:12 | |
*** jaosorior has quit IRC | 16:22 | |
*** _amrith_ is now known as amrith | 16:23 | |
*** praneshp has joined #openstack-oslo | 16:23 | |
viktors | dhellmann: ok, will do | 16:25 |
viktors | zzzeek: around? | 16:25 |
zzzeek | sure | 16:25 |
viktors | zzzeek: it seems to be, that I found a bug in exception filters system. I'm not very familiar with it, so can you please look at test case an confirm? | 16:27 |
zzzeek | sure | 16:27 |
viktors | please look at http://paste.openstack.org/show/105884/ | 16:27 |
viktors | should TestModelCreatePostgreSQL pass ? | 16:28 |
zzzeek | right now we have a rule that OperationalError is generally passed through as is, as there was a comment that this should be the case | 16:29 |
zzzeek | which I preserved | 16:29 |
viktors | zzzeek: seems to be, that I missed this thing. | 16:29 |
viktors | :( | 16:29 |
zzzeek | we shoudl probably take that rule out but i was going for total compatibiltiy | 16:30 |
viktors | is it documented somewhere? | 16:30 |
zzzeek | in the code yes | 16:30 |
viktors | agree! | 16:30 |
* viktors looking | 16:30 | |
viktors | oh, I found | 16:32 |
viktors | zzzeek: we just got an issue with this case in Nova, so thats the reason of my question | 16:32 |
zzzeek | yup | 16:33 |
viktors | zzzeek: thanks! | 16:33 |
zzzeek | good luck | 16:33 |
*** jaosorior has joined #openstack-oslo | 16:40 | |
*** viktors is now known as viktors|afk | 16:50 | |
*** takedakn has quit IRC | 16:57 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo-incubator: Switch to using pbr's autodoc capability https://review.openstack.org/119130 | 16:58 |
*** takedakn has joined #openstack-oslo | 16:58 | |
bnemec | dhellmann: I added another incubator change to https://etherpad.openstack.org/p/juno-oslo-feature-freeze and targeted the bug to juno-rc1 (the oslo.concurrency version was already targeted for it anyway) | 17:01 |
openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Reorganize DbTestCase to use provisioning completely https://review.openstack.org/110170 | 17:09 |
openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Add support for per-test-run database provisioning https://review.openstack.org/110486 | 17:09 |
openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Add transactional test support to provisioning https://review.openstack.org/113153 | 17:09 |
*** takedakn has quit IRC | 17:15 | |
*** takedakn has joined #openstack-oslo | 17:16 | |
*** harlowja has joined #openstack-oslo | 17:20 | |
openstackgerrit | A change was merged to openstack/oslo-incubator: Update list of oslo libs in update.py https://review.openstack.org/117241 | 17:22 |
openstackgerrit | A change was merged to openstack/oslo-incubator: Mark jsonutils as obsolete https://review.openstack.org/118217 | 17:23 |
harlowja | dhellmann for https://review.openstack.org/#/c/117844/ do u have any thoughts on how we could stop that anyjson behavior, it doesn't seem very good | 17:26 |
*** pcm_ has quit IRC | 17:27 | |
*** pcm_ has joined #openstack-oslo | 17:31 | |
*** takedakn1 has joined #openstack-oslo | 17:33 | |
*** takedakn has quit IRC | 17:33 | |
*** ajo has joined #openstack-oslo | 17:34 | |
*** dtantsur is now known as dtantsur|afk | 17:39 | |
*** takedakn1 has quit IRC | 17:44 | |
*** markmcclain has joined #openstack-oslo | 17:48 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.concurrency: Updated from global requirements https://review.openstack.org/117940 | 17:54 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/115605 | 17:54 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.config: Updated from global requirements https://review.openstack.org/115606 | 17:54 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.db: Updated from global requirements https://review.openstack.org/118564 | 17:54 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.log: Updated from global requirements https://review.openstack.org/119144 | 17:54 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/115363 | 17:54 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.middleware: Updated from global requirements https://review.openstack.org/114064 | 17:54 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.serialization: Updated from global requirements https://review.openstack.org/119145 | 17:54 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.vmware: Updated from global requirements https://review.openstack.org/119146 | 17:54 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/pycadf: Updated from global requirements https://review.openstack.org/119147 | 17:54 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/taskflow: Updated from global requirements https://review.openstack.org/117424 | 17:55 |
openstackgerrit | Ben Nemec proposed a change to openstack/oslo.concurrency: Sleep longer in external tests https://review.openstack.org/119155 | 17:59 |
*** zzzeek has quit IRC | 18:05 | |
dhellmann | dims, regarding your nits on https://review.openstack.org/#/c/105362/ -- can we merge the change and fix those in a follow-up? I'd like to let ttx tag j-3 in the incubator | 18:11 |
dhellmann | amrith: let me know if you have questions about my comment on https://review.openstack.org/#/c/118452/ | 18:14 |
openstackgerrit | A change was merged to openstack/oslo-incubator: Use file locks by default again https://review.openstack.org/118457 | 18:17 |
*** pcm_ has quit IRC | 18:17 | |
*** pcm_ has joined #openstack-oslo | 18:18 | |
*** ajo has quit IRC | 18:21 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-incubator: Use MultiStrOpt for policy_dirs https://review.openstack.org/119160 | 18:23 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-incubator: Use MultiStrOpt for policy_dirs https://review.openstack.org/119160 | 18:25 |
*** markmcclain has quit IRC | 18:41 | |
*** markmcclain has joined #openstack-oslo | 18:41 | |
dims | dhellmann: sounds good | 18:54 |
dims | dhellmann: i'll push that through 105362 | 18:55 |
dhellmann | dims: cool, thanks | 18:55 |
*** markmcclain has quit IRC | 19:04 | |
bnemec | dhellmann: On https://review.openstack.org/#/c/118452/ , that isn't a change. The debug call was already there, we're just masking passwords in it now. | 19:09 |
openstackgerrit | Ken Giusti proposed a change to openstack/oslo.messaging: An initial implementation of an AMQP 1.0 based messaging driver https://review.openstack.org/75815 | 19:15 |
openstackgerrit | A change was merged to openstack/oslo-incubator: Add support for policy configration directories https://review.openstack.org/105362 | 19:16 |
dhellmann | bnemec: ugh, I've been looking at too many diffs | 19:16 |
dhellmann | bnemec: +2a | 19:17 |
bnemec | dhellmann: Yeah, gotta love the end of the cycle. :-) | 19:18 |
*** ajo has joined #openstack-oslo | 19:26 | |
openstackgerrit | A change was merged to openstack/oslo-incubator: Mask passwords in exceptions and error messages https://review.openstack.org/118452 | 19:27 |
openstackgerrit | Doug Hellmann proposed a change to openstack-dev/oslo-cookiecutter: Simplify project doc templates https://review.openstack.org/119179 | 19:31 |
*** markmcclain has joined #openstack-oslo | 19:32 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.config: Update contributing instructions https://review.openstack.org/119180 | 19:33 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.concurrency: Update contributing instructions https://review.openstack.org/119182 | 19:33 |
*** jeckersb is now known as jeckersb_gone | 19:41 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Just use the natural module name instead of aliasing to tt https://review.openstack.org/119186 | 19:43 |
dims | bnemec: mad dash!!! | 19:51 |
*** arnaud has joined #openstack-oslo | 19:52 | |
*** amrith is now known as _amrith_ | 19:53 | |
*** ajo has quit IRC | 19:53 | |
*** _amrith_ is now known as amrith | 19:56 | |
*** mriedem has quit IRC | 19:57 | |
*** liusheng has quit IRC | 20:01 | |
*** liusheng has joined #openstack-oslo | 20:01 | |
*** liusheng has quit IRC | 20:02 | |
*** liusheng has joined #openstack-oslo | 20:02 | |
*** pcm_ has quit IRC | 20:03 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/oslo.utils: Add the ability to extract the query params from a urlsplit https://review.openstack.org/118881 | 20:05 |
harlowja | dhellmann the other thing i was thinking of that would be an integration with taskflow issue, is that taskflow supports py33, most of the oslo.* libraries seem for 2.6/27 still right? | 20:06 |
harlowja | *at least thats what it seems in the currently released libraries | 20:07 |
*** kgiusti has left #openstack-oslo | 20:16 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.db: Clean up documentation https://review.openstack.org/118214 | 20:17 |
*** cburgess_ is now known as cburgess | 20:19 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.concurrency: Add history file to documentation https://review.openstack.org/119194 | 20:20 |
dhellmann | harlowja: the goal is to support python 3 for everything | 20:20 |
openstackgerrit | Doug Hellmann proposed a change to openstack-dev/oslo-cookiecutter: Simplify project doc templates https://review.openstack.org/119179 | 20:23 |
*** flaper87 is now known as flaper87|afk | 20:24 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.db: Clean up documentation https://review.openstack.org/118214 | 20:25 |
dhellmann | dims: do my comments about not using the auto-generation scripts make sense? | 20:27 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.db: Clean up documentation https://review.openstack.org/118214 | 20:29 |
dims | dhellmann: you mean primarily the oslo.*.openstack.common.* right? | 20:34 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.log: Simple doc cleanup https://review.openstack.org/119198 | 20:36 |
dstanek | in keystone we are having an issue with the latest oslotest - the end result is https://bugs.launchpad.net/keystone/+bug/1365678 | 20:36 |
dhellmann | dims: also the _i18n files and any other private files | 20:36 |
dhellmann | dims: the generator doesn't distinguish those | 20:36 |
dstanek | if we explicitly create patch objects it looks like we can no longer clean them up reliably | 20:37 |
dstanek | is the indent to stop projects from explicitly calling patcher.stop()? | 20:37 |
dhellmann | dstanek: not really, but do you need to do that? | 20:38 |
dhellmann | dstanek: let me look at the logs for those tests | 20:38 |
dstanek | dhellmann: i think the author does it because otherwise they'd have to use the decorator all over the place | 20:38 |
dstanek | dhellmann: relevant olsotest code http://git.openstack.org/cgit/openstack/oslotest/tree/oslotest/base.py#n80 | 20:39 |
dstanek | dhellmann: keystone code http://git.openstack.org/cgit/openstack/keystone/tree/keystone/tests/test_backend_ldap_pool.py#n215 | 20:39 |
*** takedakn has joined #openstack-oslo | 20:40 | |
dhellmann | dstanek: that call in oslotest looks like it might be overly aggressive. Does the decorator automatically stop the patch, like the context manager does? | 20:40 |
dstanek | dhellmann: yes, i believe it does -- checking | 20:40 |
dhellmann | dstanek: does mock fixture work in the keystone code? | 20:40 |
dhellmann | dstanek: http://docs.openstack.org/developer/oslotest/api.html#module-oslotest.mockpatch | 20:41 |
dhellmann | not that it should be required, I'm just trying to understand what does/doesn't work | 20:41 |
dstanek | i'll give that a try, but i suspect it would have the same issue because it's probably doing the exact same thing we are | 20:42 |
dhellmann | dstanek: it *looks* like that keystone test is patching the connector but then never undoing that, am I wrong? | 20:42 |
dhellmann | oh, nevermind, I see the cleanup call | 20:42 |
dhellmann | dstanek: the oslotest test suite uses the fixtures and the test base class together and doesn't get the error. | 20:45 |
dstanek | dhellmann: no that is broken too | 20:45 |
dstanek | dhellmann: what's interesting is that testtools stores cleanups in a set so you are not guaranteed to get the broken ordering back | 20:46 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslotest: Add test for using mock.patch "manually" https://review.openstack.org/119201 | 20:47 |
dstanek | hmmm...maybe the latest stores them in a list now - my installed version uses a set, but the verison on github uses a list | 20:47 |
dhellmann | dstanek: ^^ demonstrates that this is working for oslotest in isolation, so there must be some extra interaction going on in the keystone test suite | 20:47 |
*** mrda1 is now known as mrda | 20:53 | |
dhellmann | dstanek: I'm setting up to run the tests here | 20:55 |
openstackgerrit | David Stanek proposed a change to openstack/oslotest: Add test for using mock.patch "manually" https://review.openstack.org/119201 | 20:56 |
dstanek | dhellmann: ^ that reproduces it in oslotest | 20:56 |
dhellmann | interesting, so there's a difference in doing it in setup vs. the test method | 20:57 |
dstanek | dhellmann: this may "go away" with the latest testtools - but people would have to understand the order of the cleanups | 20:58 |
dhellmann | yeah | 20:58 |
dhellmann | hmm, if I move your changes to their own test class then it no longer fails | 20:59 |
*** arnaud has quit IRC | 21:00 | |
dstanek | dhellmann: i suspect that at somepoint it will come back adding another cleanup or something | 21:01 |
dhellmann | adding or removing? | 21:01 |
dstanek | possibly | 21:01 |
dstanek | i don't understand the implementation of a set enough to know what causes the ordering of list(set()) | 21:02 |
dhellmann | it's going to be random under tox with the randomly generated hash seed | 21:03 |
dhellmann | dstanek: I'm not sure what's better here. Saying that you shouldn't call stop yourself or removing that stopall call. The latter might break other test suites. :-/ | 21:08 |
dstanek | dhellmann: i regenerated my env and it looks like the currect release version uses a list | 21:08 |
dstanek | dhellmann: so what's really interesting is that you have to make sure your clean is registered after the stopall because testtools processes then in the reverse order | 21:10 |
dhellmann | dstanek: this version works: http://paste.openstack.org/show/106038/ | 21:11 |
dstanek | thats' using testtools.TestCase | 21:12 |
dstanek | i wouldn't expect that to be broken | 21:12 |
dhellmann | d'oh | 21:12 |
dhellmann | ok, now it's broken :-) | 21:13 |
dstanek | dhellmann: should i open a bug to widen the audience? | 21:14 |
dhellmann | that might be a good idea | 21:14 |
dhellmann | the ordering issue is odd | 21:14 |
dhellmann | I guess you have to mock out the ldap stuff before initialising the ldap test base class? | 21:15 |
*** gordc has quit IRC | 21:16 | |
dstanek | if i move the super().setUp first then things will work | 21:17 |
dhellmann | does the test work properly though? or does the mocking need to happen before the base class initialization? | 21:17 |
dstanek | dhellmann: also i have to use mock for this because i need to start before the super but register the cleanup after | 21:20 |
dhellmann | so moving the cleanup registration to after the super() call fixes it? that seems like an OK solution? | 21:21 |
dhellmann | I'm afraid removing the stopall will break test suites that expect it :-/ | 21:21 |
dstanek | yeah, but it's not intuitive and you can't use the fixture at all | 21:21 |
dhellmann | I don't know if we have any like that, but I don't have a way to really test it | 21:21 |
dhellmann | yeah | 21:21 |
dstanek | dhellmann: well, i'll open the bug and see where it goes | 21:22 |
*** jaosorior has quit IRC | 21:22 | |
dstanek | i think the dev who added that assumed that their cleanup would run last | 21:22 |
dhellmann | dstanek: yeah, do that please. I need to think about how to verify that removing the stopall won't break anything else. | 21:22 |
dhellmann | yeah, I'm sure ihar didn't take into account mocking before initializing a test base class | 21:22 |
dhellmann | dstanek: I have to run an errand, but I'll be back online in a bit | 21:23 |
dhellmann | dstanek: ok, I have a fix, do you have bug #? | 21:27 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslotest: Ensure that mock.patch.stopall is called last https://review.openstack.org/119201 | 21:28 |
dhellmann | dstanek: see how that strikes you ^^ | 21:28 |
dhellmann | bbiab | 21:28 |
dstanek | dhellmann: that's actually what i was thinking too | 21:32 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslotest: Ensure that mock.patch.stopall is called last https://review.openstack.org/119201 | 21:33 |
dhellmann | ok, now, really I'm leaving the keyboard for a while :-) | 21:33 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a mandelbrot parallel calculation WBE example https://review.openstack.org/106216 | 21:42 |
*** markmcclain has quit IRC | 21:45 | |
*** dims_ has joined #openstack-oslo | 21:51 | |
*** arnaud has joined #openstack-oslo | 21:52 | |
*** dims has quit IRC | 21:54 | |
*** tongli has quit IRC | 21:59 | |
openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Handle a failure on communicate() https://review.openstack.org/114664 | 21:59 |
amrith | YorikSar, I've updated https://review.openstack.org/#/c/114664/ with a new (related-bug) in the commit message. Please re-review. Thanks! | 22:00 |
*** dims_ has quit IRC | 22:00 | |
*** dims has joined #openstack-oslo | 22:01 | |
*** jgrimm is now known as zz_jgrimm | 22:04 | |
*** dims has quit IRC | 22:05 | |
*** zzzeek has joined #openstack-oslo | 22:09 | |
*** dims has joined #openstack-oslo | 22:14 | |
*** amrith is now known as _amrith_ | 22:21 | |
*** jecarey has quit IRC | 22:23 | |
*** alexpilotti has quit IRC | 22:25 | |
*** liusheng has quit IRC | 22:34 | |
*** liusheng has joined #openstack-oslo | 22:34 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Add API documentation to docs build https://review.openstack.org/118960 | 22:45 |
dims | dhellmann: found a way to hide the files when you get a chance. back in a bit | 22:47 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a futures type that can contain our future functionality https://review.openstack.org/116489 | 22:48 |
*** dims has quit IRC | 22:49 | |
*** stevemar has quit IRC | 22:50 | |
*** dims has joined #openstack-oslo | 22:50 | |
*** dims has quit IRC | 22:54 | |
*** liusheng has quit IRC | 23:01 | |
*** liusheng has joined #openstack-oslo | 23:01 | |
openstackgerrit | Miguel Grinberg proposed a change to openstack/oslo.config: Fixed typo in docstring for _get_config_dirs https://review.openstack.org/119250 | 23:18 |
openstackgerrit | Michael Davies proposed a change to openstack/cliff: mock.assert_called_once() is not a valid method https://review.openstack.org/119252 | 23:27 |
harlowja | zzzeek whats your feeingl for oslo.db + py33/py34? not much effort, a little? | 23:36 |
zzzeek | i dont think it woudl be too terrible | 23:36 |
harlowja | kk, maybe i can jump in and help that occur, otherwise can't switch taskflow to using it :-/ | 23:37 |
*** oomichi has joined #openstack-oslo | 23:41 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use explicit WBE request state transitions https://review.openstack.org/114162 | 23:57 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Increase/adjust the logging of the WBE response/send activities https://review.openstack.org/102959 | 23:57 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Tidy up the WBE cache (now WBE types) module https://review.openstack.org/103245 | 23:57 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Update transitioning function name to be more understandable https://review.openstack.org/117392 | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!