*** praneshp_ has joined #openstack-oslo | 00:00 | |
*** praneshp has quit IRC | 00:03 | |
*** praneshp_ is now known as praneshp | 00:03 | |
*** mtanino has quit IRC | 00:24 | |
*** yamahata has joined #openstack-oslo | 00:34 | |
*** yamahata has quit IRC | 00:36 | |
*** yamahata has joined #openstack-oslo | 00:36 | |
*** takedakn1 has joined #openstack-oslo | 00:37 | |
*** takedakn has quit IRC | 00:37 | |
*** pcm_ has quit IRC | 01:00 | |
*** tongli has quit IRC | 01:06 | |
*** vigneshvar has quit IRC | 01:10 | |
*** dims has joined #openstack-oslo | 01:11 | |
*** bknudson has joined #openstack-oslo | 01:18 | |
*** dims has quit IRC | 01:23 | |
*** dims has joined #openstack-oslo | 01:23 | |
*** dims_ has joined #openstack-oslo | 01:26 | |
*** dims has quit IRC | 01:28 | |
openstackgerrit | A change was merged to openstack/oslo-incubator: Mark oslo.utils modules obsolete https://review.openstack.org/117616 | 01:42 |
---|---|---|
*** stevemar has joined #openstack-oslo | 01:46 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use and verify event and latch waited for values with timeouts https://review.openstack.org/118460 | 01:47 |
*** dims_ has quit IRC | 02:03 | |
*** dims has joined #openstack-oslo | 02:03 | |
*** dims has quit IRC | 02:08 | |
openstackgerrit | A change was merged to openstack/oslo-incubator: Mark the config generator as obsolete https://review.openstack.org/117614 | 02:11 |
*** dims has joined #openstack-oslo | 02:13 | |
*** stevemar has quit IRC | 02:18 | |
*** stevemar has joined #openstack-oslo | 02:19 | |
openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Log stdout, stderr and command on execute() error https://review.openstack.org/114659 | 02:23 |
*** amrith is now known as amrith__ | 02:25 | |
*** jeckersb is now known as jeckersb_gone | 02:28 | |
*** mriedem has left #openstack-oslo | 02:42 | |
*** mriedem has quit IRC | 02:42 | |
*** harlowja is now known as harlowja_away | 02:52 | |
*** dims has quit IRC | 02:56 | |
*** dims has joined #openstack-oslo | 02:57 | |
*** dims has quit IRC | 03:01 | |
*** jecarey_ has joined #openstack-oslo | 03:04 | |
*** takedakn1 has quit IRC | 03:07 | |
*** takedakn has joined #openstack-oslo | 03:12 | |
*** praneshp has quit IRC | 03:20 | |
*** praneshp has joined #openstack-oslo | 03:23 | |
*** praneshp has quit IRC | 03:38 | |
*** praneshp has joined #openstack-oslo | 03:40 | |
*** praneshp_ has joined #openstack-oslo | 03:45 | |
*** praneshp has quit IRC | 03:45 | |
*** praneshp_ is now known as praneshp | 03:45 | |
*** takedakn has quit IRC | 04:24 | |
*** jecarey_ has quit IRC | 04:41 | |
*** amotoki has joined #openstack-oslo | 04:56 | |
*** harlowja_at_home has joined #openstack-oslo | 04:59 | |
*** jaosorior has joined #openstack-oslo | 05:01 | |
*** takedakn has joined #openstack-oslo | 05:35 | |
YorikSar | dhellmann: Yes, I did. | 05:39 |
*** takedakn has quit IRC | 05:41 | |
*** harlowja_at_home has quit IRC | 05:55 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.i18n: Imported Translations from Transifex https://review.openstack.org/116553 | 06:00 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.db: Imported Translations from Transifex https://review.openstack.org/118539 | 06:01 |
*** takedakn has joined #openstack-oslo | 06:02 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.concurrency: Imported Translations from Transifex https://review.openstack.org/118545 | 06:07 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.messaging: Imported Translations from Transifex https://review.openstack.org/118547 | 06:09 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.utils: Imported Translations from Transifex https://review.openstack.org/118549 | 06:09 |
openstackgerrit | Yuriy Taraday proposed a change to openstack/oslotest: Remove differences between Python 2.x and 3.x versions https://review.openstack.org/118551 | 06:12 |
*** stevemar has quit IRC | 06:16 | |
*** k4n0 has joined #openstack-oslo | 06:18 | |
*** harlowja_at_home has joined #openstack-oslo | 06:20 | |
openstackgerrit | A change was merged to openstack/oslo.db: Updated from global requirements https://review.openstack.org/118286 | 06:20 |
*** flaper87|afk is now known as flaper87 | 06:30 | |
openstackgerrit | A change was merged to openstack/oslo.log: Fix testr failure under python2.6 https://review.openstack.org/118327 | 06:34 |
*** takedakn has quit IRC | 06:37 | |
*** takedakn has joined #openstack-oslo | 06:37 | |
*** ildikov has joined #openstack-oslo | 06:58 | |
*** flaper87 is now known as flaper87|afk | 07:26 | |
*** harlowja_at_home has quit IRC | 07:33 | |
*** AAzza is now known as AAzza_afk | 07:33 | |
*** wendar_ is now known as wendar | 07:36 | |
*** flaper87|afk is now known as flaper87 | 07:39 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/115605 | 07:41 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.db: Updated from global requirements https://review.openstack.org/118564 | 07:41 |
*** takedakn has quit IRC | 07:46 | |
*** takedakn has joined #openstack-oslo | 07:47 | |
*** AAzza_afk is now known as AAzza | 07:49 | |
openstackgerrit | A change was merged to openstack/oslo.log: Initial translation setup https://review.openstack.org/117610 | 07:52 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.log: Updated from global requirements https://review.openstack.org/117941 | 08:00 |
*** takedakn has quit IRC | 08:12 | |
*** oomichi has quit IRC | 08:25 | |
*** i159 has joined #openstack-oslo | 08:32 | |
*** pblaho_ has joined #openstack-oslo | 08:38 | |
openstackgerrit | Jakub Libosvar proposed a change to openstack/oslo.rootwrap: Fix exit of subprocess in case it was terminated by signal https://review.openstack.org/118569 | 08:42 |
*** ildikov_ has joined #openstack-oslo | 08:44 | |
*** ildikov has quit IRC | 08:47 | |
openstackgerrit | Alex Frolov proposed a change to openstack/oslo.utils: Transfer class LazyPluggable from nova to oslo.utils https://review.openstack.org/118571 | 08:51 |
*** amotoki has quit IRC | 08:52 | |
*** praneshp has quit IRC | 08:57 | |
openstackgerrit | Ann Kamyshnikova proposed a change to openstack/oslo.db: ModelsMigrationsSync:Override compare_server_default https://review.openstack.org/115203 | 09:04 |
openstackgerrit | Yuriy Taraday proposed a change to openstack/oslotest: Remove differences between Python 2.x and 3.x versions https://review.openstack.org/118551 | 09:07 |
*** dtantsur|afk is now known as dtantsur | 09:07 | |
openstackgerrit | Alex Frolov proposed a change to openstack/oslo.utils: Transfer class LazyPluggable from nova to oslo.utils https://review.openstack.org/118571 | 09:14 |
*** AJaeger has left #openstack-oslo | 09:19 | |
openstackgerrit | Ann Kamyshnikova proposed a change to openstack/oslo.db: ModelsMigrationsSync:Override compare_server_default https://review.openstack.org/115203 | 09:22 |
*** AAzza is now known as AAzza_afk | 09:25 | |
*** pblaho_ is now known as pblaho|afk | 09:32 | |
openstackgerrit | Yuriy Taraday proposed a change to openstack/oslotest: Remove differences between Python 2.x and 3.x versions https://review.openstack.org/118551 | 09:32 |
openstackgerrit | Alex Frolov proposed a change to openstack/oslo.utils: Transfer class LazyPluggable from nova to oslo.utils https://review.openstack.org/118582 | 09:33 |
*** viktors|afk is now known as viktors | 09:57 | |
*** pcm_ has joined #openstack-oslo | 10:05 | |
*** jeckersb_gone is now known as jeckersb | 10:05 | |
*** pcm_ has quit IRC | 10:05 | |
*** pcm_ has joined #openstack-oslo | 10:06 | |
*** yamahata has quit IRC | 10:11 | |
*** jeckersb is now known as jeckersb_gone | 10:16 | |
*** amrith__ is now known as amrith | 10:17 | |
*** pblaho|afk is now known as pblaho_ | 10:20 | |
openstackgerrit | A change was merged to openstack/oslo.vmware: Updated from global requirements https://review.openstack.org/117953 | 10:33 |
openstackgerrit | A change was merged to openstack/taskflow: Use __qualname__ where appropriate https://review.openstack.org/106683 | 10:34 |
*** vigneshvar has joined #openstack-oslo | 10:40 | |
vigneshvar | hi guys. Is there a method to release a topic (just opposite to declare_topic_consumer) | 10:41 |
*** pblaho_ is now known as pblaho | 10:49 | |
*** jraim_ has quit IRC | 11:03 | |
*** ttx has quit IRC | 11:03 | |
*** jraim__ has joined #openstack-oslo | 11:06 | |
*** dims has joined #openstack-oslo | 11:06 | |
*** ttx has joined #openstack-oslo | 11:09 | |
*** ttx has quit IRC | 11:09 | |
*** ttx has joined #openstack-oslo | 11:09 | |
*** dims has quit IRC | 11:12 | |
*** dims has joined #openstack-oslo | 11:13 | |
*** dims_ has joined #openstack-oslo | 11:14 | |
*** dims has quit IRC | 11:17 | |
flaper87 | dims_: hey, around? | 11:20 |
flaper87 | dims_: does this look correct to you? https://github.com/openstack/glance_store/blob/master/glance_store/backend.py#L29-L43 | 11:20 |
dims_ | good afternoon flaper87 | 11:20 |
flaper87 | dims_: hey hey! How are you doing? | 11:20 |
flaper87 | dims_: for some reason, those deprecated options are not working as expected: http://logs.openstack.org/36/100636/21/check/check-tempest-dsvm-postgres-full/469b7be/logs/screen-g-api.txt.gz#_2014-09-03_08_25_01_260 | 11:20 |
*** pblaho is now known as pblaho|afk | 11:21 | |
dims_ | looking | 11:22 |
flaper87 | dims_: thanks :) | 11:22 |
*** AAzza_afk is now known as AAzza | 11:26 | |
dims_ | flaper87: not sure i understand, the logs point to filesystem_store_datadir filesystem_store_datadirs and the deprecrated opts is not one of them right? (can you explain the problem a bit more?) | 11:26 |
flaper87 | dims_: duh, I'm so dumb | 11:27 |
*** vigneshvar has quit IRC | 11:27 | |
flaper87 | dims_: filesystem options where moved w/o the deprecation thing | 11:27 |
flaper87 | nvm | 11:27 |
flaper87 | :D | 11:27 |
*** dims_ has quit IRC | 11:29 | |
*** dims has joined #openstack-oslo | 11:29 | |
*** dims has quit IRC | 11:34 | |
*** dims has joined #openstack-oslo | 11:37 | |
dims | flaper87: aha :) | 11:38 |
flaper87 | dims: man, soooo many little things | 11:38 |
dims | :) | 11:38 |
*** yamahata has joined #openstack-oslo | 11:45 | |
flaper87 | dims: when is oslo.log going to be released? | 11:47 |
flaper87 | I saw the repo is already there | 11:47 |
dims | flaper87: needs quite a bit of work not for at least a few weeks | 11:47 |
flaper87 | dims: ok, thanks for the heads up | 11:48 |
flaper87 | :) | 11:48 |
*** dims has quit IRC | 11:50 | |
*** dims has joined #openstack-oslo | 11:50 | |
*** dims_ has joined #openstack-oslo | 11:51 | |
*** dims has quit IRC | 11:54 | |
*** yamahata has quit IRC | 11:58 | |
*** yamahata has joined #openstack-oslo | 12:00 | |
*** kgiusti has joined #openstack-oslo | 12:00 | |
*** markmcclain has joined #openstack-oslo | 12:02 | |
*** markmcclain has quit IRC | 12:02 | |
*** HenryG is now known as HenryG_afk | 12:04 | |
*** markmcclain has joined #openstack-oslo | 12:04 | |
*** pblaho|afk is now known as pblaho | 12:12 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Move the option definitions into a private file https://review.openstack.org/118615 | 12:13 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Make the local module private https://review.openstack.org/118616 | 12:13 |
*** miqui has joined #openstack-oslo | 12:25 | |
*** amrith is now known as _amrith_ | 12:28 | |
*** dims_ has quit IRC | 12:29 | |
*** dims has joined #openstack-oslo | 12:30 | |
openstackgerrit | A change was merged to openstack/oslo.vmware: Refactoring to reduce noise in log files https://review.openstack.org/116504 | 12:31 |
openstackgerrit | A change was merged to openstack/oslo.utils: Updated from global requirements https://review.openstack.org/117943 | 12:31 |
openstackgerrit | A change was merged to openstack/oslo.rootwrap: Updated from global requirements https://review.openstack.org/117942 | 12:31 |
openstackgerrit | A change was merged to openstack/pycadf: define the project goal https://review.openstack.org/115796 | 12:31 |
openstackgerrit | A change was merged to openstack/oslo.concurrency: Mask passwords in exceptions and error messages https://review.openstack.org/116763 | 12:31 |
openstackgerrit | A change was merged to openstack/taskflow: Make the WBE worker banner information more meaningful https://review.openstack.org/109840 | 12:31 |
openstackgerrit | A change was merged to openstack/oslo.utils: Just use int(BOOL) to convert to 1 or 0 https://review.openstack.org/117385 | 12:31 |
openstackgerrit | A change was merged to openstack/oslo.messaging: Switch to oslo.utils https://review.openstack.org/115996 | 12:31 |
*** dims_ has joined #openstack-oslo | 12:32 | |
*** dims has quit IRC | 12:34 | |
openstackgerrit | Ken Giusti proposed a change to openstack/oslo.messaging: An initial implementation of an AMQP 1.0 based messaging driver https://review.openstack.org/75815 | 12:40 |
*** freyes has quit IRC | 12:45 | |
*** dims_ has quit IRC | 12:45 | |
*** freyes has joined #openstack-oslo | 12:46 | |
*** dims has joined #openstack-oslo | 12:46 | |
openstackgerrit | Victor Sergeyev proposed a change to openstack/oslo.db: Fix DBReferenceError on MySQL and SQLite https://review.openstack.org/116324 | 12:55 |
openstackgerrit | A change was merged to openstack/oslo.concurrency: Address some potential security issues in lockutils https://review.openstack.org/116127 | 12:58 |
openstackgerrit | A change was merged to openstack/taskflow: Allow worker count to be specified when no executor provided https://review.openstack.org/114849 | 12:58 |
openstackgerrit | Oleksii Chuprykov proposed a change to openstack/oslo.db: Add create_database_permission_exist function https://review.openstack.org/109259 | 13:01 |
openstackgerrit | Dina Belova proposed a change to openstack/oslo-incubator: Delete the token and endpoint on expiry of token of client https://review.openstack.org/118628 | 13:03 |
*** _amrith_ is now known as amrith | 13:10 | |
*** tongli has joined #openstack-oslo | 13:20 | |
openstackgerrit | Victor Sergeyev proposed a change to openstack/oslo.db: Reorganize DbTestCase to use provisioning completely https://review.openstack.org/110170 | 13:20 |
*** mriedem has joined #openstack-oslo | 13:21 | |
*** gordc has joined #openstack-oslo | 13:21 | |
*** zzzeek has joined #openstack-oslo | 13:23 | |
*** bknudson has quit IRC | 13:26 | |
openstackgerrit | Ann Kamyshnikova proposed a change to openstack/oslo.db: ModelsMigrationsSync: Add check for foreign keys https://review.openstack.org/116238 | 13:28 |
viktors | zzzeek: hi! | 13:33 |
zzzeek | hey | 13:34 |
viktors | zzzeek: question as for patch https://review.openstack.org/#/c/110170/ - is it a sense to merge it now? Or we should wait by your spec? | 13:35 |
zzzeek | I think that one is fine to merge in any case | 13:36 |
zzzeek | its only the beginning of the series | 13:36 |
viktors | zzzeek: ok, I just want to ensure, that is will be safe :) | 13:36 |
viktors | thanks | 13:36 |
zzzeek | tehyre *all* safe…but we have to wait | 13:37 |
zzzeek | for the other two :) | 13:37 |
rpodolyaka | viktors: don't you trust our CI? :) | 13:37 |
jokke_ | if it's not going to fully be there for j3, do not +A it now ;) | 13:38 |
rpodolyaka | this one is probably self-sufficient | 13:38 |
jokke_ | Point is that if it's not needed before ff, it should not be consuming the gate resources as the Q is quite a hell of a lot atm | 13:39 |
rpodolyaka | oh, yeah, that makes sense of course | 13:39 |
jokke_ | the gate is about 18.5hrs atm. and j3 should be carved tomorrow ;) | 13:40 |
rpodolyaka | btw, what's our policy on FF? does it mean, that changes uploaded *before* the FF date should still be reviewed and merged? | 13:41 |
jokke_ | the changes needs to be merged before the tag | 13:41 |
jokke_ | effectively only the changes that are already in gate Q and are not expected to fail should be going in ... rest for J would need FFE and delayed until the Q has been cleared | 13:42 |
jokke_ | to avoid extra load and merge conflicts | 13:43 |
jokke_ | so preferably depending to each other in +A order already | 13:43 |
*** bknudson has joined #openstack-oslo | 13:44 | |
*** dhellmann has quit IRC | 13:57 | |
*** dhellmann has joined #openstack-oslo | 13:58 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.utils: Remove unused dependency on oslo.config https://review.openstack.org/118438 | 14:02 |
*** jeckersb_gone is now known as jeckersb | 14:08 | |
*** zz_jgrimm is now known as jgrimm | 14:09 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Remove dependency on global CONF https://review.openstack.org/118644 | 14:11 |
openstackgerrit | A change was merged to openstack-dev/pbr: Look for and process sem-ver pseudo headers in git https://review.openstack.org/108270 | 14:11 |
*** mtanino has joined #openstack-oslo | 14:20 | |
openstackgerrit | James E. Blair proposed a change to openstack-dev/pbr: Accept capitalized Sem-Ver headers https://review.openstack.org/118648 | 14:30 |
*** jecarey has joined #openstack-oslo | 14:33 | |
*** HenryG_afk is now known as HenryG | 14:36 | |
*** ildikov has joined #openstack-oslo | 14:36 | |
*** stevemar has joined #openstack-oslo | 14:36 | |
openstackgerrit | James E. Blair proposed a change to openstack-dev/pbr: Accept capitalized Sem-Ver headers https://review.openstack.org/118648 | 14:37 |
*** ildikov_ has quit IRC | 14:40 | |
*** ildikov has quit IRC | 14:41 | |
*** i159 has quit IRC | 14:53 | |
*** AAzza is now known as AAzza_afk | 14:58 | |
*** pblaho is now known as pblaho|afk | 14:59 | |
*** mriedem has quit IRC | 15:00 | |
*** mriedem has joined #openstack-oslo | 15:01 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Move the option definitions into a private file https://review.openstack.org/118615 | 15:05 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Make the local module private https://review.openstack.org/118616 | 15:05 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Remove dependency on global CONF https://review.openstack.org/118644 | 15:05 |
*** pblaho|afk is now known as pblaho | 15:07 | |
*** AAzza_afk is now known as AAzza | 15:08 | |
*** pblaho is now known as pblaho|afk | 15:22 | |
*** alexpilotti has joined #openstack-oslo | 15:34 | |
*** pblaho|afk is now known as pblaho | 15:34 | |
*** yamahata has quit IRC | 15:39 | |
flaper87 | dhellmann: dims you guys around? I'm still having some issues with the DeprecatedOpt thing and I can't quite figure out what's going on. I could use some extra pair of eyes. | 15:40 |
flaper87 | this seems to work as expected: https://github.com/openstack/glance_store/blob/master/glance_store/backend.py#L29-L43 | 15:40 |
flaper87 | but doing this doesn't seem to work: https://review.openstack.org/#/c/118611/1/glance_store/driver.py,cm | 15:40 |
flaper87 | I also added `deprecated_opts` to the drivers and it still doesn't work | 15:41 |
flaper87 | By it doesn't work I mean the old config option value is not being read | 15:41 |
flaper87 | It's weird, I even ran register_opt manually in pdb to try it and it didn't work | 15:41 |
flaper87 | just wondering if you guys have seen similar issues | 15:42 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Move handlers and formatters out https://review.openstack.org/118665 | 15:46 |
*** jeckersb is now known as jeckersb_gone | 15:47 | |
dims | flaper87: did you try adding group='DEFAULT' into the DeprecatedOpt? | 15:50 |
flaper87 | dims: I'm trying that now | 15:51 |
flaper87 | I think I found the bug in oslo.cfg | 15:51 |
flaper87 | it's precisely related to that | 15:51 |
*** dtantsur is now known as dtantsur|afk | 15:58 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Extract WritableLogger from log module https://review.openstack.org/118671 | 16:00 |
dims | flaper87: bug #? | 16:01 |
flaper87 | dims: still have to open it | 16:01 |
flaper87 | :D | 16:01 |
flaper87 | dims: but it's in this line: https://github.com/openstack/oslo.config/blob/master/oslo/config/cfg.py#L684 | 16:01 |
flaper87 | if dgroup is None, it shouldn't fallback to group_name | 16:02 |
flaper87 | IMHO | 16:02 |
flaper87 | it should fallback to DEFAULT | 16:02 |
dims | dhellmann: i lined up a bunch of reviews for oslo.log when you get a chance. feel free to update the reviews directly or leave notes for me when you get a chance after the milestone is over. no hurries. | 16:02 |
dhellmann | dims: ok. I wonder if we should leave CI resources available for the feature freeze, and work on oslo.log more next week? | 16:03 |
flaper87 | oh well, actually, it's hard to tell | 16:03 |
dims | flaper87: i'd run that by markmc there was a reason he defaulted that way, (don't remember why) | 16:03 |
*** vish1 has joined #openstack-oslo | 16:03 | |
dims | dhellmann: sounds good | 16:03 |
flaper87 | if we fallback to `group_name` it means we're using the deprecatedopt as a deprecated_name | 16:03 |
flaper87 | but from an oslo.config point of view, no group means DEFAULT | 16:03 |
flaper87 | so, I'd probably go with default which is consistent with oslo.config's API | 16:04 |
flaper87 | dims: sure, I'll ping him | 16:04 |
dims | flaper87: if we change behavior we may break someone else :) | 16:04 |
dhellmann | flaper87: it seems like you'd want the easy case of renaming an option within a group to be the "default" behavior, though | 16:04 |
dhellmann | flaper87: and yeah, as dims says, changing that behavior is going to break things, so we probably need to fix it through documentation | 16:05 |
flaper87 | dhellmann: yeah, that's the current behaviour | 16:05 |
flaper87 | I'm find with keeping it, I'll just update the docs to make sure we mention that None doesn't mean DEFAULT | 16:05 |
dhellmann | flaper87: right, which you're proposing to change? | 16:05 |
dhellmann | flaper87: ok, that sounds good | 16:05 |
* flaper87 wasted some hours "debugging" this :P | 16:05 | |
flaper87 | dhellmann: yeah I was proposing to change it but the current behaviour makes sense too so, changing it is not worth it | 16:06 |
dhellmann | flaper87: I've thought about providing a cli in oslo.config that could load option definitions and parse a config file and then report where it is getting a specific option | 16:07 |
*** jeckersb` has joined #openstack-oslo | 16:08 | |
*** vishy has quit IRC | 16:08 | |
*** vish1 is now known as vishy | 16:08 | |
*** k4n0 has quit IRC | 16:08 | |
*** jaosorior has quit IRC | 16:08 | |
*** sileht has quit IRC | 16:08 | |
*** jeckersb_gone has quit IRC | 16:08 | |
*** freyes has quit IRC | 16:08 | |
*** ujjain2 has quit IRC | 16:08 | |
*** GheRivero has quit IRC | 16:08 | |
*** k4n0_ has joined #openstack-oslo | 16:08 | |
*** ujjain has joined #openstack-oslo | 16:09 | |
*** freyes has joined #openstack-oslo | 16:10 | |
*** jaosorior has joined #openstack-oslo | 16:10 | |
*** sileht has joined #openstack-oslo | 16:11 | |
*** pblaho has quit IRC | 16:12 | |
*** GheRivero has joined #openstack-oslo | 16:13 | |
openstackgerrit | Flavio Percoco proposed a change to openstack/oslo.config: Explain groups for DeprecatedOpts https://review.openstack.org/118680 | 16:19 |
flaper87 | dims: dhellmann ^ docs updated | 16:20 |
flaper87 | no need to review now, obviously | 16:20 |
flaper87 | just a heads up | 16:20 |
dims | dhellmann: anything i can help with? (for the milestone) | 16:33 |
*** praneshp has joined #openstack-oslo | 16:37 | |
*** mriedem1 has joined #openstack-oslo | 16:40 | |
*** mriedem has quit IRC | 16:44 | |
*** arnaud has joined #openstack-oslo | 16:45 | |
*** takedakn has joined #openstack-oslo | 17:04 | |
openstackgerrit | Ben Nemec proposed a change to openstack/oslo-incubator: Use file locks by default again https://review.openstack.org/118457 | 17:13 |
*** harlowja_away is now known as harlowja | 17:20 | |
dhellmann | dims: I've started some notes, but we look like we're in pretty good shape: https://etherpad.openstack.org/p/juno-oslo-feature-freeze | 17:20 |
dhellmann | dims: https://review.openstack.org/#/c/105362/ may be the only blueprint item we would classify as needing to land before the freeze | 17:21 |
dims | dhellmann: ack. will review that | 17:21 |
*** mtanino has quit IRC | 17:31 | |
*** alexpilotti has quit IRC | 17:39 | |
*** alexpilotti has joined #openstack-oslo | 17:41 | |
harlowja | so dhellmann i filed out quite a bit of https://etherpad.openstack.org/p/taskflow-oslo-db-messaging (for the oslo.messaging part), i'm still sorta on the side that moving to oslo.messaging wouldn't really add that much value (oslo.db i think going there is fine) | 17:43 |
*** AAzza has left #openstack-oslo | 17:43 | |
openstackgerrit | A change was merged to openstack/taskflow: Cleanup WBE example to be simpler to understand https://review.openstack.org/105963 | 17:51 |
dhellmann | harlowja: ok, I'll take a look. | 17:51 |
harlowja | thx | 17:52 |
*** morganfainberg is now known as morganfainberg_Z | 17:53 | |
*** arnaud has quit IRC | 17:53 | |
*** mtanino has joined #openstack-oslo | 17:55 | |
dhellmann | lifeless: have you seen https://github.com/peritus/bumpversion ? could we use that for managing version tags instead of building logic into pbr? | 17:58 |
*** mriedem1 is now known as mriedem | 18:07 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Be explicit about publish keyword arguments https://review.openstack.org/117896 | 18:08 |
openstackgerrit | Doug Hellmann proposed a change to openstack/cliff: warn against sorting requirements https://review.openstack.org/118715 | 18:18 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Allow the proxy to create and provide a retry policy https://review.openstack.org/117901 | 18:18 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Allow the proxy to create and provide a retry policy https://review.openstack.org/117901 | 18:19 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.concurrency: warn against sorting requirements https://review.openstack.org/118716 | 18:20 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.config: warn against sorting requirements https://review.openstack.org/118717 | 18:21 |
harlowja | pip really needs https://github.com/pypa/pip/issues/988 :-P | 18:21 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.db: warn against sorting requirements https://review.openstack.org/118719 | 18:23 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.i18n: warn against sorting requirements https://review.openstack.org/118720 | 18:24 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.log: warn against sorting requirements https://review.openstack.org/118722 | 18:25 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.messaging: warn against sorting requirements https://review.openstack.org/118724 | 18:25 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.middleware: warn against sorting requirements https://review.openstack.org/118725 | 18:26 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.rootwrap: warn against sorting requirements https://review.openstack.org/118726 | 18:26 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.serialization: warn against sorting requirements https://review.openstack.org/118727 | 18:27 |
*** arnaud has joined #openstack-oslo | 18:27 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.utils: warn against sorting requirements https://review.openstack.org/118728 | 18:28 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.vmware: warn against sorting requirements https://review.openstack.org/118729 | 18:28 |
openstackgerrit | Doug Hellmann proposed a change to openstack/stevedore: warn against sorting requirements https://review.openstack.org/118730 | 18:28 |
openstackgerrit | Doug Hellmann proposed a change to openstack/taskflow: warn against sorting requirements https://review.openstack.org/118731 | 18:29 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslotest: warn against sorting requirements https://review.openstack.org/118734 | 18:36 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslosphinx: warn against sorting requirements https://review.openstack.org/118735 | 18:37 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-incubator: warn against sorting requirements https://review.openstack.org/118736 | 18:37 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.db: Fix formatting of usage.rst https://review.openstack.org/118214 | 18:40 |
dhellmann | flaper87: what do you think about an FFE for the AMQP 1.0 work? Can we land it by our RC cut-off of 18 Sept? | 18:47 |
dhellmann | dims, bnemec, sileht: ^^ | 18:47 |
dhellmann | markmc: ^^, though I know you may be too busy to reply this week | 18:47 |
dhellmann | the ML thread on that is http://lists.openstack.org/pipermail/openstack-dev/2014-September/044782.html | 18:48 |
sileht | dhellmann, I'm ok, it will be easier to review next iteration and bug fix, Ken Giusti have done the todo list (pyngys lib, packaging stuff, ...) discuted at Atlanta, so... | 19:05 |
sileht | dhellmann, next step for that is waiting that a linux distribution deliver the package | 19:06 |
dhellmann | sileht: well, that's a good point -- if the other libs they need aren't included, does it matter if the driver is in oslo.messaging yet? | 19:06 |
dhellmann | sileht: we should probably discuss this on the ML thread so Ken sees the conversation and can respond | 19:07 |
sileht | dhellmann, yep, I will answer tomorrow | 19:07 |
dhellmann | sileht: ok, thanks | 19:07 |
bnemec | I wish that wasn't such a huge patch. | 19:07 |
bnemec | It's effectively impossible to review in its current state. | 19:08 |
dhellmann | bnemec: yeah, but I'm not sure how it could be broken up, really :-/ | 19:08 |
bnemec | dhellmann: Yeah, me either. | 19:08 |
bnemec | Other than maybe some contrived stubbing. | 19:08 |
bnemec | So, with the caveats that Red Hat wants this in this cycle and I don't know oslo.messaging very well, I'm okay with it happening this cycle. | 19:11 |
bnemec | I'm told that it's an unintrusive change (and that seems reasonable based on the review available). | 19:11 |
bnemec | And since we can't possibly review a 2000 line patch, we might as well get it in and let people start banging on it to find the weak spots. | 19:12 |
dhellmann | bnemec: yeah, the code is restricted to the new driver so it shouldn't break anything else | 19:12 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.rootwrap: Initial cut of documentation for oslo.rootwrap https://review.openstack.org/118752 | 19:26 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.rootwrap: Initial cut of documentation for oslo.rootwrap https://review.openstack.org/118752 | 19:28 |
* flaper87 back from dinner | 19:39 | |
flaper87 | dhellmann: I think it's safe and we should let that work land | 19:40 |
flaper87 | I don't think we can break that patch into smaller patches. Lots of code was taken out of the patch when pyngus was create | 19:40 |
flaper87 | created* | 19:40 |
dhellmann | flaper87: I think that's the general consensus. I did want to make sure there's some sort of clear path for deployers to actually use it, so I asked about the other library they need (I can never remember its name, not pyngus) | 19:41 |
flaper87 | dhellmann: qpid-proton ? | 19:41 |
dhellmann | flaper87: yeah | 19:41 |
dhellmann | Ken said it's in EPEL and work is happening for Debian | 19:41 |
flaper87 | AFAIU, it's almost in debian/ubuntu and it's already in EPEL | 19:42 |
flaper87 | yeah | 19:42 |
dhellmann | I wonder if that's sufficient. It is an experimental driver | 19:42 |
flaper87 | I believe it is, I installed everything the other day to play a bit with it | 19:42 |
dhellmann | I have a few comments so far on the code itself, but I'm suggesting those as follow-up changes to make them easier to review and then we can land the series all at once | 19:42 |
jogo | zzzeek: ping | 19:42 |
dhellmann | the main thing so far is the options need to be registered in a unique group | 19:42 |
flaper87 | and I managed to get it running. Other than installing that package, I didn't have to do much | 19:42 |
dhellmann | cool, that's good to know | 19:43 |
jogo | zzzeek: your thoughts on https://review.openstack.org/#/c/53019/ would be apprecated | 19:43 |
jogo | zzzeek: MySQLdb: Add framework for mysqldb impl | 19:43 |
flaper87 | I think there're things to improve and probably some to clean up but as I mentioned in the review, if we don't let it land we won't be able to test it nor improve it. | 19:43 |
flaper87 | since it's an opt-in driver, I think it's fine | 19:44 |
jogo | zzzeek: AFAIK it is what rackspace is running in production for there DB layer | 19:44 |
flaper87 | hopefully there'll be enough folks interested in testing it | 19:44 |
dhellmann | flaper87: yeah, like I said, the options are the only thing that I really think we have to fix before landing because it's a pain to move them after | 19:44 |
flaper87 | We can always remove it if the gate and other things don't happen. I'd recommend re-evaluating the driver at the end of Kilo (assuming we let it land) | 19:44 |
flaper87 | dhellmann: +1 | 19:45 |
dhellmann | flaper87: re-evaluating is a good idea for *all* of our drivers next cycle | 19:45 |
dhellmann | flaper87: we've been carrying what I think is a broken zmq driver for ages | 19:45 |
flaper87 | dhellmann: yeah, I wish we had marked it as deprecated during Juno | 19:46 |
flaper87 | Is it too late? | 19:46 |
dhellmann | flaper87: yeah, we can't deprecate things for juno now, but we can do it early in kilo -- I want to give someone a chance to step up to maintain it if they care about it | 19:46 |
flaper87 | dhellmann: we did that at the Juno summit. 2 guys raised their hands then nothing happened | 19:46 |
flaper87 | AFAICS | 19:46 |
flaper87 | we should do the same and set some goals | 19:47 |
flaper87 | if nothing happens by k-1, the driver will be deprecated in k-2 | 19:47 |
dhellmann | flaper87: last chance, with the default of removing things at k2? | 19:47 |
flaper87 | or something along that line | 19:47 |
dhellmann | heh | 19:47 |
flaper87 | :D | 19:47 |
* dhellmann goes to add that to his summit planning list | 19:47 | |
dhellmann | flaper87: see the new entry on https://etherpad.openstack.org/p/kilo-oslo-summit-topics | 19:49 |
* flaper87 clicks | 19:50 | |
* flaper87 interested | 19:50 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslosphinx: Add initial cut for documentation https://review.openstack.org/118756 | 19:52 |
dims | dhellmann: zmq broken since we don't run it in any gate/check. afraid, will land up in the same problem with the amqp 1.0 driver :( | 19:54 |
dhellmann | dims: yeah, I was led to believe Ken had some systems running integration tests though | 19:54 |
dhellmann | dims: let me find that... | 19:54 |
dims | dhellmann: thanks | 19:55 |
dhellmann | http://lists.openstack.org/pipermail/openstack-dev/2014-August/041719.html | 19:55 |
dhellmann | dims: and https://review.openstack.org/#/c/115752/ | 19:56 |
dims | dhellmann: that's even better! | 19:56 |
dhellmann | dims: indeed | 19:56 |
kgiusti | dhellmann: dims: hi - anything I can help with? | 19:57 |
dhellmann | kgiusti: aha, I knew you were on irc but couldn't remember your handle | 19:57 |
dhellmann | kgiusti: we're reaching some consensus on allowing a FFE for the driver work you're doing. As part of that, I'd like to understand where the pieces in motion stand. Do you have some sort of summary of that you can point me to? An etherpad maybe? | 19:58 |
dhellmann | kgiusti: I'd like to know what infra thinks of the test jobs, for instance | 19:58 |
dims | kgiusti: do you see scrollback? esp flaper87's comments above | 19:58 |
* kgiusti looks... | 19:58 | |
openstackgerrit | A change was merged to openstack/oslo-incubator: Mark log code as graduating https://review.openstack.org/117615 | 19:59 |
kgiusti | dhellmann: I've kept a short summary of my immediate tasks on the blueprint whiteboard/work items: https://blueprints.launchpad.net/oslo.messaging/+spec/amqp10-driver-implementation | 20:01 |
kgiusti | dhellmann: but I should add more detail regarding what I'm 'blocked' on re: testing. | 20:01 |
dhellmann | kgiusti: that would be great, thanks | 20:02 |
kgiusti | dhellmann: Ok, let me follow up on that. | 20:03 |
dhellmann | kgiusti: just to be clear, we want to help land this, I just want to make sure we have all our ducks in a row before we do | 20:04 |
dims | kgiusti: planning to run amqp10 with tempest - soonish? | 20:04 |
kgiusti | dhellmann: agree completely, thanks! | 20:04 |
kgiusti | dims: I've proposed a CI check test: https://review.openstack.org/#/c/115752/ which does exactly that. I've got some positive feedback from Ian on it. | 20:05 |
kgiusti | dims: currently, it's blocked waiting for Ian to land his 'bare' fedora 20 node changes: https://review.openstack.org/#/c/117397/ which it depends on. | 20:06 |
dims | kgiusti: thanks! | 20:06 |
*** stevemar has quit IRC | 20:07 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Remove attrdict and just use existing types https://review.openstack.org/116191 | 20:22 |
openstackgerrit | Matt Riedemann proposed a change to openstack/oslo.serialization: Check for namedtuple_as_object support before using it https://review.openstack.org/117854 | 20:24 |
*** gordc has quit IRC | 20:24 | |
openstackgerrit | Matt Riedemann proposed a change to openstack/oslo.serialization: Check for namedtuple_as_object support before using it https://review.openstack.org/117854 | 20:28 |
openstackgerrit | Jeremy Stanley proposed a change to openstack-dev/hacking: Work toward Python 3.4 support and testing https://review.openstack.org/118765 | 20:28 |
openstackgerrit | Jeremy Stanley proposed a change to openstack-dev/pbr: Work toward Python 3.4 support and testing https://review.openstack.org/118766 | 20:28 |
openstackgerrit | Jeremy Stanley proposed a change to openstack/cliff: Work toward Python 3.4 support and testing https://review.openstack.org/118772 | 20:29 |
openstackgerrit | Matt Riedemann proposed a change to openstack/oslo.serialization: Check for namedtuple_as_object support before using it https://review.openstack.org/117854 | 20:29 |
*** mriedem has left #openstack-oslo | 20:29 | |
*** mriedem has joined #openstack-oslo | 20:30 | |
openstackgerrit | Jeremy Stanley proposed a change to openstack/oslo-incubator: Work toward Python 3.4 support and testing https://review.openstack.org/118785 | 20:30 |
openstackgerrit | Jeremy Stanley proposed a change to openstack/oslo.concurrency: Work toward Python 3.4 support and testing https://review.openstack.org/118786 | 20:30 |
openstackgerrit | Jeremy Stanley proposed a change to openstack/oslo.config: Work toward Python 3.4 support and testing https://review.openstack.org/118787 | 20:30 |
openstackgerrit | Jeremy Stanley proposed a change to openstack/oslo.i18n: Work toward Python 3.4 support and testing https://review.openstack.org/118788 | 20:30 |
openstackgerrit | Jeremy Stanley proposed a change to openstack/oslo.log: Work toward Python 3.4 support and testing https://review.openstack.org/118789 | 20:30 |
openstackgerrit | Jeremy Stanley proposed a change to openstack/oslo.messaging: Work toward Python 3.4 support and testing https://review.openstack.org/118790 | 20:30 |
openstackgerrit | Jeremy Stanley proposed a change to openstack/oslo.middleware: Work toward Python 3.4 support and testing https://review.openstack.org/118791 | 20:30 |
openstackgerrit | Jeremy Stanley proposed a change to openstack/oslo.rootwrap: Work toward Python 3.4 support and testing https://review.openstack.org/118792 | 20:30 |
openstackgerrit | Jeremy Stanley proposed a change to openstack/oslo.serialization: Work toward Python 3.4 support and testing https://review.openstack.org/118793 | 20:30 |
openstackgerrit | Jeremy Stanley proposed a change to openstack/oslo.utils: Work toward Python 3.4 support and testing https://review.openstack.org/118794 | 20:30 |
openstackgerrit | Jeremy Stanley proposed a change to openstack/oslo.vmware: Work toward Python 3.4 support and testing https://review.openstack.org/118795 | 20:30 |
mriedem | bknudson: hopefully this simplifies things https://review.openstack.org/#/c/117854/ | 20:30 |
openstackgerrit | Jeremy Stanley proposed a change to openstack/oslotest: Work toward Python 3.4 support and testing https://review.openstack.org/118796 | 20:30 |
openstackgerrit | Jeremy Stanley proposed a change to openstack/pycadf: Work toward Python 3.4 support and testing https://review.openstack.org/118797 | 20:30 |
openstackgerrit | Jeremy Stanley proposed a change to openstack/stevedore: Work toward Python 3.4 support and testing https://review.openstack.org/118811 | 20:31 |
bknudson | mriedem: does that work? to import json after import x as json? | 20:31 |
openstackgerrit | Jeremy Stanley proposed a change to openstack/taskflow: Work toward Python 3.4 support and testing https://review.openstack.org/118813 | 20:31 |
bknudson | I tried it and it works. | 20:32 |
openstackgerrit | Andreas Jaeger proposed a change to openstack-dev/cookiecutter: warn against sorting requirements https://review.openstack.org/118838 | 20:32 |
dhellmann | bknudson: the "as json" changes the name bound in the local scope, but not the sys.modules entry for it | 20:32 |
openstackgerrit | Jeremy Stanley proposed a change to openstack-dev/cookiecutter: Work toward Python 3.4 support and testing https://review.openstack.org/118855 | 20:33 |
openstackgerrit | Jeremy Stanley proposed a change to openstack-dev/oslo-cookiecutter: Work toward Python 3.4 support and testing https://review.openstack.org/118856 | 20:33 |
jokke_ | this looks exactly like preserving the resources for gating the j3 critical commits ;) | 20:33 |
dhellmann | jokke_; yeah, those are check jobs but still | 20:33 |
jokke_ | dhellmann: does not help if the check Q is 5hrs before getting into the gate which is what 19hrs atm :D | 20:34 |
bknudson | mriedem: I think the logic is reversed | 20:34 |
* bnemec is really tempted to not fix that json but in the library | 20:34 | |
bknudson | if 'namedtuple_as_object' in inspect.getargspec(json.dumps).args -- then it should use simplejson | 20:35 |
bnemec | But you know if we do that then we'll end up deciding we have to keep 2.6 around for another cycle and get bit during adoptions. | 20:35 |
bknudson | bnemec: you have the luxury of deciding whether to keep 2.6 around. | 20:35 |
bnemec | *json bu_g_ | 20:35 |
bnemec | bknudson: Right, but oslo.serialization won't get adopted for Juno, and for Kilo 2.6 isn't planned for support. | 20:36 |
openstackgerrit | Doug Hellmann proposed a change to openstack-dev/oslo-cookiecutter: warn against sorting requirements https://review.openstack.org/118858 | 20:36 |
openstackgerrit | Matt Riedemann proposed a change to openstack/oslo.serialization: Check for namedtuple_as_object support before using it https://review.openstack.org/117854 | 20:39 |
mriedem | bknudson: working on too many things at once.. ^ | 20:39 |
mriedem | bnemec: oslo.serialization won't get adopted for Juno for which project(s)? | 20:41 |
mriedem | bnemec: anyway, my patch starts in oslo.serialization but i'll have to cherry pick to oslo-incubator for keystone which synced in the bug with namedtuple_as_object | 20:41 |
bknudson | I don't think any project will adopt it... it was released recently | 20:41 |
mriedem | i've got my eye on the nova review | 20:41 |
bnemec | mriedem: Any of them at this point. We just released the first version last week and I can't believe anyone is doing adoption at this point in the cycle. | 20:41 |
mriedem | bnemec: we're still looking to merge oslo.db in nova this week | 20:42 |
mriedem | it's funny because these oslo libs patches aren't tied to blueprints | 20:42 |
bnemec | O.O | 20:42 |
mriedem | so i think they are coming in under the FFE radar | 20:42 |
bknudson | there should have been blueprints | 20:42 |
bknudson | protip | 20:42 |
mriedem | yeah there probably should have been | 20:42 |
bnemec | Heh | 20:42 |
mriedem | we've merged a few new oslo libs in nova w/o blueprints this release though | 20:42 |
* dhellmann pretends he didn't hear any of that | 20:42 | |
bnemec | I thought after FF anything without an approved bp or bug got -2'd. | 20:43 |
mriedem | oslo.db fixes a few nova bugs | 20:43 |
mriedem | so those are tied in | 20:43 |
mriedem | like the retry on deadlock fail that's been hitting the gate pretty well for a month or two | 20:43 |
mriedem | hmm, i don't have a bug for this https://review.openstack.org/#/c/118751/ | 20:43 |
bnemec | Still scary though. There have been quite a few significant changes in oslo.db since it graduated. | 20:44 |
mriedem | guess i should -2 it :P | 20:44 |
bnemec | mriedem: Would avoid it taking up gate resources. :-P | 20:44 |
mriedem | meh | 20:45 |
mriedem | drop in the bucket | 20:45 |
openstackgerrit | Joshua Harlow proposed a change to openstack/oslo.utils: Add the ability to extract the query params from a urlsplit https://review.openstack.org/118881 | 20:45 |
mriedem | i could bring this up in the nova meeting on thursday but then we'll be past juno-3, i could bring it up in the mailing list but i wouldn't mind seeing some of these libs make it into nova in juno, i think jogo is in the same boat | 20:46 |
* mriedem debates how quiet to be | 20:46 | |
* jogo reads backlog | 20:47 | |
bknudson | I'm just glad my nick isn't juno. | 20:47 |
jogo | mriedem bnemec: I would like to see oslo.db land in Juno | 20:48 |
jogo | as for oslo.serialization unless it fixes a few known bugs | 20:48 |
jogo | I don't think we should try for it | 20:48 |
mriedem | jogo: there is also oslo.utils | 20:48 |
jogo | as we already have a lot of important things for FFE | 20:48 |
jogo | mriedem: same rule of thumb, if moving to oslo,* has the promise of fixing a few bugs lets do it | 20:49 |
jogo | otherwise we just have tons on our place for FFE | 20:49 |
jogo | mainly ironic | 20:49 |
bknudson | oslo.utils didn't work for keystonemiddleware because of tests mocking the time function | 20:49 |
dhellmann | I would rather have you work on those for k-1, since we don't have some of the gate stuff worked out for the newer libs. oslo.db is good, but the others can safely wait | 20:49 |
dhellmann | bknudson: right, that's a good point, and part of why we want to delete some of the old stuff from the incubator as soon as we cut our stable branch | 20:50 |
jogo | dhellmann: I expect an oslo.db person to ask for a nova FFE btw | 20:50 |
dhellmann | jogo: aren't you our liaison? | 20:50 |
jogo | dhellmann: yup, and I am happy to sign up as a core | 20:50 |
jogo | but the patch author(s) should ask for FFE | 20:50 |
dhellmann | jogo: it is up the projects to decide when they're ready to adopt. I don't know who submitted that patch off the top of my head | 20:50 |
mriedem | dhellmann: mirantis peeps | 20:51 |
dhellmann | mriedem: ok, I'll mention the FFE to them | 20:51 |
jogo | dhellmann: https://review.openstack.org/#/c/101901/ | 20:51 |
mriedem | jogo: i'm also signing up as reviewer for oslo.db, | 20:51 |
jogo | mriedem: awesome | 20:51 |
mriedem | jogo: maybe we -2 the oslo in-flight changes for now | 20:51 |
jogo | mriedem: shouldn't be too hard to get a 3rd core for oslo.db | 20:51 |
mriedem | i'll get out the red pen | 20:52 |
jogo | mriedem: ++ to -2ing other oslo sync in flight | 20:52 |
jogo | mriedem: you want to or should I? | 20:52 |
jogo | https://review.openstack.org/#/q/project:openstack/nova++is:open+branch:master+file:%255Enova/openstack/common.*,n,z | 20:52 |
jogo | mriedem: or split the -2ing | 20:52 |
mriedem | doing it now | 20:52 |
bnemec | jogo: You may need to sync lockutils before release. | 20:52 |
bknudson | I hope the security fixes don't get -2. | 20:53 |
jogo | bnemec: https://review.openstack.org/#/c/116981/ ? | 20:53 |
mriedem | i'm only looking at libs, not oslo-incubator syncs for bug fixes | 20:53 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Move failure to its own type specific module https://review.openstack.org/102091 | 20:53 |
*** markmcclain1 has joined #openstack-oslo | 20:53 | |
jogo | mriedem: wahat other oslo.* patches are u? | 20:53 |
jogo | up* | 20:53 |
*** markmcclain has quit IRC | 20:54 | |
mriedem | jogo: https://review.openstack.org/#/c/117336/ https://review.openstack.org/#/c/101901/ https://review.openstack.org/#/c/110797/ | 20:55 |
jogo | mriedem: odd those don't drop the oslo incubator copies | 20:55 |
jogo | which is why I didn't notice them | 20:55 |
bknudson | sometimes the oslo-incubator copy is used internally by oslo-incubator | 20:56 |
jogo | bknudson: lol make sense | 20:56 |
dhellmann | jogo: yeah, again, that's why we want to accelerate deleting code from the incubator so we can make it use the libraries as we graduate things | 20:58 |
dhellmann | bnemec's point about having to backport extra changes notwithstanding, I think that's still our best path forward | 20:58 |
mriedem | jogo: i've gone through the current syncs and libs changes, the lib changes have -2 - i said in the oslo.db one to put out a FFE and they already have 2/3 cores | 20:59 |
dhellmann | jogo, mriedem : I also copied you on the email I just sent to the oslo.db drivers | 20:59 |
bnemec | dhellmann: Yeah, like I said, I haven't come up with a better option either. | 20:59 |
mriedem | i'd like to see this fixed and backported to jsonutils before we sync that over https://review.openstack.org/#/c/117854/ | 20:59 |
dhellmann | bnemec: yeah, it feels sort of "cross our fingers and hope" but without a better option... | 21:00 |
*** markmcclain1 has quit IRC | 21:01 | |
*** markmcclain has joined #openstack-oslo | 21:01 | |
bnemec | dhellmann: We can always try it for a cycle and have a postmortem at the L summit. | 21:01 |
dhellmann | mriedem: I updated the bug for that patch to include oslo.serialization separately and then +2 the patch | 21:03 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Hoist the notifier to its own module https://review.openstack.org/102372 | 21:05 |
mriedem | dhellmann: thanks | 21:07 |
mriedem | dims: you wanna be the final vote on this? https://review.openstack.org/#/c/117854/ | 21:09 |
zzzeek | jogo: I think that is pretty awful :) | 21:09 |
zzzeek | jogo: for starters it doesnt even work with eventlet b.c. mysqldb doesnt support eventlet | 21:10 |
zzzeek | jogo: nor does it work with py3k, because mysqldb doesnt support py3k | 21:10 |
bnemec | mriedem: I was just waiting for a CI pass. tripleo has made me paranoid about approving things before CI has voted. :-) | 21:10 |
mriedem | zzzeek: what are you referring to? | 21:10 |
mriedem | bnemec: ah ok | 21:11 |
zzzeek | mriedem: https://review.openstack.org/#/c/53019/6 | 21:11 |
mriedem | oh the orm thing | 21:11 |
mriedem | nvm | 21:11 |
*** miqui has quit IRC | 21:11 | |
zzzeek | if we are making huge software changes for speed, dumping MySQL for Postgresql woudl be much much easier and much more effective | 21:12 |
jogo | zzzeek: hehe I thought you wouldn't like it. that was a pre--zzzeek atempt at making db faster | 21:12 |
zzzeek | how well did it work ? | 21:12 |
mriedem | zzzeek: i believe rax is running with that in production | 21:12 |
jogo | zzzeek: AFAIK 2x speedup or something | 21:12 |
zzzeek | jogo: I can get you that with SQLAlchemy and a lot les code | 21:13 |
jogo | zzzeek: mriedem is correct, rax uses this code in production (with eventlet although AFAIK there's is forked) | 21:13 |
mriedem | yeah they've patched eventlet | 21:13 |
zzzeek | jogo / mriedem : here is a profile fresh from some ceilometer testing. three methods that run about 5 SQLAlchemy Core queries, running it 4700 times. tons of SQLAlchemy calls, but somehow, 90% of the time spent is all in just one place: http://paste.openstack.org/show/104991/ | 21:13 |
zzzeek | these are quick little select one row, insert three rows transactions | 21:14 |
zzzeek | so lets rewrite all the SQL and get a 10% increase, and just ignore the elephant in the room | 21:14 |
openstackgerrit | Jeremy Stanley proposed a change to openstack/taskflow: Work toward Python 3.4 support and testing https://review.openstack.org/118813 | 21:14 |
mriedem | maybe the answer is....db2 :) | 21:15 |
zzzeek | mriedem: the answer is, stop doing 4700 transactions for something that should be in like, 10 or 20 | 21:15 |
mriedem | or that | 21:15 |
jogo | zzzeek: ahh https://blueprints.launchpad.net/nova/+spec/db-mysqldb-impl | 21:15 |
jogo | zzzeek: here are the results http://paste.openstack.org/show/31019/ | 21:16 |
jogo | zzzeek: so I wanted to bring it to your attention because I very much thought you wouldn't like it | 21:17 |
zzzeek | jogo: its old news | 21:17 |
jogo | zzzeek: yeah, hopefully we can get RAX off of this and onto something better | 21:17 |
jogo | zzzeek: yup, I just wanted to make sure this was on your radar. | 21:17 |
zzzeek | jogo: there is nothing sqlalchemy does that has anyhing to do with eventlet.tpool, and if there is, i am disappointed nobody has come to me and showed me that. is there stil an observed issue? | 21:17 |
zzzeek | jogo: i mean, seeing all this now after ive been announcing myself for three months makes it look llike people didnt want me to get into this | 21:18 |
jogo | zzzeek: TBH I forgot about it | 21:18 |
jogo | zzzeek: and comstud is a very busy man | 21:18 |
jogo | as for the tpool part I don't think its directly related to SQLA but I am not the expert on this. all of the patches are up for sharing | 21:19 |
zzzeek | jogo: the thing about, SQLA ORM == 1 minute, SQLA Core = 30 seconds, MySQLdb = 10 seconds!!!! OK but the program takes fifteen minutes to run, maybe you dont need to go so far | 21:20 |
dims | mriedem: done! :) | 21:20 |
mriedem | dims: thanks, will get that backported to oslo-incubator on master tonight | 21:21 |
jogo | zzzeek: that test was a single db.api call done 50k times | 21:22 |
dims | mriedem: +1 | 21:22 |
jogo | zzzeek: anyway I brought this up because I should have done so 6 months ago | 21:22 |
zzzeek | jogo: yeah, so, what is the use of that API call in context. do people really need to click a button and run that call 50K times? or is it absorbed into much bigger operations over a long period of time and doesnt make that much of a difference? | 21:24 |
jogo | zzzeek: unfortunately I don't remember of the top of my head, and that call may have changed enough since then that these results are outdated | 21:26 |
zzzeek | jogo: hre’s some modern speed testing, to load 1M rows with SQLAclhemy ORM, Core, and MySQLdb: http://stackoverflow.com/a/25534166/34549 | 21:27 |
*** dhellmann is now known as dhellmann_ | 21:28 | |
zzzeek | jogo: MySQLdb loads 1M of these rows in 3 sec, core does it in 4, ORM with column references does it in 4, ORM with full objects does it in like 13 | 21:28 |
jogo | thats not bad for 1M lines | 21:28 |
zzzeek | jogo: well i did some refactoring last week, before i started, ORM with col referencse was at 8 secs. had to fix one object. | 21:29 |
zzzeek | jogo: this is the thing. you add one slow object to python, you are screwed | 21:29 |
zzzeek | so you do the big rewrite all in MySQLdb. but you make one mistake in there and dont keep profiling it as part of CI, you can get super slow again | 21:29 |
jogo | zzzeek: yup, so the mysqldb rewrite was done before we had you on board | 21:30 |
jogo | now that you, I think it needs to go away which means getting rax off of it | 21:31 |
zzzeek | jogo: here this thing. teeny cahnge to how we return tuples, doubled the speed: http://docs.sqlalchemy.org/en/latest/changelog/migration_10.html#new-keyedtuple-implementation-dramatically-faster | 21:31 |
jogo | and using your work | 21:31 |
zzzeek | jogo: OK well, id have to dig into nova a lot more | 21:31 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.db: Add code/api documentation https://review.openstack.org/118895 | 21:31 |
jogo | anyway having you look at nova bit more would be great, if you have any questions or issues please don't hesitate to ask me. | 21:33 |
zzzeek | jogo: OK! | 21:33 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.middleware: Add code/api documentation https://review.openstack.org/118897 | 21:34 |
harlowja | damn, did nova get a full direct to mysqldb impl? | 21:35 |
harlowja | interesting | 21:35 |
jogo | harlowja: rax is suing it nova didn't merge it | 21:36 |
jogo | upstream | 21:36 |
harlowja | rax is suing nova? | 21:36 |
harlowja | for reals? | 21:36 |
jogo | using* | 21:36 |
jogo | lol | 21:36 |
harlowja | :) | 21:36 |
harlowja | rax does alot of weird things like that ;) | 21:37 |
jogo | yup yup | 21:37 |
harlowja | cough cough cells, lol | 21:37 |
harlowja | maybe they just like pain | 21:40 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add proxy heartbeat support https://review.openstack.org/104397 | 21:44 |
*** mriedem has quit IRC | 21:46 | |
*** kgiusti has quit IRC | 21:49 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: Add docs target and generate api docs https://review.openstack.org/118905 | 21:51 |
*** jaosorior has quit IRC | 22:02 | |
*** jecarey has quit IRC | 22:03 | |
*** openstack has joined #openstack-oslo | 22:11 | |
-sendak.freenode.net- [freenode-info] if you're at a conference and other people are having trouble connecting, please mention it to staff: http://freenode.net/faq.shtml#gettinghelp | 22:11 | |
*** markmcclain has quit IRC | 22:20 | |
*** jeckersb` is now known as jeckersb_gone | 22:20 | |
openstackgerrit | A change was merged to openstack-dev/pbr: use get_boolean_option for warnerrors https://review.openstack.org/117476 | 22:20 |
openstackgerrit | A change was merged to openstack/oslo.middleware: Update docs for first release https://review.openstack.org/116903 | 22:26 |
*** jgrimm is now known as zz_jgrimm | 22:29 | |
*** bknudson has quit IRC | 22:41 | |
*** arnaud has quit IRC | 22:51 | |
*** pcm_ has quit IRC | 22:51 | |
*** dims has quit IRC | 22:52 | |
*** dims has joined #openstack-oslo | 22:52 | |
*** dims has quit IRC | 22:57 | |
openstackgerrit | Aaron Rosen proposed a change to openstack-dev/cookiecutter: Add additional gitignores .swo/.swn https://review.openstack.org/118923 | 23:03 |
*** openstackstatus has quit IRC | 23:19 | |
*** openstackstatus has joined #openstack-oslo | 23:20 | |
*** ChanServ sets mode: +v openstackstatus | 23:20 | |
*** alexpilotti has quit IRC | 23:37 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!