*** salv-orlando has joined #openstack-oslo | 00:05 | |
*** salv-orlando has quit IRC | 00:10 | |
*** yamamoto has joined #openstack-oslo | 00:12 | |
*** openstack has joined #openstack-oslo | 00:14 | |
*** ChanServ sets mode: +o openstack | 00:14 | |
*** yamamoto has quit IRC | 00:17 | |
*** dave-mccowan has joined #openstack-oslo | 00:21 | |
*** spilla has joined #openstack-oslo | 00:30 | |
*** yamamoto has joined #openstack-oslo | 00:38 | |
*** yamamoto has quit IRC | 00:45 | |
*** tovin07_ has joined #openstack-oslo | 00:47 | |
*** yamamoto has joined #openstack-oslo | 00:56 | |
*** bobh has joined #openstack-oslo | 01:05 | |
*** gyankum has joined #openstack-oslo | 01:12 | |
*** yamamoto has quit IRC | 01:14 | |
*** bobh has quit IRC | 01:17 | |
openstackgerrit | melissaml proposed openstack/futurist master: Update links in README https://review.openstack.org/548380 | 01:40 |
---|---|---|
*** bobh has joined #openstack-oslo | 01:45 | |
*** bobh has quit IRC | 01:53 | |
*** salv-orlando has joined #openstack-oslo | 02:07 | |
*** salv-orlando has quit IRC | 02:12 | |
*** AlexeyAbashkin has joined #openstack-oslo | 02:12 | |
*** yamamoto has joined #openstack-oslo | 02:15 | |
*** AlexeyAbashkin has quit IRC | 02:16 | |
*** yamamoto has quit IRC | 02:21 | |
*** yamamoto has joined #openstack-oslo | 02:37 | |
*** yamamoto has quit IRC | 03:18 | |
*** dave-mccowan has quit IRC | 03:55 | |
*** jaosorior has joined #openstack-oslo | 03:56 | |
*** salv-orlando has joined #openstack-oslo | 04:08 | |
*** salv-orlando has quit IRC | 04:13 | |
*** yamamoto has joined #openstack-oslo | 04:19 | |
openstackgerrit | Merged openstack/oslo.cache master: Change memcache_socket_timeout to a float https://review.openstack.org/519353 | 04:24 |
*** yamamoto has quit IRC | 04:25 | |
*** namnh has joined #openstack-oslo | 04:27 | |
*** links has joined #openstack-oslo | 04:46 | |
*** lpetrut has joined #openstack-oslo | 04:55 | |
*** chhagarw has joined #openstack-oslo | 05:03 | |
*** salv-orlando has joined #openstack-oslo | 05:09 | |
*** salv-orlando has quit IRC | 05:09 | |
*** salv-orlando has joined #openstack-oslo | 05:09 | |
*** chhagarw has quit IRC | 05:12 | |
*** yamamoto has joined #openstack-oslo | 05:21 | |
*** lpetrut has quit IRC | 05:26 | |
*** e0ne has joined #openstack-oslo | 05:26 | |
*** lpetrut has joined #openstack-oslo | 05:27 | |
*** yamamoto has quit IRC | 05:27 | |
*** msimonin has quit IRC | 05:28 | |
*** msimonin has joined #openstack-oslo | 05:28 | |
*** msimonin has quit IRC | 05:28 | |
*** msimonin has joined #openstack-oslo | 05:28 | |
*** msimonin has quit IRC | 05:29 | |
*** msimonin has joined #openstack-oslo | 05:29 | |
*** msimonin has quit IRC | 05:30 | |
*** msimonin has joined #openstack-oslo | 05:30 | |
*** msimonin has quit IRC | 05:31 | |
*** msimonin has joined #openstack-oslo | 05:31 | |
*** msimonin has quit IRC | 05:31 | |
*** msimonin has joined #openstack-oslo | 05:32 | |
*** msimonin has quit IRC | 05:32 | |
*** msimonin has joined #openstack-oslo | 05:32 | |
*** e0ne has quit IRC | 05:33 | |
*** msimonin has quit IRC | 05:33 | |
*** lpetrut has quit IRC | 05:39 | |
*** e0ne has joined #openstack-oslo | 05:50 | |
*** lpetrut has joined #openstack-oslo | 05:52 | |
*** e0ne has quit IRC | 06:10 | |
*** yamamoto has joined #openstack-oslo | 06:23 | |
*** yamamoto has quit IRC | 06:28 | |
*** jaosorior has quit IRC | 06:29 | |
*** msimonin has joined #openstack-oslo | 06:31 | |
*** msimonin has quit IRC | 06:35 | |
*** pcaruana has joined #openstack-oslo | 06:38 | |
*** lpetrut has quit IRC | 06:58 | |
*** jaosorior has joined #openstack-oslo | 07:10 | |
*** ianychoi has quit IRC | 07:10 | |
*** rcernin has quit IRC | 07:15 | |
*** pooja_jadhav has quit IRC | 07:21 | |
*** salv-orlando has quit IRC | 07:22 | |
*** pooja_jadhav has joined #openstack-oslo | 07:22 | |
*** salv-orlando has joined #openstack-oslo | 07:22 | |
*** msimonin has joined #openstack-oslo | 07:23 | |
*** yamamoto has joined #openstack-oslo | 07:25 | |
*** tesseract has joined #openstack-oslo | 07:25 | |
*** msimonin has quit IRC | 07:26 | |
*** msimonin has joined #openstack-oslo | 07:26 | |
*** salv-orlando has quit IRC | 07:27 | |
*** yamamoto has quit IRC | 07:30 | |
*** shardy has joined #openstack-oslo | 07:38 | |
*** salv-orlando has joined #openstack-oslo | 07:45 | |
*** salv-orlando has quit IRC | 07:54 | |
*** salv-orlando has joined #openstack-oslo | 07:54 | |
*** lucas-afk is now known as lucasagomes | 07:56 | |
*** salv-orlando has quit IRC | 07:59 | |
*** AlexeyAbashkin has joined #openstack-oslo | 08:00 | |
*** rcernin has joined #openstack-oslo | 08:24 | |
*** yamamoto has joined #openstack-oslo | 08:26 | |
*** e0ne has joined #openstack-oslo | 08:27 | |
*** yamamoto has quit IRC | 08:30 | |
*** oanson has quit IRC | 08:34 | |
*** oanson has joined #openstack-oslo | 08:36 | |
*** lpetrut has joined #openstack-oslo | 08:40 | |
*** rcernin has quit IRC | 08:42 | |
openstackgerrit | wanghui proposed openstack/futurist master: Update links in README https://review.openstack.org/557195 | 08:43 |
*** kashyap has left #openstack-oslo | 08:46 | |
*** lpetrut has quit IRC | 08:47 | |
*** lpetrut has joined #openstack-oslo | 08:47 | |
*** shardy has quit IRC | 09:10 | |
*** shardy has joined #openstack-oslo | 09:12 | |
*** yamamoto has joined #openstack-oslo | 09:27 | |
*** yamamoto has quit IRC | 09:32 | |
*** lpetrut_ has joined #openstack-oslo | 09:41 | |
*** vstinner has joined #openstack-oslo | 09:49 | |
*** salv-orlando has joined #openstack-oslo | 09:58 | |
*** namnh has quit IRC | 10:03 | |
*** tovin07_ has quit IRC | 10:04 | |
*** ianychoi has joined #openstack-oslo | 10:15 | |
*** sambetts|afk is now known as sambetts | 10:18 | |
*** yamamoto has joined #openstack-oslo | 10:29 | |
*** yamamoto has quit IRC | 10:34 | |
*** ansmith has quit IRC | 10:37 | |
*** pbourke has quit IRC | 10:44 | |
*** pbourke has joined #openstack-oslo | 10:45 | |
*** salv-orl_ has joined #openstack-oslo | 10:53 | |
*** salv-orlando has quit IRC | 10:56 | |
*** gyankum has quit IRC | 10:56 | |
*** salv-orlando has joined #openstack-oslo | 10:58 | |
*** salv-orl_ has quit IRC | 10:58 | |
*** links has quit IRC | 11:04 | |
*** salv-orlando has quit IRC | 11:05 | |
*** links has joined #openstack-oslo | 11:05 | |
*** salv-orlando has joined #openstack-oslo | 11:06 | |
*** dave-mccowan has joined #openstack-oslo | 11:09 | |
*** shardy is now known as shardy_lunch | 11:24 | |
*** yamamoto has joined #openstack-oslo | 11:31 | |
*** yamamoto has quit IRC | 11:35 | |
*** salv-orl_ has joined #openstack-oslo | 11:36 | |
*** salv-orlando has quit IRC | 11:41 | |
*** raildo has joined #openstack-oslo | 11:51 | |
*** lucasagomes is now known as lucas-hungry | 11:55 | |
*** bobh has joined #openstack-oslo | 12:06 | |
*** edmondsw has joined #openstack-oslo | 12:06 | |
*** chhagarw has joined #openstack-oslo | 12:08 | |
openstackgerrit | Jan Vondra proposed openstack/oslo.log master: Add log handler for Sentry https://review.openstack.org/518949 | 12:09 |
*** ansmith has joined #openstack-oslo | 12:11 | |
*** msimonin has quit IRC | 12:11 | |
*** lpetrut_ has quit IRC | 12:15 | |
*** msimonin has joined #openstack-oslo | 12:18 | |
*** eck` is now known as eck`gone | 12:22 | |
*** yamamoto has joined #openstack-oslo | 12:22 | |
*** bobh has quit IRC | 12:34 | |
*** kgiusti has joined #openstack-oslo | 12:34 | |
*** msimonin has quit IRC | 12:54 | |
*** lucas-hungry is now known as lucasagomes | 12:55 | |
*** salv-orlando has joined #openstack-oslo | 12:56 | |
*** salv-or__ has joined #openstack-oslo | 12:57 | |
*** salv-orl_ has quit IRC | 12:58 | |
*** msimonin has joined #openstack-oslo | 13:00 | |
*** msimonin has quit IRC | 13:01 | |
*** salv-orlando has quit IRC | 13:02 | |
*** salv-or__ has quit IRC | 13:02 | |
*** salv-orlando has joined #openstack-oslo | 13:03 | |
*** eck`gone is now known as eck` | 13:03 | |
*** msimonin has joined #openstack-oslo | 13:04 | |
*** lbragstad has joined #openstack-oslo | 13:04 | |
*** salv-orlando has quit IRC | 13:08 | |
*** spilla has joined #openstack-oslo | 13:30 | |
*** salv-orlando has joined #openstack-oslo | 13:53 | |
*** songjian has joined #openstack-oslo | 13:55 | |
*** songjian has quit IRC | 13:55 | |
*** janzian has joined #openstack-oslo | 13:59 | |
*** yassine has quit IRC | 14:00 | |
*** songjian has joined #openstack-oslo | 14:01 | |
*** yassine has joined #openstack-oslo | 14:02 | |
*** ianychoi_ has joined #openstack-oslo | 14:33 | |
*** ianychoi has quit IRC | 14:36 | |
*** shardy_lunch is now known as shardy | 14:53 | |
*** kevinbenton has quit IRC | 14:58 | |
bnemec | dhellmann: It looks like there are some problems with the config location changes and other projects' unit tests: http://logs.openstack.org/12/557012/1/check/cross-nova-py27/37b2a7c/job-output.txt.gz#_2018-03-27_21_41_10_037635 | 15:02 |
bnemec | From the constraint update: https://review.openstack.org/#/c/557012/ | 15:02 |
*** links has quit IRC | 15:03 | |
bnemec | I'm not sure what the deal with the cinder duplicate opt is. | 15:03 |
*** kevinbenton has joined #openstack-oslo | 15:06 | |
bnemec | Oh, the duplicate opt is because the _set_location member doesn't match. | 15:07 |
bnemec | We probably need to filter that out in __eq__ | 15:07 |
*** pcaruana has quit IRC | 15:09 | |
*** gyankum has joined #openstack-oslo | 15:11 | |
openstackgerrit | Claudiu Belu proposed openstack/oslotest master: mock: Properly patch mock.MagicMock https://review.openstack.org/557368 | 15:20 |
*** songjian has quit IRC | 15:20 | |
dhellmann | bnemec : ack | 15:24 |
dhellmann | bnemec : is there an easy way for me to run those tests locally? | 15:25 |
dhellmann | nm, I have it | 15:25 |
dhellmann | at least I have the tests running | 15:25 |
bnemec | I think you would just need to pip install the new oslo.config into one of the projects' tox venv. | 15:26 |
dhellmann | yeah, I was confused and thinking these were something other than just nova's tests | 15:26 |
*** bobh has joined #openstack-oslo | 15:31 | |
*** bobh has quit IRC | 15:36 | |
*** bobh has joined #openstack-oslo | 15:43 | |
*** bobh has quit IRC | 15:48 | |
*** bobh has joined #openstack-oslo | 15:53 | |
*** bobh has quit IRC | 15:58 | |
*** bobh has joined #openstack-oslo | 16:00 | |
*** bobh has quit IRC | 16:05 | |
*** bobh has joined #openstack-oslo | 16:08 | |
*** lucasagomes is now known as lucas-afk | 16:13 | |
*** msimonin has quit IRC | 16:21 | |
*** msimonin has joined #openstack-oslo | 16:21 | |
*** msimonin has quit IRC | 16:25 | |
*** lpetrut has quit IRC | 16:45 | |
*** kgiusti has left #openstack-oslo | 16:50 | |
*** e0ne has quit IRC | 17:01 | |
*** AlexeyAbashkin has quit IRC | 17:08 | |
*** sambetts is now known as sambetts|afk | 17:13 | |
dhellmann | bnemec : the issue with that one nova test is the way it mocks out os.path.exists | 17:13 |
bnemec | Yeah, I saw mock.patch in the traceback so I figured it had something to do with that. | 17:15 |
dhellmann | I'm willing to bet that's the issue with all of them | 17:15 |
dhellmann | nova/tests/unit/image/test_glance.py mocks open ffs | 17:15 |
* bnemec has written unit tests that mock open :-| | 17:16 | |
dhellmann | you have to be very careful mocking builtins and stdlib stuff like that | 17:16 |
dhellmann | I guess this deserves a ML thread | 17:16 |
dhellmann | maybe some of the nova folks have ideas for what to do here | 17:16 |
bnemec | Yeah | 17:17 |
dhellmann | did any other projects have similar issues with oslo.config master? | 17:18 |
dhellmann | bnemec : http://lists.openstack.org/pipermail/openstack-dev/2018-March/128833.html | 17:27 |
*** yamamoto has quit IRC | 17:29 | |
bnemec | Let's see, cinder was duplicate opt, neutron is also duplicate opt. Those were the only other ones tested on the requirements change. | 17:29 |
*** lpetrut has joined #openstack-oslo | 17:30 | |
dhellmann | ok, I think that's probably a thing we can fix in our code but let me try | 17:33 |
*** shardy has quit IRC | 17:35 | |
*** tesseract has quit IRC | 17:35 | |
dhellmann | bnemec : in cinder there are actually 2 different instances of zfssa_rest_timeout | 17:37 |
bnemec | dhellmann: Yeah, but as long as they match that should be allowed. | 17:38 |
dhellmann | that's debatable | 17:38 |
bnemec | I assume they do since the cinder tests were passing before. | 17:38 |
bnemec | Well, that was the previous behavior of oslo.config. | 17:38 |
dhellmann | the intent behind detecting that they are different is to avoid having 2 copies of the definition in 2 places | 17:38 |
bnemec | I suspect we need to fix this anyway in case an opt gets registered, modified in some way, then registered again at a later time. | 17:40 |
bnemec | I think that would fail because the location member would differ. | 17:40 |
dhellmann | if it's the same code path it should be fine | 17:40 |
dhellmann | but I guess the path of least resistance here is to allow it | 17:40 |
dhellmann | how about a warning? | 17:40 |
bnemec | Yeah, changing that behavior would require another major version bump, I think. | 17:41 |
bnemec | I'm fine with a warning. | 17:41 |
*** yamamoto has joined #openstack-oslo | 17:46 | |
*** lpetrut has quit IRC | 18:02 | |
*** yamamoto has quit IRC | 18:12 | |
*** pblaho has quit IRC | 18:12 | |
*** chhagarw has quit IRC | 18:16 | |
*** lpetrut has joined #openstack-oslo | 18:16 | |
*** e0ne has joined #openstack-oslo | 18:19 | |
*** yamamoto has joined #openstack-oslo | 18:21 | |
*** yamamoto has quit IRC | 18:26 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: ignore location when comparing options for duplicate registration https://review.openstack.org/557467 | 18:29 |
dhellmann | oh, I forgot the warning, hang on | 18:30 |
dhellmann | ah, nevermind, that's just likely to spew lots of warnings to the logs that operators can't do anything about | 18:31 |
dhellmann | bnemec : ^^ | 18:31 |
*** gyankum has quit IRC | 18:36 | |
*** yamamoto has joined #openstack-oslo | 18:36 | |
*** gyankum has joined #openstack-oslo | 18:40 | |
*** yamamoto has quit IRC | 18:41 | |
*** gyankum has quit IRC | 18:48 | |
*** yamamoto has joined #openstack-oslo | 18:52 | |
*** AlexeyAbashkin has joined #openstack-oslo | 18:54 | |
*** lpetrut has quit IRC | 18:54 | |
*** yamamoto has quit IRC | 18:56 | |
*** AlexeyAbashkin has quit IRC | 18:59 | |
*** msimonin has joined #openstack-oslo | 19:00 | |
*** yamamoto has joined #openstack-oslo | 19:17 | |
*** yamamoto has quit IRC | 19:17 | |
*** pblaho has joined #openstack-oslo | 19:25 | |
*** yamamoto has joined #openstack-oslo | 19:28 | |
*** yamamoto has quit IRC | 19:32 | |
*** bobh has quit IRC | 19:37 | |
*** yamamoto has joined #openstack-oslo | 19:43 | |
*** yamamoto has quit IRC | 19:47 | |
*** yamamoto has joined #openstack-oslo | 19:57 | |
*** yamamoto has quit IRC | 19:57 | |
*** spilla has quit IRC | 19:59 | |
*** bobh has joined #openstack-oslo | 20:01 | |
*** ansmith has quit IRC | 20:03 | |
*** eck` is now known as eck`gone | 20:38 | |
*** nicolasbock has joined #openstack-oslo | 20:39 | |
*** e0ne has quit IRC | 20:48 | |
*** cdent has joined #openstack-oslo | 20:50 | |
*** raildo has quit IRC | 20:51 | |
cdent | I'm pretty sure I've found a bug with oslo.config 6.0.0 but before I register a bug I thought I'd sanity check. A script I have which takes a --config-file argument that worked just fine 5.2.0 takes a _very_ long to complete its imports | 20:52 |
cdent | That ^ ring any bells dhellmann ? | 20:53 |
dhellmann | not really | 20:53 |
dhellmann | I'd have to look at what changed between those versions | 20:54 |
dhellmann | oh, it could be the new location stuff | 20:54 |
cdent | seems to be near /usr/local/lib/python3.6/dist-packages/oslo_config/cfg.py | 20:55 |
cdent | sorry, left out the line number: line 814, in _get_caller_detail | 20:55 |
dhellmann | yeah | 20:55 |
dhellmann | so that's the stuff that probes where the option is coming from | 20:55 |
dhellmann | so that we can say "this option is defined in foo.py and set in $file.ini" | 20:55 |
dhellmann | that's the thing jay got when he asked for the ability to tell if the user had set an option :-) | 20:56 |
cdent | ah | 20:56 |
cdent | figures | 20:56 |
dhellmann | is that code in a patch I can download? | 20:56 |
dhellmann | oops, wrong window again | 20:57 |
cdent | have you checked with jay that he actually still want/needs that because last I checked (if it is allocation ratio stuff) that's stalled out | 20:57 |
dhellmann | I have not | 20:57 |
*** yamamoto has joined #openstack-oslo | 20:57 | |
cdent | I'll dig a little closer in that chunk of code and see if I can figure out what's going on a bit more and register a bug. launchpad or storyboard? | 20:58 |
bnemec | Still launchpad at the moment | 21:02 |
cdent | thanks | 21:02 |
*** yamamoto has quit IRC | 21:03 | |
*** vstinner has left #openstack-oslo | 21:04 | |
cdent | dhellmann, bnemec : https://bugs.launchpad.net/oslo.config/+bug/1759689 | 21:12 |
openstack | Launchpad bug 1759689 in oslo.config "In 1.6.0 startup can be extremely slow when checking many config items" [Undecided,New] | 21:12 |
dhellmann | 1.6.0 or 6.0.0? | 21:12 |
dhellmann | either way it sounds like we want to turn off the file location stuff | 21:13 |
cdent | sorry, yeah, will fix it, have too many versions in my head | 21:14 |
cdent | yeah, seems so | 21:15 |
dhellmann | cdent : if you look at oslo_config/cfg.py around line 807 you should see a _get_caller_detail() function. If you short-circuit that function to always return None does it fix the performance? | 21:16 |
cdent | lemme try | 21:16 |
dhellmann | if so I can propose that as a fix quickly | 21:16 |
cdent | yes, it does: it goes from a time of 1m27 to 0m1 | 21:17 |
dhellmann | well | 21:17 |
dhellmann | stand by then | 21:18 |
cdent | :) | 21:18 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: disable stack inspection when setting option values https://review.openstack.org/557513 | 21:19 |
dhellmann | bnemec , cdent ^^ | 21:19 |
dhellmann | we could possibly keep the location for set_defaults() calls because those are less frequent | 21:20 |
dhellmann | but this was quicker to fix the immediate problem | 21:20 |
dhellmann | we could also do something like use an environment variable to turn it on/off | 21:20 |
dhellmann | since the location in code is really only useful for debugging | 21:21 |
cdent | that seems like a reasonable plan | 21:21 |
* cdent enjoys running code without upper constraints | 21:22 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: use environment variable to control file location probing https://review.openstack.org/557516 | 21:27 |
dhellmann | ok, there we go | 21:27 |
dhellmann | probably needs docs | 21:27 |
*** ansmith has joined #openstack-oslo | 21:27 | |
dhellmann | and I think I'm going to quit for the day while I'm ahead | 21:28 |
*** e0ne has joined #openstack-oslo | 21:29 | |
cdent | dhellmann is smarter than cdent | 21:33 |
*** cdent has quit IRC | 21:37 | |
*** edmondsw has quit IRC | 21:43 | |
-openstackstatus- NOTICE: the zuul web dashboard will experience a short downtime as we roll out some changes - no job execution should be affected | 21:52 | |
*** pblaho has quit IRC | 21:53 | |
*** harlowja has joined #openstack-oslo | 21:53 | |
*** e0ne has quit IRC | 21:55 | |
*** yamamoto has joined #openstack-oslo | 21:59 | |
*** yamamoto has quit IRC | 22:04 | |
*** bobh has quit IRC | 22:17 | |
*** rcernin has joined #openstack-oslo | 22:28 | |
*** msimonin has quit IRC | 22:38 | |
*** pblaho has joined #openstack-oslo | 22:48 | |
*** pblaho has quit IRC | 23:00 | |
*** yamamoto has joined #openstack-oslo | 23:00 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: disable stack inspection when setting option values https://review.openstack.org/557513 | 23:04 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: use environment variable to control file location probing https://review.openstack.org/557516 | 23:04 |
*** yamamoto has quit IRC | 23:06 | |
*** bobh has joined #openstack-oslo | 23:16 | |
*** salv-orlando has quit IRC | 23:21 | |
*** salv-orlando has joined #openstack-oslo | 23:22 | |
*** salv-orlando has quit IRC | 23:27 | |
-openstackstatus- NOTICE: Zuul has been restarted to update to the latest code; existing changes have been re-enqueued, you may need to recheck changes uploaded in the past 10 minutes | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!