*** yamamoto has joined #openstack-oslo | 00:02 | |
*** bobh has quit IRC | 00:06 | |
*** yamamoto has quit IRC | 00:08 | |
*** janzian has quit IRC | 00:21 | |
*** salv-orlando has joined #openstack-oslo | 00:23 | |
*** salv-orlando has quit IRC | 00:28 | |
*** gyankum has joined #openstack-oslo | 00:32 | |
*** gyankum has quit IRC | 00:44 | |
*** tovin07_ has joined #openstack-oslo | 00:47 | |
*** yamamoto has joined #openstack-oslo | 01:04 | |
*** msimonin has joined #openstack-oslo | 01:05 | |
*** AlexeyAbashkin has joined #openstack-oslo | 01:08 | |
*** yamamoto has quit IRC | 01:09 | |
*** msimonin has quit IRC | 01:10 | |
*** gyankum has joined #openstack-oslo | 01:12 | |
*** AlexeyAbashkin has quit IRC | 01:13 | |
*** salv-orlando has joined #openstack-oslo | 01:24 | |
*** salv-orlando has quit IRC | 01:29 | |
*** yassine has quit IRC | 01:33 | |
*** yassine has joined #openstack-oslo | 01:35 | |
*** songjian has joined #openstack-oslo | 02:02 | |
*** yamamoto has joined #openstack-oslo | 02:05 | |
*** songjian has quit IRC | 02:06 | |
*** yamamoto has quit IRC | 02:11 | |
*** salv-orlando has joined #openstack-oslo | 02:25 | |
*** salv-orlando has quit IRC | 02:31 | |
*** yamamoto has joined #openstack-oslo | 02:47 | |
*** daidv has quit IRC | 03:09 | |
*** links has joined #openstack-oslo | 03:12 | |
*** harlowja has quit IRC | 03:24 | |
*** daidv has joined #openstack-oslo | 03:24 | |
*** salv-orlando has joined #openstack-oslo | 03:27 | |
*** salv-orlando has quit IRC | 03:31 | |
*** ianychoi__ has joined #openstack-oslo | 03:47 | |
*** nicolasbock has quit IRC | 03:47 | |
*** ianychoi_ has quit IRC | 03:50 | |
*** dave-mccowan has quit IRC | 03:56 | |
*** dave-mccowan has joined #openstack-oslo | 03:58 | |
*** harlowja has joined #openstack-oslo | 03:59 | |
openstackgerrit | Wonil Choi proposed openstack/oslo.messaging master: Revert "rabbit: Don't prefetch when batch_size is set" https://review.openstack.org/557591 | 04:07 |
---|---|---|
*** AlexeyAbashkin has joined #openstack-oslo | 04:09 | |
*** AlexeyAbashkin has quit IRC | 04:14 | |
*** dave-mcc_ has joined #openstack-oslo | 04:15 | |
*** dave-mccowan has quit IRC | 04:16 | |
*** daidv has quit IRC | 04:28 | |
*** daidv has joined #openstack-oslo | 04:28 | |
*** ianychoi__ is now known as ianychoi | 04:29 | |
*** dave-mcc_ has quit IRC | 04:46 | |
*** daidv has quit IRC | 04:50 | |
*** daidv has joined #openstack-oslo | 04:50 | |
*** rcernin_ has joined #openstack-oslo | 04:59 | |
*** rcernin has quit IRC | 05:00 | |
*** salv-orlando has joined #openstack-oslo | 05:08 | |
openstackgerrit | melissaml proposed openstack/mox3 master: fix a typo in documentation https://review.openstack.org/555528 | 05:21 |
openstackgerrit | Merged openstack/mox3 master: add lower-constraints job https://review.openstack.org/555912 | 05:26 |
*** chhagarw has joined #openstack-oslo | 06:02 | |
*** harlowja has quit IRC | 06:06 | |
*** rcernin_ has quit IRC | 06:14 | |
*** rcernin has joined #openstack-oslo | 06:17 | |
openstackgerrit | Merged openstack/oslo.policy master: add lower-constraints job https://review.openstack.org/556068 | 06:23 |
openstackgerrit | Merged openstack/oslo.serialization master: add lower-constraints job https://review.openstack.org/556077 | 06:31 |
openstackgerrit | Merged openstack/oslo.vmware master: add lower-constraints job https://review.openstack.org/556081 | 06:31 |
*** e0ne has joined #openstack-oslo | 06:32 | |
openstackgerrit | Merged openstack/oslo.log master: add lower-constraints job https://review.openstack.org/556065 | 06:37 |
openstackgerrit | Merged openstack/oslo.rootwrap master: add lower-constraints job https://review.openstack.org/556071 | 06:37 |
openstackgerrit | Merged openstack-dev/pbr master: Explicitly read setup.cfg as utf-8 on Python 3 https://review.openstack.org/555366 | 06:37 |
openstackgerrit | Merged openstack/taskflow master: Updated from global requirements https://review.openstack.org/556318 | 06:37 |
openstackgerrit | Merged openstack/oslo.utils master: add lower-constraints job https://review.openstack.org/556079 | 06:38 |
openstackgerrit | Merged openstack/automaton master: add lower-constraints job https://review.openstack.org/555291 | 06:38 |
openstackgerrit | Merged openstack/oslo.versionedobjects master: add lower-constraints job https://review.openstack.org/556080 | 06:38 |
*** d0ugal_ has joined #openstack-oslo | 06:39 | |
*** d0ugal has quit IRC | 06:42 | |
openstackgerrit | Merged openstack/oslo.privsep master: add lower-constraints job https://review.openstack.org/556069 | 06:42 |
openstackgerrit | Merged openstack/oslo.db master: add lower-constraints job https://review.openstack.org/556063 | 06:42 |
openstackgerrit | Merged openstack/oslo.cache master: add lower-constraints job https://review.openstack.org/556060 | 06:42 |
openstackgerrit | Merged openstack/oslo.concurrency master: add lower-constraints job https://review.openstack.org/556061 | 06:42 |
openstackgerrit | Merged openstack/oslo.versionedobjects master: Updated from global requirements https://review.openstack.org/556424 | 06:42 |
openstackgerrit | Merged openstack/oslo.middleware master: add lower-constraints job https://review.openstack.org/556067 | 06:42 |
openstackgerrit | Merged openstack/oslo.messaging master: add lower-constraints job https://review.openstack.org/556066 | 06:45 |
openstackgerrit | Merged openstack/oslo.reports master: add lower-constraints job https://review.openstack.org/556070 | 06:48 |
openstackgerrit | Merged openstack/oslo.i18n master: add lower-constraints job https://review.openstack.org/556064 | 06:50 |
openstackgerrit | Merged openstack/oslo.vmware master: Updated from global requirements https://review.openstack.org/556425 | 06:52 |
*** e0ne has quit IRC | 06:56 | |
*** salv-orlando has quit IRC | 06:58 | |
*** salv-orlando has joined #openstack-oslo | 06:59 | |
openstackgerrit | Merged openstack/oslo.messaging master: Updated from global requirements https://review.openstack.org/556315 | 07:02 |
*** rcernin has quit IRC | 07:03 | |
*** gyan_ has joined #openstack-oslo | 07:03 | |
*** gyankum has quit IRC | 07:04 | |
*** gyan__ has joined #openstack-oslo | 07:05 | |
*** links has quit IRC | 07:05 | |
*** links has joined #openstack-oslo | 07:06 | |
*** gyan_ has quit IRC | 07:09 | |
*** salv-orlando has quit IRC | 07:20 | |
*** salv-orlando has joined #openstack-oslo | 07:20 | |
*** yamamoto has quit IRC | 07:22 | |
*** tesseract has joined #openstack-oslo | 07:22 | |
*** yamamoto has joined #openstack-oslo | 07:23 | |
*** salv-orlando has quit IRC | 07:24 | |
openstackgerrit | Merged openstack/oslo.context master: add lower-constraints job https://review.openstack.org/556062 | 07:27 |
*** yamamoto_ has joined #openstack-oslo | 07:32 | |
*** yamamoto has quit IRC | 07:34 | |
*** daidv has quit IRC | 07:46 | |
*** salv-orlando has joined #openstack-oslo | 07:56 | |
*** AlexeyAbashkin has joined #openstack-oslo | 08:00 | |
*** daidv has joined #openstack-oslo | 08:03 | |
*** AlexeyAbashkin has quit IRC | 08:07 | |
*** AlexeyAbashkin has joined #openstack-oslo | 08:10 | |
openstackgerrit | Merged openstack/debtcollector master: Updated from global requirements https://review.openstack.org/552312 | 08:13 |
*** lucas-afk is now known as lucasagomes | 08:14 | |
*** e0ne has joined #openstack-oslo | 08:15 | |
*** e0ne has quit IRC | 08:16 | |
*** e0ne has joined #openstack-oslo | 08:30 | |
*** rcernin has joined #openstack-oslo | 08:48 | |
*** Alexey_Abashkin has joined #openstack-oslo | 08:52 | |
*** AlexeyAbashkin has quit IRC | 08:54 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 08:54 | |
*** AlexeyAbashkin has quit IRC | 08:55 | |
*** AlexeyAbashkin has joined #openstack-oslo | 08:58 | |
*** lutostag has joined #openstack-oslo | 09:35 | |
lutostag | hey all, is this the right place to ask for a bit of help with using pbr in regular python projects? If not, ignore the next question and I will find a better place for it ;) | 09:36 |
lutostag | I have new versions being tagged with <tag>.dev<commits-since-tag> -- like 0.1.2.dev3 -- can I add a git hash to the end of it, so it will look like 0.1.2.dev3-gab3ab4 ? | 09:37 |
lutostag | (because our ci is stomping on the versions as we have multiple branches and we can't keep them all in our local pypi server) | 09:38 |
lutostag | basically to satisfy #11 from https://docs.openstack.org/pbr/3.1.0/semver.html -- a config option I can set somewhere? | 09:39 |
*** msimonin has joined #openstack-oslo | 10:04 | |
*** tovin07_ has quit IRC | 10:06 | |
*** msimonin has quit IRC | 10:07 | |
*** gyan__ has quit IRC | 10:09 | |
*** raildo has joined #openstack-oslo | 10:15 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/oslo.db master: Improve exponential backoff for wrap_db_retry https://review.openstack.org/527362 | 10:29 |
*** nicolasbock has joined #openstack-oslo | 10:32 | |
*** pbourke has quit IRC | 10:45 | |
*** pbourke has joined #openstack-oslo | 10:45 | |
*** AlexeyAbashkin has quit IRC | 10:53 | |
*** sambetts|afk is now known as sambetts | 10:58 | |
*** yamamoto has joined #openstack-oslo | 11:01 | |
*** yamamoto_ has quit IRC | 11:05 | |
*** lucasagomes is now known as lucas-hungry | 11:07 | |
*** ansmith has quit IRC | 11:07 | |
*** lutostag has quit IRC | 11:09 | |
*** lutostag has joined #openstack-oslo | 11:09 | |
*** pblaho has joined #openstack-oslo | 11:11 | |
*** pblaho has quit IRC | 11:12 | |
*** pblaho has joined #openstack-oslo | 11:13 | |
*** AlexeyAbashkin has joined #openstack-oslo | 11:18 | |
*** edmondsw has joined #openstack-oslo | 11:30 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/oslo.db master: Improve exponential backoff for wrap_db_retry https://review.openstack.org/527362 | 11:36 |
*** links has quit IRC | 11:49 | |
*** links has joined #openstack-oslo | 11:53 | |
*** nicolasbock has quit IRC | 11:54 | |
*** lucas-hungry is now known as lucasagomes | 11:55 | |
*** rcernin has quit IRC | 12:05 | |
*** msimonin has joined #openstack-oslo | 12:07 | |
openstackgerrit | Thomas Bechtold proposed openstack/sphinx-feature-classification master: Make openstack specific requirements optional or remove them https://review.openstack.org/557695 | 12:30 |
*** janzian has joined #openstack-oslo | 12:33 | |
*** abhi89 has joined #openstack-oslo | 12:39 | |
*** kgiusti has joined #openstack-oslo | 12:48 | |
*** pblaho has quit IRC | 12:51 | |
*** lutostag has quit IRC | 12:55 | |
*** ansmith has joined #openstack-oslo | 12:58 | |
*** edmondsw has quit IRC | 12:58 | |
*** edmondsw has joined #openstack-oslo | 12:59 | |
*** msimonin has quit IRC | 13:01 | |
*** edmondsw has quit IRC | 13:03 | |
*** edmondsw has joined #openstack-oslo | 13:05 | |
*** msimonin has joined #openstack-oslo | 13:06 | |
*** msimonin has quit IRC | 13:09 | |
*** msimonin has joined #openstack-oslo | 13:09 | |
kgiusti | msimonin: having issues w/ rendezvous - can't find mic or camera... | 13:10 |
msimonin | kgiusti: weird | 13:12 |
msimonin | kgiusti: we already experienced some trouble this week | 13:12 |
kgiusti | msimonin: can you hear me? I can hear ansmith | 13:12 |
msimonin | nope we can't | 13:12 |
kgiusti | msimonin: darn | 13:13 |
*** salv-orlando has quit IRC | 13:18 | |
*** salv-orlando has joined #openstack-oslo | 13:18 | |
*** bobh has joined #openstack-oslo | 13:19 | |
*** salv-orlando has quit IRC | 13:23 | |
*** abhi89 has quit IRC | 13:26 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: use environment variable to control file location probing https://review.openstack.org/557516 | 13:38 |
*** salv-orlando has joined #openstack-oslo | 13:48 | |
*** msimonin has quit IRC | 14:00 | |
*** dave-mccowan has joined #openstack-oslo | 14:03 | |
*** yassine has quit IRC | 14:04 | |
*** yassine has joined #openstack-oslo | 14:05 | |
*** jlvillal has quit IRC | 14:15 | |
*** links has quit IRC | 14:26 | |
*** msimonin has joined #openstack-oslo | 14:28 | |
*** msimonin has quit IRC | 14:34 | |
*** msimonin has joined #openstack-oslo | 14:39 | |
*** msimonin has quit IRC | 14:43 | |
*** msimonin has joined #openstack-oslo | 14:55 | |
*** jlvillal has joined #openstack-oslo | 15:12 | |
*** spilla has joined #openstack-oslo | 15:14 | |
*** salv-orlando has quit IRC | 15:15 | |
*** salv-orlando has joined #openstack-oslo | 15:16 | |
*** e0ne has quit IRC | 15:18 | |
*** salv-orlando has quit IRC | 15:20 | |
*** msimonin has quit IRC | 15:26 | |
*** links has joined #openstack-oslo | 15:54 | |
*** yamamoto has quit IRC | 16:04 | |
*** janzian has quit IRC | 16:04 | |
*** yamamoto has joined #openstack-oslo | 16:07 | |
openstackgerrit | Stephen Finucane proposed openstack-dev/pbr master: add lower-constraints job https://review.openstack.org/555297 | 16:07 |
*** sambetts is now known as sambetts|afk | 16:09 | |
stephenfin | bnemec: Why can't I find a patch to openstack/releases for pbr 4.0 ? | 16:10 |
stephenfin | bnemec: Wait - nvm. Found it :) https://review.openstack.org/#/c/556891/ | 16:11 |
* stephenfin notes to 'git pull' first next time | 16:11 | |
* bnemec has _never_ done that | 16:12 | |
bnemec | :-) | 16:12 |
stephenfin | well, git fetch; git merge --ff-only | 16:12 |
stephenfin | tomato-tomato | 16:12 |
stephenfin | bnemec: Do we want a 4.0.1 release for that utf-8 bug, or is it important enough? | 16:15 |
bnemec | stephenfin: I was just planning to include it in the next weekly set of releases. | 16:17 |
stephenfin | fine by me | 16:18 |
*** janzian has joined #openstack-oslo | 16:19 | |
*** links has quit IRC | 16:22 | |
*** yamamoto has quit IRC | 16:24 | |
*** yamamoto has joined #openstack-oslo | 16:29 | |
*** lucasagomes is now known as lucas-pto | 16:33 | |
smcginnis | Glance docs jobs are failing since the release of openstackdocstheme 1.20.0. | 16:34 |
smcginnis | http://logs.openstack.org/73/557673/1/check/build-openstack-sphinx-docs/9bf1f80/job-output.txt.gz#_2018-03-29_12_08_50_350938 | 16:34 |
smcginnis | Just posting that in here in case anyone has an idea of why that might be. | 16:34 |
*** yamamoto has quit IRC | 16:34 | |
smcginnis | Nothing stood out to me glancing over the diff since 1.19.0. | 16:34 |
bnemec | I feel like I have seen that "AttributeError: 'module' object has no attribute 'poll'" error before, but I can't remember where. | 16:35 |
smcginnis | It seems vaguely familiar to me too, but can't remember either. | 16:35 |
*** spilla has quit IRC | 16:37 | |
kgiusti | bnemec: something monkey patch related - does eventlet provide a poll method once select is patched? | 16:39 |
kgiusti | bnemec: total guess, but I've been bit by that before... | 16:39 |
bnemec | kgiusti: Could be. I've found some bugs with that error related to gevent monkey patching. | 16:41 |
bnemec | Maybe something is getting imported in a different order now? | 16:41 |
bnemec | kgiusti: Maybe this patch: https://github.com/openstack/openstackdocstheme/commit/433fa33f6c5b1223aca93c82c52edbbfb3ead216 | 16:43 |
bnemec | It removed an import of os and subprocess. | 16:43 |
bnemec | Ah, that's a truncated traceback. | 16:52 |
bnemec | http://paste.openstack.org/show/717925/ is the full one. | 16:52 |
*** AlexeyAbashkin has quit IRC | 16:53 | |
kgiusti | bnemec: WFM with openstackdocstheme 1.19.0 | 16:55 |
*** jaosorior has quit IRC | 16:56 | |
bnemec | Yeah, I bet there's an import order problem as a result of imports being removed from the openstackdocstheme __init__. | 16:59 |
bnemec | I don't really know enough about how this stuff works to guess why though. :-/ | 17:00 |
* bnemec looks at our resident sphinx expert, stephenfin | 17:01 | |
kgiusti | bnemec: heh, me either. | 17:01 |
bnemec | Worth noting that this is happening during the sample config generation, which probably imports parts of glance to get access to opts. | 17:02 |
bnemec | So if I move the glance monkey patching to glance/___init__.py so it always runs first then it works fine. | 17:09 |
bnemec | That doesn't play nicely with apps that run under wsgi though, so we need to find somewhere else to do it. | 17:09 |
openstackgerrit | Seyeong Kim proposed openstack/oslo.versionedobjects master: Fixing UUID coerce function for unicode non uuid form https://review.openstack.org/557778 | 17:13 |
*** salv-orlando has joined #openstack-oslo | 17:18 | |
kgiusti | stephenfin: bnemec: FWIW: git-bisect stares accusingly at https://review.openstack.org/#/c/552069/4 | 17:19 |
kgiusti | bnemec: which looks to be loading from the project | 17:19 |
bnemec | Hmm, so new pbr import in a place it wasn't before. | 17:21 |
*** salv-orlando has quit IRC | 17:22 | |
openstackgerrit | Merged openstack/futurist master: Update links in README https://review.openstack.org/548380 | 17:24 |
openstackgerrit | Merged openstack/oslo.cache master: Clean old output before new doc builds https://review.openstack.org/555064 | 17:25 |
bnemec | So pbr.packaging imports pbr.git, which imports subprocess. | 17:27 |
bnemec | If eventlet is monkey patched after that it probably breaks pbr.git. | 17:27 |
*** yamamoto has joined #openstack-oslo | 17:30 | |
*** yamamoto has quit IRC | 17:37 | |
openstackgerrit | Merged openstack/oslo.versionedobjects master: pypy is not checked at gate https://review.openstack.org/554982 | 17:37 |
*** spilla has joined #openstack-oslo | 17:37 | |
*** msimonin has joined #openstack-oslo | 17:42 | |
*** msimonin has quit IRC | 17:43 | |
*** msimonin has joined #openstack-oslo | 17:43 | |
*** msimonin has quit IRC | 17:44 | |
*** msimonin has joined #openstack-oslo | 17:44 | |
*** msimonin has quit IRC | 17:45 | |
*** msimonin has joined #openstack-oslo | 17:45 | |
*** msimonin has quit IRC | 17:46 | |
*** msimonin has joined #openstack-oslo | 17:46 | |
*** msimonin has quit IRC | 17:46 | |
*** msimonin has joined #openstack-oslo | 17:47 | |
*** msimonin has quit IRC | 17:47 | |
*** harlowja has joined #openstack-oslo | 18:01 | |
*** msimonin has joined #openstack-oslo | 18:02 | |
*** msimonin has quit IRC | 18:03 | |
*** msimonin has joined #openstack-oslo | 18:03 | |
*** msimonin has quit IRC | 18:04 | |
*** msimonin has joined #openstack-oslo | 18:04 | |
*** msimonin has quit IRC | 18:05 | |
*** msimonin has joined #openstack-oslo | 18:05 | |
*** msimonin has quit IRC | 18:06 | |
*** msimonin has joined #openstack-oslo | 18:06 | |
*** msimonin has quit IRC | 18:06 | |
*** msimonin has joined #openstack-oslo | 18:07 | |
*** msimonin has quit IRC | 18:07 | |
*** msimonin has joined #openstack-oslo | 18:07 | |
*** msimonin has quit IRC | 18:08 | |
*** salv-orlando has joined #openstack-oslo | 18:18 | |
*** AlexeyAbashkin has joined #openstack-oslo | 18:18 | |
*** salv-orlando has quit IRC | 18:23 | |
*** AlexeyAbashkin has quit IRC | 18:23 | |
*** tesseract has quit IRC | 18:31 | |
*** yamamoto has joined #openstack-oslo | 18:33 | |
*** yamamoto has quit IRC | 18:38 | |
*** e0ne has joined #openstack-oslo | 18:49 | |
smcginnis | bnemec: pbr.git is part of that stack trace. | 18:57 |
smcginnis | I hadn't seen the activity here, but my investigation of the glance failures was bringing me to the same place. | 18:57 |
smcginnis | However, adding it to glance/__init__ didn't fix it for me like you mentinoed above. | 18:57 |
*** salv-orlando has joined #openstack-oslo | 19:03 | |
*** AlexeyAbashkin has joined #openstack-oslo | 19:08 | |
dhellmann | bnemec : as a bonus, I think that patch to oslo.config that turns off stack inspection will fix the nova unit tests | 19:09 |
dhellmann | smcginnis , stephenfin , bnemec , kgiusti : is the glance doc build failing or the glance unit tests? | 19:09 |
bnemec | dhellmann: I made the same comment on https://review.openstack.org/#/c/557012/ :-) | 19:09 |
bnemec | dhellmann: doc build | 19:09 |
dhellmann | oh, I'm way behind on gerrit email | 19:10 |
smcginnis | Yeah, docs. | 19:10 |
dhellmann | ok, is someone looking at it? | 19:10 |
bnemec | dhellmann: I don't think you're on that review anyway. | 19:10 |
dhellmann | no, it looks like note | 19:10 |
dhellmann | not | 19:10 |
smcginnis | dhellmann: I am looking at the glance failure, but not really getting very far. | 19:10 |
bnemec | dhellmann: kgiusti tracked it down to https://review.openstack.org/#/c/552069/4 | 19:10 |
bnemec | It seems to be an issue with the new pbr import there. | 19:11 |
bnemec | Our current theory is that monkey patching is happening in a bad order and messing up the stdlib subprocess module. | 19:11 |
smcginnis | I moved the pbr import into the method to defer its load until after presumable other patching has taken place, but I get the same failure. | 19:11 |
smcginnis | Though I still got the failure eventlet patching in glance/__init__ | 19:11 |
bnemec | Well, that's my theory shot to hell then. :-) | 19:11 |
*** msimonin has joined #openstack-oslo | 19:11 | |
smcginnis | Could just be me. :) | 19:12 |
dhellmann | ETOOMUCHMAGIC | 19:12 |
smcginnis | Hah | 19:12 |
smcginnis | It's definitely openstackdocstheme 1.20.0 though. | 19:12 |
*** msimonin has quit IRC | 19:12 | |
smcginnis | Downgrading to 1.19.0 passes fine. | 19:12 |
* dhellmann makes another cup of tea while pip does its thing | 19:12 | |
dhellmann | knowing which patch causes it should help. I'll see if I can find a work-around | 19:12 |
*** AlexeyAbashkin has quit IRC | 19:13 | |
dhellmann | interesting, master works fine | 19:15 |
dhellmann | and I'm not able to reproduce it with 1.20 either | 19:16 |
dhellmann | yay, non-determinism | 19:16 |
smcginnis | Glance master with 1.20 upgraded? | 19:16 |
dhellmann | yeah | 19:16 |
smcginnis | Hmm | 19:16 |
dhellmann | oh, wait, hang on | 19:16 |
dhellmann | nope, it did fail | 19:16 |
kgiusti | dhellmann: worked a bit for me too, did a git clean -fdx; tox -edocs in master glance and it started failing again | 19:16 |
dhellmann | openstackdocstheme master worked though | 19:16 |
dhellmann | hmm | 19:17 |
kgiusti | dhellmann: I was git-bisecting openstackdocstheme at the time | 19:17 |
dhellmann | oh, master openstackdocstheme has a patch to catch exceptions trying to get the version number and that's where this is failing | 19:17 |
kgiusti | FWIW: dumping the value of eventlet.patcher.is_monkey_patched('select') occasionally during the test I see it change from False to True mid-way. | 19:18 |
bnemec | https://review.openstack.org/#/c/557807/ is working for me locally, so I pushed a test patch to see what ci says. | 19:19 |
dhellmann | that makes sense; it's importing the glance code to generate API docs | 19:19 |
bnemec | That was my theory. | 19:19 |
dhellmann | man, I hate eventlet | 19:20 |
dhellmann | ooo, what if we have openstackdocstheme set up a fake eventlet module | 19:20 |
bnemec | I hate monkey patching stdlib. Apparently gevent has the same problem. | 19:21 |
dhellmann | ok, we should just release openstackdocstheme master again | 19:21 |
dhellmann | that latest patch from stephenfin seems to fix it | 19:21 |
dhellmann | he catches the error and doesn't force setting the version | 19:22 |
dhellmann | so we might not get a version but at least the build doesn't fail | 19:22 |
dhellmann | and locally I do see a version number | 19:22 |
bnemec | That sounds a lot easier than trying to untangle eventlet. | 19:23 |
bnemec | I can prepare a release request. | 19:23 |
smcginnis | Which patch gets around it? | 19:23 |
dhellmann | smcginnis : HEAD of master in openstackdocstheme | 19:23 |
smcginnis | Agree on just releasing a new one if it takes care of it. | 19:23 |
dhellmann | bnemec : I'll propose a release of the theme and smcginnis can approve it (I'm the doc release liaison) | 19:24 |
smcginnis | ++ | 19:24 |
bnemec | Oh, right, that's not an Oslo project. | 19:24 |
bnemec | I was wondering why I didn't catch that commit in the last set of releases. :-) | 19:24 |
dhellmann | https://review.openstack.org/557811 | 19:25 |
smcginnis | Is that still an openstack-manuals deliverable? | 19:25 |
dhellmann | smcginnis : yeah | 19:25 |
dhellmann | stephenfin must have been borrowing Guido's time machine | 19:25 |
smcginnis | The one downside I see to that is I think it was communicated that projects shouldn't need to set version in doc/source/conf.py anymore because it will automatically get picked up. | 19:28 |
smcginnis | So it looks like with this, glance will not have a version set. | 19:28 |
dhellmann | yeah, that's a drawback | 19:31 |
dhellmann | it at least gives us space to work around that | 19:31 |
*** salv-orlando has quit IRC | 19:34 | |
*** salv-orlando has joined #openstack-oslo | 19:35 | |
*** yamamoto has joined #openstack-oslo | 19:35 | |
smcginnis | True | 19:37 |
smcginnis | bnemec: Hmm, your glance test patch passed the docs job. Maybe we should actually go ahead with that one too. | 19:38 |
bnemec | smcginnis: So the tricky thing with using that as an actual fix is that different glance commands monkey patch differently. | 19:39 |
*** salv-orlando has quit IRC | 19:39 | |
bnemec | Which is o.O | 19:39 |
openstackgerrit | Seyeong Kim proposed openstack/oslo.versionedobjects master: Fixing UUID coerce function for unicode non uuid form https://review.openstack.org/557778 | 19:39 |
smcginnis | I think I saw a couple of them doing this same thing, but not all of them. | 19:39 |
smcginnis | Maybe it would be good making your change so they all end up patches the same way. | 19:40 |
bnemec | Yeah | 19:40 |
bnemec | I _think_ it would be. In my experience partial monkey patching tends to cause issues anyway. | 19:40 |
bnemec | Heck, it could be part of the problem here. | 19:40 |
*** yamamoto has quit IRC | 19:40 | |
smcginnis | Yeah, seems highly suspect at least. | 19:41 |
openstackgerrit | Seyeong Kim proposed openstack/oslo.versionedobjects master: Fixing UUID coerce function for unicode non uuid form https://review.openstack.org/557778 | 19:42 |
*** msimonin has joined #openstack-oslo | 19:42 | |
*** salv-orlando has joined #openstack-oslo | 19:43 | |
bnemec | Oh, https://github.com/openstack/glance/blob/master/glance/cmd/scrubber.py#L47 is really bad too. | 19:44 |
bnemec | There are a lot of imports before they monkey patch. | 19:44 |
bnemec | Mmm: "docs: commands succeeded" | 19:45 |
bnemec | Removing the partial monkey patching also fixed it for me locally. | 19:45 |
*** chhagarw has quit IRC | 19:53 | |
bnemec | Hmm, oslo.util's docs call it oslo.service. | 19:53 |
bnemec | copy pasta ftw! | 19:53 |
bnemec | Okay, proposed https://review.openstack.org/557819 for glance. This is also making the docs work for me locally. | 19:58 |
bnemec | smcginnis: Do we have a bug open for the doc build failures? If we do end up going with ^ it might be good to have a bug for historical reference. | 19:59 |
bnemec | It would not shock me if we were looking at this stuff again in two years saying, "Now why did we do that again?" | 20:00 |
smcginnis | bnemec: Good point. Do you want me to file one? Or do you? | 20:00 |
kgiusti | bnemec: two years? How about 'next week'? | 20:00 |
bnemec | kgiusti: Heh, fair. :-) | 20:01 |
bnemec | smcginnis: I can file one. I just wanted to make sure there wasn't already one out there somewhere. | 20:01 |
smcginnis | Yeah, nothing I have seen. | 20:04 |
*** raildo has quit IRC | 20:05 | |
bnemec | Passed docs and failed pep8. Oh well, needed to add the bug reference anyway. | 20:12 |
bnemec | https://bugs.launchpad.net/glance/+bug/1759935 for the record | 20:15 |
openstack | Launchpad bug 1759935 in Glance "Documentation build broken with openstackdocstheme 1.20.0" [Undecided,New] | 20:15 |
bnemec | Tea time! https://artinsights.com/wp-content/uploads/2014/11/A-Mad-Tea-Party.jpg | 20:23 |
*** gagehugo has left #openstack-oslo | 20:23 | |
*** chhagarw has joined #openstack-oslo | 20:28 | |
openstackgerrit | Andy Smith proposed openstack/oslo.messaging master: Update kafka dsvm jobs https://review.openstack.org/557823 | 20:30 |
*** ansmith has quit IRC | 20:34 | |
*** kgiusti has left #openstack-oslo | 20:35 | |
*** yamamoto has joined #openstack-oslo | 20:37 | |
*** yamamoto has quit IRC | 20:42 | |
*** edmondsw has quit IRC | 20:47 | |
*** edmondsw has joined #openstack-oslo | 20:47 | |
*** edmondsw has quit IRC | 20:52 | |
*** chhagarw has quit IRC | 20:59 | |
openstackgerrit | Ben Nemec proposed openstack/oslo.utils master: Fix project name in user docs https://review.openstack.org/557830 | 21:03 |
*** spilla has quit IRC | 21:08 | |
*** janzian has quit IRC | 21:23 | |
*** spilla has joined #openstack-oslo | 21:26 | |
*** ansmith has joined #openstack-oslo | 21:29 | |
*** yamamoto has joined #openstack-oslo | 21:38 | |
*** yamamoto has quit IRC | 21:44 | |
*** msimonin has quit IRC | 22:07 | |
*** msimonin has joined #openstack-oslo | 22:07 | |
*** msimonin has quit IRC | 22:09 | |
*** msimonin has joined #openstack-oslo | 22:09 | |
*** msimonin has quit IRC | 22:10 | |
*** msimonin has joined #openstack-oslo | 22:10 | |
*** msimonin has quit IRC | 22:10 | |
*** msimonin has joined #openstack-oslo | 22:11 | |
*** bobh has quit IRC | 22:11 | |
*** msimonin has quit IRC | 22:11 | |
*** msimonin has joined #openstack-oslo | 22:12 | |
*** msimonin has quit IRC | 22:12 | |
*** msimonin has joined #openstack-oslo | 22:12 | |
*** msimonin has quit IRC | 22:13 | |
*** msimonin has joined #openstack-oslo | 22:13 | |
*** msimonin has quit IRC | 22:14 | |
*** msimonin has joined #openstack-oslo | 22:14 | |
*** bobh has joined #openstack-oslo | 22:14 | |
*** msimonin has quit IRC | 22:14 | |
*** salv-orlando has quit IRC | 22:15 | |
*** salv-orlando has joined #openstack-oslo | 22:15 | |
*** e0ne has quit IRC | 22:16 | |
*** spilla has quit IRC | 22:17 | |
*** salv-orlando has quit IRC | 22:19 | |
*** edmondsw has joined #openstack-oslo | 22:20 | |
*** bobh has quit IRC | 22:20 | |
*** edmondsw has quit IRC | 22:25 | |
*** yamamoto has joined #openstack-oslo | 22:40 | |
*** yamamoto has quit IRC | 22:45 | |
*** AlexeyAbashkin has joined #openstack-oslo | 23:08 | |
*** AlexeyAbashkin has quit IRC | 23:12 | |
*** jroll has quit IRC | 23:37 | |
*** yamamoto has joined #openstack-oslo | 23:41 | |
*** bobh has joined #openstack-oslo | 23:47 | |
*** yamamoto has quit IRC | 23:47 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!