kafilat | gouthamr: hi o/ | 14:03 |
---|---|---|
kafilat | https://review.opendev.org/c/openstack/openstacksdk/+/798333 | 14:03 |
kafilat | It passed in my environment | 14:03 |
gouthamr | o/ kafilat | 15:27 |
gouthamr | missed your ping here | 15:27 |
kafilat | The patch fails functional tests but it passed in my environment | 15:52 |
gouthamr | kafilat: which one? | 16:16 |
gouthamr | ah my logs were truncated | 16:17 |
gouthamr | https://meetings.opendev.org/irclogs/%23openstack-outreachy/%23openstack-outreachy.2021-09-01.log.html | 16:17 |
kafilat | Yeah | 16:22 |
kafilat | this one https://review.opendev.org/c/openstack/openstacksdk/+/798333 | 16:23 |
gouthamr | thank you, i'll look in a min | 16:28 |
gouthamr | kafilat: commented, you'll need to create a snapshot for snapshot instances to exist | 16:46 |
kafilat | I need to wait for snapshot patch to merge first? | 16:49 |
gouthamr | kafilat: yes | 16:55 |
* gouthamr reviews https://review.opendev.org/c/openstack/openstacksdk/+/797189 | 16:56 | |
gouthamr | kafilat: you can rebase https://review.opendev.org/c/openstack/openstacksdk/+/798333 on https://review.opendev.org/c/openstack/openstacksdk/+/797189 and add the snapshot creation logic | 16:57 |
kafilat | gouthamr: thanks, I'll try that | 17:10 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!