| francie_D | Good afternoon vkmc | 12:05 |
|---|---|---|
| francie_D | Please review when you have a moment: https://review.opendev.org/c/openstack/python-manilaclient/+/815157 | 12:05 |
| francie_D | vkmc ^ | 12:05 |
| vkmc | maaritamm, hey! | 12:55 |
| vkmc | maaritamm, if you have a moment later, I could use some extra eyes to review https://review.opendev.org/c/openstack/python-manilaclient/+/815157 | 12:55 |
| vkmc | maaritamm, is what we chatted the other day, wrt access allow/deny | 12:56 |
| maaritamm | vkmc, o/ | 12:57 |
| maaritamm | vkmc, cool, I'll check it later today :) | 12:58 |
| francie_D | Hello vkmc | 15:32 |
| maaritamm | hey francie_D :) | 15:35 |
| maaritamm | francie_D, I am just testing your patch in my devstack... | 15:36 |
| francie_D | Good afternoon maaritanm | 15:36 |
| francie_D | Ok I wait for your review | 15:36 |
| maaritamm | francie_D, did you test the command yourself as well? | 15:36 |
| francie_D | I am thinking am missing something about the 'share_access_rule' resource | 15:36 |
| francie_D | Yes | 15:37 |
| maaritamm | hmm, yeah so I tried to run the command and I got an error: ERROR: name 'share_access_rule' is not defined | 15:37 |
| francie_D | I got same, but yet to figure out where I needed to define it | 15:37 |
| francie_D | as I included it on the 'find_resource' declaration | 15:38 |
| francie_D | So I wonder what I am missing | 15:38 |
| maaritamm | ok, let's have a look, I am checking ... | 15:38 |
| francie_D | This line: | 15:39 |
| francie_D | https://review.opendev.org/c/openstack/python-manilaclient/+/815157/4/manilaclient/v2/shell.py#249 | 15:39 |
| francie_D | I am guessing that should be the culprit | 15:39 |
| maaritamm | hmm, right that might need to be cs.share_access_rules (not singular) that you need to pass | 15:42 |
| francie_D | checking | 15:45 |
| maaritamm | also in line 1908 you are passing share_access_rule that is not defined | 15:45 |
| maaritamm | you'll want to pass 'access' or rename the variable on line 1903 | 15:45 |
| francie_D | checking.. | 15:48 |
| francie_D | so I have to replace with access on line 1908 then | 15:49 |
| maaritamm | yes that should get us past the first error | 15:50 |
| maaritamm | but now I am getting: ERROR: 'dict' object has no attribute 'id' | 15:50 |
| francie_D | Investigating | 15:51 |
| francie_D | That should be on the print function | 15:51 |
| francie_D | ? | 15:51 |
| maaritamm | I am checking ... | 15:55 |
| maaritamm | ok, so the error is coming from line 85 | 16:04 |
| francie_D | yes | 16:04 |
| maaritamm | because for other resources we are passing resource objects but in this case we have a dictionary | 16:04 |
| francie_D | a workaround could be...? | 16:06 |
| maaritamm | hmm, I'll have to do some thinkos on this... I have to take my dog for a walk now and I'll dig into this after | 16:11 |
| maaritamm | but, if you want dig into meanwhile, my initial thought would be that we could use the get method in here: https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/share_access_rules.py#L49 | 16:12 |
| maaritamm | I think that should give you the resource and then perhaps pass that to the wait method instead | 16:12 |
| maaritamm | you can access that with cs.share_access_rules.get and pass the id from the dict | 16:13 |
| francie_D | Let me think it through without causing breaking changes to other resources | 16:17 |
| francie_D | Thanks | 16:17 |
| maaritamm | sure, np :) | 16:20 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!