| francie | Good morning maaritanm | 07:28 |
|---|---|---|
| maaritamm | Morning francie o/ | 07:29 |
| francie | Thanks for the review | 07:30 |
| francie | I have fixed the access_id on the recent patch | 07:30 |
| francie | But I am still getting an issue here | 07:31 |
| francie | https://review.opendev.org/c/openstack/python-manilaclient/+/815157/7/manilaclient/v2/shell.py#1917 | 07:31 |
| maaritamm | So, I don't think that's where the issue is. It should be where I left the comment, in here: https://review.opendev.org/c/openstack/python-manilaclient/+/815157/7/manilaclient/v2/shell.py#250 | 07:33 |
| francie | Ohh I see.. | 07:33 |
| maaritamm | it should be return apiclient_utils.find_resource(cs.share_access_rules, access_rule) | 07:34 |
| francie | fixed | 07:40 |
| maaritamm | nice, I'll test it now :) | 07:43 |
| maaritamm | looks like there is whitespace error waiting here: https://review.opendev.org/c/openstack/python-manilaclient/+/815157/8/manilaclient/v2/shell.py#255 | 07:44 |
| francie | How do I catch whitespace error, seems `tox -e pep8` does not catch it? | 07:50 |
| francie | locally? | 07:50 |
| maaritamm | hmm, that should catch it... | 07:51 |
| maaritamm | I just ran `tox -e pep8` on your patch and I got: ./manilaclient/v2/shell.py:255:1: W293 blank line contains whitespace | 07:52 |
| maaritamm | Looks like the latest patch is all good :) I'll wait for Zuul to run and add my +2 | 08:01 |
| maaritamm | Normally, we | 08:01 |
| maaritamm | we'd add a test to this change, but we can handle that in a follow up patch I think | 08:01 |
| francie | Great! :) | 08:01 |
| francie | sure | 08:02 |
| francie | Just to remind I am an Outreachy applicant and while the unit test is still ongoing, I hope I can apply today before the final deadline tommorrow? | 08:02 |
| maaritamm | Yes, of course. You can submit your final application with a link to this patch. I think we can merge it today/tomorrow but even if it is not merged that is fine as well. | 08:04 |
| maaritamm | a patch in progress will count as a contribution just fine, things take time in open source :) | 08:05 |
| francie | Great! | 08:14 |
| francie | Thanks | 08:14 |
| gouthamr | gah noone's here right now | 15:42 |
| gouthamr | we have a low-hanging-fruit bug if anyone's looking https://bugs.launchpad.net/manila/+bug/1948717 | 15:42 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!