| mbeas | Hi @gouthamr @carloss I made some changes here https://review.opendev.org/c/openstack/python-manilaclient/+/964568 If you could please review it would be helpful for me. Also, do I need to also add some new tests here? I haven't added yet. This time I worked without AI assistance, but the changes were easier than the other bug I worked on. | 08:34 |
|---|---|---|
| mbeas | Hi @gouthamr @carloss I added the tests here: https://review.opendev.org/c/openstack/python-manilaclient/+/964568. I would like your review when possible! | 10:16 |
| denver_ba | Hi @gouthamr and @carloss I have implemented the fixes you proposed in the review and I have my patch up for review again https://review.opendev.org/c/openstack/python-manilaclient/+/964350 thanks | 15:08 |
| gouthamr | mbeas denver_ba: ack | 15:40 |
| premlata | Hi @gouthamr, @carloss, did made the change according to the review comments, can you please review again? https://review.opendev.org/c/openstack/python-manilaclient/+/964573 Thank you very much! | 15:47 |
| *** AB is now known as Guest29739 | 16:13 | |
| *** AB is now known as Guest29746 | 18:20 | |
| *** AB is now known as Guest29750 | 20:23 | |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!