| *** AB is now known as Guest29808 | 13:33 | |
| mbeas | Hi @gouthamr @carloss I would like to work on another bug. I was thinking about https://bugs.launchpad.net/python-manilaclient/+bug/1898313 or https://bugs.launchpad.net/manila/+bug/1959329. Is anyone else currently working on these? If not, which one do you recommend to start with? | 13:44 |
|---|---|---|
| premlata | Hi @carloss, can you please check this one - https://review.opendev.org/c/openstack/python-manilaclient/+/964573? I have received approval from Goutham and need one more approval or review, thank you very much! | 14:49 |
| carloss | heyy premlata I looked at the change and I agree with the feedback from Goutham. Could you please look at the comments he left and update the change? | 17:00 |
| carloss | mbeas hey o/ I'm checking on those bugs | 17:00 |
| carloss | mbeas: we have a fix up for the former bug you mentioned https://review.opendev.org/c/openstack/python-manilaclient/+/780604 - would be nice if you can fix the merge conflicts though :) | 17:01 |
| carloss | it's also a great way to contribute | 17:01 |
| carloss | premlata: https://review.opendev.org/c/openstack/python-manilaclient/+/913216 we had another fix proposed for the same issue - both follow similar lines | 17:05 |
| carloss | we can abandon the other one I mentioned after yours get in | 17:05 |
| premlata | Hi @carloss, I am a little confused. Goutham approved the PR after the second patch. Are there any changes I still need to make? Could you guide me here, please? | 18:29 |
| denver_ba | Hi @Gouthamr and @Carlos, I have a patch that's not yet reviewed https://review.opendev.org/c/openstack/python-manilaclient/+/964719, also the previous amended patch is still up for review https://review.opendev.org/c/openstack/python-manilaclient/+/964350, thank you. | 18:58 |
| *** AB is now known as Guest29835 | 19:46 | |
| carloss | premlata: hey, so gouthamr added a +1 vote at the moment and dropped more comments for you in the commit message: https://review.opendev.org/c/openstack/python-manilaclient/+/964573/comment/7c525a2d_831ee072/ | 20:04 |
| carloss | for merging the change, we need to pursue two reviewers' +2 votes | 20:04 |
| premlata | Ohh, sure, resolving them. | 20:04 |
| premlata | Hi @carloss, updated the commit message. Can you please take a look? | 20:35 |
| premlata | Thank you very much! | 20:35 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!