| mbeas_ | Hi @gouthamr @carloss I worked on this code https://review.opendev.org/c/openstack/python-manilaclient/+/780604. I firstly tried to resolve the merge conflict and later I focused on the code. I tested both manually (in cli) and went over a couple of times in debug mode to try to correct the problematic parts. I corrected the test of the snapshot-access-allow method and added a new test for the snapshot-access-deny one. | 09:51 |
|---|---|---|
| mbeas | Here are some tries after the changes: https://paste.opendev.org/show/829441/ I would like your review so that I can try to correct the code or maybe try to work on sth else. | 10:07 |
| carloss | mbeas: good stuff, thanks for working on it | 13:08 |
| mbeas_ | Thank you. @gouthamr @carloss I have a question regarding the outreachy procedures: may we apply to the manila dashboard project although our code is not merged yet? | 15:14 |
| gouthamr | mbeas: yes; your code doesn’t need to merge to apply | 15:25 |
| premlata | Hi @carloss and @gouthamr, could you please review my PR and leave a comment? https://review.opendev.org/c/openstack/python-manilaclient/+/964573/comment/7c525a2d_831ee072/ Thank you very much | 16:12 |
| premlata | I have updated the commit message* | 16:12 |
| denver_ba | Hi @Carloss and @Gouthamr, I have updated the commit message and resolved the issue https://review.opendev.org/c/openstack/python-manilaclient/+/964719 | 16:37 |
| denver_ba | and @gouthamr, when you replied with ack: to my previous patch does it mean its okay or??https://review.opendev.org/c/openstack/python-manilaclient/+/964350 | 16:40 |
| gouthamr | premlata: hey, you can resolve those pending comments: https://youtu.be/zwQChupbU-c | 17:02 |
| premlata | sure, checking | 17:05 |
| gouthamr | denver_ba: ^ same comment to you.. please resolve code review comments | 17:05 |
| denver_ba | okay | 17:09 |
| denver_ba | Hi @carloss and @Gouthamr, I am having issues with Zuul review failure. replying with recheck has not triggered zuul tests. the issue is node failure and I wanted to recheck first and if it fails look at other options | 20:01 |
| gouthamr | hey denver_ba; looks like a bug in the CI.. i'd avoid re-checking.. i've asked on the #opendev if there's a timeline for the fix.. please ignore this for now.. we'll recheck once the issue is fixed | 20:26 |
| denver_ba | noted, thanks, | 20:27 |
| premlata | Hi @gouthamr, resolved all the comments and marked them as resolved. Can you guide me with the next steps? Thank you very much. | 20:36 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!