| mbeas | Hi @gouthamr @carloss I would like to work on another bug. I was taking a look at this one https://bugs.launchpad.net/python-manilaclient/+bug/2065773 but there is a change abandoned message in one of the comments. May we work on this or should I look up for sth else? Can you recommend sth to work on? | 11:50 |
|---|---|---|
| mbeas | I am also taking a look at this bug: https://bugs.launchpad.net/python-manilaclient/+bug/1912704. It seems like there is a long time that none has worked in it. | 11:58 |
| mbeas | I see that this bug still persists with the old command of manila, but with the new one of openstack it is not a problem. https://paste.opendev.org/show/bnXVJtru5Lt6LAl4Maug/ Should we still work on this? (https://bugs.launchpad.net/python-manilaclient/+bug/1912704) | 12:05 |
| carloss | mbeas: I'd say the share network one seems like a good one | 13:25 |
| carloss | to pick up | 13:25 |
| carloss | maybe there's something that can be reused | 13:26 |
| premlata | Hi @carloss, do I need to make any changes for https://review.opendev.org/c/openstack/python-manilaclient/+/964573, I marked the comments as done. | 13:35 |
| carloss | premlata: you're good | 13:57 |
| premlata | Thank you! For this ticket to merge, I need to resolve the merge conflict. | 13:58 |
| premlata | Sorry, above was a question. If I push commits, will it remove the approvals? | 13:59 |
| carloss | so, there's no merge conflict | 13:59 |
| carloss | I just triggered the merging of the change | 13:59 |
| carloss | and yes, if you uploaded a new patch set, you | 14:00 |
| carloss | you'd lose the votes* | 14:00 |
| premlata | Oh, got it, thanks! Can you please let me know which next ticket I can pick? | 14:00 |
| carloss | premlata: is there any other --wait ticket available? | 14:01 |
| carloss | might be good for the muscle memory you built | 14:01 |
| premlata | Thanks, I found these two - https://bugs.launchpad.net/python-manilaclient/+bugs?field.tag=add-wait-to-async-commands but they are already in progress it seems | 14:03 |
| carloss | share server unmanage is almost being merged | 14:04 |
| carloss | the other one has a change proposed: https://review.opendev.org/c/openstack/python-manilaclient/+/780604 | 14:05 |
| carloss | so maybe we should look for another issue | 14:05 |
| * carloss is doing some launchpad work | 14:12 | |
| carloss | and checking for issues | 14:12 |
| carloss | premlata: https://review.opendev.org/c/openstack/manila/+/807780 and https://review.opendev.org/c/openstack/python-manilaclient/+/807781 have been proposed for a while, so they need rebasing and also some comments to be fixed. That's a bigger change though | 14:39 |
| carloss | if you'd like to take that, I'd recommend first looking at the bugs and understand what we are attempting to fix and then start with the rebasing and fixing comments | 14:40 |
| rose_kimondo_ | HI carloss, gouthamr, Seems like the job that had an issue is still broken. Here is the change that is failing the tests but passing on my local. Would appreciate a review: https://review.opendev.org/c/openstack/manila/+/964695. Also, I made the change that you requested for the deferred deletion docs here: https://review.opendev.org/c/openstack/manila/+/965141 | 15:44 |
| carloss | rose_kimondo_: ack, thanks... We'll take a look at the testing job | 16:39 |
| carloss | and also the other change | 16:39 |
| rose_kimondo_ | Thank you carloss | 16:41 |
| premlata | Sure, Carloss, I am looking at the issues. | 16:58 |
| denver_ba | Hi @Gouthamr and @Carloss, I have attempted to apply a fix to the "share network subnet create" command as well, to close the bug. https://review.opendev.org/c/openstack/python-manilaclient/+/964350 , thanks | 23:49 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!