*** nicolasbock has quit IRC | 00:08 | |
openstackgerrit | Merged openstack/nova master: Update RequestSpec.flavor on resize_revert https://review.openstack.org/588689 | 00:35 |
---|---|---|
openstackgerrit | Brin Zhang proposed openstack/nova master: Resource retrieving: add changes-before filter https://review.openstack.org/599276 | 00:40 |
*** cdent has joined #openstack-placement | 01:47 | |
*** rubasov has joined #openstack-placement | 01:57 | |
*** tssurya has joined #openstack-placement | 02:04 | |
*** e0ne has joined #openstack-placement | 02:08 | |
*** cdent has quit IRC | 02:11 | |
*** tssurya has quit IRC | 02:12 | |
*** tssurya has joined #openstack-placement | 02:14 | |
*** rubasov has quit IRC | 02:16 | |
openstackgerrit | Chen proposed openstack/nova master: Fix evacuate logging https://review.openstack.org/593055 | 02:31 |
openstackgerrit | Chen proposed openstack/nova master: Fix evacuate logging https://review.openstack.org/593055 | 02:34 |
*** e0ne has quit IRC | 02:36 | |
*** tssurya has quit IRC | 02:53 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fix mock.patch usage in unit tests https://review.openstack.org/602198 | 02:54 |
*** e0ne has joined #openstack-placement | 02:56 | |
*** e0ne_ has joined #openstack-placement | 03:00 | |
*** e0ne has quit IRC | 03:03 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P)(WIP): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 03:11 |
openstackgerrit | fupingxie proposed openstack/nova master: Delete allocations for instances that is not in this node https://review.openstack.org/602219 | 03:17 |
*** nicolasbock has joined #openstack-placement | 04:23 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Resource retrieving: add changes-before filter https://review.openstack.org/599276 | 04:32 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P)(WIP): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 05:02 |
*** e0ne_ has quit IRC | 05:14 | |
*** nicolasbock has quit IRC | 05:27 | |
openstackgerrit | fupingxie proposed openstack/nova master: Delete allocations for instances that is not in this node https://review.openstack.org/602219 | 05:47 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P)(WIP): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 06:14 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/601047 | 07:01 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 07:17 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 07:19 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P)(WIP): support compute node resource provider update https://review.openstack.org/521041 | 07:33 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 07:41 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 07:42 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P)(WIP): support compute node resource provider update https://review.openstack.org/521041 | 07:42 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): support compute node resource provider update https://review.openstack.org/521041 | 07:49 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 07:50 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): support compute node resource provider update https://review.openstack.org/521041 | 07:51 |
*** s10 has joined #openstack-placement | 08:31 | |
*** nicolasbock has joined #openstack-placement | 11:40 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova-specs master: Support initial allocation ratios https://review.openstack.org/552105 | 11:50 |
*** tetsuro has joined #openstack-placement | 12:28 | |
*** tetsuro has quit IRC | 12:29 | |
*** tetsuro has joined #openstack-placement | 12:29 | |
*** belmoreira has quit IRC | 12:33 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Resource retrieving: add changes-before filter https://review.openstack.org/599276 | 12:36 |
*** belmoreira has joined #openstack-placement | 12:51 | |
*** jaypipes has joined #openstack-placement | 13:01 | |
*** e0ne has joined #openstack-placement | 13:05 | |
openstackgerrit | Hamdy Khader proposed openstack/nova master: Set defult value of num_nvme_discover_tries=5 https://review.openstack.org/602351 | 13:15 |
*** jaypipes has quit IRC | 13:19 | |
openstackgerrit | Claudiu Belu proposed openstack/nova master: conductor: add live_resize task https://review.openstack.org/248579 | 13:34 |
openstackgerrit | Claudiu Belu proposed openstack/nova master: API: Adds instance live-resize https://review.openstack.org/184584 | 13:35 |
*** rubasov has joined #openstack-placement | 13:35 | |
*** tetsuro has quit IRC | 13:48 | |
*** tetsuro has joined #openstack-placement | 13:59 | |
*** tetsuro_ has joined #openstack-placement | 13:59 | |
openstackgerrit | Claudiu Belu proposed openstack/nova master: WIP: replace spec with autospec https://review.openstack.org/557299 | 14:01 |
*** belmoreira has quit IRC | 14:02 | |
*** tetsuro has quit IRC | 14:04 | |
*** e0ne has quit IRC | 14:07 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 14:40 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 14:40 |
*** mriedem has joined #openstack-placement | 14:41 | |
*** belmoreira has joined #openstack-placement | 14:43 | |
*** tetsuro_ has quit IRC | 14:48 | |
*** rubasov has quit IRC | 14:50 | |
*** tetsuro has joined #openstack-placement | 14:52 | |
*** tetsuro has quit IRC | 14:52 | |
*** tetsuro_ has joined #openstack-placement | 14:53 | |
*** tetsuro has joined #openstack-placement | 14:53 | |
*** e0ne has joined #openstack-placement | 14:53 | |
openstackgerrit | Claudiu Belu proposed openstack/nova master: conductor: add live_resize task https://review.openstack.org/248579 | 14:54 |
openstackgerrit | Claudiu Belu proposed openstack/nova master: API: Adds instance live-resize https://review.openstack.org/184584 | 14:54 |
*** efried has joined #openstack-placement | 14:57 | |
*** tetsuro_ has quit IRC | 14:57 | |
*** rubasov has joined #openstack-placement | 14:57 | |
*** lei-zh has joined #openstack-placement | 15:08 | |
*** takashin has joined #openstack-placement | 15:10 | |
*** tssurya has joined #openstack-placement | 15:10 | |
*** e0ne has quit IRC | 15:11 | |
*** cdent has joined #openstack-placement | 15:11 | |
*** e0ne has joined #openstack-placement | 15:13 | |
*** cdent has quit IRC | 15:14 | |
*** cdent has joined #openstack-placement | 15:15 | |
*** nicolasbock has quit IRC | 15:15 | |
*** rubasov has quit IRC | 15:20 | |
*** rubasov has joined #openstack-placement | 15:21 | |
*** e0ne_ has joined #openstack-placement | 15:23 | |
*** e0ne has quit IRC | 15:23 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | 15:31 |
openstackgerrit | Eric Fried proposed openstack/os-traits master: Add OWNERSHIP_$SERVICE traits https://review.openstack.org/602160 | 15:43 |
*** belmoreira has quit IRC | 15:46 | |
*** belmoreira has joined #openstack-placement | 15:49 | |
*** belmoreira has quit IRC | 15:53 | |
*** rubasov_ has joined #openstack-placement | 15:54 | |
*** rubasov has quit IRC | 15:54 | |
*** nicolasbock has joined #openstack-placement | 16:02 | |
openstackgerrit | Merged openstack/placement master: config: Add oslo-config-generator config https://review.openstack.org/601838 | 16:08 |
openstackgerrit | Eric Fried proposed openstack/os-traits master: Add OWNERSHIP_$SERVICE traits https://review.openstack.org/602160 | 16:11 |
*** e0ne_ has quit IRC | 16:11 | |
openstackgerrit | Chris Dent proposed openstack/placement master: Remove unused conf opts https://review.openstack.org/602164 | 16:24 |
cdent | efried: ^ fixes the extra conf you notice | 16:24 |
cdent | d | 16:24 |
efried | cdent: ack. | 16:24 |
efried | cdent: In case you were getting ambitious, I'm making the doc config ref build. | 16:25 |
*** rubasov has joined #openstack-placement | 16:25 | |
cdent | my ambition is selective, what are you suggesting? | 16:25 |
*** e0ne has joined #openstack-placement | 16:25 | |
efried | cdent: I'm just saying, don't, because I am. | 16:25 |
efried | coming shortly. | 16:25 |
efried | +2 on the conf cleanup | 16:25 |
cdent | oh cool, good | 16:25 |
*** rubasov_ has quit IRC | 16:27 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: more tests for delete allocation cases https://review.openstack.org/591811 | 16:29 |
openstackgerrit | Eric Fried proposed openstack/placement master: Make config docs build https://review.openstack.org/602391 | 16:30 |
*** tetsuro has quit IRC | 16:31 | |
efried | cdent: This is necessarily on top of lyarwood's patch (because it uses the sample config) but not intertwined with the conf cleanup stuff, so the built doc currently still contains all the redundant stuffs. | 16:31 |
efried | (I refer to the above) | 16:31 |
*** e0ne has quit IRC | 16:31 | |
cdent | efried: I'd say at this point that's "just fine" | 16:32 |
cdent | it'll come out in the wash in a few hours | 16:32 |
cdent | we're not yet to the stage where we need to be super concerned about our 100s of thousands of users | 16:32 |
cdent | soon | 16:32 |
efried | yuh, shouldn't have conflicts | 16:32 |
*** tetsuro has joined #openstack-placement | 16:34 | |
*** s10 has quit IRC | 16:45 | |
*** rubasov has quit IRC | 16:50 | |
cdent | oh joy, placement is in stackalytics already | 16:50 |
openstackgerrit | Merged openstack/nova master: Fix mock.patch usage in unit tests https://review.openstack.org/602198 | 16:50 |
efried | cdent: Brazilian tonight? | 16:52 |
*** rubasov has joined #openstack-placement | 16:56 | |
openstackgerrit | Eric Fried proposed openstack/placement master: Make config docs build https://review.openstack.org/602391 | 16:57 |
openstackgerrit | Eric Fried proposed openstack/placement master: s/placement-config-generator/config-generator/ https://review.openstack.org/602395 | 16:57 |
*** e0ne has joined #openstack-placement | 17:00 | |
cdent | gibi: can you kick this stack in please: https://review.openstack.org/#/c/601318/ | 17:08 |
*** lei-zh has quit IRC | 17:10 | |
*** lei-zh has joined #openstack-placement | 17:11 | |
openstackgerrit | Eric Fried proposed openstack/placement master: Make config docs build https://review.openstack.org/602391 | 17:16 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Update RequestSpec.flavor on resize_revert https://review.openstack.org/602403 | 17:17 |
gibi | cdent: kicked | 17:18 |
cdent | thanks | 17:18 |
edleafe | cdent: efried: I've abandoned https://review.openstack.org/#/c/600857/ and https://review.openstack.org/#/c/601651/ in favor of Eric's patch, since his was posted a day earlier | 17:19 |
*** cdent has quit IRC | 17:21 | |
efried | edleafe: ack, sorry if I missed coordination somehow in there. | 17:21 |
openstackgerrit | Merged openstack/placement master: Update README to warn of status https://review.openstack.org/601318 | 17:24 |
*** rubasov has quit IRC | 17:27 | |
*** rubasov has joined #openstack-placement | 17:27 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Noop CantStartEngineError in targets_cell if API DB not configured https://review.openstack.org/581912 | 17:31 |
edleafe | efried: heh, no worries | 17:38 |
*** cdent has joined #openstack-placement | 17:39 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: cover migration cases with functional tests https://review.openstack.org/602408 | 17:39 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Update RequestSpec.flavor on resize_revert https://review.openstack.org/602409 | 17:39 |
*** e0ne has quit IRC | 17:48 | |
*** e0ne has joined #openstack-placement | 17:49 | |
openstackgerrit | Chris Dent proposed openstack/placement master: Remove unused code and opts in conf/paths.py https://review.openstack.org/601071 | 17:53 |
openstackgerrit | Chris Dent proposed openstack/placement master: Rationalize and clarify database configuration https://review.openstack.org/601072 | 17:53 |
openstackgerrit | Chris Dent proposed openstack/placement master: de-novify wsgi application to expect placement config https://review.openstack.org/600157 | 17:53 |
openstackgerrit | Chris Dent proposed openstack/placement master: WIP: add a table create CLI https://review.openstack.org/600161 | 17:53 |
openstackgerrit | Merged openstack/placement master: Set the name of the package to openstack-placement https://review.openstack.org/602187 | 17:54 |
openstackgerrit | Merged openstack/nova master: hyperv: Cleans up live migration Planned VM https://review.openstack.org/478943 | 17:56 |
*** rubasov has quit IRC | 17:59 | |
*** rubasov has joined #openstack-placement | 17:59 | |
openstackgerrit | Eric Fried proposed openstack/os-traits master: Add OWNERSHIP_$SERVICE traits https://review.openstack.org/602160 | 18:04 |
openstackgerrit | Chris Dent proposed openstack/placement master: de-novify wsgi application to expect placement config https://review.openstack.org/600157 | 18:18 |
openstackgerrit | Chris Dent proposed openstack/placement master: WIP: add a table create CLI https://review.openstack.org/600161 | 18:18 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add post-test hook for testing evacuate https://review.openstack.org/602174 | 18:18 |
*** rubasov has quit IRC | 18:23 | |
*** tssurya has quit IRC | 18:30 | |
*** e0ne has quit IRC | 18:31 | |
cdent | efried: yes https://review.openstack.org/#/c/600501/ is gtg | 18:35 |
efried | cdent: +2 | 18:36 |
cdent | word | 18:36 |
*** efried has quit IRC | 18:38 | |
*** cdent has quit IRC | 18:39 | |
*** tetsuro has quit IRC | 18:39 | |
*** mriedem has quit IRC | 18:39 | |
*** lei-zh has quit IRC | 18:41 | |
*** takashin has quit IRC | 18:42 | |
*** nicolasbock has quit IRC | 18:51 | |
*** rubasov has joined #openstack-placement | 18:57 | |
*** cdent has joined #openstack-placement | 19:11 | |
*** e0ne has joined #openstack-placement | 19:23 | |
*** rubasov has quit IRC | 19:26 | |
*** rubasov has joined #openstack-placement | 19:26 | |
cdent | edleafe: see my comment on https://review.openstack.org/#/c/600506/ | 19:46 |
cdent | probalby not worth changing now since we are going to collapse | 19:46 |
cdent | but wanted to point it out | 19:46 |
*** cdent has quit IRC | 19:55 | |
*** tetsuro has joined #openstack-placement | 19:55 | |
*** mriedem has joined #openstack-placement | 19:55 | |
*** rubasov has quit IRC | 19:58 | |
*** tetsuro has quit IRC | 19:58 | |
*** rubasov has joined #openstack-placement | 19:58 | |
openstackgerrit | sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432 | 20:03 |
*** cdent has joined #openstack-placement | 20:05 | |
*** rubasov has quit IRC | 20:07 | |
*** takashin has joined #openstack-placement | 20:08 | |
*** tetsuro has joined #openstack-placement | 20:09 | |
*** tssurya has joined #openstack-placement | 20:09 | |
*** efried has joined #openstack-placement | 20:09 | |
*** nicolasbock has joined #openstack-placement | 20:15 | |
edleafe | cdent: What other sorts of aggregates will there be in placement? | 20:20 |
cdent | there aren't but we don't want to rewrite code that refeferences the table name, so we don't want to change the table name, so changing the file name is confusing | 20:21 |
cdent | but since we are collapsing the migrations it doesn't really matter | 20:21 |
cdent | and for migrations from nova-api db -> placement db we don't want to make a special case for table names | 20:21 |
*** rubasov has joined #openstack-placement | 20:36 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix docs and add functional test for AggregateMultiTenancyIsolation https://review.openstack.org/601835 | 20:47 |
*** e0ne has quit IRC | 20:49 | |
*** e0ne has joined #openstack-placement | 20:50 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add post-test hook for testing evacuate https://review.openstack.org/602174 | 20:53 |
*** e0ne has quit IRC | 20:59 | |
*** rubasov_ has joined #openstack-placement | 21:02 | |
*** rubasov has quit IRC | 21:04 | |
*** e0ne has joined #openstack-placement | 21:07 | |
*** e0ne has quit IRC | 21:12 | |
*** rubasov_ has quit IRC | 21:13 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: [Stable Only] Remove soft-deleted instances from quota_usages https://review.openstack.org/602459 | 21:15 |
cdent | efried or gibi : this ought to be good to go: https://review.openstack.org/#/c/600497/ | 21:20 |
*** e0ne has joined #openstack-placement | 21:20 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/ocata: [Stable Only] Remove soft-deleted instances from quota_usages https://review.openstack.org/570653 | 21:27 |
*** s10 has joined #openstack-placement | 21:27 | |
efried | mriedem: Do you want me to continue pursuing https://review.openstack.org/#/c/600858/ as suggested by jay and/or tetsuro? | 21:42 |
*** rubasov has joined #openstack-placement | 21:44 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Re-proposes multiple vGPU types in libvirt https://review.openstack.org/602474 | 21:53 |
openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Re-proposes multiple vGPU types in libvirt https://review.openstack.org/602474 | 21:55 |
openstackgerrit | Merged openstack/placement master: Remove multiple database scaffolding https://review.openstack.org/600497 | 21:57 |
lyarwood | dansmith: https://review.openstack.org/#/c/591735/ - was this waiting on any additional testing? | 21:59 |
dansmith | lyarwood: I don't think so... mriedem ? | 22:00 |
lyarwood | dansmith: kk, it LGTM I just wanted to be sure before +W'ing this in | 22:01 |
mriedem | efried: don't care - just abandon | 22:01 |
efried | mriedem: Too late | 22:02 |
openstackgerrit | Eric Fried proposed openstack/placement master: Name arguments to _get_provider_ids_matching https://review.openstack.org/600858 | 22:02 |
mriedem | lyarwood: dansmith: if i +2ed it without comments then i'm pretty sure my past self was ok with this, which means my present self is still ok with it | 22:02 |
lyarwood | wunderbar | 22:03 |
openstackgerrit | Ed Leafe proposed openstack/placement master: Update the HACKING.rst file https://review.openstack.org/602475 | 22:04 |
edleafe | cdent: efried: per discussions, ^^ is a partial update to that document | 22:05 |
lyarwood | annnnnnnnnd I just noticed which channel I'm in, sorry about that. | 22:05 |
openstackgerrit | Merged openstack/nova stable/rocky: Add functional test for affinity with multiple cells https://review.openstack.org/599731 | 22:05 |
openstackgerrit | Chris Dent proposed openstack/placement master: Remove unused code and opts in conf/paths.py https://review.openstack.org/601071 | 22:09 |
openstackgerrit | Chris Dent proposed openstack/placement master: Rationalize and clarify database configuration https://review.openstack.org/601072 | 22:09 |
openstackgerrit | Chris Dent proposed openstack/placement master: de-novify wsgi application to expect placement config https://review.openstack.org/600157 | 22:09 |
openstackgerrit | Chris Dent proposed openstack/placement master: WIP: add a table create CLI https://review.openstack.org/600161 | 22:09 |
openstackgerrit | sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432 | 22:09 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Refix disk size during live migration with disk over-commit https://review.openstack.org/602477 | 22:15 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Refix disk size during live migration with disk over-commit https://review.openstack.org/602478 | 22:15 |
efried | edleafe, cdent: How hard is it at this point to bring additional nova files into the placement repo (preserving history)? | 22:20 |
efried | (cause I know how I would do it if history didn't matter :) | 22:20 |
cdent | efried: not sure, what are you after? | 22:20 |
efried | cdent: hacking.py | 22:20 |
cdent | yeah don't bring that | 22:20 |
cdent | see my comments on that patch too | 22:20 |
efried | ... | 22:21 |
cdent | it's _very_ nova specific. If we need such things we should start from scratch | 22:21 |
cdent | And that's a big "If" | 22:21 |
edleafe | efried: it would be really really really really hard, if not impossible | 22:21 |
edleafe | cdent: agreed on the "if" | 22:22 |
efried | Okay, then I stand by my -1 that the WORK IN PROGRESS note ought to be further up. Because none of that stuff is true, including/especially the stuff you modified via that patch. | 22:22 |
cdent | as I said in my first patch of comments just now: I think that entire section can probably be dropped | 22:24 |
edleafe | Yeah, what if we just keep the WIP note and use the file as a placeholder for now? | 22:24 |
efried | wfm | 22:24 |
*** sean-k-mooney has joined #openstack-placement | 22:24 | |
efried | given that we'd be bringing the checks in manually/individually, we could add the notes the same way and at the same time. | 22:25 |
edleafe | efried: yeah, like let it grow organically, man | 22:25 |
cdent | man, man | 22:27 |
*** e0ne has quit IRC | 22:33 | |
openstackgerrit | Jay Pipes proposed openstack/nova master: remove virt driver requires_allocation_refresh https://review.openstack.org/602481 | 22:34 |
openstackgerrit | Chris Dent proposed openstack/placement master: WIP: Add placeload to integration test https://review.openstack.org/602484 | 22:40 |
*** e0ne has joined #openstack-placement | 22:41 | |
openstackgerrit | Ed Leafe proposed openstack/placement master: Update the HACKING.rst file https://review.openstack.org/602475 | 22:45 |
edleafe | cdent: efried: ^^ Is this better? | 22:45 |
*** e0ne has quit IRC | 22:46 | |
openstackgerrit | Chris Dent proposed openstack/placement master: Set upper bound on max-complexity in pep8 https://review.openstack.org/601473 | 22:46 |
efried | cdent: Prioritizing/purging remaining placement items in etherpad fyi | 22:46 |
cdent | efried: aye aye, also fixed your nit in ^, probably providing opportunities for more nits | 22:46 |
efried | cdent: I only noticed cause I was going to try to bump us down by one :) | 22:47 |
cdent | go you | 22:47 |
efried | not sure you're gonna be encouraging me once you see where I'm going with this... | 22:47 |
cdent | just because I want to see you jump, doesn't mean you're going to win at the olympics | 22:48 |
cdent | efried: for the long future: https://black.readthedocs.io/en/stable/ | 22:52 |
*** tssurya has quit IRC | 22:53 | |
efried | cdent: At a skim, pep8 on steroids? | 22:54 |
efried | except it actually does the formatting, not just checking it? | 22:54 |
cdent | yes | 22:54 |
efried | nice | 22:54 |
cdent | it's pretty strict in some ways. lots of people hate it. | 22:55 |
edleafe | efried: I amend my remark about copying from another repo with history. It's certainly possible, but still a PITA: http://gbayer.com/development/moving-files-from-one-git-repository-to-another-preserving-history/ | 22:55 |
cdent | but because it is a third party the hate is oriented elsewhere | 22:55 |
edleafe | cdent: I hate it because of the closing paren on a separate line! | 22:56 |
cdent | :) | 22:56 |
edleafe | And I love it because it eschews single quotes! | 22:57 |
cdent | that's the reason I hate it :) | 22:57 |
cdent | I hate double quotes | 22:57 |
edleafe | foo = '' is so ugly. foo = "" is much clearer!!! | 22:59 |
cdent | it's a ~25000 line diff on placement, if you include quote fixing | 22:59 |
cdent | only ~ยง19000 lines if you avoid quote fixing | 23:00 |
edleafe | Would we run it as a check, or just insist that everyone use it and trust them? | 23:00 |
edleafe | It would mess local git up if CI changed the files | 23:00 |
edleafe | Fix all the quotes!!!! | 23:01 |
cdent | I had assumed it would be impossible to convince people that we should use it, so hadn't thought about real stuff | 23:01 |
cdent | but lots of people use it as a pre-commit hook | 23:01 |
edleafe | Well, I kind of like the 3rd-party hate instead of each of us hating each other :) | 23:02 |
edleafe | I got used to having someone dictate style when working with Go | 23:02 |
* cdent nods | 23:02 | |
cdent | it makes backporting harder | 23:02 |
edleafe | oh, hadn't thought of that | 23:03 |
edleafe | Maybe we should wait on adopting it until there is no need to backport | 23:03 |
* cdent snickers | 23:03 | |
* edleafe blinks naively | 23:03 | |
cdent | i'm assuming the room is done? or if not done nothing super important going on? | 23:03 |
cdent | i'm still laying in bed with the vapours | 23:04 |
edleafe | They're arguing stuff, but I'm not paying attention | 23:04 |
edleafe | Ironic finished about 30 min ago | 23:04 |
cdent | gibi, mriedem : easy merge https://review.openstack.org/#/c/601473/ | 23:05 |
edleafe | I think they were doing the rest of the Placement topics | 23:05 |
openstackgerrit | Merged openstack/placement master: Update the HACKING.rst file https://review.openstack.org/602475 | 23:07 |
gibi | cdent: done, nice drop on complexity | 23:07 |
cdent | thanks gibi. we can probably do even better in placement, just for fun | 23:08 |
openstackgerrit | Eric Fried proposed openstack/placement master: Move qs parsing to placement.lib.RequestGroup https://review.openstack.org/602495 | 23:08 |
efried | cdent: Step 1 ^ | 23:09 |
cdent | I forgot to put my pending spec on the etherpad as I didn't think it worth of in-person discussion: https://review.openstack.org/#/c/600016/ | 23:09 |
* cdent reads | 23:09 | |
*** takashin has left #openstack-placement | 23:11 | |
*** mriedem has quit IRC | 23:12 | |
openstackgerrit | Merged openstack/placement master: Set upper bound on max-complexity in pep8 https://review.openstack.org/601473 | 23:16 |
openstackgerrit | Chris Dent proposed openstack/nova-specs master: List resource providers having inventory https://review.openstack.org/600016 | 23:17 |
*** s10 has quit IRC | 23:18 | |
*** s10 has joined #openstack-placement | 23:19 | |
*** s10 has quit IRC | 23:19 | |
cdent | placeload tests in placement http://logs.openstack.org/84/602484/1/check/placement-tempest-gabbi/593c85c/logs/placement-perf.txt.gz | 23:19 |
*** s10 has joined #openstack-placement | 23:19 | |
*** s10 has quit IRC | 23:20 | |
*** s10 has joined #openstack-placement | 23:20 | |
*** s10 has quit IRC | 23:21 | |
*** s10 has joined #openstack-placement | 23:21 | |
*** sean-k-mooney has quit IRC | 23:21 | |
*** s10 has quit IRC | 23:22 | |
*** s10 has joined #openstack-placement | 23:22 | |
*** s10 has quit IRC | 23:22 | |
*** rubasov has quit IRC | 23:24 | |
openstackgerrit | Chris Dent proposed openstack/placement master: WIP: add a table create CLI https://review.openstack.org/600161 | 23:28 |
cdent | gibi: another easy one: https://review.openstack.org/#/c/602177/ | 23:29 |
*** efried has quit IRC | 23:30 | |
openstackgerrit | Merged openstack/nova stable/rocky: Make scheduler.utils.setup_instance_group query all cells https://review.openstack.org/599732 | 23:30 |
*** nicolasbock has quit IRC | 23:34 | |
openstackgerrit | Merged openstack/nova stable/rocky: Fix DB archiver AttributeError due to wrong table name attribute used https://review.openstack.org/599881 | 23:35 |
openstackgerrit | Sam Morrison proposed openstack/nova master: Allow ability for non admin users to use all filters on server list. https://review.openstack.org/526558 | 23:37 |
*** tetsuro has quit IRC | 23:39 | |
*** cdent has quit IRC | 23:47 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!