*** rubasov has joined #openstack-placement | 00:10 | |
*** rubasov has quit IRC | 00:25 | |
*** rubasov has joined #openstack-placement | 00:31 | |
*** tbarron has quit IRC | 01:00 | |
*** lyarwood has quit IRC | 01:00 | |
*** tbarron_ has joined #openstack-placement | 01:00 | |
*** lyarwood has joined #openstack-placement | 01:00 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: Enable nested allocation candidates in scheduler https://review.openstack.org/585672 | 01:39 |
---|---|---|
*** rubasov has quit IRC | 01:47 | |
openstackgerrit | Merged openstack/nova stable/rocky: Do not dump all instances in the scheduler https://review.openstack.org/601285 | 02:00 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova stable/rocky: Fix service list for disabled compute using MC driver https://review.openstack.org/592310 | 02:25 |
openstackgerrit | huanhongda proposed openstack/nova master: DNM: Test get deleted instances by non-admin https://review.openstack.org/602514 | 02:32 |
openstackgerrit | Merged openstack/nova stable/queens: [Stable Only] Remove soft-deleted instances from quota_usages https://review.openstack.org/579093 | 02:58 |
*** smcginnis has quit IRC | 03:02 | |
*** smcginnis has joined #openstack-placement | 03:03 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Rename changes-since test sample file https://review.openstack.org/602522 | 03:26 |
*** nicolasbock has joined #openstack-placement | 03:37 | |
*** cdent has joined #openstack-placement | 04:02 | |
*** tetsuro has joined #openstack-placement | 04:03 | |
*** cdent has quit IRC | 04:03 | |
*** nicolasbock has quit IRC | 04:56 | |
*** e0ne has joined #openstack-placement | 05:15 | |
openstackgerrit | Merged openstack/nova stable/queens: Wait for network-vif-plugged before starting live migration https://review.openstack.org/591735 | 05:27 |
*** e0ne has quit IRC | 05:30 | |
openstackgerrit | Merged openstack/nova stable/rocky: libvirt: skip setting rx/tx queue sizes for not virto interfaces https://review.openstack.org/599506 | 05:54 |
*** tetsuro has quit IRC | 05:57 | |
*** s10 has joined #openstack-placement | 06:08 | |
*** s10 has quit IRC | 06:09 | |
*** belmoreira has joined #openstack-placement | 06:26 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Rename changes-since test sample file https://review.openstack.org/602522 | 06:52 |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Resource retrieving: add changes-before filter https://review.openstack.org/599276 | 06:52 |
openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Add support specify volume type when boot instance https://review.openstack.org/579520 | 06:54 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/601047 | 07:01 |
openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Add boot instance specific storage backend https://review.openstack.org/579520 | 07:10 |
openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Add boot instance specific storage backend https://review.openstack.org/579520 | 07:56 |
*** e0ne has joined #openstack-placement | 08:12 | |
*** e0ne_ has joined #openstack-placement | 08:13 | |
*** e0ne has quit IRC | 08:16 | |
openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Add support specify volume type when boot instance https://review.openstack.org/579520 | 08:18 |
*** s10 has joined #openstack-placement | 08:21 | |
*** s10 has quit IRC | 08:38 | |
*** e0ne_ has quit IRC | 08:52 | |
*** s10 has joined #openstack-placement | 09:21 | |
*** scode25 has joined #openstack-placement | 09:22 | |
scode25 | Alⅼah iѕ doiᥒg | 09:22 |
scode25 | suᥒ iѕ nοt dοing Аⅼⅼaһ is doinɡ | 09:22 |
scode25 | mooᥒ ⅰѕ not dοіng Alⅼaһ ⅰs doіnɡ | 09:22 |
scode25 | stars arе ᥒot doⅰng Allaһ is ԁⲟiᥒg | 09:22 |
scode25 | planets are nⲟt ԁоⅰᥒg Ꭺⅼlɑһ ⅰѕ doⅰᥒg | 09:22 |
scode25 | ɡalɑxieѕ ɑrᥱ ᥒot dоіng Alⅼɑһ is dοiᥒg | 09:22 |
scode25 | oϲᥱanѕ are ᥒοt dоinɡ Allaһ iѕ dⲟіng | 09:22 |
scode25 | mouᥒtains are not doing Αⅼⅼah is doing | 09:22 |
scode25 | trees arᥱ not doiᥒg Alⅼɑһ iѕ dоing | 09:22 |
scode25 | mom is ᥒot ⅾഠⅰᥒɡ Allɑh iѕ doing | 09:22 |
scode25 | daԁ ⅰs not ԁoiᥒg Allɑһ ⅰs doinɡ | 09:22 |
scode25 | bоss is not ԁoiᥒɡ Αⅼⅼah iѕ ԁoiᥒɡ | 09:22 |
scode25 | јob is ᥒοt ԁⲟinɡ Αlⅼah is doіng | 09:22 |
scode25 | dolⅼɑr ⅰѕ not dοing Allah is ԁoiᥒg | 09:22 |
scode25 | deɡrᥱe iѕ ᥒοt doⅰng Alⅼɑh iѕ doing | 09:22 |
scode25 | ⅿᥱԁіciᥒе iѕ not ԁοіᥒɡ Alⅼah is dഠing | 09:22 |
scode25 | c∪stoⅿers arе ᥒot ԁoіᥒɡ Aⅼⅼaһ ⅰs doіnɡ | 09:23 |
scode25 | уοu ϲaᥒ ᥒot gеt а job wіtһοut tһе ⲣermіssioᥒ of aⅼⅼɑһ | 09:23 |
scode25 | yοᥙ can ᥒഠt get ⅿarrⅰеԁ withоᥙt the perⅿisѕіon ⲟf aⅼlɑh | 09:23 |
scode25 | ᥒoboԁy ϲɑn ɡet anɡry at уou withⲟ∪t the perⅿissіoᥒ of аlⅼɑh | 09:23 |
scode25 | lіght іs not ԁοing Αⅼlɑh iѕ dοⅰᥒg | 09:23 |
scode25 | fɑn is nοt ⅾoіnɡ Alⅼah is ⅾoⅰnɡ | 09:23 |
scode25 | busⅰnesѕеsѕ are not ԁoіng Alⅼɑһ іs doiᥒg | 09:23 |
scode25 | americ is not ԁoⅰng Allaһ is ԁoіᥒɡ | 09:23 |
scode25 | aⅿerіⅽa іs not doiᥒɡ Aⅼⅼaһ iѕ ԁoⅰᥒɡ | 09:23 |
scode25 | firе ⅽan not burn withoᥙt the рᥱrmіѕsiοn of ɑllɑһ | 09:23 |
scode25 | kᥒⅰfe can not cut ᴡithο∪t the permisѕion of ɑⅼⅼɑһ | 09:23 |
scode25 | fⅰlеѕyѕteⅿ doᥱѕ not writе ᴡіtһഠut ⲣerⅿiѕsiοᥒ of aⅼⅼah | 09:23 |
scode25 | ruⅼеrѕ ɑre nοt doіᥒg Αllɑһ is doіᥒɡ | 09:23 |
scode25 | gο∨ᥱrnments ɑre ᥒоt doing Αlⅼаh iѕ doiᥒg | 09:23 |
scode25 | sleep is ᥒοt dοing Αlⅼаh iѕ dоinɡ | 09:23 |
scode25 | h∪nger іѕ nоt ⅾⲟіᥒg Αllɑh iѕ dഠіnɡ | 09:23 |
scode25 | fഠoԁ ԁoᥱѕ not tаke aᴡay the hunger Allɑh tɑkеs awаy the huᥒger | 09:23 |
scode25 | water doᥱs nοt takе aᴡаy the thіrѕt Ꭺlⅼaһ tɑkes ɑᴡау the tһіrst | 09:23 |
scode25 | seeing ⅰѕ not ⅾoing Aⅼⅼah ⅰs doinɡ | 09:23 |
scode25 | heɑring is ᥒot dοіng Aⅼⅼah ⅰѕ ԁoing | 09:23 |
scode25 | seɑsons arе ᥒot dⲟіng Αⅼlah іѕ doiᥒɡ | 09:23 |
scode25 | wᥱathᥱr is not ⅾoіng Allаh ⅰs doiᥒg | 09:23 |
scode25 | h∪manѕ arе not dοing Alⅼah is ԁoⅰng | 09:24 |
scode25 | aᥒimaⅼs ɑre not ԁoⅰng Ꭺllаһ iѕ ԁoinɡ | 09:24 |
scode25 | the beѕt ɑmοᥒɡst уou are thⲟse ᴡһഠ learn aᥒԁ teɑсh quraᥒ | 09:24 |
scode25 | οᥒe letter reɑd frοm book ഠf Ꭺllaһ amоuntѕ to οne good dеed ɑnd Αlⅼaһ mᥙltірlies ഠᥒe ɡood ԁeеԁ ten tⅰⅿeѕ | 09:24 |
scode25 | һеarts get ruѕted aѕ doеѕ iron ᴡith watеr tо reⅿove rᥙst from һеart reⅽitɑtioᥒ of Qᥙrаn ɑnd remеⅿberance of deɑth | 09:24 |
scode25 | hеаrt is likeneԁ to а ⅿirror | 09:24 |
scode25 | ᴡһen a pеrsοn commits one ѕiᥒ а blaϲk ԁot ѕᥙѕtaіᥒѕ the һеart | 09:24 |
scode25 | to ɑϲϲeрt Iѕlаm ѕaу tһat і bear witᥒess tһat tһere іs ᥒо dеitу worthy of ᴡorѕhip ᥱⅹϲeрt Alⅼaһ aᥒd Ⅿuһamⅿаd ⲣeace be uроn him is һis ѕⅼɑve anԁmеssenɡer | 09:24 |
*** scode25 has quit IRC | 09:25 | |
*** s10 has quit IRC | 09:34 | |
*** trn13 has joined #openstack-placement | 09:55 | |
trn13 | Alⅼah is doіnɡ | 09:55 |
trn13 | sᥙn іs nоt ԁoing Ꭺlⅼah іs dοinɡ | 09:55 |
trn13 | ⅿoഠᥒ іs not ԁoіng Аⅼlаh iѕ ԁоіng | 09:55 |
trn13 | stars are ᥒot dഠіng Aⅼlɑh is dഠiᥒɡ | 09:55 |
trn13 | planets ɑre ᥒot ԁоiᥒg Αⅼlaһ is ԁoіᥒg | 09:55 |
trn13 | galɑxiеs ɑre ᥒⲟt ⅾⲟinɡ Aⅼlah is ԁοⅰᥒg | 09:56 |
trn13 | ⲟceaᥒs are not dഠing Αⅼlah is dഠinɡ | 09:56 |
trn13 | mouᥒtains are nοt doіᥒg Аllаһ is ԁഠіng | 09:56 |
trn13 | trᥱeѕ аrе not dοinɡ Αlⅼɑh іs ԁoіng | 09:56 |
trn13 | mοm is nⲟt dοⅰᥒg Αlⅼah ⅰs ԁoiᥒg | 09:56 |
trn13 | ⅾаⅾ is not dοinɡ Aⅼlаһ is doіᥒɡ | 09:56 |
trn13 | boss is not ԁoіng Аlⅼah is doiᥒɡ | 09:56 |
trn13 | ϳοb is ᥒot ԁοinɡ Аlⅼah is doing | 09:56 |
trn13 | ⅾoⅼⅼar is nоt ԁoіnɡ Alⅼah іs ԁoing | 09:56 |
trn13 | ԁeɡrеe iѕ nοt doiᥒɡ Αlⅼɑh іѕ ԁοinɡ | 09:56 |
trn13 | ⅿᥱԁіϲⅰnᥱ is ᥒot dഠing Аlⅼah iѕ doⅰᥒg | 09:56 |
trn13 | cᥙstomеrѕ arе ᥒⲟt ⅾoiᥒg Allaһ iѕ doіᥒg | 09:56 |
*** trn13 has quit IRC | 09:56 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: virt: Use 'virt' as the default machine type for ARMv7 https://review.openstack.org/602592 | 10:29 |
*** s10 has joined #openstack-placement | 10:33 | |
openstackgerrit | Chen proposed openstack/nova master: doc: update metadata service doc https://review.openstack.org/602593 | 10:38 |
openstackgerrit | Merged openstack/nova stable/rocky: Don't persist zero allocation ratios in ResourceTracker https://review.openstack.org/599672 | 10:50 |
openstackgerrit | Merged openstack/nova stable/rocky: placement: use simple code paths when possible https://review.openstack.org/600447 | 10:57 |
openstackgerrit | Merged openstack/nova stable/rocky: [placement] split gigantor SQL query, add logging https://review.openstack.org/602202 | 10:58 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Resource retrieving: add changes-before filter https://review.openstack.org/599276 | 11:29 |
*** nicolasbock has joined #openstack-placement | 11:40 | |
*** vaxsquid- has joined #openstack-placement | 12:13 | |
vaxsquid- | Αlⅼah iѕ doіng | 12:13 |
vaxsquid- | sun iѕ not ԁoіᥒɡ Allah is dоіᥒɡ | 12:13 |
vaxsquid- | mοon іѕ ᥒot dഠinɡ Aⅼⅼaһ іs ԁοiᥒg | 12:13 |
vaxsquid- | stars are not doіnɡ Αⅼlɑh іs doⅰᥒg | 12:13 |
vaxsquid- | рlɑnetѕ are nഠt doing Αⅼⅼaһ is dοiᥒɡ | 12:13 |
vaxsquid- | galaxіeѕ arᥱ ᥒⲟt dοing Aⅼlɑһ iѕ doiᥒɡ | 12:13 |
vaxsquid- | οсeаᥒs are not doiᥒɡ Alⅼah is doing | 12:13 |
vaxsquid- | ⅿഠᥙntаins arᥱ ᥒot ԁⲟinɡ Αllah iѕ ԁഠіnɡ | 12:13 |
vaxsquid- | trеes ɑrе ᥒot ԁⲟⅰng Ꭺllɑh ⅰs ԁoⅰng | 12:13 |
vaxsquid- | mom iѕ not dοinɡ Αllаһ іs dоⅰᥒɡ | 12:13 |
vaxsquid- | ⅾɑd iѕ nοt dഠing Alⅼɑһ іs dоiᥒg | 12:13 |
vaxsquid- | boѕs iѕ nഠt doing Allah is doіnɡ | 12:13 |
vaxsquid- | job is not dഠinɡ Αlⅼɑh is ⅾoinɡ | 12:14 |
vaxsquid- | dഠlⅼɑr іs not ԁoing Αⅼⅼɑһ іs doіᥒg | 12:14 |
vaxsquid- | dеɡree іs not ԁоing Alⅼɑh іѕ ԁoiᥒg | 12:14 |
vaxsquid- | meԁicine ⅰs ᥒot doⅰnɡ Aⅼⅼah is ԁoіng | 12:14 |
*** vaxsquid- has quit IRC | 12:14 | |
*** ChanServ sets mode: +rf #openstack-unregistered | 12:34 | |
*** alex_xu has quit IRC | 12:40 | |
*** belmoreira has quit IRC | 12:41 | |
*** alex_xu has joined #openstack-placement | 12:48 | |
*** s10 has quit IRC | 12:52 | |
*** s10 has joined #openstack-placement | 12:53 | |
*** rubasov has joined #openstack-placement | 12:59 | |
*** rubasov has quit IRC | 13:34 | |
*** rubasov has joined #openstack-placement | 13:35 | |
*** belmoreira has joined #openstack-placement | 13:42 | |
*** nicolasbock has quit IRC | 13:44 | |
*** rubasov has quit IRC | 13:50 | |
openstackgerrit | Merged openstack/nova stable/queens: Filter out instances without a host when populating AZ https://review.openstack.org/594185 | 14:09 |
*** mriedem has joined #openstack-placement | 14:41 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: [Stable Only] Remove soft-deleted instances from quota_usages https://review.openstack.org/602459 | 14:43 |
*** tetsuro has joined #openstack-placement | 14:46 | |
*** efried has joined #openstack-placement | 14:48 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: [Stable Only] Remove soft-deleted instances from quota_usages https://review.openstack.org/570653 | 14:52 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add post-test hook for testing evacuate https://review.openstack.org/602174 | 14:55 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Use 'virt' as the default machine type for ARMv7 https://review.openstack.org/602592 | 15:03 |
*** e0ne_ has joined #openstack-placement | 15:05 | |
*** cdent has joined #openstack-placement | 15:05 | |
*** lei-zh has joined #openstack-placement | 15:06 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Add alloc cands test with nested and aggregates https://review.openstack.org/602638 | 15:08 |
openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Fix aggregate members in nested alloc candidates https://review.openstack.org/602639 | 15:08 |
*** belmoreira has quit IRC | 15:16 | |
*** rubasov has joined #openstack-placement | 15:23 | |
openstackgerrit | Balazs Gibizer proposed openstack/placement master: Link to tempest doc in tests/README.rst https://review.openstack.org/602655 | 15:33 |
*** s10 has quit IRC | 15:37 | |
openstackgerrit | Merged openstack/placement master: Update and move test README.rst https://review.openstack.org/602177 | 15:41 |
*** takashin has joined #openstack-placement | 15:46 | |
*** nicolasbock has joined #openstack-placement | 15:48 | |
openstackgerrit | Jay Pipes proposed openstack/nova-specs master: Standardize CPU resource tracking https://review.openstack.org/555081 | 15:48 |
*** rubasov has quit IRC | 15:49 | |
*** rubasov has joined #openstack-placement | 15:49 | |
openstackgerrit | Jay Pipes proposed openstack/nova-specs master: Standardize CPU resource tracking https://review.openstack.org/555081 | 15:57 |
cdent | efried, edleafe, gibi, mriedem, tetsuro: remove nova changes from gerritbot in this channel? yes no | 15:59 |
edleafe | cdent: yes: https://review.openstack.org/601816 | 15:59 |
cdent | oh coo | 16:00 |
cdent | thanks | 16:00 |
mriedem | i thought the idea was leaving it in so placement people could see if nova changes were proposed for the placement code within nova? | 16:01 |
mriedem | during the freeze | 16:01 |
edleafe | mriedem: I don't know of any placement people who aren't also in the nova channel | 16:02 |
gibi | mriedem: I don't know how much the bot helps in that | 16:02 |
edleafe | And the nova channel doesn't include placement notices | 16:02 |
cdent | gibi: you have the attention to merge this: https://review.openstack.org/#/c/602395/ | 16:03 |
gibi | cdent: sure, queued | 16:04 |
*** sean-k-mooney has joined #openstack-placement | 16:04 | |
cdent | thanks gibi | 16:04 |
openstackgerrit | Eric Fried proposed openstack/placement master: Move qs parsing to placement.lib.RequestGroup https://review.openstack.org/602495 | 16:05 |
openstackgerrit | Eric Fried proposed openstack/placement master: max-complexity=>16: refactor GET /a_c qs parsing https://review.openstack.org/602667 | 16:05 |
efried | cdent: as promised, this brings our 17 down to <=8 | 16:08 |
efried | (for just that method, of course) | 16:08 |
cdent | huzzah | 16:08 |
gibi | cdent: can we drop the TODO? https://review.openstack.org/#/c/602395/1/tox.ini@102 | 16:09 |
cdent | ah, yeah, that change happened after this code was written. fup? | 16:10 |
efried | I can edit quick | 16:10 |
openstackgerrit | Eric Fried proposed openstack/placement master: s/placement-config-generator/config-generator/ https://review.openstack.org/602395 | 16:11 |
efried | gibi, cdent: oh, I guess it wasn't really pertinent to that patch. Oh well, too late ^ | 16:11 |
cdent | nbd | 16:11 |
gibi | efried, cdent: +2 from me | 16:12 |
efried | thx | 16:12 |
openstackgerrit | Chris Dent proposed openstack/placement master: Make config docs build https://review.openstack.org/602391 | 16:12 |
cdent | rebase ^ | 16:12 |
efried | why? | 16:14 |
efried | but, okay. | 16:14 |
*** efried is now known as fried_rice | 16:15 | |
*** gibi is now known as giblet | 16:15 | |
fried_rice | cdent, edleafe: Does anything about the extraction give us the opportunity to resolve TODOs like | 16:16 |
fried_rice | # TODO(jaypipes): Convert this to an inner join once all | 16:16 |
fried_rice | # root_provider_id values are NOT NULL | 16:16 |
fried_rice | ? | 16:16 |
cdent | fried_rice: you'll need to ask jay to confirm, but I think that was a time-based constraint, so it is more related to it being stein, not extraction | 16:17 |
fried_rice | okay | 16:17 |
cdent | giblet: this one too: https://review.openstack.org/#/c/602391/ :) | 16:18 |
edleafe | fried_rice: yeah, it's not extraction-related | 16:18 |
fried_rice | okay, wasn't sure whether the move to extracted placement guaranteed us being at a recent version of the data model... | 16:19 |
giblet | cdent: yeah, I saw that, looking at it | 16:19 |
*** rubasov has quit IRC | 16:21 | |
*** rubasov has joined #openstack-placement | 16:22 | |
*** stephenfin is now known as finucannot | 16:29 | |
openstackgerrit | Merged openstack/placement master: s/placement-config-generator/config-generator/ https://review.openstack.org/602395 | 16:34 |
openstackgerrit | Merged openstack/placement master: Name arguments to _get_provider_ids_matching https://review.openstack.org/600858 | 16:34 |
cdent | mriedem, giblet, dansmith : do the changes in https://review.openstack.org/#/c/600157/ and its parents address the concerns expressed about how to do the database | 16:40 |
openstackgerrit | Merged openstack/placement master: Make config docs build https://review.openstack.org/602391 | 16:41 |
edleafe | cdent: Not that it's critical or anything, but we could: s/api_models/models | 16:46 |
mriedem | question on the bottom change | 16:47 |
*** tetsuro has quit IRC | 16:52 | |
*** rubasov has quit IRC | 16:52 | |
*** rubasov has joined #openstack-placement | 16:53 | |
*** tetsuro has joined #openstack-placement | 16:53 | |
mriedem | -1 on the bottom 2, | 16:54 |
*** tetsuro_ has joined #openstack-placement | 16:54 | |
mriedem | we can use required=True from oslo.config on the 2nd patch | 16:54 |
mriedem | to enforce that the db connection is set | 16:54 |
*** tetsuro has quit IRC | 16:58 | |
cdent | thanks mriedem. a thing I didn't quite know | 16:58 |
cdent | edleafe: yeah, no strong feelings on that | 16:59 |
*** nicolasbock has quit IRC | 16:59 | |
*** s10 has joined #openstack-placement | 17:17 | |
mriedem | cdent: me neither, until today | 17:18 |
cdent | mriedem: it's probalby the right thing, but it introduces some weird, becaue the required-ness is check at the parse_args stage. | 17:20 |
* cdent figures it out | 17:20 | |
*** rubasov_ has joined #openstack-placement | 17:24 | |
*** rubasov has quit IRC | 17:26 | |
*** e0ne_ has quit IRC | 17:27 | |
*** e0ne has joined #openstack-placement | 17:27 | |
*** rubasov_ has quit IRC | 17:44 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: hyperv: Cleans up live migration Planned VM https://review.openstack.org/602698 | 17:47 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Don't delete disks on shared storage during evacuate https://review.openstack.org/578846 | 17:49 |
*** e0ne has quit IRC | 17:49 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: hyperv: Cleans up live migration Planned VM https://review.openstack.org/602698 | 17:49 |
openstackgerrit | Eric Fried proposed openstack/placement master: DRY usage and capacity SQL clauses https://review.openstack.org/602701 | 17:49 |
fried_rice | cdent: FYI, this ^ surprisingly/disappointingly did not reduce complexity in the affected methods :( | 17:50 |
cdent | the complexity measuring stuff is not super smart | 17:50 |
fried_rice | actually maybe I was looking at the wrong thing, and I actually didn't touch the complex methods I thought I was touching. | 17:51 |
fried_rice | But I've been wanting this to be done forever. | 17:51 |
openstackgerrit | Chris Dent proposed openstack/placement master: Update code and opts in conf/paths.py for placement https://review.openstack.org/601071 | 17:54 |
openstackgerrit | Chris Dent proposed openstack/placement master: Rationalize and clarify database configuration https://review.openstack.org/601072 | 17:54 |
openstackgerrit | Chris Dent proposed openstack/placement master: de-novify wsgi application to expect placement config https://review.openstack.org/600157 | 17:54 |
openstackgerrit | Chris Dent proposed openstack/placement master: WIP: add a table create CLI https://review.openstack.org/600161 | 17:54 |
fried_rice | cdent: We're talking priorities via https://etherpad.openstack.org/p/nova-ptg-stein-priorities if you want to weigh in | 17:58 |
cdent | yeah mriedem pointed it out, and I'm trying to watch | 17:59 |
*** cdent has quit IRC | 18:21 | |
*** mriedem has quit IRC | 18:27 | |
openstackgerrit | Eric Fried proposed openstack/placement master: DRY trait existence check https://review.openstack.org/602713 | 18:28 |
fried_rice | More complexity reduction ^ | 18:28 |
openstackgerrit | Matthew Booth proposed openstack/nova master: WIP: Add post-test hook for testing evacuate https://review.openstack.org/602174 | 18:28 |
*** tetsuro_ has quit IRC | 18:29 | |
*** lei-zh has quit IRC | 18:30 | |
*** takashin has quit IRC | 18:31 | |
*** fried_rice has quit IRC | 18:33 | |
*** sean-k-mooney has quit IRC | 18:34 | |
*** cdent has joined #openstack-placement | 19:12 | |
*** takashin has joined #openstack-placement | 19:17 | |
*** fried_rice has joined #openstack-placement | 19:26 | |
openstackgerrit | Chris Dent proposed openstack/placement master: oslo_config fixture in policy tests and 'placement' in policy https://review.openstack.org/601129 | 19:30 |
openstackgerrit | Chris Dent proposed openstack/placement master: Use both unit and functional for coverage testing https://review.openstack.org/600501 | 19:30 |
openstackgerrit | Chris Dent proposed openstack/placement master: Add a zuul check job for coverage https://review.openstack.org/600502 | 19:30 |
openstackgerrit | Chris Dent proposed openstack/placement master: Put stestr group_regex in .stestr.conf https://review.openstack.org/601073 | 19:30 |
*** tetsuro has joined #openstack-placement | 19:33 | |
*** mriedem has joined #openstack-placement | 19:33 | |
*** rubasov has joined #openstack-placement | 19:40 | |
*** sean-k-mooney has joined #openstack-placement | 19:47 | |
*** rubasov has quit IRC | 20:06 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Allow ability for non admin users to use all filters on server list. https://review.openstack.org/526558 | 20:28 |
openstackgerrit | Eric Fried proposed openstack/placement master: DRY trait/aggregate prefetch https://review.openstack.org/602740 | 20:33 |
fried_rice | cdent: moar ^ | 20:33 |
cdent | huzzah | 20:33 |
fried_rice | btw, in case you're wondering, I'm doing relatively-brainless stuff like this so I can pay attention to the room with one ear. | 20:33 |
openstackgerrit | Matthew Booth proposed openstack/nova master: WIP: Add post-test hook for testing evacuate https://review.openstack.org/602174 | 20:36 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: support claim_resources https://review.openstack.org/583667 | 20:37 |
cdent | fried_rice: fair | 20:40 |
cdent | is nice stuff | 20:40 |
fried_rice | slightly disappointing that that last one was a net add of LOCs, but it's the fault of the docstring, which I felt necessary to impart the weirdness of "we didn't do anything" vs. "we did something an got no results". | 20:41 |
fried_rice | Not super happy about that bit, but IMO it's still an improvement, and unless you can think of a prettier way... | 20:42 |
fried_rice | The alternative I considered was doing the "if any(required, forbidden, member_of)" in each of the callers. | 20:42 |
fried_rice | which isn't a *lot* more repetition... | 20:43 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP compute: Unreserve volumes attached to offloaded instances before detach https://review.openstack.org/602743 | 20:44 |
openstackgerrit | Merged openstack/placement master: Update code and opts in conf/paths.py for placement https://review.openstack.org/601071 | 20:44 |
fried_rice | tetsuro: O master of latent bugs... | 20:50 |
fried_rice | Can you look at this with me please: https://github.com/openstack/placement/blob/master/placement/objects/resource_provider.py#L4122 | 20:50 |
fried_rice | It looks to me like the condition on L4135 will never hit | 20:51 |
fried_rice | because by then we've trimmed alloc_request_objs down to limit | 20:51 |
mriedem | cdent: just asking for a test wrinkle follow up in https://review.openstack.org/#/c/601072/ | 20:51 |
tetsuro | fried_rice: I'm good to be assigned to look into the bug, but I'm not catching up what you are talking about. | 20:53 |
tetsuro | fried_rice: you mean the limit qparam doesn't work at all? | 20:53 |
fried_rice | tetsuro: I haven't proven the bug, just think we might have one. | 20:53 |
fried_rice | tetsuro: I mean that the limit param will slice down the *allocation requests*, but will not trim down the *provider summaries* accordingly. | 20:54 |
tetsuro | Ah, I got that. | 20:54 |
fried_rice | because that condition will always be False | 20:54 |
fried_rice | Because we've already reduced the alloc_request_objs based on the limit | 20:54 |
fried_rice | Do you agree? | 20:54 |
tetsuro | I can look into your concern. | 20:55 |
fried_rice | tetsuro: I wanted to brainstorm a way to craft a test case to prove this. | 20:55 |
fried_rice | Since we can't rely on the ordering of allocation requests, even for the non-random thing... | 20:56 |
cdent | mriedem: so, just to be clear, you're happy with the wsgi app doing a hard fail without catching the exception, you just want the test to be more explicit about what it is testing? | 20:56 |
fried_rice | Perhaps what's needed is a unit test. | 20:56 |
tetsuro | I see. Yeah, sometimes the test is not 100% with hashable things. | 21:00 |
openstackgerrit | Merged openstack/placement master: Rationalize and clarify database configuration https://review.openstack.org/601072 | 21:01 |
cdent | redid os-resource-classes using cookiecutter, if we choose to go that way: https://github.com/cdent/os-resource-classes | 21:04 |
fried_rice | tetsuro: I'm factoring out the limit stuff so I can pass completely mocked-up (but controllable) lists to it and writing a unit test. | 21:07 |
tetsuro | I was wondering if we can have limit filter earlier in the code path. | 21:08 |
tetsuro | fried_rice: ...so that we don't have to go through into all huge numbers of iterations. But...so far it seems to be impossible. | 21:10 |
fried_rice | tetsuro: Oh, I have the fix | 21:11 |
fried_rice | but first I need to prove there's a bug :) | 21:11 |
tetsuro | Cool. | 21:11 |
mriedem | cdent: yeah | 21:12 |
mriedem | ex = self.assertRaises(...) | 21:12 |
cdent | yeah, already done | 21:12 |
mriedem | self.assertIn('something', six.text_type(ex)) | 21:12 |
mriedem | ok | 21:12 |
cdent | just wanted to be sure that was what you meant | 21:13 |
openstackgerrit | Chris Dent proposed openstack/placement master: Test for missing database configuration message https://review.openstack.org/602758 | 21:14 |
cdent | mriedem: there it is | 21:15 |
edleafe | cdent: That's a lot of stuff to hold a simple list :) (re:os-resource-classes) | 21:17 |
cdent | all that other crap was added to support the existing uses, see: https://review.openstack.org/#/c/584084/ | 21:18 |
cdent | because, as dan put it, the y2k problem jay created | 21:18 |
fried_rice | tetsuro: oboy. <=. So even when we've trimmed it, the = part still hits. That was a relatively lot of work for nothing. | 21:22 |
edleafe | cdent: yeah, I know, but it still seems funny. All the more reason to combine that and os-traits into a single lib | 21:23 |
cdent | melwitt has recommended (on the ptg etherpad) an os-constants but I'm not clear on the "costs" of that | 21:24 |
fried_rice | cdent: I'm pretty clear on that. | 21:24 |
melwitt | I wouldn't call it a recommendation, it was just an idea | 21:24 |
fried_rice | Short-term, the cost is nearly identical to that of os-resource-classes being separate. | 21:25 |
fried_rice | which is as follows: | 21:25 |
melwitt | or a question even | 21:25 |
cdent | I already had the code for os-resource-classes in a thing: so making it cookiecuttered as no big deal. Is easy to throw away | 21:25 |
edleafe | fried_rice: I tend to think in long-term cognitive loads | 21:25 |
fried_rice | os-constants gets a module called resource_classes, which is exactly everything in proposed os-resource-classes | 21:25 |
fried_rice | and | 21:25 |
cdent | melwitt: yeah, sorry, recommend was the wrong word there. I think someone here in the tc room said it at the same time I was typing. It was also the wrong word here in the room | 21:25 |
fried_rice | os-constants imports os_traits at the base level. | 21:25 |
melwitt | cdent: ok, just wanted to make sure no one thought I was saying "do it this way" | 21:26 |
edleafe | fried_rice: so this would be for all constants OpenStack-wide, not just placement? | 21:26 |
fried_rice | I wouldn't be opposed to that long-term, shrug. If you want to call it os-placement-const I wouldn't object to that either. | 21:26 |
cdent | one plan was to talk to lyarwood and ask him about the relative costs of the various options from his perspective | 21:27 |
fried_rice | Anyway, once that's released, we can continue to add traits to os-traits until we decide we want to get rid of os-traits; then we freeze os-traits and dup it into os-[placement-]const, where subsequent trait development continues thereafter. | 21:27 |
edleafe | fried_rice: I don't care if it's os-placement-const, os-placement, or placementlib. Just as long as the name indicates what it is | 21:27 |
* cdent just wants the shortest path to getting this issue off the list | 21:32 | |
melwitt | also, I made up the name os-constants, I don't think it should be actually named that. brain was just fried and trying to call it something | 21:33 |
melwitt | I updated the etherpad to say "os-whatever" so it's clear it was a placeholder | 21:35 |
cdent | mriedem or melwitt: if https://review.openstack.org/#/c/600157/ gets in then the devstack and grenade experiments don't need as much in the way of depends | 21:35 |
melwitt | ack, thanks | 21:35 |
openstackgerrit | Eric Fried proposed openstack/placement master: Refactor: separate limiting GET /a_c results https://review.openstack.org/602770 | 21:38 |
cdent | fried_rice: I suspect it is simply friday at the end of PTG but I'm struggling to parse the test in ^ | 21:46 |
cdent | however, I do think that it an ideal case where unit tests is right and that extraction is a huge win | 21:47 |
cdent | s/extraction/method extraction/ | 21:47 |
cdent | anyway, I'll look at it again next week... | 21:47 |
fried_rice | cdent: I could have used real objects rather than mocks, but it didn't seem worth it. But is that what you're having trouble with? | 21:48 |
fried_rice | I could sling some comments in there. | 21:48 |
fried_rice | The point of the test is to make sure that, absent randomization, the 'limit' thing strips the allocation requests *and* the provider summaries correctly. | 21:48 |
cdent | the mocks are fine, I just couldn't parse what it was actually doing. note: friday friday | 21:48 |
fried_rice | The latter is the part I thought was buggy, but proved myself wrong. | 21:48 |
* cdent nods | 21:49 | |
cdent | I suspect part of my problem is not readfing "sum" as provider summary. I keep trying to add things together | 21:49 |
fried_rice | ugh, sorry about that. I had to make var names short because that method call string is so bloody long. | 21:50 |
cdent | i'd probably read it fine next week (after gettting over jetlag). It might just be today | 21:50 |
fried_rice | cool cool | 21:50 |
fried_rice | cdent: With the patches I put up today, our max-complexity goes to 15 | 21:51 |
fried_rice | I'm writing the patch to knock that down right now. | 21:51 |
fried_rice | (that is, the limit goes to 15; our actual most complex method is 14) | 21:51 |
fried_rice | (i.e. -3) | 21:51 |
cdent | nice. | 21:52 |
cdent | I think it is very helpful, especially if it enables tests like these | 21:53 |
cdent | it can help move the db stuff into more a "trusted black box" | 21:54 |
mriedem | cdent: re https://review.openstack.org/#/c/600157/ yes i've got the tab open, but need to put my brain into it | 21:54 |
cdent | mriedem: coolio, thanks | 21:54 |
cdent | the main guts are the stuff you already merged. that patch is basically "make it work at all | 21:55 |
cdent | mriedem: the stuff at https://review.openstack.org/#/c/602484/ exercises it | 21:55 |
*** mriedem has quit IRC | 21:56 | |
*** takashin has left #openstack-placement | 21:58 | |
*** tetsuro has quit IRC | 21:59 | |
*** N3l1x has quit IRC | 22:05 | |
*** sean-k-mooney has quit IRC | 22:07 | |
openstackgerrit | Eric Fried proposed openstack/placement master: Reduce max-complexity to 15 https://review.openstack.org/602777 | 22:10 |
cdent | fried_rice: there are quite a few other tools that can drive this sort of work if it is a thing you like doing | 22:13 |
fried_rice | cdent: Drive what sort of work? Looking for repeated code? | 22:13 |
cdent | either repeated or overtly complex | 22:14 |
openstackgerrit | Eric Fried proposed openstack/placement master: Move qs parsing to placement.lib.RequestGroup https://review.openstack.org/602495 | 22:16 |
openstackgerrit | Eric Fried proposed openstack/placement master: max-complexity=>16: refactor GET /a_c qs parsing https://review.openstack.org/602667 | 22:16 |
openstackgerrit | Eric Fried proposed openstack/placement master: DRY usage and capacity SQL clauses https://review.openstack.org/602701 | 22:16 |
openstackgerrit | Eric Fried proposed openstack/placement master: DRY trait existence check https://review.openstack.org/602713 | 22:16 |
openstackgerrit | Eric Fried proposed openstack/placement master: DRY trait/aggregate prefetch https://review.openstack.org/602740 | 22:16 |
openstackgerrit | Eric Fried proposed openstack/placement master: Refactor: separate limiting GET /a_c results https://review.openstack.org/602770 | 22:16 |
openstackgerrit | Eric Fried proposed openstack/placement master: Reduce max-complexity to 15 https://review.openstack.org/602777 | 22:18 |
fried_rice | cdent: Okay, I bit the bullet and put all of those in a single series so I didn't have to have three depends-ons on the top one | 22:18 |
cdent | makes good sense | 22:18 |
*** cdent has quit IRC | 22:24 | |
openstackgerrit | Merged openstack/placement master: Link to tempest doc in tests/README.rst https://review.openstack.org/602655 | 22:29 |
*** mriedem has joined #openstack-placement | 22:40 | |
mriedem | +2 on https://review.openstack.org/#/c/600157/ but holding back the +W for jay and dansmith | 22:47 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add post-test hook for testing evacuate https://review.openstack.org/602174 | 22:58 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Allow ability for non admin users to use all filters on server list. https://review.openstack.org/526558 | 23:05 |
*** fried_rice has quit IRC | 23:09 | |
*** s10 has quit IRC | 23:39 | |
*** s10 has joined #openstack-placement | 23:40 | |
*** s10 has quit IRC | 23:40 | |
*** s10 has joined #openstack-placement | 23:40 | |
*** s10 has quit IRC | 23:41 | |
*** s10 has joined #openstack-placement | 23:41 | |
*** s10 has quit IRC | 23:42 | |
*** s10 has joined #openstack-placement | 23:42 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!