| *** thorst_afk has joined #openstack-powervm | 00:19 | |
| *** thorst_afk has quit IRC | 00:23 | |
| *** edmondsw has joined #openstack-powervm | 01:10 | |
| *** edmondsw has quit IRC | 01:15 | |
| *** thorst_afk has joined #openstack-powervm | 01:20 | |
| *** thorst_afk has quit IRC | 01:24 | |
| *** thorst_afk has joined #openstack-powervm | 02:00 | |
| *** thorst_afk has quit IRC | 02:00 | |
| *** thorst_afk has joined #openstack-powervm | 02:36 | |
| *** thorst_afk has quit IRC | 02:36 | |
| *** edmondsw has joined #openstack-powervm | 02:58 | |
| *** edmondsw has quit IRC | 03:02 | |
| *** thorst_afk has joined #openstack-powervm | 03:37 | |
| *** thorst_afk has quit IRC | 03:56 | |
| *** chhavi has joined #openstack-powervm | 04:10 | |
| openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: ISCSI volume attachment fixes https://review.openstack.org/467599 | 04:24 |
|---|---|---|
| openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: ISCSI volume attachment fixes https://review.openstack.org/467599 | 04:39 |
| openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: ISCSI volume attachment fixes https://review.openstack.org/467599 | 04:55 |
| openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: ISCSI volume attachment fixes https://review.openstack.org/467599 | 05:14 |
| openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: ISCSI volume attachment fixes https://review.openstack.org/467599 | 05:30 |
| *** thorst_afk has joined #openstack-powervm | 05:54 | |
| openstackgerrit | Bing Li proposed openstack/nova-powervm master: Remove log translations https://review.openstack.org/473221 | 05:59 |
| *** thorst_afk has quit IRC | 05:59 | |
| openstackgerrit | Bing Li proposed openstack/nova-powervm master: Remove log translations https://review.openstack.org/473221 | 06:32 |
| *** edmondsw has joined #openstack-powervm | 06:34 | |
| *** edmondsw has quit IRC | 06:39 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/nova-powervm master: Change author in setup.cfg https://review.openstack.org/473232 | 06:51 |
| *** thorst_afk has joined #openstack-powervm | 06:55 | |
| *** thorst_afk has quit IRC | 06:59 | |
| *** thorst_afk has joined #openstack-powervm | 07:56 | |
| *** thorst_afk has quit IRC | 08:00 | |
| *** k0da has joined #openstack-powervm | 08:16 | |
| *** edmondsw has joined #openstack-powervm | 08:22 | |
| *** edmondsw has quit IRC | 08:27 | |
| *** thorst_afk has joined #openstack-powervm | 08:56 | |
| *** thorst_afk has quit IRC | 09:16 | |
| *** edmondsw has joined #openstack-powervm | 10:11 | |
| *** thorst_afk has joined #openstack-powervm | 10:13 | |
| *** edmondsw has quit IRC | 10:15 | |
| *** thorst_afk has quit IRC | 10:17 | |
| *** thorst_afk has joined #openstack-powervm | 11:43 | |
| *** jpasqualetto has joined #openstack-powervm | 12:04 | |
| *** dwayne_ has quit IRC | 12:25 | |
| *** mdrabe has joined #openstack-powervm | 12:28 | |
| chhavi | thorst_afk: nova_powervm CI master branch, is not picking the pypowervm return code changes | 12:29 |
| chhavi | are they not integrated | 12:29 |
| chhavi | https://review.openstack.org/#/c/467599/ | 12:29 |
| thorst_afk | depends on if they made a release and if that release has been updated in the upper-requirements | 12:29 |
| thorst_afk | efried: ^^^ ? | 12:29 |
| efried | correct | 12:30 |
| chhavi | efried: so what i need to do to pick it, i am using nova-powervm master branch | 12:30 |
| chhavi | pypowervm>=1.1.4 | 12:30 |
| chhavi | it shows this as the requirements | 12:31 |
| efried | We would need to cut a new release of pypowervm, then update the minimum in nova-powervm's requirements - which these days entails updating the minimum in global-requirements. | 12:31 |
| chhavi | how to check which release the return code is merged | 12:31 |
| efried | hm, I had thought jfoliva cut 1.1.6, but I don't see it out there anywhere. In any case, those changes aren't yet in any release. | 12:33 |
| efried | These iscsi changes would be the only delta from 1.1.5. thorst_afk do we want to spin a new release now? | 12:34 |
| thorst_afk | efried: we should ask in the NL scrum. I think there are other changes that are going in...but I think the iSCSI bits are enough to justify one | 12:35 |
| thorst_afk | just want to make sure we don't need to get anything else in | 12:35 |
| efried | chhavi FYI, I use this to look at a tree diagram of branches: git log --oneline --decorate --graph --all | 12:36 |
| chhavi | got it thanks | 12:36 |
| efried | thorst_afk Yeah, actually, we should include this power-off bug. | 12:36 |
| *** edmondsw has joined #openstack-powervm | 12:38 | |
| *** smatzek has joined #openstack-powervm | 12:40 | |
| *** jwcroppe has quit IRC | 13:01 | |
| *** jwcroppe has joined #openstack-powervm | 13:02 | |
| *** jwcroppe has quit IRC | 13:06 | |
| *** jwcroppe has joined #openstack-powervm | 13:15 | |
| *** esberglu has joined #openstack-powervm | 13:34 | |
| *** esberglu has quit IRC | 13:44 | |
| *** esberglu has joined #openstack-powervm | 13:45 | |
| esberglu | thorst_afk: efried: edmondsw: Still fighting with devstack. Seeing a new error now for OOT master | 14:21 |
| edmondsw | esberglu something changed over the weekend? I thought you had OOT master passing in your test runs on Friday | 14:22 |
| esberglu | I had it passing manually. Not sure if another change went in between the time that happened and the nodes picked up the change | 14:23 |
| esberglu | edmondsw: The issue is that the /etc/neutron dir doesn't exist and it's trying to do stuff with /etc/neutron/neutron.conf | 14:26 |
| esberglu | I was stacking/unstacking a bunch on the manual test node | 14:26 |
| esberglu | So I'm worried that the directory got created on one of the failed stacks | 14:26 |
| esberglu | So when I restacked with the latest version of local.conf it went through | 14:27 |
| edmondsw | makes sense | 14:38 |
| efried | esberglu Jay is hitting this on neo32 FYI | 14:45 |
| efried | in case you need a local repro to fiddle with. | 14:45 |
| *** jay1_ has joined #openstack-powervm | 14:45 | |
| *** dwayne_ has joined #openstack-powervm | 14:46 | |
| *** chhavi has quit IRC | 15:35 | |
| *** k0da has quit IRC | 15:40 | |
| efried | edmondsw Get a fresh cup of coffee before you open up 5433 again. | 15:41 |
| *** dwayne_ has quit IRC | 16:03 | |
| *** kjw3 has joined #openstack-powervm | 16:09 | |
| *** dwayne has joined #openstack-powervm | 16:17 | |
| edmondsw | efried that's a fun one... replied | 17:28 |
| edmondsw | and I do need more coffee... | 17:29 |
| edmondsw | or more sleep... | 17:29 |
| efried | If by "fun" you mean, "please claw my eyes out rather than make me touch this code ever again" | 17:29 |
| edmondsw | yeah... | 17:29 |
| edmondsw | my reply basically ends with "deprecate and replace this" | 17:30 |
| edmondsw | efried so we never have to look at it again :) | 17:30 |
| efried | A deprecation/replacement cycle guarantees we need to look at it for at least another several months. I prefer "tweak it until it's not broken, then throw it over the fence and hope it doesn't break ever again." | 17:31 |
| efried | Meanwhile, I'm still trying to convince myself that 5421 is a) correct, and b) necessary at all. This is another chunk of code that's overly complicated but in a critical path. | 17:32 |
| edmondsw | efried the changes I recommended essentially "tweak it until it's not broken" and then deprecating/replacing it means that we don't have to just hope it doesn't break every again... we get to limit "ever again" to our deprecation timeframe :) | 17:44 |
| efried | edmondsw Yup, got it. | 17:44 |
| edmondsw | efried 5421 is necessary for us to avoid bugs popping up once we merge https://review.openstack.org/#/c/471773/ | 17:44 |
| edmondsw | and I'm fairly comfortable with the logic there being correct... of course I need to write UTs, but the logic isn't too complicated | 17:45 |
| efried | edmondsw Yeah, I stared at it some more and I'm good with it, but want some more eyes on it. | 17:45 |
| efried | Talking about 5421 - I haven't given the community one a lot of attention yet. | 17:46 |
| edmondsw | I did just notice that gerrit won't let me make any new patch sets there, because it had the same change-id as the abandoned master change, so it thinks that change is already closed :( | 17:46 |
| edmondsw | efried so I think I need to abandon that and start fresh, unless you have some trick | 17:46 |
| efried | boo. | 17:46 |
| efried | You can change the change-id, and it ought to show up as a new change set. | 17:46 |
| efried | And yeah, you'll then have to abandon the old one. | 17:46 |
| efried | You could also un-abandon the master one until the develop one merges. | 17:47 |
| edmondsw | preference? | 17:47 |
| edmondsw | how would one change a change-id? i.e., what would you change it to / how would you trigger gerrit to create a new one? | 17:48 |
| edmondsw | I think I'd probably rather do that, seems cleaner | 17:48 |
| efried | edmondsw git commit --amend, delete the line with the change-id on it, then when you git-review, it'll add a new one. I'm not completely sure if it'll put it in the right place branch-wise, though, but it should warn you if it thinks you're going to be stacking it on top of the previous change. Whereupon you would have to squash commits. | 17:50 |
| efried | I prefer a way that the comment history sticks with the change in gerrit, though, which would be the temporary un-abandon. | 17:51 |
| edmondsw | oh, doh, I just realized... it wasn't that master was abandoned that it didn't like, it was that I was forgetting to add "develop" after "git-review", so it was trying the wrong branch | 17:52 |
| edmondsw | efried new changes are up for 5421 | 17:52 |
| *** jwcroppe has quit IRC | 17:59 | |
| *** jwcroppe has joined #openstack-powervm | 18:00 | |
| *** jwcroppe has quit IRC | 18:40 | |
| *** k0da has joined #openstack-powervm | 18:55 | |
| *** jwcroppe has joined #openstack-powervm | 18:57 | |
| *** jwcroppe has quit IRC | 19:07 | |
| *** jwcroppe has joined #openstack-powervm | 19:09 | |
| esberglu | edmondsw: efried: thorst_afk: External prep_devstack is working on the staging environment now. Added 1 patchset to the neo-os-ci side of things | 19:25 |
| efried | esberglu Did we get the neutron_plugin_create_nova_conf problem resolved? | 19:27 |
| esberglu | Nope I've been working both simultaneously. Still figuring that one out | 19:27 |
| *** k0da has quit IRC | 19:41 | |
| efried | edmondsw Took a more detailed swag at https://review.openstack.org/#/c/471773/ | 19:55 |
| efried | Let me know if you want to discuss. | 19:55 |
| edmondsw | efried tx, will look in a bit | 19:55 |
| edmondsw | efried have you looked at https://review.openstack.org/#/c/472794/ ? might want to do that before 471773 | 19:56 |
| efried | edmondsw Ah, nope, hadn't seen that. | 19:57 |
| edmondsw | efried that split out from your comment about doing the enable/disable services in a common way | 19:57 |
| efried | You don't have to follow this weird nova protocol about not adding any reviewers when it comes to our team. Just add me. I'll never see your changes otherwise. | 19:57 |
| edmondsw | efried I thought I did | 19:58 |
| edmondsw | oops, no, must have forgotten on that one | 19:58 |
| *** k0da has joined #openstack-powervm | 19:58 | |
| efried | edmondsw Cool, just what I had in mind. Let's get it +1-able and see if the cores bite. | 20:14 |
| edmondsw | efried exactly | 20:14 |
| edmondsw | efried I wanted to make sure you and I were on the same page, get your comments addressed, and see what you thought about whether I should invest the time writing tests before or after we get a couple core opinions | 20:15 |
| edmondsw | tests will take some work there.... I think over 100 failures right now | 20:15 |
| efried | edmondsw Well, do you think we should solicit core opinions before you get into that? | 20:16 |
| edmondsw | yes | 20:16 |
| efried | Okay. | 20:16 |
| efried | You on that? | 20:16 |
| edmondsw | I wanted to get your opinion first | 20:17 |
| edmondsw | and then thought you could suggest which cores to ping | 20:17 |
| edmondsw | or bring this up in a nova meeting, or... ? | 20:17 |
| efried | Yeah, so I didn't even realize set_host_enabled was already a driver method. Did you see any impls of it thus far? | 20:17 |
| edmondsw | you know the process better than I do | 20:17 |
| edmondsw | just one... xen | 20:18 |
| efried | Yeah, so I would approach it one of several ways. | 20:18 |
| edmondsw | efried I think that one impl was really for the os-hosts API, which is deprecated | 20:18 |
| efried | You could poke around #openstack-nova and see if anyone is willing to render an opinion. I would think git blame would be a good way to figure out who to tag. | 20:19 |
| efried | You could send a note to the openstack-dev mailing list asking for feedback. | 20:19 |
| efried | And/or you could start adding cores explicitly to the review. | 20:19 |
| efried | I find that last thing to be pretty ineffective overall. | 20:20 |
| edmondsw | yeah | 20:20 |
| edmondsw | k | 20:20 |
| edmondsw | let me know what you think and then I'll start figuring that out | 20:20 |
| efried | edmondsw I guess I would do those first two things, in that order. Poke on IRC, and if no/insufficient response, blast the ML. | 20:21 |
| efried | I can start looking for names. | 20:21 |
| edmondsw | yeah, I generally prefer irc to ML | 20:21 |
| efried | I know you'll want jaypipes, mriedem | 20:21 |
| efried | I'll get back to you with more. | 20:21 |
| edmondsw | tx | 20:22 |
| efried | But those two might be good to start with. | 20:22 |
| efried | edmondsw Sorry, it was dansmith, not jaypipes, who did the manager thing with consecutive_build_service_disable_threshold | 20:26 |
| edmondsw | k | 20:26 |
| efried | edmondsw Looks like you should hit dansmith, mriedem, and sfinucan, in that order of importance. | 20:36 |
| edmondsw | tx | 20:36 |
| efried | edmondsw Lemme know when you're going in, so I can follow along. | 20:37 |
| edmondsw | efried who is sfinucan? Haven't seen that handle before | 20:37 |
| edmondsw | efried probably be tomorrow | 20:37 |
| efried | New guy, works out of Ireland, pretty recent core, I think he works for Intel. | 20:37 |
| *** jpasqualetto has quit IRC | 20:38 | |
| efried | edmondsw 5433, quick look before I get moving on it. | 20:53 |
| *** kjw3 has quit IRC | 20:58 | |
| edmondsw | efried yeah, I think you're probably ok with just #1 and #3 | 21:01 |
| edmondsw | you want to do #3 in a separate change? | 21:01 |
| efried | yes | 21:01 |
| edmondsw | why? | 21:01 |
| edmondsw | nm, I'm fine with that | 21:02 |
| edmondsw | so in the docstring, I'd make it clear (since you're not doing #2) that restart and force_immediate are ignored if PowerOffOpts are passed | 21:03 |
| esberglu | efried: edmondsw: One more change on the external prep_devstack that came up while testing the other branches | 21:07 |
| esberglu | I've tested that on IT and all 3 OOT branches | 21:07 |
| esberglu | With the external local.conf files as well | 21:07 |
| esberglu | All of that seems to be working now | 21:08 |
| esberglu | I want to redeploy production this evening with all of that | 21:08 |
| efried | edmondsw Done. | 21:08 |
| esberglu | So that when I get this dyevstack stuff figured out we can be up right awa | 21:08 |
| efried | esberglu Should we wait to review? | 21:09 |
| esberglu | efried: Nope 5405 is ready to go | 21:09 |
| edmondsw | esberglu will look as soon as I finish checking 5433 | 21:09 |
| esberglu | Thanks | 21:10 |
| efried | edmondsw Now to see whether that mysterious i18n bug stays gone. | 21:11 |
| edmondsw | efried what bug? | 21:11 |
| efried | edmondsw Slacked | 21:13 |
| *** k0da has quit IRC | 21:14 | |
| *** smatzek has quit IRC | 21:15 | |
| edmondsw | esberglu +2 | 21:15 |
| esberglu | edmondsw: efried: Thanks | 21:15 |
| esberglu | Now I just have to redeploy, then we can merge 5425 | 21:16 |
| edmondsw | efried if you hit that i18n issue again, we should ask btang to take a look | 21:18 |
| efried | edmondsw I can repro it locally every time. | 21:18 |
| edmondsw | then we should ask him about it | 21:18 |
| edmondsw | he's good with those | 21:18 |
| *** esberglu has quit IRC | 21:19 | |
| edmondsw | efried I don't think this would be your issue, but I'd remove the trailing space in that warning message | 21:20 |
| *** esberglu has joined #openstack-powervm | 21:20 | |
| efried | edmondsw What trailing space? | 21:21 |
| edmondsw | efried "Encountered an issue while uploading. " | 21:21 |
| edmondsw | space after the period | 21:21 |
| efried | The message continues on the next code line. | 21:21 |
| edmondsw | ah, k | 21:21 |
| efried | That space is between the period and the next word. | 21:21 |
| *** esberglu has quit IRC | 21:25 | |
| *** thorst_afk has quit IRC | 21:25 | |
| efried | edmondsw Pah, this time it didn't hit. | 21:27 |
| edmondsw | efried has it been inconsistent like that? | 21:28 |
| efried | edmondsw Jenkins only hit it the once. But now I'm hitting it in my venv every time. | 21:28 |
| efried | Well, every time I invoke that test in isolation. Trying with all of py27 now... | 21:29 |
| efried | Nope. | 21:29 |
| efried | So it's timing. | 21:29 |
| efried | Hm, I bet it has something to do with our mocking of LOG methods. | 21:29 |
| *** chhavi has joined #openstack-powervm | 21:32 | |
| *** esberglu has joined #openstack-powervm | 21:32 | |
| edmondsw | efried that seems like a fair guess | 21:32 |
| *** chhavi has quit IRC | 21:36 | |
| *** thorst_afk has joined #openstack-powervm | 21:45 | |
| *** thorst_afk has quit IRC | 21:49 | |
| *** edmondsw has quit IRC | 21:50 | |
| *** edmondsw has joined #openstack-powervm | 21:59 | |
| *** smatzek has joined #openstack-powervm | 22:00 | |
| *** edmondsw has quit IRC | 22:03 | |
| *** edmondsw has joined #openstack-powervm | 22:05 | |
| *** smatzek has quit IRC | 22:07 | |
| *** smatzek has joined #openstack-powervm | 22:08 | |
| *** edmondsw has quit IRC | 22:09 | |
| *** edmondsw has joined #openstack-powervm | 22:11 | |
| *** edmondsw_ has joined #openstack-powervm | 22:14 | |
| *** edmondsw has quit IRC | 22:15 | |
| *** edmondsw_ has quit IRC | 22:18 | |
| *** smatzek has quit IRC | 22:21 | |
| *** edmondsw has joined #openstack-powervm | 22:42 | |
| *** edmondsw has quit IRC | 22:46 | |
| *** jwcroppe has quit IRC | 23:24 | |
| *** jwcroppe has joined #openstack-powervm | 23:39 | |
| *** jwcroppe has quit IRC | 23:43 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!