| *** jwcroppe has joined #openstack-powervm | 00:33 | |
| *** jwcroppe has quit IRC | 00:43 | |
| *** jwcroppe has joined #openstack-powervm | 00:43 | |
| *** esberglu has quit IRC | 01:04 | |
| *** esberglu has joined #openstack-powervm | 01:04 | |
| *** esberglu has quit IRC | 01:09 | |
| *** thorst_afk has joined #openstack-powervm | 01:33 | |
| *** thorst_afk has quit IRC | 01:43 | |
| *** mdrabe has quit IRC | 01:46 | |
| *** mdrabe has joined #openstack-powervm | 01:46 | |
| *** thorst_afk has joined #openstack-powervm | 02:13 | |
| *** thorst_afk has quit IRC | 02:23 | |
| *** thorst_afk has joined #openstack-powervm | 02:24 | |
| *** thorst_afk has quit IRC | 02:24 | |
| *** thorst_afk has joined #openstack-powervm | 02:54 | |
| *** thorst_afk has quit IRC | 03:14 | |
| *** mdrabe_ has joined #openstack-powervm | 03:17 | |
| *** mdrabe has quit IRC | 03:20 | |
| *** mdrabe_ has quit IRC | 03:27 | |
| *** jay1_ has quit IRC | 03:29 | |
| *** chhavi has joined #openstack-powervm | 03:50 | |
| *** esberglu has joined #openstack-powervm | 04:04 | |
| *** esberglu has quit IRC | 04:09 | |
| *** thorst_afk has joined #openstack-powervm | 04:11 | |
| *** mdrabe has joined #openstack-powervm | 04:23 | |
| *** thorst_afk has quit IRC | 04:30 | |
| *** mdrabe has quit IRC | 04:35 | |
| *** jwcroppe_ has joined #openstack-powervm | 05:31 | |
| *** jwcroppe has quit IRC | 05:32 | |
| *** efried has quit IRC | 05:34 | |
| *** esberglu has joined #openstack-powervm | 05:34 | |
| *** esberglu has quit IRC | 05:38 | |
| *** efried has joined #openstack-powervm | 05:50 | |
| *** edmondsw has joined #openstack-powervm | 05:56 | |
| *** edmondsw has quit IRC | 06:01 | |
| *** thorst_afk has joined #openstack-powervm | 06:27 | |
| *** thorst_afk has quit IRC | 06:32 | |
| *** k0da has joined #openstack-powervm | 06:46 | |
| *** esberglu has joined #openstack-powervm | 07:22 | |
| *** esberglu has quit IRC | 07:26 | |
| *** thorst_afk has joined #openstack-powervm | 07:28 | |
| *** thorst_afk has quit IRC | 07:32 | |
| *** thorst_afk has joined #openstack-powervm | 08:29 | |
| *** k0da has quit IRC | 08:30 | |
| *** k0da has joined #openstack-powervm | 08:32 | |
| *** thorst_afk has quit IRC | 08:33 | |
| *** esberglu has joined #openstack-powervm | 09:10 | |
| *** esberglu has quit IRC | 09:14 | |
| *** thorst_afk has joined #openstack-powervm | 09:29 | |
| *** edmondsw has joined #openstack-powervm | 09:32 | |
| *** edmondsw has quit IRC | 09:37 | |
| *** thorst_afk has quit IRC | 09:49 | |
| *** smatzek has joined #openstack-powervm | 10:30 | |
| *** smatzek has quit IRC | 10:42 | |
| *** thorst_afk has joined #openstack-powervm | 10:46 | |
| *** thorst_afk has quit IRC | 10:50 | |
| *** esberglu has joined #openstack-powervm | 10:58 | |
| *** esberglu has quit IRC | 11:03 | |
| *** smatzek has joined #openstack-powervm | 11:38 | |
| *** thorst_afk has joined #openstack-powervm | 11:52 | |
| *** jpasqualetto has joined #openstack-powervm | 12:01 | |
| *** openstackgerrit has quit IRC | 12:18 | |
| *** edmondsw has joined #openstack-powervm | 12:26 | |
| *** esberglu has joined #openstack-powervm | 12:46 | |
| *** esberglu has quit IRC | 12:51 | |
| *** esberglu has joined #openstack-powervm | 13:00 | |
| esberglu | #startmeeting powervm_driver_meeting | 13:01 |
|---|---|---|
| openstack | Meeting started Tue Jun 13 13:01:01 2017 UTC and is due to finish in 60 minutes. The chair is esberglu. Information about MeetBot at http://wiki.debian.org/MeetBot. | 13:01 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 13:01 |
| openstack | The meeting name has been set to 'powervm_driver_meeting' | 13:01 |
| edmondsw | o/ | 13:01 |
| edmondsw | efried thorst_afk you here? | 13:02 |
| thorst_afk | kinda here | 13:02 |
| esberglu | #topic In Tree Driver | 13:03 |
| esberglu | #link https://etherpad.openstack.org/p/powervm-in-tree-todos | 13:03 |
| edmondsw | I have been working on a couple patches | 13:03 |
| edmondsw | https://review.openstack.org/#/c/471773/ | 13:04 |
| edmondsw | https://review.openstack.org/#/c/472794/ | 13:04 |
| edmondsw | second was at efried's request via comment in the first, but I think should probably go first | 13:04 |
| edmondsw | he just gave his comments yesterday, which I plan to go through today and then ping a couple cores for their thoughts, make sure this is acceptable before I invest a lot of time in UTs | 13:05 |
| esberglu | Yeah that order makes sense from a quick glance | 13:05 |
| edmondsw | other than that, we got a +2 on esberglu's support matrix patch... got a link for that? | 13:06 |
| esberglu | https://review.openstack.org/#/c/470999/ | 13:06 |
| edmondsw | that's the one | 13:06 |
| * thorst_afk is now afk | 13:06 | |
| esberglu | Anything we need discussion on in tree? | 13:07 |
| edmondsw | I'll add mriedem and sdague on that and see if we can get it merged | 13:07 |
| esberglu | edmondsw: Sweet | 13:07 |
| edmondsw | done | 13:08 |
| edmondsw | I'm sure efried would have more to talk about here... maybe we come back to it when he shows up | 13:09 |
| edmondsw | next topic? | 13:09 |
| esberglu | Yep | 13:09 |
| esberglu | #topic Out of Tree Driver | 13:09 |
| *** mdrabe has joined #openstack-powervm | 13:09 | |
| esberglu | Not sure how much activity has been going on here, I've been mostly on CI the last handful of days | 13:10 |
| efried | Sorry, previous "meeting" ran over. | 13:10 |
| edmondsw | I've got a change out for pypowervm, 5421, that could use some reviews | 13:10 |
| esberglu | efried: np. You have anything you want to talk in tree quick before we move to out of tree? | 13:10 |
| edmondsw | I guess that's as much IT as OOT, or not really either | 13:11 |
| efried | What's the prognosis for hypervisors devref? | 13:11 |
| esberglu | I was gonna start that in the background today while I try to get stacks working | 13:12 |
| efried | Cool cool. | 13:12 |
| efried | I'll be interested to see where that ends up, and what it looks like. | 13:12 |
| efried | Do you have experience with RST? | 13:12 |
| esberglu | Nope but there are plenty of examples | 13:13 |
| efried | Yup; remind me when you get started and I'll show you a couple of tricks for rendering so you can test it out and make sure it's a) valid, and b) doing what you want. | 13:14 |
| esberglu | efried: Ok sounds good | 13:14 |
| edmondsw | I'll have to get you to show me those tricks as well... or better yet, someone should make sure they're documented somewhere and just link :) | 13:14 |
| edmondsw | I know how to see things once they're in gerrit, but not before | 13:15 |
| efried | Yeah, that's the most reliable one, since that's how it's actually going to be rendered. | 13:15 |
| efried | The other one is to use rst2html.py | 13:15 |
| edmondsw | esberglu once it's up in gerrit, just click the docs gate link | 13:16 |
| efried | right | 13:16 |
| esberglu | Easy enough | 13:16 |
| efried | But come to think of it, I'm sure there's a way to do that docs build locally. Probably tox -e docs in fact. | 13:16 |
| edmondsw | hmm... yeah, probably | 13:16 |
| efried | Anyway, moving on. | 13:17 |
| efried | Otherwise, I don't have anything specifically PowerVM in tree. Unless we want to start looking ahead to queens. | 13:17 |
| edmondsw | are you going to tackle some of those minor cleanup things before or after starting on queens stuff like network, config_drive, etc.? | 13:18 |
| efried | Before would be better. | 13:18 |
| edmondsw | that's what I was thinking, since it'll be a while before we can merge for queens | 13:18 |
| efried | Yeah, I don't think those have an owner yet. | 13:19 |
| edmondsw | they don't | 13:19 |
| *** mdrabe has quit IRC | 13:19 | |
| edmondsw | might be good stuff for esberglu | 13:19 |
| edmondsw | get his feet wetter :) | 13:19 |
| efried | btw, is mdrabe invited to these? | 13:20 |
| esberglu | edmondsw: Sure I can take a stab at it. I'll start looking through those patches again, been a while | 13:20 |
| edmondsw | we can all pick those off as able | 13:20 |
| esberglu | efried: Yeah | 13:20 |
| edmondsw | esberglu +1 | 13:20 |
| edmondsw | I thought mdrabe was invited, but let me check | 13:20 |
| esberglu | edmondsw: Yeah he is | 13:20 |
| *** mdrabe has joined #openstack-powervm | 13:20 | |
| esberglu | Alright are we ready to move to OOT? | 13:20 |
| edmondsw | esberglu hmm... I was going to say I don't see him on the invite I have, but you may have added him later | 13:21 |
| edmondsw | and mdrabe is here! | 13:21 |
| efried | Oh, esberglu on the devref thing, note that we have some docs OOT. A lot of it won't be appropriate (like how to install and set up the OOT driver) but could be a good starting point. | 13:21 |
| edmondsw | speak of the devil... | 13:21 |
| mdrabe | Having some trouble with my client | 13:21 |
| edmondsw | no worries | 13:22 |
| efried | Yeah, so train of thought there was something like, in order for esberglu to get to those items, he needs some breathing room in the CI - and wasn't mdrabe going to be helping create said space - say, where's mdrabe, was he invited? | 13:22 |
| efried | Anyway, I think we're done talking about in-tree now. | 13:23 |
| esberglu | efried: Yeah I'm having him do his first deploy today | 13:23 |
| efried | Schweet. We can talk about it in the CI topic. | 13:23 |
| edmondsw | :) as I understand it, mdrabe is starting to learn there on CI, and I'm also hoping esberglu will have more space from getting these patches in that allow quicker CI changes without rebuilds | 13:23 |
| *** jwcroppe_ has quit IRC | 13:23 | |
| edmondsw | we're all over the place today... anything for OOT efried? | 13:23 |
| esberglu | edmondsw: That's the idea | 13:23 |
| edmondsw | since that's the topic we're supposedly in | 13:23 |
| edmondsw | ;) | 13:24 |
| efried | I think there's going to be a ripple OOT from the power-off changes. | 13:24 |
| efried | First we're going to have to cut a new pypowervm release, for that and the iscsi stuff. | 13:24 |
| edmondsw | yep | 13:25 |
| efried | Then propose it in g-r and let it percolate. Then chhavi's change will start to verify, and I can do the above. | 13:25 |
| edmondsw | I'd like to see 5421 also go into that pypowervm release | 13:25 |
| efried | right | 13:25 |
| efried | mdrabe Can you please review 5421? | 13:26 |
| mdrabe | yep | 13:26 |
| edmondsw | ty sir | 13:26 |
| efried | And thorst_afk if you're not too busy saving the world. | 13:26 |
| edmondsw | I think he's actually afk right now | 13:26 |
| edmondsw | he likes to keep us guessing, though ;) | 13:26 |
| efried | Yeah, but he'll see this eventually. | 13:26 |
| edmondsw | yep | 13:26 |
| esberglu | Ready to move to CI? | 13:28 |
| edmondsw | backports from IT to OOT on the TODO list is another thing that anyone can dip into as they have time and could be good learning material for some of us newer guys | 13:28 |
| efried | So OOT will also be impacted eventually by edmondsw auto-disable ... | 13:28 |
| efried | yeah, what he said. | 13:28 |
| edmondsw | yep | 13:28 |
| edmondsw | efried I'd like to get the common changes in, then do you think the auto-disable for pypowervm should go IT or OOT first? | 13:29 |
| edmondsw | I think we said IT first? | 13:29 |
| efried | That was the plan, though I'm not sure there's a solid reason why. | 13:29 |
| edmondsw | we'll stick with it for now anyway | 13:29 |
| edmondsw | done with OOT? | 13:29 |
| edmondsw | #topic CI | 13:30 |
| esberglu | #link https://etherpad.openstack.org/p/powervm_ci_todos | 13:30 |
| esberglu | The external prep_devstack change is in | 13:31 |
| esberglu | And the branch specific local.conf files change is ready, just need reviews | 13:31 |
| esberglu | 5425 | 13:31 |
| edmondsw | esberglu you want to give us a quick status update, what's working / failing? | 13:31 |
| edmondsw | I pulled up 5425 right before this meeting started, will get back to it when we're done | 13:32 |
| esberglu | Ocata was working yesterday with the local.conf file in that latest patch | 13:32 |
| esberglu | newton, master (IT and OOT) were both failing | 13:32 |
| edmondsw | I thought we were getting master working first | 13:32 |
| esberglu | edmondsw: I just had them running in the background to test the branch specific patches on staging | 13:33 |
| esberglu | I was working through master devstack issues all day yesterday | 13:33 |
| esberglu | It was a real rabbithole | 13:33 |
| esberglu | That's what I'm planning on doing today too | 13:34 |
| edmondsw | esberglu the idea to go ahead and merge 5425 since it doesn't make anything worse (pending review, of course) and then fix each branch individually? | 13:34 |
| esberglu | edmondsw: Yeah | 13:34 |
| esberglu | With priority being OOT master, IT master, OOT stable branches | 13:35 |
| edmondsw | +1 | 13:35 |
| efried | Once you get stuff stacking, please send a note to Jay. | 13:35 |
| efried | And the rest of us, for that matter, since we'll be impacted next time we try to stack too. | 13:35 |
| esberglu | But with how long stacking takes I'm going to try to get them working simultaneously at least somewhat | 13:35 |
| esberglu | efried: Yep | 13:36 |
| esberglu | Other than that just tackling the list of TODOs as I am able. Hoping to get mdrabe more involved now that some of his other work has settled down (I think?) | 13:36 |
| *** jwcroppe has joined #openstack-powervm | 13:37 | |
| esberglu | #topic Driver Testing | 13:38 |
| esberglu | I know jay is being blocked by the stacking issues | 13:38 |
| efried | yup | 13:38 |
| esberglu | Anything else going on there? | 13:38 |
| efried | Actually, he also ran into a nvl dependencies problem. | 13:38 |
| edmondsw | oh? | 13:38 |
| edmondsw | anything to worry about? | 13:39 |
| efried | Hopefully he asked the right people in slack and got that figured out. | 13:39 |
| edmondsw | k | 13:39 |
| efried | He might've caught the repo in a weird state or something. | 13:39 |
| edmondsw | chhavi did you see my comments on https://review.openstack.org/#/c/467599/ ? | 13:40 |
| edmondsw | efried that is now backward compatible with existing pypowervm versions, so it doesn't have to wait for the pypowervm release, right? | 13:41 |
| efried | oh, right, we were gonna do that. I'll have to look again. | 13:42 |
| edmondsw | yep, Jenkins passed | 13:42 |
| efried | But the new code path still won't work without an updated pvm-novalink | 13:42 |
| efried | Need to think through that a bit... | 13:42 |
| edmondsw | you mean when we enable more tests? | 13:43 |
| efried | Well, that's what needs thought. | 13:43 |
| edmondsw | that's probably in queens, right? | 13:43 |
| edmondsw | s/probably// | 13:44 |
| efried | No. If we're relying on some new REST behavior via this code, we may get 500s when it runs. | 13:44 |
| edmondsw | at least for IT | 13:44 |
| edmondsw | yeah, OOT is another story | 13:44 |
| efried | Yes, for IT, queens or later. I'm talking about OOT+pypowervm+pvm-nvl interplay. | 13:44 |
| edmondsw | +1 | 13:45 |
| edmondsw | too easy to get confused with this matrix of possibilities :) | 13:45 |
| efried | Totally. Anyway, I'll re-review that change with that in mind. | 13:45 |
| edmondsw | tx | 13:45 |
| edmondsw | move on to open discussion? | 13:46 |
| esberglu | #topic Open Discussion | 13:46 |
| efried | The service tokens changes have merged. I think mriedem is closing the blueprint. | 13:46 |
| esberglu | I was thinking I would create another etherpad with an agenda for this meeting | 13:46 |
| efried | +1 | 13:46 |
| esberglu | With the idea being it will go faster and people can bring stuff up even if they can't make it | 13:46 |
| edmondsw | efried awesome | 13:46 |
| esberglu | efried: Nice | 13:47 |
| edmondsw | esberglu +1 | 13:47 |
| efried | esberglu --strict also merged in ocata, in case you were looking to use that. | 13:47 |
| esberglu | efried: We don't need to do the discover_hosts thing in ocata | 13:47 |
| esberglu | Well in the undercloud we do | 13:48 |
| efried | okay. | 13:48 |
| edmondsw | efried I don't think I ever reviewed the final service tokens change... have a link? | 13:48 |
| edmondsw | would like to give it a quick glance and see where it ende dup | 13:48 |
| efried | https://review.openstack.org/412634 https://review.openstack.org/419662 | 13:48 |
| efried | a glance indeed. | 13:48 |
| edmondsw | :) | 13:49 |
| efried | As I mentioned yesterday, I really didn't do anything on these - just kept rebasing until they went green. | 13:49 |
| efried | Biggest piece of work was chasing down the glanceclient bugs. | 13:49 |
| edmondsw | I'm not actually on either of those reviews | 13:50 |
| edmondsw | didn't you have one up at one point? What happened to that? | 13:50 |
| efried | You're thinking of the service URLs bp | 13:50 |
| efried | That one's still in limbo pending mordred's infra support for it. | 13:51 |
| edmondsw | https://review.openstack.org/#/c/458257/ | 13:51 |
| edmondsw | yeah, I was getting confused | 13:51 |
| efried | Yeah, sorry, I didn't think to add you to the service tokens reviews. | 13:52 |
| efried | I know we talked about you being more involved, but then I didn't end up actually having to do much. | 13:52 |
| edmondsw | s'ok | 13:53 |
| edmondsw | very glad to have that in | 13:53 |
| edmondsw | anything else guys? | 13:53 |
| efried | power-off changes, I should mention. | 13:53 |
| edmondsw | yeah, what's your plan for the separate changeset for my #3? | 13:54 |
| edmondsw | able to get that up this week? | 13:54 |
| efried | Should be able to, yeah. | 13:54 |
| edmondsw | would be nice to get that in the new pypowervm release along with the other things | 13:54 |
| efried | I'm going to introduce a new method power_off_progressive | 13:54 |
| edmondsw | +1 | 13:54 |
| efried | The only bit I'm still not sure about is how to specify options. | 13:55 |
| efried | Should be via a PowerOffOpts | 13:55 |
| efried | But I should validate that guy. | 13:55 |
| edmondsw | isn't the current progressive logic hardcoded, doesn't really use any options? | 13:55 |
| efried | Cause it should NOT have an operation set. | 13:55 |
| edmondsw | i.e. do you even need to let the caller specify anything? | 13:56 |
| efried | At least restart. But there's others as well I believe. | 13:56 |
| edmondsw | yeah, probably restart... can't think what else | 13:56 |
| edmondsw | would have to look again | 13:57 |
| efried | Nope, you're right, just restart. | 13:57 |
| efried | Soooo.... | 13:57 |
| efried | Maybe progressive doesn't take a PowerOffOpts at all. | 13:57 |
| efried | Just takes a restart kwarg | 13:57 |
| efried | Which feels painful because we jumped through hoops to get rid of the restart kwarg in the existing power_off | 13:57 |
| efried | And it paints us into that same corner in case we somehow need to add more opts in the future. | 13:58 |
| efried | So yeah, still need to think about this some more. | 13:58 |
| edmondsw | k | 13:59 |
| efried | Then there's the weird translation bug. | 13:59 |
| efried | btang and I discussed it some yesterday, and got it figured out, I think. | 13:59 |
| edmondsw | awesome | 14:00 |
| efried | We believe the problem is that the i18n test case is setting a locale directory globally, which it shouldn't. Depending what order the tests run, that can cause problems. | 14:00 |
| efried | So I'm going to try to nail that down in the next day or two. | 14:01 |
| efried | One more minor pypowervm thing I want to mention. | 14:01 |
| efried | We have a couple of tests that run over code that sleep()s, but the tests aren't mocking sleep(), so the tests actually take a relatively long time. | 14:01 |
| efried | Easy to see which - just look at the longest-running-tests report at the end of a tox run. | 14:01 |
| edmondsw | ooo... good catch | 14:01 |
| efried | So if someone wants to pick those off and fix 'em... | 14:02 |
| efried | Let the team know so we don't overlap. | 14:02 |
| edmondsw | sounds like we need another TODO etherpad for pypowervm | 14:02 |
| efried | This is an unusual little glut, really. | 14:03 |
| efried | We've normally got one thing at a time, directly driven by some other piece of work. | 14:03 |
| edmondsw | k | 14:03 |
| efried | But yeah, at the moment it wouldn't be bad to keep track somewhere other than my head. | 14:03 |
| edmondsw | yeah... | 14:03 |
| efried | But an openstack etherpad isn't really appropriate. | 14:04 |
| edmondsw | no | 14:04 |
| efried | Unless we bury it in the one we've got. | 14:04 |
| efried | Can we get an etherpad server set up internally? | 14:04 |
| efried | Cause I suuuuure do hate community wiki | 14:04 |
| efried | or is it called connections? | 14:04 |
| edmondsw | whatever it's called, I agree that etherpad is way better | 14:05 |
| edmondsw | I'll see if i can figure out what our options are there | 14:05 |
| edmondsw | alright, we're over, and I think done... tx guys | 14:08 |
| efried | later y'all. | 14:08 |
| edmondsw | #endmeeting | 14:08 |
| openstack | Meeting ended Tue Jun 13 14:08:41 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:08 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/powervm_driver_meeting/2017/powervm_driver_meeting.2017-06-13-13.01.html | 14:08 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/powervm_driver_meeting/2017/powervm_driver_meeting.2017-06-13-13.01.txt | 14:08 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/powervm_driver_meeting/2017/powervm_driver_meeting.2017-06-13-13.01.log.html | 14:08 |
| *** mdrabe has quit IRC | 14:35 | |
| *** mdrabe has joined #openstack-powervm | 14:41 | |
| mdrabe | efried edmondsw 5421 +1 | 14:43 |
| edmondsw | mdrabe tx | 14:43 |
| *** tjakobs has joined #openstack-powervm | 14:55 | |
| esberglu | edmondsw: efried: I have working ocata and newton local.confs with a few basic cleanup things done | 15:21 |
| esberglu | I'm running them through tempest now | 15:21 |
| edmondsw | esberglu yay! | 15:22 |
| esberglu | But we can hold off on merging that patch until then | 15:22 |
| efried | sweet. What's the status with master? Is that already done? | 15:22 |
| esberglu | efried: Still stacking and unstacking | 15:22 |
| efried | k | 15:22 |
| *** dwayne has quit IRC | 16:17 | |
| *** chhavi has quit IRC | 17:25 | |
| *** dwayne has joined #openstack-powervm | 17:25 | |
| edmondsw | efried just pinged the nova cores about https://review.openstack.org/#/c/472794/ | 17:25 |
| efried | ack, thx | 17:26 |
| esberglu | Somebody said something about there being rules when it comes to adding reviewers to nova yesterday | 18:38 |
| esberglu | efried: was that you? And what were you referring to | 18:38 |
| *** k0da has quit IRC | 18:56 | |
| efried | esberglu Unwritten rules | 19:08 |
| efried | Rule #1: Don't. | 19:08 |
| efried | They're just supposed to notice. | 19:08 |
| efried | Unless you've specifically discussed a change with someone. | 19:09 |
| efried | esberglu What did you have in mind? | 19:09 |
| esberglu | efried: Was gonna ask yesterday and got distracted | 19:12 |
| efried | ask what? | 19:12 |
| esberglu | What the rules were | 19:20 |
| esberglu | Update on master stacking. I'm currently messing with the devstack tempest settings because the tempest tox is failing | 19:21 |
| esberglu | Right now we use a custom tempest.conf | 19:21 |
| esberglu | IIRC correctly the reason we did that and didn't use the devstack generated one was that there were limited conf options for tempest | 19:22 |
| esberglu | So we couldn't get it to do what we wanted | 19:22 |
| esberglu | I'm thinking the devstack generated tempest conf might have more functionality now | 19:22 |
| esberglu | And if it still doesn't, we could add that functionality to devstack instead | 19:22 |
| esberglu | of trying to keep a custom tempest.conf | 19:23 |
| efried | esberglu I didn't know it was even possible to have devstack generate a tempest.conf | 19:24 |
| efried | But shoot, if you can get that working, I'm down. | 19:24 |
| esberglu | efried: It does. It puts it in /opt/stack/tempest/etc/tempest.conf | 19:24 |
| esberglu | efried: The idea being that we won't have to maintain tempest.conf and we can also rip out of bunch of os_ci_tempest.sh | 19:25 |
| efried | edmondsw Alas, power_off_progressive still needs the option to decide whether to start with os-immediate or not. | 19:25 |
| efried | esberglu That sounds lovely. Do you get to feed options into tempest.conf via local.conf? | 19:26 |
| edmondsw | efried ok, where does that leave us? | 19:26 |
| efried | edmondsw I think it leaves us still needing to accept a PowerOffOpts param. | 19:26 |
| efried | And I need to decide how aggressively I want to forbid that guy from having an operation specified. | 19:26 |
| esberglu | efried: I'm checking right now if you can just use the [[post-config|$TEMPEST_CONF]] like you can for others | 19:27 |
| esberglu | efried: Otherwise you can use the settings found here | 19:27 |
| esberglu | https://github.com/openstack-dev/devstack/blob/master/lib/tempest | 19:27 |
| efried | edmondsw Ye gods, I don't know if this is going to be better or worse. | 19:29 |
| efried | I really need to separate out the operation somehow. | 19:30 |
| efried | PowerOffOper as a subclass of PowerOffOpts would be okay, but not backwards compatible. | 19:30 |
| edmondsw | why not just have restart and immediate args and no PowerOffOpts? | 19:31 |
| edmondsw | efried I don't see why PowerOffOpts would apply here | 19:31 |
| efried | edmondsw I need to support both 'immediate' and 'restart'. | 19:31 |
| edmondsw | right, that's what I said | 19:31 |
| efried | oh, sorry, missed :09 | 19:31 |
| efried | Yeah, could do that, but again, the whole reason we introduced Power*Opts was to consolidate those kwargs and provide a single extensible home for them in case we add more in the future. | 19:32 |
| efried | If we add more options to the Job in the future, we wind up with exactly the same problem as with power_off. | 19:33 |
| edmondsw | what more would we possibly add? | 19:33 |
| edmondsw | and why would adding really be a problem? | 19:34 |
| efried | Looking at it another way, the new power_off_progressive would have a nearly identical signature to the existing power_off. The distinction will be difficult to describe, and confusing for the consumer. | 19:34 |
| edmondsw | I thought the problem we fixed with PowerOffOpts was about the dict, not restart/force_immediate | 19:34 |
| efried | Well, I've wondered for a while now why we don't support the same options for reboot that we do for power-on. | 19:34 |
| efried | And if that becomes a thing, we're talking 8 additional kwargs. | 19:35 |
| efried | not acceptable | 19:35 |
| edmondsw | efried in that case, make the restart kwarg take a class of startup options | 19:35 |
| efried | ew ew ew ew ewwwww | 19:36 |
| edmondsw | ? | 19:36 |
| edmondsw | you like PowerOffOpts but not PowerOnOpts? | 19:37 |
| efried | We have PowerOnOpts. That's not the point. | 19:37 |
| efried | I don't like overloading arg types. | 19:37 |
| edmondsw | then don't | 19:37 |
| edmondsw | have PowerOnOpts instead of restart | 19:37 |
| edmondsw | if None, no restart | 19:37 |
| efried | And if an empty PowerOnOpts(), restart with no additional options? That's not the greatest UX. | 19:38 |
| edmondsw | why not? | 19:38 |
| efried | Especially since right now it would just be that, always empty - anything you put in there would be ignored. | 19:39 |
| edmondsw | why ignored? | 19:39 |
| efried | Because none of those things are supported for restart | 19:39 |
| efried | UX-wise, pvm_pwr.power_off(..., restart=True) is nicer than pvm_pwr.power_off(..., power_on_opts=pvm_pwr_opts.PowerOnOpts()) | 19:40 |
| edmondsw | but you think they should be, right? so make them... or is there some technical reason we can't do that yet? | 19:40 |
| efried | Nono, I don't think they should be, necessarily. Nobody seems to care to make them so, and I'm not going to open that can of worms. | 19:41 |
| efried | The technical reason is that the REST Job doesn't support it. | 19:41 |
| edmondsw | you can have restart and power_on_opts if you want to better the UX | 19:41 |
| efried | If you want to do that, you would have to power-off (without a restart) and then power-on with opts. | 19:41 |
| edmondsw | and if there's no need for power_on_opts today (which I think we just established) we don't worry about that | 19:42 |
| edmondsw | back to just restart | 19:42 |
| efried | Yeah, and immediate. | 19:42 |
| edmondsw | yep | 19:42 |
| edmondsw | 2 kwargs... not near the limit of 8 :) | 19:42 |
| efried | Which isn't a lot better than the existing power_off | 19:42 |
| edmondsw | no? | 19:43 |
| efried | The only improvement is the crispness of what 'immediate' means. And getting to remove the host_uuid param from the signature. | 19:43 |
| edmondsw | the existing power_off has those needed kwargs deprecated... so that's not an option | 19:43 |
| edmondsw | now, if we hadn't deprecated them... or maybe we run that back and un-deprecate? | 19:44 |
| efried | talking about add_parms being an arbitrary dict? | 19:44 |
| edmondsw | but the thing that's really better about power_off_progressive is the name... shows that it's unique to progressive | 19:44 |
| edmondsw | no, I wasn't talking about add_parms | 19:45 |
| efried | I'll propose it and see what you & thorst_afk think. | 19:47 |
| edmondsw | efried do you know a way to just run the UTs that relate to the powervm driver and not everything else? | 20:00 |
| efried | edmondsw After tox -e {envlist}, you can say -- followed by a pattern prefix that indicates which tests to run. | 20:01 |
| efried | e.g. tox -e py27 -- nova.tests.unit.virt.powervm | 20:01 |
| edmondsw | right... more specifically... ok, tx | 20:01 |
| edmondsw | so nova.tests.unit.virt.powervm is what I was looking for... at least I hope | 20:02 |
| edmondsw | efried no, that doesn't seem right... that would just run the tests in that directory. Aren't there common virt driver tests as well? | 20:03 |
| efried | hold please | 20:04 |
| edmondsw | actually, maybe not... that's probably just me thinking like a keystone dev... | 20:05 |
| edmondsw | keystone have a bunch of tests that they will run against all possible drivers, but maybe nova doesn't do that | 20:06 |
| efried | Sorry, on a call. | 20:06 |
| edmondsw | np | 20:06 |
| edmondsw | answer when you can | 20:06 |
| efried | edmondsw I don't know of any UT outside of the powervm package that run against the powervm driver. | 20:07 |
| efried | Doesn't mean it doesn't exist. | 20:07 |
| efried | But I would be pretty surprised. | 20:07 |
| edmondsw | k, I'm not seeing any, so you're probably right | 20:07 |
| edmondsw | they probably consider that outside the scope of UT... which I would agree with | 20:07 |
| efried | Well, I think the argument would be that anything *unit* testing powervm should run under that directory. | 20:08 |
| efried | Functional tests are different. | 20:08 |
| edmondsw | yep, hence my agreement | 20:08 |
| edmondsw | keystone just doesn't work that way (unfortunately), and I was thinking in line with what I was familiar with there | 20:09 |
| *** smatzek has quit IRC | 20:48 | |
| *** edmondsw has quit IRC | 21:09 | |
| *** edmondsw has joined #openstack-powervm | 21:09 | |
| *** edmondsw_ has joined #openstack-powervm | 21:12 | |
| *** edmondsw has quit IRC | 21:13 | |
| *** thorst_afk has quit IRC | 21:16 | |
| *** edmondsw_ has quit IRC | 21:16 | |
| *** thorst_afk has joined #openstack-powervm | 21:19 | |
| *** thorst_afk has quit IRC | 21:23 | |
| efried | esberglu Please see mriedem comments and followup actions on https://review.openstack.org/#/c/470999/ | 21:24 |
| esberglu | efried: ack | 21:40 |
| *** thorst_afk has joined #openstack-powervm | 21:43 | |
| *** thorst_afk has quit IRC | 21:48 | |
| *** edmondsw has joined #openstack-powervm | 21:50 | |
| efried | esberglu Still bouncing off of neutron_plugin_create_nova_conf in-tree master? | 21:54 |
| esberglu | efried: Yeah but still not a working stack | 21:54 |
| esberglu | I'm trying to get the devstack generated tempest.conf working now | 21:54 |
| efried | esberglu But I'm seeing stacking fail still. | 21:54 |
| *** edmondsw has quit IRC | 21:55 | |
| esberglu | efried: Yeah I don't have working stacks yet | 21:55 |
| efried | okay. | 21:55 |
| esberglu | That's how I came upon this whole devstack generated tempest.conf thing | 21:55 |
| esberglu | The tempest install was failing | 21:55 |
| esberglu | Well not the tempest install but the tempest conf verification | 21:55 |
| *** jpasqualetto has quit IRC | 21:59 | |
| *** mdrabe has quit IRC | 22:03 | |
| *** esberglu has quit IRC | 22:07 | |
| *** esberglu has joined #openstack-powervm | 22:08 | |
| *** esberglu has quit IRC | 22:12 | |
| *** thorst_afk has joined #openstack-powervm | 22:27 | |
| *** thorst_afk has quit IRC | 22:28 | |
| *** esberglu has joined #openstack-powervm | 22:31 | |
| *** tjakobs has quit IRC | 22:32 | |
| *** esberglu has quit IRC | 22:36 | |
| *** thorst_afk has joined #openstack-powervm | 22:50 | |
| *** thorst_afk has quit IRC | 22:59 | |
| *** thorst_afk has joined #openstack-powervm | 23:00 | |
| *** thorst_afk has quit IRC | 23:04 | |
| *** jwcroppe has quit IRC | 23:20 | |
| *** thorst_afk has joined #openstack-powervm | 23:31 | |
| *** jwcroppe has joined #openstack-powervm | 23:33 | |
| *** thorst_afk has quit IRC | 23:37 | |
| *** jwcroppe has quit IRC | 23:38 | |
| *** jwcroppe has joined #openstack-powervm | 23:42 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!