| *** AlexeyAbashkin has joined #openstack-powervm | 00:18 | |
| *** AlexeyAbashkin has quit IRC | 00:22 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 01:18 | |
| *** AlexeyAbashkin has quit IRC | 01:22 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 02:18 | |
| *** AlexeyAbashkin has quit IRC | 02:23 | |
| *** chhagarw has joined #openstack-powervm | 04:40 | |
| *** chhagarw has quit IRC | 04:53 | |
| *** chhagarw has joined #openstack-powervm | 05:19 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 07:55 | |
| *** k0da has joined #openstack-powervm | 08:43 | |
| *** efried has quit IRC | 12:23 | |
| *** efried has joined #openstack-powervm | 12:24 | |
| *** edmondsw has joined #openstack-powervm | 12:40 | |
| *** tjakobs has joined #openstack-powervm | 13:27 | |
| efried | edmondsw: I'm afraid this is not good news for us. | 13:52 |
|---|---|---|
| edmondsw | yeah | 13:52 |
| edmondsw | trying to do 2 things at once and doing neither well | 14:09 |
| edmondsw | efried that should address what we need, no? | 14:17 |
| efried | edmondsw: Sorry, I quit following. Catching up... | 14:17 |
| edmondsw | not loving that it's placement API vs. nova API, but... | 14:17 |
| *** esberglu has joined #openstack-powervm | 14:19 | |
| efried | Okay, I'm caught up. | 14:21 |
| efried | Yeah, I knew we could get all the info from placement. There were a couple reasons that wasn't ideal. | 14:21 |
| efried | First being that I thought we weren't gonna use placement initially. | 14:21 |
| efried | Second being that all the information will be... placementified. So pvc will need to be able to map it back into reality. | 14:22 |
| efried | E.g. location codes will be slugified and need to be mapped back to real loc codes. Descriptions will simply be absent and will need to be looked up. Etc. | 14:22 |
| edmondsw | looked up how? | 14:23 |
| efried | In our yaml file or whatever. | 14:23 |
| edmondsw | which negates the possibility of using the description as a fallback when there isn't an entry in yaml | 14:23 |
| efried | Unless we populate the defaults in the yaml at install time based on the descriptions from the driver. | 14:24 |
| edmondsw | true | 14:24 |
| efried | I mean, I'm assuming we're going through this whole song and dance because we don't want to have to ask the nvl REST API questions at runtime. | 14:24 |
| efried | Cause if we could do that, we'd be set. We wouldn't need placement or anything. | 14:24 |
| edmondsw | if by we you mean a customer, yeah, customers shouldn't be talking to NovaLink's REST API diretcly | 14:25 |
| edmondsw | and you can consider GUI and customer to be the same thing there | 14:25 |
| efried | The GUI wants to talk to the nova API, yah? | 14:26 |
| efried | and/or the pvc database? | 14:26 |
| edmondsw | never the latter | 14:26 |
| edmondsw | only APIs | 14:26 |
| efried | But nova API, not nvl API. | 14:27 |
| edmondsw | placement API could be done there, but not NovaLink | 14:27 |
| efried | okay. I still don't really understand why not. Is it because the nvl API isn't (set up for) remote? | 14:27 |
| edmondsw | that's definitely one reason | 14:27 |
| efried | pvc runs where the n-api service runs, not where n-cpu runs, kind of thing | 14:27 |
| edmondsw | another is that the GUI has to talk to one ip/hostname | 14:27 |
| edmondsw | that's the way browsers work | 14:28 |
| efried | Oh, it's all client side? | 14:28 |
| edmondsw | huh? | 14:28 |
| edmondsw | oh, yeah... the PowerVC GUI runs in the browser | 14:28 |
| efried | The GUI comm code is driven from client side, as opposed to server talking to APIs and then presenting "static" pages. Yeah. | 14:28 |
| edmondsw | yep | 14:29 |
| edmondsw | unlike horizon in that respect, I believe | 14:29 |
| efried | I'm skeptical about the statement that a browser can't talk to multiple IPs, but won't debate it. | 14:29 |
| edmondsw | https://developer.mozilla.org/en-US/docs/Web/Security/Same-origin_policy | 14:30 |
| efried | Frames, baby | 14:32 |
| efried | (kidding) | 14:32 |
| edmondsw | :) | 14:32 |
| efried | So we would have to write an orchestrator that proxies comm to multiple nvls. I'm sure that's been discussed and vetoed. | 14:33 |
| edmondsw | so even if we're not using placement for scheduling, we'll have to update allocations if we want to be able to query them | 14:33 |
| edmondsw | I don't know that writing such an orchestrator has ever been discussed, but I expect it would be vetoed for multiple reasons | 14:34 |
| efried | We still never officially closed the books on remotable pypowervm, afaik. | 14:34 |
| efried | We have "customers" using it, tho. | 14:34 |
| edmondsw | esberglu you probably saw that https://review.openstack.org/#/c/474825/ was abandoned | 15:20 |
| edmondsw | we have a TODO in our devstack local.conf files related to that | 15:20 |
| edmondsw | though I don't see a corresponding note in our ci_todo etherpad... am I overlooking it? | 15:21 |
| esberglu | edmondsw: There's one in the in-tree todos | 15:21 |
| edmondsw | hmm... doesn't this only affect CI? | 15:23 |
| esberglu | I can move it over, makes more sense with CI | 15:23 |
| edmondsw | yeah | 15:23 |
| edmondsw | I did a little digging and found that the merge failures are because they reorganized things: https://github.com/openstack-dev/devstack/commit/d8bb220606737719bcdf7c5b4f54906f2974c71c | 15:24 |
| edmondsw | if we want to repropose it would be more like https://review.openstack.org/#/c/507068/ | 15:24 |
| edmondsw | maybe just propose that they move to the latest, which adds both ppc64 and arm64 | 15:25 |
| esberglu | edmondsw: Yeah I can propose something this week | 15:25 |
| edmondsw | cool | 15:25 |
| *** efried is now known as efried_rollin | 16:01 | |
| esberglu | edmondsw: https://review.openstack.org/#/c/554977/ for etcd upgrade | 16:13 |
| esberglu | Is devstack the same as nova where you aren't supposed to add reviewers | 16:13 |
| *** AlexeyAbashkin has quit IRC | 16:29 | |
| *** k0da has quit IRC | 16:37 | |
| edmondsw | not sure | 16:58 |
| edmondsw | that's a somewhat general thing, unless you know someone doesn't mind or will be interested | 16:59 |
| edmondsw | tonyb you may be interested in that etc commit, which supersedes your old one that just got abandoned | 17:02 |
| edmondsw | etcd* | 17:02 |
| edmondsw | esberglu got a few minutes? | 17:34 |
| *** toan has quit IRC | 17:37 | |
| *** adi_____ has quit IRC | 17:39 | |
| *** adi_____ has joined #openstack-powervm | 17:40 | |
| *** toan has joined #openstack-powervm | 17:41 | |
| *** openstackgerrit has joined #openstack-powervm | 17:45 | |
| openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: Use vios_uuids property to process required vioses for iSCSI https://review.openstack.org/555003 | 17:45 |
| chhagarw | tjakobs,edmondsw: want to discuss on the proposed changes in review https://review.openstack.org/555003 | 17:46 |
| edmondsw | pulling it up | 17:46 |
| chhagarw | this change is to introduce vios_uuids property for processing iSCSI connects | 17:46 |
| edmondsw | chhagarw what is the impetus behind this? | 17:48 |
| chhagarw | As per the current behavior it pulls all the VIOS's and runs connect volume. In a scenario where user would like to use only the active vioses or filter this change is required, so it can process only them rather running discovery on all | 17:50 |
| chhagarw | We are using the similar behavior for fileio and rbd volume driver | 17:50 |
| edmondsw | chhagarw what qualifies as a "user" in this case? | 17:53 |
| chhagarw | administrator who want to configure vioses which can be used for iSCSI connectivity | 17:55 |
| edmondsw | I'm not seeing how this gives user a way to control anything | 17:55 |
| edmondsw | _connect_volume_to_vio isn't called by a user, nor do I see a way for a user to control when that is called and for what vios | 17:56 |
| tjakobs | what determines if a vios is "active"? | 17:57 |
| edmondsw | so unless I'm missing something, you're not giving a user control, you're just changing the behavior across the board | 17:57 |
| tjakobs | also, is there any reason this should/shouldn't also be put in the vscsi.py case | 17:57 |
| chhagarw | vios_uuids is a property which is the list of active vioses | 17:57 |
| chhagarw | which can be used to host storage | 17:57 |
| chhagarw | https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/volume/driver.py#L118 | 17:58 |
| chhagarw | tjakobs: ideally this should be put for vscsi as well, but I am not sure why its not there. | 17:59 |
| edmondsw | tjakobs https://github.com/powervm/pypowervm/blob/master/pypowervm/tasks/partition.py#L110 | 17:59 |
| edmondsw | "Active is defined by powered on and RMC state being 'active'." | 18:00 |
| edmondsw | chhagarw what is the downside to the current code? | 18:01 |
| edmondsw | performance? | 18:01 |
| *** AlexeyAbashkin has joined #openstack-powervm | 18:03 | |
| tjakobs | sounds like this change was "planned". Seems to the "future changeset" of https://review.openstack.org/#/c/460723/ | 18:03 |
| chhagarw | existing code works, but having this change will avoid unnecessary calls for vios where we know the discoveyr will fail | 18:03 |
| tjakobs | I can't think of any reason not to do this. | 18:06 |
| edmondsw | wouldn't we have race conditions with get_active_vioses? | 18:08 |
| edmondsw | maybe that's ok... we just log warnings if we fail to connect | 18:16 |
| *** chhagarw has quit IRC | 18:17 | |
| edmondsw | chhagarw added my review. You also have a pep8 issue | 18:19 |
| *** AlexeyAbashkin has quit IRC | 18:21 | |
| esberglu | edmondsw: What's up? | 18:22 |
| edmondsw | chhagarw added some more comments in the commit message as well | 18:25 |
| edmondsw | esberglu hey... wanted to talk about IT work | 18:25 |
| esberglu | edmondsw: Sure | 18:25 |
| edmondsw | did you see the IRC chat we had with the nova guys yesterday about that? | 18:26 |
| esberglu | The spec-less stuff? | 18:26 |
| edmondsw | yeah... they want us to forgo a spec and use different specless bp for each feature | 18:26 |
| edmondsw | so I abandoned the spec commit | 18:26 |
| edmondsw | about to mark the existing bp "obsolete"... that seems like the best option | 18:27 |
| edmondsw | we'll need to open, and then get approved, separate blueprints for each thing we want to get in | 18:27 |
| edmondsw | and then update each commit to point to the corresponding new bp | 18:27 |
| edmondsw | you good doing that? | 18:28 |
| esberglu | okay | 18:28 |
| esberglu | Yep | 18:28 |
| edmondsw | cool | 18:28 |
| edmondsw | esberglu drop the list of bps in the IT todo etherpad, and then add them to the next meeting agenda's Open Discussion section | 18:29 |
| edmondsw | https://wiki.openstack.org/wiki/Meetings/Nova | 18:29 |
| edmondsw | and then you or I need to make sure we're there to discuss | 18:29 |
| edmondsw | next mtg is tomorrow morning, so would be nice to have at least some if not all of them ready to discuss there | 18:30 |
| esberglu | edmondsw: Sure I can do that | 18:30 |
| edmondsw | tx | 18:30 |
| edmondsw | I should be able to make the mtg tomorrow, but would be good if you're there as well | 18:31 |
| esberglu | edmondsw: Yep I'll be there | 18:31 |
| edmondsw | esberglu unrelated (and much lower priority) but I noticed that the etcd change failed zuul pretty hard | 18:32 |
| esberglu | edmondsw: Yeah I saw that too, haven't had a chance to debug | 18:33 |
| esberglu | I need to make sure it doesn't bust our CI either | 18:33 |
| edmondsw | yep | 18:33 |
| edmondsw | esberglu http://logs.openstack.org/77/554977/1/check/tempest-full-py3/34d85ef/job-output.txt.gz#_2018-03-21_16_49_50_404595 | 18:34 |
| edmondsw | I think it's just that that new version isn't staged on tarballs.openstack.org | 18:34 |
| esberglu | edmondsw: Any idea what it would take to do that? | 18:35 |
| edmondsw | I think someone like tonyb can help you with that | 18:35 |
| edmondsw | dims, etc. | 18:35 |
| esberglu | cool tx | 18:36 |
| *** k0da has joined #openstack-powervm | 18:38 | |
| esberglu | edmondsw: Does your capabilities change need a bp? | 18:54 |
| edmondsw | I hope not... | 18:54 |
| edmondsw | if it does, we probably just wrap it up in one of the ones you open | 18:55 |
| edmondsw | esberglu here's some more info on specless bps: https://docs.openstack.org/nova/latest/contributor/blueprints.html | 18:59 |
| *** k0da has quit IRC | 19:16 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 19:17 | |
| *** AlexeyAbashkin has quit IRC | 19:21 | |
| *** k0da has joined #openstack-powervm | 19:29 | |
| *** efried_rollin is now known as efried | 19:37 | |
| *** tjakobs has quit IRC | 20:04 | |
| *** tjakobs has joined #openstack-powervm | 20:05 | |
| mdrabe | efried, edmondsw: Does https://review.openstack.org/#/c/549411/ break OOT? | 20:08 |
| edmondsw | mdrabe yup... | 20:10 |
| edmondsw | I'll sling a patch | 20:11 |
| mdrabe | tyvm | 20:11 |
| *** AlexeyAbashkin has joined #openstack-powervm | 20:18 | |
| openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm master: Pass user context to virt driver when detaching volume https://review.openstack.org/555038 | 20:20 |
| *** AlexeyAbashkin has quit IRC | 20:22 | |
| efried | edmondsw: no se necessite unit tests? | 20:23 |
| edmondsw | yeah, already caught that | 20:23 |
| edmondsw | too quick | 20:23 |
| edmondsw | efried you catch that, but don't reply to the comment I directed to you in slack :) | 20:24 |
| efried | where? | 20:24 |
| edmondsw | #novalink | 20:24 |
| edmondsw | s'ok I can butt out of that convo | 20:25 |
| efried | oh, I didn't think a response was warranted. You're right. No argument. | 20:25 |
| efried | And it's what I'm hoping to get down to, if we ever get to the bottom of this. | 20:25 |
| edmondsw | I just hate inconsistency | 20:25 |
| edmondsw | makes life hard | 20:25 |
| edmondsw | repeatedly | 20:25 |
| efried | Well, in this case we've been taking advantage of a rather weird REST behavioral quirk. Basically REST is being way nicer to us than it needs to be. But - they can't just go RBB on us. | 20:26 |
| edmondsw | efried yeah, I don't disagree with doing better on our end... but that doesn't excuse them doing better on their end too | 20:27 |
| edmondsw | anyway, nuf said | 20:27 |
| openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm master: Pass user context to virt driver when detaching volume https://review.openstack.org/555038 | 20:28 |
| edmondsw | mdrabe ^ | 20:29 |
| edmondsw | that is failing a totally unrelated UT locally... still trying to get to the bottom of that, but I'm hoping it's an env issue | 20:29 |
| esberglu | edmondsw: I already did ^ for IT, I wasn't even considering OOT at the time, should have caught that | 20:30 |
| edmondsw | np | 20:30 |
| *** k0da has quit IRC | 20:30 | |
| esberglu | edmondsw: bps are up through cold migration, I kept the descriptions super basic but I think that's fine since they | 20:31 |
| esberglu | are pretty striaghtforward | 20:31 |
| edmondsw | esberglu great, will look in a minute | 20:32 |
| *** k0da has joined #openstack-powervm | 20:33 | |
| edmondsw | yeah, my local UT issue was env... tox recreate fixed it, UT working now | 20:33 |
| edmondsw | wow, they actually backported that to queens! | 20:34 |
| edmondsw | I guess that's why you noticed mdrabe :) | 20:34 |
| mdrabe | Yep | 20:34 |
| openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm stable/queens: Pass user context to virt driver when detaching volume https://review.openstack.org/555042 | 20:37 |
| edmondsw | mdrabe ^ for queens | 20:38 |
| mdrabe | ty | 20:38 |
| tonyb | Yeah we're trying to fix that etcd thing. We discussed it in Denver and then I let it slide as it wasn't on anyone's critical path. | 20:49 |
| tonyb | Let me ping infra | 20:49 |
| tonyb | the good news is due to that dscussion it'll be fixed properly in bionic ... but we still need the rights tarball for xenial (and releases <=queens) | 20:50 |
| *** esberglu has quit IRC | 21:01 | |
| *** esberglu has joined #openstack-powervm | 21:14 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 21:17 | |
| *** AlexeyAbashkin has quit IRC | 21:21 | |
| efried | edmondsw: Suddenly pep8 is failing on our hacking checks? | 21:32 |
| edmondsw | efried where? | 21:33 |
| efried | edmondsw: https://review.openstack.org/#/c/555038/ | 21:33 |
| efried | and its cherry-pick | 21:33 |
| edmondsw | huh... worked locally... | 21:33 |
| efried | and worked until really, really recently. | 21:34 |
| efried | I'll propose a fix. | 21:34 |
| efried | which we'll need to backport. | 21:34 |
| edmondsw | tx | 21:34 |
| efried | and then rebase these on those. | 21:34 |
| edmondsw | if we can find what caused this, we'll know how far we need to backport | 21:35 |
| efried | Ie2aa1c4822d8adf721ba71d467b63209bede6fb7 | 21:35 |
| efried | The cherry-pick is actually failing two rules. | 21:35 |
| efried | one of them introduced by esberglu :P | 21:36 |
| efried | Actually... | 21:36 |
| efried | Both of the hacking checks in nova-powervm are in nova's hacking checks. We can remove them. | 21:36 |
| edmondsw | efried I only see that in master, so why would queens be failing? | 21:37 |
| edmondsw | oh diff failure? | 21:37 |
| *** tjakobs has quit IRC | 21:37 | |
| efried | Queens is failing on the same one (yield must be followed by a space) as well as an additional one (redundant import aliases) | 21:37 |
| edmondsw | no, same issue + the esberglu one | 21:38 |
| edmondsw | yeah | 21:38 |
| edmondsw | so... how, if those changes aren't in queens? | 21:38 |
| edmondsw | s/changes/rules/ | 21:38 |
| edmondsw | efried yeah, neither of those rules is in stable/queens | 21:40 |
| efried | Betting we forgot to update our req when queens was cut. So we're still pulling master nova in queens nova-powervm. | 21:40 |
| efried | checking... | 21:40 |
| efried | yup. https://github.com/openstack/nova-powervm/blob/stable/queens/tox.ini#L15 | 21:41 |
| edmondsw | doh | 21:41 |
| efried | so, multiple fixes otw. | 21:42 |
| esberglu | whoops | 21:42 |
| edmondsw | same problem in the other *-powervm projects | 21:43 |
| edmondsw | want me to fix those? | 21:43 |
| openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Remove custom hacking rules https://review.openstack.org/555068 | 21:43 |
| efried | I think once we're under governance, their bots will propose those changes for us. But yeah, until then, we have to do it ourselves. | 21:43 |
| efried | edmondsw: Sure, you wanna fix the tox.inis? | 21:44 |
| edmondsw | will do | 21:44 |
| efried | Meanwhile, the above will fix master. | 21:44 |
| openstackgerrit | Eric Fried proposed openstack/nova-powervm master: Pass user context to virt driver when detaching volume https://review.openstack.org/555038 | 21:45 |
| efried | rebased ^ on ---^ | 21:45 |
| edmondsw | tox recreates are so slow... | 21:48 |
| openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm stable/queens: tox needs to pull from stable/queens https://review.openstack.org/555073 | 21:57 |
| openstackgerrit | Matthew Edmonds proposed openstack/networking-powervm stable/queens: tox needs to pull from stable/queens https://review.openstack.org/555074 | 21:57 |
| openstackgerrit | Matthew Edmonds proposed openstack/ceilometer-powervm stable/queens: tox needs to pull from stable/queens https://review.openstack.org/555075 | 21:57 |
| edmondsw | efried esberglu ^ | 21:57 |
| esberglu | edmondsw: One comment | 22:01 |
| esberglu | on the nova-powervm one | 22:01 |
| openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm stable/queens: tox needs to pull from stable/queens https://review.openstack.org/555073 | 22:02 |
| edmondsw | esberglu ^ | 22:02 |
| esberglu | edmondsw: My bad it's actually stable/queens | 22:03 |
| edmondsw | oh, of course | 22:03 |
| esberglu | Was just amending my comment too but ya beat me to it ;) | 22:03 |
| openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm stable/queens: tox needs to pull from stable/queens https://review.openstack.org/555073 | 22:04 |
| edmondsw | esberglu ^ | 22:04 |
| edmondsw | and I checked the url in my browser this time :) | 22:04 |
| esberglu | edmondsw: I'll quick approve those as soon as zuul finishes | 22:10 |
| edmondsw | cool | 22:10 |
| openstackgerrit | Eric Fried proposed openstack/nova-powervm stable/queens: Pass user context to virt driver when detaching volume https://review.openstack.org/555042 | 22:11 |
| efried | rebased ^ on ---^ | 22:11 |
| openstackgerrit | Merged openstack/nova-powervm master: Remove custom hacking rules https://review.openstack.org/555068 | 22:21 |
| esberglu | efried: edmondsw: I'm going to redeploy the CI tonight. It's struggling right now. | 22:24 |
| efried | ight | 22:24 |
| edmondsw | ack | 22:25 |
| esberglu | The zuul queue got all backed up and the rabbitmq server on the undercloud died | 22:25 |
| esberglu | Anecdotal, but in the past those have been happening at the same time as pok network issues | 22:26 |
| efried | esberglu: Does CI rely on tox.ini? To set up the nova requirement or whatever? | 22:34 |
| efried | Wondering whether we need to bother waiting for CI to merge the tox.ini fixes. | 22:34 |
| efried | The networking-powervm tox.ini fix is ill. That policy.json thing is blocking us now. | 22:36 |
| efried | esberglu: We need to backport https://review.openstack.org/#/c/553459/ ? | 22:36 |
| esberglu | efried: We're good to skip CI on the tox.ini fixes | 22:38 |
| esberglu | neutron didn't get added to stable/queens requirements | 22:42 |
| esberglu | but yeah that looks like the same issue | 22:42 |
| esberglu | efried: I'll try to put together a fix tonight, gotta go offline for a bit now though | 22:50 |
| efried | ight | 22:50 |
| *** esberglu has quit IRC | 22:51 | |
| openstackgerrit | Merged openstack/nova-powervm stable/queens: tox needs to pull from stable/queens https://review.openstack.org/555073 | 22:55 |
| *** edmondsw has quit IRC | 23:07 | |
| *** k0da has quit IRC | 23:10 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!