| *** edmondsw has joined #openstack-powervm | 02:42 | |
| *** edmondsw has quit IRC | 02:49 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 03:17 | |
| *** AlexeyAbashkin has quit IRC | 03:21 | |
| *** edmondsw has joined #openstack-powervm | 04:05 | |
| *** edmondsw has quit IRC | 04:10 | |
| *** chhagarw has joined #openstack-powervm | 04:13 | |
| *** edmondsw has joined #openstack-powervm | 05:54 | |
| *** edmondsw has quit IRC | 05:59 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 06:16 | |
| *** AlexeyAbashkin has quit IRC | 06:21 | |
| *** adi_____ has quit IRC | 07:25 | |
| *** adi_____ has joined #openstack-powervm | 07:26 | |
| *** edmondsw has joined #openstack-powervm | 07:42 | |
| *** edmondsw has quit IRC | 07:46 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 07:56 | |
| *** AlexeyAbashkin has quit IRC | 08:17 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 08:18 | |
| *** arunman has joined #openstack-powervm | 09:02 | |
| *** edmondsw has joined #openstack-powervm | 09:30 | |
| *** edmondsw has quit IRC | 09:35 | |
| *** k0da has joined #openstack-powervm | 09:35 | |
| *** k0da has quit IRC | 10:26 | |
| *** AlexeyAbashkin has quit IRC | 11:00 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 11:00 | |
| *** edmondsw has joined #openstack-powervm | 12:15 | |
| *** esberglu has joined #openstack-powervm | 13:48 | |
| esberglu | efried: edmondsw: https://review.openstack.org/#/c/555074/ | 13:49 |
|---|---|---|
| esberglu | ^ That's passing for me locally | 13:49 |
| edmondsw | did you tox --recreate ? | 13:50 |
| esberglu | edmondsw: yeah | 13:50 |
| edmondsw | it doesn't really make sense to me why it would be failing for queens... | 13:50 |
| esberglu | edmondsw: Me neither | 13:56 |
| openstackgerrit | Arun Mani proposed openstack/nova-powervm master: Add affinity score check attribute to flavor https://review.openstack.org/555309 | 13:58 |
| edmondsw | esberglu nova mtg starting | 14:01 |
| esberglu | ack | 14:01 |
| *** k0da has joined #openstack-powervm | 14:03 | |
| *** arunman has quit IRC | 14:04 | |
| *** tjakobs has joined #openstack-powervm | 14:05 | |
| edmondsw | esberglu if you can address that one thing on the network hotplug patch, I can move that back to ready for wider review | 14:07 |
| *** tjakobs has quit IRC | 14:07 | |
| esberglu | edmondsw: done | 14:11 |
| edmondsw | tx | 14:12 |
| *** tjakobs has joined #openstack-powervm | 14:14 | |
| esberglu | edmondsw: I think the networking-powervm tox is failing because it is still using master neutron for some reason | 14:59 |
| esberglu | Why that's only happening for zuul and not local idk | 14:59 |
| edmondsw | I saw stable/queens specifically called out in one place there | 14:59 |
| edmondsw | doesn't mean it's not *also* pulling master... :( | 15:00 |
| edmondsw | http://logs.openstack.org/74/555074/1/check/openstack-tox-py27/51b41b0/job-output.txt.gz#_2018-03-22_02_29_27_738468 | 15:01 |
| *** arunman has joined #openstack-powervm | 15:08 | |
| *** arunman has quit IRC | 15:24 | |
| edmondsw | esberglu is the CI ok? still no votes on the commits I put up yesterday. | 15:29 |
| esberglu | recheck | 15:30 |
| edmondsw | k | 15:30 |
| edmondsw | just powervm:recheck, right? | 15:30 |
| esberglu | Yep | 15:30 |
| openstackgerrit | Merged openstack/ceilometer-powervm stable/queens: tox needs to pull from stable/queens https://review.openstack.org/555075 | 15:31 |
| openstackgerrit | Doug Hellmann proposed openstack/ceilometer-powervm master: add lower-constraints job https://review.openstack.org/555358 | 16:06 |
| *** tjakobs has quit IRC | 16:07 | |
| efried | uh oh, here they come. | 16:07 |
| *** tjakobs has joined #openstack-powervm | 16:08 | |
| esberglu | edmondsw: https://review.openstack.org/#/c/547169 keeps failing zuul but seems to be a zuul issue | 16:17 |
| esberglu | I'm just gonna keep rechecking | 16:17 |
| edmondsw | yay zuul... | 16:18 |
| edmondsw | tx | 16:18 |
| efried | There's something blocking zuul right now. Hold on, let me find it. | 16:19 |
| efried | edmondsw, esberglu: This one needs to merge to fix the gate: https://review.openstack.org/#/c/555314/ | 16:21 |
| esberglu | efried: ah tx for the info | 16:21 |
| *** AlexeyAbashkin has quit IRC | 16:34 | |
| openstackgerrit | Matthew Edmonds proposed openstack/networking-powervm stable/queens: tox needs to pull from stable/queens https://review.openstack.org/555074 | 16:35 |
| tjakobs | efried: do you know if there is a reason we can't just use the connection_info (BDM) during migration? It already has the udid saved from the connect_volume flow | 16:59 |
| tjakobs | https://review.openstack.org/#/c/530816/6/nova_powervm/virt/powervm/volume/fcpvvscsi.py@110 | 16:59 |
| *** k0da has quit IRC | 17:00 | |
| efried | tjakobs: I recently found out that the BDM is not the connection_info. | 17:07 |
| efried | the latter is a member of the former. | 17:07 |
| efried | That may not be remotely relevant to your question :) | 17:08 |
| efried | tjakobs: I'm gonna go out on a limb and say: since you're already planning to get set up to test all this live, try it :) | 17:09 |
| tjakobs | exactly what I wanted to hear... | 17:09 |
| efried | you're welcome. | 17:10 |
| *** arunman has joined #openstack-powervm | 17:11 | |
| *** esberglu_ has joined #openstack-powervm | 17:39 | |
| *** esberglu has quit IRC | 17:41 | |
| openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: Use vios_uuids property to process required vioses for iSCSI https://review.openstack.org/555003 | 17:42 |
| chhagarw | edmondsw: updated the changes with the UT. | 17:45 |
| *** arunman has quit IRC | 17:56 | |
| chhagarw | tjakobs,edmondsw: Why do we need a global lock while getting the iscsi initiator @lockutils.synchronized("PowerVM_iSCSI_Initiator_Lookup") | 17:58 |
| chhagarw | Currently only novalink mgmt partition acts as an initiator, but if vios also host iscsi, then they will have a separare initiator iqn | 18:01 |
| edmondsw | chhagarw looks like that needs to be cleaned up a bit... should only lock when it's actually doing discovery, not when it's just going to return something already been discovered | 18:04 |
| edmondsw | and will also need changes to support VIOS as initiator | 18:04 |
| edmondsw | traditional VIOS | 18:05 |
| chhagarw | edmondsw: This can be moved to the volume/iscsi.py to return the initiator | 18:06 |
| edmondsw | chhagarw volume/iscsi.py does seem like a better place for something that is iscsi-specific | 18:07 |
| chhagarw | lock based on the uuid | 18:07 |
| edmondsw | vios uuid, right? yes | 18:07 |
| chhagarw | yeah | 18:07 |
| chhagarw | I will have that change, can u have a look on the active vios_uuid one. | 18:08 |
| edmondsw | looking | 18:13 |
| *** AlexeyAbashkin has joined #openstack-powervm | 18:15 | |
| *** AlexeyAbashkin has quit IRC | 18:20 | |
| edmondsw | chhagarw comments posted... some new, some repeated from my previous comments | 18:38 |
| *** k0da has joined #openstack-powervm | 19:03 | |
| efried | edmondsw: We currently have the ability via extra_specs to specify shared vs dedicated procs, right? | 19:03 |
| edmondsw | yep https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/vm.py#L250 | 19:05 |
| edmondsw | there's also dedicated_sharing_mode and shared_proc_pool_name | 19:06 |
| edmondsw | shared_weight, etc. | 19:06 |
| esberglu_ | efried: I don't think there is a good way to just apply the snapshot CI patch to only the snapshot change | 19:11 |
| esberglu_ | I mean we could just check every change number and match against the snapshot change | 19:12 |
| efried | esberglu_: So what do you suggest? Wait until everything under it has merged, then enable snapshot? | 19:12 |
| esberglu_ | But applying the patch would require the internal gerrit link | 19:12 |
| efried | cause mriedem threatened to cock-block you if he doesn't see snapshot tests in the CI runs for the snapshot patch. | 19:12 |
| efried | And I'm not sure he was kidding. | 19:12 |
| esberglu_ | No he was serious | 19:12 |
| esberglu_ | But we don't know which patch we are testing until later in the CI flow (prep_devstack) so we can't have internal links | 19:13 |
| esberglu_ | I guess we could put a script that applies the snapshot CI patch into the snapshot we spawn from, then call that script from prep_devstack? | 19:14 |
| esberglu_ | Gross but could work | 19:14 |
| esberglu_ | Let me think about it a little bit. Cause mriedem also didn't like us applying outstanding patches to all nova CI runs | 19:16 |
| efried | esberglu_: It would be acceptable if you could somehow put up another patch that pulls in the snapshot patch and includes those tests. mriedem does that kind of shit all the time. | 19:18 |
| edmondsw | esberglu_ is there a way to run the tests without failures causing the CI to -1 ? | 19:18 |
| efried | Don't know that that helps us at all. | 19:18 |
| esberglu_ | edmondsw: Not sure what you mean? | 19:19 |
| edmondsw | something between skip and running them normally | 19:19 |
| edmondsw | run, but just report the results, don't consider when deciding whether the CI reports success|failure | 19:20 |
| edmondsw | seems like "experimental" tests would be a nice feature, but may not exist | 19:21 |
| esberglu_ | edmondsw: I think we would have to define a whole new CI pipeline for that | 19:21 |
| edmondsw | k | 19:22 |
| edmondsw | :( | 19:22 |
| edmondsw | moving on then... | 19:22 |
| edmondsw | esberglu why can't prep_devstack watch for the gerrit review for snapshot, and update the local.conf it's gonna use? | 19:24 |
| edmondsw | esberglu_ ^ | 19:24 |
| edmondsw | as a temp hack until we can merge 6363 | 19:25 |
| edmondsw | (would update 6363 to remove that hack at the same time it does things the right way) | 19:26 |
| esberglu_ | edmondsw: Yeah that would work for snapshot since it only has the one local.conf change | 19:26 |
| esberglu_ | I would like to come up with something to actually pull in patches though | 19:26 |
| esberglu_ | Not guarantee that when we come across this in the future it will be 1 line changed in 1 file | 19:27 |
| edmondsw | sure, if you can come up with something better, I'm all for it | 19:27 |
| esberglu_ | edmondsw: I'm cool with that for snapshot though | 19:27 |
| esberglu_ | I can put something up | 19:28 |
| edmondsw | cool | 19:28 |
| esberglu_ | edmondsw: We have some code for patching pypowervm with internal patches, I can maybe rework that for powervm-ci | 19:29 |
| esberglu_ | I think that's all or nothing too though | 19:29 |
| edmondsw | esberglu_ what about network hotplug... shouldn't we have the same chicken-egg issue there? | 19:30 |
| esberglu_ | Either applying to pypowervm for all runs or none | 19:30 |
| esberglu_ | edmondsw: Nope | 19:30 |
| esberglu_ | Network attach is defined in the driver capabilites | 19:31 |
| esberglu_ | Which somehow propogates through to tempest | 19:31 |
| edmondsw | cool | 19:31 |
| esberglu_ | edmondsw: However I'm looking into the CI for that right now | 19:31 |
| esberglu_ | Idk that our current CI ever does attach_interface | 19:32 |
| edmondsw | if it doesn't, we gotta fix that ASAP | 19:32 |
| esberglu_ | https://github.com/powervm/powervm-ci/blob/master/tempest/out_of_tree_blacklist.txt#L64-L65 | 19:32 |
| edmondsw | snapshot isn't totally ready for nova core reviews, but the network hotplug is | 19:32 |
| edmondsw | boo | 19:33 |
| edmondsw | how are we gonna fix that? RMC takes so long to become active... | 19:33 |
| esberglu_ | Not a clue | 19:36 |
| esberglu_ | It takes like 5 minutes right? | 19:36 |
| esberglu_ | But I think it's accurate that RMC has to be active to attach | 19:37 |
| edmondsw | more like 10 | 19:38 |
| esberglu_ | edmondsw: I don't think we can justify adding 20 minutes to each CI run for 2 tests | 19:38 |
| edmondsw | the tempest results on the network hotplug patch show one AttachInterfacesTestJSON test passing: test_add_remove_fixed_ip | 19:39 |
| esberglu_ | But sounds like nova is gonna make us | 19:39 |
| esberglu_ | edmondsw: I don't think that actually hits the attach_interface | 19:39 |
| edmondsw | they show another skipped... test_create_list_show_delete_interfaces_by_fixed_ip | 19:39 |
| edmondsw | and then they don't show the 2 that you linked from the blacklist | 19:40 |
| edmondsw | why is that one skipped that's not in the blacklist? | 19:40 |
| edmondsw | means our tempest config is wrong, yes? | 19:40 |
| esberglu_ | edmondsw: https://github.com/openstack/tempest/blob/195992/tempest/api/compute/servers/test_attach_interfaces.py#L227 | 19:41 |
| esberglu_ | We have shared networks | 19:41 |
| edmondsw | ic... do we have to use shared networks? | 19:42 |
| edmondsw | I assume if we didn't, we'd have to add that to the blacklist or it would have the same RMC problem | 19:43 |
| edmondsw | but I'm wondering if nova will want us to stop skipping that test as well... | 19:43 |
| esberglu_ | edmondsw: Yep it would hit that | 19:43 |
| edmondsw | esberglu_ fix your nick? :) | 19:44 |
| *** esberglu_ is now known as esberglu | 19:44 | |
| edmondsw | much better | 19:44 |
| edmondsw | it's those little things... ;) | 19:44 |
| esberglu | We don't have to used shared but IIRC we used to hit tons of issues before using shared | 19:45 |
| esberglu | But that was forever ago | 19:45 |
| esberglu | I think I was still in school | 19:45 |
| edmondsw | so let's put that on the back burner and focus on the RMC issue first | 19:45 |
| edmondsw | how long does a CI run take, minus setup and teardown... i.e., actually running tests? | 19:46 |
| esberglu | 25 - 30 minutes normally | 19:47 |
| edmondsw | I wonder if we could write something that creates a server toward the beginning of that, and then tests attach/detach toward the end.. or at least 10 min between them | 19:51 |
| esberglu | No idea how we would tell tempest to use that server for those tests | 19:52 |
| edmondsw | would probably have to be totally different test | 19:52 |
| edmondsw | does tempest run everything serially? | 19:54 |
| edmondsw | I think it does some things in parallel, no? | 19:54 |
| esberglu | Nope it's customizable | 19:54 |
| esberglu | We use concurrency of 4 | 19:54 |
| edmondsw | so one really long test wouldn't necessarily kill performance | 19:55 |
| edmondsw | long as it's not one of the last tests run | 19:55 |
| esberglu | Right | 19:55 |
| esberglu | Idk that we would ever be able to get such a test into tempest | 19:58 |
| edmondsw | maybe it wouldn't have to be a totally new test... | 19:59 |
| edmondsw | if we could add something in setup for that class to create 2 server instances, and modify the existing tests to use those instead of creating the instances when the tests are run | 20:00 |
| edmondsw | then put an "if powervm" in the setup to wait for RMC to become active | 20:00 |
| edmondsw | no need to wait unless powervm | 20:01 |
| edmondsw | I think they might accept that. If not, could we carry it as a patch? | 20:01 |
| esberglu | I don't think that they would even accept that, but we can try. We could carry it as a patch, just means another thing to maintain | 20:04 |
| esberglu | edmondsw: brb I need coffee. I can start putting something together to see if your idea works | 20:06 |
| esberglu | And we can worry about how to carry it forward later | 20:06 |
| *** k0da has quit IRC | 20:43 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 20:45 | |
| esberglu | efried: edmondsw: 6418 for snapshot CI | 20:47 |
| esberglu | Wait it's not right, one sec | 20:48 |
| esberglu | Okay it's ready now | 20:49 |
| efried | esberglu: done | 20:50 |
| esberglu | efried: tx | 20:51 |
| esberglu | I'm gonna put a run through manually with that quick and make sure everything is cool before merging | 20:51 |
| *** AlexeyAbashkin has quit IRC | 20:52 | |
| edmondsw | esberglu I think you have the path wrong | 20:55 |
| edmondsw | gotta run | 20:55 |
| esberglu | edmondsw: Yep you're right good catch | 20:56 |
| *** edmondsw has quit IRC | 20:56 | |
| *** k0da has joined #openstack-powervm | 20:56 | |
| *** edmondsw has joined #openstack-powervm | 20:56 | |
| *** edmondsw has quit IRC | 21:01 | |
| openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: Use vios_uuids to process required vioses for iSCSI https://review.openstack.org/555003 | 21:08 |
| *** chhagarw has quit IRC | 21:12 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 21:17 | |
| *** AlexeyAbashkin has quit IRC | 21:21 | |
| *** tjakobs has quit IRC | 21:38 | |
| *** esberglu has quit IRC | 21:44 | |
| *** esberglu has joined #openstack-powervm | 21:44 | |
| *** esberglu has quit IRC | 21:49 | |
| *** edmondsw has joined #openstack-powervm | 22:46 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 23:16 | |
| *** AlexeyAbashkin has quit IRC | 23:20 | |
| *** k0da has quit IRC | 23:39 | |
| *** k0da has joined #openstack-powervm | 23:54 | |
| *** esberglu has joined #openstack-powervm | 23:54 | |
| *** esberglu has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!