| *** edmondsw has joined #openstack-powervm | 00:25 | |
| *** edmondsw has quit IRC | 00:29 | |
| *** edmondsw has joined #openstack-powervm | 02:13 | |
| *** edmondsw has quit IRC | 02:17 | |
| *** k0da has joined #openstack-powervm | 05:50 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 07:50 | |
| *** AlexeyAbashkin has quit IRC | 10:43 | |
| *** chhagarw has joined #openstack-powervm | 10:59 | |
| openstackgerrit | Arun Mani proposed openstack/nova-powervm master: Add affinity score check attribute to flavor https://review.openstack.org/555309 | 11:01 |
|---|---|---|
| *** AlexeyAbashkin has joined #openstack-powervm | 11:31 | |
| openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: WIP: Having iSCSI Initiator locks per VIOS https://review.openstack.org/557800 | 11:45 |
| openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: WIP: Having iSCSI Initiator locks per VIOS https://review.openstack.org/557800 | 12:36 |
| *** edmondsw has joined #openstack-powervm | 12:43 | |
| chhagarw | @all: getting the pep8 error : failed with error code 1 in /home/zuul/src/git.openstack.org/openstack/nova-powervm, falling back to uneditable format,Could not determine repository location | 12:53 |
| chhagarw | are there any issues with build ci | 12:54 |
| chhagarw | edmondsw: replied to your review comments for get_iscsi_initiators i made a change the driver.py, we can discuss if there is anything over IRC, https://review.openstack.org/#/c/557800/ | 12:56 |
| openstackgerrit | Merged openstack/nova-powervm master: Add affinity score check attribute to flavor https://review.openstack.org/555309 | 13:02 |
| edmondsw | chhagarw you cut off the first part of the pep8 error: Error when trying to get requirement for VCS system Command "git config --get-regexp remote\..*\.url" | 13:07 |
| edmondsw | and the end: of /home/zuul/src/git.openstack.org/openstack/nova-powervm | 13:07 |
| edmondsw | seems like something to just recheck | 13:08 |
| edmondsw | chhagarw your py27 error is due to overindentation on L134 of iscsi.py ... if you fix that the new patch set will be checked and hopefully the pep8 issues go away (else you'll presumably just get a different pep8 error) | 13:10 |
| chhagarw | sure let me check | 13:11 |
| edmondsw | chhagarw I'm wondering if you're really reading my comments... some of them still apply | 13:14 |
| chhagarw | there are few comments for get_iscsi_initiators, which still needs to be discussed, so I left for now before we conclude. | 13:45 |
| *** esberglu has joined #openstack-powervm | 13:52 | |
| *** tjakobs has joined #openstack-powervm | 14:05 | |
| edmondsw | esberglu please take another look at https://review.openstack.org/#/c/552172 | 14:22 |
| edmondsw | need your +2/+a | 14:22 |
| esberglu | edmondsw: ack | 14:23 |
| esberglu | edmondsw: +2/W+1 | 14:28 |
| edmondsw | esberglu tx | 14:33 |
| edmondsw | esberglu thoughts on respinning your IT vscsi commit to include that? | 14:35 |
| edmondsw | fried_bunny still fried on Monday? | 14:36 |
| fried_bunny | It's Easter Monday, right? | 14:36 |
| fried_bunny | I'll shed the fur tomorrow. | 14:36 |
| edmondsw | I don't think I've ever heard of Easter Monday | 14:38 |
| esberglu | edmondsw: Sure. I can update wwpns too | 14:38 |
| edmondsw | esberglu tx | 14:38 |
| fried_bunny | edmondsw: I thought Easter Monday was *the* day. But I'm no expert. | 14:39 |
| edmondsw | Easter Sunday | 14:39 |
| esberglu | edmondsw: fried_bunny: I fixed up snapshot and base disk adapter, ready for review again | 14:39 |
| esberglu | I also rebased everything so it's one commit chain | 14:39 |
| openstackgerrit | Merged openstack/nova-powervm master: Set volume ID as dev tag when mapping VSCSI vols https://review.openstack.org/552172 | 14:39 |
| fried_bunny | esberglu: I'm going to wait a day or two to re-look at anything powervm. | 14:40 |
| fried_bunny | for... reasons. | 14:40 |
| esberglu | Hmm what could those be | 14:40 |
| esberglu | fried_bunny: edmondsw: Working on the cold migration code right now. It uses the StoreNvram task | 15:15 |
| esberglu | Looking here https://github.com/openstack/nova-powervm/blob/stable/queens/nova_powervm/virt/powervm/nvram/manager.py | 15:15 |
| esberglu | Sounds like we don't need it right away, but could add it later as an enhancement? | 15:15 |
| fried_bunny | esberglu: Later. When we support remote restart. Which ain't yet. | 15:15 |
| fried_bunny | ditto with all the slot manager args | 15:16 |
| edmondsw | yeah, don't worry about slots yet | 15:16 |
| edmondsw | or nvram | 15:17 |
| edmondsw | esberglu FYI http://lists.openstack.org/pipermail/openstack-dev/2018-March/128938.html | 15:20 |
| esberglu | edmondsw: Yeah I saw that, not sure how it affects us outside of devstack yet | 15:24 |
| esberglu | how/if | 15:24 |
| edmondsw | hopefully just devstack/CI | 15:24 |
| openstackgerrit | Merged openstack/nova-powervm master: remove pycrypto https://review.openstack.org/558091 | 15:24 |
| *** k0da has quit IRC | 15:30 | |
| esberglu | edmondsw: fried_bunny: https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/driver.py#L1153-L1155 | 15:31 |
| esberglu | Can we just skip the detach then on a resize? | 15:31 |
| edmondsw | esberglu I doubt it | 15:31 |
| edmondsw | resize could move it to a different host | 15:32 |
| edmondsw | so volumes would need to be detached on the old host and reattached on the new host | 15:32 |
| fried_bunny | esberglu: agree with edmondsw | 15:32 |
| esberglu | ok | 15:32 |
| esberglu | fried_bunny: How did you generate the release note name here? https://review.openstack.org/#/c/546813/ | 16:11 |
| fried_bunny | esberglu: Use the reno command. <wait, there's more> | 16:11 |
| fried_bunny | I think there's a way to do that via a tox command. But that takes forever. | 16:12 |
| fried_bunny | So what I do is: | 16:12 |
| fried_bunny | . .tox/venv/bin/activate | 16:12 |
| fried_bunny | reno new <slugname> | 16:12 |
| fried_bunny | where <slugname> is whatever I want the basis of the reno name to be, like my-nifty-feature | 16:12 |
| fried_bunny | Then reno generates the rest of the name, stuffs it in the right directory, and puts the template in it. | 16:12 |
| fried_bunny | (afaict, that's actually all reno does) | 16:13 |
| esberglu | tx | 16:14 |
| *** esberglu has quit IRC | 16:31 | |
| edmondsw | esberglu https://docs.openstack.org/reno/latest/user/usage.html | 16:31 |
| *** esberglu has joined #openstack-powervm | 16:31 | |
| edmondsw | esberglu https://docs.openstack.org/reno/latest/user/usage.html | 16:31 |
| esberglu | edmondsw: vSCSI is ready again | 16:36 |
| *** AlexeyAbashkin has quit IRC | 16:37 | |
| edmondsw | esberglu pypowervm is still only 1.1.11 in nova's requirements.txt... will need to bump that for the wwpn change | 16:49 |
| edmondsw | otherwise looks good | 16:50 |
| openstackgerrit | Sridhar Venkat proposed openstack/nova-powervm master: Set fuse_limit to 15 instead of default 32 https://review.openstack.org/558245 | 18:06 |
| esberglu | edmondsw: vSCSI rebased on pypowervm req bump | 18:46 |
| *** AlexeyAbashkin has joined #openstack-powervm | 18:49 | |
| *** AlexeyAbashkin has quit IRC | 18:53 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 19:04 | |
| *** AlexeyAbashkin has quit IRC | 19:09 | |
| *** chhagarw has quit IRC | 19:38 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 21:02 | |
| *** esberglu has left #openstack-powervm | 21:03 | |
| *** esberglu has joined #openstack-powervm | 21:03 | |
| *** esberglu has quit IRC | 21:03 | |
| *** AlexeyAbashkin has quit IRC | 21:06 | |
| fried_bunny | edmondsw: FYI, I'm against the fuse limit patch. Last I heard, this was a REST bug that changh needs to fix. | 21:12 |
| fried_bunny | If there's some reason (like perf or whatever) beyond "it doesn't work when it's 32" then that's one thing. | 21:12 |
| *** tjakobs has quit IRC | 22:06 | |
| edmondsw | fried_bunny ack... I was hoping you would chime in there as I thought I'd seen you talking about it on slack | 23:14 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!