*** chhagarw has joined #openstack-powervm | 01:23 | |
*** chhagarw has quit IRC | 01:40 | |
*** AlexeyAbashkin has joined #openstack-powervm | 02:02 | |
*** AlexeyAbashkin has quit IRC | 02:06 | |
*** AlexeyAbashkin has joined #openstack-powervm | 03:04 | |
*** AlexeyAbashkin has quit IRC | 03:09 | |
*** chhagarw has joined #openstack-powervm | 04:37 | |
*** AlexeyAbashkin has joined #openstack-powervm | 07:53 | |
*** edmondsw has quit IRC | 12:28 | |
*** edmondsw has joined #openstack-powervm | 12:28 | |
*** edmondsw has quit IRC | 12:32 | |
*** fried_bunny is now known as efried | 12:35 | |
*** edmondsw has joined #openstack-powervm | 12:58 | |
*** chhagarw has quit IRC | 13:06 | |
*** chhagarw has joined #openstack-powervm | 13:11 | |
chhagarw | edmondsw,efried: have a query on this https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/volume/iscsi.py#L132 | 13:54 |
---|---|---|
efried | where's thorst when you need him | 13:54 |
*** tjakobs has joined #openstack-powervm | 13:54 | |
edmondsw | on the same call I'm stuck on | 13:55 |
edmondsw | chhagarw you probably want to ask tjakobs | 13:55 |
chhagarw | tjakobs | 13:56 |
chhagarw | As per this line: https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/volume/iscsi.py#L132 | 13:56 |
edmondsw | efried I'm gonna need to push the scrum back 30 min or so | 13:56 |
efried | ight | 13:57 |
chhagarw | I think for multipath we need to iterate_all_targets | 13:57 |
chhagarw | i think this should be if not multipath, just do a single path discovery else iterate_all_targets | 13:57 |
tjakobs | is this from a live test? or from looking at the code? | 13:58 |
chhagarw | tjakobs: looking at the code, and with UT | 13:58 |
chhagarw | I checked the storage live results, cinder returns target_iqns, target_luns for multipath | 13:59 |
tjakobs | the REST API has its one implementation of the iterate_all_targets | 13:59 |
chhagarw | so based on that in the case of multipath we need to iterate_all_tagets | 13:59 |
chhagarw | REST API ? | 14:00 |
*** esberglu has joined #openstack-powervm | 14:00 | |
chhagarw | current code does not works for multipath, rather in this case multipath gets default to single path. | 14:01 |
edmondsw | esberglu mtg delayed 30 min | 14:09 |
esberglu | edmondsw: ack | 14:09 |
edmondsw | #startmeeting PowerVM Driver Meeting | 14:31 |
openstack | Meeting started Tue Apr 3 14:31:48 2018 UTC and is due to finish in 60 minutes. The chair is edmondsw. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:31 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:31 |
*** openstack changes topic to " (Meeting topic: PowerVM Driver Meeting)" | 14:31 | |
openstack | The meeting name has been set to 'powervm_driver_meeting' | 14:31 |
edmondsw | https://etherpad.openstack.org/p/powervm_driver_meeting_agenda | 14:32 |
edmondsw | #topic In-Tree Driver | 14:32 |
*** openstack changes topic to "In-Tree Driver (Meeting topic: PowerVM Driver Meeting)" | 14:32 | |
edmondsw | efried esberglu ready? | 14:33 |
esberglu | yep | 14:33 |
efried | hit it | 14:33 |
edmondsw | so https://review.openstack.org/#/c/547169/ merged | 14:33 |
edmondsw | but none of the actual function yet | 14:33 |
edmondsw | we have one +2 on the network hotplug | 14:33 |
edmondsw | and there is a runway queued up to look at that, vscsi, and snapshot | 14:34 |
esberglu | vSCSI, Snapshot, base DiskAdapter, and Localdisk are all ready for review | 14:34 |
esberglu | Only other one is resize/cold migrate which is still WIP | 14:34 |
edmondsw | esberglu I think you said yesterday that you rebased something? | 14:35 |
edmondsw | I didn't get a chance to look | 14:35 |
esberglu | edmondsw: I just made everything one commit chain, made the resize/cold migrate stuff easier | 14:35 |
edmondsw | ah cool | 14:35 |
edmondsw | vscsi -> snapshot -> diskadapter -> localdisk -> migr/resize | 14:36 |
esberglu | And responded to the couple comments you left on snapshot and disk adapter, those should be ready for your +1 | 14:36 |
edmondsw | esberglu will try to look this afternoon | 14:36 |
esberglu | tx | 14:37 |
edmondsw | I did +1 the vscsi changes | 14:37 |
esberglu | yep | 14:37 |
esberglu | Resize is coming along | 14:37 |
esberglu | Need to figure out if boot from cinder volume works, some of the code paths depend on that | 14:37 |
esberglu | And then UT, Live test, and get CI rolling | 14:37 |
edmondsw | esberglu testing boot from volume would also be good for the vscsi commit, right? | 14:38 |
edmondsw | I don't recall whether there is a separate op for that in the support matrix that we need to mark "complete" | 14:39 |
edmondsw | if it works | 14:39 |
esberglu | edmondsw: Yep I'm stacking right now to test it out | 14:39 |
edmondsw | cool, let us know | 14:39 |
esberglu | It for me | 14:39 |
edmondsw | efried no word on core yet? | 14:40 |
edmondsw | any day now I assume | 14:40 |
efried | nope. The one week "speak now or forever hold your peace" period technically ended last night. If melwitt is thinking about it, hopefully she'll flip the switch when she gets on today. | 14:40 |
edmondsw | yep | 14:41 |
edmondsw | ok moving on | 14:41 |
edmondsw | #topic Out-of-Tree Driver | 14:41 |
*** openstack changes topic to "Out-of-Tree Driver (Meeting topic: PowerVM Driver Meeting)" | 14:41 | |
edmondsw | https://etherpad.openstack.org/p/powervm-oot-todos | 14:41 |
edmondsw | we got pypowervm bump merged and the 2 commits waiting on that as well | 14:42 |
edmondsw | chhagarw is working on iscsi stuff | 14:42 |
chhagarw | yes | 14:42 |
chhagarw | it should be mostly done by tomorrow, adding UTs | 14:43 |
edmondsw | there is a commit about setting fuse_limit for fileio that I'm trying to dig into | 14:43 |
edmondsw | chhagarw cool | 14:43 |
edmondsw | got a response from thorst about fuse_limit that "fileio seems to max at 15…I think" | 14:43 |
edmondsw | so I don't think they're doing that for perf reasons | 14:44 |
edmondsw | so it might actually make sense in nova-powervm and not just in NovaLink... but I need to get more clarity there | 14:44 |
edmondsw | tjakobs rebased the volume refactor but then it has another merge conflict now with other things having merged | 14:45 |
edmondsw | I think that covers OOT unless anyone has anything to add? | 14:45 |
efried | edmondsw: "seems to max" leads me to think this is the result of the same kind of testing the other consumer was seeing. | 14:45 |
tjakobs | edmondsw: noted | 14:46 |
edmondsw | efried you and I should catch hsien today about that | 14:46 |
edmondsw | and get to the bottom of it | 14:46 |
efried | We need to get all the players together to make sure we're really talking about two different things before we send hsien off to fix it one way and drop code on our layer to avoid the bug. | 14:46 |
edmondsw | sure | 14:47 |
efried | edmondsw: Can you find out who in pvc observed the issue? I think svenkat referenced an RTC bug | 14:47 |
edmondsw | I'm told the other player would be thorst | 14:47 |
efried | thorst who? | 14:47 |
edmondsw | lol | 14:47 |
efried | Oh THAT guy - haven't seen him in ages. | 14:47 |
edmondsw | alright, moving on | 14:48 |
esberglu | Oh one other thing, haven't figured out how to handle duplicate opts yet, but also haven't looked into it at all since last week | 14:48 |
edmondsw | #topic Device Passthrough | 14:48 |
*** openstack changes topic to "Device Passthrough (Meeting topic: PowerVM Driver Meeting)" | 14:48 | |
edmondsw | this has been languishing from my perspective... been caught up in other things | 14:48 |
edmondsw | how's it going with you efried? | 14:48 |
edmondsw | update on nova? | 14:48 |
efried | Designs and patches churning along frantically. | 14:49 |
efried | It is becoming clear that we've got way, way, way too much content for Rocky. | 14:49 |
edmondsw | across Nova, or re: placement? | 14:49 |
efried | yes | 14:49 |
edmondsw | :) | 14:49 |
efried | upt is starting to merge. | 14:49 |
edmondsw | \o/ | 14:49 |
efried | Still verrry slow progress on nrp-in-alloc-cands. | 14:50 |
efried | I'm thinking I'm going to start grinding on the granular work, because everybody is depending on it; even though I won't be able to tie it off until we get nrp-in-alloc-cands. | 14:50 |
edmondsw | can/should you help more on nrp-in-alloc-cands? | 14:50 |
efried | double-edged sword. I want to be able to +2 that stuff. | 14:51 |
edmondsw | yeah | 14:51 |
efried | One of our main cores who looks at placement stuff is out for 2w | 14:51 |
efried | (gibi on honeymoon) | 14:51 |
efried | Progress is being made; it's just slower than I would like. | 14:52 |
edmondsw | k | 14:52 |
efried | BTW, there's also been some argument over a design point for granular. | 14:52 |
efried | Per design, if you specify two separate numbered request groups, there's no restriction on whether they will or will not land on the same provider. | 14:52 |
efried | Now people are demanding that separate numbered groups *must* land on separate providers. | 14:53 |
efried | which I think is a mistake for several reasons. But I'm being outvoted. | 14:53 |
edmondsw | why? | 14:53 |
edmondsw | not why you think it's a mistake | 14:53 |
edmondsw | why others disagree? | 14:53 |
efried | I'm actually not terribly sure, to be honest. I think it's mainly to satisfy NUMA use cases. | 14:54 |
edmondsw | hmmm | 14:54 |
efried | I mean, I concede that we have to be able to handle both things eventually. | 14:54 |
edmondsw | could you add a way to say THESE providers have to go together but others don't? | 14:54 |
efried | Yeah. And we're going to have to do that eventually. | 14:55 |
edmondsw | maybe need to accelerate that | 14:55 |
efried | It's a question of whether that option is gonna be called allow_same_provider=<this group, that group> or separate_providers=<this group, that group> | 14:55 |
edmondsw | or at least articulate it | 14:55 |
efried | oh, believe me, I've been articulating my ass off. | 14:55 |
edmondsw | :) | 14:55 |
efried | I'm not sure it's going to affect us, to be honest. | 14:56 |
efried | We can make dev passthrough work whichever way the default shakes out. | 14:56 |
efried | I'm just arguing from a purely architectural standpoint. And I'm right. But I'm gonna lose. | 14:56 |
edmondsw | boo | 14:56 |
efried | them's the breaks. | 14:57 |
edmondsw | yeah | 14:57 |
edmondsw | anything else? | 14:57 |
efried | The only thing I still have on my side is that the spec, which is approved, already has it my way. | 14:57 |
efried | so someone is going to have to propose a delta to it. | 14:57 |
edmondsw | -2 it ;) | 14:57 |
efried | And I'm conspicuously dragging my feet on that leetle work item. | 14:57 |
edmondsw | #topic: PowerVM CI | 14:58 |
*** openstack changes topic to ": PowerVM CI (Meeting topic: PowerVM Driver Meeting)" | 14:58 | |
edmondsw | https://etherpad.openstack.org/p/powervm_ci_todos | 14:58 |
edmondsw | esberglu? | 14:58 |
esberglu | Upgraded all the systems last week | 14:58 |
esberglu | Everything is running really smoothly | 14:58 |
edmondsw | yay | 14:58 |
esberglu | Only failure that is hitting with any sort of consistency is the vopt naming conflict thing | 14:58 |
esberglu | But even that is really low % | 14:58 |
edmondsw | I'm gonna have to join another mtg in a min... esberglu take over this one? | 14:59 |
esberglu | I got some multinode CI runs going for OOT, all manual, nothing automated yet | 14:59 |
esberglu | edmondsw: Sure | 14:59 |
esberglu | http://184.172.12.213/manual/2node/ | 14:59 |
esberglu | But it's mostly passing, hitting a few errors on resize I haven't looked into yet | 15:00 |
edmondsw | :) | 15:00 |
esberglu | "Specified UUID is already used by other partitions" | 15:00 |
esberglu | edmondsw: Wanted to talk about my move to PowerAI in open discussion, but we can do it later today so you can be there | 15:01 |
efried | nice | 15:01 |
edmondsw | I just got a 5 min reprieve so go ahead | 15:01 |
efried | Do we want to do that here or internal? | 15:01 |
esberglu | That's all for CI | 15:01 |
esberglu | Actually internal may be better | 15:02 |
edmondsw | esberglu any more progress on the move to queens? | 15:02 |
esberglu | edmondsw: Haven't touched it, working multinode has taken priority | 15:02 |
edmondsw | sure, agreed on that | 15:02 |
edmondsw | #topic Open Discussion | 15:03 |
*** openstack changes topic to "Open Discussion (Meeting topic: PowerVM Driver Meeting)" | 15:03 | |
edmondsw | anything? | 15:03 |
esberglu | nada | 15:03 |
edmondsw | alright, thanks guys | 15:03 |
edmondsw | #endmeeting | 15:03 |
*** openstack changes topic to "This channel is for PowerVM-related development and discussion. For general OpenStack support, please use #openstack." | 15:03 | |
openstack | Meeting ended Tue Apr 3 15:03:54 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:03 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/powervm_driver_meeting/2018/powervm_driver_meeting.2018-04-03-14.31.html | 15:03 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/powervm_driver_meeting/2018/powervm_driver_meeting.2018-04-03-14.31.txt | 15:04 |
openstack | Log: http://eavesdrop.openstack.org/meetings/powervm_driver_meeting/2018/powervm_driver_meeting.2018-04-03-14.31.log.html | 15:04 |
efried | edmondsw, esberglu: Second upt patch is merging. That's the end of the important stuff - the rest is minor fixups. | 16:15 |
edmondsw | awesome | 16:15 |
esberglu | sweet | 16:17 |
efried | definitely going to start hacking on the granular stuff now. | 16:17 |
*** AlexeyAbashkin has quit IRC | 16:31 | |
efried | edmondsw: Not sure if you've been following the cyborg story at all, but this is shaping up to be a pretty good read: https://etherpad.openstack.org/p/Cyborg-Nova-Multifunction | 16:37 |
edmondsw | efried I haven't, but tx for the heads up | 16:37 |
efried | edmondsw: Very pertinent to our dev passthrough story. | 16:38 |
edmondsw | cool | 16:38 |
efried | and probably will be part of it in a year or two. | 16:38 |
edmondsw | omw to lunch, have it queued up for later | 16:38 |
esberglu | edmondsw: efried: I can't create volumes from an image either IT or OOT with vSCSI. So I'm going to rip out the boot from volume stuff from IT for now | 17:26 |
esberglu | And add a TODO to explore this OOT | 17:26 |
edmondsw | esberglu ack | 17:27 |
*** AlexeyAbashkin has joined #openstack-powervm | 17:37 | |
*** AlexeyAbashkin has quit IRC | 17:42 | |
*** AlexeyAbashkin has joined #openstack-powervm | 18:02 | |
*** AlexeyAbashkin has quit IRC | 18:06 | |
*** efried has quit IRC | 18:14 | |
*** efried has joined #openstack-powervm | 18:14 | |
openstackgerrit | Chhavi Agarwal proposed openstack/nova-powervm master: WIP: Having iSCSI Initiator locks per VIOS https://review.openstack.org/557800 | 18:20 |
chhagarw | edmondsw: updated the review, with the changes to handle dual vios iscsi_initiators, and restructered to handle iscsi connection properties. | 18:22 |
edmondsw | chhagarw tx will look | 18:23 |
chhagarw | The UT is not complete yet, but would like to have a glance, to see if the approach is fine | 18:23 |
*** AlexeyAbashkin has joined #openstack-powervm | 18:55 | |
*** AlexeyAbashkin has quit IRC | 19:00 | |
edmondsw | chhagarw I thought you were going to return a dict in connector['initiator'] ? | 19:06 |
edmondsw | did you find that doesn't work? | 19:07 |
chhagarw | i am returning a list, | 19:07 |
chhagarw | cinder accepts the list of initiators | 19:07 |
edmondsw | this doesn't look like a list | 19:08 |
edmondsw | https://review.openstack.org/#/c/557800/6/nova_powervm/virt/powervm/driver.py@1109 | 19:08 |
edmondsw | you pull a single element out of the list instead of returning the whole list | 19:08 |
edmondsw | that a mistake? that why your UT isn't working? | 19:09 |
edmondsw | chhagarw ^ | 19:10 |
chhagarw | some mistake the file did not updated in the review, the change which i did is to return the values() | 19:21 |
chhagarw | did u also checked the _get_iscsi_conn_props | 19:22 |
chhagarw | this method is added to hold the iscsi connection properties, | 19:23 |
edmondsw | chhagarw I'm trying to figure out why that is new | 19:24 |
edmondsw | looks like all it does is copy (manually) from connection_info['data'] to a new dict | 19:25 |
edmondsw | gross | 19:25 |
chhagarw | it also do KeyError Validation for the required property which should exist, if the properties are msising we throw error before hand | 19:28 |
edmondsw | is that really necessary? | 19:28 |
edmondsw | why? | 19:28 |
edmondsw | shouldn't connection_info['data'] already have correct/validated data? | 19:29 |
efried | edmondsw, esberglu: It is done. | 19:32 |
esberglu | efried: Nova core? | 19:33 |
efried | yes | 19:33 |
esberglu | Congrats! | 19:33 |
efried | Thanks! | 19:33 |
edmondsw | woot! | 19:33 |
*** chhagarw has quit IRC | 19:42 | |
*** efried is now known as efried_schoolrun | 20:12 | |
*** edmondsw has quit IRC | 21:09 | |
*** edmondsw has joined #openstack-powervm | 21:09 | |
*** edmondsw has quit IRC | 21:14 | |
*** tjakobs has quit IRC | 21:32 | |
*** tjakobs has joined #openstack-powervm | 21:43 | |
*** efried_schoolrun is now known as efried | 21:54 | |
*** AlexeyAbashkin has joined #openstack-powervm | 22:00 | |
*** tjakobs has quit IRC | 22:00 | |
*** AlexeyAbashkin has quit IRC | 22:05 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!