| *** rhsu has joined #openstack-qa | 00:03 | |
| *** hemna is now known as hemnafk | 00:05 | |
| *** krtaylor has joined #openstack-qa | 00:14 | |
| *** woodspa has joined #openstack-qa | 00:18 | |
| *** rhsu has quit IRC | 00:19 | |
| *** woodspa has quit IRC | 00:22 | |
| *** woodspa has joined #openstack-qa | 00:23 | |
| *** rhsu has joined #openstack-qa | 00:25 | |
| *** rhsu has quit IRC | 00:26 | |
| dkranz | lifeless: Thanks for the info. That is very helpful. clarkb: Peace. We just moved tempest off of nose completely. | 00:39 |
|---|---|---|
| dkranz | clarkb: There are people who have nose plugins and have been using them for a long time, before there was a testr. | 00:40 |
| clarkb | dkranz: sorry I have such horrible memories of the horror | 00:40 |
| dkranz | clarkb: I was exploring possible upgrade paths. | 00:40 |
| clarkb | dkranz: normally I would sympathize but by nature those things are horribly broken... | 00:40 |
| dkranz | clarkb: Well, nose was used by a fair number of people. Including us for a *long* time :) | 00:41 |
| dkranz | clarkb: But I am not disagreeing with you. | 00:41 |
| clarkb | and we did have to reimplement several things that were in nose to make people happy. There is a subunit to pyunit colorizor in nova so that you can get colorized output if you want, and the html reported script was ported to report off of subunit | 00:42 |
| clarkb | and coverage is implemented independently | 00:42 |
| clarkb | (ish, we actually use a small hack and have testr call cover.py instead of python when running the tests to get coverage) | 00:43 |
| clarkb | I guess what I am trying to say is we have more properly done the above and ditched the equivalent nose plugins because ugh | 00:43 |
| dkranz | clarkb: Fair enough. Now that we are logging irc here I can just point people at this thread :). | 00:50 |
| *** woodspa_ has joined #openstack-qa | 01:26 | |
| *** woodspa_ has quit IRC | 01:27 | |
| openstackgerrit | Dean Troyer proposed a change to openstack-dev/devstack: Add tools/install_pip.sh https://review.openstack.org/39827 | 01:29 |
| *** woodspa has quit IRC | 01:30 | |
| openstackgerrit | Ivan-Zhu proposed a change to openstack-dev/grenade: add nova v3 api support in upgrade https://review.openstack.org/40134 | 02:28 |
| *** SergeyLukjanov has joined #openstack-qa | 03:03 | |
| *** LiangZheng has joined #openstack-qa | 03:10 | |
| *** HenryG has quit IRC | 03:22 | |
| *** turul_ has joined #openstack-qa | 03:27 | |
| *** turul_ is now known as afazekas | 03:28 | |
| afazekas | stevebaker: https://review.openstack.org/#/c/40538/ | 03:29 |
| stevebaker | afazekas: that was deliberate. | 03:30 |
| stevebaker | there we go, grumpy comments made ;) | 03:34 |
| stevebaker | possibly it is time to create a demo_admin user in devstack | 03:35 |
| afazekas | stevebaker: I remember it was in you commit message, I just wanted to be sure nothing changed.. | 03:36 |
| stevebaker | yep, thanks for the headsup | 03:36 |
| afazekas | Do you know, will this change be updated https://review.openstack.org/#/c/34866/11 ? | 03:39 |
| lifeless | dkranz: I'm happy to help folk achieve any specific goal they have with testr. | 03:43 |
| lifeless | dkranz: I'm a small-tools + clean-interfaces guy these days; if there is a place where a plugin interface will help testr, I'll gladly add plugins | 03:44 |
| lifeless | dkranz: (I wrote the bzr plugins API) | 03:44 |
| stevebaker | afazekas: i don't know, I hope so | 03:46 |
| lifeless | dkranz: but testr is growing bits as folk need them rather than me going and aggressively making it all plugin based. I think thats largely because the problems testr wants to solve are being solved first-time-around, so I don't have a rilliant feel for the ways extensions will need to interact. | 03:46 |
| clarkb | I haven't felt a need for a proper plugin system yet. I attribute a lot of that to subunit | 03:47 |
| openstackgerrit | afazekas proposed a change to openstack/tempest: Remove wait_for_image_resp_code https://review.openstack.org/38995 | 03:51 |
| clarkb | lifeless: it would be kind of cool if for test in `testr list-tests | sed 1d` ; do testr run $test ; done could be expressed in a way that didn't run discover over and over and over again | 03:51 |
| clarkb | I think the better way to do it is just run the test directly right? using testtools.run? | 03:52 |
| lifeless | clarkb: a) it can; b) I have a patch just about ready to go to do testr run-tests --isolated and do it all for you in one step | 03:52 |
| clarkb | ooh | 03:52 |
| clarkb | I approve of this change | 03:52 |
| lifeless | clarkb: testr lists-tests | sed 1d; do testr run-tests --load-list <(echo $test); done | 03:54 |
| lifeless | clarkb: will avoid discovery for you today, IIRC. | 03:55 |
| clarkb | good to know, thanks | 03:57 |
| afazekas | stevebaker: a demo_admin sounds good to me, sooner or later the special user will be generated in tempest side anyway | 03:59 |
| *** afazekas has quit IRC | 04:31 | |
| *** SergeyLukjanov has quit IRC | 04:33 | |
| openstackgerrit | A change was merged to openstack/tempest: Remove duplicate image tests for tenant authZ https://review.openstack.org/39641 | 04:41 |
| openstackgerrit | A change was merged to openstack/tempest: Flag InstanceCfnInitTestJSON as the first slow heat test https://review.openstack.org/40738 | 04:41 |
| *** afazekas has joined #openstack-qa | 04:52 | |
| *** Ater has joined #openstack-qa | 04:52 | |
| openstackgerrit | afazekas proposed a change to openstack/tempest: Handle the credentials as object https://review.openstack.org/38641 | 05:03 |
| openstackgerrit | afazekas proposed a change to openstack-dev/devstack: .conf suffix for the horizon config on Fedora https://review.openstack.org/40352 | 05:13 |
| openstackgerrit | afazekas proposed a change to openstack/tempest: setUpClass/tearDownClass full chain https://review.openstack.org/39346 | 05:24 |
| openstackgerrit | afazekas proposed a change to openstack/tempest: Remove wait_for_image_resp_code https://review.openstack.org/38995 | 05:31 |
| mkoderer | afazekas ping | 05:54 |
| afazekas | mkoderer: pong | 06:00 |
| afazekas | I can remove the never used code from the end of the files | 06:01 |
| afazekas | The info level logging happens on exception | 06:01 |
| mkoderer | afazekas: ;) sorry that I wasn't clear in my final commet | 06:01 |
| afazekas | So it can be even error level, but it should be on lover level than error | 06:01 |
| mkoderer | afazekas: yes that's just minor thinks | 06:02 |
| mkoderer | afazekas: just because the whole file is called "debug" | 06:02 |
| mkoderer | afazekas: and that's why it sounded more like debug messages | 06:02 |
| afazekas | there will be more things there when needed, and it will get some config option | 06:02 |
| afazekas | but those prints will indicate missing iptables NAT rules | 06:03 |
| afazekas | 2 issue happens on the neutron job | 06:03 |
| afazekas | missing fixed IP | 06:03 |
| afazekas | missing floating IP rules | 06:03 |
| mkoderer | I mean such function is useful for many use cases | 06:03 |
| afazekas | So what needs to be changed ? | 06:04 |
| afazekas | or here : https://review.openstack.org/#/c/38980/ | 06:04 |
| mkoderer | yes delete those "Mini tests" | 06:05 |
| mkoderer | that's a good question | 06:05 |
| mkoderer | its already on the agenda of the qa meeting today | 06:06 |
| mkoderer | I think with https://review.openstack.org/#/c/38980/ we could stop duplicating code | 06:07 |
| afazekas | Probably I will -1 the testr serial default, since I did not find the log is saved on the gate | 06:07 |
| afazekas | mkoderer: I will submit a configurable test son, and you will see how this options can be used to have focused or less focused test | 06:09 |
| mkoderer | afazekas: what do you think about the idea to introduce a new decorator for the stress test | 06:10 |
| afazekas | BTW: neutron issues usually happens after ~20 euca run (removed volume test part) | 06:10 |
| mkoderer | so we could easily mark tempest test that they can be used as stresstest? | 06:11 |
| afazekas | mkoderer: every not numbered test method can be used in the stress tests now | 06:11 |
| mkoderer | afazekas: yes but not all are usefull for it | 06:11 |
| afazekas | We should tag all user test case anyway, as part of the API validation subset (refstack) | 06:11 |
| mkoderer | afazekas: and not all are tested | 06:11 |
| afazekas | If you can tag a good collection it is good for me | 06:12 |
| mkoderer | ok never heard about it | 06:12 |
| mkoderer | I mean I like the idea that the author on a certain test can think about tagging it as stresstest just by adding a line | 06:13 |
| mkoderer | I hope we can use all scenario tests as stress test | 06:14 |
| afazekas | https://etherpad.openstack.org/RefStackBlueprint | 06:14 |
| *** thomasbiege1 has joined #openstack-qa | 06:15 | |
| afazekas | so the story is the providers provides several users for API validation testing | 06:15 |
| afazekas | Probably without full admin privileges :) | 06:15 |
| afazekas | with disabled per class tenant isolation, the test set which can work can be used | 06:16 |
| openstackgerrit | afazekas proposed a change to openstack/tempest: Dump basic network info in the test_network_basic_ops https://review.openstack.org/40435 | 06:17 |
| mkoderer | afazekas: sound really interesting | 06:17 |
| mkoderer | afazekas: is this already somehow official? need to tell my boss about this plan | 06:18 |
| afazekas | http://refstack.org/ it has web page, probably mordred and sdague can tell you the status | 06:23 |
| mkoderer | I already found it ;) thanks | 06:24 |
| *** jhenner has joined #openstack-qa | 06:30 | |
| *** tkammer has joined #openstack-qa | 06:33 | |
| *** jhenner has quit IRC | 06:33 | |
| openstackgerrit | anju Tiwari proposed a change to openstack/tempest: Added negative tests for server https://review.openstack.org/40813 | 06:55 |
| openstackgerrit | anju Tiwari proposed a change to openstack/tempest: Added negative tests for server https://review.openstack.org/40813 | 06:56 |
| *** jhenner has joined #openstack-qa | 06:57 | |
| *** Anju has joined #openstack-qa | 07:02 | |
| *** jhenner has quit IRC | 07:03 | |
| *** thomasbiege1 has quit IRC | 07:05 | |
| *** SergeyLukjanov has joined #openstack-qa | 07:21 | |
| openstackgerrit | Marc Koderer proposed a change to openstack/tempest: Change logging in stress test https://review.openstack.org/40566 | 07:24 |
| mkoderer | Anju: ping | 07:35 |
| mkoderer | Anju: regarding https://review.openstack.org/#/c/40813/ - can you add random values like in https://review.openstack.org/#/c/40049 | 07:37 |
| Anju | mkoderer : yeah yeah sure sure | 07:40 |
| *** giulivo has joined #openstack-qa | 07:42 | |
| Anju | mkderer: last time u said to not use rand in netwrok funtions | 07:42 |
| Anju | mkoderer: last time u said to not use rand in netwrok funtions | 07:42 |
| mkoderer | Anju: no it was just because of the "variable" | 07:42 |
| mkoderer | not about random or not | 07:43 |
| openstackgerrit | anju Tiwari proposed a change to openstack/tempest: Added negative tests for server https://review.openstack.org/40813 | 07:48 |
| openstackgerrit | anju Tiwari proposed a change to openstack/tempest: Added negative tests for server https://review.openstack.org/40813 | 07:49 |
| mkoderer | Anju: thanks | 07:51 |
| openstackgerrit | A change was merged to openstack/tempest: Adds tests covering Swift's Account Quota middleware https://review.openstack.org/39659 | 07:53 |
| Anju | mkoderer: i should say thanks :) | 07:53 |
| *** thomasbiege1 has joined #openstack-qa | 07:54 | |
| *** thomasbiege1 has quit IRC | 08:12 | |
| *** fbo_away is now known as fbo | 08:22 | |
| openstackgerrit | A change was merged to openstack/tempest: Add test for swift ACLs https://review.openstack.org/38823 | 08:27 |
| *** psedlak has joined #openstack-qa | 08:31 | |
| openstackgerrit | anju Tiwari proposed a change to openstack/tempest: Added negative tests for server https://review.openstack.org/40813 | 08:45 |
| openstackgerrit | Fabien Boucher proposed a change to openstack/tempest: Add tests for swift container listing filters https://review.openstack.org/40416 | 08:51 |
| *** mkollaro has joined #openstack-qa | 08:57 | |
| openstackgerrit | nayna-patel proposed a change to openstack/tempest: Added a test case to create bulk networks in single API call. https://review.openstack.org/40826 | 09:02 |
| *** thomasbiege1 has joined #openstack-qa | 09:07 | |
| openstackgerrit | Ivan-Zhu proposed a change to openstack/tempest: port test_images and test_server_actions into v3 part2 https://review.openstack.org/39609 | 09:07 |
| openstackgerrit | A change was merged to openstack/tempest: Skip more security group tests until bug 1182384 is fixed https://review.openstack.org/40669 | 09:11 |
| *** Ater has left #openstack-qa | 09:12 | |
| openstackgerrit | Giulio Fidente proposed a change to openstack/tempest: scenario test involving glance, cinder and nova functionalities https://review.openstack.org/38943 | 09:57 |
| openstackgerrit | Giulio Fidente proposed a change to openstack/tempest: scenario test involving glance, cinder and nova functionalities https://review.openstack.org/38943 | 10:01 |
| openstackgerrit | nayna-patel proposed a change to openstack/tempest: Testcase to create bulk networks in one API call https://review.openstack.org/40826 | 10:02 |
| openstackgerrit | Giulio Fidente proposed a change to openstack/tempest: scenario test involving glance, cinder and nova functionalities https://review.openstack.org/38943 | 10:02 |
| *** thomasbiege1 has quit IRC | 10:38 | |
| *** LiangZheng has quit IRC | 10:40 | |
| *** weshay has joined #openstack-qa | 10:57 | |
| *** yfried has joined #openstack-qa | 11:23 | |
| *** woodspa has joined #openstack-qa | 11:25 | |
| *** yfried has left #openstack-qa | 11:29 | |
| *** HenryG has joined #openstack-qa | 11:35 | |
| *** thomasbiege1 has joined #openstack-qa | 11:41 | |
| openstackgerrit | anju Tiwari proposed a change to openstack/tempest: Added negative tests for server https://review.openstack.org/40813 | 11:41 |
| *** sthaha has joined #openstack-qa | 11:55 | |
| *** weshay has quit IRC | 12:03 | |
| *** mriedem has joined #openstack-qa | 12:08 | |
| *** SergeyLukjanov has quit IRC | 12:34 | |
| openstackgerrit | Fabien Boucher proposed a change to openstack/tempest: Add tests for swift container listing filters https://review.openstack.org/40416 | 12:43 |
| *** SergeyLukjanov has joined #openstack-qa | 12:43 | |
| *** weshay has joined #openstack-qa | 12:45 | |
| *** anteaya has joined #openstack-qa | 12:59 | |
| openstackgerrit | Marc Koderer proposed a change to openstack/tempest: Change logging in stress test https://review.openstack.org/40566 | 13:11 |
| mordred | mkoderer: it's in work - what can I tell you? you wanna help out? :) | 13:11 |
| mkoderer | mordred: ? | 13:12 |
| mordred | mkoderer: refstack | 13:12 |
| mkoderer | mordred: aha ;) it's ok it was just out of interest | 13:15 |
| mkoderer | mordred: but thx for asking ;) | 13:15 |
| *** adalbas has joined #openstack-qa | 13:17 | |
| *** krtaylor has quit IRC | 13:29 | |
| openstackgerrit | afazekas proposed a change to openstack/tempest: Stress ssh_floating test https://review.openstack.org/40680 | 13:43 |
| *** afazekas has quit IRC | 13:47 | |
| *** dkranz has quit IRC | 14:00 | |
| *** afazekas has joined #openstack-qa | 14:14 | |
| *** sthaha has quit IRC | 14:15 | |
| *** krtaylor has joined #openstack-qa | 14:15 | |
| openstackgerrit | afazekas proposed a change to openstack/tempest: Stress ssh_floating test https://review.openstack.org/40680 | 14:20 |
| *** burt has joined #openstack-qa | 14:24 | |
| *** adalbas has quit IRC | 14:28 | |
| *** adalbas has joined #openstack-qa | 14:44 | |
| *** tkammer has quit IRC | 14:47 | |
| openstackgerrit | Kyle Mestery proposed a change to openstack-dev/devstack: Support per-MechanismDriver config with ML2 https://review.openstack.org/40882 | 15:02 |
| afazekas | giulivo: ping | 15:06 |
| giulivo | pong aga | 15:06 |
| giulivo | auch afazekas | 15:06 |
| afazekas | https://review.openstack.org/#/c/39346/ | 15:06 |
| afazekas | why do you want to add an additional method to the base class ? | 15:06 |
| afazekas | Why is it problem If we add similar validation to tearDownClass and setUpClass as testtool has with tesrDown and setUp ? | 15:07 |
| *** dkranz has joined #openstack-qa | 15:11 | |
| giulivo | hi afazekas so in relation to 1 | 15:12 |
| giulivo | I'd add it because by doing so we ensure every base class has both setUpClass and tearDownClass defined and calling correctly the sup methods as a general rule; it looks like the object_storage base class is the only one which does not have a tearDownClass method defined | 15:15 |
| giulivo | in relation to 2 | 15:15 |
| *** krtaylor has quit IRC | 15:15 | |
| afazekas | giulivo: wo normally delete the testDown/setUP/ ... methods what just calls the super | 15:15 |
| afazekas | s/wo/we/ | 15:16 |
| giulivo | oh okay | 15:16 |
| giulivo | so my idea was just to ensure that was set for all base classes, because that is what the commit is about | 15:17 |
| giulivo | but there is no point (apart from styling) to add that for object_storage, I understand that | 15:17 |
| giulivo | so I'd be okay to leave this completely out as per your submission | 15:18 |
| giulivo | it's not that important | 15:18 |
| afazekas | the code in the base class will prevent the merging changes with missing super call | 15:18 |
| giulivo | in relation to the checks, I don't see any check for the setUp and tearDown but only for setUpClass and tearDownClass | 15:18 |
| giulivo | now my idea was, what is the reason to enforce a check in the code? | 15:19 |
| afazekas | bacose those are done by the testools base class anyway | 15:19 |
| *** SergeyLukjanov has quit IRC | 15:20 | |
| giulivo | I mean, with your changes, the only situation which could cause that not to be executed is a new testclass which implements basetestcase rather than some specific base$componentTest, correct? | 15:21 |
| afazekas | We have single base class and every test class must inherit from that directly or indirectly | 15:23 |
| giulivo | yeah indeed so after your changes, the only way to miss class setup/teardown is inheriting directly from basetest class | 15:24 |
| afazekas | You need to add a new tearDownClass or setUpClass method + an existing test case, to trigger the checker | 15:24 |
| *** SergeyLukjanov has joined #openstack-qa | 15:25 | |
| afazekas | giulivo: it is about detecting forgetting super call | 15:26 |
| giulivo | afazekas, so maybe I'm reading it wrong | 15:26 |
| afazekas | It is not restriction for declare those methods, if they are not declared the base class will do what it needs to without an issue | 15:26 |
| giulivo | if I implement some BaseObjectTest and in my setUpClass don't call super, is that detected? | 15:27 |
| afazekas | You are free to not declare those methods, but if you do, you need to call the super | 15:27 |
| afazekas | giulivo: If you have at least on test case in the class , yes | 15:28 |
| giulivo | okay so I misread that because I thought that was only working on the baseTestCaase | 15:28 |
| giulivo | then now I understand the reason for the check | 15:28 |
| afazekas | cool :) | 15:29 |
| giulivo | so I can change my review | 15:29 |
| afazekas | giulivo: thank you | 15:31 |
| giulivo | sorry for the confusion | 15:31 |
| afazekas | np | 15:32 |
| afazekas | giulivo: https://review.openstack.org/#/c/39752/ what is the issue with this ? | 15:35 |
| giulivo | afazekas, oh that's a long story | 15:36 |
| giulivo | we tried to address that before the meeting with mkoderer | 15:36 |
| giulivo | basically we had two constrasting suggestions | 15:36 |
| giulivo | mkoderer, suggested to split those into as many separated stress tests | 15:36 |
| giulivo | I suggested to merge those into a single more scenario-like stress test | 15:36 |
| giulivo | (cause I don't see what we would be stressing by just running pause/unpause concurrently) | 15:36 |
| afazekas | I would suggest random action call based on valid transition table | 15:37 |
| giulivo | agreed, indeed I don't see what is the point of those tests the way they are now | 15:37 |
| giulivo | they'd better be served by running the existing pause/unpause api unit tests as stress | 15:38 |
| afazekas | It can be changed to different way anytime, now we do not have action calling stress test, so not the ideal form is also more then not having those | 15:38 |
| openstackgerrit | David Kranz proposed a change to openstack/tempest: Provide tox entry for running slow heat tests https://review.openstack.org/40897 | 15:38 |
| giulivo | afazekas, but again, the way they are now, they're just the api tests runned concurrently, that is something which can be addressed by your change to run api tests as stress tests | 15:39 |
| giulivo | instead, making them some sort of scenario tests for those, bring it closer to your idea of a transition table | 15:39 |
| afazekas | https://review.openstack.org/#/c/38980/ | 15:39 |
| giulivo | yes that is what I'd have used | 15:40 |
| afazekas | what is the problem with setUpClass/tearDownClass ? | 15:40 |
| giulivo | wait a sec | 15:40 |
| giulivo | so regarding the stress tests, I don't see the reason to merge those the way they are now | 15:40 |
| giulivo | IMHO we either run the api tests or make them a scenario | 15:40 |
| giulivo | instead, regarding the last review , 38980 | 15:41 |
| giulivo | what I'm suggesting there is to drop the support for "per thread" or "global" setUp/tearDown | 15:41 |
| giulivo | and stick with per thread execution | 15:42 |
| afazekas | one option never harms, especially if the default value is what you like | 15:42 |
| afazekas | I think both cases is useful | 15:43 |
| giulivo | I think both cases is useful too, but I agree with dkranz that there is potential for that to be wrongly used | 15:44 |
| mtreinish | sdague: so on https://review.openstack.org/#/c/40723/ afazekas pointed out the logs aren't full anymore the solution to this is to enable the debug option. (because testr doesn't screw up logging settings like nose) | 15:45 |
| mtreinish | should I fix it in the tempest.conf.sample or just set it in devstack? | 15:45 |
| openstackgerrit | A change was merged to openstack-dev/devstack: Add call trace in error message https://review.openstack.org/39887 | 15:45 |
| *** krtaylor has joined #openstack-qa | 15:46 | |
| afazekas | giulivo: anything can be used wrongly, it is not a reason not to create them. | 15:47 |
| giulivo | afazekas, oh that's not what I'm saying either, I'm all for approving that | 15:48 |
| afazekas | mtreinish: I would prefer If the sample would make it good, but for me either way is ok | 15:48 |
| giulivo | was just suggesting a little change on that particular option | 15:48 |
| mtreinish | afazekas: my only concern with doing it in the sample is that debug logging is on by default for anyone who uses the sample as a base config | 15:49 |
| mtreinish | and I'm sure that there are use cases where the debug logs aren't useful (they normally aren't) | 15:49 |
| afazekas | mtreinish: It is test tool, you must be very optimistic to not use it on debug level :) | 15:50 |
| afazekas | BTW: is anybody ever tried to disable the debug or verbose mode in devstack ? | 15:51 |
| dkranz | afazekas, giulivo How should we resolve https://review.openstack.org/#/c/38980/ | 15:51 |
| giulivo | dkranz, that is what we were discussing ... I think that is a very nice addition, my only concern was about the setting for "per thread" or "global" setUp/tearDown execution, I'd prefer that to be removed to avoid false errors despite it being an useful option for some use cases | 15:54 |
| dkranz | giulivo: Makes sense to me. | 15:54 |
| afazekas | dkranz: As I remember the scenarios are not working multiple times If you call the setUpClass twice, there is a manager related logic in the test.py which prevents it. | 15:55 |
| *** mkollaro has quit IRC | 15:57 | |
| dkranz | afazekas, giulivo I can live with whatever you guys agree. | 15:57 |
| afazekas | https://review.openstack.org/#/c/40680/ this has more option, and looks like triggered something else what we saw on the gate as well. | 16:01 |
| *** anteaya has quit IRC | 16:01 | |
| giulivo | afazekas, so let's try this | 16:02 |
| giulivo | I'll propose a rename for the option (so that hopefully it is easier to understand what it does) and +1 | 16:02 |
| giulivo | makes sense? | 16:02 |
| afazekas | ok | 16:03 |
| giulivo | I'd call that class_setup_per_thread rather than class_setup_in_run | 16:03 |
| giulivo | looks okay? | 16:03 |
| giulivo | or maybe you've better ideas? | 16:03 |
| afazekas | ok | 16:04 |
| afazekas | I think I will keep only the test_method option, with a full method name | 16:05 |
| * giulivo didn't really want to stop that, I'd like to have some -0.5 to gerrit :) | 16:05 | |
| afazekas | It makes easier to copy the failing test method form the output :) | 16:05 |
| giulivo | you mean remove the option completely? | 16:06 |
| afazekas | you know it rounds to 0 :) | 16:06 |
| afazekas | "test_class": "tempest.cli.simple_read_only.test_glance.SimpleReadOnlyGlanceClientTest" | 16:06 |
| afazekas | "test_method": "test_glance_fake_action", | 16:06 |
| afazekas | will be | 16:06 |
| giulivo | doh | 16:06 |
| giulivo | keep the option, I know it'll be useful | 16:06 |
| afazekas | "test_method": "tempest.cli.simple_read_only.test_glance.SimpleReadOnlyGlanceClientTest.test_glance_fake_action" | 16:06 |
| *** thomasbiege2 has joined #openstack-qa | 16:07 | |
| giulivo | oh I agree with that | 16:07 |
| giulivo | that is nice | 16:07 |
| *** thomasbiege1 has quit IRC | 16:07 | |
| afazekas | I'll do it tomorrow | 16:08 |
| *** SergeyLukjanov has quit IRC | 16:11 | |
| giulivo | doh | 16:11 |
| *** mkollaro has joined #openstack-qa | 16:13 | |
| *** fbo is now known as fbo_away | 16:14 | |
| mkoderer | giulivo: there are new about https://review.openstack.org/#/c/39752/? | 16:20 |
| giulivo | says I've no permissions to open | 16:20 |
| *** anteaya has joined #openstack-qa | 16:48 | |
| sdague | mkoderer: did you put it in draft by accident? | 16:56 |
| mkoderer | sdague: where? | 16:56 |
| mkoderer | sdague: I don't see it...? | 16:57 |
| sdague | oh, the ? at the end is messing up gerrit :) | 16:57 |
| sdague | giulivo: https://review.openstack.org/#/c/39752/ | 16:57 |
| giulivo | hi there, thanks | 16:58 |
| mkoderer | sdague: which "?" .... | 16:58 |
| sdague | mkoderer: giulivo: there are new about https://review.openstack.org/#/c/39752/? | 16:59 |
| sdague | xchat links with the ? | 16:59 |
| sdague | ok, almost qa meeting time | 16:59 |
| giulivo | so I tried to add all I had to say in the review, to me in this layout they don't hurt but aren't very helpful, we could easly run the api tests concurrently by using this https://review.openstack.org/#/c/38980/ | 16:59 |
| giulivo | and avoid to maintain two copies | 16:59 |
| giulivo | of the same test | 16:59 |
| *** fbo_away is now known as fbo | 17:17 | |
| *** HenryG has quit IRC | 17:25 | |
| mkoderer | sdague: I think we don't need this patch ... | 17:26 |
| *** SergeyLukjanov has joined #openstack-qa | 17:39 | |
| *** thomasbiege has joined #openstack-qa | 17:45 | |
| *** thomasbiege2 has quit IRC | 17:45 | |
| *** annegentle is now known as annegentle_vacay | 17:53 | |
| afazekas | sdague: I will chat with dprince about how to move a new OS the gate, but he is vocation AFAIK, so next week | 18:02 |
| giulivo | mkoderer, when you said " I think we don't need this patch ... " you meant https://review.openstack.org/#/c/38980/ ? | 18:03 |
| afazekas | kashyap: are you here ? | 18:04 |
| *** krtaylor has quit IRC | 18:04 | |
| openstackgerrit | A change was merged to openstack/tempest: Change logging in stress test https://review.openstack.org/40566 | 18:15 |
| *** jhenner has joined #openstack-qa | 18:36 | |
| *** psedlak has quit IRC | 18:48 | |
| *** mkollaro has quit IRC | 18:57 | |
| *** thomasbiege has quit IRC | 19:10 | |
| *** adalbas has quit IRC | 19:29 | |
| dkranz | afazekas: dprince is back from vacation. | 19:29 |
| *** adalbas has joined #openstack-qa | 19:44 | |
| *** annegentle_vacay has quit IRC | 19:53 | |
| openstackgerrit | James E. Blair proposed a change to openstack-infra/devstack-gate: WIP: new nodepool https://review.openstack.org/40952 | 20:09 |
| *** dkranz has quit IRC | 20:23 | |
| *** woodspa has quit IRC | 20:47 | |
| *** SergeyLukjanov has quit IRC | 20:54 | |
| *** SergeyLukjanov has joined #openstack-qa | 20:54 | |
| *** krtaylor has joined #openstack-qa | 21:13 | |
| openstackgerrit | A change was merged to openstack-dev/devstack: Add tools/install_pip.sh https://review.openstack.org/39827 | 21:23 |
| openstackgerrit | Matthew Treinish proposed a change to openstack/tempest: Rework class inheritance for scenario tests https://review.openstack.org/40975 | 21:32 |
| openstackgerrit | Matthew Treinish proposed a change to openstack/tempest: Add tenant isolation for scenario tests https://review.openstack.org/39099 | 21:32 |
| *** annegentle has joined #openstack-qa | 21:40 | |
| *** lexinator has joined #openstack-qa | 21:58 | |
| *** SergeyLukjanov has quit IRC | 21:59 | |
| *** burt has quit IRC | 22:07 | |
| *** mriedem has quit IRC | 22:12 | |
| *** weshay has quit IRC | 22:24 | |
| openstackgerrit | A change was merged to openstack/tempest: Added negative tests for server https://review.openstack.org/40813 | 22:26 |
| *** fbo is now known as fbo_away | 22:29 | |
| *** afazekas has quit IRC | 22:41 | |
| *** adalbas has quit IRC | 22:43 | |
| *** afazekas has joined #openstack-qa | 22:44 | |
| openstackgerrit | Dean Troyer proposed a change to openstack-dev/devstack: Add support for Docker as Nova hypervisor https://review.openstack.org/40759 | 23:38 |
| *** wramthun has quit IRC | 23:51 | |
| *** wramthun has joined #openstack-qa | 23:53 | |
| *** jhenner has quit IRC | 23:54 | |
| *** wramthun has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!