Friday, 2013-08-09

*** stevebaker has quit IRC00:00
*** stevebaker has joined #openstack-qa00:06
*** krtaylor has quit IRC00:09
*** lexinator has quit IRC00:28
openstackgerritMatthew Treinish proposed a change to openstack/tempest: Switch to testr serial instead of nose  https://review.openstack.org/4072300:37
*** lexinator has joined #openstack-qa00:38
*** lexinator1 has joined #openstack-qa00:44
*** lexinator has quit IRC00:44
afazekasdkranz: cool01:09
*** lexinator1 is now known as Lexinator01:19
openstackgerritA change was merged to openstack-dev/devstack: misleading source filename in error message  https://review.openstack.org/3988901:30
*** wramthun has joined #openstack-qa01:58
*** Lexinator has quit IRC02:10
*** HenryG has joined #openstack-qa02:20
*** LiangZheng has joined #openstack-qa02:24
openstackgerritMike Perez proposed a change to openstack-dev/devstack: Add Cinder V2 API to keystone catalog  https://review.openstack.org/2248902:27
*** annegentle has quit IRC02:28
*** wramthun has quit IRC03:04
*** mordred has quit IRC03:04
*** mordred has joined #openstack-qa03:07
kashyapafazekas, Hey, I'm in Charleston, US, traveling...03:18
*** annegentle has joined #openstack-qa03:25
*** anteaya has quit IRC03:27
*** SergeyLukjanov has joined #openstack-qa03:46
*** giulivo has quit IRC03:57
*** SergeyLukjanov has quit IRC04:11
openstackgerritArata Notsu proposed a change to openstack/tempest: Set a preffered region for all services  https://review.openstack.org/4102604:33
*** afazekas_ has joined #openstack-qa04:47
*** afazekas_ has quit IRC04:48
*** afazekas_ has joined #openstack-qa04:48
Anjuafazeaks:are u there?05:02
Anjuafazekas: i ahve amde the upload function fopr xml also05:03
Anjui have made the upload function fopr xml also05:03
Anjuafazekas: should ia dd this05:04
Anjubut some two more xml tests cases are missing05:04
Anjufor attach and dettach volume05:04
Anjuplease suggest me05:04
*** wramthun has joined #openstack-qa05:05
*** marun has quit IRC05:26
*** marun has joined #openstack-qa05:27
mkodererGood morning / Good afternoon india ;)05:54
Anju: ) good morning mkoderer05:54
Anju11:22 am05:54
mkodererohhh.. next time ;)05:54
Anju:)05:54
*** sourabh has joined #openstack-qa05:59
sourabhhi mkoderer05:59
sourabhhttps://review.openstack.org/#/c/39752/ ??05:59
mkoderersourabh: hi, good that you are here06:00
mkoderersourabh: so we discussed it yesterday..06:00
sourabhjust joined :)06:00
mkodererthe finial plan it to use the existing api / scenario test for stress tests06:01
sourabhok06:01
mkodererso with that we don't need to duplicate stuff inside the stress test framework06:01
sourabhyeah good idea!!06:02
mkoderersourabh: so I am sorry to say, but I think you could abandon you change06:02
sourabhok, no problem06:02
mkoderersourabh: but we have a lot of stuff to do... so if you want to help :)06:02
sourabhyes sure...06:03
mkodererI will try to make a proposal for the new design in the next days06:03
mkodererbut we already have the first step with https://review.openstack.org/#/c/38980/06:04
sourabhYes, I am also waiting for it.06:05
mkodereryes, I will try to push it ;)06:05
sourabhok good luck ;)06:07
*** sourabh has quit IRC06:16
*** yfried has joined #openstack-qa06:36
*** yfried has left #openstack-qa06:37
openstackgerritnayna-patel proposed a change to openstack/tempest: Added test case to check floating IP API operations  https://review.openstack.org/4103807:22
*** giulivo has joined #openstack-qa07:29
*** fbo_away is now known as fbo07:38
openstackgerritFabien Boucher proposed a change to openstack/tempest: Add tests for swift container listing filters  https://review.openstack.org/4041607:42
afazekas_mkoderer: I am going to update that patch as we discussed in several hours07:43
*** afazekas has quit IRC07:44
*** afazekas_ is now known as afazekas07:44
mkodererafazekas: ok great07:45
*** SergeyLukjanov has joined #openstack-qa07:49
afazekasgiulivo: for the 'class_setup_per_thread' I need  to negate the flags' meaning right ?07:51
giulivohi afazekas07:52
giulivomorning07:52
afazekasgood morning :)07:52
giulivoI'm not sure if that a good naming choice, I just tried to think about a "self explanatory" name07:53
afazekaslooks like devstack master is unbreaken on fedora 19 :)07:53
afazekasclass_setup_once07:54
giulivoafazekas, also good for me07:54
*** jhenner has joined #openstack-qa07:55
afazekasclass_setup_once_per_thread07:58
*** thomasbiege has joined #openstack-qa07:58
giulivoso I'd read _once as it is executed only once and not per thread07:59
giulivowhat would _once_per_thread mean?07:59
afazekasin the json file you can specify the number of the worker threads(processes).  the setupclass called once per thread or by each run08:04
* afazekas note: on linux the tread/process terminology is very tricky, based on the context08:07
openstackgerritYuuichi Fujioka proposed a change to openstack/tempest: Add a test case for instance boot from volume  https://review.openstack.org/4104808:29
openstackgerritnayna-patel proposed a change to openstack/tempest: Added test case to check floating IP API operations  https://review.openstack.org/4103808:48
openstackgerritafazekas proposed a change to openstack/tempest: Unit tests as stress tests  https://review.openstack.org/3898008:48
giulivoafazekas, I knew the functionality08:48
giulivoI was arguing that _once_per_thread isn't easy to read as it doesn't immediately tell if it is executed once OR per_thread08:49
giulivoafazekas, so I'd use "_per_thread" OR "_once" but not both08:50
afazekasgiulivo: Please tell mi if something not ok with the above patch, I am not sure I will have time later to update it today08:50
giulivoit's just a rename of the variable! :)08:50
giulivoplease!08:50
giulivo_per_thread08:50
afazekaslooks like i find bugs what I did not searched, and I need to create some report ..08:51
afazekass/class_setup_once_per_thread/class_setup_per_thread/ ok ?08:52
giulivonp I've +108:53
openstackgerritYuuichi Fujioka proposed a change to openstack/tempest: Add a test case for instance boot from volume  https://review.openstack.org/4104808:54
*** jhenner has quit IRC08:58
*** dosaboy_ has joined #openstack-qa09:01
*** dosaboy has quit IRC09:02
giulivoafazekas, if you take a look at this (and re-approve, sorry about) https://review.openstack.org/#/c/38943/ it would be great09:04
afazekasgiulivo: both the owner and the other +2 is from RH. I would wait for a non RH +2.  If it not get approved or -1 today , I will check how trivial is the rebase09:09
afazekasjaypipes, sdague, cyeoh, mtreinish :  can you review this https://review.openstack.org/#/c/38943/09:11
openstackgerritRoman Prykhodchenko proposed a change to openstack-dev/devstack: Base support of Ironic  https://review.openstack.org/4105309:29
mkodererafazekas: could you have a look https://github.com/openstack/tempest/blob/master/tempest/services/volume/json/volumes_client.py#L8809:35
mkoderershouldn't this function be called "upload_image"?09:36
mkodererahh ok .. now I get it.. it uploaded an volume into glance09:36
Anjumkoderer u can try this using a cli09:37
mkoderer... I just misread it...09:38
Anjuhmm09:38
Anjumkoderer : my question is can u run a cli for attach-volume and dettach-volume09:39
Anju https://github.com/openstack/tempest/blob/master/tempest/services/volume/json/volumes_client.py#L8809:39
Anjuthese two are available here09:40
afazekasmkoderer: I will have closer look to that test case soon09:42
*** psedlak has joined #openstack-qa09:45
openstackgerritRoman Prykhodchenko proposed a change to openstack-dev/devstack: Basic support of Ironic  https://review.openstack.org/4105309:45
mkodererAnju: did it09:46
mkoderernova volume-attach 3b1a2175-f717-48bc-afaf-d3c745b505e3 7d86aa2c-d930-4f56-8489-2605e80ff2d4 /dev/bla09:46
mkodererworks09:46
Anjuusing cinder?09:46
mkodererno, since volume-attach is not a cinder command ;)09:47
Anjuok   checking thanks09:47
mkodererAnju: http://docs.openstack.org/user-guide/content/boot_from_volume.html09:47
Anjumkoderer: thanks : for nova i was able to run this one :) it good i will take response using this one  :)09:48
Anjuthanks09:48
*** LiangZheng has quit IRC10:28
mkoderermtreinish: ping10:43
giulivoafazekas, agreed on the scenario tests ... on the first patch jaypipes reviewed too, let's wait for some more input11:08
mkodererafazekas: regarding https://review.openstack.org/#/c/38980/11:11
mkodererI still have my opinion that this shouldn't be a test action - it should be supported by the driver itself11:12
openstackgerritNejc Saje proposed a change to openstack/tempest: Adds client and CRUD tests for Ceilometer alarms  https://review.openstack.org/3923711:16
afazekasmkoderer: AFAIK there are more test families, so it can be plugin11:19
afazekaswe might have an arbitrary program (like shell script) plugin as well11:19
mkodererafazekas: on other thing... which I already forgot - why do we need to run setUp inside of run()?11:21
afazekasmkoderer: why is it problem if you need to specify a handler class instead of selecting the type in another type of variable ?11:21
afazekasmkoderer: If you would like to replicate the setUpclass and tearDown class steps in every run11:22
afazekasfor example on server actins you might just wwant to do the actions without a new server creation11:23
mkodererafazekas: one reason is the logging11:23
mkodererif you get an exection it will be logged for all classes as "unittest"11:23
mkodererthat's a bit odd.. but maybe a minor issue11:24
afazekasmkoderer: the unittest driver can be improved  in the future11:24
afazekasI did not wanted to over complicate it at the first step11:25
mkodererafazekas: ok got it... so mainly the unit test are creating their resources on setUp... if you fork a new process the will use the same11:25
mkodererok I see11:26
mkodererafazekas: ok that's right .. let's have this simple one at the beginning11:27
afazekasI can't recall which class loading creates a differnt class, and which not, but the class can be loaded to be differnt class even if it's name and package is the same11:27
afazekasthe 'address'  matters11:27
mkodererafazekas: right you instanciate always a new object11:29
*** woodspa has joined #openstack-qa11:29
afazekasmkoderer: they are in different process and the class loaded after  fork (actually clone used without CLONE_VM)11:32
mkodererafazekas: in case of class_setup_once it will fork afterwards11:34
mkodererso setUp will be called on the parent and then forked11:35
afazekasmkoderer: thx11:38
mkodererafazekas: maybe we need to run setUp for every forked process.. otherwise all the processes will  run on the same resources11:40
afazekasmkoderer: It should be replaced to inspection based import11:42
*** weshay has joined #openstack-qa11:44
mkodererafazekas: would this help? At the end it's just important that every process runs it's initialization and generates the resources that is needed for the test11:44
*** dkranz has joined #openstack-qa12:03
afazekasAfter a reload(sys.modules[klass_module))   you will have a different class12:03
*** SergeyLukjanov has quit IRC12:08
* afazekas reevaluate 12:14
afazekasmkoderer: what if we just move the setUpclass call in the run and changing a variable when it ever runed in the process .. ?12:17
*** dosaboy_ is now known as dosaboy12:18
* afazekas eat something, after that I add simple variable based thing, what just modified after fork12:21
openstackgerritFabien Boucher proposed a change to openstack/tempest: Add tests for swift container listing filters  https://review.openstack.org/4041612:39
*** thomasbiege has quit IRC12:41
*** adalbas has joined #openstack-qa12:45
mkodererafazekas: yes I think we need to move it12:53
mkodererafazekas: how should this variable be exposed? cli or json?12:54
afazekasthere will 3 option12:54
afazekasper application, per action, per process12:54
mkodererok - upload it when your done.. want to see the code ;)12:55
afazekasThe change is done, but I would like to try at least with one option, is it able to start:)12:55
mkoderer;) right12:56
*** jasondotstar has joined #openstack-qa13:10
openstackgerritafazekas proposed a change to openstack/tempest: Unit tests as stress tests  https://review.openstack.org/3898013:10
*** russellb is now known as rustlebee13:14
*** mriedem has joined #openstack-qa13:14
afazekasdkranz: https://review.openstack.org/#/c/40897/1/tox.ini13:18
afazekasDo we need an orchestration directory in the scenario ?13:19
*** thomasbiege has joined #openstack-qa13:19
afazekasthe others are not structured .13:20
dkranzafazekas: This is for the slow heat tests13:20
dkranzafazekas: There may be slow tests that are not heat tests and we don't want to include them13:20
afazekasso this job wil be osed just only by heat13:20
afazekasand heat will get new folder in the scenario ?13:20
dkranzafazekas: Yes, there will be a separate gate job.13:21
dkranzafazekas: Yes, sbaker is moving the slow tests to scenario13:21
afazekasbut the regexp looks like wants a new folder13:21
afazekas\.orchestration does not seams to required13:22
dkranzafazekas: Yes, you are right.13:22
dkranzafazekas: I forgot that scenario does not have these subdirs.13:22
dkranzafazekas: So the regexp part for api needs to be different than scenario13:23
dkranzafazekas: This is ugly. Perhaps there should be orchestration subdir of scenario anyway13:23
afazekasDo we want to limit that job to heat only ?13:24
dkranzafazekas: For now. But some ceilometer might be added.13:24
afazekasif not probably just the flag matching is enough13:25
dkranzafazekas: What do you propose specifically?13:25
afazekasIMHO easier to not limit13:25
dkranzafazekas: I have to step out for about 20min13:26
afazekasIMHO most of the scenario tests touching many thing anyway13:26
afazekasok13:26
openstackgerritFabien Boucher proposed a change to openstack/tempest: Add tests for swift container listing filters  https://review.openstack.org/4041613:28
mkodererdkranz: should I set my set my review to 0 or is it ok to let it like it is?13:33
mkodererdkranz: ahh and in requirements.txt nose is also left...13:33
mkodererdkranz: it's about https://review.openstack.org/#/c/40723/13:34
openstackgerritRoman Prykhodchenko proposed a change to openstack-dev/devstack: Basic support of Ironic  https://review.openstack.org/4105313:35
openstackgerritMate Lakat proposed a change to openstack-dev/devstack: fix permission issues around dist-packages  https://review.openstack.org/4109113:50
dkranzmkoderer: I am going to mark this WIP until the tests we are looking for are finalized.13:50
dkranzmkoderer, afazekas : Then we will know what the regexp should be. Or maybe we will just list the tests we want explicitly.13:51
mkodererdkranz: are you talking about https://review.openstack.org/#/c/40897 or https://review.openstack.org/#/c/40723/?13:52
dkranzmkoderer: Sorry, wrong one. Looking at the one you meant how.13:53
dkranzmkoderer:   now13:53
*** burt has joined #openstack-qa13:53
afazekasdkranz: just exclude the .orchestration and I will do not have any other question13:54
dkranzmkoderer: I think you could change it to 013:54
afazekasThis should be merged soon, for the slow PoC jenkins job13:54
mkodererdkranz: ok13:54
dkranzmkoderer: This patch was "use testr for serial", not "purge nose from the code base"13:54
dkranzmkoderer: If that is what we really want it can be another patch.13:54
mkodererdkranz: you're right  - thx for the feedback13:55
dkranzmkoderer: NP. Note that I will be out on vacation next week.13:55
dkranzafazekas: slow PoC?13:56
afazekasdkranz: For the POC slow job this is OK,13:56
*** anteaya has joined #openstack-qa13:56
afazekasdkranz: sbaker added two slow tag13:56
dkranzafazekas: Yeah, but I don't see why we need to do this now. We should just wait until the heat tests are ready.13:57
dkranzafazekas: I thought I would get ahead of it but now does not seem worth it especially since I will be out next week.13:57
mkodererdkranz: happy holidays then... would need some day too ;)13:58
afazekasdkranz: IMHO when the tox entry is there , anybody else can try to setup a job for this13:58
afazekasnow those tests are excluded :(13:58
dkranzafazekas: There is more work to do in devstack gate for the heat stuff. Some new env variables to set.13:59
dkranzafazekas: https://review.openstack.org/#/c/40341/13:59
dkranzafazekas: If you want to take this over while I'm gone that is fine.14:00
afazekasdkranz: I want to do too many thing... I think the tempest part be there is the most critical, the other projects has enough reviewers14:01
dkranzafazekas: The actual real tests are still being blocked by some disk image stuff.14:02
dkranzSo this can wait another week I think.14:02
*** krtaylor has joined #openstack-qa14:06
* afazekas sorry guys I got life IRQ, I had to leave now..14:08
mkodererhave a nice weekend14:09
*** afazekas has quit IRC14:11
dkranzjaypipes: Hi Jay. You gave this a +2 before. Can you +A it please?14:14
mtreinishmkoderer: pong14:16
mkoderermtreinish: hi14:17
mkoderermtreinish: I have some questions about testr14:17
mkoderermtreinish: you are the expert right?14:17
mtreinishmkoderer: sure.....14:18
mkodererI am trying to add a decorator for the stress test14:18
mkodererand now I need the test list filtered by this decorator14:18
mkodereris there a way to do this with a testr function?14:19
mkodereror am I at the wrong lib?14:19
mtreinishmkoderer: a stress test, test attr decorator14:19
mtreinishkind of like gate, slow, smoke?14:19
mtreinishor something else14:19
mkodererI need some special parameters14:19
mkodererso possible a new one14:19
mkodererlike @stresstest(max_threads=5)14:20
mkodereror do you think a new attr would be better?14:20
mkodererI just want to reuse the function to select function with a certain decorator14:21
mtreinishmkoderer: well you could just make that stresstest decorator set the attr and do whatever else you need14:21
mtreinishmkoderer: to be able to select the tests you want to run from testr you need to be able to use a regex to filter it from the test id14:21
jaypipesdkranz: which one?14:21
*** lexinator has joined #openstack-qa14:22
mtreinishmkoderer: setting the attr makes that easy because it appends the tag name to the test id14:22
dkranzjaypipes: Sorry :) https://review.openstack.org/#/c/38943/14:23
mkoderermtreinish: mhh I have to think about it... my plan is that run_stress uses testr as a library14:23
mkoderermtreinish: so it just uses to find test cases with the certain decorator14:23
jaypipesdkranz: ah yes, done.14:24
mkoderermtreinish: do you understand what I mean?14:25
dkranzjaypipes: THx14:26
mtreinishmkoderer: I'm not sure, you want run_stress to call testr to select the tests that have a certain decorator? Does it run them or just dump them somewhere?14:26
mkoderermtreinish: I just want a list of functions to be called14:27
mkoderermtreinish: run_stress will use them and create the needed processes14:27
mkoderermtreinish: maybe testr could be enhanced to be used for it14:27
*** thomasbiege has quit IRC14:28
mtreinishmkoderer: well testr just uses subunit discover to find the tests. Take a look at .testr.conf to see what it runs.14:29
mkoderermtreinish: aha right.. this one:  subunit.run discover -t ./ ./tempest $LISTOPT $IDOPTION14:29
mkodererbut I don't see how the subunit parameter is used there14:30
mtreinishmkoderer: if you run testr run --parallel it'll print out the commands it's using to find the tests and then run the tests.14:31
mkodererok let me try14:31
*** adalbas has quit IRC14:33
openstackgerritJoe Hakim Rahme proposed a change to openstack/tempest: Add more tests for Swift Account Quota  https://review.openstack.org/4109914:34
mkoderermtreinish: so if I start "testr run --parallel --subunit smoke"14:34
mkodererI get this output: ${PYTHON:-python} -m subunit.run discover -t ./ ./tempest --list14:34
mkodererI don't see where my parameter "smoke" is used in subunit14:35
*** afazekas has joined #openstack-qa14:36
*** mlavalle has joined #openstack-qa14:37
mlavallemtreinish: ping14:38
kashyapafazekas, Just drop me an email if you need me. I'm at Fedora conference. My responses will be sporadic14:42
afazekaskashyap: I just wanted to ask is the latest Fedora image on the main download page, or there is another source ?14:43
afazekasnew the ks files just using the stable repo, I will try it again (I had repo sync issue..)14:44
mtreinishmkoderer: so, python -m subunit.run discover -t ./ ./tempest --list will generate the list of tests14:44
mtreinishand then smoke will be a regex filter on the list14:44
mtreinishI can dig up the code for you14:44
mtreinishmlavalle: pong14:44
mkoderermtreinish: ahhh ok thats easy...14:45
mkoderermtreinish: thanks for that14:45
afazekaskashyap: I want to switch my image, to something based on the official image14:45
mlavallemtreinish: thanks for the help with the review. So, what do you suggest now going forward? Wait for your https://review.openstack.org/#/c/40969/ to merge and then continue with mine?14:46
mtreinishmlavalle: I think you're looking for mriedem not me14:47
mlavallesorry14:47
*** adalbas has joined #openstack-qa14:48
mriedemmlavalle: i'm assuming you're referring to the relation on this? https://review.openstack.org/#/c/39006/14:48
mlavallemriedem: yes!14:49
mriedemmlavalle: let's go to openstack-nova14:49
mlavallesee you there14:49
*** afazekas has quit IRC14:56
openstackgerritgordon chung proposed a change to openstack-dev/devstack: Cinder configuration is not set up for Ceilometer  https://review.openstack.org/4110814:56
mtreinishsdague, dkranz, afazekas: can I get eyes on https://review.openstack.org/#/c/40975/ (dkranz thanks) and https://review.openstack.org/#/c/39099/14:57
mtreinishthey should fix the last big testr race14:57
mtreinishjaypipes: ^^^ you too :)14:57
*** burt has quit IRC15:02
openstackgerritA change was merged to openstack/tempest: Switch to testr serial instead of nose  https://review.openstack.org/4072315:10
openstackgerritMatthew Treinish proposed a change to openstack-dev/devstack: Enable debug logging on tempest  https://review.openstack.org/4111315:16
jaypipesmtreinish: \o/15:25
jaypipesmtreinish: nice work :)15:25
openstackgerritA change was merged to openstack/tempest: scenario test involving glance, cinder and nova functionalities  https://review.openstack.org/3894315:32
*** lexinator has quit IRC15:33
*** meteorfox has joined #openstack-qa15:39
mtreinishjaypipes: well I doubt it's the last of the races, but it's the last one that is failing most of the runs....15:44
*** lexinator has joined #openstack-qa15:56
*** comstud is now known as bearhands16:07
openstackgerritA change was merged to openstack/tempest: Rework class inheritance for scenario tests  https://review.openstack.org/4097516:20
*** mriedem has quit IRC16:25
*** krtaylor has quit IRC16:29
*** mriedem has joined #openstack-qa16:38
*** giulivo has quit IRC16:42
*** burt has joined #openstack-qa16:43
*** jog0 is now known as flashgordon16:48
*** lexinator has quit IRC16:56
*** lexinator has joined #openstack-qa17:00
*** jhenner has joined #openstack-qa17:07
*** krtaylor has joined #openstack-qa17:11
*** fbo is now known as fbo_away17:26
*** jhenner has quit IRC17:32
*** hemnafk is now known as hemna17:42
openstackgerritSean Dague proposed a change to openstack-dev/devstack: cleanup potentially installed older oslo.config  https://review.openstack.org/4115317:45
sdaguedtroyer: you about?17:46
dtroyerabout dead maybe17:59
dtroyertgif and all that17:59
openstackgerritSean Dague proposed a change to openstack-dev/devstack: cleanup potentially installed older oslo.config  https://review.openstack.org/4115318:05
sdagueheh18:06
sdaguedtroyer: so do you have a better solution than this - https://review.openstack.org/#/c/41091/ ?18:19
sdaguebecause we need some kind of fix18:20
dtroyernot yet, but that's a terrible hack.  is this only happening on previously-used devstack machines?18:21
sdaguedtroyer: totally clean basic installs hit it18:21
sdagueI just started with precise cloud image18:22
openstackgerritA change was merged to openstack-dev/devstack: Remove unused keystone params from neutron agents' config files  https://review.openstack.org/3976318:27
dtroyeram doing that now too.  and I think I've used up all of my old installs, may need to get the de Lorean out to find one to try again18:27
openstackgerritMatthew Treinish proposed a change to openstack/tempest: Add tenant isolation for scenario tests  https://review.openstack.org/3909918:48
openstackgerritSlickNik proposed a change to openstack-dev/devstack: Added Trove (Database as a Service).  https://review.openstack.org/3816918:55
dtroyersdague: so, uh, get this.  the permissions issue with prettytable is a *drumrole* permissions issue *IN* prettytable's dist zipfile.19:01
dtroyerit has broken us again19:01
sdaguehah!19:01
dtroyerso we can either ban 0.7.2 or try to install it separately and fix it19:02
dtroyerwait…it's been that way since april.  wtf?19:03
mtreinishsdague: So, I'm going through the requirements list right now. The first thing I hit on a clean box is that virtualenv and tox aren't installed using the lists.19:07
mtreinishis that something we should include on the requirements list or just assume that people are smart enough to install it19:08
sdaguemtreinish: requirements, or devstack package list19:11
sdagueit used to work on a clean box19:11
openstackgerritA change was merged to openstack/tempest: Skip secgroup invalid name/desc tests until bug 1161411 is fixed  https://review.openstack.org/4066619:12
mtreinishsdague: I just spun up a bare ubuntu cloud image guest, installed pip, then ran pip install -r requirements.txt (also test-requires too)19:12
sdaguemtreinish: ok19:14
sdagueworks now?19:14
mtreinishactually I'm not sure it was missing virtualenv looks like it was a permissions issue on httplib219:14
mtreinishyeah install_venv_common takes care of installing the virtualenv requirement when you use run tests19:18
mtreinishbut easy_install failed on a permissions issue on httplib219:18
mtreinishas for tox that still needs to be installed from what I can tell19:18
sdaguemtreinish: can we get a good enough tox out of the distro?19:21
mtreinishyeah probably, I'm pretty sure devstack already takes care of that19:22
mtreinishI was testing the requirements list outside of devstack to make sure it was complete19:22
mtreinishsdague: also, looks like I hit the permissions issue with devstack too: http://paste.openstack.org/show/43732/19:24
flashgordonrandom question, is it possible to get req-ids in the tempest console output for failed tests?19:42
flashgordonfor example http://logs.openstack.org/64/40764/5/check/gate-tempest-devstack-vm-full/ea1d1d1/console.html.gz19:42
flashgordonI have a failed test but have to manaully search the n-api logs to find the matching request19:42
mtreinishflashgordon: does nova include the request id in the response?19:43
flashgordonmtreinish: yes19:43
flashgordonunder x-compute-request-id19:44
mtreinishflashgordon: then it should be possible to log it. But, I'm not sure about the fails at the bottom of the run though. That's just a traceback printed by the test runner when a test fails or errors.19:45
flashgordonmtreinish: isn't there a way to log stdout too?19:46
flashgordonso print out every req-id and testr only prints stdout for failed19:46
mtreinishflashgordon: we have testr set to capture stdout and stderror19:47
mtreinishyeah I guess that would work19:47
* flashgordon files a tempest bug19:47
flashgordonmtreinish: https://bugs.launchpad.net/tempest/+bug/121063919:49
mtreinishflashgordon: ok cool19:55
flashgordonmtreinish: thanks, my standard debug procedure is find the req-id of failed test and grep for it19:56
mtreinishflashgordon: yeah I do the same thing too. (normally by using the class name to find the isolated creds for the class as a start)19:57
mtreinishit's a good idea I'll probably push something out for it soon19:57
mtreinishit'll help with the parallel debug too...19:57
flashgordon\o/20:00
mtreinishsdague, dkranz, jaypipes: can you take a look at the new revision for https://review.openstack.org/#/c/39099/20:06
*** psedlak has quit IRC20:06
dkranzmtreinish: yes20:06
mtreinishdkranz: great thanks20:07
*** weshay has quit IRC20:13
openstackgerritMonty Taylor proposed a change to openstack-dev/devstack: Protect local dev changes from the update logic  https://review.openstack.org/4041820:16
openstackgerritMonty Taylor proposed a change to openstack-dev/devstack: Protect local dev changes from the update logic  https://review.openstack.org/4041820:17
sdaguemordred: so if you land my other update.py patch, we have a different solution there20:18
openstackgerritMonty Taylor proposed a change to openstack-infra/devstack-gate: Enable flag to update requirements on run  https://review.openstack.org/4119220:19
dkranzmtreinish: Doesn't this still have the problem in https://review.openstack.org/#/c/39099/13/tempest/scenario/manager.py,unified that Sean pointed out?20:19
dkranzmtreinish: If is_deletion_complete fails the tearDownCLass will not be called?20:20
sdaguemtreinish: did you notice that neutron full passed on your run20:20
mtreinishsdague: I fixed neutron?20:21
mordredsdague: oh yeah?20:21
mordredsdague: which one?20:21
mtreinishdkranz: on line 210?20:21
sdaguemordred: https://review.openstack.org/#/c/39099/ neutron full passed20:21
dkranzmtreinish: Sorry, yes.20:21
sdagueon the update.py thing20:21
sdaguemordred: https://review.openstack.org/#/c/40995/20:22
dkranzmtreinish: If true, not so easy to fix.20:22
sdagueso with that you can ./update.py -o global $dir20:22
sdaguethen get new requirements.txt.global files20:22
sdaguewhich we can use in devstack20:22
mtreinishdkranz: that is in teardownclass20:22
dkranzmtreinish: Yes.20:23
mordredsdague: oh - and then setting REQUIREMENTS_FILES env var?20:23
mordredsdague: col. I like it20:23
mtreinishdkranz: oh I see what you're saying. Yeah this is a problem because we can't do class level addCleanup there isn't really a way to get around it20:23
sdaguemordred: I just assumed we'd pip with -r20:24
dkranzmtreinish: OK, I'm cool with that.20:24
sdagueon the new files, though if you have another idea, that's cool20:24
mordredsdague: we can do that too20:24
dkranzmtreinish: sdague wanted us to start being anal about this so I was just pointing it out20:24
sdagueanyway, take a look at the approach20:24
mordredsdague: except, no, we have to do the env var20:24
sdaguemordred: ok, env is fine20:24
mordredsdague: because otherwise the pip install -e is going to pick up the wrong requirements :)20:24
mtreinishdkranz: yeah I looked at doing that once when I first redid the isolated creds.20:24
dkranzmtreinish: There is already plenty of code with similar issues.20:24
mtreinishdkranz: yeah but we don't want to merge more bad code if we can help it :)20:25
sdaguemordred: I was going to remove -e :)20:25
sdagueand go back to -r on the 2 files20:25
sdaguehowever, env var is fine too20:25
mordredsdague: oh - well, that's fine20:25
sdagueeither way, it gives us other files20:25
sdagueand doesn't polute git20:25
mordredbut I want to keep pip -e instead of setup.py develop ... but yes - we can battle over the little bits :)20:26
dkranzmtreinish: In the future we need to be more clear about the cleanup requirements and make it easy for people to not run afoul of them.20:26
sdagueyep, that's fine :)20:26
dkranzmtreinish: decorators, more gc-like allocation, etc.20:26
mtreinishsdague: so neutron didn't pass jenkins reporting is broken...20:26
mtreinishit might be related to the move to testr20:27
mordredwhat?20:27
mordredlifeless: ^^20:27
dkranzmtreinish: So are you saying I should -1 it to not merge more "bad" code?20:27
*** meteorfox has quit IRC20:27
mtreinishsdague: see: http://logs.openstack.org/99/39099/13/check/gate-tempest-devstack-vm-neutron-full/34856db/testr_results.html.gz20:27
sdaguemtreinish: hmmm... it reported success20:28
mtreinishdkranz: hahaha20:28
mriedemmtreinish: test_security_group_create_with_invalid_group_description and test_security_group_create_with_invalid_group_name should be skipped now20:28
mriedemmtreinish: https://review.openstack.org/#/c/40666/20:29
sdaguemtreinish: umm... testr isn't failing right20:29
sdaguethis is actually very bad20:29
dtroyermordred, sdague:  I'm heading to airport soon but I like what I saw in the scrollback here, especially not messing with the repos.20:29
sdagueok20:29
mordreddtroyer: cool. I just aprv'd sdague's change to requirements20:29
dtroyerBTW, I'm building another script to handle the ugly hacks we need, like the prettytable perms and all of the rhel package nonsense...20:29
mordredonce that lands, we can put together a devstack patch to make use of it20:29
mtreinishmriedem: that probably just wasn't on the tree when I pushed out the change20:30
sdaguemordred: ok, what did we do wrong on testr?20:30
mordreddtroyer: good. also, jeez20:30
dtroyershould have a proposal soon for just the prettytable stuff20:30
sdaguedtroyer: safe travels20:30
sdaguedtroyer: cool, I'll check later on it20:30
sdagueor tomorrow morning over coffee20:30
mtreinishsdague: it's probably printing testr slowest I bet that's returning a success code20:30
mtreinishin pretty_tox_serial.sh20:31
mordredmtreinish: yup. I 'betcha that's right20:31
lifelessmtreinish: wassup?20:31
mordredlifeless: thought it might be a testr issue - but now we're looking in to be pebkac20:32
lifelesscool. Well, not cool, but ack.20:32
lifelessis it something testr could help you avoid?20:32
mtreinishlifeless: not much we just moved to testr serial in the gate and one of my sloppy wrapper scripts reports every jenkins run as a success. :)20:32
lifelessah20:32
lifelesswhoops :)20:32
sdaguemtreinish: so we just dump testr slowest?20:33
mordredsdague: grab $? after the testr20:33
mordredthen run slowest20:33
mordredthen exit $RET20:33
mtreinishsdague: ^^ yeah that I'm about to push it out20:33
sdagueso why aren't we using the integrated --slowest like in nova?20:34
mtreinishthat's part of pbr20:34
sdagueok20:34
mordredyeah. that. and also I don't know that there is a way to disable parallel - although I think we've talked about adding a --no-parallel20:34
openstackgerritMatthew Treinish proposed a change to openstack/tempest: Fix return code for pretty_tox_serial.sh  https://review.openstack.org/4119520:35
lifelessthere is a patch up for it20:35
mtreinishmordred: yeah: https://review.openstack.org/#/c/39811/20:35
mtreinishalthough i probably should respin it to appease fungi and jgriffith20:36
fungimtreinish: there is no pleasing me20:36
fungii *did* +2 that patch20:36
fungiall snark about double negatives aside20:37
mtreinishfungi: all I did was find replace with 'serial' from the previous revision20:38
sdagueman, the gate queue is as small as I've ever seen it on Friday20:39
mtreinishsdague: it's this one: https://review.openstack.org/41195 probably want to rush that through20:39
sdagueyeh, i just did20:40
fungimtreinish: well, "serial" was a positive term, whereas "no_parallel" is negative. makes it harder for readers to reason about. that was my only qualm20:40
sdaguemtreinish: also, it looks like the full runs are actually passing for reals20:40
sdagueso we didn't let anything terribad slip in20:40
mtreinishfungi: no I get that, I was just saying reason and semantics didn't really factor into it20:41
mtreinishjust sed20:41
fungiheh, got it ;)20:41
lifelessfungi: --no-foo is a convention for things that have a --foo option.20:43
dkranzmtreinish: OK, I +2 the isolated creds20:43
lifelessfungi: testr has --parallel; this is a testr wrapper - thats why I suggested --no-parallel : it's more obvious to folk that have learnt the testr interface (and vice versa, folk that know the wrapper and go to testr have less room for confusion)20:43
*** meteorfox has joined #openstack-qa20:44
dkranzmtreinish: That's a pretty significant change.20:44
dkranzmtreinish: I hope I didn't miss anything.20:44
fungilifeless: oh i don't disagree there, just the code that went into suddenly had "if not not-thing"20:44
fungi(well, not_thing)20:45
mtreinishdkranz: cool, thanks20:47
flashgordonwith tempest how do  specify a subset of commands to run?20:48
flashgordonin nova its tox -epy27 test name20:48
flashgordonwhen I do 'tox -efull test_ec2_instance_run' it runs everything20:48
mtreinishdkranz: I thought about splitting things up but the only logical way to do it was add the full isolated cred blob and then a separate patch for the scenario addition.20:49
mtreinishwhich wouldn't end up being that different than it is now20:49
dkranzmtreinish: I was not complaining.20:49
dkranzmtreinish: Just saying that I was not as certain everything is ok as I am usually with reviews.20:50
mtreinishflashgordon: the only way to do it now is with manually calling testr with the regex for what you want20:50
mtreinish(or use run_tests.sh with the regex)20:50
flashgordonmtreinish: why no posargs in tox?20:50
dkranzmtreinish: Especially in such a dynamically typed language :)20:51
mtreinishflashgordon: there are but since testr ORs the regex and we already specify one for the full gate job it won't do anything20:51
flashgordonmtreinish: :(20:52
mtreinishflashgordon: actually one sec I'll push out a patch to add posargs to -eall which doesn't specify any regex20:53
mtreinishand then you can use it there20:53
mtreinishbut, that will run in parallel.20:53
flashgordonmtreinish: I was doing -efull20:54
sdaguemtreinish: I think we'll probably need follow on clean ups, but I'm ok with landing the isolation now20:54
mtreinishsdague: ok cool20:54
mtreinishthat's the last of the big race conditions then. Now we can see if there are any hiding behind it20:55
*** woodspa has quit IRC20:55
mtreinishflashgordon: -efull runs it serially20:55
lifelessfungi: ah20:55
mtreinishflashgordon: normally you wouldn't want to use -eall because it runs the broken whitebox tests. But if you add posargs to it'll let you run just a single test using tox.20:58
flashgordonmtreinish: cool20:58
*** burt has quit IRC21:00
openstackgerritMatthew Treinish proposed a change to openstack/tempest: Fix posargs usage for tox jobs  https://review.openstack.org/4119821:03
mtreinishflashgordon: ^^^21:03
flashgordonmtreinish: thanks21:06
marunsdague: any pointers on submitting a backport to tempest's stable/grizzly branch?21:25
marunor anyone really21:25
marundkranz ^21:25
marunah, nmind21:32
*** mriedem has quit IRC21:41
openstackgerritSean Dague proposed a change to openstack/tempest: Fix return code for pretty_tox_serial.sh  https://review.openstack.org/4119521:44
sdaguemarun: you need to land it in master, than backport, per same rules of other projects21:44
sdaguemarun: also, there are a lot of critical neutron bugs in the gate right now, if there are any neutron cycles, would be nice to get someone looking at them21:45
marunsdague: it's been in master a long time, I just didn't know about having to provide the target branch name to git review21:47
marunsdague: I can spare some time next week for neutron bugs.  Where can I find them?21:48
sdaguemarun: the neutron launchpad tracker :)21:48
sdagueall the ones marked critical are things that are reseting the gate for other people21:48
marunsdague: ok21:49
marunsdague: *sigh*21:49
marunsdague: I don't get it, how are the changes that break things this bad making it past the gate in the first place?21:50
sdaguemarun: well one of them we had a slip today21:50
sdaguewhich we're trying to fix21:50
sdagueon a lot of them, they only fail 3% of the time21:51
sdagueso they can thread the gate21:51
sdagueactually a neutron test only needs to pass 50% of the time to let it merge21:51
sdagueso the race conditions in neutron just have people recheck to get past them21:51
marun#fail21:52
marunsdague: well, I'll do my best.21:53
sdaguethanks21:53
*** hemna has quit IRC21:54
sdaguehonestly, something you could do that might help other folks, is make the logging a little more clear. So like log requests that come in. The neutron logs are kind of hard to read relative to nova, which is one of the reasons people seem to just recheck them vs. look deeper21:54
openstackgerritDean Troyer proposed a change to openstack-dev/devstack: More Python package fixes  https://review.openstack.org/4120921:57
*** ianw has quit IRC22:22
*** ianw has joined #openstack-qa22:23
*** jaypipes has quit IRC22:47
*** lexinator has quit IRC22:50
openstackgerritA change was merged to openstack/tempest: Fix return code for pretty_tox_serial.sh  https://review.openstack.org/4119522:51
*** dkranz has quit IRC23:05
*** jasondotstar has quit IRC23:13
*** mlavalle has quit IRC23:50

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!