*** LiangZheng has joined #openstack-qa | 00:00 | |
*** LiangZheng has quit IRC | 00:05 | |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "create security rule" methods https://review.openstack.org/42303 | 00:09 |
---|---|---|
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "create security rule" method https://review.openstack.org/42303 | 00:31 |
*** LiangZheng has joined #openstack-qa | 01:25 | |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "create security rule" method https://review.openstack.org/42303 | 01:26 |
*** LiangZheng has quit IRC | 01:29 | |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "create security rule" method https://review.openstack.org/42303 | 01:33 |
*** LiangZheng has joined #openstack-qa | 02:15 | |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "create keypair" method https://review.openstack.org/42555 | 02:36 |
*** mriedem has quit IRC | 03:00 | |
openstackgerrit | Zhi Kun Liu proposed a change to openstack/tempest: test_servers_whitebox - using official client https://review.openstack.org/40396 | 03:01 |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "create keypair" method https://review.openstack.org/42555 | 03:21 |
openstackgerrit | Joseph Wang proposed a change to openstack-dev/devstack: add mageia support https://review.openstack.org/42561 | 03:36 |
openstackgerrit | Joseph Wang proposed a change to openstack-dev/devstack: turn out usb_tablet for libvirt https://review.openstack.org/42562 | 04:04 |
*** mkoderer has quit IRC | 04:19 | |
*** Anju has joined #openstack-qa | 04:21 | |
*** mberwanger has joined #openstack-qa | 04:41 | |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "create keypair" method https://review.openstack.org/42555 | 04:44 |
*** mberwanger has quit IRC | 05:10 | |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "ssh-login server" method https://review.openstack.org/42569 | 05:11 |
*** thomasbiege1 has joined #openstack-qa | 05:15 | |
*** thomasbiege1 has quit IRC | 05:17 | |
*** thomasbiege has joined #openstack-qa | 05:21 | |
*** thomasbiege has quit IRC | 05:24 | |
*** SergeyLukjanov has joined #openstack-qa | 05:41 | |
*** kashyap has left #openstack-qa | 05:45 | |
*** kashyap has joined #openstack-qa | 05:45 | |
*** thomasbiege1 has joined #openstack-qa | 06:06 | |
*** thomasbiege1 has quit IRC | 06:08 | |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "ssh-login server" method https://review.openstack.org/42569 | 06:11 |
*** mkoderer has joined #openstack-qa | 06:21 | |
*** SergeyLukjanov has quit IRC | 06:25 | |
*** SergeyLukjanov has joined #openstack-qa | 06:30 | |
*** sthaha has quit IRC | 06:35 | |
*** SergeyLukjanov has quit IRC | 06:38 | |
*** SergeyLukjanov has joined #openstack-qa | 06:42 | |
*** SergeyLukjanov has quit IRC | 06:48 | |
openstackgerrit | Zhang Hua proposed a change to openstack/tempest: Fixes the issues of tempest due to async network allocation https://review.openstack.org/42472 | 07:04 |
*** Anju has quit IRC | 07:05 | |
*** fbo_away is now known as fbo | 07:16 | |
*** yfried has joined #openstack-qa | 07:21 | |
*** nsaje1 has joined #openstack-qa | 07:23 | |
*** thomasbiege1 has joined #openstack-qa | 07:42 | |
*** thomasbiege1 has quit IRC | 07:43 | |
*** yfried has quit IRC | 07:54 | |
*** yfried has joined #openstack-qa | 07:56 | |
*** jhenner has joined #openstack-qa | 07:59 | |
*** tkammer has joined #openstack-qa | 08:00 | |
*** yfried has quit IRC | 08:01 | |
openstackgerrit | Ivan-Zhu proposed a change to openstack-dev/grenade: add nova v3 api support in upgrade https://review.openstack.org/40134 | 08:11 |
*** sthaha has joined #openstack-qa | 08:13 | |
*** sthaha has joined #openstack-qa | 08:13 | |
*** giulivo has joined #openstack-qa | 08:15 | |
*** yfried has joined #openstack-qa | 08:15 | |
openstackgerrit | Ivan-Zhu proposed a change to openstack-dev/grenade: add nova v3 api support in upgrade https://review.openstack.org/40134 | 08:15 |
*** VinodGupta has joined #openstack-qa | 08:17 | |
openstackgerrit | Ivan-Zhu proposed a change to openstack-dev/grenade: add nova v3 api support in upgrade https://review.openstack.org/40134 | 08:19 |
*** psedlak has joined #openstack-qa | 08:21 | |
*** tkammer has quit IRC | 08:55 | |
*** yfried has quit IRC | 08:57 | |
*** yfried has joined #openstack-qa | 08:58 | |
*** LiangZheng has quit IRC | 09:06 | |
*** LiangZheng has joined #openstack-qa | 09:06 | |
*** Guest has quit IRC | 09:19 | |
*** tkammer has joined #openstack-qa | 09:25 | |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "create volume" method https://review.openstack.org/42593 | 09:32 |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "create volume" method https://review.openstack.org/42593 | 09:42 |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "ssh-login server" method https://review.openstack.org/42569 | 09:48 |
openstackgerrit | nayna-patel proposed a change to openstack/tempest: Added test case to check floating IP API operations https://review.openstack.org/41038 | 09:49 |
*** Anju has joined #openstack-qa | 09:50 | |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "create volume" method https://review.openstack.org/42593 | 09:51 |
*** tkammer has quit IRC | 09:58 | |
*** sthaha has quit IRC | 10:01 | |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "create keypair" method https://review.openstack.org/42555 | 10:04 |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "create security rule" method https://review.openstack.org/42303 | 10:09 |
*** weshay has joined #openstack-qa | 10:14 | |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "create security rule" method https://review.openstack.org/42303 | 10:19 |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "create keypair" method https://review.openstack.org/42555 | 10:21 |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "create volume" method https://review.openstack.org/42593 | 10:22 |
*** fbo is now known as fbo_away | 10:34 | |
*** Anju has quit IRC | 10:45 | |
*** Anju has joined #openstack-qa | 10:49 | |
*** raies has joined #openstack-qa | 11:03 | |
*** psedlak_ has joined #openstack-qa | 11:03 | |
raies | afazekas: what is request body for bulk network creation with xml formatted body request | 11:04 |
raies | ? | 11:04 |
afazekas | raies: I am still not OK :(, try to capture the traffic of the cli | 11:06 |
raies | i am trying cli but still there is problem | 11:06 |
raies | when I tried "<networks> <name>sample_network_1</name> <admin_state_up>false</admin_state_up> </networks> <networks> <name>sample_network_2</name> <admin_state_up>false</admin_state_up> </networks>" | 11:07 |
raies | in request body then bad request | 11:07 |
*** psedlak has quit IRC | 11:07 | |
raies | displayed | 11:07 |
raies | when I tried "<networks><name>sample_network_1</name><name>sample_network_2</name></networks>" | 11:08 |
afazekas | Wild guess you have multiple <network> in the <networks> | 11:08 |
raies | then server error 500 displayed | 11:08 |
afazekas | the 500 error should be reported | 11:08 |
raies | but I am unable to find exact request body for xml request during bulk network creation | 11:10 |
afazekas | <networks><network> <name>sample_network_1</name> <admin_state_up>false</admin_state_up></network> </networks> # just wild guess without a client | 11:13 |
raies | ok | 11:13 |
raies | i will try it | 11:13 |
raies | afazekas : I tried this with success :) yep "<networks><network><name>sample_network_1</name><name>sample_network_2</name></network></networks>" | 11:15 |
afazekas | if it working with multiple network it was good guess :) | 11:18 |
* afazekas go back to rest | 11:18 | |
openstackgerrit | nayna-patel proposed a change to openstack/tempest: Added test case to check floating IP API operations https://review.openstack.org/41038 | 11:20 |
*** yfried has quit IRC | 11:21 | |
openstackgerrit | afazekas proposed a change to openstack/tempest: Move the network api tests to smoke https://review.openstack.org/42517 | 11:36 |
*** fbo_away is now known as fbo | 11:37 | |
*** thomasbiege1 has joined #openstack-qa | 11:40 | |
*** yfried has joined #openstack-qa | 11:42 | |
openstackgerrit | Aditi Raveesh proposed a change to openstack/tempest: Fixing format_flavor to handle flavor extra_specs https://review.openstack.org/42616 | 11:42 |
*** weshay has quit IRC | 11:44 | |
*** Anju has quit IRC | 11:44 | |
*** thomasbiege1 has quit IRC | 11:44 | |
*** thomasbiege1 has joined #openstack-qa | 11:45 | |
*** weshay has joined #openstack-qa | 11:50 | |
*** VinodGupta has quit IRC | 11:53 | |
*** nsaje1 has quit IRC | 11:58 | |
*** torandu has joined #openstack-qa | 11:58 | |
*** weshay has quit IRC | 11:59 | |
openstackgerrit | raiesmh08 proposed a change to openstack/tempest: Adding network api xml support https://review.openstack.org/41673 | 12:02 |
raies | afazekas: r u there ? | 12:03 |
*** torandu has quit IRC | 12:07 | |
*** mkollaro has joined #openstack-qa | 12:07 | |
openstackgerrit | Kui Shi proposed a change to openstack-dev/devstack: libffi-dev is needed while install python package https://review.openstack.org/42620 | 12:09 |
*** psedlak__ has joined #openstack-qa | 12:10 | |
*** yfried has quit IRC | 12:12 | |
*** psedlak_ has quit IRC | 12:14 | |
openstackgerrit | nayna-patel proposed a change to openstack/tempest: Adds verfication for Bootable Volume https://review.openstack.org/42621 | 12:16 |
*** woodspa has joined #openstack-qa | 12:21 | |
*** mriedem has joined #openstack-qa | 12:36 | |
*** thomasbiege1 has quit IRC | 12:42 | |
*** jasondotstar has joined #openstack-qa | 12:47 | |
*** thomasbiege1 has joined #openstack-qa | 12:51 | |
*** thomasbiege1 has quit IRC | 12:52 | |
*** anteaya has joined #openstack-qa | 12:53 | |
*** adalbas has joined #openstack-qa | 12:55 | |
*** tkammer has joined #openstack-qa | 13:03 | |
*** LiangZheng has quit IRC | 13:11 | |
*** xqueralt has joined #openstack-qa | 13:15 | |
*** sthaha has joined #openstack-qa | 13:15 | |
xqueralt | hey, I think tempest tests might be broken for grizzly | 13:15 |
xqueralt | could somebody take a look at: https://bugs.launchpad.net/tempest/+bug/1213912 ? | 13:15 |
openstackgerrit | Joe Hakim Rahme proposed a change to openstack/tempest: Add more tests for Swift Account Quota https://review.openstack.org/41099 | 13:16 |
xqueralt | I've tried to debug it a bit more more but I don't know where the problem might come from | 13:16 |
*** timello_ has joined #openstack-qa | 13:20 | |
*** stevebaker has quit IRC | 13:22 | |
*** timello has quit IRC | 13:22 | |
*** stevebaker has joined #openstack-qa | 13:23 | |
*** burt has joined #openstack-qa | 13:26 | |
openstackgerrit | Julien Danjou proposed a change to openstack-dev/devstack: Use 10gen repository to get MongoDB 2.4 https://review.openstack.org/42642 | 13:28 |
*** psedlak has joined #openstack-qa | 13:36 | |
*** psedlak__ has quit IRC | 13:37 | |
*** LiangZheng has joined #openstack-qa | 13:41 | |
*** LiangZheng has quit IRC | 13:49 | |
*** sthaha has quit IRC | 13:57 | |
*** psedlak_ has joined #openstack-qa | 14:05 | |
*** psedlak has quit IRC | 14:09 | |
*** annegentle has joined #openstack-qa | 14:10 | |
openstackgerrit | Matthew Treinish proposed a change to openstack/tempest: Add tenant isolation to the swift tests https://review.openstack.org/42169 | 14:13 |
*** rustlebee is now known as russellb | 14:13 | |
*** tkammer has quit IRC | 14:16 | |
openstackgerrit | Matthew Treinish proposed a change to openstack/tempest: Fix skip tracker regex for multi-line skips https://review.openstack.org/42424 | 14:16 |
openstackgerrit | Julien Danjou proposed a change to openstack-dev/devstack: Remove useless sources.list https://review.openstack.org/42652 | 14:17 |
*** tkammer has joined #openstack-qa | 14:18 | |
*** tkammer has quit IRC | 14:23 | |
*** xqueralt is now known as xqueralt-afk | 14:28 | |
*** xqueralt-afk is now known as xqueralt | 14:28 | |
*** malini has joined #openstack-qa | 14:31 | |
*** fbo is now known as fbo_away | 14:33 | |
*** dkranz has joined #openstack-qa | 14:36 | |
*** malini is now known as malini_afk | 14:37 | |
*** malini_afk is now known as malini | 14:37 | |
*** fbo_away is now known as fbo | 14:40 | |
*** mlavalle has joined #openstack-qa | 14:44 | |
openstackgerrit | afazekas proposed a change to openstack/tempest: task_state must be consider before many action https://review.openstack.org/35165 | 14:45 |
*** LiangZheng has joined #openstack-qa | 14:46 | |
*** LiangZheng has quit IRC | 14:50 | |
openstackgerrit | afazekas proposed a change to openstack/tempest: Simplify xml/json client selection https://review.openstack.org/36937 | 15:00 |
*** openstackgerrit has quit IRC | 15:01 | |
*** openstackgerrit has joined #openstack-qa | 15:02 | |
openstackgerrit | Julien Danjou proposed a change to openstack-dev/devstack: Use 10gen repository to get MongoDB 2.4 https://review.openstack.org/42642 | 15:06 |
openstackgerrit | raiesmh08 proposed a change to openstack/tempest: Adding network api xml support https://review.openstack.org/41673 | 15:07 |
*** psedlak_ has quit IRC | 15:11 | |
openstackgerrit | afazekas proposed a change to openstack/tempest: Dump basic network info in the test_network_basic_ops https://review.openstack.org/40435 | 15:12 |
*** raies_ has joined #openstack-qa | 15:12 | |
raies_ | afazeks: hi | 15:13 |
raies_ | afazekas: hi | 15:13 |
openstackgerrit | afazekas proposed a change to openstack/tempest: Dump basic network info in the test_network_basic_ops https://review.openstack.org/40435 | 15:16 |
*** thomasbiege1 has joined #openstack-qa | 15:16 | |
*** SergeyLukjanov has joined #openstack-qa | 15:19 | |
raies_ | afazekas: please check https://review.openstack.org/#/c/41673/ and https://review.openstack.org/#/c/42624/ | 15:21 |
afazekas | https://review.openstack.org/#/c/41673/5/tempest/api/network/test_networks.py my first inline note not addressed (you removed a space without a reason) | 15:24 |
raies_ | oh silly mistake | 15:25 |
raies_ | i will amend | 15:26 |
afazekas | why did you changed the test case ? | 15:26 |
raies_ | which one ? | 15:26 |
afazekas | https://review.openstack.org/#/c/41673/7/tempest/api/network/test_networks.py | 15:26 |
afazekas | test_list_networkks .. all of them | 15:27 |
*** rhsu has joined #openstack-qa | 15:27 | |
*** rhsu has quit IRC | 15:27 | |
raies_ | to handle JSON as well s XML i used this technique | 15:27 |
raies_ | ultimately our motive ws to check self.id | 15:28 |
raies_ | so i checked server list methods | 15:28 |
raies_ | and implemented here lso | 15:28 |
raies_ | *also | 15:28 |
raies_ | Thus using help of server list methods I was able to handle xml as well as json response bodies :) | 15:30 |
afazekas | At first look the new version looks better, but I am not sure it should be in the same change.. | 15:32 |
raies_ | i didn't understand please elaborate ? | 15:33 |
raies_ | I checked, everything is working good | 15:33 |
raies_ | and your comments of keyword arguments also handled | 15:34 |
raies_ | and list cases are handled in an alternative and in good way | 15:34 |
afazekas | usually we do not change/add test cases at the same time when we add xml support | 15:37 |
afazekas | mtreinish: https://review.openstack.org/#/c/41673/7 can we review this change once ? | 15:38 |
raies_ | Actually when I checked the return value in case of json i was "{{"ports": [ {"status": "DOWN", "name": "", "admin_state_up": true, "network_id": "52a5bed2-3d7e-488d-8cca-b8a9a7883ef7", "tenant_id": "40b7ab229c3b47dba7991e857e082216", "device_owner": "network:dhcp", "mac_address": "fa:16:3e:ba:fd:bf", "fixed_ips": [ {"subnet_id": "34ddc9b5-4152-4d43-9a59-468ffd | 15:39 |
openstackgerrit | Zhang Hua proposed a change to openstack/tempest: Fixes the issues of tempest due to async network allocation https://review.openstack.org/42472 | 15:39 |
raies_ | and when I checked the return response of xml the it was -- "{'ports': {'port': {'status': 'DOWN', 'name': 'port-1577847275', 'admin_state_up': 'True', 'network_id': '544147e2-c454-4434-98d2-0057b45f979f', 'tenant_id': '40b7ab229c3b47dba7991e857e082216', 'device_owner': {}, 'mac_address': 'fa:16:3e:00:21:f4', 'fixed_ips': {'fixed_ip': | 15:40 |
raies_ | 2nd is just an example | 15:40 |
raies_ | So in case when I changed xml response in list | 15:40 |
raies_ | It was unable to parse as per previous test trend | 15:41 |
raies_ | so I have to made some changes | 15:41 |
afazekas | https://wiki.openstack.org/wiki/GitCommitMessages#Structural_split_of_changes | 15:41 |
raies_ | afazekas: Is the wiki page is suggested for me ? | 15:42 |
mtreinish | afazekas: yeah I was going to leave a -1 comment about that. It probably should be split up per test file. Also, any xml client code written needs tests that use it. | 15:43 |
afazekas | looks there was some anomaly with the json client | 15:44 |
*** tkammer has joined #openstack-qa | 15:45 | |
*** LiangZheng has joined #openstack-qa | 15:47 | |
*** xqueralt has left #openstack-qa | 15:47 | |
raies_ | afazekas: | 15:48 |
*** LiangZheng has quit IRC | 15:51 | |
afazekas | mtreinish: the change does not looks too big, do you think do we need an additional tempest specific change grouping guideline ? | 15:52 |
mtreinish | afazekas: actually I was just giving it a first glance when I made the above remark I'm not sure that it really applie. My bigger issue is with all the changes in one of the tests files. That should be split out (and made a dependency if it is one) | 15:54 |
*** SergeyLu_ has joined #openstack-qa | 15:54 | |
*** SergeyLukjanov has quit IRC | 15:57 | |
afazekas | mtreinish: Probably the second patch would be under 50 line, close to the limit where not really worth to split | 16:00 |
mtreinish | afazekas: I disagree, its not just about making it a small enough patch to be easy to review. But also about making a logical split in patches to make bisecting easier and the logs descriptive. | 16:01 |
*** Anju has joined #openstack-qa | 16:03 | |
*** thomasbiege1 has quit IRC | 16:06 | |
*** tkammer has quit IRC | 16:07 | |
raies_ | afazekas: https://review.openstack.org/#/c/41673/7/tempest/api/network/test_networks.py line 176 I did not understand ? | 16:12 |
afazekas | raies_: As remember last time I recommended to add xml support in way when the test cases are not modified | 16:12 |
raies_ | afazekas: does it will affect our process ? | 16:13 |
afazekas | Very frequently: - the style changing, renaming commits are individual | 16:13 |
afazekas | raies_: can you submit the patch in way, when just the things what really necessary for the xml support included ? | 16:14 |
*** SergeyLu_ has quit IRC | 16:14 | |
raies_ | afazekas: mtrennish has made several comments , out of which 2 comments are still in confusion | 16:15 |
raies_ | 1. what i told you | 16:15 |
raies_ | 2. https://review.openstack.org/#/c/41673/7/tempest/api/network/base.py line 52 | 16:16 |
afazekas | 2. I think it can be added together with the xml | 16:17 |
afazekas | mtreinish: do you agree ? | 16:17 |
afazekas | It was required for providing better common interface, based on a previous IRC discussion | 16:17 |
raies_ | sorry i gave wrong | 16:18 |
raies_ | https://review.openstack.org/#/c/41673/7/tempest/services/network/json/network_client.py line 118 | 16:18 |
raies_ | 2 . as mentioned just above | 16:18 |
afazekas | strange I read the correct one :) | 16:20 |
raies_ | afazekas: case 1. As xml and json responses are are quite different to handle in same test case trend, I have to choose redundant way | 16:21 |
afazekas | https://review.openstack.org/#/c/41673/7/tempest/api/network/base.py line 51 should be deleted | 16:21 |
raies_ | afazekas: When my amendment is giving better for case 1 is giving good and a step more validation and also valid for xml as well as json then why there re being rejected ? | 16:23 |
raies_ | afazekas: last comment what u written should be for https://review.openstack.org/#/c/41673/7/tempest/services/network/json/network_client.py line 118 I think | 16:24 |
afazekas | raies_: Normally a change does does on "type" of change | 16:25 |
afazekas | now the patch grow to big, and does 3 type of change | 16:26 |
afazekas | https://review.openstack.org/#/c/42472/ probably this change also will be asked for separation | 16:27 |
afazekas | the skips are coming in a single change | 16:28 |
raies_ | afazekas: as per previous test trend xml does not work for list cases as I have told you before | 16:28 |
raies_ | then what could be the solution again | 16:28 |
raies_ | afazekas: r u there ? | 16:31 |
afazekas | raies_: is the code you submitted recently working with XML correctly? | 16:33 |
* afazekas is not OK now, I try to look it closer tomorrow | 16:34 | |
afazekas | mtreinish: when you returned can you discuss with raies_, how to split ? | 16:41 |
*** marun has joined #openstack-qa | 16:46 | |
*** LiangZheng has joined #openstack-qa | 16:47 | |
raies_ | afazekas: I m in now :) | 16:48 |
raies_ | Yes my code was working good for xml s well as json | 16:48 |
raies_ | all 24 testcases (xml+json) was pass OK | 16:48 |
*** afazekas_ has joined #openstack-qa | 16:51 | |
afazekas | raies_: I guess it would be able to work with unmodified test cases | 16:52 |
*** LiangZheng has quit IRC | 16:52 | |
raies_ | No it is working for all I had checked specially for modified one | 16:52 |
*** fbo is now known as fbo_away | 16:53 | |
afazekas | Interesting, the json client return 'structure' looks unchanged just based on the code, and I do not see condition in the test cases | 16:56 |
raies_ | afazekas: will you please run after applying this patch ? | 16:58 |
afazekas | Tomorrow I will | 17:00 |
raies_ | afazekas : | 17:00 |
raies_ | If jenkins will give +1 , then it will be verified I think ? | 17:00 |
afazekas | If you say it does not working with the original one, something else can be wrong, I want to investigate it | 17:02 |
raies_ | afazekas: Yes please :) and give your inputs to improve it soon as so many times it had been discaded :( | 17:03 |
mtreinish | afazekas: when you get a chance can I get some eyes on: https://review.openstack.org/#/c/42169/ | 17:07 |
mtreinish | it's a fix for one of the common failures on the parallel runs | 17:07 |
*** jerryz has joined #openstack-qa | 17:07 | |
afazekas | mtreinish: the tempest.conf.sample should mention the alt user should have operator rule, when the isolation is turned off | 17:11 |
afazekas | https://review.openstack.org/#/c/42169/3/etc/tempest.conf.sample L42 and L34 | 17:12 |
mtreinish | afazekas: if isolation is turned off I think its a safe assumption the users provided would have the operator role configured if they're being used for swift tests. | 17:13 |
mtreinish | it'd be weird to try to run the swift tests with users that didn't have the right role | 17:14 |
afazekas | mtreinish: yes, bit it should be documented somewhere, now the config sample is one possible place | 17:14 |
afazekas | mtreinish: operator role is higher role in swift, the several old tests worked without operator role AFAIK | 17:15 |
mtreinish | afazekas: well the devstack case is misleading because all the users it creates get an operator role. | 17:15 |
mtreinish | when I tested it without the role set I think all the tests failed | 17:15 |
afazekas | I really go to rest otherwise I will be sick tomorrow as well... | 17:16 |
mtreinish | afazekas: ok go, don't work yourself too hard... | 17:16 |
afazekas | operator_roles "Member, admin" | 17:17 |
afazekas | so 'all' regular devstack role considered as operator | 17:17 |
*** burt has quit IRC | 17:18 | |
mtreinish | afazekas: yeah that's what I saw | 17:18 |
mtreinish | but making users with the tempest client doesn't necessarily have that set | 17:18 |
afazekas | Looks like I changed that time last :) | 17:18 |
afazekas | it was refactoring .. | 17:19 |
afazekas | Ok, we should not forget to mention this operator role thing when document what is the expected system config for tempest | 17:20 |
mtreinish | afazekas: ok, I'm just not sure that sample conf around the users is the right place for it. But I'm not sure where a good place would be. | 17:22 |
afazekas | https://review.openstack.org/#/c/42169/3/tempest/api/object_storage/base.py strange next usage | 17:24 |
afazekas | frequently we just define the id in the config | 17:25 |
afazekas | the role lookup should be outside of the loop | 17:25 |
afazekas | It only needs to happen once in timpest lifetyme or once in a process lifetime | 17:26 |
*** mlavalle has quit IRC | 17:26 | |
mtreinish | afazekas: that was just lifted from what I do for adding the admin role in tenant isolation. But, I agree I'll move it outside of the loop | 17:26 |
afazekas | simpler to use a list expression with [0] | 17:27 |
*** afazekas is now known as afazekas_zz | 17:28 | |
*** yfried has joined #openstack-qa | 17:34 | |
*** raies_ has quit IRC | 17:37 | |
*** Anju has quit IRC | 17:37 | |
*** thomasbiege1 has joined #openstack-qa | 17:38 | |
*** mlavalle has joined #openstack-qa | 17:44 | |
*** thomasbiege2 has joined #openstack-qa | 17:46 | |
*** LiangZheng has joined #openstack-qa | 17:48 | |
openstackgerrit | James E. Blair proposed a change to openstack-infra/devstack-gate: Use git.openstack.org as origin https://review.openstack.org/42693 | 17:49 |
*** thomasbiege1 has quit IRC | 17:50 | |
*** afazekas_ has quit IRC | 17:51 | |
*** LiangZheng has quit IRC | 17:53 | |
*** thomasbiege2 has quit IRC | 17:56 | |
*** thomasbiege has joined #openstack-qa | 18:04 | |
*** giulivo has quit IRC | 18:06 | |
*** thomasbiege has quit IRC | 18:15 | |
*** thomasbiege has joined #openstack-qa | 18:23 | |
*** thomasbiege has quit IRC | 18:24 | |
*** SergeyLukjanov has joined #openstack-qa | 18:28 | |
*** burt has joined #openstack-qa | 18:37 | |
openstackgerrit | Maru Newby proposed a change to openstack/tempest: Remove skip of neutron connectivity check https://review.openstack.org/42018 | 18:46 |
*** LiangZheng has joined #openstack-qa | 18:48 | |
*** LiangZheng has quit IRC | 18:53 | |
*** mriedem has quit IRC | 18:55 | |
*** mriedem has joined #openstack-qa | 18:56 | |
*** fbo_away is now known as fbo | 19:27 | |
*** xqueralt has joined #openstack-qa | 19:31 | |
*** xqueralt is now known as xqueralt-afk | 19:37 | |
*** malini is now known as malini_afk | 19:41 | |
*** LiangZheng has joined #openstack-qa | 19:49 | |
*** LiangZheng has quit IRC | 19:54 | |
*** thomasbiege has joined #openstack-qa | 20:04 | |
marun | anyone have eyes on the glance cli failure I'm seeing at the end of the grenade gate? | 20:24 |
marun | http://logs.openstack.org/18/42018/5/check/gate-grenade-devstack-vm/e5876b2/console.html | 20:25 |
*** harlowja_ has quit IRC | 20:31 | |
*** harlowja has joined #openstack-qa | 20:31 | |
dkranz | marun: This is a bug recently introduced, discussed in #openstack-infra in the last hour or two. A fix is on the way. | 20:37 |
mlavalle | mriedem: ping | 20:37 |
dkranz | marun: https://review.openstack.org/#/c/42720/ | 20:38 |
mriedem | mlavalle: pong | 20:38 |
marun | dkranz: thank you | 20:38 |
marun | dranz: while I have your attention: https://review.openstack.org/#/c/41202/ | 20:38 |
mlavalle | mriedem: so, in regards to https://bugs.launchpad.net/tempest/+bug/1182384, what is the way forward? Are we going to implement uuid's for sec groups in nova? | 20:38 |
marun | dkranz: would like to get this merged and then pull it into the grizzly branch in for the rdo github repo | 20:39 |
dkranz | marun: I'll take a look. | 20:39 |
mriedem | mlavalle: my notes on where that was at was in my tempest review to skip the tests: https://review.openstack.org/#/c/40015/ | 20:40 |
mriedem | i think the mailing list post is where the ideas were | 20:40 |
mriedem | mlavalle: when i talked with sdague about it, he pointed out another nova patch to change how the security group api validation would be done in nova...trying to find that | 20:42 |
dkranz | marun: What does "Conflicts:" mean? | 20:42 |
mriedem | dkranz: cherry pick merge conflicts | 20:42 |
mriedem | added by git | 20:42 |
marun | dkranz: it's output from the git cherry-pick | 20:42 |
dkranz | marun: Ah, OK. | 20:43 |
mriedem | marun: you cherry picked that from master right? | 20:43 |
marun | mriedem: correct | 20:43 |
mriedem | the change-id doesn't match what's in master | 20:43 |
mriedem | it should | 20:43 |
mlavalle | mriedem: in the mailing list, it seems the last to reply was Vish, back in July 10th: http://lists.openstack.org/pipermail/openstack-dev/2013-July/011666.html | 20:43 |
marun | really? | 20:43 |
mriedem | you need to use the -x option when you cherry pick | 20:43 |
marun | mreidem: can you please point me at the relevant documentation? | 20:44 |
mriedem | marun: looking | 20:44 |
mlavalle | mriedem: are you aware of any further discussions / progress? | 20:44 |
marun | mreidem: I'm not sure I understand why the change ids would match. | 20:44 |
mriedem | marun: i think the wiki might have a gap in not tellin you to use -x | 20:44 |
* mriedem getting blown up by qa :) | 20:44 | |
mriedem | marun: https://wiki.openstack.org/wiki/StableBranch#Proposing_Fixes | 20:45 |
mriedem | marun: you should use the -x option so the change id is the same between reviews, it works like a topic branch | 20:45 |
mriedem | in gerrit, you click the change id and it shows up the reviews on each branch | 20:45 |
marun | mreidem: Hmmm, so the change id is 1 to many? | 20:46 |
mriedem | marun: yeah | 20:46 |
mriedem | trying to find an example | 20:46 |
mriedem | marun: example: https://review.openstack.org/#/q/I6c08b1b8040a1fd0db8e2b3b1fc798060733001f,n,z | 20:47 |
marun | mriedem: no, that's fine. i wasn't clear that it was safe to reuse a change id across branches. | 20:47 |
mriedem | marun: preferred even :) | 20:47 |
marun | I haven't done any backports up till now. | 20:47 |
mriedem | mlavalle: ok, back to your question, i'm not aware of further discussion on the mailing list, i had talked with sdague about it in -nova awhile back when i was looking at fixing it, | 20:47 |
mriedem | mlavalle: and he said we should do the validation in nova but in a different way for nova-network vs neutron APIs, i'm trying to find that now | 20:48 |
marun | mriedem: does that imply that including the cherry-picked rev hash in a commit is unnecessary? | 20:49 |
mriedem | mlavalle: because i think the issue is the tempest nova tests pass id to nova and it pukes in the neutron API because it's looking for a uuid | 20:49 |
mriedem | marun: that should say in there | 20:49 |
marun | mriedem: ok | 20:49 |
mlavalle | mriedem: Yep, that's the problem... | 20:49 |
*** LiangZheng has joined #openstack-qa | 20:50 | |
mlavalle | mriedem: I want to move this forward. Any advice as to what the next step might be? | 20:50 |
marun | mriedem: it looks like it created a new review. Can I abandon the old one? | 20:50 |
mriedem | marun: yeah, i think you have to since the change id would change | 20:52 |
mriedem | mlavalle: i'd say we should talk to sdague but that lazy bum us on vacation :) | 20:52 |
mriedem | for another week or two i think | 20:52 |
mriedem | mlavalle: still looking up some notes i have on this | 20:52 |
*** thomasbiege has quit IRC | 20:53 | |
*** thomasbiege has joined #openstack-qa | 20:53 | |
mlavalle | mriedem: ok, i'll keep an eye on his return and start nagging him as soon as he is back | 20:53 |
marun | https://review.openstack.org/#/c/42735/ | 20:53 |
mlavalle | mriedem: if you find the notes, would you add them to the bug? | 20:54 |
marun | dkranz: ^ | 20:54 |
mriedem | mlavalle: yeah | 20:54 |
mlavalle | ;-) | 20:54 |
*** LiangZheng has quit IRC | 20:54 | |
dkranz | marun: Saw that. Need to wait for the +1 from jenkins. | 20:55 |
marun | dkranz: i know it's procedure, but a part of me is not impressed with having to rerun the gate simply because the new change id required a new review | 20:56 |
marun | (since the gate has already passed) | 20:57 |
*** thomasbiege has quit IRC | 20:57 | |
*** thomasbiege has joined #openstack-qa | 20:57 | |
dkranz | marun: I'm not sure why it is necessary. Ask sdague :) | 20:58 |
marun | dkranz: the robots do the work (or make it, depending :) ) | 20:59 |
*** jhenner has quit IRC | 21:02 | |
*** malini_afk is now known as malini | 21:03 | |
*** woodspa has quit IRC | 21:08 | |
mriedem | mlavalle: bug reported updated with my notes | 21:11 |
*** SergeyLukjanov has quit IRC | 21:11 | |
mriedem | sdague == /dev/null right now :) | 21:11 |
mlavalle | mriedem: thanks. I appreciate it. This bug is causing 4 test failures in the neutron full gate test. So we need to find a solution | 21:12 |
*** thomasbiege has quit IRC | 21:12 | |
mriedem | mlavalle: yeah, that's why i proposed the skip test patch...it's a sticky one - definitely thanks for looking at it thought | 21:12 |
mriedem | *though | 21:12 |
*** malini is now known as malini_afk | 21:15 | |
*** jasondotstar has quit IRC | 21:28 | |
*** dkranz has quit IRC | 21:36 | |
*** yfried has quit IRC | 21:42 | |
openstackgerrit | Ravi Chunduru proposed a change to openstack-dev/devstack: blueprint quantum-fwaas-devstack Adds support for Openstack Networking FWaaS (Firewall) https://review.openstack.org/37147 | 21:48 |
*** LiangZheng has joined #openstack-qa | 21:50 | |
*** LiangZheng has quit IRC | 21:58 | |
*** burt has quit IRC | 22:09 | |
*** mkollaro has quit IRC | 22:11 | |
*** mriedem has quit IRC | 22:17 | |
openstackgerrit | Bob Ball proposed a change to openstack-dev/devstack: Use a global virtualenv https://review.openstack.org/40534 | 22:23 |
*** jerryz has quit IRC | 22:30 | |
openstackgerrit | James E. Blair proposed a change to openstack-infra/devstack-gate: Use git.openstack.org as origin https://review.openstack.org/42693 | 22:49 |
*** LiangZheng has joined #openstack-qa | 22:55 | |
*** weshay has joined #openstack-qa | 22:57 | |
*** LiangZheng has quit IRC | 23:00 | |
*** malini_afk is now known as malini | 23:01 | |
*** mlavalle has quit IRC | 23:09 | |
*** sthaha has joined #openstack-qa | 23:13 | |
*** sthaha has joined #openstack-qa | 23:13 | |
*** weshay has quit IRC | 23:14 | |
openstackgerrit | Zhang Hua proposed a change to openstack/tempest: Fixes the issues of tempest due to async network allocation https://review.openstack.org/42472 | 23:17 |
*** LiangZheng has joined #openstack-qa | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!