| *** LiangZheng has quit IRC | 00:00 | |
| *** jasondotstar has joined #openstack-qa | 00:12 | |
| *** LiangZheng has joined #openstack-qa | 00:17 | |
| *** mriedem has joined #openstack-qa | 00:37 | |
| *** anteaya has quit IRC | 00:58 | |
| *** mriedem has quit IRC | 01:33 | |
| *** malini is now known as malini_afk | 01:41 | |
| *** LiangZheng has quit IRC | 02:18 | |
| *** LiangZheng has joined #openstack-qa | 02:28 | |
| *** LiangZhe_ has joined #openstack-qa | 02:30 | |
| *** LiangZheng has quit IRC | 02:34 | |
| *** LiangZheng has joined #openstack-qa | 02:35 | |
| *** LiangZhe_ has quit IRC | 02:35 | |
| *** LiangZhe_ has joined #openstack-qa | 02:37 | |
| *** LiangZheng has quit IRC | 02:37 | |
| *** jasondotstar has quit IRC | 02:40 | |
| *** mriedem has joined #openstack-qa | 02:40 | |
| *** jasondotstar has joined #openstack-qa | 02:46 | |
| openstackgerrit | Zhang Hua proposed a change to openstack/tempest: Mismatch dictionary key in the process of parsing XML https://review.openstack.org/42797 | 02:48 |
|---|---|---|
| openstackgerrit | Zhang Hua proposed a change to openstack/tempest: Skip os-fixed-ips test since neutron has not implemented it https://review.openstack.org/42798 | 02:48 |
| openstackgerrit | Zhang Hua proposed a change to openstack/tempest: Eliminate the impact of "wait_until='BUILD'" https://review.openstack.org/42799 | 02:48 |
| openstackgerrit | Zhang Hua proposed a change to openstack/tempest: Fixes all issues of tempest caused by async network allocation https://review.openstack.org/42472 | 02:48 |
| *** mriedem has quit IRC | 02:49 | |
| *** afazekas_zz is now known as __afazekas_zz | 03:02 | |
| openstackgerrit | Ryan Hsu proposed a change to openstack/tempest: Set missing attribute self.server in _create_and_attach utility https://review.openstack.org/42800 | 03:15 |
| *** ivanzhu has joined #openstack-qa | 03:16 | |
| *** rhsu has joined #openstack-qa | 03:18 | |
| *** HenryG has quit IRC | 03:25 | |
| *** LiangZhe_ has quit IRC | 03:35 | |
| *** LiangZheng has joined #openstack-qa | 03:37 | |
| *** LiangZheng has quit IRC | 03:41 | |
| *** afazekas has joined #openstack-qa | 03:42 | |
| *** mberwanger has joined #openstack-qa | 03:59 | |
| openstackgerrit | A change was merged to openstack-dev/devstack: Redirect dpkg -l stderr to /dev/null https://review.openstack.org/41763 | 04:01 |
| *** ivanzhu has quit IRC | 04:08 | |
| raies | afazekas: https://review.openstack.org/#/c/41673/ jenkins gave -1 to it , I am unable to know the reason for it please check if possible | 04:10 |
| afazekas | raies: do you know this page: http://status.openstack.org/rechecks/ | 04:11 |
| raies | afazekas: No I do not know | 04:12 |
| afazekas | probably you need to say 'recheck bug 1214094' and jenkins will test it again | 04:12 |
| afazekas | If the issue not fixed yet, we need to wait until it is fixed | 04:13 |
| raies | afazekas: Now what I should do ? recommit same patch ? | 04:13 |
| afazekas | Looks like jenkis still sick :( | 04:13 |
| raies | afazekas: It mean I should try later in the evening ? | 04:14 |
| afazekas | https://review.openstack.org/#/c/41673/7/tempest/api/network/test_networks.py it contains new line addition to L47, it usually not liked on review | 04:14 |
| afazekas | you can try it now | 04:16 |
| afazekas | http://status.openstack.org/zuul/ | 04:16 |
| afazekas | looks like it can pass now | 04:16 |
| afazekas | the space '#vim' still removed, so you can amend it | 04:17 |
| raies | afazekas: I will incorporate all the review comments in new patch except "list cases", and https://review.openstack.org/#/c/41673/7/tempest/services/network/json/network_client.py L118 comment | 04:17 |
| raies | yes I will also do that I remember | 04:17 |
| afazekas | Normally a change should not change unrelated whiespaces | 04:17 |
| raies | afazekas: I will amend all except list cases, list cases are are fullfilling xml as well as json cases | 04:18 |
| afazekas | I will discuss the L118 with mtreinish | 04:18 |
| raies | afazekas: You can see http://logs.openstack.org/73/41673/7/check/gate-tempest-devstack-vm-neutron-full/40c6187/testr_results.html.gz network xml and json cases are working good | 04:19 |
| afazekas | raies: can you separate the xml/json changes and the test case changes to two patch ? | 04:19 |
| raies | afazekas : You mean to say that , for json I should call previous test case trend and for xml I should use the current once what I have used ? | 04:21 |
| raies | afazekas : json -> do not change code use as of master branch (list cases) | 04:21 |
| afazekas | Are you sure the old test cases are not working with xml, but the now test cases really working with bath and really testing it ? | 04:22 |
| raies | afazekas: xml --> check if xml interface then call current method what I have changed in patch 7 (list cases) | 04:22 |
| raies | afazekas: yes I am sure | 04:23 |
| raies | unit tests are also giving all pass | 04:23 |
| raies | what u say, what I have suggested above ? | 04:24 |
| afazekas | for adding xml normally the L27 + L233... required in test case file | 04:25 |
| raies | which file ? | 04:25 |
| afazekas | https://review.openstack.org/#/c/41673/7/tempest/api/network/test_networks.py | 04:26 |
| afazekas | the other changes usually unrelated to xml | 04:26 |
| afazekas | I mean in that file | 04:27 |
| raies | afazekas: Then what u want to suggest here ? for my case I wanted to make a local function in the end to check if interface is json/xml. if json use master branch code for list cases if xml then use code what i used in patch 7 list cases | 04:29 |
| afazekas | Why the old code does not work with the xml version ? | 04:30 |
| raies | old code uses following line -- > "for n in ports_list:" , In case of xml response body is such that in "n" only single value "port/network/subnet" comes | 04:31 |
| raies | afazekas: If u have time then please check after applying my patch | 04:32 |
| * afazekas is waiting for image prepare | 04:33 | |
| *** LiangZheng has joined #openstack-qa | 04:37 | |
| raies | afazekas : | 04:38 |
| *** mberwanger has quit IRC | 04:38 | |
| *** rhsu has quit IRC | 04:40 | |
| *** LiangZheng has quit IRC | 04:41 | |
| * afazekas is waiting for devstack | 04:44 | |
| *** LiangZheng has joined #openstack-qa | 04:50 | |
| * afazekas is planning to add DB restore capability to the devstack, instead of the boring time consuming sqlalchemy migrate wait | 04:50 | |
| raies | afazekas: are u there ? | 05:05 |
| afazekas | I had fight with the tox version upgrade, now I am ready for checking it | 05:06 |
| raies | afazekas: please check. | 05:08 |
| raies | afazekas : | 05:20 |
| *** SergeyLukjanov has joined #openstack-qa | 05:24 | |
| afazekas | The old network listing testcase is passing from me | 05:26 |
| raies | afazekas: with xml ? | 05:27 |
| afazekas | yes | 05:27 |
| raies | are u sure ? | 05:27 |
| raies | afazekas: Please let me check | 05:28 |
| afazekas | I check is it really using xml :) | 05:29 |
| afazekas | the full log contains xml traffic | 05:32 |
| raies | afazekas: Really is working i checked :) | 05:32 |
| raies | sorry for the inconvenience | 05:32 |
| raies | afazekas: Thanks for help :) Now I should recommit it :) | 05:32 |
| afazekas | np | 05:33 |
| afazekas | Please try to avoid the unnecessary line changes | 05:33 |
| afazekas | new line removal and addition to an unrelated place is frequent -1 reason | 05:34 |
| raies | yes I will check them also | 05:34 |
| raies | vim space | 05:34 |
| afazekas | The unrelated change chunks makes more difficult to read the unified diffs | 05:34 |
| raies | new line | 05:34 |
| afazekas | some cases you rename things, this kind of things not passes always on review | 05:35 |
| *** yfried has joined #openstack-qa | 05:36 | |
| afazekas | https://review.openstack.org/#/c/41673/7/tempest/api/network/test_networks.py L107-L110 type change can be on issue, I usually does not note them if just a few | 05:37 |
| raies | afazekas : what is there, not all right there ? | 05:39 |
| raies | afazekas : till now what I incorporated is - vim space , line 47 removal, mtrennish comment for base.py , previous code for list case restored, removed port negative case (will add in new review) | 05:41 |
| afazekas | test_create_update_delete_network_subnet renames are unrelated things | 05:41 |
| afazekas | for the xml/json patch just add L27 and the L234.. to this file https://review.openstack.org/#/c/41673/7/tempest/api/network/test_networks.py | 05:42 |
| afazekas | I am searching for minor nits what sometimes noted on a review | 05:44 |
| afazekas | https://review.openstack.org/#/c/41673/7/tempest/api/network/base.py L51 must be deleted | 05:44 |
| raies | L51 is deleted in new patch what i will apply | 05:45 |
| afazekas | tempest/services/network/xml/network_client.py update_port(self, port_id, new_name) | 05:46 |
| afazekas | as in the json version | 05:46 |
| afazekas | wait a sec .. | 05:47 |
| *** thomasbiege has joined #openstack-qa | 05:48 | |
| afazekas | keep it as name | 05:48 |
| raies | in json it is new_name too | 05:49 |
| raies | afazekas : then why to change ? | 05:49 |
| afazekas | Ok use the same name as in the json | 05:50 |
| afazekas | the json has the new_name version | 05:50 |
| raies | afazekas: u there ? | 05:51 |
| afazekas | yes | 05:51 |
| raies | in json is there new_name then why i should i change , I thing new_should be there otherwise I have to change a lot locations | 05:52 |
| afazekas | http://www.fpaste.org/33335/76977949/ | 05:52 |
| openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Implement some test of extend-volume https://review.openstack.org/42813 | 05:52 |
| raies | afazekas: I did not understand on "test_create_update_delete_network_subnet". It has been accepted. Update is called in combination because of create so that created network can be updated , to not affect enviroment | 05:53 |
| afazekas | you should use the same name with xml | 05:53 |
| raies | afazekas: i can see here "new_name" https://github.com/openstack/tempest/blob/master/tempest/services/network/json/network_client.py , | 05:56 |
| raies | in update_port | 05:56 |
| raies | afazekas: should I change it ? | 05:56 |
| afazekas | IMHO just calling them as 'name' is better, I will ask mtreinihs what to do | 05:56 |
| afazekas | I am planning to create some rest client arg/param guideline, and imho the parameters should have the same name as in the request | 05:58 |
| raies | afazekas: I dont want to amend here because if I am changing one for network then I have to change for port and subnet also at too many locations. Thats why I want to avoid | 05:58 |
| afazekas | so imho you should keep the 'name' name , and the json version will be changed | 05:59 |
| *** thomasbiege1 has joined #openstack-qa | 05:59 | |
| afazekas | these are used as positional argument you do not need to change .. | 05:59 |
| raies | afazekas: then finally what u want ? | 06:01 |
| raies | if it will affect u later then better would to rename it to "name" | 06:01 |
| raies | afazekas: what u say ? | 06:01 |
| afazekas | IMHO the xml version is good as it is | 06:01 |
| afazekas | sorry for the noise | 06:02 |
| *** thomasbiege has quit IRC | 06:02 | |
| afazekas | I thinked loudly | 06:02 |
| raies | afazekas: np :) | 06:02 |
| raies | now i will commit new patch | 06:02 |
| raies | afazekas: my changes are as - "vim space , line 47 removal, mtrennish comment for base.py , previous code for list case restored, removed port negative case (will add in new review)" | 06:03 |
| raies | please suggest if any more or I should proceed with commit :) | 06:03 |
| * afazekas waiting for other core reviewer to awake | 06:03 | |
| afazekas | jenkins will say something to to the new version in 1 hour | 06:07 |
| afazekas | we probably need to wait 3-4 hour for another reviewer anyway | 06:08 |
| afazekas | While waiting we can comment the other pending reviews .. | 06:09 |
| *** thomasbiege1 has quit IRC | 06:13 | |
| *** thomasbiege has joined #openstack-qa | 06:17 | |
| raies | afazekas: During commit I changed description of https://review.openstack.org/#/c/41673/ because 1 test case (port negative) is deleted , then something out stacnding error is comming | 06:19 |
| afazekas | ? | 06:20 |
| raies | *outstanding commit | 06:22 |
| raies | when provoked for yes , commit got failed | 06:22 |
| openstackgerrit | afazekas proposed a change to openstack-dev/devstack: Configure bash completion https://review.openstack.org/41928 | 06:27 |
| openstackgerrit | afazekas proposed a change to openstack-dev/devstack: Defining a bash completion function https://review.openstack.org/42402 | 06:27 |
| afazekas | raies: can you elaborate it ? | 06:28 |
| openstackgerrit | garyk proposed a change to openstack-dev/devstack: VMware: update conder support for VMware configuration settings https://review.openstack.org/42824 | 06:48 |
| afazekas | What does the 'commit got failed' means in this context ? | 06:48 |
| *** fbo is now known as fbo_away | 06:49 | |
| *** SergeyLukjanov has quit IRC | 06:50 | |
| *** jhenner has joined #openstack-qa | 06:53 | |
| *** tkammer has joined #openstack-qa | 06:59 | |
| openstackgerrit | garyk proposed a change to openstack-dev/devstack: VMware: update cinder support for VMware configuration settings https://review.openstack.org/42824 | 06:59 |
| raies | afazekas : during commit, if I want to delete a line in description then what precautions I should take ? | 07:00 |
| *** Anju has joined #openstack-qa | 07:00 | |
| afazekas | raies: Do not mix something with the change-id | 07:01 |
| afazekas | Are you speaking about the git commit message right ? | 07:01 |
| raies | afazekas: yes | 07:01 |
| raies | I want to delete a line in thevious descriptinon | 07:02 |
| raies | when I tried first there was outstanding commit queries and error I can't explaint it now | 07:02 |
| afazekas | Change-Id: should be the last line maybe it needs to be separate by a new line | 07:03 |
| afazekas | looks like the new line is not required | 07:03 |
| raies | afazekas: Let me try once again | 07:03 |
| afazekas | there is some 'pep8' checking on the git commit message as well | 07:04 |
| raies | ok | 07:05 |
| *** Anju_ has joined #openstack-qa | 07:07 | |
| *** Anju has quit IRC | 07:08 | |
| *** SergeyLukjanov has joined #openstack-qa | 07:11 | |
| *** SergeyLukjanov has quit IRC | 07:14 | |
| *** Anju has joined #openstack-qa | 07:21 | |
| *** Anju_ has quit IRC | 07:23 | |
| *** xqueralt-afk is now known as xqueralt | 07:26 | |
| openstackgerrit | garyk proposed a change to openstack-dev/devstack: VMware: update cinder support for VMware configuration settings https://review.openstack.org/42824 | 07:37 |
| *** SergeyLukjanov has joined #openstack-qa | 07:38 | |
| openstackgerrit | raiesmh08 proposed a change to openstack/tempest: Adding network api xml support https://review.openstack.org/41673 | 07:40 |
| raies | afazekas: I have added patch 8 after incorporating review comments. Please check and review it . Now I will be away for half an hour :) | 07:42 |
| afazekas | ok | 07:43 |
| openstackgerrit | afazekas proposed a change to openstack-dev/devstack: Configure bash completion https://review.openstack.org/41928 | 07:44 |
| *** SergeyLukjanov has quit IRC | 08:00 | |
| *** fbo_away is now known as fbo | 08:07 | |
| *** Anju has quit IRC | 08:10 | |
| afazekas | raies: Do you really need to change more than 3 line in the https://review.openstack.org/#/c/41673/8/tempest/api/network/test_networks.py ? | 08:23 |
| *** giulivo has joined #openstack-qa | 08:25 | |
| afazekas | "for the xml/json patch just add L27 and the L234.. to this file https://review.openstack.org/#/c/41673/7/tempest/api/network/test_networks.py" | 08:26 |
| *** psedlak has joined #openstack-qa | 08:27 | |
| *** SergeyLukjanov has joined #openstack-qa | 08:27 | |
| raies | afazekas: I didn't understand | 08:47 |
| raies | afazekas: u there ? | 08:48 |
| afazekas | yes | 08:49 |
| raies | afazekas: you have written "for the xml/json patch just add L27 and the L234.. to this file https://review.openstack.org/#/c/41673/7/tempest/api/network/test_networks.py" | 08:50 |
| afazekas | patchet 8 still does unrelated changes in the test_networks.py, which are not mentioned even in the commit message | 08:50 |
| raies | I did not understand this | 08:51 |
| afazekas | I say it on the review, to be more clear | 08:51 |
| raies | ok | 08:52 |
| raies | afazekas: For what changes u are talking about ? | 08:54 |
| raies | as the create_por() function is modified as u had suggested to use keyword argument | 08:54 |
| raies | so I need to change the code where create_port function is being used :) | 08:55 |
| afazekas | you do not need, since it is an optional parameter | 08:56 |
| *** Anju has joined #openstack-qa | 08:56 | |
| raies | afazekas: So I think, I have added more parameter to justify the keyword argument based function create_port ? It will be better to add I think | 08:58 |
| raies | afazekas : It will affect the code in good way I thinl | 08:59 |
| raies | *think | 08:59 |
| afazekas | Yes, but following the "Structural split of changes" is usually important | 09:00 |
| afazekas | Lot of changes even not related to the port naming | 09:01 |
| afazekas | "Structural split of changes" is followed by almost all openstack project | 09:02 |
| afazekas | raies: what do you think what is more easy, convincing two core review they are ok in the same change, or just moving them into a second change ? | 09:04 |
| raies | afazekas: ok I will apply a new patch with incorporating review comments :( | 09:05 |
| raies | afazekas: please recheck your first comment and validate ? as in master branch single line is there | 09:08 |
| afazekas | ?? | 09:09 |
| raies | l24 | 09:09 |
| raies | This 2 line is required. | 09:09 |
| afazekas | L26 L27, keep those lines | 09:10 |
| raies | afazekas: yes it was previously being used, u commented for any special purpose ? | 09:11 |
| raies | afazekas: I mean it as 2 blank lines are needed | 09:12 |
| afazekas | no, the comment is in wrong place | 09:13 |
| afazekas | I just tried to say hat area is ok | 09:14 |
| afazekas | the end of the file is also ok | 09:14 |
| raies | afazekas: comment in L64 please see | 09:14 |
| Anju | afazekas : ping | 09:15 |
| Anju | afazekas : are u usig new master branch of devstack? | 09:16 |
| afazekas | raies: basically what is recommended to do, us the original file and just add | 09:16 |
| afazekas | - class rename | 09:16 |
| afazekas | - interface | 09:16 |
| afazekas | - XML class | 09:16 |
| afazekas | Anju: yes | 09:17 |
| *** sthaha has quit IRC | 09:17 | |
| raies | afazekas: ok | 09:17 |
| afazekas | Probably you need to upgrade tox | 09:17 |
| afazekas | Anju: ^^ | 09:17 |
| Anju | afazekas : there is a error | 09:17 |
| Anju | when i was usin it | 09:18 |
| Anju | of xenserver | 09:18 |
| afazekas | I am not using xen | 09:18 |
| afazekas | what is the issue ? | 09:18 |
| Anju | just wait | 09:18 |
| Anju | i am showing u a patch which is added in the master branch on aug 10 | 09:19 |
| Anju | yesterday when i clon a new devstack | 09:19 |
| Anju | then this problem occured | 09:19 |
| raies | afazekas: I think L155 should be ok | 09:20 |
| raies | afazekas: as this is required to check for response code ? | 09:20 |
| raies | afazekas : u there ? | 09:22 |
| afazekas | raies: question is what can be in the same change, yes your are correct the response status code should be checked somewhere | 09:23 |
| raies | :) | 09:23 |
| afazekas | The question is is it required for xml/json | 09:23 |
| afazekas | is the commit message covers this change ? | 09:23 |
| raies | afazekas: not yet. But we add description there. | 09:24 |
| afazekas | raies: I can +2 it anyway (especially if you pay me beer), but I am not sure it can pass .. | 09:24 |
| Anju | afazekas : https://github.com/openstack-dev/devstack/commit/e0d4aebe7a584c94b3b17fde59fa710a2bf84bbb | 09:25 |
| Anju | these changes are currently in your stackrc file | 09:25 |
| Anju | ? | 09:25 |
| raies | afazekas: We Indian always ready to serve our guests (As "Atithi devo bhavah" -- guest is like god to us). When U will come India I will help you with beer and "Indian Desi Tharra" | 09:27 |
| raies | afazekas: btw | 09:27 |
| afazekas | Anju: $ git log | grep e0d4aebe7a584c94b3b17fde59fa710a2bf84bbb | 09:28 |
| afazekas | commit e0d4aebe7a584c94b3b17fde59fa710a2bf84bbb | 09:28 |
| *** sthaha has joined #openstack-qa | 09:28 | |
| raies | if u suggest I can remove the response code cheching | 09:28 |
| afazekas | giulivo, mkoderer : what is your opinion in this quest? ^^ | 09:29 |
| raies | afazekas: please give your final comment :) whether I should amend commit description or remove the response checking code | 09:29 |
| Anju | afazekas : not clear to me | 09:30 |
| afazekas | raies: I have doubts anybody would ask why you not checking the response code in + xml change, but someone might ask why do you add this in this change.. | 09:31 |
| giulivo | afazekas, thanks for pinging, what is the review? | 09:31 |
| afazekas | Anju: what is your issue whit that change ? | 09:31 |
| afazekas | giulivo: https://review.openstack.org/#/c/41673/7 | 09:31 |
| giulivo | Anju, how is it going with your new account and the xml client? | 09:31 |
| *** SergeyLukjanov has quit IRC | 09:32 | |
| Anju | giulivi : hiii | 09:32 |
| raies | afazekas: i think it should be there :) lets what get happen to it for sure. I am going to add it :) | 09:32 |
| afazekas | giulivo: raies is the owner | 09:32 |
| afazekas | raies: At least add it to the commit message we will see is it able to pass in the same change :) | 09:33 |
| Anju | giulivo : hiii, when i will add that u will get a mail :) | 09:33 |
| raies | afzekas: ok I will add description in commit message | 09:34 |
| giulivo | Anju, sure, just asking, enjoy :) | 09:34 |
| Anju | giulivo : yeah ,thanks :) | 09:34 |
| raies | afazekas: one more thing is there: L197 | 09:34 |
| Anju | afazekas : these changes was giving me a issue in devstack | 09:35 |
| Anju | whe i reinstalled it with master branch | 09:35 |
| raies | afazekas: as list cases of subnet and network are like "for n in subnets/networks:" | 09:35 |
| afazekas | Anju: what is the issue, are you using xen ? are you sure that change causes the issue ? | 09:36 |
| raies | afazekas: So I thaught that L197 should be like for n in ports: not ports_list | 09:36 |
| Anju | afazekas : i want to know that is this happening only in my system | 09:38 |
| Anju | or with others. | 09:38 |
| Anju | afazekas : that is why asked have u upgraded your devstack | 09:38 |
| Anju | or using the old one | 09:38 |
| raies | afazekas: u there ? | 09:39 |
| afazekas | raies: I will wait for another reviewer to comment it first | 09:39 |
| raies | afazekas : any special reason ?? | 09:39 |
| afazekas | raies: If they like it (+2) I just need to approve, If do not like it I will not need to disagree on review | 09:41 |
| raies | afazekas: ok | 09:42 |
| raies | I am applying new patch | 09:42 |
| raies | please suggest someone to review it :) | 09:43 |
| openstackgerrit | raiesmh08 proposed a change to openstack/tempest: Adding network api xml support https://review.openstack.org/41673 | 09:45 |
| raies | afazekas: I have applied it now you can check it :) | 09:45 |
| raies | afazekas: please check https://review.openstack.org/#/c/42624/ also | 09:47 |
| openstackgerrit | A change was merged to openstack/tempest: Fixing the rest of the comment spacing issues https://review.openstack.org/42461 | 09:48 |
| afazekas | https://review.openstack.org/#/c/42624/ does not looks good | 09:48 |
| afazekas | http://www.fpaste.org/33384/69922321/ I guess it looks like this | 09:50 |
| raies | afazekas: any reason ? | 09:50 |
| afazekas | raies: this is the usual xml structure | 09:52 |
| raies | afazekas: I will check it | 09:52 |
| raies | got it | 09:52 |
| afazekas | unless you want to specify a network with two name | 09:52 |
| afazekas | :) | 09:53 |
| Anju | afazekas : | 09:57 |
| Anju | yes when I delete line no 186 https://github.com/openstack-dev/devstack/commit/e0d4aebe7a584c94b3b17fde59fa710a2bf84bbb | 09:59 |
| Anju | in this in my stackrc file | 09:59 |
| Anju | then it was running | 09:59 |
| Anju | afazekas : devstack installed successfully but api was not running | 10:00 |
| *** LiangZheng has quit IRC | 10:04 | |
| afazekas | which api ? | 10:06 |
| Anju | anyone | 10:07 |
| Anju | means cli | 10:07 |
| Anju | i ran cli first | 10:07 |
| afazekas | which ? | 10:08 |
| afazekas | all of them ? | 10:08 |
| Anju | nova list | 10:08 |
| afazekas | what is the error message ? | 10:08 |
| Anju | xenserver error | 10:09 |
| afazekas | do you have issue with glance and keystone as well ? | 10:09 |
| Anju | yes | 10:09 |
| afazekas | where do you see the xenserver error ? | 10:09 |
| Anju | when i was running any cli | 10:09 |
| Anju | it just showing me that one line message | 10:09 |
| afazekas | you get 500 response with xen server ? | 10:10 |
| Anju | there was nothing like this | 10:10 |
| Anju | a simple message | 10:11 |
| Anju | when i commented the 186 line ehich is introduced in new devstack master branch | 10:11 |
| Anju | then it was running | 10:12 |
| afazekas | can you paste somewhere a nova --debug list output | 10:12 |
| Anju | cant this time :( | 10:12 |
| Anju | are u using the updted devstack | 10:12 |
| Anju | ? | 10:12 |
| afazekas | normally I get fresh devstack on every vm start | 10:13 |
| Anju | u clone every time ? | 10:13 |
| afazekas | On the image I have all repos, I just need to pull them (in parallel), some places I also have local mirror | 10:14 |
| Anju | check that these lines are in your stackrc file if yes means that u are not facing this error https://github.com/openstack-dev/devstack/commit/e0d4aebe7a584c94b3b17fde59fa710a2bf84bbb | 10:14 |
| afazekas | Anju: try to remove the xenserver-core | 10:15 |
| Anju | afazekas : yes i did the same | 10:16 |
| Anju | was running | 10:16 |
| Anju | afazekas : then everytime everyone have to comment this line ? | 10:17 |
| afazekas | Anju: you just need to uninstall the xenserver-core if you want the original behavior | 10:18 |
| afazekas | or add the VIRT_DRIVER=libvirt to your localrc | 10:19 |
| Anju | ok afazekas : will do and tell :) | 10:19 |
| Anju | thanks for help | 10:19 |
| afazekas | Anju: you are welcome | 10:20 |
| afazekas | Anju: I think next time you should start with several pastebin entry about the issue | 10:20 |
| Anju | means ? | 10:22 |
| Anju | afazekas : u are saying the output after debug | 10:23 |
| afazekas | for example | 10:23 |
| afazekas | an actual output example usually tells more then several words without a context, I was even not sure are you using xen or not | 10:25 |
| Anju | yeah : correct ..so sry ..yesterday u were not good so didnt ask .and today i have not my system | 10:26 |
| Anju | so | 10:26 |
| Anju | :) | 10:26 |
| afazekas | :) | 10:26 |
| Anju | afazekas : did u check our stackrc file? | 10:27 |
| Anju | i means this code is added in that or not | 10:28 |
| *** thomasbiege has quit IRC | 10:28 | |
| openstackgerrit | raiesmh08 proposed a change to openstack/tempest: Adding network api xml support https://review.openstack.org/41673 | 10:30 |
| raies | afazekas: https://review.openstack.org/#/c/42624/ and https://review.openstack.org/#/c/41673, I think now u can consider it | 10:33 |
| raies | afazekas: u there ? | 10:36 |
| *** mkollaro has joined #openstack-qa | 10:37 | |
| *** SergeyLukjanov has joined #openstack-qa | 10:37 | |
| afazekas | raises: the request in the test case starts with <?xml version="1.0" encoding="UTF-8"?> | 10:38 |
| afazekas | why it has additional space .. | 10:39 |
| raies | which file ? | 10:40 |
| afazekas | not the file, looks like our xml request formater adds a space even if the element does not have an attribute ... | 10:41 |
| afazekas | not a real issue | 10:41 |
| raies | afazekas : ok | 10:42 |
| raies | afazekas: from tempest/api/network/test_networks.py i have almost incorporated suggested by you. Now you can mean it I think :) | 10:43 |
| * afazekas is hunting for food | 10:45 | |
| *** jasondotstar has quit IRC | 10:45 | |
| *** mkollaro has quit IRC | 10:55 | |
| *** giulivo has quit IRC | 10:56 | |
| *** dosaboy_ has joined #openstack-qa | 10:57 | |
| *** dosaboy has quit IRC | 10:59 | |
| *** thomasbiege has joined #openstack-qa | 11:02 | |
| *** SergeyLukjanov has quit IRC | 11:12 | |
| *** Anju has quit IRC | 11:26 | |
| raies | afazekas: u there ? | 11:29 |
| *** weshay has joined #openstack-qa | 11:31 | |
| openstackgerrit | Ivan-Zhu proposed a change to openstack/tempest: port test_aggregates and test_hosts into v3 part1 https://review.openstack.org/42868 | 11:38 |
| openstackgerrit | Ivan-Zhu proposed a change to openstack/tempest: port test_aggregates and test_hosts into nova v3 part2 https://review.openstack.org/42869 | 11:38 |
| *** SergeyLukjanov has joined #openstack-qa | 11:39 | |
| *** tkammer has quit IRC | 11:44 | |
| *** SergeyLukjanov has quit IRC | 11:44 | |
| *** tkammer has joined #openstack-qa | 11:44 | |
| raies | afazekas: u there ? | 11:45 |
| *** HenryG has joined #openstack-qa | 11:49 | |
| *** raies has quit IRC | 11:52 | |
| afazekas | raies: pong | 11:53 |
| *** afazekas is now known as afazekas_no_irq | 11:59 | |
| *** mkollaro has joined #openstack-qa | 12:04 | |
| *** mriedem has joined #openstack-qa | 12:19 | |
| *** giulivo has joined #openstack-qa | 12:23 | |
| *** anteaya has joined #openstack-qa | 12:29 | |
| *** SergeyLukjanov has joined #openstack-qa | 12:35 | |
| *** dkranz has joined #openstack-qa | 12:39 | |
| *** SergeyLukjanov has quit IRC | 12:47 | |
| *** jasondotstar has joined #openstack-qa | 12:49 | |
| *** dkranz has quit IRC | 12:55 | |
| *** jog0 is now known as jog0-away | 13:01 | |
| *** mberwanger has joined #openstack-qa | 13:01 | |
| *** adalbas has quit IRC | 13:03 | |
| openstackgerrit | Ivan-Zhu proposed a change to openstack/tempest: port test_services into nova v3 part1 https://review.openstack.org/42880 | 13:12 |
| *** whayutin_ has joined #openstack-qa | 13:14 | |
| *** weshay has quit IRC | 13:16 | |
| openstackgerrit | Ivan-Zhu proposed a change to openstack/tempest: port test_services into nova v3 part2 https://review.openstack.org/42885 | 13:19 |
| *** HenryG has quit IRC | 13:27 | |
| *** malini_afk is now known as malini | 13:34 | |
| *** mberwanger has quit IRC | 13:35 | |
| openstackgerrit | afazekas proposed a change to openstack-dev/devstack: Configure bash completion https://review.openstack.org/41928 | 13:41 |
| *** burt has joined #openstack-qa | 13:42 | |
| *** thomasbiege2 has joined #openstack-qa | 13:43 | |
| *** thomasbiege has quit IRC | 13:46 | |
| openstackgerrit | Ivan-Zhu proposed a change to openstack/tempest: port test_aggregates and test_hosts into nova v3 part2 https://review.openstack.org/42869 | 13:47 |
| *** whayutin_ has quit IRC | 13:49 | |
| *** weshay has joined #openstack-qa | 14:01 | |
| *** raies has joined #openstack-qa | 14:22 | |
| raies | afazekas: hi | 14:23 |
| afazekas_no_irq | raies: hi | 14:24 |
| *** thomasbiege2 has quit IRC | 14:28 | |
| giulivo | ping afazekas_no_irq | 14:30 |
| giulivo | doh _no_irq ! :( | 14:30 |
| afazekas_no_irq | giulivo: pong | 14:32 |
| giulivo | sorry for irq I didn't notice that until hit TAB :( | 14:33 |
| afazekas_no_irq | It was an NMI :) | 14:33 |
| giulivo | so the question is about https://review.openstack.org/#/c/36937 | 14:33 |
| giulivo | what is the reason for that? | 14:33 |
| afazekas_no_irq | +72, -175 | 14:33 |
| afazekas_no_irq | You just need to add 4 lines instead 8 for new client | 14:34 |
| afazekas_no_irq | There is two possible re-factor at the moment | 14:34 |
| giulivo | yeah indeed I was tempted to +1 but thought it was nice to have easy access to the class names for both JSON and XML clients | 14:34 |
| raies | ok | 14:34 |
| afazekas_no_irq | my change moves closer to single authentication per user style | 14:35 |
| afazekas_no_irq | the other refactor possibility is adding factory to all rest client to provide the correct interface (xml/json + version) | 14:35 |
| afazekas_no_irq | But actually it just adds more code, without a real benefit | 14:35 |
| afazekas_no_irq | so probbaly another smaller transform may came when someone touching the authentication location in the model | 14:36 |
| afazekas_no_irq | I did not wanted to create 800 line change for handling everything | 14:37 |
| *** mkollaro has quit IRC | 14:38 | |
| *** __afazekas_zz has quit IRC | 14:41 | |
| *** raies has quit IRC | 14:43 | |
| openstackgerrit | raiesmh08 proposed a change to openstack/tempest: Adding network api xml support https://review.openstack.org/41673 | 14:47 |
| *** sthaha has quit IRC | 14:50 | |
| *** raies has joined #openstack-qa | 14:51 | |
| *** SergeyLukjanov has joined #openstack-qa | 14:51 | |
| raies | afazekas: hi | 14:51 |
| openstackgerrit | Matthew Treinish proposed a change to openstack/tempest: Add tenant isolation to the swift tests https://review.openstack.org/42169 | 14:51 |
| raies | afazekas_no_irq | 14:53 |
| raies | afazekas_no_irq: I applied patch 11 | 14:53 |
| afazekas_no_irq | giulivo: ^^ | 14:54 |
| yfried | Hi, is there anyone who isn't running tempest on devstack, but on an actual openstack? | 15:04 |
| mriedem | yfried: yeah, me, on rhel 6.4 | 15:08 |
| yfried | mriedem: after I have a live openstack setup, what are the steps to configure tempest to work with it? anything not on tempest.conf? | 15:10 |
| mriedem | yfried: not really | 15:11 |
| mriedem | yfried: you could probably just use run_tests.sh -V -f in tempest to run it | 15:11 |
| mriedem | i don't ues a virtual environment though | 15:11 |
| mriedem | since i'm in a vm | 15:11 |
| mriedem | yfried: this is old, but it's what i used to get started: http://fedoraproject.org/wiki/QA:Testcase_run_Tempest_tests | 15:12 |
| mriedem | yfried: most of the work for me was configuring tempest.conf to match the values in my installation, e.g. neutron network, glance image ids, tenant id's, etc etc | 15:13 |
| *** yfried has quit IRC | 15:18 | |
| openstackgerrit | Tal Kammer proposed a change to openstack/tempest: Initial basic setup of openstack and tempest config file https://review.openstack.org/42920 | 15:18 |
| jaypipes | mtreinish: https://review.openstack.org/#/c/42797/ is good to have your +1A on... easy win IMO | 15:39 |
| mtreinish | jaypipes: yep | 15:41 |
| *** afazekas_no_irq is now known as afazekas | 15:42 | |
| *** thomasbiege has joined #openstack-qa | 15:42 | |
| afazekas | jaypipes, mtreinish: https://review.openstack.org/#/c/42018/ | 15:42 |
| *** giulivo has quit IRC | 15:47 | |
| afazekas | tkammer: http://www.youtube.com/watch?v=9QFK1cLhytY :) | 15:47 |
| *** xqueralt has left #openstack-qa | 15:48 | |
| jaypipes | afazekas: done | 15:49 |
| tkammer | afazekas, lol | 15:51 |
| mtreinish | jaypipes: on https://review.openstack.org/#/c/42798 you +A'd that without another +2. Also, I would have -1'd it because he could have just raised a skipException if neutron was enabled in setupClass. | 15:52 |
| tkammer | afazekas, there is another one I love: http://www.youtube.com/watch?v=b-Cr0EWwaTk | 15:52 |
| mtreinish | instead of using a decorator on every test method | 15:52 |
| jaypipes | mtreinish: sorry, I thought cyeoh +2d it... | 15:53 |
| jaypipes | mtreinish: I guess he only _1d it | 15:53 |
| jaypipes | +1d... sorry | 15:53 |
| jaypipes | mtreinish: removed +1A... please feel free to comment on it. | 15:54 |
| afazekas | tkammer: http://www.youtube.com/watch?v=Mt7zsortIXs :) | 15:55 |
| mtreinish | jaypipes: ok thanks I'll do that. | 15:55 |
| jaypipes | mtreinish: sorry bout that | 15:56 |
| mtreinish | jaypipes: do you know if the -1 is enough to prevent the merge | 15:56 |
| mtreinish | jaypipes: its not a problem I've made that mistake before too | 15:56 |
| jaypipes | mtreinish: no.. -2 will prevent | 15:56 |
| mtreinish | should I do that then? | 15:56 |
| jaypipes | with a big red X :) | 15:56 |
| jaypipes | mtreinish: sure, if it is important, go for it. | 15:56 |
| afazekas | mtreinish: Is the skip tracker working when something skipped in a class ? | 15:59 |
| mtreinish | afazekas: not yet it's on my todo list | 15:59 |
| *** tkammer has quit IRC | 16:00 | |
| mtreinish | but we normally only use it with optional features at the class level so there often isn't a bug associated with it. | 16:00 |
| afazekas | mtreinish: BTW on the pending patch imho it should allow just the skip( and skipIf( | 16:00 |
| *** yfried has joined #openstack-qa | 16:00 | |
| mtreinish | afazekas: that won't work with multi-line skips then | 16:02 |
| mtreinish | unless I start getting fancy with the detection and regex | 16:02 |
| mtreinish | which I'm not sure how to go about doing, the skip detection logic starts getting more complex | 16:03 |
| *** Anju has joined #openstack-qa | 16:08 | |
| afazekas | mtreinish: can you show me an example where it is not working ? and where it starts working ? | 16:09 |
| mtreinish | afazekas: look at any skipif that takes 2 lines because the condition is too long. | 16:10 |
| mtreinish | afazekas: right now the skip tracker looks for the skip regex | 16:10 |
| mtreinish | and in the next line the start of a method with a def | 16:10 |
| *** thomasbiege has quit IRC | 16:13 | |
| afazekas | yes | 16:22 |
| afazekas | tkammer: I added several notes, I will try it in real life on this week | 16:24 |
| afazekas | mtreinish: I see guilivo also commented it | 16:26 |
| *** psedlak has quit IRC | 16:36 | |
| *** adalbas has joined #openstack-qa | 16:38 | |
| *** yfried has quit IRC | 16:39 | |
| *** jhenner has quit IRC | 16:41 | |
| *** afazekas has quit IRC | 16:54 | |
| raies | jaypipes: hi | 16:57 |
| *** fbo is now known as fbo_away | 17:01 | |
| *** jhenner has joined #openstack-qa | 17:06 | |
| *** jhenner has quit IRC | 17:15 | |
| *** raies has quit IRC | 17:16 | |
| *** hemnafk is now known as hemna | 17:22 | |
| *** SergeyLukjanov has quit IRC | 17:34 | |
| *** Anju has quit IRC | 18:11 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/tempest: Add a more detailed message about the volumes missing. https://review.openstack.org/42964 | 18:12 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/tempest: Add a more detailed message about the volumes missing. https://review.openstack.org/42964 | 18:14 |
| *** yfried has joined #openstack-qa | 18:35 | |
| *** SergeyLukjanov has joined #openstack-qa | 18:43 | |
| *** SergeyLukjanov has quit IRC | 18:43 | |
| *** openstack` has joined #openstack-qa | 18:51 | |
| *** openstack has quit IRC | 18:51 | |
| *** openstack` is now known as openstack | 18:52 | |
| openstackgerrit | Avishay Traeger proposed a change to openstack-dev/grenade: Update Cinder's policy.json file https://review.openstack.org/42971 | 18:53 |
| *** afazekas has joined #openstack-qa | 18:53 | |
| openstackgerrit | Ravi Chunduru proposed a change to openstack-dev/devstack: blueprint quantum-fwaas-devstack Adds support for Openstack Networking FWaaS (Firewall) https://review.openstack.org/37147 | 18:59 |
| openstackgerrit | Russell Bryant proposed a change to openstack-dev/devstack: Enabled the compute admin API by default https://review.openstack.org/42974 | 19:01 |
| *** mriedem1 has joined #openstack-qa | 19:02 | |
| *** mriedem has quit IRC | 19:03 | |
| *** thomasbiege1 has joined #openstack-qa | 19:06 | |
| afazekas | mtreinish: https://review.openstack.org/#/c/42169 do we really need a new admin user ? | 19:14 |
| *** fbo_away is now known as fbo | 19:15 | |
| *** jhenner has joined #openstack-qa | 19:17 | |
| mtreinish | afazekas: I'd rather err on the side of caution and have everything in there own tenant and user. But, it's probably not strictly required, I didn't do a thorough audit of how the tests use the admin user. | 19:18 |
| mtreinish | but even if not's needed now I could easily see a condition where the isolation might be useful in future tests | 19:18 |
| afazekas | I see more issue in long run to introducing not necessary admin isolation, then it may solve now | 19:19 |
| afazekas | The admin usually not limited by tenant, the in most cases does not creates a resource in his tenant | 19:21 |
| afazekas | May just in some tenant 'isolation' related test case | 19:21 |
| afazekas | The admin usually not limited by tenant, in most cases admin does not creates a resource in his tenant | 19:22 |
| afazekas | May be he does just in some tenant 'isolation' related test case, but those are not the best example | 19:23 |
| * afazekas go to sleep, I have more grammar issue than usually | 19:23 | |
| mtreinish | afazekas: the admin users can't create resources in tenants they're not a member of. But, they are able to control global state (which includes tenant membership) | 19:25 |
| mtreinish | so in that sense the tenant isolation doesn't mean much if they can add themselves to any tenant | 19:26 |
| *** HenryG has joined #openstack-qa | 19:26 | |
| mtreinish | but I don't really see any harm in creating an isolated admin user and tenant for the swift tests | 19:26 |
| afazekas | It is unnecessary in swift case IMHO | 19:29 |
| *** malini is now known as malini_afk | 19:34 | |
| *** thomasbiege1 has quit IRC | 19:34 | |
| afazekas | mtreinish: I am hesitant for a +2, but I am close to do that. Removing the admin isolation, or proving it is required will be good for +2. Or I just need to sleep for it :) | 19:40 |
| afazekas | mtreinish: +2, but I still not think it is really required | 19:48 |
| openstackgerrit | A change was merged to openstack-infra/devstack-gate: Use git.openstack.org as origin https://review.openstack.org/42693 | 19:52 |
| afazekas | cyeoh, jaypipes, mtreinish: https://review.openstack.org/#/c/34866/ | 19:52 |
| *** afazekas has quit IRC | 19:54 | |
| *** SergeyLukjanov has joined #openstack-qa | 19:58 | |
| openstackgerrit | Avishay Traeger proposed a change to openstack-dev/grenade: Update Cinder's policy.json file https://review.openstack.org/42971 | 20:21 |
| *** HenryG has quit IRC | 20:23 | |
| openstackgerrit | Clark Boylan proposed a change to openstack-infra/devstack-gate: Replace review.o.o with git.o.o. https://review.openstack.org/42989 | 20:28 |
| *** SergeyLukjanov has quit IRC | 20:42 | |
| openstackgerrit | Russell Bryant proposed a change to openstack-dev/devstack: Enable the compute admin API by default https://review.openstack.org/42974 | 20:43 |
| *** fbo is now known as fbo_away | 21:16 | |
| *** thomasbiege1 has joined #openstack-qa | 21:22 | |
| *** thomasbiege1 has quit IRC | 21:26 | |
| *** jhenner has quit IRC | 21:48 | |
| *** thomasbiege1 has joined #openstack-qa | 21:51 | |
| openstackgerrit | Salvatore Orlando proposed a change to openstack-dev/devstack: Colorize Neutron log output and refactor log setup code https://review.openstack.org/43006 | 21:54 |
| *** weshay has quit IRC | 21:55 | |
| *** thomasbiege1 has quit IRC | 22:00 | |
| *** mriedem1 has quit IRC | 22:03 | |
| *** burt has quit IRC | 22:08 | |
| openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "create security rule" method https://review.openstack.org/42303 | 22:52 |
| *** sthaha has joined #openstack-qa | 22:58 | |
| *** sthaha has joined #openstack-qa | 22:58 | |
| openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/tempest: Cleanup: Add common "ssh-login server" method https://review.openstack.org/42569 | 23:08 |
| *** HenryG has joined #openstack-qa | 23:31 | |
| *** mriedem has joined #openstack-qa | 23:48 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!