| opendevreview | Maxim Sava proposed openstack/tempest master: Add delete image from specific store API https://review.opendev.org/c/openstack/tempest/+/898544 | 05:55 |
|---|---|---|
| sean-k-mooney | clarkb: dansmith: gmann: so i figured out why installing in a venv is broken on centos 9 stream and i more or less expect it to break on ubuntu at some point too. | 06:16 |
| sean-k-mooney | tl;dr pip 20.2 deprecated calling setup.py install if pyproject.toml is not found and in 23.1 that fallback was removed | 06:17 |
| sean-k-mooney | without that fallback whle some of the pbr code seams to be invoked not all of it is run, sepcifcally what happens is the local installl path which is where we generate the wsgi files is not invovked because of how pip is building a tempory wheel | 06:18 |
| sean-k-mooney | the fix for this is simple we just need to add the minimal pyproject.toml to tell pip to use pbr as the build system https://review.opendev.org/c/openstack/keystone/+/899519 | 06:19 |
| sean-k-mooney | that restores the correct behavior | 06:19 |
| sean-k-mooney | im off on monday but if we agree with that approch i can send a mail to the list and start proposing the same patch to some/all repos | 06:19 |
| sean-k-mooney | if people have a script for that it would help | 06:20 |
| sean-k-mooney | otherwise ill just do it for the main ones | 06:20 |
| sean-k-mooney | pbr will still use setup.cfg to read all the entry point ectra so we dont actully need ot stop haveing or using setup.cfg or setup.py we just need to tell pip about pbr properly which is what i have done in that keystone review by using the exampel form the pbr repo. | 06:21 |
| sean-k-mooney | i have left more context in https://review.opendev.org/c/openstack/keystone/+/899519/2#message-79795188b149c9d830023c4ee5c4801951e24573 and https://review.opendev.org/c/openstack/keystone/+/899519/2#message-ec006563fbe402e307c5e0595fdf5c2c83b549b2 | 06:43 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!