opendevreview | Abhishek Kekane proposed openstack/tempest master: Provid raw disk-format to images which uses raw data https://review.opendev.org/c/openstack/tempest/+/923352 | 05:24 |
---|---|---|
abhishek_ | gmann: if you are still around ^^ | 05:24 |
abhishek_ | any tempest core around, above patch is to unblock gate to fix CVE related patches | 05:35 |
abhishek_ | kindly have a look and approve it, thank you!! | 05:35 |
opendevreview | Ashish Gupta proposed openstack/tempest master: Add test to verify hostname allows FQDN https://review.opendev.org/c/openstack/tempest/+/922342 | 06:23 |
opendevreview | Abhishek Kekane proposed openstack/tempest master: Introduce new config parameter to download qcow2 image https://review.opendev.org/c/openstack/tempest/+/923357 | 07:03 |
frickler | kopecmartin: ^^ | 07:33 |
abhishek_ | kopecmartin: https://review.opendev.org/c/openstack/tempest/+/923352 this one as well | 07:47 |
opendevreview | Abhishek Kekane proposed openstack/tempest master: Introduce new config parameter to download qcow2 image https://review.opendev.org/c/openstack/tempest/+/923357 | 07:48 |
opendevreview | Rodolfo Alonso proposed openstack/devstack master: [Neutron] Add a new Neutron service: neutron-ovn-maintenance-worker https://review.opendev.org/c/openstack/devstack/+/922611 | 09:06 |
opendevreview | Abhishek Kekane proposed openstack/tempest master: Introduce new config parameter to download qcow2 image https://review.opendev.org/c/openstack/tempest/+/923357 | 10:58 |
*** gthiemon1e is now known as gthiemonge | 13:27 | |
*** whoami-rajat_ is now known as whoami-rajat | 14:00 | |
surbhi_ | Frickler : Can you look into the messages I have sent? | 14:56 |
abhishekk | cores, I need reviews on two patches, https://review.opendev.org/c/openstack/tempest/+/923357 and https://review.opendev.org/c/openstack/tempest/+/923352 these are required to unblocked gate for glance and get CVE patches in | 14:59 |
abhishekk | frickler, gmann any suggestion, whom I can approach for review ^^ | 16:14 |
frickler | abhishekk: kopecmartin and gmann are the only tempest cores left afaict | 16:15 |
abhishekk | ack, kopecmartin already reviewed, I guess gmann will be around shortly | 16:16 |
clarkb | In this case its probably fine if kopecmartin approves with a single review? | 16:16 |
clarkb | then any issues found in subsequent review can be cleaned up in followups | 16:16 |
dansmith | clarkb: frickler yeah, and I can +1 those tests as someone who knows about them if it would help | 16:57 |
dansmith | and prioritizing them in the queue would be helpful if reasonable | 16:57 |
clarkb | are either kopecmartin or gmann around? a quick +W would allow us to do those things without bypassing hte project's review control | 16:57 |
dansmith | abhishek_: do we need both or just the qcow2->raw one? | 16:58 |
abhishek_ | both | 16:58 |
clarkb | do they need to be squashed together then? | 16:59 |
dansmith | no but they could for speed I guess | 17:00 |
dansmith | I +1'd both, for as much as that means | 17:00 |
fungi | probably only if there's an increased risk of neither passing without the other. if one is fixing a worse problem than the other we can put it first in the queue with the other second | 17:00 |
abhishek_ | one is needed to fix other jobs except nova-ceph-multistore | 17:01 |
abhishek_ | the other new config option fixes that issue for nova-ceph-multistore | 17:01 |
clarkb | fungi: yes that is my concern if they fix different issues and we need both to allow one or the other to pass reliably | 17:01 |
clarkb | ah ok so they address problems in different jobs and can be separate | 17:01 |
dansmith | yeah | 17:01 |
abhishek_ | yes | 17:02 |
fungi | once a tempest maintainer approves them i'm happy to enqueue and promote them in the gate | 17:03 |
* fungi is not a tempest maintainer, can only +1 without abusing administrator privs in gerrit | 17:04 | |
abhishek_ | I am not sure either of them around right now | 17:04 |
abhishek_ | dansmith: I guess we should go ahead with skip or blacklist tests in job for time being | 17:05 |
dansmith | abhishek_: yes, skip is in your control and you can unskip as soon as it is possible | 17:06 |
fungi | it really looks like https://review.opendev.org/admin/groups/tempest-core,members could stand to be revisited | 17:06 |
abhishek_ | dansmith: ack, let me propose one patch for skipping, I guess for nova-ceph job that needs to be done in nova | 17:07 |
fungi | masayukig is also tempest-core and is in the channel, only idle for a couple of days | 17:08 |
dansmith | abhishek_: ack | 17:08 |
opendevreview | Austin Nazworth proposed openstack/stackviz master: Update dependencies for modern node and python https://review.opendev.org/c/openstack/stackviz/+/908678 | 19:33 |
opendevreview | Austin Nazworth proposed openstack/stackviz master: Update dependencies for modern node and python https://review.opendev.org/c/openstack/stackviz/+/908678 | 19:35 |
opendevreview | Merged openstack/tempest master: Provid raw disk-format to images which uses raw data https://review.opendev.org/c/openstack/tempest/+/923352 | 19:55 |
opendevreview | Merged openstack/tempest master: Introduce new config parameter to download qcow2 image https://review.opendev.org/c/openstack/tempest/+/923357 | 20:00 |
opendevreview | Merged openstack/tempest master: extend tempest-integrated-compute and tempest-full-py3 https://review.opendev.org/c/openstack/tempest/+/922108 | 20:08 |
clarkb | fungi: did you end up needing to promote those changes or did they merge through normal processes? | 20:24 |
fungi | clarkb: i promoted them and also dequeued the temporary glance workaround at the same time | 20:33 |
clarkb | oh I see the notes about it in the noav channel now | 20:37 |
opendevreview | Merged openstack/tempest master: Allow visibility of external subnet as shared ones https://review.opendev.org/c/openstack/tempest/+/922938 | 20:51 |
*** haleyb is now known as haleyb|out | 21:18 | |
masayukig | fungi, gmann, kopecmartin thanks for the patches. I think all of the patches are merged now. Do I miss something? | 22:59 |
fungi | masayukig: nope, all good now. thanks for checking in! | 23:03 |
masayukig | fungi: that sounds good. thanks! | 23:05 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!