| gmann | masayukig: yeah, all good. | 03:33 |
|---|---|---|
| masayukig | Thanks! | 03:45 |
| opendevreview | Abhishek Kekane proposed openstack/tempest master: Reno for http_qcow2_image config option https://review.opendev.org/c/openstack/tempest/+/923462 | 06:34 |
| opendevreview | Abhishek Kekane proposed openstack/tempest master: Update http_image config option to use latest image https://review.opendev.org/c/openstack/tempest/+/923463 | 06:41 |
| opendevreview | Pranali Deore proposed openstack/tempest master: Fix the misleading skip test message https://review.opendev.org/c/openstack/tempest/+/923465 | 07:02 |
| abhishekk | So is it allowed to backport a new config option added patch to stable branch, it will need to fix gate till 2023.1 | 07:31 |
| abhishekk | gmann: kopecmartin ^^ | 07:31 |
| frickler | abhishekk: there are no stable branches for tempest. I think back until 2023.1 all runs tempest from master, or so I'd hope, else things will become difficult | 07:32 |
| abhishekk | cool, will recheck one of the stable patch to make sure | 07:34 |
| abhishekk | thank you! | 07:34 |
| opendevreview | Abhishek Kekane proposed openstack/tempest master: Update http_image config option to use latest image https://review.opendev.org/c/openstack/tempest/+/923463 | 08:38 |
| *** iurygregory_ is now known as iurygregory | 13:02 | |
| gmann | abhishekk: yes, no backport needed as tempest is branchless and master is used in all supported branches. you can set same config option in stable branches is it need different value and it will reflect in tests | 16:13 |
| abhishekk | gmann: ++ thank yu | 16:13 |
| abhishekk | also I submitted reno patch | 16:14 |
| gmann | abhishekk: thanks, will check those | 16:14 |
| gmann | abhishekk: one comment in this otherwise lgtm https://review.opendev.org/c/openstack/tempest/+/923463 | 16:18 |
| abhishek_ | looking | 16:21 |
| abhishek_ | gmann: I am sorry, but what should I mention in upgrade section? | 16:22 |
| gmann | abhishek_: change of default vakue from old to new one. same way we do it for services when default value is changed | 16:23 |
| gmann | abhishek_: example https://github.com/openstack/tempest/blob/master/releasenotes/notes/config-image-api-v1-default-to-false-39d5f2xafc534ab1.yaml | 16:23 |
| abhishek_ | ohh, you are talking about different patch, I thought its related to reno patch | 16:24 |
| abhishek_ | will do it | 16:24 |
| abhishek_ | thank you | 16:24 |
| gmann | abhishek_: yeah, this one https://review.opendev.org/c/openstack/tempest/+/923463 | 16:26 |
| gmann | other patch lgtm | 16:26 |
| abhishek_ | cool, will push a new patch shortly | 16:27 |
| opendevreview | Abhishek Kekane proposed openstack/tempest master: Update http_image config option to use latest image https://review.opendev.org/c/openstack/tempest/+/923463 | 16:37 |
| abhishek_ | gmann: ^^ | 16:37 |
| abhishek_ | Can someone tell me is it OK/allowed to approve all stable pathces (2024.1, 2023.2 and 2023.1) all at once or should I go branch by branch merging? | 16:44 |
| gmann | abhishek_: branch by branch is recommended, nova has job to confirm that previous branch backport is merged before next one goes | 16:45 |
| abhishek_ | gmann: ack, thank you will follow the same approach | 16:46 |
| gmann | that way we make sure backport are merged in right order just in case CI or something else block it in previous branches | 16:46 |
| abhishek_ | ++ | 16:46 |
| gmann | abhishek_: seems like two different value in release notes and actual default change. commented | 16:50 |
| abhishek_ | :/ looking | 16:51 |
| gmann | I think we should use x86_64 | 16:51 |
| abhishek_ | needs to change in config | 16:52 |
| abhishek_ | yeah, earlier I directly done the publish and forgot to fetch it to local | 16:52 |
| gmann | ok | 16:55 |
| opendevreview | Abhishek Kekane proposed openstack/tempest master: Update http_image config option to use latest image https://review.opendev.org/c/openstack/tempest/+/923463 | 16:56 |
| abhishek_ | needed to change in commit message as well | 16:57 |
| gmann | thanks, lgtm, waiting for gate result | 17:10 |
| abhishek_ | ++ thank you!! | 17:13 |
| opendevreview | Ashish Gupta proposed openstack/tempest master: Add test to verify hostname allows FQDN https://review.opendev.org/c/openstack/tempest/+/922342 | 19:46 |
| opendevreview | Merged openstack/tempest master: Reno for http_qcow2_image config option https://review.opendev.org/c/openstack/tempest/+/923462 | 20:51 |
| opendevreview | Merged openstack/tempest master: Test image <-> volume <-> server dependency https://review.opendev.org/c/openstack/tempest/+/922873 | 21:36 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!