Thursday, 2020-03-19

*** tetsuro has joined #openstack-release00:10
*** tetsuro has quit IRC00:12
*** tetsuro has joined #openstack-release00:13
*** tetsuro has quit IRC00:19
*** tetsuro has joined #openstack-release00:20
*** tetsuro_ has joined #openstack-release00:30
*** tetsuro has quit IRC00:33
*** mlavalle has quit IRC00:40
*** tosky has quit IRC00:50
*** ianychoi_ has joined #openstack-release01:38
*** ianychoi has quit IRC01:40
*** mgoddard has quit IRC01:49
*** mgoddard has joined #openstack-release01:57
*** tetsuro_ has quit IRC03:51
*** tetsuro has joined #openstack-release04:16
*** udesale has joined #openstack-release04:32
*** tetsuro_ has joined #openstack-release04:49
*** tetsuro has quit IRC04:52
*** tetsuro has joined #openstack-release05:03
openstackgerritAbhishek Kekane proposed openstack/releases master: Release Glance 17.0.1  https://review.opendev.org/71377905:04
*** tetsuro_ has quit IRC05:06
*** dave-mccowan has quit IRC05:10
*** tetsuro_ has joined #openstack-release05:15
*** tetsuro has quit IRC05:18
openstackgerritAbhishek Kekane proposed openstack/releases master: Release glance_store 0.26.2  https://review.opendev.org/71378205:18
openstackgerritAbhishek Kekane proposed openstack/releases master: Release python-glanceclient 2.13.2  https://review.opendev.org/71378305:34
*** evrardjp has quit IRC05:36
*** evrardjp has joined #openstack-release05:36
*** zxiiro has quit IRC06:24
*** tetsuro_ has quit IRC07:49
*** slaweq has joined #openstack-release08:06
*** portdirect has quit IRC08:08
*** guilhermesp has quit IRC08:09
*** mwhahaha has quit IRC08:09
*** portdirect has joined #openstack-release08:10
*** mnaser has quit IRC08:10
*** mwhahaha has joined #openstack-release08:10
*** mnaser has joined #openstack-release08:11
*** rpittau|afk is now known as rpittau08:11
*** guilhermesp has joined #openstack-release08:11
*** e0ne has joined #openstack-release08:16
*** tosky has joined #openstack-release08:21
*** jbadiapa has joined #openstack-release08:33
*** tetsuro has joined #openstack-release08:34
*** tetsuro_ has joined #openstack-release08:40
*** tetsuro has quit IRC08:43
ttxsmcginnis: we got two recent false negative on check-release-approval09:35
ttxhttp://zuul.openstack.org/build/911208ee679d4466a0477a596d72f26709:35
ttxhttp://zuul.openstack.org/build/7d07b54ae3f14668b1fe16ca7c255c9409:35
*** e0ne has quit IRC09:36
ttxThose happened on two different executors, so i don't think the issue is pinned to one09:36
*** e0ne has joined #openstack-release09:36
*** dtantsur|afk is now known as dtantsur09:39
*** tetsuro has joined #openstack-release09:40
*** tetsuro_ has quit IRC09:43
*** tetsuro has quit IRC09:56
openstackgerritMerged openstack/releases master: Release keystoneauth1 3.13.2 for stable/stein  https://review.opendev.org/71363610:05
openstackgerritMerged openstack/releases master: Oslo releases for 2020-03-18  https://review.opendev.org/71374910:06
*** hberaud has quit IRC11:19
*** dtantsur is now known as dtantsur|afk11:20
*** rpittau is now known as rpittau|bbl11:30
*** dave-mccowan has joined #openstack-release11:53
smcginnisttx: Well, at least it's more data. And one hypothesis proven wrong.11:57
openstackgerritMerged openstack/releases master: Release Glance 17.0.1  https://review.opendev.org/71377912:18
openstackgerritMerged openstack/releases master: Release glance_store 0.26.2  https://review.opendev.org/71378212:18
openstackgerritMerged openstack/releases master: Release python-glanceclient 2.13.2  https://review.opendev.org/71378312:18
*** udesale_ has joined #openstack-release12:19
*** udesale has quit IRC12:20
*** e0ne_ has joined #openstack-release12:20
*** e0ne has quit IRC12:21
ttxmy current hypothesis is that the extended query (o=DETAILED_LABELS) somehow times out and gerrit hides it by returning the data it successfully retrieved12:31
ttxhence my hope that using /detail instead would use a different code path12:32
*** hberaud has joined #openstack-release12:41
*** rpittau|bbl is now known as rpittau12:59
smcginnisWe should find out soon enough now.13:30
*** udesale_ has quit IRC14:00
openstackgerritRabi Mishra proposed openstack/releases master: Release tripleo-common 12.2.0  https://review.opendev.org/71389114:27
*** amoralej has joined #openstack-release14:47
amoralejhi can we consider rocky in EM already? my understanding was so but https://releases.openstack.org/ says Maintained14:48
amoralejsmcginnis, ^14:49
smcginnisamoralej: Projects are in the process of transitioning to EM. Only a few left. We can probably update that page now to reflect that Rocky is no longer Maintained.14:51
amoralejack, thx14:52
*** armstrong has joined #openstack-release14:57
*** ricolin has quit IRC15:08
*** ricolin has joined #openstack-release15:13
openstackgerritSean McGinnis proposed openstack/releases master: [glance] Transition Rocky to EM  https://review.opendev.org/70988815:22
evrardjpsorry I have been under fire the whole week :/15:58
evrardjpI will still attend the meeting if there is one today.15:58
smcginnisYep!15:59
smcginnis#startmeeting releaseteam16:00
openstackMeeting started Thu Mar 19 16:00:01 2020 UTC and is due to finish in 60 minutes.  The chair is smcginnis. Information about MeetBot at http://wiki.debian.org/MeetBot.16:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:00
*** openstack changes topic to " (Meeting topic: releaseteam)"16:00
openstackThe meeting name has been set to 'releaseteam'16:00
ttxo/16:00
smcginnisPing list: ttx armstrong diablo_rojo, diablo_rojo_phon16:00
hberaudo/16:00
evrardjpo/16:00
smcginnis#link https://etherpad.openstack.org/p/ussuri-relmgt-tracking Agenda16:00
elodo/16:00
smcginnisGood turnout.16:00
smcginnis#topic Outstanding rocky-em patches16:00
*** openstack changes topic to "Outstanding rocky-em patches (Meeting topic: releaseteam)"16:00
smcginnis#link https://review.opendev.org/#/q/status:open+project:openstack/releases+branch:master+topic:rocky-em EM Patches16:01
smcginnisGlance should be good to go now - https://review.opendev.org/70988816:01
smcginnisGreat if someone else can take a look and approve that.16:01
diablo_rojoo/16:01
smcginnisCloudkitty - https://review.opendev.org/#/c/709920/16:01
evrardjpI will have a look after the meeting.16:01
smcginnisNo response from PTL and it looks like there are unreleased commits.16:01
smcginnisSo... would be nice to get a release out for those, but also an indication that this may actually be unmaintained.16:02
smcginnisThoughts on that?16:02
evrardjpMaybe the new PTL didn't get the memo. Will ping in their channel16:02
*** chandankumar is now known as raukadah16:02
evrardjpthey changed PTL during the cycle16:02
smcginnisAh, OK. We can wait on that one a bit then.16:03
evrardjpI expect some quirks on comms16:03
smcginnisTelemetry - https://review.opendev.org/#/c/709880/16:03
smcginnisPTL approved, but unreleased commits.16:03
evrardjp:/16:03
smcginnisNo response to question regarding doing another release first.16:03
evrardjplet's go ahead then ?16:03
evrardjpI mean if it was approved by PTL....16:04
smcginnisYeah, kind of what I was thinking.16:04
smcginnisOther thoughts?16:04
evrardjplet's see if there are complaints later ;)16:04
evrardjphaha16:04
elodI think the same, if there are no answers then I guess those can be EM'd :/16:04
ttxnope go for it16:04
smcginnisAt least looking at ceilometer, a few fixes, but nothing critical.16:05
diablo_rojoI would hope that the PTL actually looked at the patches..16:06
smcginnisAnd of course, distros and end users can always apply unreleased commits if actually needed.16:06
elodexactly16:06
smcginnisIf someone could approve that telemetry one then...16:06
smcginnisOSA - https://review.opendev.org/#/c/709875/16:06
smcginnisThese cycle trailing ones wanted to wait until other projects had finished going to EM.16:07
smcginnisSo I think this one can wait a little more.16:07
evrardjpwe should define a limit16:07
evrardjphow long to wait ?16:07
ttxtelemetry one approved16:07
smcginnisNext week maybe? I think glance and telemetry are the only big ones that OSA would need to wait for?16:08
smcginnisHeat - https://review.opendev.org/#/c/709889/16:08
smcginnisricolin: There are some questions on the heat rocky em patch.16:08
smcginnisThat one at least needs the sha's updated.16:09
smcginnisValidation has since been added to make sure that doesn't pass anymore.16:09
smcginnisI guess go ahead and update that and transition if no response by next week? Any other ideas?16:10
smcginnisWe can go back to that one later.16:11
smcginnisTripleO - https://review.opendev.org/#/c/709912/16:11
diablo_rojoI think that is plenty of time that we've waited..16:11
smcginnisThat one actually looks it's OK, just never got a PTL response.16:12
smcginnisSo I think we can approve that.16:12
ttxok on it16:12
smcginnisLast one, Kolla - https://review.opendev.org/#/c/709893/16:12
smcginnisCommented on their that they wanted to wait for others to transition.16:13
smcginnisSo that one we can wait until glance and telemetry (and maybe Heat) make it through.16:13
smcginnisI can comment on their now to ask Mark to reassess their readiness.16:13
evrardjpsounds good16:14
smcginnisWell, some progress on those at least.16:14
smcginnisI will also put up a patch to reflect the stable phase on releases.o.o after the meeting.16:14
smcginnis#topic Outstanding ussuri-cwi patches16:14
*** openstack changes topic to "Outstanding ussuri-cwi patches (Meeting topic: releaseteam)"16:14
smcginnis#link https://review.opendev.org/#/q/status:open+project:openstack/releases+branch:master+topic:ussuri-cwi16:15
smcginnisTwo outstanding ones.16:15
smcginnisFreezer - https://review.opendev.org/#/c/709844/16:15
smcginnisThey have not done a release. A little confusing comment on there, but I think we are OK to go ahead and switch them to -rc.16:15
evrardjpIsn't freezer already in the freezer?16:15
smcginnisHah16:16
smcginnisNot sure on that projects state, but it has been iffy for awhile now I think.16:16
evrardjpI thought only SUSE was working on it recently, but I might be wrong, I have to double check. It might be worth checking if we shouldn't retire it instead.16:16
smcginnisSo probably safe enough to do. Unless it needs to be completely dropped for Ussuri.16:16
smcginnisAnyone know anything about its state?16:16
ttxon a call, brb16:16
hberaudnope...16:16
evrardjpthe safe bet would be to move it to cycle-with-rc and deprecate it next cycle16:17
smcginnisIs the TC still doing health checks?16:17
evrardjpbut that increase the lifespan16:17
evrardjpnot actively as we used to have16:17
diablo_rojosmcginnis, not really16:17
evrardjpwe are trying a different approach to see the healthiness of the project, using "golden signals"16:17
evrardjpbasically this is a signal :D16:18
diablo_rojoPTL is from ZTE16:18
evrardjpso I am thinking -- how should we interact on this16:18
diablo_rojoI think we move it to cycle with rc16:18
diablo_rojoand then we will see if they elect a PTL..16:18
smcginnisI think it's the release teams place to decide if it's part of the coordinated release or not. But TCs role to see if it should even exist anymore.16:19
diablo_rojoI would agree16:19
smcginnisI guess since we got at least some activity from the PTL (even if it was confusing) we can do the switch to rc, then see how things go.16:19
evrardjpagreed on both diablo_rojo and smcginnis comment16:19
smcginnisSo if someone wants to merge that patch, I think that's the right path at this point.16:19
evrardjpI just want to make sure the TC is aware of this :)16:19
smcginnisI suppose PTL election will be another "signal" on that.16:20
evrardjpcorrect.16:20
evrardjpat least that's my understanding. ttx can tell us more about the signals.16:20
smcginnisThe other one is similar - https://review.opendev.org/#/c/709845/16:20
smcginnisKarbor. Some comment, but kept thiss time, on that one.16:21
smcginnisBut no follow up release.16:21
smcginnisSo I think we go ahead with the switch. Otherwise drop since technically they have not met the inclusion criteria.16:21
evrardjpthe problem I have is that the more we wait, the more it will take to deprecate :) but I think it's too late to decide for this cycle, and let's not take harsh decisions lightly16:21
evrardjp(that's the tc hat speaking, sorry for that)16:21
diablo_rojo+2 Sounds good to me. We can only give so much time.16:22
evrardjpsmcginnis: agreed16:22
smcginnis"Projects must participate in at least two milestones in order to be considered part of the release."16:22
smcginnishttps://releases.openstack.org/ussuri/schedule.html#u-mf16:22
smcginnisWe do clearly state what is expected, and they have not met that expectation.16:22
evrardjpagreed16:22
smcginnisWould like ttx's input on this too. I don't think we've ever had to fully drop a whole project before.16:22
evrardjpit's never too late to start those kind of things.16:23
diablo_rojoReally? Never?16:23
diablo_rojoI'm surprised.16:23
evrardjpsmcginnis: just a question: are you afraid of the impact on the tooling for the release?16:23
smcginnisAt least since I've been involved. The threat of the stick has usually worked to get them to do a release.16:24
smcginnisevrardjp: No, I think we're fine.16:24
smcginnisI will propose dropping the files.16:24
smcginnisWe can get comments on the review for that.16:24
evrardjpyeah or release-management none16:24
evrardjpor whatever16:24
evrardjp:)16:24
smcginnisBut I wonder if maybe we should do the same for freezer.16:24
smcginnisSomething cycle based like this, I don't think we would want to say release-management none.16:24
evrardjpwe should probably drop an email on the ML16:25
evrardjpsmcginnis: I agree it was more: if there is a real urgency, maybe we can do something16:25
smcginnisWhat do folks think about including freezer along with karbor?16:25
evrardjpnot that governance is the fastest for merging things :p haha16:25
smcginnis;)16:25
evrardjphow long can this wait?16:26
diablo_rojosmcginnis, freezer had one release but karbor has had none right?16:26
smcginnisWe're already way past the deadline. Not sure we want to wait much longer in the cycle to communicate something like this.16:26
ttxback16:26
evrardjpok I guess we should go ahead then16:26
ttxcatching up16:26
smcginnisevrardjp: No, neither.16:26
smcginnisevrardjp: https://review.opendev.org/#/c/709844/1/deliverables/ussuri/freezer.yaml16:27
smcginnisttx: tldr; should we drop freezer and karbor from being included in the ussuri release since they have not done releases by the deadline.16:27
ttxtechnically we are past membership freeze, so what's in we are committed to release16:28
evrardjpI have the impression freezer is a repeating offender, but maybe it's my wrong impression16:28
evrardjpoh that's true too16:28
evrardjpso that's the solution16:28
smcginnisBut with no releases at all, just a placeholder file, are those actually "in"?16:28
ttxsmcginnis: the idea behind membership freeze was to communicate early what will be in release16:29
ttxfor packagers and all16:29
ttxnot sure who actually pays attention, but I like the concept16:29
smcginnisTrue16:29
evrardjpsmcginnis: technically -- why not? assuming the project is very stable it might not require new patches and new releases, but be part of the coordinated release16:29
openstackgerritMerged openstack/releases master: [Telemetry] Transition Rocky to EM  https://review.opendev.org/70988016:29
smcginnisOK, then just force both of these to -rc, even though at least one the PTL has said no.16:30
openstackgerritElod Illes proposed openstack/releases master: Set Rocky status to Extended Maintenance  https://review.opendev.org/71392616:30
evrardjpttx: I have doubts about the usefulness, but that's a conversation for another time :p16:30
ttxsmcginnis: yes... that or proposing an intermediary release immediately16:30
smcginnisI'm concerned about the lack of visibility into zombie projects that we just end up taking care of.16:30
ttxI would switch karbor, and propose a release for freezer on HEAD16:30
smcginnisWe did add the "forced" flag awhile back.16:30
smcginnisMaybe we should think about doing that as a way to track the ones that do not get any response from the teams.16:31
ttxFeels like a ML thread about it could trigger some attention16:31
ttxone for each16:31
smcginnisttx: I'm concerned that we asked them to get an intermediary release out to stay cwi, then no response at all.16:31
ttxthat way we (1) track it and (2) use the shame16:31
evrardjpwould you mind tackling this? :)16:31
evrardjpI am afraid of my wording.16:32
ttxsmcginnis: then we force-approve it16:32
evrardjpI agree with ttx plan. currently I have voted on those, and if they propose a patch, I can vote again.16:32
smcginnisOK, switch karbor and force freezer. That works for me.16:33
ttxthen I'll create a thread for each16:33
smcginnisttx: Thanks for taking that.16:33
smcginnisI can get the release proposed.16:33
ttxmind you, the thread might conclude membership freeze should not prevent us from removing stuff at the last minute16:33
smcginnisI like that too.16:33
ttxhmm16:34
smcginnisOh good, the additional validations caught something with the tripleo patch. I'll get that fixed up too.16:34
ttxI'm confused16:34
evrardjpttx: ?16:35
ttxso freezer is the one where jiaopengju said "please ignore this comment."16:35
ttxbasically not -1 it16:35
ttxso that would be the one we'd swtch to -rc16:35
* hberaud need to eject, sorry, see you tomorrow16:36
ttxkarbor is the one with a standing -116:36
ttxso the one for which we should propose a release16:36
smcginnisYep. I think that's waht we said, release karbor, transition freezer.16:36
ttxok, you had said OK, switch karbor and force freezer16:37
smcginnisOh, nope, I stated that backwards earlier.16:37
smcginnisSorry.16:37
ttxas  long as we are on the same boat16:37
smcginnisDo what I meant, not what I said. :)16:37
evrardjpoh interesting the three of us understood it correctly, but the words were wrong :)16:37
smcginnisttx: As long as it's not a cruise ship.16:37
evrardjpsmcginnis: hahaha16:37
evrardjp #nevertoosoon16:37
smcginnis #alwaystoosoon16:38
smcginnisOK, I think that horse is well beaten.16:38
diablo_rojo#neveracruiseship16:38
smcginnisHah~16:38
smcginnis#topic Validate countdown email16:38
*** openstack changes topic to "Validate countdown email (Meeting topic: releaseteam)"16:38
smcginnis#link https://etherpad.openstack.org/p/relmgmt-weekly-emails16:38
smcginnisLine 21016:39
smcginnisdiablo_rojo: Should we expand on the cycle highlights in there to point out appropriate content for that?16:41
smcginnisWe at least have the links.16:41
diablo_rojosmcginnis, I was just debating that.16:41
smcginnisI added one line to address a common confusion at least.16:42
diablo_rojoI think there is enough detail there since you are linking to the email etc.16:42
diablo_rojoYeah that is a good addition16:42
diablo_rojoMaybe add it to the dates list at the bottom16:42
smcginnisWhat is the deadline for these?16:42
smcginnisOK, perfect.16:43
smcginnisThanks ttx as always for getting these prepped.16:43
smcginnisI will send out tomorrow, my morning.16:43
diablo_rojoOh interesting16:44
diablo_rojoWe dont have the deadline on the release schedule for ussuri16:44
diablo_rojoI will get that patch out today16:44
smcginnisCan't hurt.16:44
smcginnis#topic Unmaintained for older branches16:44
*** openstack changes topic to "Unmaintained for older branches (Meeting topic: releaseteam)"16:44
smcginnisJust wanted to check with the team.16:44
smcginnisWe have some really older stable branches.16:44
smcginnisWith some things being still "maintained" and some not.16:45
smcginnisIt was never really clear to me what the signal would be to know if and when something would transition to unmaintained.16:45
smcginnisOther than the team expressing declaring it.16:45
smcginnisBut I'm fairly sure not a lot of teams are still paying much attention to Ocata.16:46
elodif the branch of a project does not get patches about ~6 months. maybe?16:46
smcginnisI guess that's one sign.16:46
smcginnisOr proposed patches that are not getting merged.16:46
ttxyeah I like objective signs16:46
smcginnisOr broken CI.16:46
ttxsince if we ask around there will always be someone saving it16:47
elodyes, those, too16:47
smcginnisSecondary question, do we need to wait for all teams before we show these as unmaintained on releases.o.o?16:47
fungii suppose "broken ci" is only a signal if it's broken for a while and nobody is fixing it16:48
fungithat may be hard to gauge in a simple spot-check16:48
smcginnisDo we run stable periodic jobs on ocata yet?16:48
evrardjpfungi: I am afraid of a move to a pseudo noop job to make things green16:48
smcginnisYeah, I've seen some of that.16:48
elodyes, there are periodic jobs still against ocata16:48
smcginniselod: OK, great.16:48
fungiplenty of stable branch jobs are perpetually broken because nobody looks at them, but they're also usually not the same jobs being run against proposed changes16:49
elodand there are some constantly failing :)16:49
smcginnisIt does seem like there's a usual set of failures every day. I haven't been paying attention to which branches those were coming from.16:49
fungialso one of the options spelled out in the extended maintenance section of the stable branch chapter in the project teams guide is to drop broken ci jobs16:49
smcginnisSo I guess as far as this team is concerned, we just leave these as Unmaintained until we are told otherwise?16:50
fungibecause the extended maintenance proponents felt having an untested (or nominally tested) branch still receiving patches was better than straight eol16:50
elodheat, nova-powervm and nowadays octavia are failing in ocata16:51
johnsomOcata is long EOL for Octavia.....16:51
smcginnisOK, not something this team needs to solve today. Just wanted to raise it to get folks thinking.16:52
smcginnisjohnsom: Was that announced on the mailing list?16:52
smcginnisBut makes me think, we need some central place to track that too.16:52
johnsomYeah, I would have to dig way back in the way-back machine16:52
elodhmmm. then i guess the jobs should be dropped in such cases16:52
smcginnisjohnsom: Doesn't look like it every got an ocata-eol tag proposed.16:53
johnsomPike was the first 1.0 release, so we announced that it was as far back as we go16:53
smcginnisThat would reflect that state on the site.16:53
fungimaybe we're missing a clear process for removing periodic jobs when branches transition to unmaintained16:53
smcginnisWe should document what needs to be done. Do the -eol tagging, remove periodic stable jobs, etc.16:53
johnsomWe were just having a conversation about this on our channel. It's really not clear how individual teams can EOL or "declare" Unmaintained. beyond the e-mail list which gets lost to history.16:54
fungithe "new" extended maintenance process got rid of the eol tags, i thought16:54
smcginnisIIRC, part of the process was a team had to announce it and wait 6 months in case someone else came along and volunteered to maintain the older branch than the official team would.16:54
fungior maybe it only got rid of deleting eol branches16:54
smcginnisfungi: It didn't get rid of branches being EOL though. Just how it got to that phase.16:54
johnsomRight, there was talk that the new process would no longer remove the branches like the old EOL did16:55
smcginnisYeah, maybe the deletion. That sounds right.16:55
elodI can prepare something to the stable-branch page and we can refine there the general TODOs, is that OK?16:55
smcginniselod: That would be great!16:55
fungiahh, rereading there is an eol phase, which comes 6 months after unmaintained16:55
fungihttps://docs.openstack.org/project-team-guide/stable-branches.html#end-of-life16:55
smcginnisIt's that process of getting between maintained and eol that isn't as clear as I would like.16:55
fungicurrent process does still tag and delete branches at eol time16:55
smcginnisAnyway, not something we need to solve in this meeting. I'm going to move on to our last agenda topic.16:56
smcginnis#topic16:56
*** openstack changes topic to " (Meeting topic: releaseteam)"16:56
johnsomFrankly, we are talking about EOL up to Rocky.16:56
smcginnis#topic Check-release-approval false negatives16:56
evrardjpthat's quite the topic16:56
*** openstack changes topic to "Check-release-approval false negatives (Meeting topic: releaseteam)"16:56
smcginnisjohnsom: I think that makes sense.16:56
ttxyeah so the latest change did not really fix anything16:56
smcginnis#link http://zuul.openstack.org/build/d385f0d89418420baaf4b8a1d05d345f16:56
fungilooks like the transition from unmaintained to eol is pretty clear, it's the transition from extended maintenance to unmaintained which is muddy16:56
ttxwe already have a false negative16:56
smcginnisLooks like the same symptoms.16:56
smcginnisSo something we need help on the gerrit side to figure out.16:56
ttxCurrently picking it apart to check if anything else is missing16:57
fungiooh, i like this game. i'll play too16:57
ttxThe code does not seem to have crazy code paths that would explain this behavior16:57
ttxIt's not limited to a specific executor16:57
smcginnisReally seems like it would have to be a bug in gerrit.16:58
ttxsmcginnis: yeah, one which I can't reproduce locally16:58
ttxI ran a lot of tests and never hit it16:58
smcginnisfungi: Do you know if there are any debug logs on the gerrit side that could help?16:58
ttxWhile it seems to be between 5% and 20% hit rate in zuul16:58
fungigerrit's only useful logging is for the ssh api, really16:59
ttxinteresting...16:59
smcginnisttx: And that's not an option from the executor?16:59
ttx  "permitted_labels": {}17:00
ttxThe failed JSON has ^17:00
ttxSuccessful JSON has the data in that array17:00
smcginnisWe're over time, so I'm going to end the meeting. But we should keep on this.17:01
smcginnis#endmeeting17:01
*** openstack changes topic to "OpenStack Release Managers office - Come here to discuss how to release OpenStack components - Logged at http://eavesdrop.openstack.org/irclogs/%23openstack-release/"17:01
openstackMeeting ended Thu Mar 19 17:01:46 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)17:01
openstackMinutes:        http://eavesdrop.openstack.org/meetings/releaseteam/2020/releaseteam.2020-03-19-16.00.html17:01
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/releaseteam/2020/releaseteam.2020-03-19-16.00.txt17:01
openstackLog:            http://eavesdrop.openstack.org/meetings/releaseteam/2020/releaseteam.2020-03-19-16.00.log.html17:01
fungimy ipv6 route is busted so i'm having trouble pulling current state of the releases repo to make sure the liaison e-mail address matches what gerrit's using for that account17:02
ttxfungi: what's the easiest way to access the code that is actually running on our gerrit?17:02
fungiwill be a few minutes17:02
fungittx: as in the source code for the gerrit service?17:03
diablo_rojosmcginnis, thank you!17:03
ttxI'd like to dig into what could make "permitted_labels" empty17:03
ttxfungi: yes...17:03
evrardjpthanks smcginnis and others !17:03
fungias of tomorrow the answer will be download our gerrit docker image17:03
fungiyou picked an interesting day to ask ;)17:03
clarkbttx: opendev/gerrit on openstack/2.13 branch iirc17:03
ttxok17:03
fungiyeah, technically that will get you the gerrit we'll be running on review.opendev.org tomorrow17:04
fungibut for your purposes that's probably sufficient17:04
ttxyeah, I want to track down what fills permitted_labels17:05
fungii've confirmed the cause isn't anything as simple as an e-mail address mismatch17:05
ttxbecause i can see how that would affect how "labels" gets filled17:05
smcginnisfungi: The interesting thing is the same account can comment twice, and the first time if fails, the second time it works correctly.17:05
fungithe preferred_email field in gerrit for that account matches the email entry for tripleo in data/release_liaisons.yaml17:05
fungiyeah, sounds like this could be zuul missing gerrit events?17:07
fungihttps://zuul.openstack.org/builds?job_name=check-release-approval&project=openstack%2Freleases&change=71389117:07
ttxfungi: how so?17:08
ttxWe correctly make a Gerrit query and that query returns imcomplete data17:09
ttxThat's totally a Gerrit bug17:09
ttxNot  a missed event17:09
fungithat build corresponds with when rabi uploaded the change, the build timestamp is prior to alex's comment17:09
fungiunless i'm misunderstanding the problem17:10
ttxI'll restate the problem :)17:10
fungigerrit says alex left a +1 at 14:29z17:10
ttxThe script makes a query asking for detailed label information (o=DETAILED_LABELS, or more recently /detail)17:11
ttxand gerrit answers with erroneous information that does not match its JSON answer format17:11
ttxIf you run it again, it will answer correctly17:11
openstackgerritJavier Peña proposed openstack/releases master: Release python-keystoneclient 3.19.1 for stable/stein  https://review.opendev.org/71393817:11
ttxhttp://zuul.openstack.org/build/d385f0d89418420baaf4b8a1d05d345f/console shows the partial JSON response17:11
ttxIn particular, missing labels['Code-Review']['all']17:12
ttxbut also missing other labels[*]['all']17:12
ttxand permitted_labels17:12
fungigerrit will omit empty fields17:13
fungifor some fields17:13
ttxin that case it does reply   "permitted_labels": {}17:13
ttxhttp://paste.ubuntu.com/p/v8GrT3qFWD/ shows the complete answer17:14
ttxhttp://zuul.openstack.org/build/d385f0d89418420baaf4b8a1d05d345f/console shows the one we got17:14
ttxThe only difference I could spot is in the structure of "labels" and the fact that permitted_labels is empty17:15
ttxI suspect those are related. Gerrit thinks tehre is no permitted label and switches the label data to a simpler content17:16
ttxmore specifically, missing labels[*]['all'] and labels[*]['recommended']17:16
ttx(while still providing labels[*]['values'] and labels[*]['default_value']17:18
fungithough that task occurred at 14:29:36 which is prior to the 14:29:43 Code-Review +1 from alex17:18
fungiso i'm confused as to what it's trying to check there17:18
openstackgerritKendall Nelson proposed openstack/releases master: Add Cycle Highlights to U Release Schedule  https://review.opendev.org/71394017:18
ttxfungi: the originasl patchset sunmission17:18
fungiat the time that task ran, there were no labels with votes17:19
ttxfungi: if the patch is provided by PTL, it's PTL-approved17:19
ttxah....17:19
ttxI see what you mean17:19
* ttx thinks17:19
fungiso the job may need to treat missing labels as an indicator to look at the change owner id17:20
ttxso 'all' would be skipped17:20
ttxin case there is no single review yet17:20
fungiunless i completely misunderstand how it's implemented17:20
ttxstill weird that permitted_labels would be empty17:20
ttxbut let me check17:20
fungiwouldn't be the weirdest thing i've seen in gerrit's api ;)17:21
fungialso may entirely change when we upgrade17:21
fungi(though no eta on that, we need to switch to our containerized deployment tomorrow and then look at upgrade timelines)17:21
ttxha17:21
ttxYeah, we load the list of approvers from ['labels']['Code-Review']['all'] then add ['owner']['email']17:22
ttxLet me see if all recent issues match that scenario17:22
*** mlavalle has joined #openstack-release17:23
ttxyep, that could explain it17:24
openstackgerritSean McGinnis proposed openstack/releases master: [tripleo] Transition Rocky to EM  https://review.opendev.org/70991217:24
openstackgerritSean McGinnis proposed openstack/releases master: Create stable/rocky branch for tripleo-ipsec  https://review.opendev.org/71394117:24
ttxwill post fix tomorrow17:25
ttxfungi: thanks for your analysis! I did not take into account the fact that Gerrit would answer different formats17:26
ttxStill don't get why it would answer "permitted_labels: {}"17:27
ttxbut will happily ignore that if my fix fixes the issue17:27
openstackgerritSean McGinnis proposed openstack/releases master: Release freezer ussuri deliverables  https://review.opendev.org/71394217:31
smcginnisDoh, got it backwards again!!17:33
openstackgerritSean McGinnis proposed openstack/releases master: Release karbor ussuri deliverables  https://review.opendev.org/71394617:35
*** evrardjp has quit IRC17:36
*** evrardjp has joined #openstack-release17:36
openstackgerritMerged openstack/releases master: Switch freezer to cycle-with-rc  https://review.opendev.org/70984417:48
openstackgerritColleen Murphy proposed openstack/releases master: Release keystonemiddleware 6.0.1  https://review.opendev.org/71395418:05
*** rpittau is now known as rpittau|afk18:06
*** armstrong has quit IRC19:06
*** mlavalle has quit IRC19:49
*** mlavalle has joined #openstack-release19:58
*** e0ne_ has quit IRC21:04
*** e0ne has joined #openstack-release21:08
*** e0ne has quit IRC21:22
openstackgerritMerged openstack/releases master: Release tripleo-common 12.2.0  https://review.opendev.org/71389121:39
openstackgerritMerged openstack/releases master: Create stable/rocky branch for tripleo-ipsec  https://review.opendev.org/71394121:39
openstackgerritMerged openstack/releases master: [glance] Transition Rocky to EM  https://review.opendev.org/70988821:39
*** dhellmann_ has joined #openstack-release21:53
*** dhellmann has quit IRC21:54
*** dhellmann_ is now known as dhellmann21:54
openstackgerritMerged openstack/releases master: [tripleo] Transition Rocky to EM  https://review.opendev.org/70991222:20
*** zigo has quit IRC22:22
*** zigo has joined #openstack-release22:32
*** slaweq has quit IRC22:45
*** jbadiapa has quit IRC22:50

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!