| opendevreview | Dr. Jens Harbott proposed openstack/releases master: Create stable/2024.1 for requirements https://review.opendev.org/c/openstack/releases/+/913972 | 14:50 |
|---|---|---|
| frickler | elodilles: I'm wondering where those random reformattings like in https://review.opendev.org/c/openstack/releases/+/913973/1/deliverables/caracal/manila.yaml do come from. they don't actually look line length related | 15:58 |
| frickler | in a smaller patch I'd ask to revert those to avoid unrelated changes, but it might be a bit tough in this case | 16:00 |
| frickler | also do you want to wait for more ptl feedback or can we move on with it? | 16:01 |
| opendevreview | Merged openstack/releases master: Create stable/2024.1 for devstack https://review.opendev.org/c/openstack/releases/+/913969 | 16:07 |
| opendevreview | Merged openstack/releases master: Create stable/2024.1 for grenade https://review.opendev.org/c/openstack/releases/+/913970 | 16:08 |
| elodilles | frickler: those are due to the yaml module we use in releases repository | 16:13 |
| elodilles | frickler: https://pypi.org/project/ruamel.yaml | 16:14 |
| elodilles | frickler: https://review.opendev.org/c/openstack/releases/+/669717 | 16:14 |
| elodilles | so those length related reformattings are not bad imo. which is it a bit painful is the long link related line wrapping fix that landed ~a year ago. it causes us to have an empty space at the end of the line above the long link. (like the 'releases: ' above long reno link lines) | 16:18 |
| elodilles | frickler: oh, and about the patch: it's good if PTLs are reviewing it, though it's not necessary to wait more. also, it's not fortunate to respin the patch as it will spam *everyone* o:) | 16:38 |
| elodilles | frickler: so feel free to approve it | 16:39 |
| frickler | yes, losing all of those acks was one of my concerns beside the work involved. will +3 | 16:39 |
| elodilles | thanks o/ | 16:39 |
| elodilles | also, note, that once ruamel reformatted(wrapped) the cycle highlights, it won't do that again (fingers crossed) | 16:40 |
| elodilles | the original intention about using ruamel was that it keeps the yamls as close to its original state as possible | 16:42 |
| frickler | maybe we should add that as a linter step, so highlights are consistenly formatted from the start | 16:42 |
| elodilles | maybe we should fix it somehow... i can think of 2 ways: 1) set line length to longer lines; 2) add some script to reformat the yaml so that people can run it before uploading (i hate to say this, but probably a precommit hook would be fine for this :X) | 16:44 |
| frickler | also I really don't know what to think about the commentless new PTL +1 on https://review.opendev.org/c/openstack/releases/+/910425 | 16:44 |
| frickler | I really don't like precommit hooks, but in this case I could probably agree | 16:45 |
| elodilles | yeah, sorry, i didn't go through the remaining transition patches yet :/ | 16:46 |
| opendevreview | Elod Illes proposed openstack/releases master: [keystone] Transition EM branches to Unmaintained https://review.opendev.org/c/openstack/releases/+/910411 | 16:52 |
| opendevreview | Merged openstack/releases master: Add release note links for 2024.1 Caracal https://review.opendev.org/c/openstack/releases/+/913973 | 16:57 |
| opendevreview | Merged openstack/releases master: Amend Tacker releae highlights with SRBAC work https://review.opendev.org/c/openstack/releases/+/913947 | 18:30 |
| opendevreview | Elod Illes proposed openstack/releases master: [keystone] Transition EM branches to Unmaintained https://review.opendev.org/c/openstack/releases/+/910411 | 18:41 |
| opendevreview | Merged openstack/releases master: Create stable/2024.1 for requirements https://review.opendev.org/c/openstack/releases/+/913972 | 18:51 |
| noonedeadpunk | huh, should such merge trigger some post pipeline to create the branch? ^ | 18:58 |
| opendevreview | Ghanshyam proposed openstack/releases master: [telemetry-tempest-plugin] Tag yoga-last https://review.opendev.org/c/openstack/releases/+/908365 | 18:58 |
| noonedeadpunk | hm, ok, I either missed it or there's some magic involved | 18:59 |
| elodilles | noonedeadpunk: there is a post-release pipeline, where the job that creates the branches and such runs shortly after merging the patch | 19:10 |
| frickler | the branch is in place and the bot generated patches are there https://review.opendev.org/c/openstack/requirements/+/914150 | 19:23 |
| frickler | this is the job that created the branch https://zuul.opendev.org/t/openstack/build/7380e8fa78e54fa3ba3a3cb01e7d1974 | 19:26 |
| noonedeadpunk | ah, it's likely just not attached to the change? | 19:35 |
| noonedeadpunk | as I tried to filter by change id :) | 19:35 |
| noonedeadpunk | and I see it's linked to revision instead | 19:36 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!