| smcginnis[m] | Awesome | 00:01 |
|---|---|---|
| tonyb | smcginnis[m]: and now I have cascading failures :( | 00:03 |
| tonyb | sphinx dosn't have the most helpful error messages | 00:03 |
| smcginnis[m] | Bleh | 00:04 |
| tonyb | And I'm out of time | 00:17 |
| tonyb | lbragstad: So the bottom line is that the keystone docs will fail to build with -W until the oauthlib docs do also | 00:18 |
| tonyb | lbragstad: http://paste.openstack.org/show/724271/ is a start but it isn't complete | 00:18 |
| tonyb | lbragstad: the good news is grabbing the oauthlib code and tox -edocs will fail if you add -W so it's kinda of a follow the bouncing ball to get there | 00:19 |
| tonyb | lbragstad: so perhaps you can disable -W to unblock your gate and then fix oauthlib | 00:19 |
| tonyb | lbragstad: sorry I don't have better news :/ | 00:20 |
| *** edmondsw has quit IRC | 00:37 | |
| *** hongbin has joined #openstack-requirements | 01:21 | |
| *** mordred has quit IRC | 01:49 | |
| *** mordred has joined #openstack-requirements | 02:07 | |
| lbragstad | tonyb: thanks for digging into that, i appreciate it! | 03:10 |
| tonyb | lbragstad: you're welcome. Sorry I don't have time to do more :/ | 03:11 |
| lbragstad | tonyb: not a problem at all, it's not your problem to fix :) | 03:11 |
| lbragstad | tonyb: you don't happy to know if there is something upstream tracking this against oauth? | 03:12 |
| lbragstad | oauthlib/oauthlib that is | 03:12 |
| tonyb | lbragstad: I didn't see anything in the github issues | 03:14 |
| tonyb | lbragstad: the docs build as the don't enable -W and noone has noticed that the API docs are eitehr unused io incomplete | 03:15 |
| tonyb | lbragstad: I s'pose asking for help might be a good first step ;P | 03:15 |
| lbragstad | yeah - good point | 03:16 |
| tonyb | lbragstad: :) | 03:17 |
| *** hongbin has quit IRC | 03:54 | |
| openstackgerrit | Vu Cong Tuan proposed openstack/requirements master: Add py36 testenv https://review.openstack.org/577688 | 04:02 |
| *** dims has quit IRC | 04:30 | |
| *** dims has joined #openstack-requirements | 04:35 | |
| *** ccamacho has quit IRC | 05:06 | |
| *** CrayZee has joined #openstack-requirements | 05:07 | |
| *** strigazi has quit IRC | 05:17 | |
| *** strigazi has joined #openstack-requirements | 05:19 | |
| *** strigazi_ has joined #openstack-requirements | 05:24 | |
| *** strigazi has quit IRC | 05:27 | |
| *** udesale has joined #openstack-requirements | 05:44 | |
| *** snapiri- has joined #openstack-requirements | 05:53 | |
| *** CrayZee has quit IRC | 05:56 | |
| *** openstackgerrit has quit IRC | 06:04 | |
| *** ccamacho has joined #openstack-requirements | 06:09 | |
| *** openstackgerrit has joined #openstack-requirements | 06:23 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/requirements master: Updated from generate-constraints https://review.openstack.org/577997 | 06:23 |
| *** andreas_s has joined #openstack-requirements | 06:33 | |
| *** florianf has joined #openstack-requirements | 07:24 | |
| *** florianf has quit IRC | 07:25 | |
| *** andreas_s has quit IRC | 07:25 | |
| *** andreas_s has joined #openstack-requirements | 07:26 | |
| *** amoralej|off is now known as amoralej | 07:28 | |
| *** andreas_s_ has joined #openstack-requirements | 07:28 | |
| *** andreas_s has quit IRC | 07:32 | |
| *** andreas_s_ has quit IRC | 07:38 | |
| *** andreas_s has joined #openstack-requirements | 07:39 | |
| *** andreas_s has quit IRC | 07:39 | |
| *** andreas_s_ has joined #openstack-requirements | 07:40 | |
| *** tosky has joined #openstack-requirements | 07:41 | |
| openstackgerrit | Matthew Thode proposed openstack/requirements master: Updated from generate-constraints https://review.openstack.org/577997 | 07:51 |
| *** andreas_s_ has quit IRC | 07:59 | |
| *** andreas_s has joined #openstack-requirements | 08:00 | |
| *** andreas_s has joined #openstack-requirements | 08:01 | |
| *** jpich has joined #openstack-requirements | 08:05 | |
| *** dtantsur|afk is now known as dtantsur | 09:18 | |
| *** strigazi_ is now known as strigazi | 09:47 | |
| *** andreas_s has quit IRC | 11:00 | |
| *** andreas_s has joined #openstack-requirements | 11:00 | |
| *** andreas_s has joined #openstack-requirements | 11:01 | |
| *** andreas_s has quit IRC | 11:02 | |
| *** andreas_s has joined #openstack-requirements | 11:02 | |
| *** andreas_s has quit IRC | 11:03 | |
| *** andreas_s has joined #openstack-requirements | 11:17 | |
| *** andreas_s has quit IRC | 11:26 | |
| *** udesale has quit IRC | 11:33 | |
| *** andreas_s has joined #openstack-requirements | 11:35 | |
| *** andreas_s has quit IRC | 11:44 | |
| *** andreas_s has joined #openstack-requirements | 11:48 | |
| *** amoralej is now known as amoralej|lunch | 11:59 | |
| dhellmann | tonyb , smcginnis , lbragstad : why are docstrings in oauthlib breaking the build for keystone? | 12:36 |
| *** andreas_s has quit IRC | 12:48 | |
| *** andreas_s has joined #openstack-requirements | 12:50 | |
| *** andreas_s has quit IRC | 12:57 | |
| *** edmondsw has joined #openstack-requirements | 12:58 | |
| *** andreas_s has joined #openstack-requirements | 12:59 | |
| *** r-mibu has joined #openstack-requirements | 13:01 | |
| dhellmann | tonyb , prometheanfire , dirk : http://lists.openstack.org/pipermail/openstack-dev/2018-June/131824.html | 13:03 |
| openstackgerrit | Michal Arbet proposed openstack/requirements master: Update constraint for networkx to new release 2.1 https://review.openstack.org/578094 | 13:12 |
| openstackgerrit | Michal Arbet proposed openstack/requirements master: Update constraint for networkx to new release 2.1 https://review.openstack.org/578094 | 13:13 |
| openstackgerrit | Michal Arbet proposed openstack/requirements master: Update constraint for networkx to new release 2.1 https://review.openstack.org/578094 | 13:21 |
| *** dtantsur is now known as dtantsur|brb | 13:22 | |
| *** vpickard_ is now known as vpickard | 13:30 | |
| *** udesale has joined #openstack-requirements | 13:31 | |
| *** snapiri- has quit IRC | 13:41 | |
| lbragstad | dhellmann: apparently it's transitive? | 13:48 |
| dhellmann | lbragstad : including the text of docstrings shouldn't be, though, right? is something doing that explicitly? | 13:49 |
| dhellmann | lbragstad : is keystone subclassing something from that library? | 13:51 |
| lbragstad | dhellmann: https://git.openstack.org/cgit/openstack/keystone/tree/keystone/oauth1/validator.py | 13:52 |
| dhellmann | ok | 13:52 |
| dhellmann | yeah, it didn't occur to me that you'd be subclassing and that would cause the problem | 13:52 |
| dhellmann | you could always override the docstring for the method from within your subclass | 13:52 |
| dhellmann | kinda icky, but that would let you keep -W enabled | 13:53 |
| lbragstad | oh - good call | 13:53 |
| dhellmann | I think you can do MyClass.method.__doc__ = '' for example | 13:53 |
| dhellmann | so you don't even need to override the method | 13:53 |
| kmalloc | Yeah that might be good. | 13:54 |
| lbragstad | if the impact is isolated to that specific area - i wouldn't be opposed to just doing that | 13:54 |
| dhellmann | sure, the question is how many of these methods do you have to do that for | 13:54 |
| kmalloc | I am inclined to decorate the classes in question and it just clips the docstring for all methods in the class. | 13:54 |
| kmalloc | For subclassing that is. | 13:55 |
| dhellmann | sure | 13:55 |
| kmalloc | Or similar. | 13:55 |
| kmalloc | I do dislike losing the docstrings though (but to be fair I am not sure it is that useful for subclassing) | 13:56 |
| lbragstad | we're just implementing the interface | 13:57 |
| dhellmann | you would only have to strip them for as long as it takes to get a version of oauth that has well-formatted docstrings, right? | 13:57 |
| kmalloc | Right... Which may be forever | 13:57 |
| dhellmann | so much optimism! :-) | 13:58 |
| kmalloc | Some of these libs are very slow moving | 13:58 |
| lbragstad | i did reach out to them | 13:58 |
| *** amoralej|lunch is now known as amoralej | 13:58 | |
| kmalloc | Oauth isn't as bad as some | 13:58 |
| lbragstad | and asked if they would be interested in addressing those change | 13:58 |
| kmalloc | But it def doesn't move fast. | 13:58 |
| lbragstad | they seem receptive to the idea | 13:59 |
| dhellmann | I'm guessing they're not using sphinx to generate docs? or not with -W enabled in any case | 13:59 |
| kmalloc | Yeah. | 13:59 |
| kmalloc | lbragstad: silly question... Can we just not subclass this? | 13:59 |
| kmalloc | Do something like we do on the managers, and just forward to an underlying obkect? | 14:00 |
| kmalloc | Object* | 14:00 |
| kmalloc | Because it is one lib/class, right? | 14:01 |
| *** rpioso|afk is now known as rpioso | 14:04 | |
| *** cjloader has joined #openstack-requirements | 14:05 | |
| lbragstad | https://github.com/oauthlib/oauthlib/issues/558 | 14:06 |
| openstackgerrit | Dirk Mueller proposed openstack/requirements master: WIP: Add cross testing for py36 https://review.openstack.org/554824 | 14:09 |
| *** ccamacho has quit IRC | 14:35 | |
| *** ccamacho has joined #openstack-requirements | 14:35 | |
| prometheanfire | dhellmann: your plan sounds good, the question I was going to ask was answered (do deps changs) | 14:39 |
| dhellmann | prometheanfire : ack, thanks | 14:43 |
| *** dtantsur|brb is now known as dtantsur | 14:45 | |
| prometheanfire | dhellmann: maybe we should enshrine that docs are special | 14:46 |
| dhellmann | yeah, I would like us to be less concerned with testing and syncing doc requirements | 14:46 |
| dhellmann | now that we have the ability to list those outside of test-requirements.txt it's easier | 14:46 |
| prometheanfire | true | 14:47 |
| lbragstad | dhellmann: prometheanfire tonyb kmalloc alternative approach to removing -W https://review.openstack.org/#/c/578121/ | 14:55 |
| dhellmann | I like that better than removing the -W | 14:56 |
| lbragstad | me too | 14:58 |
| lbragstad | especially since it's only two comments | 14:58 |
| *** cjloader_ has joined #openstack-requirements | 14:59 | |
| *** cjloader has quit IRC | 14:59 | |
| prometheanfire | lbragstad: looks like a working workaround :P | 14:59 |
| prometheanfire | lbragstad: and it has a fixme, so lgtm | 15:00 |
| prometheanfire | is upstream slow? | 15:00 |
| lbragstad | i'm not sure | 15:00 |
| lbragstad | this is the first time i've interfaced with that community (stevemar originally implemented support for oauth) | 15:01 |
| lbragstad | but even then i'm not sure how much we worked with them | 15:01 |
| *** vpickard has quit IRC | 15:11 | |
| openstackgerrit | Michal Arbet proposed openstack/requirements master: Update constraint for networkx to new release 2.1 https://review.openstack.org/578094 | 15:13 |
| *** vpickard has joined #openstack-requirements | 15:14 | |
| prometheanfire | dhellmann: I want to know who this is so I can get them beer ^ | 15:14 |
| prometheanfire | https://review.openstack.org/#/c/577833/ | 15:14 |
| *** ccamacho has quit IRC | 15:15 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/requirements master: update constraint for python-zunclient to new release 2.0.0 https://review.openstack.org/578132 | 15:17 |
| dhellmann | prometheanfire : they did some work in taskflow, too, I think | 15:19 |
| prometheanfire | yep, that's the link | 15:21 |
| *** andreas_s has quit IRC | 15:32 | |
| *** cjloader_ has quit IRC | 15:45 | |
| *** cjloader has joined #openstack-requirements | 15:46 | |
| *** cjloader has quit IRC | 15:48 | |
| *** cjloader has joined #openstack-requirements | 15:48 | |
| *** cjloader has quit IRC | 15:48 | |
| *** cjloader has joined #openstack-requirements | 15:49 | |
| openstackgerrit | Michal Arbet proposed openstack/requirements master: Update constraints for networkx to new release 2.1 https://review.openstack.org/578094 | 15:56 |
| *** udesale has quit IRC | 16:09 | |
| *** r-mibu has quit IRC | 16:14 | |
| openstackgerrit | Merged openstack/requirements master: Updated from generate-constraints https://review.openstack.org/577997 | 16:19 |
| *** jpich has quit IRC | 16:28 | |
| *** CrayZee has joined #openstack-requirements | 16:49 | |
| *** CrayZee has quit IRC | 16:51 | |
| *** dtantsur is now known as dtantsur|afk | 17:15 | |
| *** andreas_s has joined #openstack-requirements | 17:48 | |
| *** andreas_s has quit IRC | 17:53 | |
| *** cjloader_ has joined #openstack-requirements | 17:54 | |
| *** cjloader has quit IRC | 17:54 | |
| *** cjloader_ has quit IRC | 17:54 | |
| *** cjloader has joined #openstack-requirements | 17:54 | |
| *** amoralej is now known as amoralej|off | 17:56 | |
| *** cjloader has quit IRC | 18:01 | |
| *** cjloader has joined #openstack-requirements | 18:05 | |
| *** cjloader has quit IRC | 18:05 | |
| *** cjloader has joined #openstack-requirements | 18:05 | |
| *** vpickard is now known as vpickard_ | 21:30 | |
| *** edmondsw has quit IRC | 22:04 | |
| *** edmondsw has joined #openstack-requirements | 22:07 | |
| *** edmondsw has quit IRC | 22:11 | |
| *** cjloader has quit IRC | 22:13 | |
| *** bnemec has quit IRC | 22:29 | |
| *** bnemec has joined #openstack-requirements | 22:35 | |
| *** tosky has quit IRC | 23:08 | |
| *** rpioso is now known as rpioso|afk | 23:36 | |
| *** cjloader has joined #openstack-requirements | 23:37 | |
| *** cjloader has quit IRC | 23:41 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!