| *** openstack has joined #openstack-sahara | 14:04 | |
| SergeyLukjanov | test logging | 14:05 |
|---|---|---|
| SergeyLukjanov | http://eavesdrop.openstack.org/irclogs/%23openstack-sahara/%23openstack-sahara.2014-03-12.log | 14:06 |
| SergeyLukjanov | works ok | 14:06 |
| *** SergeyLukjanov changes topic to "OpenStack Data Processing Project (Sahara, ex. Savanna) - http://docs.openstack.org/developer/sahara; channel logs: http://eavesdrop.openstack.org/irclogs/%23openstack-sahara/; discussions in this (#openstack-sahara) channel; weekly meetings on Thursdays at 18:00 UTC in #openstack-meeting-alt channel" | 14:07 | |
| openstackgerrit | Alexander Ignatov proposed a change to openstack/sahara: Renamed all swift-dependent configs to sahara https://review.openstack.org/79952 | 14:09 |
| openstackgerrit | Alexander Ignatov proposed a change to openstack/sahara: Renamed all swift-dependent configs to sahara https://review.openstack.org/79952 | 14:13 |
| openstackgerrit | Alexander Ignatov proposed a change to openstack/sahara: Renamed all swift-dependent configs to sahara https://review.openstack.org/79952 | 14:23 |
| openstackgerrit | Chad Roberts proposed a change to openstack/sahara-dashboard: Renaming savannadashboard directory to saharadashboard https://review.openstack.org/79746 | 14:28 |
| *** elmiko has joined #openstack-sahara | 14:30 | |
| *** crobertsrh has joined #openstack-sahara | 14:30 | |
| *** themistymay has quit IRC | 14:30 | |
| *** tmckay has joined #openstack-sahara | 14:33 | |
| tmckay | woohoo | 14:33 |
| tmckay | I almost have the python-saharaclient renaming done; just a few internal variables and the packaging stuff which I can do now that the repo move has happened | 14:34 |
| tmckay | and I ran integration tests so I know it's working | 14:34 |
| SergeyLukjanov | tmckay, it's really great | 14:40 |
| openstackgerrit | Chad Roberts proposed a change to openstack/sahara-dashboard: Renaming savannadashboard directory to saharadashboard https://review.openstack.org/79746 | 14:48 |
| *** ErikB has joined #openstack-sahara | 14:54 | |
| ErikB | Is anyone working on the doc changes Savanna ->Sahara? | 14:56 |
| SergeyLukjanov | ErikB, hey | 14:56 |
| SergeyLukjanov | ErikB, we have a tons of blueprints and work items to rename all stuff | 14:56 |
| crobertsrh | I don't seem to be able to push any changes to savanna-project/savanna-ci. What's that process I should go through to make changes there? | 14:57 |
| SergeyLukjanov | ErikB, http://lists.openstack.org/pipermail/openstack-dev/2014-March/029414.html | 14:57 |
| SergeyLukjanov | crobertsrh, you should create a pull request | 14:57 |
| *** eanxgeek is now known as eanxgeek|log | 14:59 | |
| ErikB | I was looking at: https://blueprints.launchpad.net/sahara/+spec/savanna-renaming and it does not specify anything about docs proper. | 14:59 |
| *** NikitaKonovalov has joined #openstack-sahara | 14:59 | |
| *** vrovachev has joined #openstack-sahara | 15:00 | |
| openstackgerrit | Michael McCune proposed a change to openstack/sahara-image-elements: Renaming all Savanna references to Sahara https://review.openstack.org/79419 | 15:00 |
| *** tnovacik has joined #openstack-sahara | 15:00 | |
| SergeyLukjanov | ErikB, probably, noone is assigned on it now | 15:02 |
| SergeyLukjanov | ErikB, you want to volunteer? :) | 15:02 |
| ErikB | SergeyLukjanov: yes I will volunteer, should I create a new BP for this? | 15:03 |
| SergeyLukjanov | ErikB, yep, I think so | 15:03 |
| SergeyLukjanov | ErikB,thank you | 15:03 |
| ErikB | SergeyLukjanov: ok np | 15:03 |
| *** aignatov has joined #openstack-sahara | 15:04 | |
| *** bogdando has joined #openstack-sahara | 15:05 | |
| aignatov | Hello Sahara!! | 15:05 |
| elmiko | hi aignatov :) | 15:05 |
| SergeyLukjanov | aignatov, please, go away :) | 15:05 |
| aignatov | noooooo.jpg | 15:05 |
| tmckay | Sahara? oh, right | 15:05 |
| SergeyLukjanov | aignatov, oh, you're core. please, stay here | 15:06 |
| tmckay | lol | 15:06 |
| aignatov | Okay! | 15:06 |
| tmckay | hmm, something went wrong with my package naming change. tox -e py27 shows prb having some problem with version name. | 15:06 |
| * tmckay gets software shovel | 15:07 | |
| tmckay | prb that is | 15:07 |
| ErikB | added https://blueprints.launchpad.net/sahara/+spec/savanna-renaming-docs | 15:07 |
| tosky | SergeyLukjanov: you are also going to rename the namespace here, right? https://github.com/savanna-project | 15:07 |
| SergeyLukjanov | tosky, sure | 15:07 |
| tmckay | SergeyLukjanov, so why the change from eho? I like that. | 15:07 |
| SergeyLukjanov | tmckay, there were some concerns about pronunciation and overall gall | 15:08 |
| *** ErikB has quit IRC | 15:08 | |
| SergeyLukjanov | eho = elastic hadoop on openstack | 15:08 |
| aignatov | ErikB, hi | 15:09 |
| aignatov | oh, he has left the chat... | 15:09 |
| *** ErikB has joined #openstack-sahara | 15:09 | |
| tmckay | SergeyLukjanov -- "gall" brazen boldness coupled with impudent assurance and insolence | 15:09 |
| tmckay | someone thought eho was brazen? | 15:09 |
| tmckay | sounds descriptive to me | 15:10 |
| aignatov | ErikB: hi, I looked at the doc, and found that some info related to HDP plugin is outdated | 15:10 |
| tmckay | oh well, old issue I guess :) | 15:10 |
| SergeyLukjanov | tmckay, gall -> goal | 15:10 |
| tmckay | llol, oh :-D | 15:11 |
| SergeyLukjanov | aignatov, ErikB volunteered to rename savanna to sahara in docs | 15:11 |
| aignatov | In particular, on the page http://docs.openstack.org/developer/savanna/userdoc/hdp_plugin.html there are wrong limitation | 15:11 |
| SergeyLukjanov | and I think he'll update HDP docs too after that | 15:11 |
| SergeyLukjanov | :) | 15:11 |
| aignatov | ah ok | 15:11 |
| aignatov | thats great | 15:11 |
| ErikB | Yes yes, I have been sitting on that transaction for weeks… sigh. Will get this in asap. | 15:16 |
| *** witlessb has joined #openstack-sahara | 15:20 | |
| SergeyLukjanov | ErikB, thank you! | 15:24 |
| tmckay | SergeyLukjanov, mattf, so the base for openstack-common.conf used to be "savannaclient" for the python-savannaclient. When I swapped the dir contents for saharaclient/savannaclient and made savannaclient the alias, I missed openstack/common in savannaclient (maybe because I wasn't on the tip and changes were pushed out from oslo on 3/5?) | 15:34 |
| tmckay | Can I just git rm savannclient/openstack or do I have to do something more complicated? | 15:35 |
| tmckay | openstack-common.conf has been updated | 15:35 |
| tmckay | currently "common" is sitting there with just an __init__.py, not hurting anything but not right either | 15:35 |
| SergeyLukjanov | tmckay, it should be moved to saharaclient with replace all savanna to sahara | 15:35 |
| tmckay | (init.py has some "six" stuff in it) | 15:36 |
| tmckay | SergeyLukjanov, yes, I think it's duplicated. It's in both places. | 15:36 |
| SergeyLukjanov | tmckay, it should be only in saharaclient | 15:36 |
| tmckay | okay, thanks. I'll remove it with git rm and add it to the swap CR. | 15:37 |
| openstackgerrit | Michael McCune proposed a change to openstack/sahara-image-elements: Renaming all Savanna references to Sahara https://review.openstack.org/79419 | 16:04 |
| openstackgerrit | Trevor McKay proposed a change to openstack/python-saharaclient: Change packaging references to python-saharaclient https://review.openstack.org/79979 | 16:06 |
| *** vrovachev has left #openstack-sahara | 16:08 | |
| openstackgerrit | Trevor McKay proposed a change to openstack/python-saharaclient: Swap the saharaclient and savannaclient directories https://review.openstack.org/79751 | 16:09 |
| openstackgerrit | Trevor McKay proposed a change to openstack/python-saharaclient: Add cli integration test https://review.openstack.org/75527 | 16:09 |
| openstackgerrit | Trevor McKay proposed a change to openstack/python-saharaclient: Change packaging references to python-saharaclient https://review.openstack.org/79979 | 16:10 |
| openstackgerrit | Chad Roberts proposed a change to openstack/sahara-dashboard: Renaming savannadashboard directory to saharadashboard https://review.openstack.org/79746 | 16:31 |
| *** tosky has quit IRC | 16:32 | |
| *** tosky has joined #openstack-sahara | 16:32 | |
| openstackgerrit | Trevor McKay proposed a change to openstack/python-saharaclient: Change internal variables and classes to 'sahara' https://review.openstack.org/79992 | 16:43 |
| *** dmitryme has joined #openstack-sahara | 16:48 | |
| openstackgerrit | Trevor McKay proposed a change to openstack/python-saharaclient: Change client doc references to sahara https://review.openstack.org/79803 | 16:48 |
| openstackgerrit | Michael McCune proposed a change to openstack/sahara-image-elements: Renaming all Savanna references to Sahara https://review.openstack.org/79419 | 16:55 |
| *** alazarev has joined #openstack-sahara | 17:14 | |
| openstackgerrit | A change was merged to openstack/sahara-dashboard: Update .gitreview to point on updated repo https://review.openstack.org/79937 | 17:27 |
| *** crobertsrh has quit IRC | 17:32 | |
| *** crobertsrh has joined #openstack-sahara | 17:33 | |
| openstackgerrit | Chad Roberts proposed a change to openstack/sahara-dashboard: Renaming savannadashboard directory to saharadashboard https://review.openstack.org/79746 | 17:53 |
| openstackgerrit | Michael McCune proposed a change to openstack/sahara-image-elements: Renaming all Savanna references to Sahara https://review.openstack.org/79419 | 17:54 |
| *** mattf is now known as _mattf | 17:55 | |
| *** _mattf is now known as mattf | 18:01 | |
| openstackgerrit | Sergey Lukjanov proposed a change to openstack/sahara: Add etc/sahara/sahara.conf.sample needed for d-g https://review.openstack.org/80038 | 18:07 |
| openstackgerrit | Sergey Lukjanov proposed a change to openstack/sahara: Add etc/sahara/sahara.conf.sample needed for d-g https://review.openstack.org/80038 | 18:12 |
| openstackgerrit | Trevor McKay proposed a change to openstack/python-saharaclient: Change internal variables and classes to 'sahara' https://review.openstack.org/79992 | 18:14 |
| crobertsrh | tmckay: is savanna-db going to change to sahara-db? I'll need to make sure to coordinate that change whenever it happens for the dashboard. | 18:15 |
| tmckay | crobertsrh, yes, I believe so. We should have an alembic script for that too. I haven't done any work on savanna-api yet (I thiink aignatov is working there) | 18:16 |
| tmckay | but I'm just about done with client, so maybe I can lend a hand ^^ | 18:17 |
| tmckay | SergeyLukjanov, ^^ | 18:17 |
| *** dmitryme has quit IRC | 18:19 | |
| mattf | tmckay, what happened to internal-db-the-thing-that-needs-to-go-away:?? | 18:19 |
| aignatov | tmckay: crobertsrh yep, 'savanna-db' should be renamed | 18:21 |
| aignatov | I see great idea from mattf to go away from project name in this thing | 18:22 |
| aignatov | 'savanna-db' -> 'interanal-db' looks great | 18:22 |
| aignatov | *internal-db | 18:23 |
| mattf | i'm just a repeater here. i believe tmckay brought it up before. | 18:23 |
| aignatov | oh, ok, didn't know that | 18:23 |
| tmckay | mattf, ack on that, thanks for the reminder. | 18:24 |
| aignatov | tmckay: I'm just going to sleep you can go with this change | 18:24 |
| aignatov | :) | 18:24 |
| tmckay | aignatov :) Okey doke. Please +1 anything I do. | 18:24 |
| tmckay | +2 even | 18:25 |
| tmckay | crobertsrh, so, savanna-db will change to internal-db | 18:25 |
| * tmckay time for snacks | 18:25 | |
| elmiko | mmmm snacks | 18:28 |
| aignatov | btw, I've send today patch for renaming 'savanna' in swift related configs | 18:28 |
| aignatov | but didn't decided to write alembic script for renaming data sources urls | 18:29 |
| aignatov | not sure if this needed | 18:29 |
| *** dmitryme has joined #openstack-sahara | 18:33 | |
| mattf | tmckay, consider if the savanna-db change can happen blindly or if there should be some backward compat in place | 18:37 |
| SergeyLukjanov | ++ for internal-db | 18:38 |
| crobertsrh | any chance of getting the dashboard ci-tests updated/kicked off again? Looks like my pull request was merged. I *think* things should work now. | 18:41 |
| *** witlessb has quit IRC | 18:42 | |
| *** dmitryme_ has joined #openstack-sahara | 18:43 | |
| mattf | my vote is for please-do-not-use-this-just-use-swift-instead-it-is-easy-cmon:// | 18:46 |
| *** dmitryme has quit IRC | 18:46 | |
| *** dmitryme_ is now known as dmitryme | 18:46 | |
| elmiko | lol | 18:47 |
| mattf | alias it to rrly-guys-just-swift-upload-pls:// | 18:49 |
| *** tosky has quit IRC | 19:06 | |
| tmckay | I have typed "ack [Ss]avanna" about 1000 times today | 19:11 |
| tmckay | mattf, or some negative reinforcement, "i-am-a-bad-person-for-using-this://" | 19:12 |
| ErikB | does anyone know why I would get: remote: Permission to openstack/sahara.git denied to bergenholtz. | 19:13 |
| ErikB | on git review -v ? | 19:13 |
| tmckay | ErikB, hmm, I haven't touched sahara today, but python-saharaclient has been fine. Nothing special there. | 19:14 |
| SergeyLukjanov | ErikB, it works for me ok | 19:15 |
| SergeyLukjanov | ErikB, for sahara | 19:15 |
| ErikB | ok, thanks will keep checking. | 19:15 |
| elmiko | tmckay, maybe "ack -i savanna" :) | 19:15 |
| openstackgerrit | Sergey Lukjanov proposed a change to openstack/sahara: NOOOOOOOO.jpg https://review.openstack.org/80057 | 19:15 |
| tmckay | elmiko, fancy | 19:16 |
| SergeyLukjanov | ErikB, you can share your output on paste.o.o, I'll check it | 19:16 |
| elmiko | lol | 19:16 |
| aignatov | lol, what is that? | 19:16 |
| tmckay | yes, me too. | 19:17 |
| * tmckay uses the opportunity for a -1 | 19:17 | |
| tmckay | oh darn, abandoned | 19:17 |
| tmckay | must have been a test | 19:17 |
| SergeyLukjanov | tmckay, yup, it's a test for ErikB | 19:18 |
| *** alazarev has quit IRC | 19:28 | |
| mattf | tmckay, that'd work! | 19:35 |
| tmckay | mattf, oh, really? | 19:36 |
| mattf | anyone have a sed line i should run across my repos? | 19:36 |
| * mattf tries sed -i 's/savanna/sahara/' .git/config | 19:39 | |
| SergeyLukjanov | mattf, it should work IMO | 19:40 |
| mattf | for r in *savanna*; do (cd $r && sed -i 's/savanna/sahara/' .git/config); done | 19:40 |
| SergeyLukjanov | :) | 19:41 |
| mattf | rename savanna sahara *savanna* | 19:42 |
| mattf | and DONE | 19:42 |
| mattf | now to train myself not to type savTAB | 19:43 |
| elmiko | i'm waiting on docs.o.o to put the new docs in place, and for the sahara-image-elements merge to happen. are there any other renaming tasks that i could help with? | 19:43 |
| crobertsrh | changing repos =~ 20 seconds.....learning to use the new repos =~ a lifetime | 19:43 |
| *** alazarev has joined #openstack-sahara | 19:44 | |
| SergeyLukjanov | elmiko, review all other changes :) | 19:44 |
| elmiko | SergeyLukjanov: will do! | 19:45 |
| SergeyLukjanov | I'm now waiting for devstack updates merged and than I'll start merging renaming CRs with +1 from jenkins and savanna-ci (when it's expected) | 19:45 |
| SergeyLukjanov | I think it'll be tomorrow | 19:45 |
| SergeyLukjanov | so, time to review each other | 19:45 |
| tmckay | mattf, hmm, so I don't think we can get away with a blind change of savanna-db to internal-db unless we want to sync the change across savanna-dashboard and savanna. Could be done. For compat code, I'm thinking of something kind of loose. Any url of the form "blahblah://uuid" referenced from a job-binary. I don't really see how that can go wrong, all we really care about is the uuid. | 19:48 |
| tmckay | crobertsrh, opinion? ^^ | 19:50 |
| mattf | ok, what about the upgrade case, where i have savanna-db stored in the db somewhere? | 19:50 |
| tmckay | mattf, alembic script. simple. Might not even be necessary, depending on how the value is treated when we process it. | 19:51 |
| tmckay | the right compat incantation could even make alembic unnecessary | 19:51 |
| crobertsrh | tmckay: That is probably a fine way to go, assuming that there is a db migrate script (which I see you have noted as I'm typing this) | 19:51 |
| tmckay | yeah, I think alembic would be fine. Because we probably want to fix up xxx.savanna for stored swift urls too | 19:52 |
| crobertsrh | true | 19:52 |
| tmckay | haven't thought about that one too much yet | 19:52 |
| tmckay | similar issue, maybe not as easy to fudge | 19:53 |
| tmckay | hmm, well, we know it starts with "swift", that won't change. Wonder if we check for the ".savanna" part. | 19:54 |
| * tmckay goes to look | 19:54 | |
| openstackgerrit | A change was merged to openstack/sahara: Update .gitreview to point on updated repo https://review.openstack.org/79932 | 19:57 |
| *** ErikB has quit IRC | 19:58 | |
| *** ErikB has joined #openstack-sahara | 19:59 | |
| SergeyLukjanov | mattf, alazarev, aignatov, jspeidel, please, note that our devstack/tempest jobs aren't running sahara atm due to the transition | 19:59 |
| SergeyLukjanov | I'll send an email confirmation when it'll start working | 19:59 |
| alazarev | SergeyLukjanov: it's Ok, it seems that we will not merge anything until renaming ends anyway | 20:00 |
| SergeyLukjanov | alazarev, yup, it's about renaming CRs too | 20:01 |
| dmitryme | SergeyLukjanov: can you disable openstackgerrit bot in the savanna channel? It does not make sense to post review updates into two channels. And at the same time it it disturbing | 20:01 |
| SergeyLukjanov | dmitryme, change is already on review | 20:01 |
| dmitryme | SergeyLukjanov: cool, thanks | 20:01 |
| alazarev | SergeyLukjanov: most of renaming CRs don't pass tests anyway, we will need to repair tests after renaming | 20:02 |
| SergeyLukjanov | alazarev, renaming CRs must pass Jenkins | 20:02 |
| SergeyLukjanov | alazarev, that's why we're adding aliases and etc. | 20:03 |
| openstackgerrit | Erik Bergenholtz proposed a change to openstack/sahara: Renames all doc references from Savanna to Sahara. https://review.openstack.org/80069 | 20:06 |
| mattf | ErikB, ^^ you going to get your ATC discount? | 20:07 |
| ErikB | I already did. ;-) | 20:07 |
| mattf | bwahahaha | 20:08 |
| ErikB | Who has the source for the doc images? | 20:08 |
| tmckay | crobertsrh, mattf, it doesn't look like any code changes are necessary to support compat for swift urls. binaries don't use the ".savanna" mechanism, and although data sources do we don't check anywhere. Strictly a convention in the hadoop implementation, afaik. If alembic can support glob/replace we can fix up existing rows (still have to check that) | 20:08 |
| SergeyLukjanov | ErikB, dmitryme probably | 20:09 |
| crobertsrh | tmckay: ack | 20:09 |
| SergeyLukjanov | tmckay, sounds correct, but I'm afraid that alembic doesn't have such feature | 20:10 |
| elmiko | is a pep8 warning worthy of a -1 ? | 20:11 |
| tmckay | SergeyLukjanov, that's terrible. Maybe there is a way to make it happen :) Alembic patches... Or, maybe "fix on read" in the sqlalchemy stuff. | 20:11 |
| tmckay | SergeyLukjanov, looks like sql has some support for wildcard replace, so maybe it can be done with alembic raw sql op. Not giving up yet :) | 20:17 |
| * tmckay slaps own hand, he needs to finish the client first. | 20:18 | |
| * mattf 's eyes bleed sahara | 20:23 | |
| mattf | ErikB, i quit after 20 inline comments | 20:24 |
| mattf | ErikB, many of the comments are just requests for clarification, or to make sure there's coordination happening. | 20:25 |
| mattf | a few not so much, e.g. Shara... | 20:25 |
| dmitryme | ErikB: regarding doc images' sources, I think I got some of them in my google drive. | 20:26 |
| dmitryme | I'll check it out tomorrow and update those which I have | 20:27 |
| dmitryme | I'll figure who has the others then | 20:27 |
| ErikB | dmitryme: if you could send them to me, i will update. If not, i will re-create. I have some mode doc changes that i need to make | 20:32 |
| dmitryme | aha, ok. I'll see right now what I have | 20:33 |
| dmitryme | will update you shortly | 20:33 |
| *** ErikB1 has joined #openstack-sahara | 20:34 | |
| * mattf appears to have received 2 ATC codes | 20:43 | |
| ErikB1 | mattf, Ok, NP. I will go back and address the comments. Hang tight. In general I think it will be difficult too coordinate all changes with docs, unless we put these off until the very end. | 20:44 |
| openstackgerrit | Chad Roberts proposed a change to openstack/sahara-dashboard: Changing "Savanna" to "Sahara" in basic strings https://review.openstack.org/80079 | 20:45 |
| mattf | ErikB1, i agree re difficulty. i just want to make sure the folks making the related changes sign off. it'd be a pita if you pick one url and crobertsrh picks another, for instance | 20:45 |
| openstackgerrit | Trevor McKay proposed a change to openstack/python-saharaclient: Add cli integration test https://review.openstack.org/75527 | 20:48 |
| *** witlessb has joined #openstack-sahara | 20:50 | |
| *** crobertsrh is now known as _crobertsrh | 20:50 | |
| dmitryme | ErikB: so we have 4 images in sahara/doc/source/images directory in total | 20:51 |
| dmitryme | here are the sources for 3 of them: | 20:51 |
| dmitryme | savanna-architecture.png | 20:51 |
| dmitryme | https://docs.google.com/drawings/d/12bmmnnBDiaF2sbbXIZ7euaWFokfyGlqbJbxofHsOMEE/edit?usp=sharing | 20:51 |
| dmitryme | hadoop-cluster-example.jpg | 20:51 |
| dmitryme | https://docs.google.com/drawings/d/1LAJD0pbqvxnK--IeGdnp6Rb8nqeGENn94j7DIjYIrCc/edit?usp=sharing | 20:51 |
| dmitryme | openstack-interop.png | 20:51 |
| dmitryme | https://docs.google.com/drawings/d/1kCahSrGI0OvPeQBcqjX9GV54GZYBZpt_W4nOt5nsKB8/edit?usp=sharing | 20:51 |
| dmitryme | as for hdp-plugin-architecture.png, I think you guys should have it somewhere :-) | 20:52 |
| ErikB1 | dmitryme, I have the HDP ing source and have already updated | 20:54 |
| ErikB1 | dmitryme, thanks | 20:54 |
| dmitryme | ErikB: the drawings are in read-only mode, copy them to change | 20:57 |
| *** ErikB has quit IRC | 20:58 | |
| SergeyLukjanov | folks, http://docs.openstack.org/developer/sahara/ is already available | 20:59 |
| elmiko | SergeyLukjanov: yay! updating wiki now | 20:59 |
| SergeyLukjanov | elmiko, thx | 20:59 |
| openstackgerrit | Trevor McKay proposed a change to openstack/python-saharaclient: Change client doc references to sahara https://review.openstack.org/79803 | 21:06 |
| elmiko | SergeyLukjanov: with the exception of the few issues i emailed you about the wiki is in pretty good shape. | 21:06 |
| SergeyLukjanov | elmiko, awesome, thank you, I'll fix them tomorrow, it's in my backlog | 21:06 |
| tmckay | SergeyLukjanov, https://review.openstack.org/#/c/79803/2/doc/source/index.rst, comment on line 4, is "OpenStack Sahara" a problem? | 21:08 |
| *** elmiko is now known as elmiko_afk | 21:12 | |
| mattf | tmckay, https://review.openstack.org/#/c/79992/2/saharaclient/api/client.py <- breaks api, ack? | 21:12 |
| SergeyLukjanov | tmckay, I've added a comment | 21:13 |
| mattf | specifically anyone passing savanna_url=blah as a named parameter to the client | 21:13 |
| mattf | tmckay, i'm fine to +1, just want to make sure you thought about it and we're generally ok w/ the situation | 21:13 |
| openstackgerrit | A change was merged to stackforge/sahara-guestagent: Rename Savanna to Sahara https://review.openstack.org/79681 | 21:14 |
| mattf | maybe the way to address it is to have the alias client pass sahara_url=savanna_url | 21:15 |
| * mattf checks the code to probably find that's already done | 21:15 | |
| tmckay | mattf, hmm, you might have a point there. I was kind of assuming since it's optional it's an edge case. But I like the idea of fixing up the alias client | 21:16 |
| tmckay | mattf, I don't think it's already done | 21:16 |
| mattf | ok, i'll leave a -1 w/ request for clarification | 21:16 |
| tmckay | mattf, okay, I'll play with an alias client change. That makes the most sense to me. | 21:18 |
| SergeyLukjanov | tmckay, we shouldn't change simple alias | 21:18 |
| SergeyLukjanov | tmckay, the best case is to add additional arg to the end of client constructor | 21:19 |
| tmckay | SergeyLukjanov, what do you think of "savanna_url" to "sahara_url" in the client __init__.py. The other thing I can think of is to include both = None, and give sahara_url the preference | 21:19 |
| tmckay | ack ^^ | 21:19 |
| tmckay | okay. SergeyLukjanov, so what's our plan to remove the savanna compat stuff? Post juno? | 21:20 |
| tmckay | never? :) | 21:20 |
| SergeyLukjanov | tmckay, it should be discussed | 21:21 |
| SergeyLukjanov | personally, I don't think that we need it at all | 21:21 |
| SergeyLukjanov | only to migrate to the new name and remove before the I release | 21:21 |
| SergeyLukjanov | because it's our first real OpenStack aligned release | 21:21 |
| mattf | topic for tomorrow i guess | 21:22 |
| mattf | ^^ re if we care about compat, which we need to start doing | 21:23 |
| mattf | assuming we do compat, it's cleaner to put the mapping in the shell/compat client instead of in the sahara client | 21:24 |
| SergeyLukjanov | mattf, yup, it's main topic for tomorrow | 21:24 |
| tmckay | hmm, just a derivation with an overloaded __init__ ought to do it | 21:24 |
| tmckay | I'll make patches for both, toss a coin which one I push first :) | 21:25 |
| * mattf appears to be a negative nathan w/ all these -1s | 21:29 | |
| mattf | chad may win w/ most files changed - https://review.openstack.org/#/c/79746/ | 21:30 |
| *** mattf is now known as _mattf | 21:41 | |
| *** dmitryme has quit IRC | 21:46 | |
| *** elmiko_afk is now known as elmiko | 21:48 | |
| *** alazarev has quit IRC | 21:49 | |
| *** dmitryme has joined #openstack-sahara | 21:49 | |
| *** alazarev has joined #openstack-sahara | 21:49 | |
| openstackgerrit | Trevor McKay proposed a change to openstack/python-saharaclient: Map savanna_url to sahara_url in savannaclient.client https://review.openstack.org/80096 | 21:53 |
| *** alazarev has quit IRC | 21:55 | |
| *** tmckay has quit IRC | 21:57 | |
| *** alazarev has joined #openstack-sahara | 21:57 | |
| *** elmiko has quit IRC | 22:00 | |
| *** alazarev has quit IRC | 22:01 | |
| *** witlessb has quit IRC | 22:03 | |
| *** witlessb has joined #openstack-sahara | 22:04 | |
| *** alazarev has joined #openstack-sahara | 22:11 | |
| *** dmitryme has quit IRC | 22:39 | |
| *** alazarev has quit IRC | 23:41 | |
| *** alazarev has joined #openstack-sahara | 23:45 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!