openstackgerrit | weiting-chen proposed openstack/sahara: Add Key Value Store service test in cdh plugin integration test https://review.openstack.org/158940 | 01:05 |
---|---|---|
*** alazarev has quit IRC | 01:08 | |
*** aignatov has quit IRC | 01:08 | |
*** SergeyLukjanov has quit IRC | 01:08 | |
*** aignatov has joined #openstack-sahara | 01:09 | |
*** openstack has joined #openstack-sahara | 01:11 | |
*** alazarev has joined #openstack-sahara | 01:11 | |
*** SergeyLukjanov has joined #openstack-sahara | 01:14 | |
*** sgotliv has quit IRC | 01:16 | |
*** elmiko has quit IRC | 01:16 | |
*** Longgeek has joined #openstack-sahara | 01:18 | |
*** Longgeek has quit IRC | 01:18 | |
*** elmiko has joined #openstack-sahara | 01:20 | |
*** amcrn has quit IRC | 01:20 | |
*** dmitryme2 has joined #openstack-sahara | 01:23 | |
*** dmitryme has quit IRC | 01:24 | |
*** dmitryme2 is now known as dmitryme | 01:24 | |
*** sgotliv has joined #openstack-sahara | 01:25 | |
*** Longgeek has joined #openstack-sahara | 01:25 | |
*** pashkin has quit IRC | 01:35 | |
*** ekarlso has quit IRC | 01:35 | |
*** juice has quit IRC | 01:35 | |
*** anteaya has quit IRC | 01:35 | |
*** ruhe has quit IRC | 01:35 | |
*** NikitaKonovalov has quit IRC | 01:35 | |
*** coolsvap_ has quit IRC | 01:35 | |
*** ekarlso has joined #openstack-sahara | 01:39 | |
*** pashkin has joined #openstack-sahara | 01:39 | |
*** ruhe has joined #openstack-sahara | 01:39 | |
*** NikitaKonovalov has joined #openstack-sahara | 01:39 | |
*** coolsvap_ has joined #openstack-sahara | 01:39 | |
*** juice has joined #openstack-sahara | 01:39 | |
*** anteaya has joined #openstack-sahara | 01:39 | |
*** pashkin has quit IRC | 01:40 | |
*** ekarlso has quit IRC | 01:40 | |
*** juice has quit IRC | 01:40 | |
*** anteaya has quit IRC | 01:40 | |
*** ruhe has quit IRC | 01:40 | |
*** NikitaKonovalov has quit IRC | 01:40 | |
*** coolsvap_ has quit IRC | 01:40 | |
*** sreshetnyak has quit IRC | 01:40 | |
*** ekarlso has joined #openstack-sahara | 01:41 | |
*** pashkin has joined #openstack-sahara | 01:41 | |
*** ruhe has joined #openstack-sahara | 01:41 | |
*** NikitaKonovalov has joined #openstack-sahara | 01:41 | |
*** coolsvap_ has joined #openstack-sahara | 01:41 | |
*** juice has joined #openstack-sahara | 01:41 | |
*** anteaya has joined #openstack-sahara | 01:41 | |
*** Longgeek has quit IRC | 01:49 | |
*** jamielennox is now known as jamielennox|away | 01:58 | |
*** sreshetnyak has joined #openstack-sahara | 01:59 | |
*** jamielennox|away is now known as jamielennox | 02:06 | |
*** sreshetnyak has quit IRC | 02:10 | |
*** sreshetnyak has joined #openstack-sahara | 02:16 | |
openstackgerrit | weiting-chen proposed openstack/sahara: Add Key Value Store service test in cdh plugin integration test https://review.openstack.org/158940 | 02:16 |
*** jamielennox is now known as jamielennox|away | 02:17 | |
*** Longgeek has joined #openstack-sahara | 02:18 | |
*** jamielennox|away is now known as jamielennox | 02:27 | |
openstackgerrit | weiting-chen proposed openstack/sahara: Add Impala service test in cdh plugin integration test https://review.openstack.org/151934 | 02:36 |
*** jamielennox is now known as jamielennox|away | 02:38 | |
*** jamielennox|away is now known as jamielennox | 02:47 | |
openstackgerrit | Michael McCune proposed openstack/sahara-specs: Adding improved secret storage spec https://review.openstack.org/157432 | 02:49 |
openstackgerrit | TIngting Bao proposed openstack/sahara: Remove unused field in job_execution table https://review.openstack.org/158964 | 03:04 |
*** devlaps has joined #openstack-sahara | 03:14 | |
*** jamielennox is now known as jamielennox|away | 03:22 | |
*** jamielennox|away is now known as jamielennox | 03:33 | |
*** hogepodge has quit IRC | 03:34 | |
*** hogepodge has joined #openstack-sahara | 03:39 | |
*** devlaps has quit IRC | 03:40 | |
*** Longgeek has quit IRC | 03:52 | |
*** ViswaV has quit IRC | 04:01 | |
*** mahito has joined #openstack-sahara | 04:03 | |
*** ViswaV has joined #openstack-sahara | 04:05 | |
*** coolsvap_ is now known as coolsvap | 04:16 | |
*** hdd has quit IRC | 04:36 | |
*** hdd has joined #openstack-sahara | 04:37 | |
*** hdd has quit IRC | 04:38 | |
*** Longgeek has joined #openstack-sahara | 04:46 | |
*** akuznetsov has joined #openstack-sahara | 05:03 | |
*** Longgeek has quit IRC | 05:07 | |
*** Longgeek has joined #openstack-sahara | 05:07 | |
*** chen123 has joined #openstack-sahara | 05:09 | |
*** chandankumar has joined #openstack-sahara | 05:26 | |
*** Longgeek has quit IRC | 05:50 | |
*** chandankumar has quit IRC | 05:50 | |
*** Longgeek has joined #openstack-sahara | 05:52 | |
*** mahito has quit IRC | 06:03 | |
*** mahito has joined #openstack-sahara | 06:13 | |
*** Longgeek has quit IRC | 06:19 | |
*** chandankumar has joined #openstack-sahara | 06:20 | |
*** hdd has joined #openstack-sahara | 06:27 | |
*** mahito has quit IRC | 07:02 | |
*** mahito has joined #openstack-sahara | 07:06 | |
*** tnovacik_ has joined #openstack-sahara | 07:08 | |
*** mahito has quit IRC | 07:11 | |
*** mahito has joined #openstack-sahara | 07:12 | |
*** mahito has quit IRC | 07:36 | |
*** mahito has joined #openstack-sahara | 07:37 | |
*** hdd has quit IRC | 07:42 | |
*** ekarlso has quit IRC | 07:48 | |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara: Add support of several scenario files in integration tests https://review.openstack.org/158710 | 08:08 |
*** skolekonov has joined #openstack-sahara | 08:09 | |
*** witlessb has joined #openstack-sahara | 08:16 | |
*** ViswaV has quit IRC | 08:27 | |
*** mahito has quit IRC | 08:31 | |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara: Add unit-tests for new integration tests https://review.openstack.org/155298 | 08:43 |
*** IvanBerezovskiy_ has joined #openstack-sahara | 08:44 | |
*** ekarlso has joined #openstack-sahara | 08:52 | |
openstackgerrit | Denis Egorenko proposed stackforge/sahara-ci-config: Divide jobs log to different files https://review.openstack.org/158737 | 08:55 |
openstackgerrit | Denis Egorenko proposed stackforge/sahara-ci-config: Divide jobs log to different files https://review.openstack.org/158737 | 08:58 |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara: Add support of several scenario files in integration tests https://review.openstack.org/158710 | 09:04 |
*** akuznetsov has quit IRC | 09:07 | |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara: Add unit-tests for new integration tests https://review.openstack.org/155298 | 09:11 |
openstackgerrit | Denis Egorenko proposed stackforge/sahara-ci-config: Divide jobs log to different files https://review.openstack.org/158737 | 09:12 |
openstackgerrit | Denis Egorenko proposed stackforge/sahara-ci-config: Divide jobs log to different files https://review.openstack.org/158737 | 09:21 |
*** akuznetsov has joined #openstack-sahara | 09:21 | |
openstackgerrit | Merged stackforge/sahara-ci-config: Divide jobs log to different files https://review.openstack.org/158737 | 09:27 |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara: Add unit-tests for new integration tests https://review.openstack.org/155298 | 10:02 |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara: Add support of several scenario files in integration tests https://review.openstack.org/158710 | 10:16 |
*** tnovacik_ has quit IRC | 10:22 | |
*** macjacktw has joined #openstack-sahara | 10:23 | |
*** macjacktw1 has joined #openstack-sahara | 10:24 | |
*** macjacktw1 has quit IRC | 10:25 | |
*** macjack has quit IRC | 10:25 | |
*** macjack has joined #openstack-sahara | 10:26 | |
*** macjack has quit IRC | 10:26 | |
*** macjacktw has quit IRC | 10:27 | |
*** tosky has joined #openstack-sahara | 10:33 | |
*** macjack has joined #openstack-sahara | 10:36 | |
*** tnovacik_ has joined #openstack-sahara | 11:17 | |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara: Add support of several scenario files in integration tests https://review.openstack.org/158710 | 11:25 |
openstackgerrit | Merged openstack/sahara: Minor - Added missing check for 'Deleting' state https://review.openstack.org/155861 | 12:42 |
*** tnovacik_ has quit IRC | 12:53 | |
*** tnovacik_ has joined #openstack-sahara | 13:02 | |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara: Add support of several scenario files in integration tests https://review.openstack.org/158710 | 13:08 |
openstackgerrit | Merged openstack/sahara: Remove unused code (timed decorator) https://review.openstack.org/158649 | 13:11 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/sahara: Updated from global requirements https://review.openstack.org/158775 | 13:22 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/sahara-dashboard: Updated from global requirements https://review.openstack.org/159118 | 13:22 |
*** ylobankov has quit IRC | 13:34 | |
*** _crobertsrh is now known as crobertsrh | 13:50 | |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Provide ability to get events directly from cluster https://review.openstack.org/159131 | 13:59 |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Provide ability to get events directly from cluster https://review.openstack.org/159131 | 14:02 |
openstackgerrit | Vitaly Gridnev proposed openstack/sahara: Provide ability to get events directly from cluster https://review.openstack.org/159131 | 14:04 |
openstackgerrit | Chad Roberts proposed openstack/sahara: Adding ability to edit cluster templates https://review.openstack.org/157460 | 14:06 |
openstackgerrit | Chad Roberts proposed openstack/sahara: Adding ability to edit cluster templates https://review.openstack.org/157460 | 14:23 |
*** witlessb has quit IRC | 14:27 | |
*** witlessb has joined #openstack-sahara | 14:29 | |
*** openstackgerrit has quit IRC | 15:08 | |
*** openstackgerrit has joined #openstack-sahara | 15:08 | |
openstackgerrit | Chad Roberts proposed openstack/sahara: Adding ability to edit cluster templates https://review.openstack.org/157460 | 15:36 |
*** chandankumar has quit IRC | 15:47 | |
*** chandankumar has joined #openstack-sahara | 15:53 | |
openstackgerrit | Artem Osadchiy proposed openstack/sahara: Add Drill support for MapR plugin https://review.openstack.org/148350 | 16:00 |
*** tnovacik_ has quit IRC | 16:09 | |
*** tnovacik_ has joined #openstack-sahara | 16:12 | |
*** hdd has joined #openstack-sahara | 16:15 | |
*** ViswaV has joined #openstack-sahara | 16:16 | |
openstackgerrit | Denis Egorenko proposed stackforge/sahara-ci-config: Migrate jobs to new integrations tests config https://review.openstack.org/155301 | 16:17 |
openstackgerrit | Evgeny Sikachev proposed openstack/sahara: Add support of several scenario files in integration tests https://review.openstack.org/158710 | 16:18 |
*** coolsvap is now known as coolsvap_ | 16:28 | |
*** tnovacik_ has quit IRC | 16:28 | |
*** openstackstatus has joined #openstack-sahara | 16:43 | |
*** ChanServ sets mode: +v openstackstatus | 16:43 | |
*** IvanBerezovskiy_ has quit IRC | 16:53 | |
*** vgridnev_ has joined #openstack-sahara | 17:05 | |
*** tnovacik_ has joined #openstack-sahara | 17:06 | |
vgridnev_ | ping tmckay | 17:06 |
tmckay | vgridnev_, hi | 17:06 |
vgridnev_ | hi | 17:06 |
vgridnev_ | when i'm use data.get('progress', False) it would be string, right? | 17:08 |
vgridnev_ | in my patch which i proposed today | 17:08 |
tmckay | yes | 17:09 |
vgridnev_ | ok, thanks | 17:09 |
tmckay | vgridnev_, I was just doing the same thing in another patch. I expected it to be a boolean :) | 17:10 |
vgridnev_ | Today Nikita and Sergey Lukjanov we decided, that is bad approach to have separate endpoint for events | 17:10 |
vgridnev_ | Today with* | 17:10 |
*** chandankumar has quit IRC | 17:11 | |
*** skolekonov has quit IRC | 17:13 | |
tmckay | ah, I se | 17:16 |
tmckay | see | 17:16 |
*** tmckay is now known as tmckay_lunch | 17:16 | |
*** tnovacik_ has quit IRC | 17:21 | |
*** jamielennox is now known as jamielennox|away | 17:22 | |
*** jamielennox|away is now known as jamielennox | 17:30 | |
elmiko | vgridnev_: why the move away from an endpoint for clusterevents? | 17:38 |
vgridnev_ | it's was noticed during implementation for horizon | 17:38 |
elmiko | but why remove it? | 17:39 |
vgridnev_ | we have problem: if need full info about provision progress, it's required to make 2 api calls | 17:39 |
elmiko | one for the cluster and one for the events? | 17:39 |
vgridnev_ | yes | 17:40 |
elmiko | hmm | 17:40 |
egafford | SergeyLukjanov: An oddity: on https://review.openstack.org/#/c/159118/, I do not have +2 (though I'm stable maint core now,) while elmiko (who is sahara-core but not stable maint core) does have +2 on this. It seems that sahara-dashboard stable/icehouse may not be playing by group rules. | 17:40 |
elmiko | vgridnev_: we probably need to patch the spec, imo | 17:40 |
vgridnev_ | good proposition, elmiko | 17:41 |
openstackgerrit | Sergey Reshetnyak proposed openstack/sahara: Collect errors in new integration tests https://review.openstack.org/157842 | 17:53 |
*** tnovacik_ has joined #openstack-sahara | 17:56 | |
openstackgerrit | Merged openstack/sahara: Updated from global requirements https://review.openstack.org/158775 | 17:59 |
*** jamielennox is now known as jamielennox|away | 18:02 | |
*** hdd has quit IRC | 18:06 | |
vgridnev_ | folks, how to ping guys from Cloudera/Intel? | 18:10 |
*** egafford has quit IRC | 18:11 | |
*** jamielennox|away is now known as jamielennox | 18:15 | |
*** hdd has joined #openstack-sahara | 18:20 | |
crobertsrh | Are rechecks just slow today? Or is it me? | 18:24 |
tosky | crobertsrh: I had to launch 2 rechecks for two different issues (one fixed today), so I suspect the queues are full | 18:26 |
crobertsrh | Ok. I feel less bad if it is slow for everyone :) | 18:26 |
*** tmckay_lunch is now known as tmckay | 19:10 | |
tmckay | vgridnev_, sometimes they check the channel (maybe through eavesdrop) but you could email them directly | 19:12 |
tmckay | or leave a note on a review | 19:12 |
tmckay | vgridnev_, who are you trying to find? | 19:12 |
tosky | tmckay, vgridnev_: aren't they hanging around during the meeting? Especially tomorrow, during the UTC-afternoon time? | 19:14 |
*** macjack has quit IRC | 19:15 | |
elmiko | tosky: +1 | 19:16 |
tmckay | tosky, yes, but you can find them more quickly if you need to | 19:17 |
tosky | oh, there are always emails | 19:17 |
openstackgerrit | Merged openstack/sahara: Add support for oslo_debug_helper to tox.ini https://review.openstack.org/158812 | 19:18 |
elmiko | or ring the sahara tower bells ;) | 19:19 |
*** tosky has quit IRC | 19:30 | |
vgridnev_ | i'm trying to find ken chen for reviewing this patch: https://review.openstack.org/#/c/157728/ | 19:31 |
*** egafford has joined #openstack-sahara | 19:33 | |
tmckay | vgridnev_, I would send an email. They have contacted me by email about Oozie questions | 19:35 |
elmiko | send to the ml too | 19:35 |
vgridnev_ | ok, thanks tmkay | 19:36 |
*** chandankumar has joined #openstack-sahara | 19:50 | |
*** akuznetsov has quit IRC | 20:00 | |
openstackgerrit | Andrew Lazarev proposed openstack/sahara: Implemented support of placeholders in datasource URLs https://review.openstack.org/158909 | 20:25 |
*** chandankumar has quit IRC | 21:01 | |
openstackgerrit | Andrew Lazarev proposed openstack/sahara-specs: Use trusts for cluster creation and scaling https://review.openstack.org/159251 | 21:15 |
*** amcrn has joined #openstack-sahara | 21:15 | |
tmckay | alazarev, ping | 21:18 |
alazarev | tmckay, pong | 21:18 |
tmckay | alazarev, lots of thinking out loud on your CR :) | 21:19 |
tmckay | my last comment (just posted) I think might make the most sense | 21:19 |
tmckay | maybe we just need placeholder replacement calls in the data source resolution routine, instead of just copying the URL | 21:19 |
tmckay | alazarev, line 228 in service/edp/job_utils.py | 21:20 |
tmckay | we would have to pass job_execution id in to that routine, too | 21:21 |
tmckay | that would handle the data source substitution cases. But not manually typed URLs with placeholders. | 21:24 |
tmckay | But, those could be checked for too during processing | 21:25 |
alazarev | tmckay, do you think we need support manually typed URLs? | 21:26 |
alazarev | tmckay, I thought the feature is for datasources only | 21:26 |
tmckay | alazarev, well, I don't know. It seems inconsistent to me not to | 21:27 |
tmckay | the case would be someone running a Java job mulitple times, with an arg giving an output dir | 21:27 |
alazarev | tmckay, for manually types URLs we could type whatever we want, for datasource we can't | 21:27 |
tmckay | alazarev, I guess we could say that if you want placeholders, you must use the data source substitution feature. That's the rule. | 21:28 |
tmckay | alazarev, but it would be the relaunch case. I guess you could change the value and relaunch. Okay, I can accept that, sure. | 21:28 |
alazarev | tmckay, e.g. we could add %DATASOURCE_ID% var that will not have sense without datasource, also we could add %DATASOURCE_TYPE%, etc. | 21:29 |
tmckay | so, manual is not supported. You can do that even with a Java job by using data_source substitution, so kay | 21:29 |
tmckay | okay | 21:29 |
*** tnovacik_ has quit IRC | 21:29 | |
tmckay | alazarev, maybe we should change the syntax for data source references to match your placeholders | 21:30 |
alazarev | tmckay, why do you think that updating job_execution in engine is bad? | 21:30 |
tmckay | It seemed like good policy to have a single point of update, so that when working on code in the job_manager the developer could be sure that it had not changed. I think it makes setting status, etc, less error-prone | 21:31 |
tmckay | alazarev, it doesn't have to be set in stone, if there is a good case not to, but I think it helps in sanely managing job status, etc | 21:33 |
alazarev | tmckay, we don't have such policy for other objects | 21:34 |
alazarev | tmckay, cluster status is changed in many places | 21:34 |
alazarev | tmckay, and having long list in return statement looks even worse for me | 21:35 |
alazarev | tmckay, datasources are not supported in spark, right? Only manual URLs | 21:37 |
tmckay | alazarev, using the data source reference substitution mechanism, they are | 21:39 |
tmckay | this is new | 21:39 |
tmckay | so you reference one by uuid in the arg list and turn substitution on | 21:40 |
tmckay | (or by name, with datasource://name I think) | 21:40 |
alazarev | tmckay, and URL will be added to configs... and now I dont | 21:40 |
alazarev | tmckay, and URL will be added to configs... and now I don't update placeholder... right? | 21:40 |
tmckay | right. | 21:41 |
tmckay | but I think it can be fixed near line 228 of job_utils, easily | 21:41 |
alazarev | I update it later, but value in config will still contain placeholder | 21:41 |
tmckay | right | 21:41 |
alazarev | and to fix that we need 1. all info to make replacemnt 2. way to return generated URL | 21:43 |
tmckay | alazarev, maybe your're right about job_execution. For status updates, it seemed better to do it in the job_manger, but for other fields, maybe it doesn't matter. It seemed unnecessary to have each implementation of cancel_job() for instance do the status update. | 21:43 |
tmckay | alazarev, I think you have most of #1. I think all you need is the job_execution id which can be passed in, and the url generation routine is already in the same file, isn't it? | 21:44 |
alazarev | tmckay, yeap, looks so | 21:45 |
tmckay | datasource is already retrieved from database, so you have that too | 21:45 |
tmckay | oh, it url constructor takes the whole job_exeuction but that's okay. It can take an id, or the data source reference routine can just take job_execution | 21:46 |
alazarev | with new ability to reference from config... is it possible that the same datasource referenced twice? | 21:47 |
tmckay | yes | 21:47 |
alazarev | tmckay, not good :) | 21:47 |
alazarev | tmckay, is it Ok to have the same URL for all duplicated? | 21:48 |
tmckay | heh. It didn't matter for my case. But, we could add a cache to that routine. | 21:48 |
tmckay | hmmm .... interesting case. | 21:49 |
alazarev | tmckay, because I return id->URL dict as result | 21:50 |
*** ViswaV has quit IRC | 21:50 | |
tmckay | we don't know what an app is going to do with them ... do we make it illegal? not sure | 21:50 |
tmckay | I could see inputs being passed multiple times, maybe. But outputs ... probably not | 21:51 |
tmckay | the trouble is we have no idea how an app is written | 21:51 |
*** ViswaV has joined #openstack-sahara | 21:52 | |
*** vgridnev_ has quit IRC | 21:53 | |
tmckay | alazarev, what if resolve_data_source_references() built a dictionary as it went, and looked up references in the dict? And then returned it? | 21:53 |
alazarev | tmckay, this is exactly what I was thinking about | 21:54 |
tmckay | That way, all duplicate references in job_configs would be the same, and if input_source or output_source referenced them too, they would also be the same | 21:54 |
alazarev | tmckay, exactly | 21:54 |
tmckay | ^^ this last one is a weird case, which hopefully will get better with egafford's job arg mapping spec | 21:54 |
tmckay | I don't like fixed data sources for mapreduce jobs, for example | 21:55 |
elmiko | wouldn't that dict need to be saved somehow in case of process restart? | 21:55 |
tmckay | alazarev, as long as we are consistent, it is up to the user to write a good job | 21:55 |
alazarev | elmiko, it will be saved in job_execution | 21:55 |
elmiko | alazarev: ack, thanks | 21:55 |
tmckay | elmiko, ack. alazarev, more argument for update as soon as possible. I remove my objection :) | 21:56 |
tmckay | Sahara is becoming powerful, and making my head hurt | 21:56 |
openstackgerrit | TIngting Bao proposed openstack/sahara: Remove unused field in job_execution table https://review.openstack.org/158964 | 21:56 |
elmiko | tmckay: lol | 21:57 |
tmckay | alazarev, so by adding these changes, Spark would automatically be fixed up. | 21:58 |
alazarev | tmckay, yeap | 21:59 |
tmckay | nothing else to do, I believe | 21:59 |
tmckay | hmm, except for the job_execution update call | 21:59 |
egafford | tmckay: Soon; soon (re: job arg mapping spec.) | 22:01 |
*** crobertsrh is now known as _crobertsrh | 22:01 | |
alazarev | tmckay, shouldn't spark be able to work with external hdfs? why this code oozie specific? | 22:02 |
tmckay | alazarev, you mean the configure cluster for hdfs code? Hmm. Maybe you're right | 22:04 |
tmckay | Never tried it | 22:04 |
tmckay | alazarev, yes, I think you're right. Oversight. | 22:07 |
tmckay | I think it was missed because of the lack of data sources | 22:08 |
tmckay | And it brings up a good point, too. If you run a java job with url args that reference an external hdfs, this could would not run either | 22:09 |
tmckay | "this code" | 22:10 |
tmckay | it would only work if you referenced data sources | 22:10 |
tmckay | alazarev, separate bug? | 22:15 |
alazarev | tmckay, definitely | 22:16 |
alazarev | tmckay, it looks that resolve_data_source_references should handle all that stuff | 22:17 |
tmckay | alazarev, I think so. If we add the h.configure_cluster_for_hdfs() call to spark in another CR, data_sources for external hdfs referenced in job_configs will be caught. Only one thing left: | 22:19 |
tmckay | manual URLs again. For manually typed URLs referencing external hdfs, we won't catch them. Mostly a Java and Spark case. | 22:20 |
tmckay | It might be possible to check for those in resolve, or do another pass. | 22:21 |
alazarev | tmckay, we can add configure_cluster_for_hdfs to resolve_data_source_references | 22:21 |
alazarev | the same lines as in my patch :) | 22:22 |
tmckay | alazarev, seems like a separate function to me. One is dealing with fixing up values in job_exeuction, one is modifying cluster config | 22:24 |
alazarev | tmckay, but you need to return list of URLs from configs | 22:25 |
tmckay | yeah, that's the other option, another return value | 22:26 |
tmckay | or another pass, but that's inefficient | 22:26 |
tmckay | Tradeoffs, I'm okay with it either way | 22:26 |
tmckay | alazarev, I'll add a bug for external hdfs support for Spark (if you did not already) | 22:28 |
alazarev | tmckay, I didn't | 22:29 |
alazarev | tmckay, please also add bug for hdfs in configs for oozie | 22:29 |
tmckay | okay, will do | 22:29 |
alazarev | tmckay, hdfs for spark looks more like bp | 22:30 |
tmckay | yeah, unintentionally missed feature | 22:30 |
openstackgerrit | Andrew Lazarev proposed openstack/sahara-specs: Two step scaling with Heat engine https://review.openstack.org/159278 | 22:41 |
tmckay | https://blueprints.launchpad.net/sahara/+spec/edp-spark-external-hdfs | 22:53 |
tmckay | https://bugs.launchpad.net/sahara/+bug/1425731 | 22:53 |
openstack | Launchpad bug 1425731 in Sahara "[EDP][Oozie] Configuration of cluster for external hdfs missed for URLs in job_configs" [Undecided,New] | 22:53 |
tmckay | alazarev, fyi, thanks for noticing ^^ | 22:53 |
*** tmckay is now known as tmckay_bbl | 22:54 | |
*** ViswaV has quit IRC | 22:54 | |
openstackgerrit | Andrew Lazarev proposed openstack/sahara-specs: Use trusts for cluster creation and scaling https://review.openstack.org/159251 | 22:55 |
*** ViswaV has joined #openstack-sahara | 22:59 | |
*** egafford has quit IRC | 23:00 | |
*** ViswaV has quit IRC | 23:04 | |
*** ViswaV has joined #openstack-sahara | 23:04 | |
*** hdd has quit IRC | 23:22 | |
*** hdd has joined #openstack-sahara | 23:28 | |
*** witlessb has quit IRC | 23:37 | |
*** macjack has joined #openstack-sahara | 23:42 | |
*** chlong has quit IRC | 23:43 | |
*** chlong_ has quit IRC | 23:44 | |
*** chlong has joined #openstack-sahara | 23:48 | |
*** macjack has quit IRC | 23:48 | |
openstackgerrit | TIngting Bao proposed openstack/sahara: Remove unused field in job_execution table https://review.openstack.org/158964 | 23:49 |
*** macjack has joined #openstack-sahara | 23:49 | |
*** hdd has quit IRC | 23:55 | |
openstackgerrit | Andrew Lazarev proposed openstack/sahara: Implemented support of placeholders in datasource URLs https://review.openstack.org/158909 | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!