| *** tellesnobrega_ has joined #openstack-sahara | 04:42 | |
| *** tellesnobrega has quit IRC | 04:45 | |
| *** rcernin has quit IRC | 06:58 | |
| *** pcaruana has joined #openstack-sahara | 07:42 | |
| *** tosky has joined #openstack-sahara | 08:37 | |
| *** tellesnobrega_ is now known as tellesnobrega | 10:32 | |
| tellesnobrega | tosky, hi | 10:36 |
|---|---|---|
| tellesnobrega | might be faster to discuss the patch here | 10:37 |
| tellesnobrega | thanks for the review | 10:37 |
| tellesnobrega | I'm cleaning my local venv so I can see the errors we are seeing on the gate locally | 10:37 |
| tosky | yep | 10:47 |
| tellesnobrega | funny enough | 10:51 |
| tellesnobrega | even after cleaning tox | 10:51 |
| tellesnobrega | unit tests are all passing | 10:51 |
| tosky | tellesnobrega: clean your .pyc files | 10:55 |
| tellesnobrega | will do | 10:56 |
| *** tellesnobrega has quit IRC | 10:58 | |
| *** tellesnobrega has joined #openstack-sahara | 10:59 | |
| tellesnobrega | regarding the spark errors | 11:05 |
| tellesnobrega | now I remember what is going on | 11:05 |
| tellesnobrega | do you think I can move those tests to the plugin? | 11:05 |
| tosky | you should :) | 11:07 |
| tosky | for sure they must not live into sahara.git | 11:07 |
| tosky | because they can't work there | 11:07 |
| tellesnobrega | yes | 11:07 |
| tosky | of course if it makes sense to have them in the test plugin, sure | 11:07 |
| tosky | s/test/fake/ | 11:07 |
| tosky | maybe it's not possible to submit them right now because we need the basic jobs for the plugins | 11:08 |
| tosky | and we can do it next week | 11:08 |
| tellesnobrega | sure | 11:08 |
| tellesnobrega | I'm basically removing sahara/tests/unit/service/edp/spark folder | 11:09 |
| tellesnobrega | and later I will try to make it work on the spark plugin | 11:10 |
| tellesnobrega | tosky, tests passed after deleting spark tests | 11:12 |
| tosky | not suprised :) | 11:14 |
| tosky | on a related news, the wildcards for notification are not working | 11:43 |
| tellesnobrega | on the plugins repo? | 11:43 |
| tosky | everywhere; I switched from a list of repositories (sahara, sahara-tests, etc) to a regexp (sahara.*) but it's not working | 11:44 |
| tosky | the change happened in the review that drove the import | 11:44 |
| tellesnobrega | I see | 11:46 |
| tosky | pinged AJeager | 11:47 |
| tosky | AJaeger | 11:47 |
| tellesnobrega | where? openstack-infra? | 11:48 |
| tosky | yes | 11:48 |
| tellesnobrega | simple malformation on the regex | 12:07 |
| tellesnobrega | tosky, can you check the documentation patch I wrote for the ambari plugin? | 12:29 |
| tosky | sure | 13:11 |
| tellesnobrega | thanks | 13:11 |
| *** zigo has joined #openstack-sahara | 13:28 | |
| tosky | tellesnobrega: done (basically, it was a change for -vanilla, not -ambari); I also pushed few basic changes for all 6 plugins to add .gitreview and basic jobs | 13:31 |
| tellesnobrega | tosky, thanks I will review it now | 13:37 |
| tellesnobrega | how do I configure the plugins repo for release notes? | 13:37 |
| tosky | the basic is still there, there is a releasenotes directory, but it needs to be cleaned | 13:40 |
| tosky | and when it's cleaned you can probably add the releasenotes job to each .zuul.yaml | 13:40 |
| tellesnobrega | sure | 13:41 |
| tellesnobrega | I will do that now | 13:41 |
| tellesnobrega | I'm approving all those patches right away | 13:43 |
| tosky | I'd suggest a unique review which fixes releasenotes, README.rst and documentation building (and re-adds the related jobs) | 13:43 |
| tellesnobrega | sure | 13:46 |
| tellesnobrega | will do | 13:46 |
| tellesnobrega | I'm approving your patches, and writing my changes on top of that | 13:46 |
| tosky | I just discovered that the gerrit search accepts regexp to; so I updated my long search and shortened it using project:^openstack/sahara.* | 13:50 |
| tellesnobrega | nice | 13:53 |
| tellesnobrega | tosky, should I update releasenotes/source/conf.py and set project to openstack/sahara-plugin-* | 14:07 |
| tellesnobrega | ? | 14:07 |
| tosky | probably yes | 14:08 |
| tosky | I mean, you should notice when you test it locally with tox -e releasenotes :) | 14:08 |
| tellesnobrega | tosky, the releasenotes jobs is this one - release-notes-jobs-python3? | 14:14 |
| tosky | tellesnobrega: that's the template, yes | 14:15 |
| tellesnobrega | do I need to add something else? | 14:16 |
| tosky | tellesnobrega: you forgot the .gitreview patch for sahara-plugin-ambari, which is a bit older (I sent it last night) | 14:16 |
| tosky | re releasenotes: apart from that job, I don't think so | 14:16 |
| tosky | you will notice when you send the patch | 14:16 |
| tellesnobrega | ok | 14:16 |
| tellesnobrega | I think what might be wrong with fake plugin | 14:50 |
| tellesnobrega | tosky, there is one unit test that checks edp without oozie, but we don't have oozie on fake | 14:55 |
| tellesnobrega | I can simply remove that test, but not sure how bad that is | 14:55 |
| tellesnobrega | there were some tests that used vanilla that I had to switch to fake, and for that I changed a validate_job_execution to get it to work | 14:57 |
| tellesnobrega | and it checks for oozie | 14:57 |
| tosky | so either remove the test or implement a fake oozie on fake? | 14:57 |
| tellesnobrega | if I remove the oozie check on the validate_job_execution and the test I think it will pass | 14:57 |
| tellesnobrega | or I can implement oozie on fake for sure | 14:58 |
| tosky | if you implement oozie on fake, you can send it as patch on the current sahara; it's something that will need to be done at some point anyway iirc | 15:00 |
| tellesnobrega | ok | 15:01 |
| tellesnobrega | I will take a look | 15:01 |
| tellesnobrega | tosky, the gettext file you mentioned on the review is the ones under locale?? the releasenotes.po files? | 15:14 |
| tellesnobrega | tosky, also, when you say implement oozie on fake, is it just a fake oozie, or should we actually start oozie there? like it is done on Vanilla Plugin? | 15:20 |
| tosky | yes, thos po files | 15:31 |
| tosky | I suspect that everything in the fake plugin is fake, but I didn't check | 15:31 |
| tosky | like a big mock | 15:31 |
| tellesnobrega | ok | 15:34 |
| *** pcaruana has quit IRC | 16:20 | |
| tellesnobrega | tosky, can I refer to a document on sahara from sahara-plugin-ambari? | 16:58 |
| tosky | tellesnobrega: if you use the generated documentation, so the https:// URL, it's not different from any other link | 16:58 |
| tellesnobrega | For more information about building image, refer to :doc:`building-guest-images`. | 16:59 |
| tellesnobrega | I'm referring to this part of the documentation | 17:00 |
| tosky | you can change it to an external link, like http://git.openstack.org/cgit/openstack/sahara/commit/doc?id=39e7c2d3200b2e2895650ff28e73ee49eb4b369f | 17:05 |
| tellesnobrega | oh | 17:05 |
| tellesnobrega | nice | 17:06 |
| tosky | this feature: https://docs.openstack.org/openstackdocstheme/latest/#external-link-helper | 17:06 |
| tellesnobrega | tosky, documentation is fixed | 17:14 |
| tellesnobrega | can you check the patch | 17:14 |
| tellesnobrega | once you give me the OK I will write the patch to the other plugins | 17:15 |
| tosky | tellesnobrega: but you didn't use the external link helper, it's a "normal" link | 17:16 |
| tosky | also, the documentation job should be readded and probably doc/source/conf.py requires some fixes | 17:17 |
| tosky | well, created as new | 17:17 |
| tosky | tellesnobrega: can I send a new version of the patch? | 17:29 |
| tellesnobrega | tosky, sure | 17:31 |
| tellesnobrega | got the external link working | 17:32 |
| tellesnobrega | but please send the patch | 17:32 |
| tosky | done, please check if anything seems in order | 17:34 |
| tosky | I need to go out for a while, but probably you will find some new issue and upload a new patch :) | 17:34 |
| tellesnobrega | thanks | 17:35 |
| tosky | I reverted to numerical ID for the projects into conf.py because the parser does not seem to work with non-numerical IDs | 17:35 |
| tosky | so the link to the bug reporting page points to launchpad and not storyboard if it's an alphanumerical string | 17:35 |
| tosky | or maybe not, but now it's working | 17:37 |
| tellesnobrega | awesome | 17:37 |
| tosky | I also added the doc job | 17:37 |
| tosky | so it should be clear if it's working or not | 17:37 |
| tellesnobrega | awesome | 17:37 |
| * tosky bbl | 17:37 | |
| tellesnobrega | if it works I will copy to others as well | 17:38 |
| *** tmckay has joined #openstack-sahara | 18:48 | |
| *** tmckay has left #openstack-sahara | 18:49 | |
| *** tosky has quit IRC | 20:49 | |
| *** rcernin has joined #openstack-sahara | 22:53 | |
| *** tosky has joined #openstack-sahara | 23:01 | |
| tosky | tellesnobrega: almost there (apart from -mapr) | 23:07 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!