*** bobh has joined #openstack-sdks | 00:14 | |
*** bobh has quit IRC | 01:02 | |
*** bobh has joined #openstack-sdks | 01:09 | |
*** chenyb4 has joined #openstack-sdks | 02:08 | |
*** dayou_ has joined #openstack-sdks | 02:44 | |
*** dayou_ has quit IRC | 02:50 | |
*** dhellmann has quit IRC | 02:55 | |
*** dhellmann has joined #openstack-sdks | 03:01 | |
*** d0ugal has quit IRC | 03:11 | |
*** charz has joined #openstack-sdks | 03:13 | |
openstackgerrit | Mike Chen proposed openstack/python-openstackclient master: Compute: Add description support for server https://review.openstack.org/568549 | 03:36 |
---|---|---|
*** d0ugal has joined #openstack-sdks | 03:39 | |
*** bobh has quit IRC | 03:48 | |
*** d0ugal has quit IRC | 04:00 | |
*** d0ugal has joined #openstack-sdks | 04:11 | |
*** d0ugal has quit IRC | 04:17 | |
*** Luzi has joined #openstack-sdks | 06:50 | |
*** maxbab has joined #openstack-sdks | 07:23 | |
*** noama has joined #openstack-sdks | 07:35 | |
*** gkadam has joined #openstack-sdks | 07:44 | |
*** d0ugal has joined #openstack-sdks | 07:49 | |
*** slaweq has joined #openstack-sdks | 07:53 | |
*** slaweq has quit IRC | 07:54 | |
*** d0ugal has quit IRC | 07:56 | |
*** slaweq has joined #openstack-sdks | 07:59 | |
*** slaweq has quit IRC | 07:59 | |
*** d0ugal has joined #openstack-sdks | 08:00 | |
*** slaweq has joined #openstack-sdks | 08:11 | |
*** gkadam has quit IRC | 08:22 | |
*** gkadam has joined #openstack-sdks | 08:22 | |
*** maxbab has quit IRC | 08:29 | |
*** d0ugal has quit IRC | 08:32 | |
*** gtema has joined #openstack-sdks | 08:38 | |
*** d0ugal has joined #openstack-sdks | 08:39 | |
*** e0ne has joined #openstack-sdks | 08:45 | |
*** gkadam has quit IRC | 08:53 | |
*** gkadam has joined #openstack-sdks | 08:55 | |
*** jpena|off is now known as jpena | 08:57 | |
*** d0ugal has quit IRC | 09:27 | |
*** d0ugal has joined #openstack-sdks | 09:54 | |
*** slaweq has quit IRC | 09:56 | |
*** cdent has joined #openstack-sdks | 09:57 | |
*** slaweq has joined #openstack-sdks | 09:59 | |
*** slaweq has quit IRC | 10:25 | |
*** slaweq has joined #openstack-sdks | 10:27 | |
*** dtantsur|afk is now known as dtantsur | 10:35 | |
*** chenyb4 has quit IRC | 10:51 | |
*** rcarrillocruz has joined #openstack-sdks | 11:15 | |
*** zigo has quit IRC | 11:17 | |
*** e0ne has quit IRC | 11:25 | |
*** e0ne has joined #openstack-sdks | 11:34 | |
*** bobh has joined #openstack-sdks | 12:13 | |
*** elmiko has joined #openstack-sdks | 12:20 | |
*** edleafe- has joined #openstack-sdks | 12:29 | |
*** edleafe- is now known as edleafe | 12:29 | |
*** bobh has quit IRC | 12:51 | |
*** e0ne has quit IRC | 12:58 | |
*** jpena is now known as jpena|lunch | 13:03 | |
*** cdent has quit IRC | 13:03 | |
nmimi | Hi all again! | 13:04 |
nmimi | I have one qustion, if someone knows the answer.... | 13:04 |
nmimi | I try to create a server with SDK with the following attributes: | 13:04 |
nmimi | instance = self.conn.compute.create_server(name=vm_name,image_id=image.id,flavor_id=flavor_obj.id,networks=[{"uuid": network.id}], key_name=keypair.name) | 13:04 |
nmimi | When the server is created i noticed that although i haven't set security groups attribute, "Default" sec_group is being added to the server: | 13:04 |
nmimi | security_groups | name='default' | 13:04 |
nmimi | Is there a way to create the server without security groups (even "Default")? | 13:05 |
dtantsur | nmimi: the API docs say "If you omit this attribute, the API creates the server in the default security group" | 13:09 |
dtantsur | so it's not even openstacksdk doing, I suspect | 13:09 |
*** d0ugal has quit IRC | 13:09 | |
*** e0ne has joined #openstack-sdks | 13:11 | |
*** zigo has joined #openstack-sdks | 13:12 | |
*** e0ne has quit IRC | 13:17 | |
*** e0ne has joined #openstack-sdks | 13:19 | |
*** mriedem has joined #openstack-sdks | 13:19 | |
nmimi | dtantsur: Thanks for the answer! | 13:21 |
*** elbragstad is now known as lbragstad | 13:22 | |
*** e0ne has quit IRC | 13:24 | |
*** bobh has joined #openstack-sdks | 13:27 | |
mordred | yeah, that is a very true statement | 13:27 |
*** e0ne has joined #openstack-sdks | 13:30 | |
frickler | nmimi: iiuc the only possible workaround for your issue is to create a port in your network beforehand and pass that to the "create_server" call: "Requested security groups are not applied to pre-existing ports." | 13:46 |
*** jpena|lunch is now known as jpena|mtg | 13:55 | |
nmimi | frickler: i will try it, thanks! | 13:57 |
*** jpich has joined #openstack-sdks | 13:58 | |
mordred | frickler: ooh. that's a workaround we should maybe put into create_server | 14:01 |
mordred | like - make security_groups=False create a port and pass it in | 14:01 |
mordred | nmimi: also - you might want to try self.conn.create_server instead of self.conn.compute.create_server - it's a bit more complete, and its api is more stable | 14:03 |
smcginnis | There are probably those that expect that behavior, so if we did a workaround in create_server we would probably have to make it a --no-security-group arg or something. | 14:03 |
frickler | mordred: I don't think that we want to do that in the sdk, because you will not be able to clean up properly on deleting the server | 14:03 |
mordred | frickler: hrm. that is a good point | 14:06 |
*** cdent has joined #openstack-sdks | 14:20 | |
openstackgerrit | Daniel Speichert proposed openstack/openstacksdk master: Added basic CRUD functionality around Host Aggregates https://review.openstack.org/609416 | 14:37 |
openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: implement block-storage backup resource https://review.openstack.org/591445 | 14:43 |
*** gtema has quit IRC | 14:43 | |
*** jpena|mtg is now known as jpena | 14:59 | |
*** Luzi has quit IRC | 15:04 | |
*** jpich has quit IRC | 15:09 | |
*** wouterdb has joined #openstack-sdks | 15:09 | |
*** irclogbot_2 has joined #openstack-sdks | 15:10 | |
*** dtantsur is now known as dtantsur|brb | 15:10 | |
wouterdb | hi all, I'm getting started with openstacksdk. I wonder: how do I close the connection? each connection maintains a thread pool and I'm opening a LOT of connections. | 15:11 |
wouterdb | I couldn't find anything in the documentation or the source and I can't figure out the search function on the bug tracker | 15:11 |
mordred | wouterdb: I don't know that we have a close function - but the connection opening a threadpool piece will be going away soon, so that issue should solve itself | 15:13 |
mordred | wouterdb: that said- any reason you're opening a lot of connections instead of sharing a connection? you should be able to use one connection from many threads | 15:14 |
mordred | (we do that in nodepool at pretty large scale - it's built to handle that use case) | 15:14 |
mordred | wouterdb: for reference- this: https://review.openstack.org/#/c/604926/ is the upcoming patch to remove the internal creation of thread pools - as soon as I write some tests for the keystoneauth-side replacement we should be able to get that forward - the extra threads spawned are annoying even in the shared connection usecase, so using the existing parallelism of the calling context to handle | 15:17 |
mordred | concurrency should be an improvement for everybody | 15:17 |
*** cdent has quit IRC | 15:22 | |
*** d0ugal has joined #openstack-sdks | 15:24 | |
*** d0ugal has quit IRC | 15:37 | |
wouterdb | mordred: I'm writing code that logs in to the same openstack using different users | 15:38 |
*** d0ugal has joined #openstack-sdks | 15:38 | |
mordred | wouterdb: ah - gotcha. that makes sense | 15:48 |
*** cdent has joined #openstack-sdks | 15:48 | |
mordred | wouterdb: well, this will get better in a few weeks. in the mean time, if it's killing you, you can pin back to < 0.18.0 | 15:50 |
mordred | the thread-splosion was introduced in 0.18.0 - and should go away hopefully by 0.20.0 | 15:50 |
wouterdb | ok, can I find the docs for that version somewhere? | 15:55 |
wouterdb | I try connection.identity.find_domain(domain) on the 0.17.2 and I get AttributeError: 'Proxy' object has no attribute 'find_domain' | 15:57 |
mordred | wouterdb: that sounds like you're getting the v2 version of the proxy - find_domain has been on the v3 proxy object since 2015 | 16:00 |
mordred | wouterdb: you might want to set OS_IDENTIY_API_VERSION=3 - or in your clouds.yaml set identity_api_version: 3 - up until 0.18.0 this was all driven by config (0.18 switch to properly using discovery) | 16:01 |
mordred | (I'm sorry this is wonky for you right now) | 16:01 |
*** d0ugal has quit IRC | 16:02 | |
wouterdb | It is a bit unfortunate, I've been working at porting code from the old client to openstacksdk for a week, under the assumption they don't have a close function because they don't really consume any system resources. But now it turns out that they do. So I really can't use it, as I can't properly dispose of the threadpools (even in the 604926 patch set, there still is a thread pool and no close). | 16:08 |
wouterdb | 16:09 | |
wouterdb | I really liked th idea of the library, to have one (rather nice) interface, but it all seems a bit risky now. | 16:10 |
mordred | wouterdb: which threadpool is still there in 604926 ? | 16:14 |
mordred | wouterdb: also - we could add a close method for you pretty easily if that would help | 16:14 |
*** dtantsur|brb is now known as dtantsur | 16:16 | |
*** finucannot is now known as stephenfin | 16:17 | |
wouterdb | @mordred: close method would be great, threadpool is at https://review.openstack.org/#/c/604926/12/openstack/cloud/openstackcloud.py line 7848 | 16:19 |
wouterdb | mordred: thanks for your help, I'll consider my options | 16:19 |
kmalloc | mordred: looking closely at the rate limit stuff in ksa today | 16:20 |
kmalloc | mordred: i think the code looks ok, but i want to run through it in depth | 16:21 |
kmalloc | make sure there are no surprises | 16:21 |
kmalloc | if it's good i think we should land/release this week | 16:21 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency https://review.openstack.org/604926 | 16:22 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add close method to shutdown threadpool https://review.openstack.org/613976 | 16:22 |
mordred | wouterdb: ^^ that should get you a close() that will also work with the new code | 16:22 |
mordred | wouterdb: also - that threadpool will only exist if you happen to upload swift LargeObjects | 16:23 |
*** wouterdb has quit IRC | 16:24 | |
mordred | aww. we lost wouterdb | 16:24 |
mordred | kmalloc: sweet - I need to write tests, but I think we should be able to do that within a week | 16:25 |
kmalloc | yeah. | 16:26 |
kmalloc | i expect i'll be able to score +1 (+2 tentatively, pending tests) or -1 with reasons soon | 16:26 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Replace TaskManager with a keystoneauth concurrency https://review.openstack.org/604926 | 16:32 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Make Connection a context manager https://review.openstack.org/613978 | 16:32 |
*** e0ne has quit IRC | 16:36 | |
*** gkadam has quit IRC | 16:52 | |
*** d0ugal has joined #openstack-sdks | 17:04 | |
*** d0ugal has quit IRC | 17:12 | |
*** markvoelker has joined #openstack-sdks | 17:13 | |
*** noama has quit IRC | 17:45 | |
*** jpena is now known as jpena|off | 18:07 | |
openstackgerrit | Daniel Speichert proposed openstack/openstacksdk master: Added image properties to Image class https://review.openstack.org/544544 | 18:38 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use sdk for list_servers https://review.openstack.org/530770 | 18:50 |
*** dtantsur is now known as dtantsur|afk | 19:11 | |
openstackgerrit | Merged openstack/openstacksdk master: Call pre/post run task calls from TaskManager.submit_task() https://review.openstack.org/613503 | 19:47 |
openstackgerrit | Merged openstack/openstacksdk master: Add doc depends to tox releasenotes environment https://review.openstack.org/613504 | 19:49 |
*** mrhillsman is now known as mrhillsman_lunch | 19:53 | |
*** lbragstad has quit IRC | 20:03 | |
*** lbragstad has joined #openstack-sdks | 20:18 | |
smcginnis | mordred, dtroyer: Any plans for a python-openstackclient release? I'd like to get https://review.openstack.org/609473 out there. | 20:42 |
smcginnis | Maybe a last 3.x release before merging those backwards incompatible patches I have out there? | 20:42 |
dtroyer | smcginnis: we can do a release… as far as switching to 4.x that's not happening quickly unless someone picks up the heavy lifting of all of the ksa & sdk-related auth stuff. there is an osc4 feature branch… | 20:44 |
smcginnis | dtroyer: OK, that's fine if those sit out there awhile. Not really time critical on that. | 20:45 |
smcginnis | dtroyer: Are there any high level docs on what's needed with the auth stuff? Not sure I would have time for something like that, but I might be willing to poke at it a bit if there's not too steep of a curve to get going. | 20:47 |
*** mrhillsman_lunch is now known as mrhillsman | 21:04 | |
*** bobh has quit IRC | 21:08 | |
*** bobh has joined #openstack-sdks | 21:10 | |
*** bobh has quit IRC | 21:15 | |
mordred | smcginnis, dtroyer: I've been planning on jumping in on the ksa/sdk stuff in the feature branch soonish | 21:21 |
smcginnis | mordred: Great. I can't commit to anything, but let me know if there's any way I can help with that. | 21:21 |
mordred | will do | 21:22 |
*** e0ne has joined #openstack-sdks | 21:29 | |
*** e0ne has quit IRC | 21:36 | |
*** mriedem is now known as mriedem_away | 21:42 | |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix latest flake8 issues https://review.openstack.org/614038 | 21:44 |
*** bobh has joined #openstack-sdks | 21:49 | |
*** bobh has quit IRC | 21:55 | |
*** bobh has joined #openstack-sdks | 21:57 | |
*** ml has left #openstack-sdks | 22:04 | |
*** cdent has quit IRC | 22:13 | |
*** bobh has quit IRC | 22:16 | |
*** eandersson has joined #openstack-sdks | 22:36 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!