| *** mriedem_away has quit IRC | 00:15 | |
| openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: Modify the help message for 'registered limit set' https://review.openstack.org/609985 | 01:57 |
|---|---|---|
| *** rcarrillocruz has quit IRC | 02:43 | |
| *** gildub has joined #openstack-sdks | 04:12 | |
| openstackgerrit | Ian Wienand proposed openstack/openstacksdk master: Make delete_unattached_floating_ips return a count https://review.openstack.org/614075 | 04:58 |
| openstackgerrit | Ian Wienand proposed openstack/openstacksdk master: Make delete_unattached_floating_ips return a count https://review.openstack.org/614075 | 05:06 |
| *** d0ugal has joined #openstack-sdks | 05:18 | |
| *** d0ugal has quit IRC | 05:30 | |
| *** d0ugal has joined #openstack-sdks | 05:44 | |
| adriant | mordred: I'm either hitting a really weird bug, or something stupid, but I can't use the SDK to list servers against our cloud anymore :/ | 05:52 |
| adriant | we are running nova still in Kilo though, so it's always possible that something there is a problem, but it's not that it errors, I just get back an empty list | 05:53 |
| adriant | oh | 05:54 |
| adriant | what | 05:54 |
| adriant | it's calling the wrong region?! | 05:54 |
| adriant | ok, nvm, found my issue | 05:55 |
| adriant | yeah, nvm this code just doesn't make sese | 05:58 |
| adriant | sense* | 05:58 |
| * adriant is an idiot | 05:59 | |
| *** gildub has quit IRC | 06:05 | |
| *** gildub has joined #openstack-sdks | 06:12 | |
| *** mnaser has quit IRC | 06:16 | |
| *** mnaser has joined #openstack-sdks | 06:17 | |
| *** slaweq has quit IRC | 06:40 | |
| *** tonyb has quit IRC | 06:50 | |
| *** gildub has quit IRC | 06:51 | |
| *** Luzi has joined #openstack-sdks | 06:52 | |
| *** d0ugal has quit IRC | 07:01 | |
| *** gildub has joined #openstack-sdks | 07:02 | |
| *** slaweq has joined #openstack-sdks | 07:49 | |
| *** gkadam has joined #openstack-sdks | 08:05 | |
| *** jpich has joined #openstack-sdks | 08:26 | |
| adriant | mordred: well after being and idiot, there is now a new version of my silly interpreter tool, and i've updated the docs to mostly ignore that the per service client libraries exist. | 08:40 |
| *** e0ne has joined #openstack-sdks | 08:41 | |
| *** gtema has joined #openstack-sdks | 08:49 | |
| *** d0ugal has joined #openstack-sdks | 08:50 | |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: implement block-storage backup resource https://review.openstack.org/591445 | 08:52 |
| *** slaweq has quit IRC | 08:53 | |
| *** jpena|off is now known as jpena | 08:57 | |
| *** d0ugal has quit IRC | 09:05 | |
| *** brtknr has left #openstack-sdks | 09:06 | |
| *** cdent has joined #openstack-sdks | 09:42 | |
| *** slaweq has joined #openstack-sdks | 10:08 | |
| *** ttsiouts has joined #openstack-sdks | 10:22 | |
| *** e0ne has quit IRC | 10:32 | |
| openstackgerrit | wangqiang-bj proposed openstack/keystoneauth master: fix wrong spelling of "unnecessary" https://review.openstack.org/614178 | 10:40 |
| *** cdent has quit IRC | 10:42 | |
| *** e0ne has joined #openstack-sdks | 10:56 | |
| *** dave-mccowan has joined #openstack-sdks | 11:10 | |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: implement block-storage backup resource https://review.openstack.org/591445 | 11:12 |
| *** gkadam has quit IRC | 11:12 | |
| *** cdent has joined #openstack-sdks | 11:13 | |
| *** dtantsur|afk is now known as dtantsur | 11:50 | |
| *** jpena is now known as jpena|lunch | 11:57 | |
| *** gtema has quit IRC | 12:14 | |
| *** ttsiouts has quit IRC | 12:16 | |
| *** e0ne has quit IRC | 12:21 | |
| *** ttsiouts has joined #openstack-sdks | 12:32 | |
| *** cdent has quit IRC | 13:07 | |
| *** e0ne has joined #openstack-sdks | 13:08 | |
| *** jpena|lunch is now known as jpena | 13:12 | |
| *** mriedem has joined #openstack-sdks | 13:13 | |
| *** bobh has joined #openstack-sdks | 13:20 | |
| mordred | adriant: yay! | 13:26 |
| *** cdent has joined #openstack-sdks | 13:27 | |
| *** gildub has quit IRC | 13:29 | |
| *** gildub has joined #openstack-sdks | 13:29 | |
| *** gildub has quit IRC | 13:36 | |
| *** ttsiouts has quit IRC | 13:40 | |
| *** ttsiouts has joined #openstack-sdks | 13:42 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Filter ports in list_ports when batching is in effect https://review.openstack.org/614213 | 13:42 |
| Shrews | mordred: did we remove the old shade func tests in sdk? | 13:48 |
| mordred | Shrews: no - they should still be there in openstack/tests/functional/cloud | 13:48 |
| Shrews | oh yep | 13:48 |
| mordred | Shrews: maybe before we retire we'll have all of that completely integrated | 13:49 |
| Shrews | mordred: can we explore trying to have a func test for that before we merge? i mean, we're really just assuming it works | 13:50 |
| *** gtema has joined #openstack-sdks | 13:50 | |
| Shrews | i might need to setup a devstack again to try to create a port in the down state | 13:51 |
| Shrews | or maybe we could ask someone with actual knowledge of neutron | 13:51 |
| Shrews | hrm, our unit tests don't even test passing filter | 13:53 |
| openstackgerrit | Monty Taylor proposed openstack/cliff master: Don't try to run issubclass on non-classes https://review.openstack.org/614218 | 13:56 |
| mordred | Shrews: oh - totally. let's definitely add some tests | 14:00 |
| openstackgerrit | David Shrewsbury proposed openstack/openstacksdk master: Filter ports in list_ports when batching is in effect https://review.openstack.org/614213 | 14:03 |
| Shrews | mordred: ^^ unit test | 14:03 |
| Shrews | mordred: double check me, but passes locally for me | 14:03 |
| openstackgerrit | Monty Taylor proposed openstack/cliff master: Don't try to run issubclass on non-classes https://review.openstack.org/614218 | 14:05 |
| Shrews | mordred: hrm, no. that passes on master when it shouldn't | 14:05 |
| Shrews | :( | 14:05 |
| *** d0ugal has joined #openstack-sdks | 14:06 | |
| Shrews | so i've done something wrong | 14:06 |
| mordred | Shrews: that test tests that the query returns an unfilted list | 14:11 |
| mordred | mock_neutron_port_list_rep is a list of ports that has non-down ports in it right? | 14:12 |
| Shrews | mordred: it isn't asserting that the uri contains the filter params? | 14:12 |
| Shrews | i thought assert_calls did that | 14:12 |
| Shrews | i wasn't worried so much about the return data as much as i wanted to confirm the uri had any filters we passed | 14:13 |
| mordred | Shrews: oh - i was looking at line 253 | 14:13 |
| mordred | Shrews: I think you need to configure caching | 14:14 |
| mordred | Shrews: because we only skip passing the query string if caching is enabled | 14:14 |
| mordred | (although maybe leave that test to test that non-caching also works) | 14:14 |
| Shrews | ah. do we have an example of that? | 14:15 |
| mordred | looking for one now | 14:15 |
| mordred | Shrews: openstack/tests/unit/cloud/test_caching.py is set up to do servers caching - we could add prts to openstack/tests/unit/fixtures/clouds/clouds_cache.yaml | 14:16 |
| mordred | Shrews: and add a copy of the test you just added but without the query string | 14:16 |
| *** cdent has quit IRC | 14:21 | |
| *** gkadam has joined #openstack-sdks | 14:21 | |
| Shrews | don't you need the query string?? | 14:21 |
| mordred | well - in the caching version we'd expect it to not pass filters on the query string | 14:21 |
| Shrews | oh! b/c we filter ourselves | 14:22 |
| * Shrews is slow | 14:22 | |
| Shrews | mordred: you seem to have a handle on it, feel free to push that PS while I caffeinate more appropriately | 14:23 |
| mordred | Shrews: ok. I'll do that one | 14:24 |
| mordred | Shrews: OH | 14:25 |
| mordred | Shrews: also - re: functional ... | 14:25 |
| mordred | Shrews: when you create a port but it isn't attached to anything - its state is totally DOWN | 14:25 |
| mordred | Shrews: see mock_neutron_port_create_rep in openstack/tests/unit/cloud/test_port.py | 14:26 |
| *** d0ugal has quit IRC | 14:28 | |
| Shrews | oh cool | 14:29 |
| *** e0ne has quit IRC | 14:33 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Filter ports in list_ports when batching is in effect https://review.openstack.org/614213 | 14:35 |
| mordred | Shrews: how's that look? | 14:35 |
| *** e0ne has joined #openstack-sdks | 14:37 | |
| Shrews | mordred: yes, that fails for me on master | 14:40 |
| Shrews | ++ | 14:40 |
| mordred | Shrews: \o/ | 14:40 |
| mordred | slaweq: feel in the mood to review a quick neutron related sdk patch? ^^ | 14:40 |
| mordred | Shrews: I believe this same bug exists for servers and floating ips - followup patch coming | 14:42 |
| Shrews | oh goodie | 14:43 |
| slaweq | mordred: +W (I hope CI will be happy with it too) :) | 14:45 |
| mordred | slaweq: thanks! | 14:45 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Apply list filter fix to servers and floating ips too https://review.openstack.org/614236 | 14:48 |
| mordred | Shrews: ^^ there it is applied to servers and floating ips too | 14:48 |
| *** dtantsur is now known as dtantsur|brb | 14:50 | |
| *** Luzi has quit IRC | 14:52 | |
| Shrews | ossum | 15:02 |
| mordred | Shrews: I put a pause on the 0.19.0 release (which contained the other fix we needed for nodepool) so we can get this in there | 15:02 |
| *** dave-mccowan has quit IRC | 15:03 | |
| Shrews | ++ | 15:04 |
| *** cdent has joined #openstack-sdks | 15:08 | |
| mordred | dtroyer: if you get a sec, could you take a peep at https://review.openstack.org/#/c/614218/ ? | 15:22 |
| *** e0ne has quit IRC | 15:25 | |
| *** Leo_m has joined #openstack-sdks | 15:27 | |
| *** e0ne has joined #openstack-sdks | 15:35 | |
| openstackgerrit | Sean McGinnis proposed openstack/openstacksdk master: Remove setup.py check from pep8 job https://review.openstack.org/614274 | 15:38 |
| mordred | Shrews: if you have a sec, https://review.openstack.org/#/c/613976 and https://review.openstack.org/#/c/613978 are in response to a feedback we got yesterday from wouterdb | 15:43 |
| mordred | Shrews: who had a usecase where he was creating and destroying a ton of Connection objects, and the lack of a close to shutdown underlying threadpool objects was causing a preponderance of threads | 15:43 |
| Shrews | mordred: i totes want a be_awesome() method | 15:45 |
| *** Leo_m has quit IRC | 15:49 | |
| *** Leo_m has joined #openstack-sdks | 15:51 | |
| mordred | Shrews: we should make one | 15:52 |
| mordred | gtema: looking at your story from earlier about caching and wait_for methods ... we really need to do some work in the caching layer | 15:54 |
| gtema | mordred: agree | 15:55 |
| gtema | just spend some time trying to figure out why it suddenly does not work properly | 15:55 |
| gtema | mordred: can I help there? | 15:55 |
| mordred | gtema: almost certainly! I think once we get this task manager updates finished it'll be a good time to work on it | 15:58 |
| gtema | ok | 15:59 |
| gtema | mordred: what about backup support in block-storage (https://review.openstack.org/#/c/591445/) | 16:00 |
| openstackgerrit | Sean McGinnis proposed openstack/os-client-config master: Remove setup.py check from pep8 job https://review.openstack.org/614280 | 16:00 |
| mordred | gtema: "Note that backup restore is not documented in the official API, but is implemented in the cinderclient" | 16:01 |
| mordred | that's so awesome | 16:01 |
| gtema | yes, I was clarifying it - it was a bug promised to be fixed in docs | 16:02 |
| gtema | oh, it is even now fixed - will update commit message | 16:02 |
| openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: implement block-storage backup resource https://review.openstack.org/591445 | 16:04 |
| smcginnis | Which "official API" is Cinder backup not documented in? | 16:04 |
| gtema | backup restore was not documented | 16:04 |
| smcginnis | Where? | 16:04 |
| gtema | https://developer.openstack.org/api-ref/block-storage/v2/index.html?expanded=restore-backup-detail#backups-backups | 16:04 |
| gtema | but now it is documented | 16:05 |
| mordred | \o/ | 16:05 |
| smcginnis | Must have been a really old reference. | 16:05 |
| gtema | from what I remember I was told there was a content error somewhere in sources, so that this method was not shown properly | 16:06 |
| smcginnis | Ah, that could be then. | 16:06 |
| smcginnis | OK, yeah, I fixed that just in August. https://review.openstack.org/#/c/592026/ | 16:07 |
| gtema | yes, I was asking in maillist sometime back in august - my change was for this time forgotten and I rebased it yesterday | 16:08 |
| gtema | mordred: thanks | 16:08 |
| smcginnis | gtema: Cool, thanks! | 16:08 |
| gtema | welcome | 16:09 |
| dtroyer | mordred: +2… there is an isclass() call in OSC that has gone back and forth a time or two, I'm wondering if a similar solution would be appropriate there (without looking before typing of course) | 16:11 |
| *** dave-mccowan has joined #openstack-sdks | 16:23 | |
| *** dtantsur|brb is now known as dtantsur | 16:26 | |
| *** e0ne has quit IRC | 16:30 | |
| *** Leo_m has quit IRC | 16:44 | |
| *** Leo_m has joined #openstack-sdks | 16:45 | |
| *** Leo_m has quit IRC | 16:55 | |
| *** Leo_m has joined #openstack-sdks | 16:56 | |
| *** gkadam has quit IRC | 17:08 | |
| *** jpich has quit IRC | 17:08 | |
| openstackgerrit | Merged openstack/openstacksdk master: Add close method to shutdown threadpool https://review.openstack.org/613976 | 17:13 |
| openstackgerrit | Merged openstack/openstacksdk master: Make Connection a context manager https://review.openstack.org/613978 | 17:13 |
| *** gtema has quit IRC | 17:26 | |
| *** ttsiouts has quit IRC | 17:28 | |
| *** ttsiouts has joined #openstack-sdks | 17:29 | |
| *** gkadam has joined #openstack-sdks | 17:29 | |
| *** ttsiouts has quit IRC | 17:33 | |
| *** gkadam has quit IRC | 17:40 | |
| *** gyroknight_ has joined #openstack-sdks | 17:47 | |
| gyroknight_ | Hi, just wondering if anyone's had trouble with list_servers(all_projects=True) in openstack.connection.Connection? It seems to only list instances belonging to the authenticated user's project, even when the user is an admin | 17:50 |
| gyroknight_ | I can't find any related tasks or stories in the StoryBoard | 17:50 |
| *** bobh has quit IRC | 17:53 | |
| mordred | gyroknight_: I feel like I saw a patch related to that recently | 17:53 |
| mordred | looking | 17:53 |
| gyroknight_ | The servers(all_projects=True) generator in the compute v2 proxy also doesn't seem to work. The generator creation seems to work fine, but if I try to iterate through it, Resource throws an error "openstack.exceptions.InvalidResourceQuery: Invalid query params: all_projects" | 17:54 |
| mordred | oh - maybe not | 17:54 |
| *** bobh has joined #openstack-sdks | 17:55 | |
| mordred | gyroknight_: cool (I mean, not cool, but good to know) - I've gotta run out for a sec, but will investigate in just a little bit | 17:55 |
| gyroknight_ | Thanks | 17:55 |
| *** dtantsur is now known as dtantsur|afk | 17:57 | |
| *** bobh has quit IRC | 17:59 | |
| *** jpena is now known as jpena|off | 18:10 | |
| *** e0ne has joined #openstack-sdks | 18:10 | |
| gyroknight_ | Figured out the compute proxy, seems the documentation is incorrect, it should be all_tenants instead of all_projects | 18:22 |
| gyroknight_ | I'm using the documentation here: https://docs.openstack.org/openstacksdk/latest/user/proxies/compute.html#openstack.compute.v2._proxy.Proxy | 18:23 |
| *** e0ne has quit IRC | 18:25 | |
| *** bobh has joined #openstack-sdks | 18:29 | |
| *** bobh has quit IRC | 18:33 | |
| *** gyroknight_ is now known as gyroknight | 18:40 | |
| *** bobh has joined #openstack-sdks | 18:41 | |
| mordred | gyroknight: we just recently merged a fix for that ... https://review.openstack.org/#/c/540390/ (like, 2 days ago and it'll be in there when we release later today) | 18:56 |
| gyroknight | Awesome, thanks | 18:57 |
| gyroknight | I figured out the workaround with list_servers(filters={'all_tenants': True}) in the meantime, but it'll be nice to have the alias later on | 18:59 |
| mordred | ++ | 19:04 |
| mordred | hrm. list_servers(filters={'all_tenants': True}) works but list_servers(all_projects=True) doesn't work? that's sad making ... | 19:06 |
| mordred | gyroknight: do you have resource caching enabled? | 19:06 |
| gyroknight | Not sure | 19:06 |
| gyroknight | How would I check? | 19:07 |
| mordred | you'd have to do it explicitly by putting a cache: section in a clouds.yaml | 19:08 |
| mordred | so if you weren't intending on it, you are likely not doing it | 19:08 |
| gyroknight | Yeah, don't have one of those | 19:08 |
| mordred | just asking cause we found a bug earlier today with filters not being passed properly when caching was in play | 19:08 |
| mordred | kk. well - I'll see if I can figure out why one form works and the ohter doesn't | 19:09 |
| *** e0ne has joined #openstack-sdks | 19:13 | |
| gyroknight | Interestingly enough, all_projects=True works in get_server(), so maybe it's only isolated to those two occurences? | 19:14 |
| mordred | o_O | 19:21 |
| mordred | that's excessively strange - get_server is built on top of list_server :) | 19:21 |
| openstackgerrit | Merged openstack/openstacksdk master: Filter ports in list_ports when batching is in effect https://review.openstack.org/614213 | 19:41 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Apply list filter fix to servers and floating ips too https://review.openstack.org/614236 | 19:43 |
| *** cdent has quit IRC | 19:56 | |
| *** gildub has joined #openstack-sdks | 20:05 | |
| *** gildub has quit IRC | 20:18 | |
| *** Leo_m has quit IRC | 20:51 | |
| *** bobh has quit IRC | 21:00 | |
| *** gildub has joined #openstack-sdks | 21:13 | |
| openstackgerrit | Merged openstack/openstacksdk master: Remove setup.py check from pep8 job https://review.openstack.org/614274 | 21:13 |
| *** e0ne has quit IRC | 21:18 | |
| *** gyroknight has quit IRC | 21:21 | |
| *** mriedem has quit IRC | 21:30 | |
| *** ttsiouts has joined #openstack-sdks | 21:55 | |
| openstackgerrit | Tony Breeds proposed openstack/cliff master: Removed unused err variable https://review.openstack.org/614359 | 21:57 |
| *** ttsiouts has quit IRC | 22:04 | |
| *** ttsiouts has joined #openstack-sdks | 22:05 | |
| *** ttsiouts has quit IRC | 22:10 | |
| *** e0ne has joined #openstack-sdks | 22:49 | |
| *** tonyb has joined #openstack-sdks | 23:03 | |
| *** e0ne has quit IRC | 23:13 | |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add networks to Limestone vendor https://review.openstack.org/608027 | 23:16 |
| openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add networks to Limestone vendor https://review.openstack.org/608027 | 23:17 |
| *** gildub has quit IRC | 23:32 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!