*** tosky has quit IRC | 00:28 | |
*** enriquetaso has quit IRC | 00:56 | |
*** iurygregory has quit IRC | 01:17 | |
*** dmellado has quit IRC | 01:22 | |
*** dmellado has joined #openstack-sdks | 01:46 | |
*** camelCaser has quit IRC | 03:01 | |
*** ricolin_ has joined #openstack-sdks | 03:01 | |
*** camelCaser has joined #openstack-sdks | 03:02 | |
*** ricolin_ has quit IRC | 03:38 | |
*** ricolin has quit IRC | 04:44 | |
*** evrardjp has quit IRC | 05:35 | |
*** evrardjp has joined #openstack-sdks | 05:35 | |
*** ricolin has joined #openstack-sdks | 05:51 | |
*** sshnaidm|afk is now known as sshnaidm | 07:16 | |
openstackgerrit | Bram Verschueren proposed openstack/openstacksdk master: Add support for additional volume backup options https://review.opendev.org/688353 | 07:17 |
---|---|---|
*** iurygregory has joined #openstack-sdks | 07:29 | |
*** __ministry has quit IRC | 07:57 | |
*** __ministry1 has joined #openstack-sdks | 07:57 | |
*** __ministry1 is now known as __ministry | 07:59 | |
*** slaweq has joined #openstack-sdks | 08:03 | |
*** tkajinam has quit IRC | 08:14 | |
*** tosky has joined #openstack-sdks | 08:28 | |
*** gkadam has joined #openstack-sdks | 08:34 | |
*** gkadam has quit IRC | 08:34 | |
*** ralonsoh has joined #openstack-sdks | 08:47 | |
*** gouthamr has quit IRC | 08:49 | |
*** mgoddard has quit IRC | 08:49 | |
*** dulek has quit IRC | 08:49 | |
*** gouthamr has joined #openstack-sdks | 08:50 | |
*** mgoddard has joined #openstack-sdks | 08:50 | |
*** jpena|off is now known as jpena | 08:52 | |
*** dtantsur|afk is now known as dtantsur | 08:56 | |
*** rpittau|afk is now known as rpittau | 08:58 | |
*** jpich has joined #openstack-sdks | 09:01 | |
*** dulek has joined #openstack-sdks | 09:07 | |
openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk stable/train: Consistent normalization of Machine objects in the cloud layer https://review.opendev.org/712295 | 09:28 |
*** Blinkiz has quit IRC | 10:15 | |
*** Blinkiz has joined #openstack-sdks | 10:16 | |
-openstackstatus- NOTICE: The mail server for lists.openstack.org is currently not handling emails. The infra team will investigate and fix during US morning. | 10:27 | |
openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Fix microversion negotiation in some bare metal node call https://review.opendev.org/712336 | 10:32 |
dtantsur | sshnaidm: this ^^^ is probably your issue | 10:32 |
dtantsur | testing appreciated | 10:33 |
dtantsur | (this approves that microversion negotiation is hard.. even I do it wrong all the time) | 10:39 |
dtantsur | * proves | 10:39 |
dtantsur | mordred: I have a feeling we're somehow running master tests on train Oo see the ironic job https://review.opendev.org/#/c/712295/1 | 11:05 |
dtantsur | rpittau: do you have a follow-up for the 'retired' functional tests? | 11:05 |
dtantsur | we somehow end up failing them on train (because the feature is not there) | 11:06 |
rpittau | dtantsur: yes https://review.opendev.org/711958 | 11:06 |
rpittau | mmm | 11:06 |
dtantsur | cool, +A | 11:06 |
dtantsur | rpittau: oh, sorry, there is an issue there, could you check? | 11:08 |
rpittau | sure | 11:08 |
dtantsur | you end up duplicating all tests because of inheritance | 11:08 |
openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Set min version to test node retirement https://review.opendev.org/711958 | 11:10 |
openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Set min version to test node retirement https://review.opendev.org/711958 | 11:10 |
openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Fix microversion negotiation in some bare metal node call https://review.opendev.org/712336 | 11:50 |
*** rpittau is now known as rpittau|bbl | 11:58 | |
*** enriquetaso has joined #openstack-sdks | 12:06 | |
*** sshnaidm is now known as sshnaidm|afk | 12:10 | |
*** jpena is now known as jpena|lunch | 12:22 | |
*** jpena|lunch is now known as jpena | 13:01 | |
*** camelCaser has quit IRC | 13:04 | |
*** camelCaser has joined #openstack-sdks | 13:06 | |
*** irclogbot_0 has quit IRC | 13:22 | |
*** irclogbot_2 has joined #openstack-sdks | 13:23 | |
*** BakaKuna has joined #openstack-sdks | 13:27 | |
*** dave-mccowan has joined #openstack-sdks | 13:42 | |
*** dave-mccowan has quit IRC | 13:46 | |
*** zigo has quit IRC | 13:49 | |
openstackgerrit | Merged openstack/openstacksdk master: Set min version to test node retirement https://review.opendev.org/711958 | 13:49 |
dtantsur | mordred: when you have a minute: https://review.opendev.org/#/c/712336/ | 13:51 |
*** jpich has quit IRC | 13:51 | |
*** jpich has joined #openstack-sdks | 13:51 | |
*** dave-mccowan has joined #openstack-sdks | 13:57 | |
mordred | dtantsur: oy. | 14:15 |
mordred | dtantsur: microversion negotiation is hard | 14:24 |
dtantsur | it is indeed.. | 14:24 |
smcginnis | It would be great if OSC supported microversions. :P | 14:25 |
dtantsur | first, we need to agree on the default behavior.. | 14:33 |
*** sshnaidm|afk is now known as sshnaidm | 14:37 | |
mordred | smcginnis: it does support microversion | 15:19 |
mordred | microversions | 15:19 |
mordred | dtantsur: I agree we need to agree on the default behavior. I'd like to argue that osc's default behavior should match SDK's- which is that it should negotiate for the most recent microversion it can handle for a given command | 15:24 |
mordred | this is a little self-serving of course - since the long-term plan is to port osc on top of sdk - one would imagine that at that point osc's microversion behavior would be delegated to sdk anyway - so it would be good if porting to sdk didn't produce a behavior change | 15:24 |
smcginnis | mordred: I should have put <sarcasm/> tags on there. ;) | 15:25 |
mordred | smcginnis: :) | 15:26 |
mordred | that said - the current OSC behavior if you try something like compute_api_version: 2.latest is ridiculous | 15:27 |
mordred | but that's going to be because it just defers to novaclient and novaclient's behavior in that case is ridiculous | 15:27 |
smcginnis | I pushed back on that approach in cinder. | 15:28 |
mordred | well - the bad behavior here is that 2.latest is just an alias for "2.$whatever_the_highest_Version_hardcoded_into_novaclient_is" ... and is _not_ "2.please_negotiate_for_the_latest_available_version" | 15:30 |
mordred | so if you set 2.latest and then run opensatck server list against vexxhost, you get: clean_up ListServer: Version 2.81 is not supported by the API. Minimum is 2.1 and maximum is 2.60. (HTTP 406) (Request-ID: req-d368c068-4e37-448c-8e25-74e4aa0385a9) | 15:30 |
mordred | rather than just getting interactions at 2.60 | 15:30 |
*** BakaKuna has quit IRC | 15:31 | |
mordred | dtantsur: ooh. I think I just had an epiphany of how to support 2.latest in sdk safely | 15:48 |
mordred | WIP patch coming | 15:48 |
dtantsur | nice! | 15:52 |
dtantsur | I think in ironic OSC plugin we treat 1 like 1.latest and support it in the correct sense.. | 15:52 |
*** dtantsur is now known as dtantsur|brb | 15:53 | |
smcginnis | Yeah, couldn't OSC do the negotiation to figure out the highest? | 15:53 |
*** zigo has joined #openstack-sdks | 15:53 | |
openstackgerrit | Merged openstack/openstacksdk master: Fix microversion negotiation in some bare metal node call https://review.opendev.org/712336 | 15:57 |
mordred | smcginnis: sort of - the problem is that if you just do straight latest then a new microversion can come and break you | 16:02 |
mordred | because there is additional processing of resources returned | 16:02 |
mordred | smcginnis: which is why what you _really_ want is "negotiate for the latest the client understands" (which is the power of microversions in the first place) | 16:03 |
mordred | in practice, if we start pro-actively adding support for a service's microversion as part of adding the new whatever to the server API | 16:04 |
mordred | this should have the result people are looking for and remain safe | 16:04 |
*** ricolin has quit IRC | 16:25 | |
*** rpittau|bbl is now known as rpittau | 16:43 | |
*** ricolin has joined #openstack-sdks | 17:01 | |
*** evrardjp has quit IRC | 17:35 | |
*** evrardjp has joined #openstack-sdks | 17:35 | |
*** jpich has quit IRC | 17:44 | |
*** jpena is now known as jpena|off | 17:57 | |
*** sshnaidm is now known as sshnaidm|afk | 18:04 | |
*** dtantsur|brb is now known as dtantsur | 18:24 | |
yoctozepto | mordred: may I get your attention on https://review.opendev.org/711492 ? it seems I "fixed" devstack enough to provide what sdk requires, yet it does not accept the 'example' key config | 18:33 |
mordred | yoctozepto: looking | 18:39 |
mordred | yoctozepto: https://zuul.opendev.org/t/openstack/build/d28bf0dd977942f4ac7b6331bce2ccd8/log/controller/logs/etc/openstack/clouds.yaml#23-24 | 18:48 |
mordred | yoctozepto: that's not in the right place | 18:48 |
mordred | example should be a top-level config - a sibling of clouds | 18:48 |
mordred | yoctozepto: so it's not a property of the devstack-admin cloud | 18:49 |
yoctozepto | mordred: ack, that makes sense; just notice that 'functional' actually is and sdk docs claim that 'example' should be as well: https://opendev.org/openstack/openstacksdk/src/branch/master/doc/source/contributor/clouds.yaml | 18:50 |
mordred | one sec | 18:51 |
yoctozepto | mordred: feeling confused about the dichotomy | 18:51 |
mordred | yoctozepto: BWAHAHAHA. ok. yeah | 18:51 |
mordred | I think theres totally a bug here - let me propose a patch | 18:51 |
mordred | and ... maybe let's see if we can remove the need for a separate "example" image setting | 18:52 |
yoctozepto | mordred: I'd love that | 18:52 |
openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk stable/train: Fix microversion negotiation in some bare metal node call https://review.opendev.org/712536 | 19:05 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rationalize examples and functional extra config loading https://review.opendev.org/712538 | 19:05 |
mordred | yoctozepto: ^^ | 19:06 |
mordred | yoctozepto: with that, you should be able to stop writing out the example config specially | 19:06 |
mordred | yoctozepto: if that all works, I'd like to change where we're writing the functional config since it's currently just flat wrong :) | 19:06 |
mordred | and thanks - that's a leftover mess from the merge | 19:06 |
yoctozepto | mordred: quickie - the patch I mentioned modifies devstack to use this config at all, I based it off the docs and got functional working | 19:08 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rationalize examples and functional extra config loading https://review.opendev.org/712538 | 19:08 |
yoctozepto | mordred: you can go ahead and do it the best way you want | 19:08 |
yoctozepto | mordred: devstack won't break :-) | 19:08 |
yoctozepto | mordred: and I will adapt | 19:09 |
mordred | yoctozepto: :) | 19:09 |
mordred | yoctozepto: awesome - well, let's get it update so that the docs are right and so that we're using an exposed api inside of our own tests in sdk | 19:09 |
mordred | because we _do_ use get_extra_config in other places - so it's a real way to pass this information | 19:09 |
mordred | I don't know why we weren't using it in functional/base - nor why the examples docs were wrong even though the examples code WAS doing the right thing | 19:10 |
yoctozepto | mordred: ok, then just ditch the 'functional' difference | 19:10 |
mordred | yeah - we'll drive everything in the functional tests with the functional entry | 19:11 |
mordred | then we can fix the location of the functional entry later in the file as a followup | 19:11 |
yoctozepto | mordred: sure, let me know when you have your final change on sdk side and I'll base the devstack part accordingly | 19:12 |
mordred | yoctozepto: OH - duh | 19:19 |
*** adriant has quit IRC | 19:20 | |
mordred | yoctozepto: I just realized you're adding both functional AND example in that change | 19:20 |
*** iokiwi has quit IRC | 19:20 | |
mordred | yoctozepto: let me make my change the correct/simple version - no need to continue to work with the thing that doesn't exist | 19:20 |
yoctozepto | mordred: yeah, I tried to tell you that | 19:22 |
yoctozepto | mordred: also found breakage in your patch, commented | 19:22 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rationalize examples and functional extra config loading https://review.opendev.org/712538 | 19:24 |
mordred | yoctozepto: thanks - yes you are right with your comment :) - and yes you did - I just didn't quite follow it in my brainhole | 19:24 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rationalize examples and functional extra config loading https://review.opendev.org/712538 | 19:25 |
mordred | yoctozepto: I think that one should be good | 19:25 |
yoctozepto | mordred: no problem, one more comment | 19:28 |
*** diablo_rojo has joined #openstack-sdks | 19:30 | |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rationalize examples and functional extra config loading https://review.opendev.org/712538 | 19:35 |
mordred | yoctozepto: good catch | 19:35 |
*** adriant has joined #openstack-sdks | 19:39 | |
*** rpittau is now known as rpittau|afk | 19:40 | |
*** dtantsur is now known as dtantsur|afk | 19:40 | |
yoctozepto | mordred: thanks, now +1 :-) | 19:44 |
*** ralonsoh has quit IRC | 19:44 | |
mordred | woot! | 19:47 |
mordred | Shrews: ^^ does that have any impact we should consider on nodepool | 19:47 |
Shrews | mordred: i want to say "no" | 19:48 |
mordred | Shrews: me too | 19:49 |
yoctozepto | mordred: hahaha, sorry to inform you about another bug in there | 19:49 |
mordred | yoctozepto: yay! | 19:49 |
*** BakaKuna has joined #openstack-sdks | 19:49 | |
mordred | yoctozepto: haha | 19:49 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rationalize examples and functional extra config loading https://review.opendev.org/712538 | 19:49 |
yoctozepto | mordred: fingers crossed now | 19:51 |
yoctozepto | mordred: https://review.opendev.org/711492 testing devstack for overall happiness | 19:52 |
*** slaweq has quit IRC | 19:53 | |
mordred | cool! fingers crossed as well | 19:54 |
yoctozepto | mordred: now that I got one of your eyes on sdk tests fixing, may I have your other eye on http://lists.openstack.org/pipermail/openstack-discuss/2020-March/013213.html ? | 19:54 |
mordred | yoctozepto: hrm. | 19:54 |
*** BakaKuna has quit IRC | 20:18 | |
yoctozepto | mordred: will I spoil it much if I tell you that was not exactly the answer I was expecting? ;D | 20:27 |
yoctozepto | also, unfortunately, still something wrong with that patch, commented there | 20:29 |
mordred | yoctozepto: no - I was pretty sure you would not enjoy that answer - I'm mulling a better one | 20:36 |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rationalize examples and functional extra config loading https://review.opendev.org/712538 | 20:38 |
umbSublime | heh, I was about to ask if the sdks config supported adding arbitrary sections to clouds.yaml. TIL \o/ | 21:27 |
mordred | umbSublime: :) | 21:32 |
*** enriquetaso has quit IRC | 21:37 | |
*** enriquetaso has joined #openstack-sdks | 21:37 | |
*** dave-mccowan has quit IRC | 22:05 | |
*** dave-mccowan has joined #openstack-sdks | 22:13 | |
openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rationalize examples and functional extra config loading https://review.opendev.org/712538 | 22:26 |
*** enriquetaso has quit IRC | 22:27 | |
*** amito has quit IRC | 22:31 | |
*** Shrews has quit IRC | 22:31 | |
*** gundalow has quit IRC | 22:31 | |
*** vishakha has quit IRC | 22:31 | |
*** dustinc has quit IRC | 22:31 | |
*** rm_work has quit IRC | 22:31 | |
*** rm_work has joined #openstack-sdks | 22:33 | |
*** amito has joined #openstack-sdks | 22:34 | |
*** gundalow has joined #openstack-sdks | 22:35 | |
*** guilhermesp has quit IRC | 22:36 | |
*** mnaser has quit IRC | 22:36 | |
*** gmann has quit IRC | 22:36 | |
*** vkmc has quit IRC | 22:36 | |
*** fyx has quit IRC | 22:36 | |
*** fyx has joined #openstack-sdks | 22:38 | |
*** mnaser has joined #openstack-sdks | 22:39 | |
*** vkmc has joined #openstack-sdks | 22:39 | |
*** Shrews has joined #openstack-sdks | 22:40 | |
*** dustinc has joined #openstack-sdks | 22:40 | |
*** gmann has joined #openstack-sdks | 22:40 | |
*** guilhermesp has joined #openstack-sdks | 22:41 | |
*** irclogbot_2 has quit IRC | 22:47 | |
*** irclogbot_2 has joined #openstack-sdks | 22:48 | |
*** openstackstatus has quit IRC | 22:48 | |
*** mnasiadka has quit IRC | 22:50 | |
*** mnasiadka has joined #openstack-sdks | 22:54 | |
*** knikolla has quit IRC | 22:56 | |
*** lxkong has quit IRC | 22:56 | |
*** knikolla has joined #openstack-sdks | 23:01 | |
*** tkajinam has joined #openstack-sdks | 23:01 | |
*** lxkong has joined #openstack-sdks | 23:02 | |
*** dave-mccowan has quit IRC | 23:08 | |
*** dave-mccowan has joined #openstack-sdks | 23:10 | |
*** tosky has quit IRC | 23:44 | |
*** KeithMnemonic has quit IRC | 23:51 | |
*** KeithMnemonic has joined #openstack-sdks | 23:51 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!