Wednesday, 2020-03-11

*** tosky has quit IRC00:28
*** enriquetaso has quit IRC00:56
*** iurygregory has quit IRC01:17
*** dmellado has quit IRC01:22
*** dmellado has joined #openstack-sdks01:46
*** camelCaser has quit IRC03:01
*** ricolin_ has joined #openstack-sdks03:01
*** camelCaser has joined #openstack-sdks03:02
*** ricolin_ has quit IRC03:38
*** ricolin has quit IRC04:44
*** evrardjp has quit IRC05:35
*** evrardjp has joined #openstack-sdks05:35
*** ricolin has joined #openstack-sdks05:51
*** sshnaidm|afk is now known as sshnaidm07:16
openstackgerritBram Verschueren proposed openstack/openstacksdk master: Add support for additional volume backup options  https://review.opendev.org/68835307:17
*** iurygregory has joined #openstack-sdks07:29
*** __ministry has quit IRC07:57
*** __ministry1 has joined #openstack-sdks07:57
*** __ministry1 is now known as __ministry07:59
*** slaweq has joined #openstack-sdks08:03
*** tkajinam has quit IRC08:14
*** tosky has joined #openstack-sdks08:28
*** gkadam has joined #openstack-sdks08:34
*** gkadam has quit IRC08:34
*** ralonsoh has joined #openstack-sdks08:47
*** gouthamr has quit IRC08:49
*** mgoddard has quit IRC08:49
*** dulek has quit IRC08:49
*** gouthamr has joined #openstack-sdks08:50
*** mgoddard has joined #openstack-sdks08:50
*** jpena|off is now known as jpena08:52
*** dtantsur|afk is now known as dtantsur08:56
*** rpittau|afk is now known as rpittau08:58
*** jpich has joined #openstack-sdks09:01
*** dulek has joined #openstack-sdks09:07
openstackgerritDmitry Tantsur proposed openstack/openstacksdk stable/train: Consistent normalization of Machine objects in the cloud layer  https://review.opendev.org/71229509:28
*** Blinkiz has quit IRC10:15
*** Blinkiz has joined #openstack-sdks10:16
-openstackstatus- NOTICE: The mail server for lists.openstack.org is currently not handling emails. The infra team will investigate and fix during US morning.10:27
openstackgerritDmitry Tantsur proposed openstack/openstacksdk master: Fix microversion negotiation in some bare metal node call  https://review.opendev.org/71233610:32
dtantsursshnaidm: this ^^^ is probably your issue10:32
dtantsurtesting appreciated10:33
dtantsur(this approves that microversion negotiation is hard.. even I do it wrong all the time)10:39
dtantsur* proves10:39
dtantsurmordred: I have a feeling we're somehow running master tests on train Oo see the ironic job https://review.opendev.org/#/c/712295/111:05
dtantsurrpittau: do you have a follow-up for the 'retired' functional tests?11:05
dtantsurwe somehow end up failing them on train (because the feature is not there)11:06
rpittaudtantsur: yes https://review.opendev.org/71195811:06
rpittaummm11:06
dtantsurcool, +A11:06
dtantsurrpittau: oh, sorry, there is an issue there, could you check?11:08
rpittausure11:08
dtantsuryou end up duplicating all tests because of inheritance11:08
openstackgerritRiccardo Pittau proposed openstack/openstacksdk master: Set min version to test node retirement  https://review.opendev.org/71195811:10
openstackgerritRiccardo Pittau proposed openstack/openstacksdk master: Set min version to test node retirement  https://review.opendev.org/71195811:10
openstackgerritDmitry Tantsur proposed openstack/openstacksdk master: Fix microversion negotiation in some bare metal node call  https://review.opendev.org/71233611:50
*** rpittau is now known as rpittau|bbl11:58
*** enriquetaso has joined #openstack-sdks12:06
*** sshnaidm is now known as sshnaidm|afk12:10
*** jpena is now known as jpena|lunch12:22
*** jpena|lunch is now known as jpena13:01
*** camelCaser has quit IRC13:04
*** camelCaser has joined #openstack-sdks13:06
*** irclogbot_0 has quit IRC13:22
*** irclogbot_2 has joined #openstack-sdks13:23
*** BakaKuna has joined #openstack-sdks13:27
*** dave-mccowan has joined #openstack-sdks13:42
*** dave-mccowan has quit IRC13:46
*** zigo has quit IRC13:49
openstackgerritMerged openstack/openstacksdk master: Set min version to test node retirement  https://review.opendev.org/71195813:49
dtantsurmordred: when you have a minute: https://review.opendev.org/#/c/712336/13:51
*** jpich has quit IRC13:51
*** jpich has joined #openstack-sdks13:51
*** dave-mccowan has joined #openstack-sdks13:57
mordreddtantsur: oy.14:15
mordreddtantsur: microversion negotiation is hard14:24
dtantsurit is indeed..14:24
smcginnisIt would be great if OSC supported microversions. :P14:25
dtantsurfirst, we need to agree on the default behavior..14:33
*** sshnaidm|afk is now known as sshnaidm14:37
mordredsmcginnis: it does support microversion15:19
mordredmicroversions15:19
mordreddtantsur: I agree we need to agree on the default behavior. I'd like to argue that osc's default behavior should match SDK's- which is that it should negotiate for the most recent microversion it can handle for a given command15:24
mordredthis is a little self-serving of course - since the long-term plan is to port osc on top of sdk - one would imagine that at that point osc's microversion behavior would be delegated to sdk anyway - so it would be good if porting to sdk didn't produce a behavior change15:24
smcginnismordred: I should have put <sarcasm/> tags on there. ;)15:25
mordredsmcginnis:  :)15:26
mordredthat said - the current OSC behavior if you try something like compute_api_version: 2.latest is ridiculous15:27
mordredbut that's going to be because it just defers to novaclient and novaclient's behavior in that case is ridiculous15:27
smcginnisI pushed back on that approach in cinder.15:28
mordredwell - the bad behavior here is that 2.latest is just an alias for "2.$whatever_the_highest_Version_hardcoded_into_novaclient_is" ... and is _not_ "2.please_negotiate_for_the_latest_available_version"15:30
mordredso if you set 2.latest and then run opensatck server list against vexxhost, you get: clean_up ListServer: Version 2.81 is not supported by the API. Minimum is 2.1 and maximum is 2.60. (HTTP 406) (Request-ID: req-d368c068-4e37-448c-8e25-74e4aa0385a9)15:30
mordredrather than just getting interactions at 2.6015:30
*** BakaKuna has quit IRC15:31
mordreddtantsur: ooh. I think I just had an epiphany of how to support 2.latest in sdk safely15:48
mordredWIP patch coming15:48
dtantsurnice!15:52
dtantsurI think in ironic OSC plugin we treat 1 like 1.latest and support it in the correct sense..15:52
*** dtantsur is now known as dtantsur|brb15:53
smcginnisYeah, couldn't OSC do the negotiation to figure out the highest?15:53
*** zigo has joined #openstack-sdks15:53
openstackgerritMerged openstack/openstacksdk master: Fix microversion negotiation in some bare metal node call  https://review.opendev.org/71233615:57
mordredsmcginnis: sort of - the problem is that if you just do straight latest then a new microversion can come and break you16:02
mordredbecause there is additional processing of resources returned16:02
mordredsmcginnis: which is why what you _really_ want is "negotiate for the latest the client understands" (which is the power of microversions in the first place)16:03
mordredin practice, if we start pro-actively adding support for a service's microversion as part of adding the new whatever to the server API16:04
mordredthis should have the result people are looking for and remain safe16:04
*** ricolin has quit IRC16:25
*** rpittau|bbl is now known as rpittau16:43
*** ricolin has joined #openstack-sdks17:01
*** evrardjp has quit IRC17:35
*** evrardjp has joined #openstack-sdks17:35
*** jpich has quit IRC17:44
*** jpena is now known as jpena|off17:57
*** sshnaidm is now known as sshnaidm|afk18:04
*** dtantsur|brb is now known as dtantsur18:24
yoctozeptomordred: may I get your attention on https://review.opendev.org/711492 ? it seems I "fixed" devstack enough to provide what sdk requires, yet it does not accept the 'example' key config18:33
mordredyoctozepto: looking18:39
mordredyoctozepto: https://zuul.opendev.org/t/openstack/build/d28bf0dd977942f4ac7b6331bce2ccd8/log/controller/logs/etc/openstack/clouds.yaml#23-2418:48
mordredyoctozepto: that's not in the right place18:48
mordredexample should be a top-level config - a sibling of clouds18:48
mordredyoctozepto: so it's not a property of the devstack-admin cloud18:49
yoctozeptomordred: ack, that makes sense; just notice that 'functional' actually is and sdk docs claim that 'example' should be as well: https://opendev.org/openstack/openstacksdk/src/branch/master/doc/source/contributor/clouds.yaml18:50
mordredone sec18:51
yoctozeptomordred: feeling confused about the dichotomy18:51
mordredyoctozepto: BWAHAHAHA. ok. yeah18:51
mordredI think theres totally a bug here - let me propose a patch18:51
mordredand ... maybe let's see if we can remove the need for a separate "example" image setting18:52
yoctozeptomordred: I'd love that18:52
openstackgerritDmitry Tantsur proposed openstack/openstacksdk stable/train: Fix microversion negotiation in some bare metal node call  https://review.opendev.org/71253619:05
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Rationalize examples and functional extra config loading  https://review.opendev.org/71253819:05
mordredyoctozepto: ^^19:06
mordredyoctozepto: with that, you should be able to stop writing out the example config specially19:06
mordredyoctozepto: if that all works, I'd like to change where we're writing the functional config since it's currently just flat wrong :)19:06
mordredand thanks - that's a leftover mess from the merge19:06
yoctozeptomordred: quickie - the patch I mentioned modifies devstack to use this config at all, I based it off the docs and got functional working19:08
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Rationalize examples and functional extra config loading  https://review.opendev.org/71253819:08
yoctozeptomordred: you can go ahead and do it the best way you want19:08
yoctozeptomordred: devstack won't break :-)19:08
yoctozeptomordred: and I will adapt19:09
mordredyoctozepto: :)19:09
mordredyoctozepto: awesome - well, let's get it update so that the docs are right and so that we're using an exposed api inside of our own tests in sdk19:09
mordredbecause we _do_ use get_extra_config in other places - so it's a real way to pass this information19:09
mordredI don't know why we weren't using it in functional/base - nor why the examples docs were wrong even though the examples code WAS doing the right thing19:10
yoctozeptomordred: ok, then just ditch the 'functional' difference19:10
mordredyeah - we'll drive everything in the functional tests with the functional entry19:11
mordredthen we can fix the location of the functional entry later in the file as a followup19:11
yoctozeptomordred: sure, let me know when you have your final change on sdk side and I'll base the devstack part accordingly19:12
mordredyoctozepto: OH - duh19:19
*** adriant has quit IRC19:20
mordredyoctozepto: I just realized you're adding both functional AND example in that change19:20
*** iokiwi has quit IRC19:20
mordredyoctozepto: let me make my change the correct/simple version - no need to continue to work with the thing that doesn't exist19:20
yoctozeptomordred: yeah, I tried to tell you that19:22
yoctozeptomordred: also found breakage in your patch, commented19:22
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Rationalize examples and functional extra config loading  https://review.opendev.org/71253819:24
mordredyoctozepto: thanks - yes you are right with your comment :) - and yes you did - I just didn't quite follow it in my brainhole19:24
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Rationalize examples and functional extra config loading  https://review.opendev.org/71253819:25
mordredyoctozepto: I think that one should be good19:25
yoctozeptomordred: no problem, one more comment19:28
*** diablo_rojo has joined #openstack-sdks19:30
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Rationalize examples and functional extra config loading  https://review.opendev.org/71253819:35
mordredyoctozepto: good catch19:35
*** adriant has joined #openstack-sdks19:39
*** rpittau is now known as rpittau|afk19:40
*** dtantsur is now known as dtantsur|afk19:40
yoctozeptomordred: thanks, now +1 :-)19:44
*** ralonsoh has quit IRC19:44
mordredwoot!19:47
mordredShrews: ^^ does that have any impact we should consider on nodepool19:47
Shrewsmordred: i want to say "no"19:48
mordredShrews: me too19:49
yoctozeptomordred: hahaha, sorry to inform you about another bug in there19:49
mordredyoctozepto: yay!19:49
*** BakaKuna has joined #openstack-sdks19:49
mordredyoctozepto: haha19:49
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Rationalize examples and functional extra config loading  https://review.opendev.org/71253819:49
yoctozeptomordred: fingers crossed now19:51
yoctozeptomordred: https://review.opendev.org/711492 testing devstack for overall happiness19:52
*** slaweq has quit IRC19:53
mordredcool! fingers crossed as well19:54
yoctozeptomordred: now that I got one of your eyes on sdk tests fixing, may I have your other eye on http://lists.openstack.org/pipermail/openstack-discuss/2020-March/013213.html ?19:54
mordredyoctozepto: hrm.19:54
*** BakaKuna has quit IRC20:18
yoctozeptomordred: will I spoil it much if I tell you that was not exactly the answer I was expecting? ;D20:27
yoctozeptoalso, unfortunately, still something wrong with that patch, commented there20:29
mordredyoctozepto: no - I was pretty sure you would not enjoy that answer - I'm mulling a better one20:36
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Rationalize examples and functional extra config loading  https://review.opendev.org/71253820:38
umbSublimeheh, I was about to ask if the sdks config supported adding arbitrary sections to clouds.yaml. TIL \o/21:27
mordredumbSublime: :)21:32
*** enriquetaso has quit IRC21:37
*** enriquetaso has joined #openstack-sdks21:37
*** dave-mccowan has quit IRC22:05
*** dave-mccowan has joined #openstack-sdks22:13
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Rationalize examples and functional extra config loading  https://review.opendev.org/71253822:26
*** enriquetaso has quit IRC22:27
*** amito has quit IRC22:31
*** Shrews has quit IRC22:31
*** gundalow has quit IRC22:31
*** vishakha has quit IRC22:31
*** dustinc has quit IRC22:31
*** rm_work has quit IRC22:31
*** rm_work has joined #openstack-sdks22:33
*** amito has joined #openstack-sdks22:34
*** gundalow has joined #openstack-sdks22:35
*** guilhermesp has quit IRC22:36
*** mnaser has quit IRC22:36
*** gmann has quit IRC22:36
*** vkmc has quit IRC22:36
*** fyx has quit IRC22:36
*** fyx has joined #openstack-sdks22:38
*** mnaser has joined #openstack-sdks22:39
*** vkmc has joined #openstack-sdks22:39
*** Shrews has joined #openstack-sdks22:40
*** dustinc has joined #openstack-sdks22:40
*** gmann has joined #openstack-sdks22:40
*** guilhermesp has joined #openstack-sdks22:41
*** irclogbot_2 has quit IRC22:47
*** irclogbot_2 has joined #openstack-sdks22:48
*** openstackstatus has quit IRC22:48
*** mnasiadka has quit IRC22:50
*** mnasiadka has joined #openstack-sdks22:54
*** knikolla has quit IRC22:56
*** lxkong has quit IRC22:56
*** knikolla has joined #openstack-sdks23:01
*** tkajinam has joined #openstack-sdks23:01
*** lxkong has joined #openstack-sdks23:02
*** dave-mccowan has quit IRC23:08
*** dave-mccowan has joined #openstack-sdks23:10
*** tosky has quit IRC23:44
*** KeithMnemonic has quit IRC23:51
*** KeithMnemonic has joined #openstack-sdks23:51

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!