openstackgerrit | Felix Yan proposed openstack/cliff master: Fix compatibility with new cmd2 https://review.opendev.org/712591 | 00:17 |
---|---|---|
*** openstackstatus has joined #openstack-sdks | 00:44 | |
*** ChanServ sets mode: +v openstackstatus | 00:44 | |
*** diablo_rojo has quit IRC | 02:13 | |
*** KeithMnemonic1 has joined #openstack-sdks | 03:28 | |
*** KeithMnemonic has quit IRC | 03:31 | |
*** ricolin_ has joined #openstack-sdks | 03:31 | |
*** ricolin_ has quit IRC | 03:33 | |
*** ricolin_ has joined #openstack-sdks | 03:34 | |
*** dave-mccowan has quit IRC | 03:58 | |
*** KeithMnemonic1 has quit IRC | 04:06 | |
*** tobiash has quit IRC | 04:16 | |
*** tobiash has joined #openstack-sdks | 04:17 | |
*** factor has joined #openstack-sdks | 04:34 | |
*** tobiash has quit IRC | 04:43 | |
*** tobiash has joined #openstack-sdks | 04:46 | |
*** evrardjp has quit IRC | 05:35 | |
*** evrardjp has joined #openstack-sdks | 05:36 | |
*** Luzi has joined #openstack-sdks | 06:02 | |
*** smcginnis has quit IRC | 07:03 | |
*** smcginnis has joined #openstack-sdks | 07:04 | |
*** rpittau|afk is now known as rpittau | 07:17 | |
*** slaweq has joined #openstack-sdks | 08:02 | |
*** tosky has joined #openstack-sdks | 08:18 | |
*** jpena|off is now known as jpena | 08:45 | |
*** jpich has joined #openstack-sdks | 08:47 | |
*** rpittau is now known as rpittau|bbl | 08:52 | |
*** ralonsoh has joined #openstack-sdks | 08:58 | |
*** dtantsur|afk is now known as dtantsur | 09:13 | |
*** sshnaidm|afk is now known as sshnaidm | 09:39 | |
*** gtema has joined #openstack-sdks | 09:49 | |
dtantsur | mordred: morning! when you have a minute, this backport https://review.opendev.org/#/c/712536/ will likely make sshnaidm a bit happier | 09:54 |
sshnaidm | dtantsur, thanks! | 09:55 |
sshnaidm | dtantsur, btw take a look https://review.opendev.org/#/c/712303/ | 09:57 |
dtantsur | sshnaidm: are you aware of this call? https://docs.openstack.org/openstacksdk/latest/user/proxies/baremetal.html#openstack.baremetal.v1._proxy.Proxy.wait_for_nodes_provision_state | 09:59 |
dtantsur | you seem to be duplicating it | 09:59 |
dtantsur | if you miss something from it, let's update the SDK rather then duplicating the functionality | 10:00 |
sshnaidm | dtantsur, yeah I know this call, but it's blocking, in the module I run all nodes provision in parallel | 10:01 |
dtantsur | sshnaidm: I mean, it's a direct replacement for lines 354-400 | 10:02 |
dtantsur | where you're looping over nodes waiting for them to be finished | 10:02 |
dtantsur | wait_for_nodes_provision_state does exactly that | 10:02 |
dtantsur | I don't suggest you use wait=True on set_node_provision_state | 10:02 |
sshnaidm | dtantsur, a-ha, seems like I missed it can be done for multiple nodes | 10:03 |
dtantsur | yep, I implemented it this way specially for cases like yours :) | 10:03 |
dtantsur | lemme know if anything is missing there, we can update it | 10:03 |
sshnaidm | dtantsur, and in case of failure, does it still return nodes that were provisioned successfully? | 10:04 |
dtantsur | sshnaidm: I'm not sure, but we can implement that | 10:04 |
* dtantsur checks the source code | 10:04 | |
dtantsur | sshnaidm: it raises an exception by default. do you need this functionality? | 10:06 |
sshnaidm | dtantsur, yeah, maybe an option to not raise, but return passed/failed | 10:06 |
sshnaidm | dtantsur, not too critical though | 10:07 |
dtantsur | sshnaidm: I'll look into that. I'd suggest you start without it to avoid these 50 lines of code. | 10:07 |
sshnaidm | dtantsur, yeah, will replace it, thanks | 10:08 |
sshnaidm | dtantsur, also need to figure out if we need one module for "set state" for nodes, right now it's one for provide, and one for cleaning | 10:09 |
sshnaidm | and they have dups of course | 10:09 |
dtantsur | a good question. at the very least, they have different parameters | 10:10 |
openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: [WIP] baremetal: fail-less mode for wait_for_nodes_provision_state https://review.opendev.org/712637 | 10:18 |
dtantsur | sshnaidm: wdyt about this design ^^^? | 10:18 |
openstackgerrit | Igor Malinovskiy proposed openstack/python-openstackclient master: Add 'address_scope' type support to network rbac commands https://review.opendev.org/709124 | 10:23 |
sshnaidm | dtantsur, perfect | 10:24 |
dtantsur | okie, will add tests now | 10:24 |
sshnaidm | dtantsur, cool, thanks | 10:25 |
sshnaidm | dtantsur, after I'm done, we'll need to talk about how to optimize the modules | 10:25 |
dtantsur | totally | 10:25 |
dtantsur | sshnaidm: do we need to schedule a virtual meetup for that? given how less and less likely the PTG is... | 10:26 |
sshnaidm | dtantsur, yeah, I think it's good to do | 10:26 |
sshnaidm | dtantsur, tbh I don't believe ptg will happen in June | 10:26 |
sshnaidm | maybe only virtual one | 10:27 |
*** BakaKuna has joined #openstack-sdks | 10:36 | |
openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: baremetal: fail-less mode for wait_for_nodes_provision_state https://review.opendev.org/712637 | 11:04 |
dtantsur | sshnaidm: the final one (testing welcome) ^^^ | 11:04 |
sshnaidm | dtantsur, ack, will try to test it today | 11:06 |
*** sshnaidm has quit IRC | 11:18 | |
*** sshnaidm has joined #openstack-sdks | 11:19 | |
*** sshnaidm has quit IRC | 11:22 | |
*** sshnaidm has joined #openstack-sdks | 11:30 | |
*** sshnaidm has quit IRC | 11:30 | |
*** gtema has quit IRC | 11:31 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add "fields" parameter to ListSecurityGroup query https://review.opendev.org/710825 | 11:44 |
*** jpena is now known as jpena|lunch | 11:49 | |
*** sshnaidm has joined #openstack-sdks | 11:52 | |
*** sshnaidm has quit IRC | 11:53 | |
*** sshnaidm has joined #openstack-sdks | 11:54 | |
*** enriquetaso has joined #openstack-sdks | 12:09 | |
*** Luzi has quit IRC | 12:10 | |
*** lastmikoi has quit IRC | 12:20 | |
*** lastmikoi has joined #openstack-sdks | 12:25 | |
*** tkajinam has quit IRC | 12:27 | |
*** jpena|lunch is now known as jpena | 12:32 | |
*** rpittau|bbl is now known as rpittau | 13:02 | |
BakaKuna | I'm probably missing something in the documentation, but maybe someone can help. When I try to commit a change on dhcp_agent I get the error that 'AttributeError: 'Session' object has no attribute 'default_microversion'. I have set the microversion in my env variables as OS_NEUTRON_DEFAULT_MICROVERSION=2, but that is not used apparently. | 13:18 |
BakaKuna | 13:18 | |
*** jpich has quit IRC | 13:29 | |
*** jpich has joined #openstack-sdks | 13:30 | |
*** dtantsur is now known as dtantsur|brb | 13:36 | |
openstackgerrit | Jose Castro Leon proposed openstack/python-openstackclient master: Allow os quota list query to filter by project https://review.opendev.org/712678 | 13:46 |
*** jistr is now known as jistr|mtg | 13:59 | |
*** dave-mccowan has joined #openstack-sdks | 14:02 | |
bverschueren | gate tests failed for https://review.opendev.org/#/c/688353/ due to the aggregate functional test, but it is rebased now after the fix and should be fine | 14:07 |
bverschueren | if anyone could have a look ? | 14:07 |
*** dave-mccowan has quit IRC | 14:25 | |
*** dave-mccowan has joined #openstack-sdks | 14:29 | |
mordred | if anyone sees BabaKuna, the env var woudl bs OS_NETWORK_DEFAULT_MICROVERSION | 14:40 |
*** ricolin_ has quit IRC | 14:41 | |
*** ricolin_ has joined #openstack-sdks | 14:41 | |
BakaKuna | mordred: thanks! I'll try that. Have to go work at home now. | 14:42 |
mordred | BakaKuna: cool - let me know if it still doens;'t work | 14:43 |
mordred | oh - also - "2" isn't a microversion | 14:43 |
mordred | slaweq: does neutron have microversions now? | 14:45 |
*** ricolin_ has quit IRC | 14:48 | |
*** BakaKuna has quit IRC | 14:48 | |
bverschueren | thanks mordred smcginnis ! | 14:48 |
mordred | dtantsur|brb: if we were to do an SDK v2 (hahaha assuming we ever tag a v1) - I'd totally have methods return a Future if wait wasn't true | 14:54 |
mordred | dtantsur|brb: or even just have two methods - one that is wait=False that returns a future and one that is wait=True which calls the first and does the wait and returns the object | 14:55 |
*** bverschueren has quit IRC | 14:58 | |
*** enriquetaso has quit IRC | 15:02 | |
*** enriquetaso has joined #openstack-sdks | 15:02 | |
*** bverschueren has joined #openstack-sdks | 15:03 | |
openstackgerrit | Igor Malinovskiy proposed openstack/python-openstackclient master: Add 'subnetpool' type support to rbac commands https://review.opendev.org/712705 | 15:07 |
*** jistr|mtg is now known as jistr | 15:33 | |
slaweq | mordred: hi, nope | 15:39 |
slaweq | mordred: we still have only those API extensions | 15:39 |
slaweq | amotoki was going to propose some spec about microversions for extensions but I don't think he worked on it recently | 15:39 |
mordred | slaweq: ok. so does BakaKuna's question above make any sense? | 15:42 |
slaweq | mordred: TBH it looks more like some bug in SDK code | 15:46 |
mordred | yay | 15:47 |
noonedeadpunk | hi everyone. Need some help to understand how CLI commands are "routed". Like `openstack image add project` | 15:50 |
noonedeadpunk | I kinda feel that there's some "bug" there but can't really find "entry point" | 15:51 |
noonedeadpunk | It looks like https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v2/image_members.py#L55-L60 but can't find how it's called | 15:52 |
noonedeadpunk | The thing is that I suggest, that while searching for member_id there's exception handling missing | 15:53 |
noonedeadpunk | so while doing `openstack project list` error handling is preset like http://paste.openstack.org/show/790616/ | 15:55 |
*** dtantsur|brb is now known as dtantsur | 15:56 | |
noonedeadpunk | but `openstack image add project` ends up that way: http://paste.openstack.org/show/790617/ | 15:57 |
dtantsur | mordred: good idea. let's live to see v1 first :) | 15:57 |
*** diablo_rojo has joined #openstack-sdks | 15:58 | |
elmiko | API SIG office hour now open \o/ | 16:00 |
mordred | noonedeadpunk: look in setup.cfg at the entrypoints | 16:00 |
mordred | noonedeadpunk: you'll see one called "image" - which will point you in the right direction to start tracing | 16:00 |
mordred | noonedeadpunk: I'm sorry - you'll find one called "image_add_project" | 16:01 |
noonedeadpunk | mordred: oh, nice! thanks | 16:02 |
mordred | noonedeadpunk: we just recently landed the patch to replace the calls to glanceclient with calls to sdk - but I don't think I've cut a release with that code yet | 16:02 |
mordred | noonedeadpunk: so you might want to start with trying to see how it goes with the code in master since it's RADICALLY different for image | 16:03 |
noonedeadpunk | mordred: so do you suggest trying out master version before futher investigation? | 16:03 |
mordred | yup | 16:03 |
noonedeadpunk | yeah, ok | 16:03 |
dtantsur | o/ | 16:04 |
mordred | oh - actually | 16:05 |
noonedeadpunk | tbh, image_add_project & image_member_list & image_remove_project pretty confising, because they point to the same api path, but are so different for CLI.... is there alias support? Like, can be `image_member_add` safely added for deprecating older one later? | 16:05 |
mordred | noonedeadpunk: those aren't landed yet - https://review.opendev.org/#/c/699416/ ... you might want to grab that change and try with that | 16:05 |
noonedeadpunk | mordred: oh, thanks ffor providing patch:) | 16:06 |
*** diablo_rojo has quit IRC | 16:06 | |
*** diablo_rojo has joined #openstack-sdks | 16:10 | |
noonedeadpunk | patch do not resolve issue, infortunatelly | 16:11 |
mordred | ok. well - good to know at least | 16:11 |
mordred | noonedeadpunk: if you find a fix - do it on top of that stack - just so we don't hit weird merge conflicts | 16:11 |
noonedeadpunk | yes, sure:) | 16:12 |
openstackgerrit | Merged openstack/openstacksdk master: Add support for additional volume backup options https://review.opendev.org/688353 | 16:21 |
elmiko | dtantsur: given the consolidation efforts that have been discussed recently, and the low traffic of sig-api acitivity. i wonder if it's time that we re-evaluate ourselves a little? or perhaps consider a next phase for the sig, what do you think? | 16:22 |
dtantsur | elmiko: I was actually about to propose us to merge with someone.. SDK? | 16:22 |
dtantsur | because realistically, we're not doing anything except for trolling each other for quite a while :) | 16:23 |
elmiko | right | 16:25 |
elmiko | i think merging into sdk would be great | 16:25 |
elmiko | is there a chair or something we should talk to in the sdk group? | 16:26 |
elmiko | or maybe i should just make an email to discuss ml about this? | 16:26 |
dtantsur | elmiko: well, mordred? | 16:28 |
elmiko | i should probably send an email as well, just to help promote transparency and collaboration for the decision | 16:29 |
dtantsur | yup | 16:30 |
* mordred waves to elmiko | 16:30 | |
dtantsur | mordred: we want to grant you an unlimited access to elmiko, are you happy? | 16:30 |
mordred | YES GOD YES | 16:30 |
*** Blinkiz has quit IRC | 16:30 | |
* dtantsur has found a truly horrible way to convey the information and is very proud of it | 16:30 | |
*** Blinkiz has joined #openstack-sdks | 16:31 | |
mordred | we could fold the api sig docs into the SDK/CLI team- I thnk they're all super useful - but I also agree, the main driving humans of the sig are busy with other parts of their life at this point | 16:32 |
mordred | tl;dr - happy to ingest the stuff so it has a place to exist - also happy to not do that | 16:32 |
elmiko | lol | 16:33 |
elmiko | mordred: i'm happy to help how i can as well, but if my recent track record is any evidence my openstack time is super limited | 16:33 |
elmiko | at the least, i will kick off an email to get this discussion more in the open | 16:33 |
mordred | kk | 16:34 |
dtantsur | in my brain SDK and CLI at least have stakes in the API SIG work | 16:34 |
dtantsur | email++ | 16:34 |
dtantsur | now that we've ensured that mordred is not going to run away screaming | 16:34 |
elmiko | agreed dtantsur, and we have been welcome here for awhile so it seems like a natural merge to me | 16:34 |
elmiko | LOL | 16:34 |
dtantsur | yup | 16:34 |
mordred | basically - this channel is all one big (or maybe not _big_) happy family | 16:35 |
elmiko | \o/ | 16:35 |
mordred | elmiko: just be warned, this is going to mean you're going to become core on sdk and osc as a result | 16:35 |
dtantsur | smaller than it should be, but very happy and welcoming | 16:35 |
dtantsur | here goes The Evin Plan (tm) | 16:35 |
elmiko | mordred: ack, thanks for the warn^H^H^H^H heads up | 16:36 |
amotoki | slaweq: mordred: as slaweq mentioned neutron does not support micro-versioning. I explored a way to microversion in neutron, but per PTG discussion perhaps in Denver we agreed that API extension versioning would be simple and reasonable as microversion in neutron may potentially lead to regression in current neutron behaviors. | 16:37 |
amotoki | I hope I can restore the work on API extension versioning but the horizon PTL and less contributors in horizon steal my time..... :( | 16:37 |
*** enriquetaso has quit IRC | 16:38 | |
mordred | amotoki: I understand these issues | 16:38 |
elmiko | dtantsur, mordred, just sent an email. hopefully it helps get the ball rolling =) | 16:58 |
dtantsur | thanks! | 16:58 |
noonedeadpunk | Am I right, that https://docs.openstack.org/api-ref/identity/v3/?expanded=list-projects-detail,list-projects-for-user-detail#list-projects-for-user is just not present in openstackclient? | 17:04 |
noonedeadpunk | ah, ok, it's used with flag --user | 17:06 |
*** sshnaidm is now known as sshnaidm|afk | 17:07 | |
*** rpittau is now known as rpittau|afk | 17:27 | |
*** jpich has quit IRC | 17:28 | |
*** dtantsur is now known as dtantsur|afk | 17:34 | |
*** evrardjp has quit IRC | 17:35 | |
*** evrardjp has joined #openstack-sdks | 17:36 | |
noonedeadpunk | them most sad part with glance memer is that glanceclient itself works:( http://paste.openstack.org/show/790619/ | 17:37 |
noonedeadpunk | and things are so because of the way how find_resource is designed.... | 17:39 |
*** ralonsoh has quit IRC | 18:29 | |
openstackgerrit | Dmitriy Rabotyagov (noonedeadpunk) proposed openstack/python-openstackclient master: Fix excpected exception for find_identity_resource https://review.opendev.org/712764 | 18:36 |
*** LarsErikP has left #openstack-sdks | 18:37 | |
*** jpena is now known as jpena|off | 18:51 | |
*** gmann is now known as gmann_lunch | 19:00 | |
*** BakaKuna has joined #openstack-sdks | 19:37 | |
*** gmann_lunch is now known as gmann | 20:01 | |
openstackgerrit | Merged openstack/openstacksdk stable/train: Fix microversion negotiation in some bare metal node call https://review.opendev.org/712536 | 20:14 |
mordred | noonedeadpunk: I think we can fix that | 20:15 |
umbSublime | Hey I'm trying to see if maybe the osc-lib or sdk has something equivalent to novaclient.utils.flatten_dict or keystone.common.utils.flatten_dict I can't find a method with name flatten_dict, but maybe the name was just refactored | 21:06 |
openstackgerrit | Merged openstack/openstacksdk master: Rationalize examples and functional extra config loading https://review.opendev.org/712538 | 21:15 |
*** enriquetaso has joined #openstack-sdks | 21:28 | |
umbSublime | I know it's only like 10L of code, but it's quite useful, but maybe it would have it's place in cliff instead of osc/sdk | 21:29 |
*** BakaKuna has quit IRC | 21:32 | |
*** enriquetaso has quit IRC | 21:32 | |
*** senrique_ has joined #openstack-sdks | 21:32 | |
*** senrique_ has quit IRC | 21:38 | |
*** factor has quit IRC | 22:27 | |
*** slaweq has quit IRC | 22:28 | |
mordred | umbSublime: sorry - don't know of anything like it | 22:28 |
mordred | noonedeadpunk: oh - wow. that's ... | 22:28 |
mordred | what? | 22:28 |
mordred | noonedeadpunk: your fix is showing a slightly deeper issue | 22:29 |
*** slaweq has joined #openstack-sdks | 22:40 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Don't look up project by id if given id https://review.opendev.org/712810 | 22:42 |
mordred | noonedeadpunk, mnaser: ^^ try that | 22:42 |
mordred | the other thing is a rabbit hole - and one that we need to go down - but it'll take me a couple of seconds to even write down what is broken there and what needs to be fixed | 22:43 |
mordred | the good news is that I dont think fixing it is going to be super HARD - it just needs to be done in a few places all at once | 22:43 |
*** slaweq has quit IRC | 22:44 | |
openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Optimize adding project to image slightly more https://review.opendev.org/712813 | 22:48 |
*** dave-mccowan has quit IRC | 22:50 | |
*** tkajinam has joined #openstack-sdks | 22:56 | |
*** dave-mccowan has joined #openstack-sdks | 23:10 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!